Bug#506419: Driver from Supermicro fixes issue
tags 506419 -patch
thanks
On Tue, Dec 09, 2008 at 11:54:03AM +0100, martin f krafft wrote:
> The attached patch against linux-2.6 2.6.26-11 seems to fix the
> original problem for me, but I have not had a chance to verify the
> second ('downstream') problem I identified in the bug report.
This is no patch which suffice our guidelines. Please show submittions
to the Linux maintainers and/or commit ids.
Bastian
--
There's coffee in that nebula!
-- Capt. Kathryn Janeway, Star Trek: Voyager, "The Cloud"
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#506419: Driver from Supermicro fixes issue
also sprach Bastian Blank <[EMAIL PROTECTED]> [2008.12.09.1211 +0100]: > This is no patch which suffice our guidelines. Please show > submittions to the Linux maintainers and/or commit ids. As stated in my message, I don't have the time to do this right now, but I will try to get Transtec/Supermicro to push this stuff into the kernel. It's still a patch. I don't mind if you remove the patch tag, but it might still be useful to some people. I, for one, don't expect this to be fixed for lenny, or even any time soon, unfortunately. Cheers, -- .''`. martin f. krafft <[EMAIL PROTECTED]> Related projects: : :' : proud Debian developer http://debiansystem.info `. `'` http://people.debian.org/~madduckhttp://vcs-pkg.org `- Debian - when you have better things to do than fixing systems digital_signature_gpg.asc Description: Digital signature (see http://martin-krafft.net/gpg/)
Bug#506419: Driver from Supermicro fixes issue
martin f krafft <[EMAIL PROTECTED]> writes:
> The attached patch against linux-2.6 2.6.26-11 seems to fix the
> original problem for me, but I have not had a chance to verify the
> second ('downstream') problem I identified in the bug report.
>
> The patch is based on the driver source I obtained via Transtec from
> Supermicro, the board manufacturer. It's quite ugly and big and
> I don't have the time to dissect it right now, but if you want me to
> try out particulars, I will.
Hmm, this part of your patch looks a lot like half of
edcfe5f7e307846e578fb88d69fa27051fded0ab which Bastian already has
pointed you to:
> @@ -5417,11 +6978,15 @@ static int __devinit nv_probe(struct pci_dev
> *pci_dev, const struct pci_device_i
> if (id->driver_data & DEV_HAS_LARGEDESC)
> np->pkt_limit = NV_PKTLIMIT_2;
>
> + dev->mtu = ETH_DATA_LEN;
> +
> if (id->driver_data & DEV_HAS_CHECKSUM) {
> np->rx_csum = 1;
> np->txrxctl_bits |= NVREG_TXRXCTL_RXCHECK;
> - dev->features |= NETIF_F_HW_CSUM | NETIF_F_SG;
> + dev->features |= NETIF_F_IP_CSUM|NETIF_F_SG;
> +#ifdef NETIF_F_TSO
> dev->features |= NETIF_F_TSO;
> +#endif
> }
>
> np->vlanctl_bits = 0;
This should not apply against linux-2.6 2.6.26-11 since it is already a
part of debian/patches/bugfix/all/stable/2.6.26.4.patch. Are you sure
your patch really does apply? If it does, then I'd suggest trying
*just* edcfe5f7e307846e578fb88d69fa27051fded0ab instead.
BTW, I also noticed that linux-2.6 2.6.26-11 includes the patch
linux-2.6-2.6.26/debian/patches/features/all/net-use-gso.patch
which very well may trigger the problem. You might also want to try
building without that patch.
In fact, I'm a little confused as to the reasons that patch is in
Debian. It is probably the correct thing to do, but it is also the kind
of thing that is bound to cause regressions because it will expose
latent bugs in drivers.
But then again, there's your performance requirements. I guess you'd
better get a proper NIC :-)
Bjørn
--
You have the narrow-mindedness of a disease carrier
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#506419: Driver from Supermicro fixes issue
On Tue, Dec 09, 2008 at 02:13:36PM +0100, Bjørn Mork wrote: > BTW, I also noticed that linux-2.6 2.6.26-11 includes the patch > linux-2.6-2.6.26/debian/patches/features/all/net-use-gso.patch > which very well may trigger the problem. You might also want to try > building without that patch. > > In fact, I'm a little confused as to the reasons that patch is in > Debian. It is probably the correct thing to do, but it is also the kind > of thing that is bound to cause regressions because it will expose > latent bugs in drivers. This is in mainline: e5a4a72d4f88f4389e9340d383ca67031d1b8536. I don't know what the rationale was to add this. Bastian -- I'm frequently appalled by the low regard you Earthmen have for life. -- Spock, "The Galileo Seven", stardate 2822.3 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#506419: Driver from Supermicro fixes issue
also sprach Bjørn Mork <[EMAIL PROTECTED]> [2008.12.09.1413 +0100]: > This should not apply against linux-2.6 2.6.26-11 since it is already a > part of debian/patches/bugfix/all/stable/2.6.26.4.patch. Are you sure > your patch really does apply? If it does, then I'd suggest trying > *just* edcfe5f7e307846e578fb88d69fa27051fded0ab instead. My patch does no "apply", it was made against 2.6.26-11 -- Supermicro just sent me their forcedeth.c and I made the patch. > BTW, I also noticed that linux-2.6 2.6.26-11 includes the patch > linux-2.6-2.6.26/debian/patches/features/all/net-use-gso.patch > which very well may trigger the problem. You might also want to > try building without that patch. I have not tried -11 on the server, only -8 and -10, which both had the problems. How do I find out when net-use-gso.patch was added? The changelog does not mention it, and I cannot find a repository for the source (there are also no Vcs-* links in the package). > But then again, there's your performance requirements. I guess > you'd better get a proper NIC :-) As soon as I get a second switch port, I will. While I only have one switch port, I have no choice... -- .''`. martin f. krafft <[EMAIL PROTECTED]> Related projects: : :' : proud Debian developer http://debiansystem.info `. `'` http://people.debian.org/~madduckhttp://vcs-pkg.org `- Debian - when you have better things to do than fixing systems digital_signature_gpg.asc Description: Digital signature (see http://martin-krafft.net/gpg/)
Bug#506419: Driver from Supermicro fixes issue
martin f krafft <[EMAIL PROTECTED]> writes: > also sprach Bjørn Mork <[EMAIL PROTECTED]> [2008.12.09.1413 +0100]: >> This should not apply against linux-2.6 2.6.26-11 since it is already a >> part of debian/patches/bugfix/all/stable/2.6.26.4.patch. Are you sure >> your patch really does apply? If it does, then I'd suggest trying >> *just* edcfe5f7e307846e578fb88d69fa27051fded0ab instead. > > My patch does no "apply", it was made against 2.6.26-11 -- > Supermicro just sent me their forcedeth.c and I made the patch. Probably against the unpatched 2.6.26 then? OK, that will explain the similarities. But then the real problem must be something else. Sorry for the confusion. >> BTW, I also noticed that linux-2.6 2.6.26-11 includes the patch >> linux-2.6-2.6.26/debian/patches/features/all/net-use-gso.patch >> which very well may trigger the problem. You might also want to >> try building without that patch. > > I have not tried -11 on the server, only -8 and -10, which both had > the problems. > > How do I find out when net-use-gso.patch was added? The changelog > does not mention it, and I cannot find a repository for the source > (there are also no Vcs-* links in the package). http://packages.debian.org/changelogs/pool/main/l/linux-2.6/linux-2.6_2.6.26-11/changelog#versionversion2.6.26-2 has a * net: use software GSO for SG+CSUM capable netdevices (Lennert Buytenhek) line, which matches the subject in the patch. Bjørn -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#506419: Driver from Supermicro fixes issue
* Bastian Blank <[EMAIL PROTECTED]> [2008-12-09 15:06]: > > In fact, I'm a little confused as to the reasons that patch is in > > Debian. It is probably the correct thing to do, but it is also the kind > > of thing that is bound to cause regressions because it will expose > > latent bugs in drivers. > > This is in mainline: e5a4a72d4f88f4389e9340d383ca67031d1b8536. I don't > know what the rationale was to add this. I added the patch because it leads to better performances with several devices. There was one regression with loopback that got fixed quickly and that patch is also in the Debian package. I'm currently not aware of any regressions caused by the patch, but if there are any, we of course have to remove the patch. -- Martin Michlmayr http://www.cyrius.com/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#506419: Driver from Supermicro fixes issue
also sprach Bjørn Mork <[EMAIL PROTECTED]> [2008.12.09.1758 +0100]: > > My patch does no "apply", it was made against 2.6.26-11 -- > > Supermicro just sent me their forcedeth.c and I made the patch. > > Probably against the unpatched 2.6.26 then? OK, that will explain the > similarities. But then the real problem must be something else. Sorry > for the confusion. No, I made it against 2.6.26-11, for no other reason that it was in Debian unstable at the time, and I had given up hope for targetting lenny before. I'd be happy to create a patch against -10 instead. > > How do I find out when net-use-gso.patch was added? The changelog > > does not mention it, and I cannot find a repository for the source > > (there are also no Vcs-* links in the package). > > http://packages.debian.org/changelogs/pool/main/l/linux-2.6/linux-2.6_2.6.26-11/changelog#versionversion2.6.26-2 > > has a > > * net: use software GSO for SG+CSUM capable netdevices (Lennert Buytenhek) > > line, which matches the subject in the patch. Alright. I admit I didn't look that closely. Isn't there a Git repo for Debian kernels? -- .''`. martin f. krafft <[EMAIL PROTECTED]> Related projects: : :' : proud Debian developer http://debiansystem.info `. `'` http://people.debian.org/~madduckhttp://vcs-pkg.org `- Debian - when you have better things to do than fixing systems "she was rather too intelligent and competent-looking to be considered entirely beautiful, but all the more attractive because of it." -- george spencer-brown, "a lion's teeth" digital_signature_gpg.asc Description: Digital signature (see http://martin-krafft.net/gpg/)
Bug#506419: Driver from Supermicro fixes issue
On Tue, Dec 09, 2008 at 09:57:19PM +0100, martin f krafft wrote: > also sprach Bjørn Mork <[EMAIL PROTECTED]> [2008.12.09.1758 +0100]: > > > My patch does no "apply", it was made against 2.6.26-11 -- > > > Supermicro just sent me their forcedeth.c and I made the patch. > > Probably against the unpatched 2.6.26 then? OK, that will explain the > > similarities. But then the real problem must be something else. Sorry > > for the confusion. > No, I made it against 2.6.26-11, for no other reason that it was in > Debian unstable at the time, and I had given up hope for targetting > lenny before. I'd be happy to create a patch against -10 instead. No, you did not. The lines in question read: | dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG; | dev->features |= NETIF_F_TSO; > Alright. I admit I didn't look that closely. Isn't there a Git repo > for Debian kernels? Nope. Bastian -- Murder is contrary to the laws of man and God. -- M-5 Computer, "The Ultimate Computer", stardate 4731.3 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#506419: Driver from Supermicro fixes issue
also sprach martin f krafft <[EMAIL PROTECTED]> [2008.12.09.1154 +0100]: > The attached patch against linux-2.6 2.6.26-11 seems to fix the > original problem for me, [...] I just saw another gso-related kernel trace, even with the new driver. :/ -- .''`. martin f. krafft <[EMAIL PROTECTED]> Related projects: : :' : proud Debian developer http://debiansystem.info `. `'` http://people.debian.org/~madduckhttp://vcs-pkg.org `- Debian - when you have better things to do than fixing systems digital_signature_gpg.asc Description: Digital signature (see http://martin-krafft.net/gpg/)
Bug#506419: Driver from Supermicro fixes issue
also sprach Bastian Blank <[EMAIL PROTECTED]> [2008.12.10.0005 +0100]: > > No, I made it against 2.6.26-11, for no other reason that it was in > > Debian unstable at the time, and I had given up hope for targetting > > lenny before. I'd be happy to create a patch against -10 instead. > > No, you did not. The lines in question read: Uh, yes Bastian, I did: piper:~|master|.tmp/cdt.pUbIXWau/linux-2.6-2.6.26% dpkg-parsechangelog| sed -rne 's,Version: ,,p' 2.6.26-11 piper:~|master|.tmp/cdt.pUbIXWau/linux-2.6-2.6.26% md5sum drivers/net/forcedeth.c a149be68037f7f57ae61986c30caa8fa drivers/net/forcedeth.c piper:~|master|.tmp/cdt.pUbIXWau/linux-2.6-2.6.26% cd ~/forcedeth total 472 -rw--- 1 281784 20081209.1128 0001-import-driver-from-supermicro-nvidia.patch -rw--- 1835 20081209.1128 0002-amend-version-number-for-local-changes.patch -rw--- 1 188327 20081209.1128 forcedeth.c piper:~|master|.tmp/cdt.pUbIXWau/linux-2.6-2.6.26% md5sum forcedeth.c a149be68037f7f57ae61986c30caa8fa forcedeth.c ### NOTE: it's identical to the version in 2.6.26-11 piper:~|master|.tmp/cdt.pUbIXWau/linux-2.6-2.6.26% md5sum 000* 75ba184e0d279b6588801972d0fb1118 0001-import-driver-from-supermicro-nvidia.patch de157fcbc5f3853bbf58363bcd4471e0 0002-amend-version-number-for-local-changes.patch piper:~|master|.tmp/cdt.pUbIXWau/linux-2.6-2.6.26% patch < 0001-import-driver-from-supermicro-nvidia.patch patching file Makefile patching file forcedeth.c patching file readme.txt piper:~|master|.tmp/cdt.pUbIXWau/linux-2.6-2.6.26% patch < 0002-amend-version-number-for-local-changes.patch patching file forcedeth.c ### NOTE: the patch applies cleanly > > Alright. I admit I didn't look that closely. Isn't there a Git > > repo for Debian kernels? > > Nope. How is the kernel code maintained then? -- .''`. martin f. krafft <[EMAIL PROTECTED]> Related projects: : :' : proud Debian developer http://debiansystem.info `. `'` http://people.debian.org/~madduckhttp://vcs-pkg.org `- Debian - when you have better things to do than fixing systems humpty was pushed. digital_signature_gpg.asc Description: Digital signature (see http://martin-krafft.net/gpg/)
Bug#506419: Driver from Supermicro fixes issue
On Wed, Dec 10, 2008 at 03:23:30PM +0100, martin f krafft wrote: > also sprach Bastian Blank <[EMAIL PROTECTED]> [2008.12.10.0005 +0100]: > > > No, I made it against 2.6.26-11, for no other reason that it was in > > > Debian unstable at the time, and I had given up hope for targetting > > > lenny before. I'd be happy to create a patch against -10 instead. > > No, you did not. The lines in question read: > Uh, yes Bastian, I did: > piper:~|master|.tmp/cdt.pUbIXWau/linux-2.6-2.6.26% dpkg-parsechangelog| sed > -rne 's,Version: ,,p' > 2.6.26-11 > piper:~|master|.tmp/cdt.pUbIXWau/linux-2.6-2.6.26% md5sum > drivers/net/forcedeth.c > a149be68037f7f57ae61986c30caa8fa drivers/net/forcedeth.c You managed to get the _unpatched_ source. The patches are applied during the build: | a149be68037f7f57ae61986c30caa8fa drivers/net/forcedeth.c | fdeca7862c903463b607d80cbe2408a0 debian/build/source/drivers/net/forcedeth.c > > > Alright. I admit I didn't look that closely. Isn't there a Git > > > repo for Debian kernels? > > Nope. > How is the kernel code maintained then? svn://svn.debian.org/kernel/dists/sid/linux-2.6/ Bastian -- You can't evaluate a man by logic alone. -- McCoy, "I, Mudd", stardate 4513.3 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#506419: Driver from Supermicro fixes issue
also sprach Bastian Blank <[EMAIL PROTECTED]> [2008.12.10.1541 +0100]: > You managed to get the _unpatched_ source. The patches are applied > during the build: Okay, that makes sense. How do I get the patched source? The accepted standard methods (see policy 4.9 and 4.14) don't reveal anything and don't work: piper:..orcedeth|master|linux-2.6-2.6.26% less debian/README.source debian/README.source: No such file or directory piper:..orcedeth|master|linux-2.6-2.6.26% fakeroot debian/rules patch make: *** No rule to make target `patch'. Stop. -- .''`. martin f. krafft <[EMAIL PROTECTED]> Related projects: : :' : proud Debian developer http://debiansystem.info `. `'` http://people.debian.org/~madduckhttp://vcs-pkg.org `- Debian - when you have better things to do than fixing systems "the wonderful thing about standards is that there are so many to choose from." -- grace hopper digital_signature_gpg.asc Description: Digital signature (see http://martin-krafft.net/gpg/)
Bug#506419: Driver from Supermicro fixes issue
clone 506419 -1 retitle -1 kernel debian/rules misses patch instructions and target severity -1 serious thanks also sprach martin f krafft [2008.12.10.2027 +0100]: > Okay, that makes sense. How do I get the patched source? The > accepted standard methods (see policy 4.9 and 4.14) don't reveal > anything and don't work: > > piper:..orcedeth|master|linux-2.6-2.6.26% less debian/README.source > debian/README.source: No such file or directory > piper:..orcedeth|master|linux-2.6-2.6.26% fakeroot debian/rules patch > make: *** No rule to make target `patch'. Stop. This makes kernel packaging not policy-compliant, thus I am cloning this bug and making it RC. Please do not just ignore my question. -- .''`. martin f. krafft Related projects: : :' : proud Debian developer http://debiansystem.info `. `'` http://people.debian.org/~madduckhttp://vcs-pkg.org `- Debian - when you have better things to do than fixing systems "first get your facts; then you can distort them at your leisure." -- mark twain digital_signature_gpg.asc Description: Digital signature (see http://martin-krafft.net/gpg/)
Bug#506419: Driver from Supermicro fixes issue
severity 509156 wishlist thanks On Thu, Dec 18, 2008 at 10:43:59PM +0100, martin f krafft wrote: > This makes kernel packaging not policy-compliant, thus I am cloning > this bug and making it RC. Not a must-clause nor does the kernel list compatibility with they newest policy version which added this. Bastian -- "Get back to your stations!" "We're beaming down to the planet, sir." -- Kirk and Mr. Leslie, "This Side of Paradise", stardate 3417.3 -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Processed: Re: Bug#506419: Driver from Supermicro fixes issue
Processing commands for [EMAIL PROTECTED]: > tags 506419 -patch Bug#506419: kernel trace during IPv6 ssh output Tags were: patch ipv6 Tags removed: patch > thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Processed: Re: Bug#506419: Driver from Supermicro fixes issue
Processing commands for cont...@bugs.debian.org: > clone 506419 -1 Bug#506419: kernel trace during IPv6 ssh output Bug 506419 cloned as bug 509156. > retitle -1 kernel debian/rules misses patch instructions and target Bug#509156: kernel trace during IPv6 ssh output Changed Bug title to `kernel debian/rules misses patch instructions and target' from `kernel trace during IPv6 ssh output'. > severity -1 serious Bug#509156: kernel debian/rules misses patch instructions and target Severity set to `serious' from `important' > thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Processed: Re: Bug#506419: Driver from Supermicro fixes issue
Processing commands for cont...@bugs.debian.org: > severity 509156 wishlist Bug#509156: kernel debian/rules misses patch instructions and target Severity set to `wishlist' from `serious' > thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#509156: Bug#506419: Driver from Supermicro fixes issue
Hi Martin, On Mittwoch, 10. Dezember 2008, martin f krafft wrote: > Okay, that makes sense. How do I get the patched source? The > accepted standard methods (see policy 4.9 and 4.14) don't reveal > anything and don't work: according to http://wiki.debian.org/HowToRebuildAnOfficialDebianKernelPackage you need to run "make -f debian/rules source-all" regards, Holger signature.asc Description: This is a digitally signed message part.
