blt repackaged again, please advise on last lintian warnings
Hi, everybody. I'm back, now humbled by linitian's might. Instead of putting my blt package revisions onto the mentors server, and probably wasting your storage on another not-yet-done package, I uploaded my new effort here: http://pj.freefaculty.org/Debian/wheezy/amd64/blt-GK-3/ After I uploaded my try last week, Georges Khaznadar noticed I made several mistakes and he did quite a bit of work to set it right. He solved several of the long-standing package problems and several that I caused. He toward the task of silencing all of the linitian warnings. I silenced quite a few warnings. What about the rest? These lintian warnings affected the blt package as it stood before I tried to adopt it. The blt includes a couple of important patches that solve segmentation faults, and it fixes up tens of lintian warnings. At the current time, these are the lintian warnings I'm left with (I'm inserting numbers so we can discuss them). 01. W: blt source: changelog-should-mention-nmu 02. W: blt source: source-nmu-has-incorrect-version-number 2.4z-6 03. W: blt: package-name-doesnt-match-sonames libBLT.2.4-8.4 libBLT.2.4-8.5 libBLTlite.2.4-8.4 libBLTlite.2.4-8.5 04. W: blt: hardening-no-relro usr/lib/libBLT.2.4.so.8.4 05. W: blt: hardening-no-fortify-functions usr/lib/libBLT.2.4.so.8.4 06. W: blt: hardening-no-relro usr/lib/libBLT.2.4.so.8.5 07. W: blt: hardening-no-fortify-functions usr/lib/libBLT.2.4.so.8.5 08. W: blt: hardening-no-relro usr/lib/libBLTlite.2.4.so.8.4 09. W: blt: hardening-no-fortify-functions usr/lib/libBLTlite.2.4.so.8.4 10. W: blt: hardening-no-relro usr/lib/libBLTlite.2.4.so.8.5 11. W: blt: hardening-no-fortify-functions usr/lib/libBLTlite.2.4.so.8.5 12. W: blt: image-file-in-usr-lib usr/lib/blt2.4/treeview.xbm 13. W: blt: image-file-in-usr-lib usr/lib/blt2.4/treeview_m.xbm 14. W: blt: dev-pkg-without-shlib-symlink usr/lib/libBLTlite.2.4.so.8.4 usr/lib/libBLTlite.2.4.so 15. W: blt: dev-pkg-without-shlib-symlink usr/lib/libBLT.2.4.so.8.4 usr/lib/libBLT.2.4.so 16. W: blt: dev-pkg-without-shlib-symlink usr/lib/libBLTlite.2.4.so.8.5 usr/lib/libBLTlite.2.4.so 17. W: blt: dev-pkg-without-shlib-symlink usr/lib/libBLT.2.4.so.8.5 usr/lib/libBLT.2.4.so 1-2 I need you to tell me the protocol. I intend to adopt, Its not an NMU. Is it? I solve warnings if I mark it as a Nonmaintainer Upload and then change the release to a fractional 6.1. By the way, last week on mentors I uploaded 2.4z-6. When I upload again, should I use 2.4z-6 again? 3 is an objection against the package name, which is currently blt, but perhaps it might be changed to libblt. But I don't want to. What a hassle. 4-11 are compiler flags, but I don't know how to fiddle the rules file. 12-13 are unsolvable without make some pretty deep, unpredictable changes in the source itself. There are scripts that use those two image files as "busy cursor" icons, and the path is hard coded into them. 14-17 seem peculiar to me. Aren't the necessary symlinks created by ldconfig after the package files are installed? It shouldn't matter if the links are in the package at all. Just my opinion. Once again, thanks for the help to Georges and several of you who emailed the list this weekend. I understand that, when I eventually upload it to mentors, I'll get instructions on requesting a sponsor via email to the bug number 664...@bugs.debian.org. pj ps. Before this, I had never read through a man page in source code. How awful that format must be. What patience and care the author must have. It makes the great man pages (rsync) seem even greater now. And I now understand completely why there are so many sketchy man pages. -- Paul E. Johnson Professor, Political Science Assoc. Director 1541 Lilac Lane, Room 504 Center for Research Methods University of Kansas University of Kansas http://pj.freefaculty.org http://quant.ku.edu -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAErODj8Df=qDCGqZPAJ0d=b24wnncrohvslzt_beuq-fptq...@mail.gmail.com
Re: RFS: tty-clock/1.1-1.1 [RC]
I talked to the maintainer about this on IRC, he will take care of it. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caktje6fbbamblpv1t5g5k7rzpndluurehamotwl1b_ybxo3...@mail.gmail.com
Re: RFS: asio [O] (#583862)
Hi Markus, I have uploaded the package with some minor changes (see an attachment). If you are not agree with them (changelog entries mostly), feel free to drop them with the future uploads. Pay attention, (Closes: #583862: did not work in your changelog. Please, consider the package maintenance under the team. On 03/04/2013 12:31 PM, Markus Wanner wrote: >> 3) Changelog-entry #2 is not necessary IMHO. > > Hm.. I merged this into the "New maintainer" line. Is there another > place to thank the former maintainer? I kind of like these little > pieces of appreciation. But yeah, it doesn't need to be the changelog. You can write him an email, if you want. Try to write changelog-entries shorter: they should not tell the whole life-story. >> 4) Compat 7 should be better changed to the newer 9 as well as BD >> in control. It will allow also to inject hardened buildflags. > > I updated to 9. > > Just wondering: wheezy ships with dh 8. Why not keep a lower > requirement to allow for easier backports? What benefit does a newer > debhelper compat level give? dh 9 brings build-flags hardening and multiarch (maybe something else, not sure). >> 5) Standards-Version is already 3.9.4 > > Corrected. (No changes required.) ^^^ This should be in changelog. Thanks for contribution. Anton From 6aac113f900cf8163323976ad6e3608bcf5e6e35 Mon Sep 17 00:00:00 2001 From: Anton Gladky Date: Mon, 4 Mar 2013 22:18:02 +0100 Subject: [PATCH] Minor changes before upload. --- debian/changelog |9 - debian/libasio-dev.install |2 +- debian/libasio-doc.docs|1 + debian/libasio-doc.install |1 - 4 files changed, 6 insertions(+), 7 deletions(-) create mode 100644 debian/libasio-doc.docs delete mode 100644 debian/libasio-doc.install diff --git a/debian/changelog b/debian/changelog index 2a06522..c92003b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,15 +1,14 @@ asio (1.4.8-1) experimental; urgency=low * New upstream release. - * New maintainer. (Closes: #583862: ITA: asio -- cross-platform C++ -library for network programming). Thanks to Simon Richter for -maintenance todate. + * New maintainer. (Closes: #583862). * Switch to dpkg-source 3.0 (quilt) format, splitting patches. * Drop the patch for src/Makefile.am, it got applied upstream. - * Drop the patch for Makefile.am, it isn't necessary, anymore. + * Drop the patch for Makefile.am, it isn't necessary anymore. * Adjust the SSLv2 disabling patch. * Migrate to debhelper 9, revamp the rules. Drop all custom build flags, -update to standards version 3.9.4, allow parallel builds. +allow parallel builds. + * Update to standards version 3.9.4. No changes. * Watch only releases with even minor version numbers, odd ones seem to be non-stable releases. * Migrate copyright info to machine readable format. diff --git a/debian/libasio-dev.install b/debian/libasio-dev.install index 98b24cf..41a1414 100644 --- a/debian/libasio-dev.install +++ b/debian/libasio-dev.install @@ -1 +1 @@ -debian/tmp/usr/include/* /usr/include +usr/include/* diff --git a/debian/libasio-doc.docs b/debian/libasio-doc.docs new file mode 100644 index 000..30d29de --- /dev/null +++ b/debian/libasio-doc.docs @@ -0,0 +1 @@ +doc/* diff --git a/debian/libasio-doc.install b/debian/libasio-doc.install deleted file mode 100644 index 127f174..000 --- a/debian/libasio-doc.install +++ /dev/null @@ -1 +0,0 @@ -doc/* /usr/share/doc/libasio-doc -- 1.7.10.4 signature.asc Description: OpenPGP digital signature
RFS: tty-clock/1.1-1.1 [RC]
Package: sponsorship-requests Severity: high Dear mentors, I am looking for a sponsor for my package "tty-clock" * Package name: tty-clock Version : 1.1-1.1 It builds those binary packages: tty-clock - simple terminal clock To access further information about this package, please visit the following URL: http://mentors.debian.net/package/tty-clock Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/t/tty-clock/tty-clock_1.1-1.1.dsc More information about hello can be obtained from http://www.example.com. Changes since the last upload: Add patch to fix rc bug: #700738 Regards, Mateusz Łukasik -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/op.wtfwfkchifijsr@laptop
Re: RFS: asio [O] (#583862)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
Anton,
as an update to your review: I've uploaded a new version to mentors
and committed the same packaging files to collab-maint ('revamp'
branch, though). To keep track:
On 02/23/2013 08:02 AM, Anton Gladky wrote:
> 1) Use DEP-3 for patches (at least Description, Author,
> Last-Update). 2) Remove the fix-makefile.patch, which is not listed
> in debian/patch/series
Corrected.
> 3) Changelog-entry #2 is not necessary IMHO.
Hm.. I merged this into the "New maintainer" line. Is there another
place to thank the former maintainer? I kind of like these little
pieces of appreciation. But yeah, it doesn't need to be the changelog.
> 4) Compat 7 should be better changed to the newer 9 as well as BD
> in control. It will allow also to inject hardened buildflags.
I updated to 9.
Just wondering: wheezy ships with dh 8. Why not keep a lower
requirement to allow for easier backports? What benefit does a newer
debhelper compat level give?
> 5) Standards-Version is already 3.9.4
Corrected. (No changes required.)
> 6) As I understood from #583862, there is already a VCS on
> collab-maint, add corresponding fields into control-file.
Added.
> 7) Use in debian/rules dh_auto_configure -- --prefix=
> instead of "configure". It should be more "nicely"
Very nice hint. Turned out I could skip the entire override.
dh_auto_configure passes --disable-maintainer-mode by default, where
as I used to pass --enable-maintainer-mode. As we don't need to run
autotools anymore, it seems better to disable maintainer-mode, anyway.
> 8) dh 9 sets the "correct" buildflags in many cases. Do you really
> need to set them explicitly?
No, very likely not. Especially as asio doesn't install any binary. So
whatever flags we pass there, they only ever affect the test suite.
Thus, I stripped all custom {CXX,LD}FLAGS and now use the defaults.
> 9) Add --parallel option to dh for faster building.
Added.
> 10) The upload should be targeted to experimental branch due to a
> freeze-period.
Corrected.
Regards
Markus Wanner
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQQcBAEBCgAGBQJRNIYJAAoJEOhoLRs/MemzRUogAMgD81t6LG9eMXtmsojbBzOS
Hg9O8W8IUX2aWVeOpbsu/VDbwNEaEq446yDYsbV36N925EltvtZJmcyNWkLs8LYy
4sb+gPIdYBQqIeS5KV9M1uWIVg0Kpq1P0WcQLWgGl1UheqBGMd1ErHvnGPzzKYXq
i7fKbZq1JhoBVppmNwCLqxIb4wl1BA97rlTmXPTAmu6JCTOg7u81pwArKvwwgnuy
hzwhgnVaC6DuS9z3XMeavKToU5XibLin2o2CEtmzVzRjF2L/rWhaRuilckdn2Hq7
MtDFs2WQMm/1JED1G52GTnqEFfN84gaqxOP3of79eBt0f5KFH9MqiezJtfJrhg34
dBO39IjqlekR9pN+dmdrIFkra+kjdqnY1k6ZWblDk5li4P25prIBkOJZCwijADZ6
ruXrKjJMl9sQ6Bs6FhN7LIo/1H08okaRh1KHI9rbQW354n+LRZsgR38oQM46642c
zpV8OGBQQNBvseHkRBxmkExCh+H2CqR9Xq7koVXC3kdF+uZSpqTqXEhcrRYtjKDE
zXo8gDiq0upQP21oAhZHPXAAJL/5tZCCbssT+chSGbDZbber+ksd4jjdFGJpCEqX
dpJvGcRgDhCYBxWM7fg/KTTfw1kcnDj5rZ1p1B5INN1XFk5sB4vFN4AIYJqFVK/a
wU4lWZpFzABqL1pTZCYwjhF7foY1nkvGDatfqE+r0QSy40c9guVeGBA4d4btRRRV
gMjiUmys0CCQO3B5UzjB1fe1PuKkBEjGEwVo7tVJBfNRoiGw19H+++v6OQPoCDZ6
o5KyTPQ5iFjeTVlyv+5fJmN34AwdlSZQ8fYzO1uruJAVnTE17SY8C6vTkVylOrUx
cLhp8YiniDWh03lHHtoj7zvHNpUQU8B5kHN9wm3aE0TilQOzQg7BV7erqZhIJUgp
+cuBJAi6pr20pR8uhU4MgKgU6ul526M/y/K4YT6b66W4Ffj6aVeS4BhX2/Ic9Qgx
g9e+jvQBvvgJyscD+r7mSHz6pOasFwJ+ZgAmRw5EXBnsPGXWC0EXDuz9pd7xXeuX
I8eOIrWeqc0ZuLHS2S93r0gg4zoTsnE0SCpYlZdNci/0vsG/yAkdBQugKOdwWxYz
tpBBKqj7YN2C1V5ajoW6uMC6IxY/xTEQRSIQMH93BG16ytfH7wZqyKV/yWF+fcja
OWx9pHe5SrNBSiR4soknqWWwmXf7mNEknAdlByPWrMJrrVbe7dpQX7dPsop+7jdh
E36j0ks4vF5Fy7EnX8QQBVI9saaFl4PgxbPfXQ2aR0D5Y/4LLHPzmo84cs73zqLi
DzXQ0CvvFaKqAtkxz0DdDqdbun+z4FkXrzLfUVJgNUXlmNuc3SqCobbZJiYTcCA=
=Mlh2
-END PGP SIGNATURE-
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/5134860b.7090...@bluegap.ch
Bug#701693: RFS: compton/0.0.1+git-2182505-2013-02-05-1 [ITP]
Sounds like you should work with upstream to merge compton fixes back into xcompmgr, which is already in Debian. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAKTje6GfjY3xrZeL+7oATpG0357y0ZoiYPov=krm6lqo6gv...@mail.gmail.com
Bug#701706: RFS: ocamlrss/2.0-1 [ITP] -- RSS 2.0 parser and printer for OCaml
I don't intend to sponsor this package, but here is a review: You might want to get involved in the ocaml team: http://wiki.debian.org/Teams/OCamlTaskForce Please drop the unnessecary information from the patch header, including the partial changelog and the stuff about patch tagging guidelines. Please get the patch included upstream. Please improve your watch file: http://wiki.debian.org/debian/watch#Common_mistakes There should be no need for .PHONY in debian/rules. The lintian override should probably be replaced by a bug against lintian or blhc. The copyright/license info for rss_date.mli/rss_date.ml is incomplete. Automatic checks: http://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package ocamlc: File "rss_date.ml", line 220, characters 10-280: Warning 25: bad style, all clauses in this pattern-matching are guarded. lintian: P: librss-ocaml: no-upstream-changelog P: librss-ocaml-dev: no-upstream-changelog similarity-tester: rss_types.ml consists for 85 % of ./rss.ml material -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAKTje6G1iDg84=u=vvSdAUaLzcVUe-DUsvEzAH+YmB9dk=4...@mail.gmail.com
Bug#662955: RFS: rubyripper/0.6.2-1 [ITP]
On Mon, Mar 4, 2013 at 6:51 PM, Scott Leggett wrote: > I think the best course of action at this stage would be to work on > sending some patches upstream prior to the new release. Hopefully that > way I can avoid carrying patches for 0.7.0 when it is done, and > produce a better package. Yep, always a good idea to get patches merged upstream. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caktje6ebhkprbfhaimqiaf8djpe3e4jhc8pznxooi9_lq_k...@mail.gmail.com
Bug#702174: RFS: estonianidcard/3.7.0 [ITP] -- Estonian ID card support packages
I don't intend to sponsor these packages, but here is a review: mentors.d.n cut off my downloads early so I wasn't able to review all the packages. General: Please run wrap-and-sort -sa to wrap various files. The package descriptions are too short. The Homepage redirects to its https version. Some packages don't close their ITPs. The comments in debian/rules are not needed. The copyright information is incorrect. I would suggest debhelper rules.tiny and compat 9 instead of cdbs. Please run these automatic checks against your packages: https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package The watch files make a couple of common mistakes: http://wiki.debian.org/debian/watch#Common_mistakes estonianidcard: The package should probably be a native package? The upstream tarball looks weird, it only contains an empty file. esteidpkcs11loader: The patch Fix-library-directory makes the package only work on amd64/i386, please change the Architecture line in debian/control or fix the patch. Why is JavaScript code loading ELF shared libraries??! Especially loading them from an absolute path is very wrong. esteidfirefoxplugin: No need to make override_dh_strip .PHONY. No need to tell dh what the dbg package is since you do that for dh_strip. override_dh_auto_configure is not needed. Please ask upstream to remove the pre-compiled or generated files from their tarball: keychain-tool firefox-win/plugin-win.aps firefox-win/plugin-win.res ie/dlldata.c Please ask upstream to remove the embedded code copy of the OpenSSL headers: include/openssl http://wiki.debian.org/EmbeddedCodeCopies Likewise for the other files in include/, they are all embedded code copies, from Mozilla and scute. esteidcerts: Why do the certs need to be put in the ca-certificates db? Either they should be in ca-certificates itself (unlikely), or they should not be side-loaded into it via this package. The debian/rules file looks a bit weird, seems like you install things twice, once with dh_install and once manually. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAKTje6H_ubODsi2E9iZWSMLwL_pR=arneifqkewbny0atwr...@mail.gmail.com
Bug#662955: RFS: rubyripper/0.6.2-1 [ITP]
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Paul, On 04/03/13 00:33, Paul Wise wrote: > You might want to join #debian-au :) > I didn't know this existed, cool! > Have you considered joining the multimedia team? > > https://wiki.debian.org/Teams/Multimedia No I haven't, I'll take a look. > > I don't intend to sponsor this package, but here is a review: ... :-/ Thank you for taking the time to do such a detailed review. It looks like you've identified quite some issues with the current package. I have pushed a few of those patches upstream; it's just that upstream is (slowly) getting ready for releasing 0.7.0 and the build is currently broken, otherwise I would package something a bit newer (0.6.2 is quite old!). I think the best course of action at this stage would be to work on sending some patches upstream prior to the new release. Hopefully that way I can avoid carrying patches for 0.7.0 when it is done, and produce a better package. - -- Regards, Scott Leggett. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJRNHyvAAoJEHlzKPr+55fVymYP/2o+qNkaliu7Da6HaXerWaXH li8jW6DP8F+3E+QpQTMqS7dcUZ8iYnhQKk5kn4H8Bg2wqPS/WsQKyL1UaOd+Qb56 xVG9TdwqbBD5NBsbm+XcnMCL/F58xKF8xZgFTlboCtQl3drp37Y5HydYiJwh1sgX lZuGifSVdvyFtVRkpqOxT6s+5asthNOEfoaQBebCp1d3xpKOZHjXb8eDB0Bu34fO vYk6fXIMeAh20GnMou6uwPyCo5hSbXgBblyDJYjRcDFGWFJ7M3ITi9V/0DcTAJQD MC2fWhP6H1e40CnTNlRIW6SCJBWw3QU75nvhWMjDUn7NmfJVAR+foUofGLKRFraG 6frocetbqogCubOakkCapLL4h4c9qWS946BBq0sLlM+FKlzx3BOutaDawUomHImq LLf0ZXLJrlQ8TAQQN/RIi+RXcG3lXQ6ZAY7p2KGHjqDzjmn1cS0fPzubRhkLpepU AZhuH4a/GXGFRVEXqUidDuT2qO/yFrJK2ZjZOjyypYqJlHF8eHTarVQ8KH4PS5uv W3dM/1qBWrHM7y6CzHbgPf/3UHTKd+LUxxr4en4Wf/MKWV0f3YmdF6r3ir6bcW+L Qo3HxURjiPC+LB/RNfyRwWVG2Kpc6J9INXEakPx7xlNGSFjDBDnz8zbWTocOtnvc lofClxTwHr1xa0ECX7tQ =rkUq -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/51347cb9.8050...@sl.id.au
