Re: RFS: sima (autoqueue MPD client, find similar artists to queue)

[Iker Salmón San Millán]

Hello.

I am not DM or DD but you should fix a spelling error in manpage:

spelling-error-in-manpage usr/share/man/man1/simadb_cli.1.gz completly
completely

Cheers

Iker

2010/11/12 Geoffroy Youri Berret 

> Dear mentors,
>
> I am looking for a sponsor for my package "sima".
>
> * Package name: sima
>  Version : 0.6.0-1
>  Upstream Author : Kaliko Jack 
> * URL : http://codingteam.net/project/sima
> * License : GPLv3
>  Section : sound
>
> It builds these binary packages:
> sima   - Automagically add title to mpd playlist
>
> The package appears to be lintian clean.
>
> The upload would fix this bug: 594085
>
> My motivation for maintaining this package is: As the upstream Author I
> would be glad to distribute my soft within official Debian repository,
> first because it is a way to contribute and learn about python packaging
> within Debian, second it would benefit the popularity hence quality of
> the soft to be distributed in such a popular distribution.
>
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/s/sima
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/s/sima/sima_0.6.0-1.dsc
>
>
> I would be glad if someone uploaded^Wreview this package for me.
>
> Kind regards
>  Geoffroy Youri Berret
>
>
>

Re: RFS: wicd-kde

[Iker Salmón San Millán]

sorry about that. It was just to be... i don't know... proper?

Thanks, anyway

Regards

Iker

El 5 de noviembre de 2010 19:44, David Paleino  escribió:

> On Fri, 5 Nov 2010 19:33:24 +0100, Iker Salmón San Millán wrote:
>
> > Dear mentors,
>
> Iker,
>
> > I am looking for a sponsor for my package "wicd-kde".
> >
> > * Package name: wicd-kde
> >   Version : 0.2.1-1
> >   Upstream Author : Anthony Vital
> > 
> > >
> > * URL : http://gitorious.org/wicd-client-kde
> > * License : GPL-v3
> >   Section : kde
> >
> > It builds these binary packages:
> > wicd-kde   - Wired and wireless network manager - KDE client
>
> There was no need to make a new RFS. I'll have a look and sponsor it, as I
> already told you ;-)
>
> Kindly,
> David
>
> --
>  . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
>  : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
>  `. `'`  GPG: 1392B174 | http://deb.li/dapal
>   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
>

RFS: wicd-kde

[Iker Salmón San Millán]

Dear mentors,

I am looking for a sponsor for my package "wicd-kde".


* Package name: wicd-kde
  Version : 0.2.1-1
  Upstream Author : Anthony Vital 
>
* URL : http://gitorious.org/wicd-client-kde
* License : GPL-v3
  Section : kde

It builds these binary packages:
wicd-kde   - Wired and wireless network manager - KDE client

The package appears to be lintian clean.

The upload would fix these bugs: 602049

My motivation for maintaining this package is:

I am using this program since the first releases and works quite well.  I
also want to start mantaining some packages and i think this package is a
good start for it.
I am in contact with the upstream author and he also would be glad to have
his program in debian oficial repositories and he is going to help me fixing
posible bugs if appear.


The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/w/wicd-kde
- Source repository: deb-src http://mentors.debian.net/debian unstable main
contrib non-free
- dget
http://mentors.debian.net/debian/pool/main/w/wicd-kde/wicd-kde_0.2.1-1.dsc

I would be glad if someone uploaded this package for me.

Kind regards
 Iker Salmón San Millán

Re: RFS: wicd-client-kde

[Iker Salmón San Millán]

I have uploaded a new package, but there are a couple of issues.

first i have to rename the ITP and i've been looking how to do it but i
haven't found.
The second thing is that i get an error that anthony (author)  can't
reproduce it. The program works well but there is kind of issue with the
launcher and kick off (it saids tha KDEinit couldn't launch the program but
the program starts).  I have a patch ready and sent to the author but i want
to wait till he reproduces the error and supervise the patch.

Here is the new package if someone want to make a review:

The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/w/wicd-kde
- Source repository: deb-src http://mentors.debian.net/debian unstable main
contrib non-free
- dget
http://mentors.debian.net/debian/pool/main/w/wicd-kde/wicd-kde_0.2.1-1.dsc

And if someone cand help me finding a link to something to read about how to
rename the ITP bug it would be grate

Thanks

Iker
2010/11/3 David Paleino 

> On Wed, 3 Nov 2010 17:29:00 +0100, Anthony Vital wrote:
>
> > [..]
> > Put it that way, it indeed makes more sense to call the binary wicd-kde.
> So
> > I can do that upstream, but I haven't planned a new release anytime soon
> > because I just released a new one a couple of days ago. But if needed, I
> can
> > make a patch and Iker could use it?
>
> Sure, not a problem.
>
> I'll wait for a new package from Iker :-)
>
> Kindly,
> David
>
> --
>  . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
>  : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
>  `. `'`  GPG: 1392B174 | http://deb.li/dapal
>   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
>

Re: RFS: wicd-client-kde

[Iker Salmón San Millán]

2010/11/3 Anthony Vital 

>
>  Ah, I didn't know that. I've never even noticed there was a wicd-gtk
> binary ;)
> Put it that way, it indeed makes more sense to call the binary wicd-kde. So
> I can do that upstream, but I haven't planned a new release anytime soon
> because I just released a new one a couple of days ago. But if needed, I can
> make a patch and Iker could use it?
>
> Anthony
>


No problem for me anthony  I have addeed to the package the patchs i sent to
you, so another one is not a problem for me.


Iker

Re: RFS: wicd-client-kde

[Iker Salmón San Millán]

El 3 de noviembre de 2010 13:05, Iker Salmón San Millán  escribió:

>
> I am still wainting upstream response about changing the name to wicd-qt,
> but till then i would be glad if someone makes a new review of the package.
>
>
Here is the response:
>Well technically this is a KDE App, which heavily depends on the KDE libs,
not only on Qt, and is designed to integrate in the KDE >desktop. If you
call it wicd-qt, it might be misleading if someone doesn't want any kdelibs
dependencies for whatever reason. So I do >not recommend using wicd-qt for
the package name, but instead wicd-kde, like your potential mentor said, for
consistency.
>About the binary name, I don't plan to change it to wicd-kde, because it
doesn't contains/substitute the wicd daemon, I think it's >important that
the users understand it's just a client for the daemon.
>So the package wicd-gtk depends on gtk (and not GNOME) and provides the
wicd-client binary.
>And the package wicd-kde depends on kde (and not only Qt) and would provide
the wicd-client-kde binary. (I can't call it wicd-client >obviously so I
just add -kde at the end)

That makes sense to me.  I don't know what to do now.  I have to correct the
description of the package just to make clear that not only depends on qt it
also depends on kdelibs

Cheers

Iker

Re: RFS: wicd-client-kde

[Iker Salmón San Millán]

I've uploaded tha package again.  I think i've corrected all the mistakes
mentioned in previous emails.

I've also added "provides: wicd-client" in debian/control.

I am still wainting upstream response about changing the name to wicd-qt,
but till then i would be glad if someone makes a new review of the package.

I also have a question.  If we (me, mentors, sponsors, DD, upstream...)
finally decide to change the name i guess i should send a new itp bug with
the new name and close this one,  shouldn't I?

Thanks, iker

P.S. @David: I cc you because i don't know if you are subscribed to
debian-mentors

Re: RFS: wicd-client-kde

[Iker Salmón San Millán]

2010/11/2 Didier 'OdyX' Raboud 

> Iker Salmón San Millán wrote:
>
> > I've added manpage
>
> Nice, but not completely correct: it is named as a manpage for Qt: QT:(1),
> etc. Please change that to wicd-client-kde.


Corrected,


> Furthermore, it seems to lack
> your name as author of said manpage (and mentioning how you prepared it).
>
> But i am not pretty sure where tu put that

> > there are so many troubles running network-manager-kde and wicd-daemon
> > (actually a think they cannot run at the same time, i don't know why you
> > can install both)
>
> > I think that the best option is to add conflicts with knm-runtime because
> In fact, you can install both because there is no reason not to be able to.
>
> For now, I'd find this situation satisfactory, yet not ideal: icons should
> be renamed on one side to avoid the conflict.
>
>
There is a big issue with the icons thing, i'll quote the author's response:

---
Unfortunately I can't do this, because I use the same name scheme as knm on
purpose. Let me explain the situation:
- That name scheme is the one used by monochromatic icons on KDE4.5.x. There
is no way to have control over it. So if I want the application to use those
monochromatic icons, I have to use that name scheme.
Now the tricky part:
- The monochromatic icon set is shipped in kdebase-runtime as part of the
"Air" desktop theme.
- network-wired.png (has to be used because is has a monochromatic
equivalent) is shipped in oxygen-icons.
- All the other icons are shipped with knm.
To sum up: The monochromatic icons are meant to be used with one and only
one icon (well at least one icon name), but monochromatic icons + normal
icons are dispatched in 3 different kde "parts" (I don't know how I should
call them), and one of this "parts" is an application on its own (knm), so
not generic. I hope you understand my explaination ;)
My plan was to get in touch with the knm guys eventually, to try to have all
the icons in one place, but I haven't yet. But even if it happens, I doubt
it will happen tomorrow, if you know what I mean...

So i guess that the best option is to comunicate with kde-devel team to see
if it's posible to provide those icons with oxygen-icon-theme instead that
with knm-runtime.  We'll see that.  But now i just want to keep correcting
the package and see if i can do something that it worths, so i'll keep
conflicts: knm-runtime for the present time.


> The patch you have made to fix the spelling errors still has some issues:
>
> * You should incorporate "DEP-3" headers to it.
> * You are renaming the "informationsButton" object into
> "informationButton".
> Why that ? This will never appear in the GUI and will only be a source of
> errors, no ?
> * You changed "adress" for "address" in the english source and in all po's,
> but it seems you made a quick "search and replace". This has the following
> consequences:
>  - in french, you substituted "adresse" for "addresse", which is wrong
>   (french adresse has one 'd')
>  - You changed the "source translations" blindly (aka the translations are
>   not marked "fuzzy". How do you know that the non-plural form of
>   "Information" is translated the same in chinese as its plural form ?
>
> So I would say that both entagled part of the patch are wrong and I would
> simply drop it: the code change is too risky and the i18n label change is
> done too blindly.
>
> Everything fixed i think...


I have upload the package again. I would be grate if someone could make
another revision of it

Thanks

Iker


P.S. i can't reproduce the error on "preferences" panel. It opens good for
me. Can someone check that again?

Re: RFS: wicd-client-kde

[Iker Salmón San Millán]

Hello again, i've uploaded the package again and i hope that there will be
less errors this time

I've added manpage, i've corrected copyrigth, changelog and  build
dependecies.

I think that the best option is to add conflicts with knm-runtime because
there are so many troubles running network-manager-kde and wicd-daemon
(actually a think they cannot run at the same time, i don't know why you can
install both)

I would be very gatetful if someone could review my package again and tell
me something before i send a new request with "update package" in subject.

Cheers

Iker

Fwd: RFS: wicd-client-kde

[Iker Salmón San Millán]

-- Mensaje reenviado --
De: Iker Salmón San Millán 
Fecha: 1 de noviembre de 2010 13:35
Asunto: Re: RFS: wicd-client-kde
Para: Didier 'OdyX' Raboud 




2010/11/1 Andreas Ronnquist 

> On Mon, 1 Nov 2010 11:30:07 +0100
> Iker Salmón San Millán  wrote:
>
>
> Hi!
>
> I am not a DD, so I have no possiblity to upload any package, and I am
> not familiar with KDE stuff - but anyway -
>
> Trying to build (pdebuild) this package I do get a warning for lacking
> cmake_minimum_required, which probably isn't too serious:
>
>  8< 
> CMake Warning (dev) in CMakeLists.txt:
>  No cmake_minimum_required command is present.  A line of code such as
>
>cmake_minimum_required(VERSION 2.8)
>
>  should be added at the top of the file.  The version specified may be
> lower if you wish to support older CMake versions for this project.
> For more information run "cmake --help-policy CMP".
> This warning is for project developers.  Use -Wno-dev to suppress it.
>  8< 
>
>
I didn't specify the version because the version already aviable in
repositories is 2.8.2, because this package is for kde4 i tought i did not
need to do it, but you are rigth, i'll fix it

> What is worse, I get this too:
>
>  8< 
> CMake Error at /usr/share/cmake-2.8/Modules/FindKDE4.cmake:58 (MESSAGE):
>  ERROR: Could not find KDE4 kde4-config
>  8< 
>
> Have you forgotten som build-depends on some KDE development package?
>

You are rigth, i've made so many tries that in this last one i forgot to add
de dependencie, actually is kdebase-workspace-dev (this ones pulls up other
dependencies needed

>
> I am very far from an expert on packaging (I am also in the process of
> trying to get a package into Debian), but as I understand reviewing of
> others packages is encouraged.
>
> best regards
> --
> Andreas Rönnquist 
>
> Thanks for the help

2010/11/1 Didier 'OdyX' Raboud 


> Hi Iker, and thanks for packaging this software!
>
> Preliminary notice: I am not a DD, so I will not be able to upload your
> package. However, I think that my review can be of interest.
>
> > The package appears to be lintian clean.
>
> Maybe, but it doesn't build in a clean chroot: you miss at least
> kdelibs-bin
> (so using kdelibs5-dev as Build-Dependency would be good [and works]). Did
> you build it in a clean chroot (with pbuilder or sbuild e.g.) before
> uploading it to mentors.d.n ?
>
> Once I fixed that, I still had one lintian warning:
>
> already responsed that, i forgot to add kdebase-workspace-dev as build
dependencie

> W: wicd-client-kde: binary-without-manpage usr/bin/wicd-client-kde
>
> which should really be fixed (see help2man for example).
>
> Terrible mistake, I tried man wicd-gtk to see how it was (the funcionality
is the same in both front-ends and i did not find de man page.  I forgot
that I uninstalled the gtk-client.  I just tough that if wicd-gtk didn't
have man page this one would'nt need one.
Silly me...

Anyway, working on that also


>
> Other things I noticed (randomly ordered)
>
> * Your debian/copyright is unusual as it doesn't quote the GPL license.
>
>  I tried to do the rigth way, i'll have to see more copyrigth files to see
what i've done bad.

* You have a debian/patches subdirectory that contains direct changes to the
> source: if you want to apply patches, you should really prepare real
> patches
> (quilt add; quilt edit; …).
>
>
Yup, in this case i guess is better to correct the spelling things before
dh_make.  I'll also contact with Anthony to fix that in upstream.


> * You are mis-using the Vcs-* fields in debian/control: those are not meant
> to point the the "upstream" VCS, but to the packaging VCS.
>
> Thanks, i did not notice that


> * This package would perfectly fit in the "KDE-Extras" team; did you
> consider putting it under this umbrella ?
>
> done


> * There is a typo in the description: "qt" should be "Qt". And if it is
> really a "KDE" client, it should be labelled as such.
>
>
* Your changelog contains two useless informations: the fact that it's your
> first package and the two spelling errors you are fixing (without proper
> patching, see above). For a first release, there is usually no need to
> explain what you have done (a matter of taste). So if you want to mention
> the spelling errors patch, you can, but you should mention that it is done
> through patching.
>
> thanks again

> * The packages ships the network-wireless-*.png icons, that are also in
> knm-
> runtime. So you would either need to conflict with knm-runtime 

RFS: wicd-client-kde

[Iker Salmón San Millán]

Dear Mentors,

I am looking for a sponsor for my package "wicd-client-kde".

* Package name: wicd-client-kde
  Version : 0.2.1-1
  Upstream Author : Anthony Vital 
* URL : http://gitorious.org/wicd-client-kde
* License : GPL v3
  Section : kde

It builds these binary packages:
wicd-client-kde - wired and wireless network manager - KDE client

The package appears to be lintian clean.

The upload would fix these bugs: 602049

My motivation for maintaining this package is:

I am using this program since the first releases and works quite well.  I
also want to start mantaining some packages and i think this package is a
good start for it.
I am in contact with the upstream author and he also would be glad to have
his program in debian oficial repositories and he is going to help me fixing
posibles bugs if appear.


The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/w/wicd-client-kde
- Source repository: deb-src http://mentors.debian.net/debian unstable main
contrib non-free
- dget
http://mentors.debian.net/debian/pool/main/w/wicd-client-kde/wicd-client-kde_0.2.1-1.dsc

I would be glad if someone uploaded this package for me.

Kind regards
 Iker Salmón San Millán

Re: watch file and kde-looks

[Iker Salmón San Millán]

2010/11/1 Paul Wise 

>
> You might be able to use the tan variable, but there is no indication
> in the href as to what version a particular tan corresponds to.
>
>

> The URLs listed there don't contain tags but commit SHA-1s so that
> wouldn't work.
>
> It would be a good idea to ask gitorious.org to implement something
> that works with our requirements.
>
>
> So, at least for now the best i can do it's to fill watch file with
comments describing the situation, isn't it?

Thanks

iker

Re: watch file and kde-looks

[Iker Salmón San Millán]

2010/11/1 Simon Paillard 

>
>
> Which is the canonical place where the author publish the tarball ?
>
> There is no canonical place, The author uses debian sid, and he published
the tarball in kde-look:

 http://kde-apps.org/content/show.php/Wicd+Client+KDE?content=132366

Something like
> http://gitorious.org/wicd-client-kde/wicd-client-kde/archive-tarball/v0.2.1
> will work (but gitorious first reply is NOK, until the tarball is generated
> i.e. a few seconds).
>

Yes, wih that link you can download, but the thing is (at least is what i
underestand reading de documentation) that watch file is used to detect new
versions, so should be something like:
http://gitorious.org/wicd-client-kde/wicd-client-kde/archive-tarball/(*)
???

I am a little confused with this...

Thanks a lot for replying

Iker

watch file and kde-looks

[Iker Salmón San Millán]

Hello mentors.

I am trying to edit properly watch file in order tu be able to use uscan but
i can't do it.
I've tried a lot of combinations with no results.  I tought that th solution
was going to be with downloadurlmangle option but i still have no results
I don't know if it's posible to configure it with kde-look.

I have also been looking wih githubredir.debian.net but i don't know if it
works also with gitorius
http://gitorious.org/wicd-client-kde/

where can i read anything else to find a clue?

Regards

Iker