Bug#1071821: RFS: vzlogger/0.8.6-2 Fixes FTBFS

2024-05-25 Thread Joachim Zobel
(forgotten cc)

Am Samstag, dem 25.05.2024 um 17:38 +0500 schrieb Andrey Rakhmatullin:
> Both require authentication.

Only over https, if you use http everything is fine. The original idea
was that all administration should go over https. Unfortunately there
are by now browsers out there that change the protocol without using
Upgrade-Insecure-Requests.

Sincerely,
Joachim



Bug#1071821: RFS: vzlogger/0.8.6-2 Fixes FTBFS

2024-05-25 Thread Joachim Zobel
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "vzlogger":

Package name : vzlogger
Version : 0.8.6-2
Upstream contact : Joachim Zobel jz-2...@heute-morgen.de
URL : http://wiki.volkszaehler.org/software/controller/vzlogger
License : GPL-3.0-or-later
Vcs : https://github.com/volkszaehler/vzlogger/tree/debian
Section : net
The source builds the following binary packages:

vzlogger - program for logging measurements of smart meters

To access further information about this package, please visit the
following URL:

http://www.heute-morgen.de/debian/repo/unstable/main/source/net/

Alternatively, you can download the package with 'dget' using this
command:

dget -x
http://www.heute-morgen.de/debian/repo/unstable/main/source/net/vzlogger_0.8.6-2.dsc

Changes since the last upload:

Patch that fixes a FTBFS by removing a time dration assert

Regards,

Joachim Zobel



Bug#1069906: RFS: vzlogger/0.8.6-1 -- Fixes for the migration to testing

2024-05-18 Thread Joachim Zobel
Hi.

I have resolved this by doing a new upstream release as the base for
the Debian release. There was also a modified configuration in the
debian branch that was adapted for the Debian package. This is now a
quilt patch. If I understood you correctly the debian branch should not
differ from upstream outside of the debian directory.

To access further information about this package, please visit the
following URL:

http://www.heute-morgen.de/debian/repo/unstable/main/source/net/

Alternatively, you can download the package with 'dget' using this
command:

dget -x
http://www.heute-morgen.de/debian/repo/unstable/main/source/net/vzlogger_0.8.6-1.dsc

Sincerely,
Joachim



Bug#1069906: RFS: vzlogger/0.8.5-1 -- Fixes for the migration to testing

2024-05-14 Thread Joachim Zobel
Am Dienstag, dem 14.05.2024 um 13:35 +0200 schrieb Tobias Frost:
(forgotten cc, again, sorry)

> However, recycling upstream version numbers (as upstream) should be
> avoided, as there are now two 0.8.5 in the world. Please avoid that.

Where did I recycle upstream version numbers? Which are the two 0.8.5s?

Is it that upstream has moved and you consider 0.8.5-1 a 0.8.5?

Sincerely,
Joachim



Bug#1069906: RFS: vzlogger/0.8.5-1 -- Fixes for the migration to testing

2024-05-12 Thread Joachim Zobel
(forgotten cc)

Am Freitag, dem 03.05.2024 um 18:50 +0200 schrieb Tobias Frost:
> reviewing your new package:
> 
> - d/changelog
>   - generally documents only changes to the packaging, not "upstream"
changes
> (the entry "Fixed logrotate conf user name" is an upstream
change.)
> There are exceptions, like if it a very noteworthy change, but
this
> is one isn't in that category.
>   - When packaging a new upstream version, you say so in the
changelog.
> (Like first changelog entry: 
>  * New upstream version.
> )
>   - There are undocumented changes, for example the change to the
> Standard-Version. 
> 

Done.

> A nitpick on d/rules:
>  I'm a fan of declarative syntax, so I'd replace the dh_clean
override
>  with specifing the file to be deleted in the file d/clean. (If you
feel
>  different about this, it is ok to ignore my nitpicking)

Done, thx.

> Remarks on Readme.md: 
>   - It cointains only information not relevant when the user is
> installing the binary package (like how to build, how to install
and
> where to find the packages), so it should not be installed into
> the binary package.

Not exactly. There is the important line "Our packages are built with
MQTT support, but without OMS support.". In addition it is a moving
target. So I'd prefer to keep it as now.

>   - "Debian" is written with a captial "D".

Done.

>   - The sentence "Unfortunately Debian armhf packages do not 
> run on Raspberry Pi 1 although the architecture on the RPi is
named armhf.
> Using Raspian armhf packages fixes that." is a bit hard to parse,
a
> bit off:
> - Raspberry Pi 1 is supported by the Debian armel architecture,
so people
>   running (real) Debian on the Pi 1 need to use "armel" not
"armhf".
> - Paspian has been renamed to Raspberry Pi OS, so the naming
should
>   maybe be also updated.

Done. During the discussion more changes were added.

> Maybe this should be separated into a Debian and Raspberry Pi OS
> section? (They are different distributions anyways…)

The handling is very similar from the users perspective.

>   
> Some parts already mentioned for the previous upload, would be great
if
> you could start tackling them:
> 
> As you are involved with upstream:
> The manpage, initfile, systemd service file should probably be
included in the
> upstream part, it is not only useful for Debian alone.
> 

It is currently under discussion if other installation methods are
still needed.

> Linitian: (I've pre-filtered them a bit already on those that should
be
> investigaged. If harderning is working now, override the linitian I:
tag.)
> I: vzlogger source: debian-rules-parses-dpkg-parsechangelog
[debian/rules:15]
> I: vzlogger: hardening-no-bindnow [usr/bin/vzlogger]
> I: vzlogger: systemd-service-file-missing-documentation-key
[usr/lib/systemd/system/vzlogger.service]
> P: vzlogger source: trailing-whitespace [debian/changelog:10]
> P: vzlogger source: trailing-whitespace [debian/changelog:4]
> P: vzlogger source: trailing-whitespace [debian/control:17]
> P: vzlogger source: trailing-whitespace [debian/control:40]
> P: vzlogger source: trailing-whitespace [debian/rules:45]
> X: vzlogger: systemd-service-file-missing-hardening-features
[usr/lib/systemd/system/vzlogger.service]
> X: vzlogger source: upstream-metadata-file-is-missing

All done except for upstream-metadata-file-is-missing. I don't think
this is of much use for a service.

An updated 0.8.5-1 has been uploaded.

Sincerely,
Joachim



Bug#1069906: RFS: vzlogger/0.8.5-1 -- Fixes for the migration to testing

2024-04-26 Thread Joachim Zobel
Package: sponsorship-requests  
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "vzlogger":

* Package name : vzlogger  
Version  : 0.8.5-1  
Upstream contact : Joachim Zobel   
* URL  : http://wiki.volkszaehler.org/software/controller/vzlogger  
* License  : GPL-3.0-or-later 
* Vcs  : https://github.com/volkszaehler/vzlogger/tree/debian  
Section  : net

The source builds the following binary packages:

vzlogger - program for logging measurements of smart meters

To access further information about this package, please visit the following URL:

http://www.heute-morgen.de/debian/repo/unstable/main/source/net/

Alternatively, you can download the package with 'dget' using this command:

dget -x http://www.heute-morgen.de/debian/repo/unstable/main/source/net/vzlogger_0.8.5-1.dsc

Changes since the last upload:

  * Fixed logrotate conf user name
  * Fixed passing of hardening flags to cmake 

Regards,  
--  
Joachim Zobel



Bug#1064589: marked as done (RFS: photodedupe/1.0.1 [ITP] -- a utility for identifying duplicate images)

2024-04-05 Thread Joachim Zobel
Am Freitag, dem 05.04.2024 um 19:18 + schrieb Debian Bug Tracking
System:
> You need to provide a proper source package, not a dpkg-deb artifact.

Learning about debcargo might be helpful.

Sincerely,
Joachim

https://salsa.debian.org/rust-team/debcargo/

-- 
Papier ist gebundenes CO2. Bitte drucken Sie diese EMail aus und
archivieren Sie sie.



Bug#1064344: RFS: vzlogger/0.8.3 ITP #864255

2024-03-16 Thread Joachim Zobel
Hi Tobias.

Am Donnerstag, dem 14.03.2024 um 17:20 +0100 schrieb Tobias Frost:
> - $2 might be empty, you need to quote it: use "$2" otherwise dpkg will fail

That was a stupid one, thanks. Fixed and uploaded.

Sincerely,
Joachim



Bug#1064344: RFS: vzlogger/0.8.3 ITP #864255

2024-03-06 Thread Joachim Zobel
Control: tags -moreinfo

Hi Tobias.

Thanks for looking into the package.

Am Donnerstag, dem 22.02.2024 um 22:58 +0100 schrieb Tobias Frost:
> d/source/lintian-overrides
>  - delete the overrides, seems to be some remnant of earlier packaging.
> 
> d/DEBIAN_RELEASE.txt
>  - delete this file; the information contained in this files would not
>be a process how to create a package for Debian. (and if you need a
>file describing certain unusal aspects of the Debian packaging, it
>would be README.source (see Debian Policy §4.14)
>I recommend checking out git-buildpackage:
>https://honk.sigxcpu.org/piki/projects/git-buildpackage/ 
>https://honk.sigxcpu.org/projects/git-buildpackage/manual-html/
>- remove Debian_release.patch -- this is not needed, you work with
>your debian/ directory and evolve it, you do not patch it when you
>create a new version. 
> 
> d/control
>  - specify Rules-Require-Root
>  - you manually depend on libsml1. Can you expand why this is needed?
>  - Build-Depend: s/pkg-config/pkgconf
>  - remove versions from the versioned build dependencies, if the
>debpendency is already fulfilled in oldstable:
>- libjson-c-dev, libcurl4-openssl-dev, 
> 
> 
> d/postinst / postrm
>  - When you create a user, it should start with "_" - see policy 9.2.1
>- Another option might be using systemd's DynamicUser feature to 
>  create the user at runtime. (bonus: some hardening for free.)
>- there's systemd-sysuser (works also without systemd as init system)
>  to use sysusers.d 
>- do not delete users/groups on package removal. 

All changes have been done. In addition the repository has been moved
to DEP-14 layout.

Sincerely,
Joachim



Bug#1064344: RFS: vzlogger/0.8.3 ITP #864255

2024-02-26 Thread Joachim Zobel
Hi.

Thanks for taking the time to review my package.

Am Donnerstag, dem 22.02.2024 um 22:58 +0100 schrieb Tobias Frost:
> d/postinst / postrm
>  - When you create a user, it should start with "_" - see policy
> 9.2.1
This has been implemented and is on its way, see 
https://github.com/volkszaehler/vzlogger/pull/628

It was a bit complicated because I need to rename an existing user.
There are installations of the existing native package. I am therefore
unsure if it is good to do this. Going by the letter which is
"When maintainers choose a new hardcoded or dynamically generated
username" the username has already been choosen when the
debian/vzlogger.init script was created.

Since it is a now or never situation and since the number of existing
installations is still low I tend to rename the user. Any opinions are
appreciated.

Sincerely,
Joachim



Bug#1064344: RFS: vzlogger/0.8.3 ITP #864255

2024-02-24 Thread Joachim Zobel
Hi.

I'll reply to the DEP-14 issue while working on the others.

Am Donnerstag, dem 22.02.2024 um 22:58 +0100 schrieb Tobias Frost:
> > https://github.com/volkszaehler/vzlogger.git 
> > 
> > on branch debian-0.8.3-1.
> 
> (There is no such branch on that repo, but a "debian" one.)

Sorry, forgot to merge that. 

> Please see dep14 (https://dep-team.pages.debian.net/deps/dep14/) for 
> recommendation how to layout the repository used for packaging, I'd
> even recommend to use an extra repository for the packaging.

I know about DEP-14 and actually tried it. I found it however very
inconvenient to use and I think this is because it is inappropriate for
the current situation. 

The package is maintained in the upstream repository as a native
package (by me). This is necessary because Debian packages are built as
part of the upstream releases. So all packaging changes happen upstream
first. The changes that are later needed to turn an upstream native
release into a Debian release are few and won't change much over time.
So a patch makes sense IMHO. 

This situation can change when vzlogger reaches stable (and as a result
reaches Raspbian). At that point maintaining a package in the upstream
repo is no longer necessary.

For now I would prefer to use the suggested release workflow (which I
am already using for libsml, where the situation is the same). I am
aware that the DEP-14 layout works well if upstream is not doing
package maintenance and I am not generally against it. My other current
ITP #1062335 is using it.

https://salsa.debian.org/debian-iot-team/tasmota-device-manager

Sincerely,
Joachim



Bug#1064344: RFS: vzlogger/0.8.3 ITP #864255

2024-02-20 Thread Joachim Zobel
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "vzlogger":

 * Package name : vzlogger
 Version : 3.1-4
 Upstream contact : Joachim Zobel 
 * URL : http://wiki.volkszaehler.org/software/controller/vzlogger
 * License : GPL-3
 * Vcs : https://github.com/volkszaehler/vzlogger
 Section : net 

The source builds the following binary packages:

 vzlogger - program to read measurements from smart meters and log them
to Influxdb or forward them via MQTT.

vzlogger is a tool to read and log measurements of a wide variety of
smart meters and sensors. It supports various commonly used protocols
such as s0, d0, sml, oms and others. It can write these data to an
Influxdb, forward them via MQTT, make them available via HTTP or eport
them to a volkszaehler.org middleware.

The package is maintained in the upstream repository. Upstream (which I
am part of) currently builds native packages. These are patched (a
switch from native to quilt, a different changelog and a version >= 3.0
for the dependency on openssl) to make them more suitable for debian.
The package is therefore availabe in the upstream repo 

https://github.com/volkszaehler/vzlogger.git 

on branch debian-0.8.3-1.

Alternatively, you can download the package with 'dget' using this
command:

 dget -x 
http://www.heute-morgen.de/debian/repo/unstable/main/source/net/vzlogger_0.8.3-1.dsc

Regards,
-- 
 Joachim Zobel