Bug#1062001: RFS: trader/7.20-3 -- simple game of interstellar trading

2024-03-09 Thread John Zaitseff
Control: retitle -1 RFS: trader/7.20-3 -- simple game of interstellar trading

Dear mentors,

[This is an updated email now that I believe I have addressed all
outstanding issues raised by Bastian Germann and Tobias Frost.]

I am still looking for a sponsor for my updated package "trader", a
simple game of interstellar trading:

  Package name:trader
  Version: 7.20-3
  Upstream author: John Zaitseff  -- that's me!
  URL: https://www.zap.org.au/projects/trader/
  License: GPL3+
  Vcs: https://git.zap.org.au/git/trader.git -b with-debian
  Section: games

It builds one binary package:

  trader - simple game of interstellar trading

I have successfully built appropriate binaries using Debian chroots
on my own server at https://ftp.zap.org.au/pub/debian/.  You can
download using dget with:

  dget -x 
https://ftp.zap.org.au/pub/debian/dists/zapgroup-sid/main/source/trader_7.20-3.dsc

Changes since the last upload to Debian:

  trader (7.20-3) unstable; urgency=low

* New upstream release: changed documentation (history of the game),
  updated Swedish, Norwegian Bokmål, French, German, Serbian, Esperanto,
  Romanian, Polish and Ukrainian translations.
* Incorporates changes made to previous upstream release (not uploaded
  to Debian): new Polish, Romanian and Ukrainian translations, renamed
  AppStream metainfo and desktop files.
* Added debian/patches/0001-man-page-bug-fix.patch from upstream commit.
* Removed version numbers on build dependencies for Automake and
  Gettext: oldstable already has at least the required versions.
* Changed Vcs-Git link to use HTTPS instead of Git protocol.
* Included copyright information for Gnulib files in debian/copyright.
* Added debian/upstream/metadata as requested by Tobias Frost.
* Removed superfluous signatures from debian/upstream/signing-key.asc.
* Updated to Debian Policy 4.6.2 (no changes).

   -- John Zaitseff   Sun, 10 Mar 2024 15:57:55 +1100

Please don't hesitate to contact me if you have any questions.  I'm
more than willing to work through any issues that you might
identify.  Thanks!


In my previous email to Tobias Frost, written on Wednesday 28th
February, I wrote:

> > Please add some upstream metadata:
> > https://wiki.debian.org/UpstreamMetadata
>
> This one was new to me.  I've added a simple file, although the
> fields are copies of what is in debian/control already:
>
>   Repository: https://git.zap.org.au/data/git/trader.git
>   Repository-Browse: https://www.zap.org.au/git-browser/trader.git/

Since my last email, I've also added:

  Changelog: https://www.zap.org.au/git-browser/trader.git/plain/NEWS
  Bug-Submit: mailto:j.zaits...@zap.org.au
  Security-Contact: mailto:j.zaits...@zap.org.au

> > I: trader source: public-upstream-key-not-minimal has 16 extra signature(s) 
> > for keyid 0D254111C4EE569B [debian/upstream/signing-key.asc]
>
> Happy to solve this if I could but find instructions on how to
> remove those extra signatures *without* modifying the underlying
> key...

I discovered the helpful lintian-brush package and ran it over my
repository.  This has fixed the public-upstream-key-not-minimal
message.

Yours truly,

John Zaitseff

-- 
John Zaitseff   ╭───╮   Email: j.zaits...@zap.org.au
The ZAP Group   │ Z │   GnuPG: 0x0D254111C4EE569B
Australia Inc.  ╰───╯   https://www.zap.org.au/~john/



Bug#1062001: RFS: trader/7.20-1 -- simple game of interstellar trading

2024-02-27 Thread John Zaitseff
Control: retitle -1 trader/7.20-2 -- simple game of interstellar trading
Control: tags -1 - moreinfo

Dear Tobias,

Thank you very much for your feedback on my RFS for Star Traders,
and apologies for not replying sooner -- it's been a bit of a crazy
week around here...

You (or anyone else) can see my latest Git tree at the following
URL; this tree reflects the changes I've made as a result of your
email:

  https://www.zap.org.au/git-browser/trader.git/tree/?h=with-debian
  git clone https://git.zap.org.au/git/trader.git -b with-debian

I do have a few questions and observations about your comments:

> d/control:
> - Please remove all versions from the versioned build depends that
>   are fulfiled already since oldstable, e.g gettext and automake.

Good catch!  This is what happens when one maintains a Debian
package outside the distro since 2011...

Given that the Git tag for package version 7.20-1 already exists
(and has been distributed!), I've released the new package as
7.20-2, with the entry for 7.20-1 removed as it has not been
uploaded to Debian.  I'm retitling this bug report to suit.  If you
prefer, I can close this RFS and open a new one.

You can now download the updated package by running:

  dget -x 
https://ftp.zap.org.au/pub/debian/dists/zapgroup-sid/main/source/trader_7.20-2.dsc

> - Your VCS-Git link git:// is not using an encrypted link, but the
>   site supports https://. Please use https.

Done.

> d/copyright:
> - the directory lib/ has files which are not documented in
>   d/copyright; (They have a different license and copyright)
> - same for the m4 macros

Hmm.  The files (in lib and m4) that are not my own are mostly from
the Gnulib GNU Portability Library.  Rather tedious and quite a bit
of work, but I've updated the debian/copyright file to suit.

I find it interesting that you're the first Debian developer to pick
up on this: previous sponsors of the package were okay with it the
way it was.  Perhaps you're more thorough!  If it leads to a better
Debian package, I don't mind.

However, I note from section 2.3 of the Debian policy manual:

  Thus, the copyright information for files in the source package
  which are only part of its build process, such as autotools files,
  need not be included in /usr/share/doc/PACKAGE/copyright, because
  those files do not get installed into the binary package.

My reading of that suggests there is no need to include copyright
stanzas for files in the m4 directory.  Is this understanding
correct?

This is what I've added to debian/copyright -- is this okay?

  Files: lib/*
  Copyright: 1987-2024, Free Software Foundation, Inc.
  License: GPL-3+
  Comment:
   Some files in this directory (from the Gnulib GNU Portability Library)
   are licensed by the Free Software Foundation under LGPL-2.1+; other
   files are under GPL-2+.  When combined with the remaining files from the
   same Gnulib library, these inherit the overall GPL-3+ licence.

  Files:
   lib/obsolete-strings.c
   lib/xopen-source.h
  Copyright: 2018-2024, John Zaitseff 
  License: GPL-3+

> embedded code copies:
> - gnulib is packaged for Debian, any reason why you don't use the
>   packaged version?

The upstream release I make (in this case, trader-7.20.tar.xz)
includes the files from Gnulib.  And in all current cases, my
snapshot of Gnulib is *newer* than what is included in the gnulib
Debian package (currently 20240117+stable-1 in Debian Sid, but
20210102~ebaa53c-1 in Debian Bullseye/oldstable -- for Star Traders
7.20, my snapshot is from Tue Jan 30 17:07:32 2024 +0100).

I believe my code depends on the newer Gnulibs to compile.  But even
if it didn't, the upstream release *must* contain Gnulib as it is
compiled on distributions and operating systems where Gnulib is not
packaged.

Rerunning "gnulib-tool --update" as part of the build process is
possible, I suppose, but given that my snapshots are newer, and
there are API-related changes compared to the Debian oldstable and
stable snapshots of Gnulib, I'm not sure that it's worth the hassle
to even try using those Debian snapshots...

> - there are m4 macros from autoconf-archive. Please check if you
>   can use the ones from the package autoconf-archive.

Unfortunately, I can't.  Some of the M4 macros (particularly
m4/ax_compiler_vendor.m4) contain changes that I've submitted
upstream but have not yet been included.  Besides, the
autoconf-archive package does not seem to be part of Debian Sid
anymore.

> Please add some upstream metadata:
> https://wiki.debian.org/UpstreamMetadata

This one was new to me.  I've added a simple file, although the
fields are copies of what is in debian/control already:

  Repository: https://git.zap.org.au/data/git/trader.git
  Repository-Browse: https://www.zap.org.au/git-browser/trader.git/

I don't have a bug database or a separate bug submission URL
(Upstream-Contact from debian/copyright is what I ask people to
use), the 

Bug#1062001: RFS: trader/7.20-1 -- simple game of interstellar trading

2024-01-30 Thread John Zaitseff
Hi, Bastian et al.,

> > > 7.19-1 was never uploaded to Debian, so please remove it from
> > > the changelog.
> >
> > Would this still be the case even though I _did_ release it on
> > The ZAP Group Australia's repository?  If so, how would I
> > preserve the changes listed for v7.19 -- should I just add them
> > as part of the 7.20-1 changelog entry?
>
> Yes, you should do that. Alternatively, you can upload 7.19-1
> before uploading 7.20-1.

I have removed the changelog entry for 7.19-1; the entry for 7.20-1
now reads:

 trader (7.20-1) unstable; urgency=low

   * New upstream release: changed documentation (history of the game),
 updated Swedish, Norwegian Bokmål, French, German, Serbian, Esperanto,
 Romanian, Polish and Ukrainian translations.
   * Incorporates changes made to previous upstream release (not uploaded
 to Debian): new Polish, Romanian and Ukrainian translations, renamed
 AppStream metainfo and desktop files.
   * Require at least Gettext 0.21 and Automake 1.16 for building.
   * Updated to Debian Policy 4.6.2 (no changes).

Could you (or someone) now sponsor the package?  The original link
now points to the updated package:

  dget -x 
https://ftp.zap.org.au/pub/debian/dists/zapgroup-sid/main/source/trader_7.20-1.dsc

Yours truly,

John Zaitseff

-- 
John Zaitseff   ╭───╮   Email: j.zaits...@zap.org.au
The ZAP Group   │ Z │   GnuPG: 0x0D254111C4EE569B
Australia Inc.  ╰───╯   https://www.zap.org.au/~john/



Bug#1062001: RFS: trader/7.20-1 -- simple game of interstellar trading

2024-01-30 Thread John Zaitseff
Hi, Bastian et al.,

Thanks for your quick reply.

> 7.19-1 was never uploaded to Debian, so please remove it from the
> changelog.

Would this still be the case even though I _did_ release it on The
ZAP Group Australia's repository?  If so, how would I preserve the
changes listed for v7.19 -- should I just add them as part of the
7.20-1 changelog entry?

John

-- 
John Zaitseff   ╭───╮   Email: j.zaits...@zap.org.au
The ZAP Group   │ Z │   GnuPG: 0x0D254111C4EE569B
Australia Inc.  ╰───╯   https://www.zap.org.au/~john/



Bug#1062001: RFS: trader/7.20-1 -- simple game of interstellar trading

2024-01-30 Thread John Zaitseff
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my updated package "trader", a simple
game of interstellar trading:

  Package name:trader
  Version: 7.20-1
  Upstream author: John Zaitseff  -- that's me!
  URL: https://www.zap.org.au/projects/trader/
  License: GPL3+
  Vcs: git://git.zap.org.au/data/git/trader.git -b with-debian
  Section: games

It builds one binary package:

  trader - simple game of interstellar trading

I have successfully built appropriate binaries using Debian chroots
on my own server at https://ftp.zap.org.au/pub/debian/.  You can
download using dget with:

  dget -x 
https://ftp.zap.org.au/pub/debian/dists/zapgroup-sid/main/source/trader_7.20-1.dsc

Changes since the last upload:

  trader (7.20-1) unstable; urgency=low

* New upstream release: changed documentation (history of the game),
  updated Swedish, Norwegian Bokmål, French, German, Serbian, Esperanto,
  Romanian, Polish and Ukrainian translations.

   -- John Zaitseff   Wed, 31 Jan 2024 06:52:27 +1100

  trader (7.19-1) unstable; urgency=low

* New upstream release: new Polish, Romanian and Ukrainian translations,
  renamed AppStream metainfo and desktop files.
* Require at least Gettext 0.21 and Automake 1.16 for building.
* Updated to Debian Policy 4.6.2 (no changes).

   -- John Zaitseff   Sun, 07 Jan 2024 11:30:24 +1100

Please don't hesitate to contact me if you have any questions.  I'm
more than willing to work through any issues that you might
identify.  Thanks!

Yours truly,

John Zaitseff

-- 
John Zaitseff   ╭───╮   Email: j.zaits...@zap.org.au
The ZAP Group   │ Z │   GnuPG: 0x0D254111C4EE569B
Australia Inc.  ╰───╯   https://www.zap.org.au/~john/



Bug#1016582: RFS: trader/7.18-1 -- simple game of interstellar trading

2022-08-04 Thread John Zaitseff
Dear Adam,

> > > Seems you lost the changelog for 7.16-3.1.
> >
> > [...] I can add the entry for 7.16-3.1 into my repos.  Should I
> > then just reissue 7.18-1 (the current version) or create 7.18-2?
>
> There's no 7.18-1 in the archive, thus 7.18-1.

I have added the entry for 7.16-3.1 into debian/changelog, have
regenerated the relevant files for 7.18-1 (debian.tar.xz, dsc) and
have rebuilt the binary packages as well.  As before, you may
download using:

  dget -x 
https://ftp.zap.org.au/pub/debian/dists/zapgroup-sid/main/source/trader_7.18-1.dsc
  dget -x 
https://ftp.zap.org.au/pub/debian/dists/zapgroup-sid/main/binary-amd64/trader_7.18-1_amd64.deb

> (I think only Fedora uses the opposite scheme.)

Given I am also a Fedora and openSUSE developer, you can understand
why I asked my question...  It can be tricky to keep track of the
different packaging standards each distro has!

Yours truly,

John Zaitseff

-- 
John Zaitseff   ╭───╮   Email: j.zaits...@zap.org.au
The ZAP Group   │ Z │   GnuPG: 0x0D254111C4EE569B
Australia Inc.  ╰───╯   https://www.zap.org.au/~john/



Bug#1016582: RFS: trader/7.18-1 -- simple game of interstellar trading

2022-08-03 Thread John Zaitseff
Hi, Adam,

Thanks for responding to my request.

> Seems you lost the changelog for 7.16-3.1.

Ah, I didn't realise I needed to incorporate the downstream (Debian)
changelog entries back into my own repository, particularly when the
only change between 7.16-3 and 7.16-3.1 was to use "urgency=medium"
in debian/changelog.  My mistake.

I can add the entry for 7.16-3.1 into my repos.  Should I then just
reissue 7.18-1 (the current version) or create 7.18-2?

Yours truly,

John Zaitseff

-- 
John Zaitseff   ╭───╮   Email: j.zaits...@zap.org.au
The ZAP Group   │ Z │   GnuPG: 0x0D254111C4EE569B
Australia Inc.  ╰───╯   https://www.zap.org.au/~john/



Bug#1016582: RFS: trader/7.18-1 -- simple game of interstellar trading

2022-08-03 Thread John Zaitseff
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my updated package "trader", a simple
game of interstellar trading:

  Package name:trader
  Version: 7.18-1
  Upstream author: John Zaitseff  -- that's me!
  URL: https://www.zap.org.au/projects/trader/
  License: GPL3+
  Vcs: git://git.zap.org.au/data/git/trader.git -b with-debian
  Section: games

It builds one binary package:

  trader - simple game of interstellar trading

I have successfully built appropriate binaries using Debian chroots
on my own server at https://ftp.zap.org.au/pub/debian/.  You can
download using dget with:

  dget -x 
https://ftp.zap.org.au/pub/debian/dists/zapgroup-sid/main/source/trader_7.18-1.dsc

Changes since the last upload:

  trader (7.18-1) unstable; urgency=low

* New upstream release: fixed two TOCTOU (time-of-check / time-of-use)
  bugs and one when HOME is empty; also updated Brazilian Portuguese,
  Norwegian Bokmål, Swedish, French, Esperanto, Serbian, German and
  English translations.
* Added an explicit build dependency on Autoconf 2.71.
* Updated to Debian Policy 4.6.1 (no changes).
* Updated the debian/copyright file to match the FSFAP licensing of
  AppStream trader.appdata.xml* files.

Please don't hesitate to contact me if you have any questions.
I'm more than willing to work through any issues that you might
identify.  Thanks!

Yours truly,

John Zaitseff

-- 
John Zaitseff   ╭───╮   Email: j.zaits...@zap.org.au
The ZAP Group   │ Z │   GnuPG: 0x0D254111C4EE569B
Australia Inc.  ╰───╯   https://www.zap.org.au/~john/



Bug#980456: RFS: trader/7.16-1 [ITP] -- simple game of interstellar trading

2021-01-19 Thread John Zaitseff
Hi, Adam et al.,

> [...]
>
> I'll update the debian/control file in my Git repo to start (give
> me 15 minutes), then rebuild the files on my FTP site.

All done.  You can download the new package by running:

  dget -x 
https://ftp.zap.org.au/pub/debian/dists/zapgroup-sid/main/source/trader_7.16-2.dsc

Yours truly,

John Zaitseff

-- 
John Zaitseff  ╭───╮   Email: j.zaits...@zap.org.au
The ZAP Group  │ Z │   GnuPG: 0x0D254111C4EE569B
Sydney, Australia  ╰───╯   https://www.zap.org.au/~john/



Bug#980456: RFS: trader/7.16-1 [ITP] -- simple game of interstellar trading

2021-01-19 Thread John Zaitseff
Hi, Adam,

On Tuesday, 19 January, 2021 at 11:34:15am +0100, Adam Borowski wrote:

> What's "libncursesw6-dev"?  There's no such package in Debian --
> even though there are similar ones, for different
> versions/flavours of ncurses.

Not sure how that ended up still in my debian/control file: it
should be libncurses-dev, of course (which provides libncursesw5-dev).

I think it was from the time when Debian Sid moved from Ncurses 5.x
to 6.x: the initial dev package was libncursesw6-dev.  I guess over
time, as I rebuilt the binaries on my chroot system, I never noticed
that the dev package was renamed :-(  Sorry about that.

I'll update the debian/control file in my Git repo to start (give me
15 minutes), then rebuild the files on my FTP site.

Yours truly,

John Zaitseff

-- 
John Zaitseff  ╭───╮   Email: j.zaits...@zap.org.au
The ZAP Group  │ Z │   GnuPG: 0x0D254111C4EE569B
Sydney, Australia  ╰───╯   https://www.zap.org.au/~john/



Bug#980456: RFS: trader/7.16-1 [ITP] -- simple game of interstellar trading

2021-01-19 Thread John Zaitseff
Package: sponsorship-requests
Severity: wishlist

Hi,

I am looking for a sponsor for my package "trader", a simple game of
interstellar trading:

  Package name:trader
  Version: 7.16
  Upstream author: John Zaitseff  -- that's me!
  URL: https://www.zap.org.au/projects/trader/
  License: GPL3+
  Vcs: git://git.zap.org.au/data/git/trader.git -b with-debian
  Section: games

It builds one binary package:

  trader - simple game of interstellar trading

I have successfully built appropriate binaries using Debian chroots
on my own server at https://ftp.zap.org.au/pub/debian/.  You can
download using dget with:

  dget -x 
https://ftp.zap.org.au/pub/debian/dists/zapgroup-sid/main/source/trader_7.16-1.dsc

From the blurb:

  Star Traders is a simple game of interstellar trading, where the
  objective is to create companies, buy and sell shares, borrow and
  repay money, in order to become the wealthiest player (the
  winner).

Please don't hesitate to contact me if you have any questions.  I'm
more than willing to work through any issues that you might
identify.  Thanks!

Yours truly,

John Zaitseff

-- 
John Zaitseff  ╭───╮   Email: j.zaits...@zap.org.au
The ZAP Group  │ Z │   GnuPG: 0x0D254111C4EE569B
Sydney, Australia  ╰───╯   https://www.zap.org.au/~john/