Bug#738581: RFS -- speedtest-cli - A command line client for the speedtest.net
On Thu, Feb 13, 2014 at 10:35 AM, Jonathan Carter (highvoltage) jonat...@ubuntu.com wrote: On 13/02/2014 00:26, Andrew Starr-Bochicchio wrote: I'd be happy to sponsor this package. Here's a quick review: Thanks! I've made the changes as requested. Let me know if there's anything further that needs fixing and I'll do so as soon as I can. Alright, I know this is nit-picky, but here's how I would have written the Files paragraphs of debian/copyright: Files: * Copyright: 2013, Matt Martz m...@sivel.net License: Apache-2.0 Files: debian/* Copyright: 2014, Jonathan Carter jonat...@ubuntu.com License: Apache-2.0 License: Apache-2.0 Licensed under the Apache License, Version 2.0 (the License); you may not use this file except in compliance with the License. You may obtain a copy of the License at . http://www.apache.org/licenses/LICENSE-2.0 . Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. . On Debian systems, the complete text of the Apache License 2.0 can be found in /usr/share/common-licenses/Apache-2.0 You can use a stand alone license paragraph if multiple files paragraphs share a license. Also, is the packaging in version control somewhere? If so, please include Vcs fields in debian/control. If not, you might consider joining the Python Application Packaging Team. [0] Besides that, it looks ready to upload! [0] https://wiki.debian.org/Teams/PythonAppsPackagingTeam -- Andrew Starr-Bochicchio Ubuntu Developer https://launchpad.net/~andrewsomething Debian Developer http://qa.debian.org/developer.php?login=asb PGP/GPG Key ID: D53FDCB1 -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cal6k_ayswckmffwfwmkkry7zhtyzvx-bmfco9gvh4ln360t...@mail.gmail.com
Bug#738581: RFS -- speedtest-cli - A command line client for the speedtest.net
On 13/02/2014 00:26, Andrew Starr-Bochicchio wrote: I'd be happy to sponsor this package. Here's a quick review: Thanks! I've made the changes as requested. Let me know if there's anything further that needs fixing and I'll do so as soon as I can. -Jonathan -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52fce645.5040...@ubuntu.com
Bug#738581: RFS -- speedtest-cli - A command line client for the speedtest.net
On 13/02/2014 19:24, Andrew Starr-Bochicchio wrote: Besides that, it looks ready to upload! Recommended changes made, I agree the license file looks nicer this way. Uploaded to mentors.debian.org: https://mentors.debian.net/package/speedtest-cli -Jonathan -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52fd0a03.5020...@ubuntu.com
Bug#738581: Fwd: Bug#738581: RFS -- speedtest-cli - A command line client for the speedtest.net
On Thu, Feb 13, 2014 at 1:34 PM, Jonathan Carter (highvoltage) jonat...@ubuntu.com wrote: Uploaded and Lintian is satisfied. and so am I. Uploaded to the NEW queue. It's in the hands of the FTP-masters now. Feel free to email me directly for future uploads. -- Andrew Starr-Bochicchio Ubuntu Developer https://launchpad.net/~andrewsomething Debian Developer http://qa.debian.org/developer.php?login=asb PGP/GPG Key ID: D53FDCB1 -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cal6k_ayhqzj_mfoqbqog_xnbg2g3zyfq_osbv-_o1h-k1fi...@mail.gmail.com
Bug#738581: RFS -- speedtest-cli - A command line client for the speedtest.net
On Mon, Feb 10, 2014 at 3:50 PM, Jonathan Carter (highvoltage) jonat...@ubuntu.com wrote: It builds the following binary package: speedtest-cli I'd be happy to sponsor this package. Here's a quick review: 1) debian/watch needs to do some mangling of the version number to deal with the v Currently it reports: Newest version on remote site is /v0.2.4, local version is 0.2.4 2) debian/copyright has a minor issue. Even though a license is in common-licenses, you should still at least include the header. [0] Also, it strikes me as strange to use a more restrictive license for the files in debian/ than what upstream uses. 3) Is that debian/README.source really necessary? ;-) 4) debian/control should include a X-Python-Version field. From my build log: pyversions: missing X(S)-Python-Version in control file, fall back to debian/pyversions pyversions: missing debian/pyversions file, fall back to supported versions [0] https://lists.debian.org/debian-devel-announce/2006/03/msg00023.html Thanks! -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cal6k_azfocr3ilvxawuhqpyfuwogfh2uvlywfhfg969ufvk...@mail.gmail.com
Bug#738581: RFS -- speedtest-cli - A command line client for the speedtest.net
Package: sponsorship-requests Severity: wishlist Dear mentors, * Package name: speedtest-cli Version : 0.2.4 Upstream Author : Matt Martz m...@sivel.net * URL : https://github.com/sivel/speedtest-cli/ * License : Apache 2 Programming Lang: Python Description : A command line client for the speedtest.net bandwidth testing service It builds the following binary package: speedtest-cli To access further information about this package, please visit the following URL: http://mentors.debian.net/package/speedtest-cli Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/s/speedtest-cli/speedtest-cli_0.2.4-1.dsc More information about speedtest-cli can be found at https://github.com/sivel/speedtest-cli Thanks for looking at my package! -Jonathan -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.12-trunk-amd64 (SMP w/4 CPU cores) Locale: LANG=en_ZA.utf8, LC_CTYPE=en_ZA.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52f93bb1@ubuntu.com
