Bug#763810: RFS: cruft/0.9.16+nmu1 NMU
Hi, You should sometime read them I have already read them many times in random order; I will browse those again from start to begin to see if i missed something important. As [1] is emtpy, I will be a little more verbose below, apologizes if I tell you something you already know. Indeed. I have till now very little experience with packaging. I just built some dummy ones with equivs. - Change the Orphaning Bug to an Intent-To-Adopt-Title (ITA:) one and set yourself as owner (see https://www.debian.org/devel/wnpp/#howto-o and https://www.debian.org/Bugs/server-control; bts(1) is also a useful tool for manipulating bug status) Done, I wish I knew bts existed before. - Close the Bug in your d/changelog. (some entry like New maintainer (Closes: #763888) -- (d/ is short for the debian/ directory in your package) Ok - Set yourself as Maintainer in d/control (and remove the likely inactive Uplpoader; he can be added in case of again) Ok I already solved 3 bugs, they will be automaticaly closed by the amended changelog. Thats the way to go. If you like, you can also tag those bugs pending In fact, those fixes are already included in the last upload from Marcin that is already in sid. (cruft-ng) Just one remark: Depends should be only used when appropriate -- refer to Policy §7.2 -- so only if cruft-ng requires cruft to operate) It does well requires all the _rules_ from the explain/ filters-unex/ directories. The proper way to do it would be to have an arch-indepedant cruft-data package with theses rules, with two arc-dependant cruft cruft-ng that depend on this. Though, this is much work; I guess that people willing to rewrite cruft could also just do a git clone ; cd ; make to try it out. NM is to become a DD. Ok, I mixed it up; I thought taht was needed to recognize the gpg key. (Lintian Error ) This error will go away after you adopted the package (as described above) Ok - d/changelog: There was an upload Oct3 - you need to rebase your d/changelog to include the changes from 0.9.17 (skip the unreleased nmu) Ok, I did the rebase, the nmu is gone Standard Version 3.9.6 is out ;-) Ok Regarding VCS-*, they need some update as you need to keep them actual Marcin transfered me the root GitHub repository after I deleted my fork, I adapted the URL everywere. (Note: Seems that Marcin did not push the tag for 0.9.17 -- please make sure to tag this release. Tool recommendation: git-buildpackage I set the tag. - d/copyright Comment: should go, not needed. You need to add your name to the * section (as you are also becoming upstream, I guess. Its a native package afterall :)) Ok, I just didn't want to rush it/hurt people feelings; It's nothing technical. This is correct now. I removed the links to the wiki alioth page; those are not much usefull anyway. - d/cruft.lintian-overrides Please remove the lines when no longer needed, not just only comment it. Ok - d/docs is empty Remove file if not needed. Ok - d/dirs *might* not be needed, as debhelper will create the dirs for you usually. So check if can be cleaned up I've forgotten this little bit in my last upload to mentors. Only the empty folders should be there. (/var/... /etc...) Ok, the list is not really long. Good job! Please update the package, replay to this mail and say what you changed, put it to mentors, and give me a ping. https://mentors.debian.net/package/cruft - 2014-10-06 05:09 -- Tobi Thanks for the review Alexandre -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/3197009.dka1B10lbq@antec
Bug#763810: RFS: cruft/0.9.16+nmu1 NMU
Am Monday, den 06.10.2014, 15:36 +0200 schrieb Alexandre Detiste: Ok, the list is not really long. Good job! Please update the package, replay to this mail and say what you changed, put it to mentors, and give me a ping. https://mentors.debian.net/package/cruft - 2014-10-06 05:09 Ähm, there is an lintian error.. orphaned-package-should-not-have-uploaders The reason is that your d/control should read: Maintainer: Alexandre Detiste alexandre.deti...@gmail.com (Remove Uploaders!) Please reupload NOTE: I'm on vacation starting from tomorrow. So only a few hours left before I need to pause sponsoring (until Oct 18) (I will in parallel check the rest of the package) signature.asc Description: This is a digitally signed message part
Bug#763810: RFS: cruft/0.9.16+nmu1 NMU
Am Monday, den 06.10.2014, 15:36 +0200 schrieb Alexandre Detiste: Hi, - Change the Orphaning Bug to an Intent-To-Adopt-Title (ITA:) one and set yourself as owner (see https://www.debian.org/devel/wnpp/#howto-o and https://www.debian.org/Bugs/server-control; bts(1) is also a useful tool for manipulating bug status) Done, I wish I knew bts existed before. - Close the Bug in your d/changelog. (some entry like New maintainer (Closes: #763888) -- (d/ is short for the debian/ directory in your package) Not what I meant. It's still a QA-Upload they way you writing it in d/changelog but you are adopting. Write: cruft (0.9.18) unstable; urgency=medium * New Maintainer (Closes: #763888) * Overhaul ruleset for recent kernels systemd (...) * Closes: #702853 : explain cgroups,devtmpfs and other special fs * Bump DebHelper compat from 5 to 9 (note the line removed in the last section) - Set yourself as Maintainer in d/control (and remove the likely inactive Uplpoader; he can be added in case of again) Ok See previous mail with the lintian error. I already solved 3 bugs, they will be automaticaly closed by the amended changelog. Thats the way to go. If you like, you can also tag those bugs pending In fact, those fixes are already included in the last upload from Marcin that is already in sid. If they already closed by a previous, the approach is different: Manually close them by sending a mail to xx-d...@bugs.debian.org and noteing with the Fixed command (see https://www.debian.org/Bugs/server-control#fixed ) Do not close bugs in the changelog when it not the new version that fixes it! (cruft-ng) Just one remark: Depends should be only used when appropriate -- refer to Policy §7.2 -- so only if cruft-ng requires cruft to operate) It does well requires all the _rules_ from the explain/ filters-unex/ directories. The proper way to do it would be to have an arch-indepedant cruft-data package with theses rules, with two arc-dependant cruft cruft-ng that depend on this. Good idea, and thats not so much work to do it, if you just need to copy files into a different package. (dsclaimer: i didn't check if my claim is right in this case). But lets keep that on the TODO for the moment, and talk about that when introducing cruft-ng, as there is no need before that. Though, this is much work; I guess that people willing to rewrite cruft could also just do a git clone ; cd ; make to try it out. - d/dirs *might* not be needed, as debhelper will create the dirs for you usually. So check if can be cleaned up I've forgotten this little bit in my last upload to mentors. Only the empty folders should be there. (/var/... /etc...) You did not touch that file... As said, if you are quick, I will upload today. (Otherwise after my VAC.) -- tobi signature.asc Description: This is a digitally signed message part
Bug#763810: RFS: cruft/0.9.16+nmu1 NMU
I fixed the changelog, I only kept what was really fixed in 0.9.18 - d/dirs *might* not be needed, as debhelper will create the dirs for you usually. So check if can be cleaned up I've forgotten this little bit in my last upload to mentors. Only the empty folders should be there. (/var/... /etc...) You did not touch that file... Removing any line from d/dirs breaks the build; I reverted changes to this file. As said, if you are quick, I will upload today. (Otherwise after my VAC.) Ok thanks, theres is a new upload on mentors.d.o signature.asc Description: This is a digitally signed message part.
Bug#763810: RFS: cruft/0.9.16+nmu1 NMU
PS: I forgot, there is a lintian informational warning which should be fixed: debian-news-entry-uses-asterisk Thanks! signature.asc Description: This is a digitally signed message part
Bug#763810: RFS: cruft/0.9.16+nmu1 NMU
Control: tags -1 pending Control: owner -1 ! Control: block 763888 by -1 # indicating that I will sponsor this package Hi Alexandre, On Sat, 2014-10-04 at 01:54 +0200, Alexandre Detiste wrote: Hi, cruft is orphaned (#763888), so you dont do a NMU, as technically there is no maintainer. Instead, do a QA-upload. See https://www.debian.org/doc/manuals/developers-reference/pkgs.html#nmu-qa-upload Ok, it wasn't orphaned at the time I did the RFS. Here is a new package: http://mentors.debian.net/package/cruft Just downloaded. We will start a review right away after some entry words :) I saw from [1] that this is your first package, therefore I'd like you to introduce you to a few important documents linked from http://mentors.debian.net/intro-maintainers §3. You should sometime read them (you don't need to be able to recite them from memory, but you should familiarize with them to know where to look up) This will help down the road, especially if you intend to regulary contribute or even become DM/DD at some time) Additionally you should browse https://wiki.debian.org/DebianMentorsFaq As [1] is emtpy, I will be a little more verbose below, apologizes if I tell you something you already know. BTW, don't be scared, it is normal that a review list is huge in the first iteration, Ok, so let me briefly go over your email and then start finally the review.. (I peeked already, so there will be already some remarks) Of course, it would be even better if would consider adopting the package... I would like to. Great! But you need to indicate this on the package, not in this mail :) So, to indicate that you will adopt, you need to do: - Change the Orphaning Bug to an Intent-To-Adopt-Title (ITA:) one and set yourself as owner (see https://www.debian.org/devel/wnpp/#howto-o and https://www.debian.org/Bugs/server-control; bts(1) is also a useful tool for manipulating bug status) - Close the Bug in your d/changelog. (some entry like New maintainer (Closes: #763888) -- (d/ is short for the debian/ directory in your package) - Set yourself as Maintainer in d/control (and remove the likely inactive Uplpoader; he can be added in case of again) As a QA upload allows you to fix litteraly everything, it would be great if you could reduce the bug count a little bit :) I already solved 3 bugs, they will be automaticaly closed by the amended changelog. Thats the way to go. If you like, you can also tag those bugs pending Most others are not bugs, but feature requests; my own biggest complaint is that it is s slow, even on a new PC. After one week of thinkering, I had rewritten the cruft engine from scratch and it is already 30x to 100x faster. https://github.com/a-detiste/cruft-ng https://github.com/a-detiste/cruft-ng/wiki/Benchmark It tries to have an output identical to cruft. It doesn't support any command line argument at the moment but it is already usefull to myself for testing the cruft ruleset, and fix it faster. This let me also find new bugs in cruft: it doesn't grok multiarch, and can't realise that libc6:amd64 libc6 are the same thing. I would like at first to package this as cruft-ng (with Depends: cruft) so that users can compare output. (This getting off topic, I suggest you file an ITP (against pseudo package wnpp) that you are ITP cruft-ng; You can also ping me to sponsor this when ready. Just one remark: Depends should be only used when appropriate -- refer to Policy §7.2 -- so only if cruft-ng requires cruft to operate) It's my first C++ program after 10 years of SQL SAS, the code is ugly. This in not even real C++, just C + strings + vectors + lot of calls to C library; I would better rewrite it in plain C. Of course this won't be completed for Jessie. Don't rush it... There will be a jessie+1 :) (So, yes, I'm willing to sponsor you if you bring the package into shape :-) Ok, that would be great. I've filled up the needed form for Debian Maintainer https://nm.debian.org/public/person/detiste Slow,slow :) NM is to become a DD. But before that is possible you need to be involved already, have some work done already. Usually the way is first to contribute, then after a while, apply for a DebianMaintainer and then again after a while apply to become DD. https://wiki.debian.org/DebianMaintainer https://www.debian.org/devel/join/ (Antonjy: You are listed as uploader... I assume that this is obsolete as your last upload for this package was 1998. please confirm) Lintian complaints about that too. This error will go away after you adopted the package (as described above) Thanks ! Ok, to the review. (Some words ahead: I usually just unordered lists of things I see, but I will not offer solutions how to fix it. This is to encourage research and learning why this is so. -- If you're stuck, ask.) - d/changelog: There was an upload Oct3 - you need to rebase your d/changelog to include the changes from
Bug#763810: RFS: cruft/0.9.16+nmu1 NMU
Hallo Alexandre, cruft is orphaned (#763888), so you dont do a NMU, as technically there is no maintainer. Instead, do a QA-upload. See https://www.debian.org/doc/manuals/developers-reference/pkgs.html#nmu-qa-upload Of course, it would be even better if would consider adopting the package... As a QA upload allows you to fix litteraly everything, it would be great if you could reduce the bug count a little bit :) (So, yes, I'm willing to sponsor you if you bring the package into shape :-) (Antonjy: You are listed as uploader... I assume that this is obsolete as your last upload for this package was 1998. please confirm) -- tobi On Fri, 2014-10-03 at 07:02 +0200, Alexandre Detiste wrote: Dear Maintainer, Uploaded, User I am looking for a sponsor for my updated cruft package. This includes fixes for all the changes that happened in Debian since 2011, like devtmpfs, systemd, grub2, cupsys - cups ... * Package name: cruft Version : 0.9.16+nmu1 * URL : https://github.com/a-detiste/cruft * License : no change Section : admin Here is a colordiff: https://github.com/porridge/cruft/pull/3/files It builds those binary packages: cruft - program that finds any cruft built up on your system My plan was not to touch the cruft engine at all, only update the ruleset, but the current source won't even build without removing non existent directories filters-frbn filters-miss from DATADIRS in Makefile.in . If this update succeds, I'll then have a look a the build packaging too; using Lintian output as a starting point. To access further information about this package, please visit the following URL: http://mentors.debian.net/package/cruft Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/cruft/cruft_0.9.16+nmu1.dsc Alexandre Detiste -- By the way, reportbug is itself broken at the moment (758619), so I didn't manage to CC you to the original RFS bug repport; you'll have to subscribe yourself manually to this bug. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1412366901.3620.17.ca...@edoras.loewenhoehle.ip
Bug#763810: RFS: cruft/0.9.16+nmu1 NMU
Hi, cruft is orphaned (#763888), so you dont do a NMU, as technically there is no maintainer. Instead, do a QA-upload. See https://www.debian.org/doc/manuals/developers-reference/pkgs.html#nmu-qa-upload Ok, it wasn't orphaned at the time I did the RFS. Here is a new package: http://mentors.debian.net/package/cruft Of course, it would be even better if would consider adopting the package... I would like to. As a QA upload allows you to fix litteraly everything, it would be great if you could reduce the bug count a little bit :) I already solved 3 bugs, they will be automaticaly closed by the amended changelog. Most others are not bugs, but feature requests; my own biggest complaint is that it is s slow, even on a new PC. After one week of thinkering, I had rewritten the cruft engine from scratch and it is already 30x to 100x faster. https://github.com/a-detiste/cruft-ng https://github.com/a-detiste/cruft-ng/wiki/Benchmark It tries to have an output identical to cruft. It doesn't support any command line argument at the moment but it is already usefull to myself for testing the cruft ruleset, and fix it faster. This let me also find new bugs in cruft: it doesn't grok multiarch, and can't realise that libc6:amd64 libc6 are the same thing. I would like at first to package this as cruft-ng (with Depends: cruft) so that users can compare output. It's my first C++ program after 10 years of SQL SAS, the code is ugly. This in not even real C++, just C + strings + vectors + lot of calls to C library; I would better rewrite it in plain C. Of course this won't be completed for Jessie. (So, yes, I'm willing to sponsor you if you bring the package into shape :-) Ok, that would be great. I've filled up the needed form for Debian Maintainer https://nm.debian.org/public/person/detiste (Antonjy: You are listed as uploader... I assume that this is obsolete as your last upload for this package was 1998. please confirm) Lintian complaints about that too. Thanks ! signature.asc Description: This is a digitally signed message part.
Bug#763810: RFS: cruft/0.9.16+nmu1 NMU
Package: sponsorship-requests Severity: normal Dear Maintainer, I am looking for a sponsor for my updated cruft package. This includes fixes for all the changes that happened since 2011, like devtmpfs, systemd, ... * Package name: cruft Version : 0.9.16+nmu1 Upstream Author : Marcin Owsiany porri...@debian.org * URL : https://github.com/a-detiste/cruft * License : no change Section : admin Here is a colordiff: https://github.com/porridge/cruft/pull/3/files It builds those binary packages: cruft - program that finds any cruft built up on your system To access further information about this package, please visit the following URL: http://mentors.debian.net/package/cruft Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/cruft/cruft_0.9.16+nmu1.dsc More information about hello can be obtained from http://www.example.com. -- System Information: Distributor ID: Raspbian (also applicable for vanilla Debian) Description:Raspbian GNU/Linux testing (jessie) Release:testing Codename: jessie Architecture: armv6l Kernel: Linux 3.12.28+ (PREEMPT) Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20141002203526.4393.47887.reportbug@localhost
Bug#763810: RFS: cruft/0.9.16+nmu1 NMU
Dear Maintainer, Uploaded, User I am looking for a sponsor for my updated cruft package. This includes fixes for all the changes that happened in Debian since 2011, like devtmpfs, systemd, grub2, cupsys - cups ... * Package name: cruft Version : 0.9.16+nmu1 * URL : https://github.com/a-detiste/cruft * License : no change Section : admin Here is a colordiff: https://github.com/porridge/cruft/pull/3/files It builds those binary packages: cruft - program that finds any cruft built up on your system My plan was not to touch the cruft engine at all, only update the ruleset, but the current source won't even build without removing non existent directories filters-frbn filters-miss from DATADIRS in Makefile.in . If this update succeds, I'll then have a look a the build packaging too; using Lintian output as a starting point. To access further information about this package, please visit the following URL: http://mentors.debian.net/package/cruft Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/cruft/cruft_0.9.16+nmu1.dsc Alexandre Detiste -- By the way, reportbug is itself broken at the moment (758619), so I didn't manage to CC you to the original RFS bug repport; you'll have to subscribe yourself manually to this bug. signature.asc Description: This is a digitally signed message part.
