Re: RFS: ripit (updated package, upload to unstable only)
On Tue, Apr 26, 2011 at 05:18:08PM +0200, Elimar Riesebieter wrote: > * Peter Pentchev [110426 15:49 +0300]: > > On Tue, Apr 26, 2011 at 01:38:02PM +0200, Elimar Riesebieter wrote: > > > Dear mentors, > > > > > > I am looking for a sponsor for the new version 3.9.0-2 > > > of my package "ripit". > > > > > > It builds these binary packages: > > > ripit - Textbased audio CD ripper > > > > > > This is an upload to unstable with no changes to the version which > > > resides in > > > exparimental. > > > > I see that your package has already been uploaded; however, what do you > > think about the attached couple of patches - a couple of minor improvements > > and a couple of fixes to minor issues in the Debian packaging? None of them > > are mandatory or anything; they're just things that I would do to my own > > Debian packages, and of course it's up to you whether to accept them or not > > :) > > Well, those patches are not structured well. Come in come out. Why > not one patch per each file? Would be more comfortable to read. See below :) > And why do you prefer "dh $@"? Well, this is indeed a matter of preference, but by doing this I can easily keep track of what new programs are available in new versions of debhelper and I can easily start to use them. Of course, it helps that I also keep the last couple of build logs so they can be compared to the log from this run. Also, IMHO, a short and simple rules file is preferable to one that lists all of the commands actually invoked. Yes, there are arguments both ways - by listing the commands you know *exactly* what debhelper will do, but then it's a little bit harder to find out what is special about this particular package's build; by using override targets (or even dh --before, --until and --remaining) it's a lot easier to figure out how this package differs from the "usual" build procedure. Yes, with enough experience (and I dare say I may already have enough experience) it's *not so hard* to spot the differences even in an all-commands rules file, but... personally, to me, something like this: override_dh_auto_test: %: dh $@ ...screams "no, I don't want to run this package's test suite, even though I know it has one!" a bit louder than: build: build-stamp build-stamp: dh_testdir dh_auto_configure dh_auto_build touch build-stamp install:install-stamp install-stamp: build-stamp dh_testdir ... ...and so on :) As I said, a matter of preference, and that's the way I like it. > I'll pick up some hints but not all. Now *that*'s why I didn't structure them as "one patch per file" - so you could very easily pick only some of the changes and not the rest, without having to wonder whether this change in the rules file needs to go along with some other change in the control file, or whether the change in the compat file means that something will *have* to change in the rules file or else debhelper will do something nasty in the new compat mode... :) The patches are structured exactly in the sequence of commits - as a matter of fact, they *are* a series of Git commits done to a local repository that I created just for this purpose. The point was to make one commit per change, and when those commits touch more than one file, do it in one go. Of course, two changes in a row may touch the same file, but by keeping them separate, I give you a chance to evaluate each of them on its own merits. > Thanks > > Elimar No problem, and thanks for making Debian better by taking care of its packages! G'luck, Peter -- Peter Pentchev r...@ringlet.net r...@freebsd.org pe...@packetscale.com PGP key:http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 What would this sentence be like if pi were 3? signature.asc Description: Digital signature
Re: RFS: ripit (updated package, upload to unstable only)
* Peter Pentchev [110426 15:49 +0300]: > On Tue, Apr 26, 2011 at 01:38:02PM +0200, Elimar Riesebieter wrote: > > Dear mentors, > > > > I am looking for a sponsor for the new version 3.9.0-2 > > of my package "ripit". > > > > It builds these binary packages: > > ripit - Textbased audio CD ripper > > > > This is an upload to unstable with no changes to the version which resides > > in > > exparimental. > > I see that your package has already been uploaded; however, what do you > think about the attached couple of patches - a couple of minor improvements > and a couple of fixes to minor issues in the Debian packaging? None of them > are mandatory or anything; they're just things that I would do to my own > Debian packages, and of course it's up to you whether to accept them or not :) Well, those patches are not structured well. Come in come out. Why not one patch per each file? Would be more comfortable to read. And why do you prefer "dh $@"? I'll pick up some hints but not all. Thanks Elimar -- The path to source is always uphill! -unknown- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110426151807.gb3...@samweis.home.lxtec.de
Re: RFS: ripit (updated package, upload to unstable only)
On Tue, Apr 26, 2011 at 08:48:16AM -0500, Matt Zagrabelny wrote: Hi, > It seems like lowercase would be the way to go. The description is not > a sentence and capitalizing the first letter makes it feel like a > sentence (when it is not one.) > Since it now feels like a sentence, you also begin to wonder where the > ending punctuation is. It's already noted in the developers-reference, it's just that a lot of us forget about it or ignore it. http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis Sven, need to fix my packages ;) -- And I don't know much, but I do know this: With a golden heart comes a rebel fist. [ Streetlight Manifesto - Here's To Life ] -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110426140457.GD20370@marvin
Re: RFS: ripit (updated package, upload to unstable only)
On Tue, 26 Apr 2011 15:33:46 +0200, Sven Hoexter wrote: > > -Description: Textbased audio CD ripper > > +Description: textbased audio CD ripper > this is a rather interesting one. After a short look at various > packages we seem to have a mixture of upper and lower cases. > Maybe we should try to go with one variant and advice that in the > policy (except for proper names of course). That's already written down in devref: http://www.debian.org/doc/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - PGP/GPG key ID: 0x8649AA06 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe `-Phasers locked on target, Captain. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110426134245.gu5...@colleen.colgarra.priv.at
Re: RFS: ripit (updated package, upload to unstable only)
On Tue, Apr 26, 2011 at 8:33 AM, Sven Hoexter wrote: > On Tue, Apr 26, 2011 at 03:49:30PM +0300, Peter Pentchev wrote: > > Hey Peter, > >> -Description: Textbased audio CD ripper >> +Description: textbased audio CD ripper > > this is a rather interesting one. After a short look at various > packages we seem to have a mixture of upper and lower cases. > Maybe we should try to go with one variant and advice that in the > policy (except for proper names of course). It seems like lowercase would be the way to go. The description is not a sentence and capitalizing the first letter makes it feel like a sentence (when it is not one.) Since it now feels like a sentence, you also begin to wonder where the ending punctuation is. my $.02 -matt zagrabelny -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/BANLkTi=f1x9ejyffastswudovx6_glt...@mail.gmail.com
Re: RFS: ripit (updated package, upload to unstable only)
On Tue, Apr 26, 2011 at 03:49:30PM +0300, Peter Pentchev wrote: Hey Peter, > -Description: Textbased audio CD ripper > +Description: textbased audio CD ripper this is a rather interesting one. After a short look at various packages we seem to have a mixture of upper and lower cases. Maybe we should try to go with one variant and advice that in the policy (except for proper names of course). Sven -- And I don't know much, but I do know this: With a golden heart comes a rebel fist. [ Streetlight Manifesto - Here's To Life ] -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110426133346.GB20370@marvin
Re: RFS: ripit (updated package, upload to unstable only)
On Tue, Apr 26, 2011 at 01:38:02PM +0200, Elimar Riesebieter wrote: > Dear mentors, > > I am looking for a sponsor for the new version 3.9.0-2 > of my package "ripit". > > It builds these binary packages: > ripit - Textbased audio CD ripper > > This is an upload to unstable with no changes to the version which resides in > exparimental. I see that your package has already been uploaded; however, what do you think about the attached couple of patches - a couple of minor improvements and a couple of fixes to minor issues in the Debian packaging? None of them are mandatory or anything; they're just things that I would do to my own Debian packages, and of course it's up to you whether to accept them or not :) G'luck, Peter -- Peter Pentchev r...@ringlet.net r...@freebsd.org pe...@packetscale.com PGP key:http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 I am jealous of the first word in this sentence. From ebf0dde42ed20a7f6825a001f94d2fe4204ef9dc Mon Sep 17 00:00:00 2001 From: Peter Pentchev Date: Tue, 26 Apr 2011 15:09:23 +0300 Subject: [PATCH 1/7] Do not remove .pc/ with 3.0 (quilt). With the 3.0 (quilt) source format, dpkg-buildpackage takes care of applying and unapplying the patches. If the clean target removes quilt's .pc directory, but the patches are *not* unapplied (as they will not be in a normal "debian/rules clean" run), the source tree is left in a somewhat inconsistent state, and a subsequent build attempt will fail when trying to apply the patches. --- debian/rules |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/debian/rules b/debian/rules index f47ffeb..a533286 100755 --- a/debian/rules +++ b/debian/rules @@ -17,7 +17,6 @@ clean: dh_testdir dh_testroot rm -f build-stamp install-stamp - rm -rf .pc dh_clean install: install-stamp -- 1.7.4.1 From cf76f3d267d1980f16c52a0fcec8d6eb7a2b7e96 Mon Sep 17 00:00:00 2001 From: Peter Pentchev Date: Tue, 26 Apr 2011 15:12:14 +0300 Subject: [PATCH 2/7] Convert the copyright file to the DEP 5 candidate format. --- debian/copyright | 36 ++-- 1 files changed, 18 insertions(+), 18 deletions(-) diff --git a/debian/copyright b/debian/copyright index 1a0775d..44ada16 100644 --- a/debian/copyright +++ b/debian/copyright @@ -1,21 +1,21 @@ -This package was debianized by Elimar Riesebieter on -Sun, 04 Dec 2005 18:34:22 +0100. +Format: http://svn.debian.org/wsvn/dep/web/deps/dep5.mdwn?op=file&rev=174 +Upstream-Name: ripit +Upstream-Contact: Felix Suwald +Source: http://www.suwald.com/ripit -It is available at: http://www.suwald.com/ripit +Files: * +Copyright: (C) 2005 Felix Suwald +License: GPL-2+ -Upstream Author: Felix Suwald +Files: debian/* +Copyright: (C) 2006-2011 Elimar Riesebieter +License: GPL-2+ -Copyright (C) 2005 Felix Suwald - -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or (at -your option) any later version. - -This program is distributed in the hope that it will be useful, but -WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -General Public License for more details. - -On a Debian system, the license can be found at -/usr/share/common-licenses/GPL-2 +License: GPL-2+ + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + . + On Debian systems, the complete text of the GNU General Public License + can be found in "/usr/share/common-licenses/GPL-2". -- 1.7.4.1 From d53c11c285619342b74f72032d4959aa07ee6fa0 Mon Sep 17 00:00:00 2001 From: Peter Pentchev Date: Tue, 26 Apr 2011 15:19:21 +0300 Subject: [PATCH 3/7] Shorten the rules file by using the dh(1) tool. --- debian/rules | 34 -- 1 files changed, 8 insertions(+), 26 deletions(-) diff --git a/debian/rules b/debian/rules index a533286..78c37b6 100755 --- a/debian/rules +++ b/debian/rules @@ -6,44 +6,26 @@ # Uncomment this to turn on verbose mode. #export DH_VERBOSE=1 -#include /usr/share/quilt/quilt.make - build: build-stamp build-stamp: - dh_testdir + dh build touch build-stamp clean: - dh_testdir - dh_testroot - rm -f build-stamp install-stamp - dh_clean + dh $@ install: install-stamp install-stamp: build-stamp - dh_testdir - dh_testroot - dh_prep - dh_installdirs - # Add here commands to install the package into debian/ripit. - $(MAKE) install prefix=$(CURDIR)/debian/ripit/usr \ + dh install --before auto_install + dh_auto_install -- prefix=$(CURDIR)/debian/ripit/usr \ etcdir=$(CURDIR)/debian/ripit/etc/ripit + dh install --before installchangelogs + dh_inst
Re: RFS: ripit (updated package, upload to unstable only)
On Tue, Apr 26, 2011 at 01:38:02PM +0200, Elimar Riesebieter wrote: > Dear mentors, > > I am looking for a sponsor for the new version 3.9.0-2 > of my package "ripit". Uploaded, thanks. Sven -- And I don't know much, but I do know this: With a golden heart comes a rebel fist. [ Streetlight Manifesto - Here's To Life ] -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110426123205.GC4051@marvin
RFS: ripit (updated package, upload to unstable only)
Dear mentors, I am looking for a sponsor for the new version 3.9.0-2 of my package "ripit". It builds these binary packages: ripit - Textbased audio CD ripper This is an upload to unstable with no changes to the version which resides in exparimental. The package appears to be lintian clean. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/r/ripit - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/r/ripit/ripit_3.9.0-2.dsc I would be glad if someone uploaded this package for me. Kind regards Elimar Riesebieter -- Numeric stability is probably not all that important when you're guessing;-) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110426113802.ga3...@samweis.home.lxtec.de
