Re: RFS: tnef -- Tool to unpack MIME application/ms-tnef attachments

2006-04-07 Thread Paul Wise
On Thu, 2006-04-06 at 12:12 -0400, Kevin Coyner wrote:

 I am looking for a sponsor for the package 'tnef'.

Thanks for adopting this.

 Thank you in advance for reviewing this package

Some comments:

  * debian/control: need an extra space before Homepage (see the
devref 6.2.4), may as well remove the extra / from the end of
the URL.
  * debian/control: hmm, not sure if the Section is correct. I think
utils or perhaps otherosfs would be more appropriate - compare
with orange or unshield / etc.
  * debian/watch: the url you give will only give you html. the
correct URL (using the special support from uscan) would be
this: http://sf.net/tnef/tnef-(.*)\.tar\.gz
  * debian/rules: the config.sub/guess removal seems elaborate
  * several files contain extra lines and comments that are not
necessary - watch, rules, 
  * don't forget to review the debtags for this package and make
sure they are ok:
http://debtags.alioth.debian.org/cgi-bin/edit.cgi?pkg=tnef

 and possibly sponsoring it.

IANADD, sorry.

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part


Re: RFS: tnef -- Tool to unpack MIME application/ms-tnef attachments

2006-04-07 Thread Simon Richter

Hi,

Paul Wise schrieb:


  * debian/control: need an extra space before Homepage (see the
devref 6.2.4), may as well remove the extra / from the end of
the URL.


No. The / at the end is usually important, although a number of web 
servers hand out redirects (i.e. one extra round trip) if you omit it.



  * debian/control: hmm, not sure if the Section is correct. I think
utils or perhaps otherosfs would be more appropriate - compare
with orange or unshield / etc.


Well, mail would be fine IMO, since this type of file is usually found 
in emails.


   Simon


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: RFS: tnef -- Tool to unpack MIME application/ms-tnef attachments

2006-04-07 Thread Bernhard R. Link
* Kevin Coyner [EMAIL PROTECTED] [060406 18:29]:
 I am looking for a sponsor for the package 'tnef'.  This is a great
 little program for unpacking those winmail.dat attachments that some
 of your friends insist on sending you.  tnef has been in the Debian
 Archives since December 2000 and was recently put up for adoption.
 Since I use it and have too many friends that continue to send me
 winmail.dat attachments, I'd like to see it remain in Debian.
 [...]
 Source files:
 http://mentors.debian.net/debian/pool/main/t/tnef/

Either my md5sum utility has some bug, or the .orig.tar.gz only has
the same content but different timestamps than the .tar.gz from sf.net.

The manpage misses some spaces. (though that is really a minor one,
and a upstream bug, too)

Otherwise it looks good.

Hochachtungsvoll,
  Bernhard R. Link

-- 
Sendmail is like emacs: A nice operating system, but missing
an editor and a MTA.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: RFS: tnef -- Tool to unpack MIME application/ms-tnef attachments

2006-04-07 Thread Bernhard R. Link
* Paul Wise [EMAIL PROTECTED] [060407 08:05]:
   * debian/control: need an extra space before Homepage (see the
 devref 6.2.4), may as well remove the extra / from the end of
 the URL.

Without that slash it is no URL any more. (Slashes at the end of the path may
be omitted, though some webserver do funny stuff then. But between the
hostname and the path there has to be a slash, otherwise it simply is
no URL any more).

Hochachtungsvoll,
  Bernhard R. Link


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: RFS: tnef -- Tool to unpack MIME application/ms-tnef attachments

2006-04-07 Thread Gerber van der Graaf
I recently had a similar problem with my package libgpiv2; the
differences between upstram .tar.gz and .orig.tar.gz., I think , is due
to the differences in the root direcory names. Programs/scripts like
dh_make create a new directory 'name.orig' if you start to debianize an
upstream package from scratch. During building the package the name.orig
is packed into name.orig.tar.gz. The md5check sum's of the CONTENTS of
upstream and progname-version.orig were identic, but the md5check sum's
of tar.gz and orig.tar.gz FILES were different. 

The only remedy against this is to rename the name.tar.gz (from
upstream) to name.orig.tar.gz before you start building the package.

Maybe there should be filed a bug against dh_make for this?
Gerber
-- 
Main developer of G[ov c.s.; software for Particle Image Velocimetry
http://gpiv.sourceforge.net
public key: D39A2B64



signature.asc
Description: This is a digitally signed message part


Re: RFS: tnef -- Tool to unpack MIME application/ms-tnef attachments

2006-04-07 Thread Kevin Coyner


On Fri, Apr 07, 2006 at 02:05:29PM +0800, Paul Wise wrote..

 * debian/control: need an extra space before Homepage (see the
   devref 6.2.4), may as well remove the extra / from the end of the
   URL.

Fixed the extra space.  Think I'll leave the extra / given the
discussion on this.  Can't see it hurting.

 * debian/control: hmm, not sure if the Section is correct. I think
   utils or perhaps otherosfs would be more appropriate - compare
   with orange or unshield / etc.

Agreed.  Utils makes more sense and has been changed now.

 * debian/watch: the url you give will only give you html. the
   correct URL (using the special support from uscan) would be
   this: http://sf.net/tnef/tnef-(.*)\.tar\.gz

Fixed.

 * debian/rules: the config.sub/guess removal seems elaborate

It does seem that way, but I took this straight from
/u/s/doc/autotools-dev/examples/rules.gz.

 * several files contain extra lines and comments that are not
   necessary - watch, rules, 

Fixed.

 * don't forget to review the debtags for this package and make
   sure they are ok:
   http://debtags.alioth.debian.org/cgi-bin/edit.cgi?pkg=tnef

Not an expert on debtags, but I checked this out and it seems
o.k.

Thanks much for your review and comments, and likewise thanks to the
others who gave their comments too.

A newly packaged version fixing the things above is now available
at: http://mentors.debian.net/debian/pool/main/t/tnef/

I also fixed the md5sum inconsistency.

This is a nice little program that needs to stay with Debian.
Still hoping that someone will sponsor it.

Thanks, Kevin

-- 
Kevin Coyner  GnuPG key: 1024D/8CE11941  http://rustybear.com/publickey


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]