Re: Bug#980005: lumpy-sv: lumpyexpress fails with no args
Andreas Tille kirjoitti 12.1.2021 klo 23.08:
> Hi,
>
> I confirm I can reproduce the issue in a minimal chroot while the
> lumpyexpress command prints the help screen as expected. This smells
> like a missing dependency but I do not have any idea which one. It
> seems there is a similar known issue here
>
>
> https://stackoverflow.com/questions/65028261/attributeerror-module-importlib-has-no-attribute-util-ii
>
> but there is no answer here.
>
> Any idea how to fix this?
>
> Kind regards
>
> Andreas.
It's a change made in debian/patches/lumpyexpress.config.patch.
https://salsa.debian.org/med-team/lumpy-sv/-/commit/e64a65545fbf60c5c98965bc1d00d416b2f9582c#6864ced7557ec33a7ee70c7b0c75b076f84f4fac_24_30
-$PYTHON_TEST -c "import imp; imp.find_module('pysam')"
-$PYTHON_TEST -c "import imp; imp.find_module('numpy')"
+$PYTHON_TEST -c "import importlib; importlib.util.find_spec('pysam')"
+$PYTHON_TEST -c "import importlib; importlib.util.find_spec('numpy')"
It's not entirely correct even if it worked: the original causes
a visible error message to alert if one of the required modules does
not exist. The current patch will not cause error messages or the
python check to exit non-zero.
Because it's a Debian context we could rely on dpkg dependencies i.e.
just don't perform this check and comment out the two lines.
--
Juhani
Joining the team, ITP and RFS
Hi! I'd like to join the Debian Python Team to maintain a new python module called pysol_cards. It will be needed by the solitaire game pysolfc. Packaging is ready for review and upload, links here: https://salsa.debian.org/jnumm-guest/python-pysol-cards https://mentors.debian.net/package/python-pysol-cards/ Also, I would like to ask for a new git repository for the package. Would you mind creating one in the standard location https://salsa.debian.org/python-team/packages/python-pysol-cards? I have read and agree to the team policy. My salsa account is "jnumm-guest". Regards, Juhani Numminen
Joining the team and RFS
Hi, I'd like to join the Debian Python Modules Team to maintain a new python module called pysol_cards. It is a dependency of pysolfc and freecell-solver. The role of the pysol_cards module seems to be mainly to share code between those two. Packaging is ready for review and upload, please see https://salsa.debian.org/jnumm-guest/python-pysol-cards . I'd like to ask that the team create a new git repo https://salsa.debian.org/python-team/modules/python-pysol-cards for this package. I have read and agree to the team policy. My salsa account is "jnumm-guest". Cheers, Juhani Numminen
Re: Suspected change in test dependencies - where is "discover" (Was: [Help] Re: Bug#884040: python-matplotlib-venn FTBFS: test failure)
Andreas Tille kirjoitti 12.12.2017 klo 17:10:
> Hi again,
>
> On Mon, Dec 11, 2017 at 09:27:57AM +0100, Andreas Tille wrote:
>>
>> On Sun, Dec 10, 2017 at 09:05:07PM +0200, Adrian Bunk wrote:
>>> === warnings summary
>>> ===
>>> None
>>> [pytest] section in setup.cfg files is deprecated, use [tool:pytest]
>>> instead.
>>
>> I've fixed this in Git[1]
>>
>>> -- Docs: http://doc.pytest.org/en/latest/warnings.html
>>> == 1 warnings in 0.00 seconds
>>> ==
>>> ERROR: file not found: discover
>>
>
> I tried to build on local host (not in a pbuilder chroot) and than this
> issue does not occure. Seems I need to add a new Build-Depends for
> whatever reason. Any hint which one? I parsed the package pool for
> anything Python related containing a file "discover" / "discover.py" but
> besides many hits there was no real helpful one.
Hello,
In debian/rules, are the arguments to dh_auto_test still needed? The error went
away when I removed said arguments, like so:
override_dh_auto_test:
xvfb-run --auto-servernum --server-args="-screen 0 1024x768x24" \
-dh_auto_test -- --test --system=custom --test-args='cp -a README.rst
{home_dir}/build && cd {home_dir}/build && {interpreter} $(CURDIR)/setup.py
test && rm README.rst'
+dh_auto_test
Regards,
Juhani
