Re: Request for review - Charm 1.9.1

2009-02-19 Thread Piotr Ożarowski 
FTR: this package is already uploaded (after few more changes)


pgpB2DeZbw0HL.pgp
Description: PGP signature

Re: Request for review - Charm 1.9.1

2009-02-14 Thread Christopher Lunsford 
Thank you all for the quick replies. I have edited the package to fix
the issues found in your reviews and uploaded it to Alioth. If there
are anymore problems with the package please let me know. Again thank
you for your time and patience during this process.


-- 
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Re: Request for review - Charm 1.9.1

2009-02-05 Thread Piotr Ożarowski 
[Christopher Lunsford, 2009-02-05]
 - dget http://mentors.debian.net/debian/pool/main/c/charm/charm_1.9.1-1.dsc

* PAPT is in Maintainer field, join PAPT and inject the package into our repo
* python-feedparser is missing in Recommends (Depends?)
* add ${misc:Depends} to Depends
* no need to build depend on python-all, python is enough
* add teams' Vcs-Svn and Vcs-Browser fields
in debian/rules:
* why python$*, $* will always be empty
* you can remove everything from build rule
* binary-arch doesn't need to depend on build and install
* dh_shlibdeps can be removed
* remove *.pyc files in clean rule
* install ljcharm.py into private directory (it's a Python application,
  not module); install charm script into the same directory and symlink
  it to /usr/bin/charm
-- 
http://people.debian.org/~piotr/sponsor


pgpnZnUnVKJBE.pgp
Description: PGP signature

Re: Request for review - Charm 1.9.1

2009-02-05 Thread Mauro Lizaur 
On Thu, 05 Feb 2009, Christopher Lunsford wrote:

 Dear Debian-Python,
 
 I am looking for some peer reviews on my package charm, and possibly a 
 mentor.
 
   Package name: charm
   Version : 1.9.1-1
   Upstream Author : Lydia Leong evil...@livejournal.com
   URL : http://ljcharm.sourceforge.net/
   License : GPLv2
   Section : web
 
 It builds these binary packages:
 charm  - LiveJournal and Atom blogging client for the terminal
 


Hi there,
IANDD but i'd like to comment a a couple of small things:
- On debian/copyright seems like you're missing one year (2009),
also you can use © instead of (C).
- On debian/control, perhaps you may want to use the same
short desc that was used on the ITP (A LiveJournal and Atom API client).
Also there's no need to start the paragraph of the long desc
with the package's name.

Regards,
Mauro

-- 
JID: lavaram...@jabber.org | http://lusers.com.ar/
work: ma...@gcoop.com.ar   | http://gcoop.com.ar/
2B82 A38D 1BA5 847A A74D 6C34 6AB7 9ED6 C8FD F9C1


-- 
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org