Re: URL convention to point to per-package lintian checks

[Russ Allbery]

Stefano Zacchiroli <[EMAIL PROTECTED]> writes:
> On Tue, Dec 04, 2007 at 01:17:39AM -0800, Russ Allbery wrote:

>> Let's do this.  Let's standardize on:

> Ok, cool. Many thanks!

> I'll implement the convention PTS side, let me know when the new scheme
> is read on the lintian side.

I'll sneak this into the next release and then give you warning and
coordinate before I update lintian.d.o.

-- 
Russ Allbery ([EMAIL PROTECTED])   


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Re: URL convention to point to per-package lintian checks

[Stefano Zacchiroli]

On Tue, Dec 04, 2007 at 01:17:39AM -0800, Russ Allbery wrote:
> Let's do this.  Let's standardize on:

Ok, cool. Many thanks!

I'll implement the convention PTS side, let me know when the new scheme
is read on the lintian side.

Cheers.

-- 
Stefano Zacchiroli -*- PhD in Computer Science ... now what?
[EMAIL PROTECTED],debian.org,bononia.it} -%- http://www.bononia.it/zack/
(15:56:48)  Zack: e la demo dema ?/\All one has to do is hit the
(15:57:15)  Bac: no, la demo scema\/right keys at the right time


signature.asc
Description: Digital signature

Re: URL convention to point to per-package lintian checks

[Russ Allbery]

Stefano Zacchiroli <[EMAIL PROTECTED]> writes:
> On Mon, Dec 03, 2007 at 12:42:31PM -0800, Russ Allbery wrote:

>> I do, although I'd like to reorganize more than that too.  For example,
>> right now everything is written to one giant directory, which isn't a
>> good idea.  It would also be nice to have pages by package as well as
>> by maintainer, and it would be good to include packages for which one
>> is an uploader in one's personal report.

> Ok, what do you suggest then? Should I wait for the code reorganization
> (assuming it was planned for anytime soon), or go ahead and try patching
> something for the meantime?

Let's do this.  Let's standardize on:

http://lintian.debian.org/reports/maintainer/.html

where  is formed by taking the e-mail address of the maintainer and
then replacing any character other than:

a-z A-Z 0-9 - _ . @ = +

with _.  That's nicely conservative and consists of all of the unreserved
URI characters minus ~*'()! (sometimes shell metacharacters basically
never found in e-mail addresses) and with @=+ added from the reserved
characters since they're found in some addresses and will do no harm.

Then, we'll have a nicer structure to the URL without you having to wait
for a general reorganization or additional views, and I can add that stuff
later.

-- 
Russ Allbery ([EMAIL PROTECTED])   


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Re: URL convention to point to per-package lintian checks

[Stefano Zacchiroli]

On Mon, Dec 03, 2007 at 06:18:28PM -0600, Raphael Geissert wrote:
> What my patches actually do is switch to an email address-based naming (in
> everywhere: lintian reports generator, developer.php and PTS).
> As for what I understood that's what you want to do, am I mistaken?

No, you're not. It's me who overlooked your "lintian.patch" in the bug
report log you pointed me to. But since the lintian maintainer is active
in this discussion I'll let him comment on whether that patch should be
applied right now or not.

Cheers.

-- 
Stefano Zacchiroli -*- PhD in Computer Science ... now what?
[EMAIL PROTECTED],debian.org,bononia.it} -%- http://www.bononia.it/zack/
(15:56:48)  Zack: e la demo dema ?/\All one has to do is hit the
(15:57:15)  Bac: no, la demo scema\/right keys at the right time


signature.asc
Description: Digital signature

Re: URL convention to point to per-package lintian checks

[Stefano Zacchiroli]

On Mon, Dec 03, 2007 at 12:42:31PM -0800, Russ Allbery wrote:
> > If you like the email based approach I've mentioned in my former post
> > and point please let me know, I would happy to contribute a patch for
> > that.
> I do, although I'd like to reorganize more than that too.  For example,
> right now everything is written to one giant directory, which isn't a good
> idea.  It would also be nice to have pages by package as well as by
> maintainer, and it would be good to include packages for which one is an
> uploader in one's personal report.

Ok, what do you suggest then? Should I wait for the code reorganization
(assuming it was planned for anytime soon), or go ahead and try patching
something for the meantime?

Cheers.

-- 
Stefano Zacchiroli -*- PhD in Computer Science ... now what?
[EMAIL PROTECTED],debian.org,bononia.it} -%- http://www.bononia.it/zack/
(15:56:48)  Zack: e la demo dema ?/\All one has to do is hit the
(15:57:15)  Bac: no, la demo scema\/right keys at the right time


signature.asc
Description: Digital signature

Re: URL convention to point to per-package lintian checks

[Raphael Geissert]

Stefano Zacchiroli wrote:
> On Sun, Dec 02, 2007 at 01:27:41PM -0600, Raphael Geissert wrote:
> 
> I surely can, but before doing so I would prefer to fix the URL naming
> scheme in the right place, see my reply to Russ.

What my patches actually do is switch to an email address-based naming (in
everywhere: lintian reports generator, developer.php and PTS).
As for what I understood that's what you want to do, am I mistaken?

> 
> Cheers.
> 

Sincerely,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Re: URL convention to point to per-package lintian checks

[Adeodato Simó]

* Stefano Zacchiroli [Mon, 03 Dec 2007 08:48:31 +0100]:

> My main problem with the current naming scheme is that it is also open
> to clashes. If two maintainer names are different only for an accented
> letter they would clash into the very same page.

(Plus we already have at least two maintainers with the very same name,
Brian Nelson, pyro@ and [EMAIL PROTECTED])

-- 
Adeodato Simó dato at net.com.org.es
Debian Developer  adeodato at debian.org
 
HS boy #1: Okay, who's Pavlov?
HS boy #2: I don't know, it doesn't ring a bell.
-- http://www.overheardinnewyork.com/archives/003016.html


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Re: URL convention to point to per-package lintian checks

[Russ Allbery]

Stefano Zacchiroli <[EMAIL PROTECTED]> writes:

> Are you aware of having several external links pointing into
> lintian.debian.org beside the PTS? I guess beside the PTS and maybe
> personal DD's homepage there won't be many, but I might be utterly wrong
> of course.

I would have thought so, but maybe not.

> My main problem with the current naming scheme is that it is also open
> to clashes. If two maintainer names are different only for an accented
> letter they would clash into the very same page.  Given that, I'm not
> particularly enthusiastic in fixing the PTS wrt a naming scheme that I
> feel to be broken in that respect.
>
> If you like the email based approach I've mentioned in my former post
> and point please let me know, I would happy to contribute a patch for
> that.

I do, although I'd like to reorganize more than that too.  For example,
right now everything is written to one giant directory, which isn't a good
idea.  It would also be nice to have pages by package as well as by
maintainer, and it would be good to include packages for which one is an
uploader in one's personal report.

-- 
Russ Allbery ([EMAIL PROTECTED])   


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Re: URL convention to point to per-package lintian checks

[Thijs Kinkhorst]

On Mon, December 3, 2007 08:48, Stefano Zacchiroli wrote:
> My main problem with the current naming scheme is that it is also open
> to clashes. If two maintainer names are different only for an accented
> letter they would clash into the very same page.

Clashes are already there, even without accented letters. See the two
Lintian links from this page:
http://qa.debian.org/developer.php?login=Brian+Nelson

> If you like the email based approach I've mentioned in my former post
> and point please let me know, I would happy to contribute a patch for
> that.

An email-based approach would also prevent clashes like the one above, so
if anything is changed, rather fix this problem while we're at it :-)


Thijs


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Re: URL convention to point to per-package lintian checks

[Stefano Zacchiroli]

On Sun, Dec 02, 2007 at 01:27:41PM -0600, Raphael Geissert wrote:
> > So, question, what is the actual algorithm used by lintian.d.o to patch
> > maintainer names?
> 
> The script used to generate the html pages is available at:
> http://svn.wolffelaar.nl/lintian/trunk/reporting/html_reports
> 
> There you will find this code:

Thanks for these pointers.

> I've already tried once to fix this problem and even submitted a patch, but
> I recommend you to read the whole bug report[1].
> It would be great if you could finish my work on that.

I surely can, but before doing so I would prefer to fix the URL naming
scheme in the right place, see my reply to Russ.

Cheers.

-- 
Stefano Zacchiroli -*- PhD in Computer Science ... now what?
[EMAIL PROTECTED],debian.org,bononia.it} -%- http://www.bononia.it/zack/
(15:56:48)  Zack: e la demo dema ?/\All one has to do is hit the
(15:57:15)  Bac: no, la demo scema\/right keys at the right time


signature.asc
Description: Digital signature

Re: URL convention to point to per-package lintian checks

[Stefano Zacchiroli]

On Sun, Dec 02, 2007 at 02:01:04PM -0800, Russ Allbery wrote:
> I'm also happy to change the lintian escaping algorithm to make it easier
> for corner cases, but I'd rather not change the algorithm in a way that
> would invalidate other external links unless we declare a major flag day

Are you aware of having several external links pointing into
lintian.debian.org beside the PTS? I guess beside the PTS and maybe
personal DD's homepage there won't be many, but I might be utterly wrong
of course.

> and really completely reorganize lintian.d.o.  (Which should happen one of
> these days, but which would require a fair bit of warning.)

My main problem with the current naming scheme is that it is also open
to clashes. If two maintainer names are different only for an accented
letter they would clash into the very same page.  Given that, I'm not
particularly enthusiastic in fixing the PTS wrt a naming scheme that I
feel to be broken in that respect.

If you like the email based approach I've mentioned in my former post
and point please let me know, I would happy to contribute a patch for
that.

Cheers.

-- 
Stefano Zacchiroli -*- PhD in Computer Science ... now what?
[EMAIL PROTECTED],debian.org,bononia.it} -%- http://www.bononia.it/zack/
(15:56:48)  Zack: e la demo dema ?/\All one has to do is hit the
(15:57:15)  Bac: no, la demo scema\/right keys at the right time


signature.asc
Description: Digital signature

Re: URL convention to point to per-package lintian checks

[Russ Allbery]

Raphael Geissert <[EMAIL PROTECTED]> writes:

> I've already tried once to fix this problem and even submitted a patch, but
> I recommend you to read the whole bug report[1].
> It would be great if you could finish my work on that.

I'm also happy to change the lintian escaping algorithm to make it easier
for corner cases, but I'd rather not change the algorithm in a way that
would invalidate other external links unless we declare a major flag day
and really completely reorganize lintian.d.o.  (Which should happen one of
these days, but which would require a fair bit of warning.)

-- 
Russ Allbery ([EMAIL PROTECTED])   


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Re: URL convention to point to per-package lintian checks

[Raphael Geissert]

Hello Stefano,

Stefano Zacchiroli wrote:
> 
> This does not correspond to what lintian.debian.org is doing, partly for
> the PTS bug, partly for (I guess, though I'm not sure) a lintian bug
> which does not replace with "__" for the last character of maintainer
> name.  For example, at [2], if you look for "Adeodato Simó" you will
> notice that the resulting link is
> http://lintian.debian.org/reports/mAdeodato_Sim.html (and indeed PTS
> pages for packages maintained by dato have 404 lintian links!).
> 
> So, question, what is the actual algorithm used by lintian.d.o to patch
> maintainer names?

The script used to generate the html pages is available at:
http://svn.wolffelaar.nl/lintian/trunk/reporting/html_reports

There you will find this code:
$file =~ s/^(.+)\<.*$/$1/;
$file =~ tr/A-Za-z0-9_.,/_/c;
$file =~ s/^_+//g;
$file =~ s/_+$//g;

> 
> Beside that, should I really need to implement that in the PTS as well?
> The alternative is that lintian.d.o is willing to implement a simpler
> naming scheme, for example using maintainer email and creating URLs like
> http://lintian.debian.org/reports/mEMAIL. In email you can patch "@"
> with the usual URL escape and be done with that. What about it? I think
> the resulting URL would even be easier to guess out of the blue.

I've already tried once to fix this problem and even submitted a patch, but
I recommend you to read the whole bug report[1].
It would be great if you could finish my work on that.

> 
> Many thanks in advance, Cheers.
> 

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=373218

Sincerely,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]