[RFR] templates://mserv/{mserv.templates}
Please find, for review, the debconf templates and packages descriptions for
the mserv source package.
This review will last from Saturday, January 31, 2009 to Tuesday, February 10,
2009.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
[RFRn] (n=2) as a subject tag.
When we will reach a consensus, I send a Last Chance For
Comments mail with [LCFC] as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with [BTS] as
a subject tag.
Rationale:
--- mserv.old/debian/mserv.templates2009-01-27 12:03:15.867022284 +0100
+++ mserv/debian/mserv.templates2009-01-31 08:52:51.551175481 +0100
@@ -1,23 +1,26 @@
Template: mserv/mp3_location
Type: string
-_Description: Please enter the path to the root of your mp3 archive.
- Mserv needs to know where your mp3 files are located so that it can index
- them. The files don't need to be arranged in any special way. If you
- don't have any mp3s right now you can just enter anything. In that case
- mserv will not be able to play music. If you get mp3s in the future you
- can run 'dpkg-reconfigure mserv' to show mserv where they are.
+_Description: Path to the root of the MP3 archive:
+ Mserv needs to know where MP3 files are located so that it can index
+ them. The files don't need to be arranged in any special way.
+ .
+ If no MP3 files are available right now, just enter any directory.
+ In that case,
+ mserv will not be able to play music. To index new MP3 files in the
+ future, you can
+ run dpkg-reconfigure mserv to instruct the program about their location.
Complete redesign.
The synopsis was not a prompt as recommended by the Developers
Reference.
Split in paragraphs to improve readability.
mp3-MP3: this is an acronym
Use double quotes.
Avoid you don't have and such constructions as this is not
necessarily the installing user who has.
Template: mserv/path_invalid
Type: boolean
Default: false
-_Description: This path does not exist. Would you like to use it anyway?
+_Description: Use nonexisting directory anyway?
+ The directory path you mentioned does not exist. Please choose whether you
+ want to use that path anyway.
Never use two sentences in a synopsis.
Ask the question in the synopsis and give explanations in the log part.
Template: mserv/confirm_update
Type: boolean
Default: false
-_Description: Are you sure you want to do this?
- Reconfiguring the location of the mp3 archive when a trackinfo database
- already exists is dangerous. If you proceed with this configuration you
- risk losing your track info database (any ratings, last play times etc.).
- If you know what you are doing or don't care about losing the track info
- database, feel free to continue.
+_Description: Really change the MP3 files archive location?
+ By reconfiguring the location of the MP3 files archive when a
+ trackinfo database already exists, you risk losing the track info
+ database (ratings, last play times etc.).
The synopsis (which could be displayed alone in some interfaces) was
not enough to give needed information (want to do WHAT?).
So, give a little bit more info in the synopsis and the remaining
explanation in the long part.
Avoid the if you know what you're doing stuff. Users are supposed to..:-)
--- mserv.old/debian/control2009-01-27 12:03:15.867022284 +0100
+++ mserv/debian/control2009-01-31 08:47:57.771175250 +0100
@@ -4,49 +4,44 @@
Maintainer: Nick Estes deb...@nickstoys.com
Build-Depends: sharutils, debhelper (= 4.1.51), cdbs
Standards-Version: 3.6.1
+Homepage: http://www.mserv.org
Use this instead of giving the URL in the description
Package: mserv
Architecture: any
Depends: adduser, debconf | debconf-2.0, ${shlibs:Depends}, ${perl:Depends}
Recommends: mpg321 | mpg123 | vorbis-tools | music123 | sox
-Description: local centralised multiuser music server
- Mserv is a music server designed to do a number of things better than most
- systems designed to play mp3s or oggs:
+Description: centralised multiuser music server - server
Standard form for multi-binary packages : one fix part and one package-specific
+ Mserv is a network music server with the following features:
Less advertisment-style. You don't know if it's better than others
and anyway, package descriptions are not meant for this..:-)
.
- - Supports any type of client using standard TCP protocol
- - Stores information on mp3 (bitrate, duration, name, author, genre, date
-produced, last play date) in on-disk database.
- - Stores rating information supplied by the user (awful, bad, neutral,
-good, superb).
- - Has a comprehensive queuing system (track, album, random album, etc)
- - Random play chooses the songs that people currently
Re: [RFR] templates://mserv/{mserv.templates}
Christian Perrier wrote: Your review should be sent as an answer to this mail. This isn't quite a complete review. Template: mserv/mp3_location [...] +_Description: Path to the root of the MP3 archive: + Mserv needs to know where MP3 files are located so that it can index + them. The files don't need to be arranged in any special way. Bare MP3 files here feels odd. We don't want to say your MP3 files, but how about its MP3 files? Hang on, though - what if (as in fact is the case) my music files aren't in MP3 format? The package description claims it supports Ogg Vorbis format too... and yes, my trial install (on Etch) shows up a variety of other annoyances, but since it supports music123 I'm not having any problem getting it to play WAV, Flac, Musepack, MP4 or Speex files either... _Description: Path to the root of mserv's music archive: Mserv needs to know where its music files are located so that it can index them. The files don't need to be arranged in any special way. + If no MP3 files are available right now, just enter any directory. + In that case, + mserv will not be able to play music. To index new MP3 files in the + future, you can + run dpkg-reconfigure mserv to instruct the program about their location. Avoid the alternative interpretation of enter [the] directory. And instruct about seems didactic, so say inform of. If no music files are available right now, just enter any directory name. In that case, mserv will not be able to play music. To index new music files in the future, you can run dpkg-reconfigure mserv to inform the program of their location. Template: mserv/path_invalid Type: boolean Default: false -_Description: This path does not exist. Would you like to use it anyway? +_Description: Use nonexisting directory anyway? Nonexistent or (rarer, but maybe justified here) non-existing. Except that I got this error when it _did_ exist. Mserv does its scan as an unprivileged user - it should say something like: _Description: Really use unreadable location? Mserv cannot access the directory path you specified. Please choose whether you want to use that path anyway. Template: mserv/confirm_update +_Description: Really change the MP3 files archive location? s/MP3 files/music/g, simplifying the noun-pile. Package: mserv [...] Recommends: mpg321 | mpg123 | vorbis-tools | music123 | sox I'd suggest changing that to mp3-decoder | music123 | sox, but I'll leave it as it is. -Description: local centralised multiuser music server - Mserv is a music server designed to do a number of things better than most - systems designed to play mp3s or oggs: +Description: centralised multiuser music server - server z Standard form for multi-binary packages : one fix part and one package-specific If we're doing suite description - package role we can avoid server - server: Description: centralized multiuser music environment - server + Mserv is a network music server with the following features: Less advertisment-style. You don't know if it's better than others and anyway, package descriptions are not meant for this..:-) Agreed, but you've dropped the qualifier local from the short description - I wouldn't suggest running it over the Internet. I'd also suggest that people might want it to turn up in searches on the word jukebox. So bulking it back out a bit: Mserv is a local network jukebox server. It features: + - Support for any type of client using a standard TCP protocol; What does this even mean? (Does it support SSH clients?) I can only imagine it's hinting at the fact (advertised in README.Debian) that you could connect to it from a MUD... + - storage of information on MP3 (bitrate, duration, name, author, genre, date +produced, last play date) in an on-disk database; This has a better candidate lead noun, the database. Not that it's quite what people normally mean when they refer to an on-disk database - it doesn't mean stored in a .db file instead of in memory, it means made of lots and lots of little text files, which you'll probably have to edit by hand. + - rating information supplied by the user (awful, bad, neutral, +good, superb); These go in the same database system, so merge the items: - text databases for track information (author, name, year, genre, last play date, duration) and user ratings (awful, bad, neutral, good, superb); (Ordering them as they appear in the file; no sign of bitrate.) + - queuing system (track, album, random album, etc); ^. + - random play mode that uses users' ratings; Is there an easy way of avoiding uses user? How about: - random play mode taking users' ratings into account; + - search facilities, status information, statistics, etc. ^; + -
Processing of crafty_22.10-1_i386.changes
crafty_22.10-1_i386.changes uploaded successfully to localhost along with the files: crafty_22.10-1.dsc crafty_22.10.orig.tar.gz crafty_22.10-1.diff.gz crafty_22.10-1_i386.deb Greetings, Your Debian queue daemon -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
crafty_22.10-1_i386.changes ACCEPTED
Accepted: crafty_22.10-1.diff.gz to pool/non-free/c/crafty/crafty_22.10-1.diff.gz crafty_22.10-1.dsc to pool/non-free/c/crafty/crafty_22.10-1.dsc crafty_22.10-1_i386.deb to pool/non-free/c/crafty/crafty_22.10-1_i386.deb crafty_22.10.orig.tar.gz to pool/non-free/c/crafty/crafty_22.10.orig.tar.gz Override entries for your package: crafty_22.10-1.dsc - source non-free/games crafty_22.10-1_i386.deb - optional non-free/games Announcing to debian-devel-chan...@lists.debian.org Closing bugs: 357494 411224 425252 449178 449820 Thank you for your contribution to Debian. -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#513180: do not add this yet =)
as this file just yet. it is apperently up for review and I'll add an updated file to this bug when that is done. -- /brother http://frakalendern.se Only one security god has a surname with three adjacent vowels. -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
thwab-lib_1.1.2-2_i386.changes ACCEPTED
Accepted: thwab-data_1.1.2-2_all.deb to pool/main/t/thwab-lib/thwab-data_1.1.2-2_all.deb thwab-doc_1.1.2-2_all.deb to pool/main/t/thwab-lib/thwab-doc_1.1.2-2_all.deb thwab-lib_1.1.2-2.diff.gz to pool/main/t/thwab-lib/thwab-lib_1.1.2-2.diff.gz thwab-lib_1.1.2-2.dsc to pool/main/t/thwab-lib/thwab-lib_1.1.2-2.dsc thwab-lib_1.1.2-2_i386.deb to pool/main/t/thwab-lib/thwab-lib_1.1.2-2_i386.deb Override entries for your package: thwab-data_1.1.2-2_all.deb - extra misc thwab-doc_1.1.2-2_all.deb - extra doc thwab-lib_1.1.2-2.dsc - extra misc thwab-lib_1.1.2-2_i386.deb - extra misc Announcing to debian-devel-chan...@lists.debian.org Thank you for your contribution to Debian. -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#478187: RFS: trang 20030619-7 (QA upload, second try)
Any news? On http://lists.debian.org/debian-java/2008/09/msg00023.html, I see: Pushing. So, what's the status of this package? -- Vincent Lefèvre vinc...@vinc17.org - Web: http://www.vinc17.org/ 100% accessible validated (X)HTML - Blog: http://www.vinc17.org/blog/ Work: CR INRIA - computer arithmetic / Arenaire project (LIP, ENS-Lyon) -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
