Bug#563121: dh_installdefoma leads to buggy maintainer scripts
Keith Packard kei...@keithp.com (30/12/2009): I'm about to QA-upload defoma with this change in the various debhelper-files/* files, but I wanted to open this bugreport for reference. Fortunately, I didn't do so, that wouldn't have helped (yay for sleeping before uploading :)). Here's a patch which I've used to build new fontconfig packages which should survive the absence of defoma. I don't think it would help. - test -x `which defoma-app` defoma-app update #PACKAGE# + which defoma-app /dev/null defoma-app update #PACKAGE# $ which doesnotexist /dev/null echo be happy $ echo $? 1 So the maintainer script bits generated by dh_installdefoma would still lead to non-0 exits. Current/common practice within debhelper seems to be: | if [ -x `which foo 2/dev/null` ]; then… I think I'm going to upload with such a change once I'm up (for real, not vaguely opening eyes). Mraw, KiBi. signature.asc Description: Digital signature
Bug#561693: sun-java6-plugin: solved with temporary workaround
Package: sun-java6-plugin Version: 6-16-1 Severity: normal http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=560044) solved the problem for me also, but as this is just a workaround, I guess the bug should not be closed until the source of the problem is solved. -- System Information: Debian Release: squeeze/sid APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Kernel: Linux 2.6.30-2-686 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages sun-java6-plugin depends on: ii iceweasel 3.5.6-1lightweight web browser based on M ii libasound21.0.21a-1 shared library for ALSA applicatio ii libx11-6 2:1.3.2-1 X11 client-side library ii libxext6 2:1.0.4-1 X11 miscellaneous extension librar ii libxi62:1.2.1-2 X11 Input extension library ii libxtst6 2:1.0.3-1 X11 Testing -- Resource extension ii sun-java6-bin 6-16-1 Sun Java(TM) Runtime Environment ( sun-java6-plugin recommends no packages. sun-java6-plugin suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Processing of defoma_0.11.10-4_amd64.changes
defoma_0.11.10-4_amd64.changes uploaded successfully to localhost along with the files: defoma_0.11.10-4.dsc defoma_0.11.10-4.tar.gz defoma_0.11.10-4_all.deb defoma-doc_0.11.10-4_all.deb psfontmgr_0.11.10-4_all.deb Greetings, Your Debian queue daemon (running on host ries.debian.org) -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#563121: Returning a status of non-zero might not be safe
YOSHINO Yoshihito yy.y.ja...@gmail.com (31/12/2009): Hello, Hi, test -x `which foo` foo bar baz returns status 1, which comes to an error if a script executed this as the last command. E.g. like #563121, prerm will exit with status 1 if defoma not found unless explicitly writing the last line exit 0 in the prerm template. So I think changing defoma templates like if test -x `which foo`; then foo bar baz fi that's what I stated in a later reply to this bug. would be good, since the script should simply ignore the block when defoma is not found. That's indeed what I implemented. Please, Cc the bug submitter in the future. I would have totally missed your mail if I wouldn't have used “bts -m show $bug” to make sure not to break the threading… Mraw, KiBi. signature.asc Description: Digital signature
defoma_0.11.10-4_amd64.changes ACCEPTED
Accepted: defoma-doc_0.11.10-4_all.deb to main/d/defoma/defoma-doc_0.11.10-4_all.deb defoma_0.11.10-4.dsc to main/d/defoma/defoma_0.11.10-4.dsc defoma_0.11.10-4.tar.gz to main/d/defoma/defoma_0.11.10-4.tar.gz defoma_0.11.10-4_all.deb to main/d/defoma/defoma_0.11.10-4_all.deb psfontmgr_0.11.10-4_all.deb to main/d/defoma/psfontmgr_0.11.10-4_all.deb Override entries for your package: defoma-doc_0.11.10-4_all.deb - optional doc defoma_0.11.10-4.dsc - source admin defoma_0.11.10-4_all.deb - optional admin psfontmgr_0.11.10-4_all.deb - optional admin Announcing to debian-devel-chan...@lists.debian.org Closing bugs: 563121 Thank you for your contribution to Debian. -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#563121: marked as done (dh_installdefoma leads to buggy maintainer scripts)
Your message dated Thu, 31 Dec 2009 13:17:09 +
with message-id e1nqktp-00021b...@ries.debian.org
and subject line Bug#563121: fixed in defoma 0.11.10-4
has caused the Debian Bug report #563121,
regarding dh_installdefoma leads to buggy maintainer scripts
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
563121: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=563121
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
---BeginMessage---
Package: defoma
Version: 0.11.10-3
Severity: grave
Justification: Fucks up fontconfig (at least), then buildds.
Hi,
dh_installdefoma leads to this kind of code in maintainer scripts:
test -x `which foo` foo bar baz
The trick being that if foo isn't found by which, “foo bar baz” gets
executed, leading to broken packages (see fontconfig's #559136 and
#560252 for examples).
A pair of quotes would fix this:
| k...@finzi:~$ test -x `which foo` foo bar baz
| -bash: foo: command not found
| k...@finzi:~$ test -x `which foo` foo bar baz
| k...@finzi:~$
I'm about to QA-upload defoma with this change in the various
debhelper-files/* files, but I wanted to open this bugreport for
reference.
Cc'ing defoma folks and buildd folks, since they might be interested in
knowing about this.
Mraw,
KiBi.
---End Message---
---BeginMessage---
Source: defoma
Source-Version: 0.11.10-4
We believe that the bug you reported is fixed in the latest version of
defoma, which is due to be installed in the Debian FTP archive:
defoma-doc_0.11.10-4_all.deb
to main/d/defoma/defoma-doc_0.11.10-4_all.deb
defoma_0.11.10-4.dsc
to main/d/defoma/defoma_0.11.10-4.dsc
defoma_0.11.10-4.tar.gz
to main/d/defoma/defoma_0.11.10-4.tar.gz
defoma_0.11.10-4_all.deb
to main/d/defoma/defoma_0.11.10-4_all.deb
psfontmgr_0.11.10-4_all.deb
to main/d/defoma/psfontmgr_0.11.10-4_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 563...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Cyril Brulebois k...@debian.org (supplier of updated defoma package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Format: 1.8
Date: Thu, 31 Dec 2009 13:16:08 +0100
Source: defoma
Binary: defoma defoma-doc psfontmgr
Architecture: source all
Version: 0.11.10-4
Distribution: unstable
Urgency: high
Maintainer: Debian QA Group packa...@qa.debian.org
Changed-By: Cyril Brulebois k...@debian.org
Description:
defoma - Debian Font Manager -- automatic font configuration framework
defoma-doc - Debian Font Manager documentation
psfontmgr - PostScript font manager -- part of Defoma, Debian Font Manager
Closes: 563121
Changes:
defoma (0.11.10-4) unstable; urgency=high
.
* QA upload.
* Fix dh_installdefoma: Use “if [ -x `which foo 2/dev/null` ]”
instead of test -x `which foo` since test -x without parameter
succeeds, leading to the execution of the next command, breaking
maintainer scripts (Closes: #563121).
* Set urgency to “high” accordingly.
* Introduce ${misc:Depends} for all binary packages.
Checksums-Sha1:
3dbab671b6d6166583d3ed68cf85b566ecd9795f 775 defoma_0.11.10-4.dsc
e467ce997a4ba3c9696535b473f0af9ff6888074 149111 defoma_0.11.10-4.tar.gz
251166bfcaa0f6b680992cfc6a428330a135e1dd 100918 defoma_0.11.10-4_all.deb
4554d46e4332311b9465f605a8a91a141d9d99e3 64112 defoma-doc_0.11.10-4_all.deb
8bd138d4c5970fe6cc750d7bfce071e45ef9 22718 psfontmgr_0.11.10-4_all.deb
Checksums-Sha256:
072ec5a98af059b318df3301bc38c382e6db2d7ebf540f4963fce16ccace97b2 775
defoma_0.11.10-4.dsc
b8b3fa4090f555f2609dfc02b292450f874aa660b5296579da816050189aa800 149111
defoma_0.11.10-4.tar.gz
a2121f1d86ac5ce85f24cc3cf5964dfced650adbc33ebb8f7abdabe06603fb1f 100918
defoma_0.11.10-4_all.deb
6dc6391489aa0170f072d3167e51b1f9881ccf9849a136ebc5b50df737d539a5 64112
defoma-doc_0.11.10-4_all.deb
41933990cf409c3adc0ba7c60bc84841954816fb8695c8472aea26a8de8a77fb 22718
psfontmgr_0.11.10-4_all.deb
Files:
b367887769d9d0ab33291ab3a7ab1dc8 775 admin optional defoma_0.11.10-4.dsc
796c9305e4fcdc0bac09e6dad31b6e41 149111 admin optional defoma_0.11.10-4.tar.gz
f7ed144e156aa4ab9d88506111fa885c 100918 admin optional defoma_0.11.10-4_all.deb
4a8ef2b1c608eb39359b60e16ac02681 64112 doc optional
defoma-doc_0.11.10-4_all.deb
Bug#563121: dh_installdefoma leads to buggy maintainer scripts
Cyril Brulebois k...@debian.org (31/12/2009):
Current/common practice within debhelper seems to be:
| if [ -x `which foo 2/dev/null` ]; then…
I think I'm going to upload with such a change once I'm up (for
real, not vaguely opening eyes).
Hi again,
I've just checked that fontconfig 2.8.0-1 built against the new defoma
was installable and removable with and without defoma installed. It
seems to be OK. So I guess you should be able to e.g. bump the
versioned BD on defoma to = 0.11.10-4 and reupload without the
bandaid; or wait until new defoma is installed on all architectures.
I hope I didn't miss anything.
I'm attaching the patches I used for further reference:
- dh_installdefoma fixes.
- lintian warning about ${misc:Depends} (trivial fix).
- changelog.
Some trivial lintian warnings/errors could have been fixed, but I feel
like I already spent too much time on defoma.
Mraw,
KiBi.
From f20657a059d3414427d9c08dec15da25c974a0df Mon Sep 17 00:00:00 2001
From: Cyril Brulebois k...@debian.org
Date: Thu, 31 Dec 2009 12:52:42 +0100
Subject: [PATCH 1/3] Switch to if [ -x `which foo 2/dev/null` ].
---
debhelper-files/postinst-defoma |6 +++---
debhelper-files/postinst-defoma-hints |4 +++-
debhelper-files/prerm-defoma |7 ---
debhelper-files/prerm-defoma-hints|4 +++-
4 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/debhelper-files/postinst-defoma b/debhelper-files/postinst-defoma
index 8819ce4..eeed4c7 100644
--- a/debhelper-files/postinst-defoma
+++ b/debhelper-files/postinst-defoma
@@ -1,5 +1,5 @@
if [ $1 = configure ]; then
-
- test -x `which defoma-app` defoma-app update #PACKAGE#
-
+ if [ -x `which defoma-app 2/dev/null` ]; then
+ defoma-app update #PACKAGE#
+ fi
fi
diff --git a/debhelper-files/postinst-defoma-hints b/debhelper-files/postinst-defoma-hints
index 83e1e8b..ae69812 100644
--- a/debhelper-files/postinst-defoma-hints
+++ b/debhelper-files/postinst-defoma-hints
@@ -1,4 +1,6 @@
FILE='/etc/defoma/hints/#PACKAGE#.hints'
if [ $1 = configure ]; then
- test -x `which defoma-font` defoma-font reregister-all $FILE
+ if [ -x `which defoma-font 2/dev/null` ]; then
+ defoma-font reregister-all $FILE
+ fi
fi
diff --git a/debhelper-files/prerm-defoma b/debhelper-files/prerm-defoma
index fc05dcc..d4a41e9 100644
--- a/debhelper-files/prerm-defoma
+++ b/debhelper-files/prerm-defoma
@@ -1,10 +1,11 @@
case $1 in
upgrade)
- test -x `which defoma-app` \
+ if [ -x `which defoma-app 2/dev/null` ]; then
defoma-app clean #PACKAGE#
+ fi
;;
remove)
- test -x `which defoma-app` \
+ if [ -x `which defoma-app 2/dev/null` ]; then
defoma-app purge #PACKAGE#
- ;;
+ fi
esac
diff --git a/debhelper-files/prerm-defoma-hints b/debhelper-files/prerm-defoma-hints
index 1fdef0f..df40f96 100644
--- a/debhelper-files/prerm-defoma-hints
+++ b/debhelper-files/prerm-defoma-hints
@@ -1,4 +1,6 @@
FILE='/etc/defoma/hints/#PACKAGE#.hints'
if [ $1 = remove ]; then
- test -x `which defoma-font` defoma-font purge-all $FILE
+ if [ -x `which defoma-font 2/dev/null` ]; then
+ defoma-font purge-all $FILE
+ fi
fi
--
1.6.5.7
From 9ce8c31833f91bd24128339810f8d60fbdeafebc Mon Sep 17 00:00:00 2001
From: Cyril Brulebois k...@debian.org
Date: Thu, 31 Dec 2009 13:19:32 +0100
Subject: [PATCH 2/3] Add ${misc:Depends} to all binaries.
---
debian/control |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/debian/control b/debian/control
index 5a73bd1..af57269 100644
--- a/debian/control
+++ b/debian/control
@@ -8,7 +8,7 @@ Standards-Version: 3.6.2.0
Package: defoma
Architecture: all
-Depends: whiptail | dialog, file, ${perl:Depends}
+Depends: whiptail | dialog, file, ${perl:Depends}, ${misc:Depends}
Enhances: debhelper
Suggests: defoma-doc, psfontmgr, x-ttcidfont-conf, dfontmgr
Recommends: libfont-freetype-perl
@@ -26,6 +26,7 @@ Description: Debian Font Manager -- automatic font configuration framework
Package: defoma-doc
Architecture: all
+Depends: ${misc:Depends}
Section: doc
Description: Debian Font Manager documentation
Defoma, which stands for DEbian FOnt MAnager, provides a framework
@@ -36,7 +37,7 @@ Description: Debian Font Manager documentation
Package: psfontmgr
Architecture: all
-Depends: defoma (= 0.9.1), whiptail | dialog, ${perl:Depends}
+Depends: defoma (= 0.9.1), whiptail | dialog, ${perl:Depends}, ${misc:Depends}
Conflicts: defoma-ps, scigraphica-common (= 0.7.1-3)
Description: PostScript font manager -- part of Defoma, Debian Font Manager
psfontmgr manages PostScript fonts through the Defoma framework. It
--
1.6.5.7
From 28019d205ce672ebd2849bb504c228ebede8ff6f Mon Sep 17 00:00:00 2001
From: Cyril Brulebois k...@debian.org
Date: Thu, 31 Dec 2009 13:19:43 +0100
Subject: [PATCH 3/3] Start changelog.
---
debian/changelog | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index 1758b4b..183fee3 100644
---
Bug#563166: gstreamer0.10-fluendo-mpegdemux and gstreamer0.10-fluendo-mpegmux installabled with gstreamer0.10-plugins-bad
Package: gstreamer0.10-fluendo-mpegdemux and gstreamer0.10-fluendo-mpegmux Version: testing Both packages are not installable together with gstreamer0.10-plugins-bad, but for in my case i do NOT want to uninstall gstreamer0.10-plugins-bad, as this package is needed by e.g. pidgin, etc... Thanks, Patrick -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
sgml-data 2.0.4 MIGRATED to testing
FYI: The status of the sgml-data source package in Debian's testing distribution has changed. Previous version: 2.0.3 Current version: 2.0.4 -- This email is automatically generated once a day. As the installation of new packages into testing happens multiple times a day you will receive later changes on the next day. See http://release.debian.org/testing-watch/ for more information. -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
remotefs 0.11+debian-3 MIGRATED to testing
FYI: The status of the remotefs source package in Debian's testing distribution has changed. Previous version: 0.11+debian-2 Current version: 0.11+debian-3 -- This email is automatically generated once a day. As the installation of new packages into testing happens multiple times a day you will receive later changes on the next day. See http://release.debian.org/testing-watch/ for more information. -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
xview 3.2p1.4-25 MIGRATED to testing
FYI: The status of the xview source package in Debian's testing distribution has changed. Previous version: 3.2p1.4-24 Current version: 3.2p1.4-25 -- This email is automatically generated once a day. As the installation of new packages into testing happens multiple times a day you will receive later changes on the next day. See http://release.debian.org/testing-watch/ for more information. -- To UNSUBSCRIBE, email to debian-qa-packages-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#563121: dh_installdefoma leads to buggy maintainer scripts
On Thu, 31 Dec 2009 09:03:59 +0100, Cyril Brulebois k...@debian.org wrote: Keith Packard kei...@keithp.com (30/12/2009): I'm about to QA-upload defoma with this change in the various debhelper-files/* files, but I wanted to open this bugreport for reference. Fortunately, I didn't do so, that wouldn't have helped (yay for sleeping before uploading :)). Here's a patch which I've used to build new fontconfig packages which should survive the absence of defoma. I don't think it would help. - test -x `which defoma-app` defoma-app update #PACKAGE# + which defoma-app /dev/null defoma-app update #PACKAGE# $ which doesnotexist /dev/null echo be happy $ echo $? 1 So the maintainer script bits generated by dh_installdefoma would still lead to non-0 exits. Check out the 'bash' manual -- set -e explicitly excludes precisely this case from causing early termination of the script: The shell does not exit if the command that fails is part of the command list immedi‐ ately following a while or until keyword, part of the test following the if or elif reserved words, part of any command executed in a or ⎪⎪ list except the command fol‐ lowing the final or ⎪⎪, any command in a pipeline but the last, or if the command's return value is being inverted with !. Current/common practice within debhelper seems to be: | if [ -x `which foo 2/dev/null` ]; then… That also seems fine, if a bit longer. I think I'm going to upload with such a change once I'm up (for real, not vaguely opening eyes). cool! I'd prefer to build fontconfig with your desired change; the set +e change will hold until then. I'll change the one other case to match whatever you choose to use. -- keith.pack...@intel.com pgprfFohmahds.pgp Description: PGP signature
Bug#563121: dh_installdefoma leads to buggy maintainer scripts
Keith Packard kei...@keithp.com (31/12/2009): Check out the 'bash' manual -- set -e explicitly excludes precisely this case from causing early termination of the script: […] Alrighty. I must confess I'm not really keen on checking what happens in the various shells, but that seems to be true under dash as well, so that might be OK. Current/common practice within debhelper seems to be: | if [ -x `which foo 2/dev/null` ]; then… ^^^ (debhelper-like syntax) ^^^ That also seems fine, if a bit longer. I think I'm going to upload with such a change once I'm up (for real, not vaguely opening eyes). cool! I'd prefer to build fontconfig with your desired change; the set +e change will hold until then. I'll change the one other case to match whatever you choose to use. In the meanwhile, defoma was uploaded with the debhelper-like syntax (as quoted above). In my previous mail[1], you can scratch “until new defoma is installed on all architectures” since it's arch: all. ;) 1. http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=35;bug=563121 Mraw, KiBi. signature.asc Description: Digital signature
Bug#563121: dh_installdefoma leads to buggy maintainer scripts
On Thu, 31 Dec 2009 18:44:18 +0100, Cyril Brulebois k...@debian.org wrote: In the meanwhile, defoma was uploaded with the debhelper-like syntax (as quoted above). In my previous mail[1], you can scratch “until new defoma is installed on all architectures” since it's arch: all. ;) Ok, I've adopted the same syntax in fontconfig 2.8.0-2 and uploaded that (after testing in a chroot). Please let me know asap if anything breaks with this version. -- keith.pack...@intel.com pgpGaC60XabMO.pgp Description: PGP signature
