Bug#706047: unblock bacula/5.2.6+dfsg-9

2013-04-27 Thread Alexander Golovko 
В Sat, 27 Apr 2013 00:13:10 +0100
Jonathan Wiltshire j...@debian.org пишет:

 Control: tag -1 + confirmed
 
 On Wed, Apr 24, 2013 at 02:17:12AM +0400, Alexander Golovko wrote:
  Package: release.debian.org
  Severity: normal
  User: release.debian@packages.debian.org
  Usertags: unblock
  
  Hi!
  
  Does all prepared changes acceptable for unblock?
  
  
  debdiff between 5.2.6+dfsg-8 and prepared 5.2.6+dfsg-9 in attach.
  
  
  1. Update info about upstream license changes.
  
  Upstream change license since squeeze release, but this was not
  properly described in debian/copyright.
  
  
  2. Remove incorrect systemd service file for bacula-fd due to
  unaccepted for freeze changes in fixes (Closes: #699943).
  
  This changes is a continue of 5.2.6+dfsg-7. I incorrectly think,
  that bacula-fd systemd service file workable and did not remove it,
  but systemd maintainers prefer to remove this file too.
 
 Please upload urgently.

Uploaded into sid


 
 
 --
 Jonathan Wiltshire  j...@debian.org
 Debian Developer http://people.debian.org/~jmw
 
 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51
 
 directhex i have six years of solaris sysadmin experience, from
 8-10. i am well qualified to say it is made from bonghits
   layered on top of bonghits


-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Bug#706047: unblock bacula/5.2.6+dfsg-9

2013-04-23 Thread Alexander Golovko 
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hi!

Does all prepared changes acceptable for unblock?


debdiff between 5.2.6+dfsg-8 and prepared 5.2.6+dfsg-9 in attach.


1. Update info about upstream license changes.

Upstream change license since squeeze release, but this was not
properly described in debian/copyright.


2. Remove incorrect systemd service file for bacula-fd due to
unaccepted for freeze changes in fixes (Closes: #699943).

This changes is a continue of 5.2.6+dfsg-7. I incorrectly think, that
bacula-fd systemd service file workable and did not remove it, but
systemd maintainers prefer to remove this file too.



-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru
diffstat for bacula-5.2.6+dfsg bacula-5.2.6+dfsg

 bacula-fd.install |1 
 changelog |   10 
 copyright |  707 --
 3 files changed, 701 insertions(+), 17 deletions(-)

diff -Nru bacula-5.2.6+dfsg/debian/bacula-fd.install bacula-5.2.6+dfsg/debian/bacula-fd.install
--- bacula-5.2.6+dfsg/debian/bacula-fd.install	2013-01-29 16:42:27.0 +0400
+++ bacula-5.2.6+dfsg/debian/bacula-fd.install	2013-04-24 01:55:47.0 +0400
@@ -1,3 +1,2 @@
 usr/sbin/bacula-fd
 usr/lib/bacula/bpipe-fd.so
-platforms/systemd/bacula-fd.service	lib/systemd/system
diff -Nru bacula-5.2.6+dfsg/debian/changelog bacula-5.2.6+dfsg/debian/changelog
--- bacula-5.2.6+dfsg/debian/changelog	2013-01-29 18:47:28.0 +0400
+++ bacula-5.2.6+dfsg/debian/changelog	2013-04-24 01:56:14.0 +0400
@@ -1,3 +1,13 @@
+bacula (5.2.6+dfsg-9) unstable; urgency=low
+
+  * debian/copyright:
++ Update info about upstream license changes.
+  * debian/bacula-fd.install:
+- Remove incorrect systemd service file for bacula-fd due to unaccepted for
+  freeze changes in fixes (Closes: #699943).
+
+ -- Alexander Golovko alexan...@ankalagon.ru  Wed, 24 Apr 2013 01:56:12 +0400
+
 bacula (5.2.6+dfsg-8) unstable; urgency=high
 
   * debian/additions/common-functions.dpkg:
diff -Nru bacula-5.2.6+dfsg/debian/copyright bacula-5.2.6+dfsg/debian/copyright
--- bacula-5.2.6+dfsg/debian/copyright	2013-01-29 16:42:27.0 +0400
+++ bacula-5.2.6+dfsg/debian/copyright	2013-04-24 01:55:20.0 +0400
@@ -3,6 +3,11 @@
 jgoer...@complete.org and now by the Debian Bacula Team
 pkg-bacula-de...@lists.alioth.debian.org.
 
+Debian-specific files distributed under terms of GPLv2, because:
+ * at moment of packaging upstream license was GPLv2
+ * files was created without explicit license info, that considered as the
+   same license, as upstream.
+
 It was downloaded from http://www.bacula.org
 
 Upstream Authors: Kern Sibbald ke...@users.sourceforge.net and John Walker.
@@ -11,7 +16,8 @@
 The original Bacula code was Copyright Kern Sibbald and John Walker.
 After November 2004, it became Copyright Kern Sibbald, and finally,
 the copyright was transferred to the Free Software Foundation Europe
-on 15 November 2006.
+on 15 November 2006. The license was changed from GPLv2 to AGPLv3
+on 24 July 2010.
 
 Trademark:
 The name Bacula is a registered trademark of Kern Sibbald.
@@ -19,31 +25,31 @@
 ===
 
 License:
-For the most part, Bacula is licensed under the GPL version 2. This
+For the most part, Bacula is licensed under the AGPL version 3. This
 code is listed under Copyright Free Software Foundation Europe e.V.
-What follows is the addition(s) to the GPL version 2 license, that
+What follows is the addition(s) to the AGPL version 3 license, that
 applies to code that is copyrighted by the Free Software Foundation
 Europe e.V.
 
 Linking: 
-As a special exception to the GPLv2, the Bacula Project gives
+As a special exception to the AGPLv3, the Bacula Project gives
 permission to link the code of its release of Bacula with the OpenSSL
 project's OpenSSL library (or with modified versions of it that use
 the same license as the OpenSSL library), and distribute the linked
-executables.  You must obey the GNU General Public License in all
+executables.  You must obey the GNU Affero General Public License in all
 respects for all of the code used other than OpenSSL.
 
-As a special exception to the GPLv2, the Bacula Project gives
+As a special exception to the AGPLv3, the Bacula Project gives
 permission to link the code of its release of the Bacula Win32 File
 daemon with the Microsoft supplied Volume Shadow Copy (VSS) libraries
 and distribute the linked executables.  You must obey the GNU General
 Public License in all respects for all of the code used other than for
 the Microsoft VSS code, where you must obey their license terms.
 
-The Bacula Project gives permission for plugins with GPLv2 compatible
+The Bacula Project gives permission for plugins with AGPLv3 compatible
 licenses to be loaded and distributed with the Bacula executables as
 long as the combined

Bug#699492: unblock bacula-doc/5.2.6-2

2013-04-22 Thread Alexander Golovko 
Argh, i reply only to message about copyrights, but do not reply to
this.

В Mon, 18 Feb 2013 19:55:41 +
Jonathan Wiltshire j...@debian.org пишет:

 Control: tag -1 + moreinfo
 
 On Fri, Feb 01, 2013 at 02:55:54AM +0400, Alexander Golovko wrote:
  Package: release.debian.org
  Severity: normal
  User: release.debian@packages.debian.org
  Usertags: unblock
  
  Hi!
  
  Please, unblock bacula-doc/5.2.6-2.
  This is change in major version, but this will fix situation, that
  we ship in wheezy different versions of package and documentation
  (package 5.2.6 and docs for 5.0.2).
 
 Whilst I agree that we should have same versions of the package and
 documentation, and I'd be more leniant that usual given that it's
 just documentation, there are problems that mean I'm not prepared
 to unblock this version.
 
  +bacula-doc (5.2.6-2) unstable; urgency=low
 
 You aren't listed in Uploaders or Maintainers, so this should be an
 NMU version number and have a note in the changelog.

Package maintainer is Debian Bacula Team, i'm one of members of this
team.

 
  +bacula-doc (5.2.6-1) unstable; urgency=low
  +
  +  [ Alexander Golovko ]
  +  * debian/patches/remove-config-generated-file-in-source.patch, 
  +debian/patches/series, debian/rules,
  debian/source.lintian-overrides:
  ++ change method for remove config.{log,status} from sources.
 
 Why? Apart from the ick of using quilt to remove this file, you now
 have to update that patch every time the file changes, which is
 probably every upstream release. Was there a problem caused by the
 previous behaviour?

This is a fix for error 'aborting due to unexpected upstream changes',
when try to build package by git-buildpackage --git-pbuilder.

Upstream was informed about this files and new versions ships without
it, so we will not be require to change this patch every new upstream
version.


 
  +  * Bump standards to 3.9.4 (no changes).
  +  * debian/compat: bump to 9.
  +debian/control: set dpendency debhelper to 9.
 
 These are a definite 'no' (although I realise the dependency was
 reverted).

Ok, standards bumping will be reverted for wheezy, all other changes
already was reverted.


-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Bug#699492: [pkg-bacula-devel] Bug#699492: unblock bacula-doc/5.2.6-2

2013-04-22 Thread Alexander Golovko 
В Mon, 22 Apr 2013 19:56:06 +0200
Julien Cristau jcris...@debian.org пишет:

 On Mon, Apr 22, 2013 at 17:59:26 +0400, Alexander Golovko wrote:
 
  Argh, i reply only to message about copyrights, but do not reply to
  this.
  
 For the record:
 
  jmw alexandro: ok, I am not near a mail client and can't follow up 
there. you need to: sort out the copyright file as you think
 best; put Team Upload in the changelog or add yourself to
 uploaders; revert the standards version bump. the quilt bit is a
 little yucky but if it's sorted out upstream then I don't mind that.
 with those changes you can upload and then ping the unblock bug.
 thanks for working on it

Thank you!

bacula-doc 5.2.6-3 was uploaded.

* debian/control:
  - Revert bumping standards to 3.9.4.
  + Add itself to uploaders.
* debian/copyright:
  + Switch to DEP-5 format.
  + Update license information.


But now we should also fix license information in bacula packages,
because upstream change license from GPL-2 to AGPL-3. I can simply copy
upstream license file or convert it to DEP-5 too. What is preferable?
Current copyright file was copied from previous upstream license file
with minimum changes about packaging.


 
 Cheers,
 Julien


-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Bug#699492: unblock bacula-doc/5.2.6-2

2013-04-08 Thread Alexander Golovko 
В Mon, 08 Apr 2013 21:25:08 +0100
Adam D. Barratt a...@adam-barratt.org.uk пишет:

 On Sun, 2013-03-24 at 21:11 +, Jonathan Wiltshire wrote:
  On Mon, Feb 18, 2013 at 08:18:16PM +, Jonathan Wiltshire wrote:
   On Mon, Feb 18, 2013 at 07:55:41PM +, Jonathan Wiltshire
   wrote:
On Fri, Feb 01, 2013 at 02:55:54AM +0400, Alexander Golovko
wrote:
 Please, unblock bacula-doc/5.2.6-2.
 This is change in major version, but this will fix situation,
 that we ship in wheezy different versions of package and
 documentation (package 5.2.6 and docs for 5.0.2).
   
   I also meant to say that debian/copyright claims the license is
   GFDL, Wheezy's upstream headers claim GPL and sid's upstream
   headers claim AGPL. That needs sorting out, preferably with a
   complete audit and update of debian/copyright.
  
  Ping?
 
 Ping? If there's no reply shortly then we'll have to decline.

Very sorry for previous unreplied messages, was in unadequate hope to
solve in nearest time and then reply, but this covered :(

Will try to solve this immediately.

 
 Regards,
 
 Adam
 
 


-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Bug#699492: unblock bacula-doc/5.2.6-2

2013-04-08 Thread Alexander Golovko 
В Sun, 24 Mar 2013 21:11:34 +
Jonathan Wiltshire j...@debian.org пишет:

 On Mon, Feb 18, 2013 at 08:18:16PM +, Jonathan Wiltshire wrote:
  On Mon, Feb 18, 2013 at 07:55:41PM +, Jonathan Wiltshire wrote:
   Control: tag -1 + moreinfo
   
   On Fri, Feb 01, 2013 at 02:55:54AM +0400, Alexander Golovko wrote:
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hi!

Please, unblock bacula-doc/5.2.6-2.
This is change in major version, but this will fix situation,
that we ship in wheezy different versions of package and
documentation (package 5.2.6 and docs for 5.0.2).
  
  I also meant to say that debian/copyright claims the license is
  GFDL, Wheezy's upstream headers claim GPL and sid's upstream
  headers claim AGPL. That needs sorting out, preferably with a
  complete audit and update of debian/copyright.
 
 Ping?
 

Bacula (as software) in wheezy and sid distributed under terms of AGPL-3
with some exceptions. Version from squeeze distributed under terms of
GPLv2+. There is incorrect debian/copyright in wheezy and sid.

Bacula documentation stored in separated repo, not in the same as main
code. There is no copyright info in repo, but online documentation
distributed under terms of GFDL-1.2.

Is it true, that we should fix debian/copyright for bacula packages and
don't touch it for bacula-doc package?



-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Bug#699492: unblock bacula-doc/5.2.6-2

2013-01-31 Thread Alexander Golovko 
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hi!

Please, unblock bacula-doc/5.2.6-2.
This is change in major version, but this will fix situation, that we
ship in wheezy different versions of package and documentation (package
5.2.6 and docs for 5.0.2).

Differences in debian/ structure between 5.0.2-4 and 5.2.6-2 in attach.
There were excluded from diff next files: debian/patches/* and
debian/fake-bacula-source/


-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru
diff -urEZwbBN -x patches -x fake-bacula-source bacula-doc-5.0.2/debian/changelog bacula-doc/debian/changelog
--- bacula-doc-5.0.2/debian/changelog	2011-12-16 20:17:48.0 +0400
+++ bacula-doc/debian/changelog	2013-02-01 02:22:08.809411200 +0400
@@ -1,3 +1,39 @@
+bacula-doc (5.2.6-2) unstable; urgency=low
+
+  * Revert dependency from debhelper = 9.
+  * debian/rules:
++ Don't compress documentation in libreoffice formats.
+  * debian/gbp.conf:
++ Fix option name for bz2 compression.
+
+ -- Alexander Golovko alexan...@ankalagon.ru  Fri, 01 Feb 2013 02:22:07 +0400
+
+bacula-doc (5.2.6-1) unstable; urgency=low
+
+  [ Alexander Golovko ]
+  * debian/patches/remove-config-generated-file-in-source.patch, 
+debian/patches/series, debian/rules, debian/source.lintian-overrides:
++ change method for remove config.{log,status} from sources.
+
+  [ Willem van den Akker ]
+  * New maintainer (Closes: #612297).
+  * New upstream release.
+  * debian/control: 
++ changed maintainer to Debian Bacula Team.
++ added Vcs-Git, Vcs-Browser and Homepage tags.
++ added myself to uploaders list.
+  * debian/patches/tex-styles-and-path: changed hardcoded version numbers.
+  * debian/fake-bacula-source: updated version.h from the 
+bacula-5.2.6+dfsg.orig.tar.gz file.
+  * Bump standards to 3.9.4 (no changes).
+  * debian/compat: bump to 9.
+debian/control: set dpendency debhelper to 9.
+  * debian/watch: file added.
+  * debian/gbd.conf: changed pristine-tar to pristine-bz2. Source is shipped
+as bz2 file.
+
+ -- Willem van den Akker wvdak...@wilsoft.nl  Fri, 25 Jan 2013 08:32:44 +0100
+
 bacula-doc (5.0.2-4) unstable; urgency=low
 
   [Alexander Reichle-Schmehl]
diff -urEZwbBN -x patches -x fake-bacula-source bacula-doc-5.0.2/debian/control bacula-doc/debian/control
--- bacula-doc-5.0.2/debian/control	2011-12-16 20:12:36.0 +0400
+++ bacula-doc/debian/control	2013-01-31 17:58:24.316930676 +0400
@@ -1,11 +1,15 @@
 Source: bacula-doc
 Section: doc
 Priority: optional
-Maintainer: Debian QA Group packa...@qa.debian.org
+Maintainer: Debian Bacula Team pkg-bacula-de...@lists.alioth.debian.org
+Uploaders: Willem van den Akker wvdak...@wilsoft.nl
 Build-Depends: debhelper (= 7), autoconf, autotools-dev,
  texlive-base, texlive-latex-recommended, texlive-fonts-recommended,
  ghostscript
-Standards-Version: 3.9.2
+Standards-Version: 3.9.4
+Vcs-Browser: http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula-doc.git;a=summary
+Vcs-Git: git://anonscm.debian.org/pkg-bacula/bacula-doc.git
+Homepage: http://www.bacula.org/
 
 Package: bacula-doc
 Architecture: all
diff -urEZwbBN -x patches -x fake-bacula-source bacula-doc-5.0.2/debian/gbp.conf bacula-doc/debian/gbp.conf
--- bacula-doc-5.0.2/debian/gbp.conf	2011-02-09 20:59:40.0 +0300
+++ bacula-doc/debian/gbp.conf	2013-02-01 02:19:08.849408340 +0400
@@ -1,3 +1,3 @@
 [DEFAULT]
-pristine-tar = True
-git-compression = bzip2
+pristine-bz2 = True
+compression = bzip2
diff -urEZwbBN -x patches -x fake-bacula-source bacula-doc-5.0.2/debian/rules bacula-doc/debian/rules
--- bacula-doc-5.0.2/debian/rules	2011-12-16 20:17:17.0 +0400
+++ bacula-doc/debian/rules	2013-02-01 01:07:54.773340390 +0400
@@ -41,7 +41,7 @@
 	rm -f build-stamp configure-stamp
 	-rm -rf $(BUILDDIR)
 	dh_autotools-dev_restoreconfig
-	dh_clean config.status config.log
+	dh_clean
 
 install: build
 	dh_testdir
@@ -75,7 +75,7 @@
 	dh_installman
 	dh_link
 	dh_strip
-	dh_compress -X.pdf
+	dh_compress -X.odp -X.ods -X.odt -X.pdf -X.sxw
 	dh_fixperms
 #	dh_perl
 #	dh_makeshlibs
diff -urEZwbBN -x patches -x fake-bacula-source bacula-doc-5.0.2/debian/source.lintian-overrides bacula-doc/debian/source.lintian-overrides
--- bacula-doc-5.0.2/debian/source.lintian-overrides	2011-12-16 20:05:30.0 +0400
+++ bacula-doc/debian/source.lintian-overrides	1970-01-01 03:00:00.0 +0300
@@ -1,4 +0,0 @@
-# they are cleaned in debian/rules clean target
-bacula-doc source: configure-generated-file-in-source config.status
-bacula-doc source: configure-generated-file-in-source config.log
-
diff -urEZwbBN -x patches -x fake-bacula-source bacula-doc-5.0.2/debian/watch bacula-doc/debian/watch
--- bacula-doc-5.0.2/debian/watch	1970-01-01 03:00:00.0 +0300
+++ bacula-doc/debian/watch	2013-01-31 17:48:16.852921018 +0400
@@ -0,0 +1,2 @@
+version=3
+http://sf.net/bacula/bacula-docs-?([\w+\d+\.]+|\d+)\.tar

Bug#699326: unblock: bacula/5.2.6+dfsg-8

2013-01-30 Thread Alexander Golovko 
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hi!

Please unblock bacula-* packages, it fixes security bug #699244
(service run with incorrect permissions)

debdiff --diffstat output attached

Thank you!

-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru
diffstat for bacula-5.2.6+dfsg bacula-5.2.6+dfsg

 additions/common-functions.dpkg |7 ++-
 changelog   |7 +++
 2 files changed, 9 insertions(+), 5 deletions(-)

diff -Nru bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg 
bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg
--- bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg2013-01-03 
00:53:46.0 +0400
+++ bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg2013-01-29 
18:46:09.0 +0400
@@ -162,16 +162,14 @@
 bacula-fd)
 SERVICE=bacula-fd
 ARGS=
-DEFAULT_ARGS=
 ;;
 bacula-sd)
 SERVICE=bacula-sd
 ARGS=-u bacula -g tape
-DEFAULT_ARGS=-u bacula -g tape
 ;;
 bacula-director-pgsql|bacula-director-mysql|bacula-director-sqlite3)
 SERVICE=bacula-dir
-DAEMONUSER=bacula:bacula
+ARGS=-u bacula -g bacula
 if ucfq -w /etc/default/bacula-dir \
 |egrep -q '^[^:]*:bacula-director-(pgsql|mysql|sqlite3):'; then
 UCFR_ARGS=-f
@@ -197,7 +195,6 @@
 else
 if [ -f $DEFAULTS ]; then
 ENABLED=$(. $DEFAULTS; echo $ENABLED)
-ARGS=$(. $DEFAULTS; echo $ARGS)
 CONFIG=$(. $DEFAULTS; echo $CONFIG)
 fi
 fi
@@ -219,7 +216,7 @@
 ENABLED=$ENABLED
 
 # Additional start arguments can be provided here
-# ARGS=$DEFAULT_ARGS
+# ARGS=$ARGS
 ARGS=$ARGS
 
 # Default config file can be changed here
diff -Nru bacula-5.2.6+dfsg/debian/changelog bacula-5.2.6+dfsg/debian/changelog
--- bacula-5.2.6+dfsg/debian/changelog  2013-01-08 16:01:40.0 +0400
+++ bacula-5.2.6+dfsg/debian/changelog  2013-01-29 18:47:28.0 +0400
@@ -1,3 +1,10 @@
+bacula (5.2.6+dfsg-8) unstable; urgency=high
+
+  * debian/additions/common-functions.dpkg:
++ Fix missed user for run bacula-director (Closes: #699244).
+
+ -- Alexander Golovko alexan...@ankalagon.ru  Tue, 29 Jan 2013 18:47:27 +0400
+
 bacula (5.2.6+dfsg-7) unstable; urgency=low
 
   * debian/bacula-sd.install, bacula-director-{sqlite3,mysql,pgsql}.install,


signature.asc
Description: PGP signature

Bug#699326: unblock: bacula/5.2.6+dfsg-8

2013-01-30 Thread Alexander Golovko 
В Wed, 30 Jan 2013 20:40:07 +0100
Julien Cristau jcris...@debian.org пишет:

 On Wed, Jan 30, 2013 at 14:33:49 +0400, Alexander Golovko wrote:
 
  diffstat for bacula-5.2.6+dfsg bacula-5.2.6+dfsg
  
   additions/common-functions.dpkg |7 ++-
   changelog   |7 +++
   2 files changed, 9 insertions(+), 5 deletions(-)
  
  diff -Nru bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg
  bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg ---
  bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg
  2013-01-03 00:53:46.0 +0400 +++
  bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg
  2013-01-29 18:46:09.0 +0400
 
 How/where is this file used?

Changed code used for generate /etc/default/bacula-{fd,sd,director}
files. Defaults file for bacula-director in 5.2.6+dfsg-7 incorrectly
set empty arguments string (there is error in reverting some changes),
which lead to run service with root privileges.


-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Bug#689003: unblock: bacula/5.2.6+dfsg-5

2013-01-13 Thread Alexander Golovko 
В Wed, 2 Jan 2013 23:28:50 +0400
Alexander Golovko alexan...@ankalagon.ru пишет:

 В Sat, 1 Dec 2012 14:02:30 +0100
 Julien Cristau jcris...@debian.org пишет:
 
  On Mon, Nov 26, 2012 at 01:24:19 +0400, Alexander Golovko wrote:
  
   Sorry, i don't see any reply.
   
   I prepare package for wheezy, changelog here:
   http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=blob;f=debian/changelog;h=56223bdd477cd7a52770eae92cfc5d1c857dea27;hb=wheezy
   
   i try to make each changelog record as separate commit with clean
   description:
   http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=shortlog;h=refs/heads/wheezy
   
   If i has not a mess, than all changes except one was accepted.
   I didn't get final reply about #556207 (see inline).
   
  I thought it was clear I'm not convinced this change is suitable.
  Please drop it.
 
 Ok
 
  
   And i have yet another question - there was a non-maintainer
   upload. What package version should be now?
   
  I would much prefer if this was a 5.2.6+dfsg-7 version, uploaded to
  sid, and including only the approved changes, rather than a direct
  upload to testing.
 
 Ok, 5.2.6+dfsg-7 prepared. 
 Additional changes - add dutch translation and update info about
 upstream bugs in patches.
 
 Also i have a question about opened bugs 605449 and 694046. Can be
 fixes included into wheezy or not?

Please, unblock 5.2.6+dfsg-7 (#605449 included, #694046 - not).


 
 If this is interest, git history was changed. Subtree [1] with clean
 changes since 5.2.6+dfsg-2 was merged [2] into master branch without
 undescribed changes [3]
 
 [1]
 http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=595829670fcf9555b1f50897655d3ae23cca65e6
 
 [2]
 http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=bbe70c0b38617576fb67a318007c70818007306d
 
 [3]
 http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commitdiff;h=bbe70c0b38617576fb67a318007c70818007306d;hp=595829670fcf9555b1f50897655d3ae23cca65e6
 
 


-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Bug#689003: unblock: bacula/5.2.6+dfsg-5

2013-01-02 Thread Alexander Golovko 
В Sat, 1 Dec 2012 14:02:30 +0100
Julien Cristau jcris...@debian.org пишет:

 On Mon, Nov 26, 2012 at 01:24:19 +0400, Alexander Golovko wrote:
 
  Sorry, i don't see any reply.
  
  I prepare package for wheezy, changelog here:
  http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=blob;f=debian/changelog;h=56223bdd477cd7a52770eae92cfc5d1c857dea27;hb=wheezy
  
  i try to make each changelog record as separate commit with clean
  description:
  http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=shortlog;h=refs/heads/wheezy
  
  If i has not a mess, than all changes except one was accepted.
  I didn't get final reply about #556207 (see inline).
  
 I thought it was clear I'm not convinced this change is suitable.
 Please drop it.

Ok

 
  And i have yet another question - there was a non-maintainer upload.
  What package version should be now?
  
 I would much prefer if this was a 5.2.6+dfsg-7 version, uploaded to
 sid, and including only the approved changes, rather than a direct
 upload to testing.

Ok, 5.2.6+dfsg-7 prepared. 
Additional changes - add dutch translation and update info about
upstream bugs in patches.

Also i have a question about opened bugs 605449 and 694046. Can be
fixes included into wheezy or not?

If this is interest, git history was changed. Subtree [1] with clean
changes since 5.2.6+dfsg-2 was merged [2] into master branch without
undescribed changes [3]

[1]
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=595829670fcf9555b1f50897655d3ae23cca65e6

[2]
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=bbe70c0b38617576fb67a318007c70818007306d

[3]
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commitdiff;h=bbe70c0b38617576fb67a318007c70818007306d;hp=595829670fcf9555b1f50897655d3ae23cca65e6


-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Bug#689003: unblock: bacula/5.2.6+dfsg-5

2013-01-01 Thread Alexander Golovko 
В Tue, 1 Jan 2013 23:35:35 +0100
Julien Cristau jcris...@debian.org пишет:

 On Sat, Dec  1, 2012 at 14:02:30 +0100, Julien Cristau wrote:
 
  I would much prefer if this was a 5.2.6+dfsg-7 version, uploaded to
  sid, and including only the approved changes, rather than a direct
  upload to testing.
  
 Ping?

pong.
I'm sorry for delay, will rework 5.2.6+dfsg-2+deb7u1 into 5.2.6+dfsg-7
until end of week.


 
 Cheers,
 Julien


-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Bug#689003: unblock: bacula/5.2.6+dfsg-5

2012-11-25 Thread Alexander Golovko 
Sorry, i don't see any reply.

I prepare package for wheezy, changelog here:
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=blob;f=debian/changelog;h=56223bdd477cd7a52770eae92cfc5d1c857dea27;hb=wheezy

i try to make each changelog record as separate commit with clean
description:
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=shortlog;h=refs/heads/wheezy

If i has not a mess, than all changes except one was accepted.
I didn't get final reply about #556207 (see inline).

And i have yet another question - there was a non-maintainer upload.
What package version should be now?


В Fri, 9 Nov 2012 10:12:29 +0400
Alexander Golovko alexan...@ankalagon.ru пишет:

 В Thu, 8 Nov 2012 23:10:46 +0100
 Julien Cristau jcris...@debian.org пишет:
 
  On Fri, Nov  9, 2012 at 01:07:18 +0400, Alexander Golovko wrote:
  
   bacula daemons SIGSEGV handler can call gdb for save some useful
   (for developers) info about process (stack for all threads and
   other). Gdb called with bacula user privileges, but files
   in /proc/pid/ owned by root and gdb can't get info about
   process. This is subject of bug #556207.
   
  Or you could just let the kernel get you a core file with all the
  info you would want.  
 
 Yes, coredump will be enough and in some cases it required for solve
 problem. But it contain some information, such a passwords, that
 1. make impossible coredump publication
 2. require password changing even after privately sending
 coredump to developers due to possibility of passwords leakage.
 
 But thank you for attention to this moment, there is a bacula bug -
 daemons don't create coredumps on such signals, i will send bugreport
 to upstream.

1. we can't get coredump for bacula daemons
http://bugs.bacula.org/view.php?id=1949

2. Upstream declare, that backtrace output enough for bugreports about
crashes.


 
 
 
  I'm sorry, but I don't think this is worthy of
  breaking the freeze.
  
   Yes, user still must install -dbg packages before this will
   work, but this is not so hard work for them as manually changing
   init scripts.
   
  Seriously, editing a shell script, hard work?
  

Seriously, user must know, what to change before edit shell script.
I can add this to documentation, but will not be this poinlessly?


-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Bug#689003: unblock: bacula/5.2.6+dfsg-5

2012-11-08 Thread Alexander Golovko 
В Wed, 7 Nov 2012 18:35:44 +0100
Moritz Muehlenhoff j...@inutil.org пишет:

 On Wed, Oct 24, 2012 at 06:28:47PM +0200, Moritz Muehlenhoff wrote:
 
 [..]
 
 Alexander, what's the status?

I am sorry for delay!

Most of changes prepared with clean commits, but i still need reply to
question about systemd changes:


3. fix daemons user/group on systems with systemd (Closes:
#679958). delegate daemons uid/gid changing to
start-stop-daemon or systemd, thanks to Matija Nalis (Closes:
#556207).

This changes are related and intersected. First commit reverted
by last.

http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=d077cd3c71734828b635f8605c8411f6cd86b6f6
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=cf9eb640182f4adfd83d05954dc35a20b60170c1
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=694b788e0f82a734ca98bb0930a97432240c7fe8

Upstream already much time (at least since 2010, Oct) use
start-stop-daemon for change daemons uid/gid in their variant of
init scripts. Our patch for uid/gid changing by systemd was
already accepted into upstream. 

The big problem, that without this change user can't simply get
backtraces on daemons crashes. This backtraces required for some
bugreport to upstream.
  
   Meh.  Can't the systemd files be simply removed?  If this doesn't
   affect sysvinit systems I would prefer not to bother.  
  
  Hmm. But systemd service files was added to package in 5.2.6+dfsg-1
  via bug #624532. And patch for fix them is trivial.

 Apparently not so trivial, since it needs a fixup now.  I would rather
 not see a change that affects all paths to fix something for the .1%
 of users that run systemd.  

ohh. i think, that will be better to split explanation of this change
into two parts.

First - changes in sysvinit scripts. Instead of run daemons as root and
pass options for chuid we allow start-stop-daemon to run it as
non-root. This is what do upstream and without this fix we have a
problems with getting backtraces on daemons crashes.

Second - changes in systemd service files. In 5.2.6+dfsg-1 our team add
this files into packages, but unfortunely, they was shipped with
incorrect (empty) uid/gid in them.
So, for systemd service files was fixed two problems:
a) Change daemons uid/gid by systemd, as do sysvinit scripts. This
is separate patch [1] for simplicity sending it to upstream (already
accepted by upstream)
b) Fixing incorrect uid/gid. Due to limitation of upstream build
system we can't use build options and hardcore uid/gid by patch [2]

[1]
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=blob;f=debian/patches/delegate-chuid-to-systemd.patch
[2]
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=blob;f=debian/patches/fix-systemd-daemon-user-group.patch

As i understand, your opinion is that will be better do not ship
systemd service files at all, but include changes in sysvinit scripts?



-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Bug#689003: unblock: bacula/5.2.6+dfsg-5

2012-11-08 Thread Alexander Golovko 
В Thu, 8 Nov 2012 19:45:00 +0100
Julien Cristau jcris...@debian.org пишет:

 On Thu, Nov  8, 2012 at 13:26:33 +0400, Alexander Golovko wrote:
 
  ohh. i think, that will be better to split explanation of this
  change into two parts.
  
  First - changes in sysvinit scripts. Instead of run daemons as root
  and pass options for chuid we allow start-stop-daemon to run it as
  non-root. This is what do upstream and without this fix we have a
  problems with getting backtraces on daemons crashes.
  
 That doesn't sound like freeze material to me, as the current scripts
 work.  I don't understand your comment about backtraces.

bacula daemons SIGSEGV handler can call gdb for save some useful (for
developers) info about process (stack for all threads and other). Gdb
called with bacula user privileges, but files in /proc/pid/ owned by
root and gdb can't get info about process. This is subject of bug
#556207.

Yes, user still must install -dbg packages before this will work, but
this is not so hard work for them as manually changing init scripts.


 
  Second - changes in systemd service files. In 5.2.6+dfsg-1 our team
  add this files into packages, but unfortunely, they was shipped with
  incorrect (empty) uid/gid in them.
  So, for systemd service files was fixed two problems:
  a) Change daemons uid/gid by systemd, as do sysvinit scripts. This
  is separate patch [1] for simplicity sending it to upstream (already
  accepted by upstream)
  b) Fixing incorrect uid/gid. Due to limitation of upstream build
  system we can't use build options and hardcore uid/gid by patch [2]
  
  [1]
  http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=blob;f=debian/patches/delegate-chuid-to-systemd.patch
  [2]
  http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=blob;f=debian/patches/fix-systemd-daemon-user-group.patch
  
  As i understand, your opinion is that will be better do not ship
  systemd service files at all, but include changes in sysvinit
  scripts?
  
 I don't think that reflects my opinion.  My understanding is that the
 current init script works, and if that is true then the current init
 script doesn't need to be changed.

Current init scripts work, but have a bug, as described above.


 I don't particularly care what
 happens to the systemd files, though if the current ones don't work
 then I'd kinda prefer to see them go away rather than get more
 changes.

Hmm, but if users want worked systemd files (#679958), is it really
prefer to drop systemd support over fix problem?



-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Bug#689003: unblock: bacula/5.2.6+dfsg-5

2012-11-08 Thread Alexander Golovko 
В Thu, 8 Nov 2012 23:10:46 +0100
Julien Cristau jcris...@debian.org пишет:

 On Fri, Nov  9, 2012 at 01:07:18 +0400, Alexander Golovko wrote:
 
  bacula daemons SIGSEGV handler can call gdb for save some useful
  (for developers) info about process (stack for all threads and
  other). Gdb called with bacula user privileges, but files
  in /proc/pid/ owned by root and gdb can't get info about process.
  This is subject of bug #556207.
  
 Or you could just let the kernel get you a core file with all the info
 you would want.  

Yes, coredump will be enough and in some cases it required for solve
problem. But it contain some information, such a passwords, that
1. make impossible coredump publication
2. require password changing even after privately sending
coredump to developers due to possibility of passwords leakage.

But thank you for attention to this moment, there is a bacula bug -
daemons don't create coredumps on such signals, i will send bugreport to
upstream.



 I'm sorry, but I don't think this is worthy of
 breaking the freeze.
 
  Yes, user still must install -dbg packages before this will work,
  but this is not so hard work for them as manually changing init
  scripts.
  
 Seriously, editing a shell script, hard work?
 
 [...]
  Hmm, but if users want worked systemd files (#679958), is it really
  prefer to drop systemd support over fix problem?
  
 We're frozen.

ok, i understand you and will remove this files



-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Bug#689003: unblock: bacula/5.2.6+dfsg-5

2012-10-09 Thread Alexander Golovko 
В Mon, 08 Oct 2012 14:26:08 +0200
Mehdi Dogguy me...@dogguy.org пишет:

 On 28/09/2012 07:57, Alexander Golovko wrote:
  Package: release.debian.org Severity: normal User:
  release.debian@packages.debian.org Usertags: unblock
  
  Hi!
  
  Please unblock bacula-* packages, it fixes multiple bugs, include 
  CVE-2012-4430, crashes and debian policy violations:
  
  #687923 - security issue CVE-2012-4430 #688732 - bacula-fd save
  only first xattr on file #682733 - unowned files after purge 
  #680051 - switch between bacula-director-dbtype #679958 -
  incorrect systemd service file Fix unsafe bacula-director
  passwords. Fix bacula-fd crash on saving xattr on btrfs.
  
 
 Ok, I don't feel comfortable with all these packaging changes. I don't
 think I'm going to unblock this package. Could you prepare an upload
 to t-p-u please? #687923, #682733, #679958, Fix unsafe
 bacula-director passwords look okay. For the others, please show
 minimal separate patches if you want to include them.

I can try to remove some patches, but i'm afraid, that completely
rework changes will be very hard. I list all changes (except #687923,
#682733, #679958, Fix unsafe bacula-director passwords) with links to
commits and additional description. Please say, which of changes can be
included and which not. Sorry for this abuse.



1. Build packages for all database types in the same time, not a
separate process for sqlite3, mysql and pgsql.

http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=1ca440fc3758a28fdcd17c05aa24f724934dbc5f

This change affect only package building process. It was thoroughly
checked, that binary packages changed not more, than on rebuild from
the same sources.
This change make build process much more clear and less differ from
standard debhelper. I'm afraid, that unaccepting this change will lead
to requirement of very hard reworking some other changes.
Another argument for accept this change is that this change will be one
of first candidate for post-wheezy and we will need support two
different solutions - for stable wheezy and current.



2. Save all file xattrs, not only first (Closes: #688732),
Fix bacula-fd crash on saving xattr on btrfs.

http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=455622199fb46805cd11f69630279af5987c0bb2
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=d7bb353b616c6221684ffc81cbfe2c885a1dab81

It is a regression since squeeze. Squeeze shipped with previous major
version of bacula. There are a big commits, but however this is
only adding upstream patch. I'm think, there is important bugfix.



3. fix daemons user/group on systems with systemd (Closes: #679958).
delegate daemons uid/gid changing to start-stop-daemon or systemd,
thanks to Matija Nalis (Closes: #556207).

This changes are related and intersected. First commit reverted by
last.

http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=d077cd3c71734828b635f8605c8411f6cd86b6f6
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=cf9eb640182f4adfd83d05954dc35a20b60170c1
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=694b788e0f82a734ca98bb0930a97432240c7fe8

Upstream already much time (at least since 2010, Oct) use
start-stop-daemon for change daemons uid/gid in their variant of init
scripts. Our patch for uid/gid changing by systemd was already accepted
into upstream. 

The big problem, that without this change user can't simply get
backtraces on daemons crashes. This backtraces required for some
bugreport to upstream.



4. fix waiting for real daemon stopping (Closes: #684744).
remove unused code from bacula-director init script.

http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=ef0c7b8b1ee7060decff3b4757bfb512c11bb98a
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=d4052cfbafbcb1718b687886a7b01198f06fb0a1
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=037b600ebfec34b6d48adcbfa08580276e188d0b

First commit is bug fix, last is only adding info into changelog.
Second commit is not required, but always better, when init scripts
make the same tasks by the same methods.



5. Add build-depends for read-all capability support (Closes: #683080).
capabilities is linux-only feature. disable it for non-linux
platforms, add information, that capabilities is linux-only feature.
Add information about file daemon without root privileges.

http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=c6b51c2c010ae82f73d8cdce2eecbfbe52e6bbec
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=74198182c2fa9e2567077356e345ff5251e26bf1
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=6e1fab3c304fa73b9c6801a07290ce48b7cadb24

Yes, this is, of-course, new feature. But maybe fact, that this
change can improve Debian security and will be very useful for Debian
System Administration Team will be enough for accept this change

Bug#689003: unblock: bacula/5.2.6+dfsg-5

2012-10-09 Thread Alexander Golovko 
В Tue, 9 Oct 2012 12:32:07 +0200
Julien Cristau jcris...@debian.org пишет:

 On Tue, Oct  9, 2012 at 13:17:23 +0400, Alexander Golovko wrote:
 
  1. Build packages for all database types in the same time, not a
  separate process for sqlite3, mysql and pgsql.
  
  http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=1ca440fc3758a28fdcd17c05aa24f724934dbc5f
  
 nak.

I try to convince you again, if you don't mind.

Benefits for our team:

Package building is faster. It was start, wait, make something, look,
wait, look, wait, forget, remember only after some time :(
It was really annoying and significantly slow my work.

Package building process is much clear. Anybody other can help us if
he has basic knowledge about debhelper. With old variant d/rules is
more hard for understanding.

Also this change i test very-very deep. I compare packages, built from
sources with and without this change. Comparison include non-elf files
by content, where point symlinks, list of linked libraries for elf
files and buildlogs for anomaly differences in flags. There was one of
my most tested changes.

I really can promise, that this change not affect anything in binary
packages.

I hope, if this arguments will enough for allow exclusion and accept
this change.


  3. fix daemons user/group on systems with systemd (Closes: #679958).
  delegate daemons uid/gid changing to start-stop-daemon or systemd,
  thanks to Matija Nalis (Closes: #556207).
  
  This changes are related and intersected. First commit reverted by
  last.
  
  http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=d077cd3c71734828b635f8605c8411f6cd86b6f6
  http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=cf9eb640182f4adfd83d05954dc35a20b60170c1
  http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=694b788e0f82a734ca98bb0930a97432240c7fe8
  
  Upstream already much time (at least since 2010, Oct) use
  start-stop-daemon for change daemons uid/gid in their variant of
  init scripts. Our patch for uid/gid changing by systemd was already
  accepted into upstream. 
  
  The big problem, that without this change user can't simply get
  backtraces on daemons crashes. This backtraces required for some
  bugreport to upstream.
  
 Meh.  Can't the systemd files be simply removed?  If this doesn't
 affect sysvinit systems I would prefer not to bother.

Hmm. But systemd service files was added to package in 5.2.6+dfsg-1 via
bug #624532. And patch for fix them is trivial.



  5. Add build-depends for read-all capability support (Closes:
  #683080).
  
 A bit nervous about this one.  How much has this been tested, and how
 likely is it to affect unrelated features?

There are only one difference between packages built with and without
capabilities support in src/lib/priv.c on lines 110-132.

http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=blob;f=src/lib/priv.c;h=cfa4ec768970df40c3baea3f9d87831e761b7735;hb=52609e79da8df27cb68918acd074bff4af7cceb0

If binaries built without capabilities, than bacula-fd will return
error Keep readall caps not implemented when user try to use it.
If user start bacula without flags for enabling cap usage (default),
then the same code will be executed in both binaries - with or without
cap support.

This change should not affect to anything other.



  8. make package purging more careful about users files.
  
 Don't really see the point of this one.  Purging means purging.

actually, this is a difference from squeeze behavior for bacula-director
packages. Revert anyway?



  10. force /etc/defaults/bacula-dir reregistration in ucf when
  changing bacula-director database type, fix purging after this
  (Closes: #680051).
  
 Not sure about this, would appreciate advice from somebody who knows
 ucf.
 
  11. switch to /run directory
  
 nak.

Ok. i revert it.



  12. Fix impossibility to run out-of-box scripts make_mysql_tables
  and update_mysql_tables scripts, shipped with package (#679855).
  
 Are these scripts ever run automatically by the package?

No, scripts (dbconfig-common) use other files, generated on build time.
This files intended for users, who don't want or can't use dbconfig for
database population.



  13. switch from usermod to more debian-policy friendly adduser.
  
 Unless this is fixing an actual bug, nak.

Ok, i revert it.



  14. fix hostname substitution (Closes: #682966).
  
 Doesn't seem critical?

It is not critical for package installation. But this changes will do
all users immediately after first package installation.



  15. add bacula into cdrom group (Closes: #520508).
  
 Same here, I'd say defer to wheezy+1.

Ok, i revert it.


  16. Cleanup list of linked libraries.
  
 nak.

Maybe i incorrect worded this change.
This change remove unused libraries (no symbols from library used) from
list of linked libraries. 

From ld documentation:
--as-needed causes DT_NEEDED tags to only be emitted for libraries that
satisfy some symbol

Bug#689003: unblock: bacula/5.2.6+dfsg-5

2012-10-09 Thread Alexander Golovko 
В Tue, 9 Oct 2012 19:50:04 +0200
Julien Cristau jcris...@debian.org пишет:

 On Tue, Oct  9, 2012 at 17:56:47 +0400, Alexander Golovko wrote:
 
  В Tue, 9 Oct 2012 12:32:07 +0200
  Julien Cristau jcris...@debian.org пишет:
  
   On Tue, Oct  9, 2012 at 13:17:23 +0400, Alexander Golovko wrote:
   
1. Build packages for all database types in the same time, not a
separate process for sqlite3, mysql and pgsql.

http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=1ca440fc3758a28fdcd17c05aa24f724934dbc5f

   nak.
  
  I try to convince you again, if you don't mind.
  
 ok, I guess I'll take your word for it.

i'm sorry for my english, but what you mean? That you allow this change
or that it rejected and i should not continue try to change you opinion?


  
3. fix daemons user/group on systems with systemd (Closes:
#679958). delegate daemons uid/gid changing to
start-stop-daemon or systemd, thanks to Matija Nalis (Closes:
#556207).

This changes are related and intersected. First commit reverted
by last.

http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=d077cd3c71734828b635f8605c8411f6cd86b6f6
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=cf9eb640182f4adfd83d05954dc35a20b60170c1
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=694b788e0f82a734ca98bb0930a97432240c7fe8

Upstream already much time (at least since 2010, Oct) use
start-stop-daemon for change daemons uid/gid in their variant of
init scripts. Our patch for uid/gid changing by systemd was
already accepted into upstream. 

The big problem, that without this change user can't simply get
backtraces on daemons crashes. This backtraces required for some
bugreport to upstream.

   Meh.  Can't the systemd files be simply removed?  If this doesn't
   affect sysvinit systems I would prefer not to bother.
  
  Hmm. But systemd service files was added to package in 5.2.6+dfsg-1
  via bug #624532. And patch for fix them is trivial.
  
 Apparently not so trivial, since it needs a fixup now.  I would rather
 not see a change that affects all paths to fix something for the .1%
 of users that run systemd.

ohh. i think, that will be better to split explanation of this change
into two parts.

First - changes in sysvinit scripts. Instead of run daemons as root and
pass options for chuid we allow start-stop-daemon to run it as
non-root. This is what do upstream and without this fix we have a
problems with getting backtraces on daemons crashes.

Second - changes in systemd service files. In 5.2.6+dfsg-1 our team add
this files into packages, but unfortunely, they was shipped with
incorrect (empty) uid/gid in them.
So, for systemd service files was fixed two problems:
a) Change daemons uid/gid by systemd, as do sysvinit scripts. This
is separate patch [1] for simplicity sending it to upstream (already
accepted by upstream)
b) Fixing incorrect uid/gid. Due to limitation of upstream build
system we can't use build options and hardcore uid/gid by patch [2]

[1]
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=blob;f=debian/patches/delegate-chuid-to-systemd.patch
[2]
http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=blob;f=debian/patches/fix-systemd-daemon-user-group.patch

As i understand, your opinion is that will be better do not ship
systemd service files at all, but include changes in sysvinit scripts?


8. make package purging more careful about users files.

   Don't really see the point of this one.  Purging means purging.
  
  actually, this is a difference from squeeze behavior for
  bacula-director packages. Revert anyway?
  
 That would be my preference, yes.

ok. i revert it.


16. Cleanup list of linked libraries.

   nak.
  
  Maybe i incorrect worded this change.
  This change remove unused libraries (no symbols from library used)
  from list of linked libraries. 
  
 I know what --as-needed does.  It's essentially cosmetic, not
 appropriate during the freeze.

ok. i revert it.

 
  And the next question.
  Currently bacula can't built on hurd platforms. Should i include
  fix for this problem into next upload, intended for wheezy or not?
  
 If the patch is small and obvious enough why not, but hurd won't make
 wheezy so it's not really needed from our perspective.

In fact this is depend on upstream. There was a little changes in
package (disabled acl, xattr and mtx on this platform) and i wait
while upstream fix problems with maximum path length on this platform.
I will ask this additionally, when upstream prepare patch.


Upstream recommend do not use hardening for bacula, so we have 71
lintian warning about this fact. In git master branch this warnings was
hidden by adding lintian-overrides. This is cosmetic change and should
not present in next upload, intended for wheezy?


What is the best way to prepare package without rejected changes

Bug#678818: release.debian.org: pu: package bacula/5.0.2+dfsg-0+squeeze1

2012-10-05 Thread Alexander Golovko 
Hi!

Due to prepared upload to security-master with security fix, please do
not upload this package.
We will prepare updated package, which will also include already
uploaded changes.

thank you!

-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Bug#689003: unblock: bacula/5.2.6+dfsg-5

2012-09-28 Thread Alexander Golovko 
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hi!

Please unblock bacula-* packages, it fixes multiple bugs, include
CVE-2012-4430, crashes and debian policy violations:

#687923 - security issue CVE-2012-4430
#688732 - bacula-fd save only first xattr on file
#682733 - unowned files after purge
#680051 - switch between bacula-director-dbtype
#679958 - incorrect systemd service file
Fix unsafe bacula-director passwords.
Fix bacula-fd crash on saving xattr on btrfs.


Also new version include useful for DSA team [1] security improvement -
ability to run bacula-fd without root privileges (#683080)


There are also other changes in packages, i don't know need you see
more detailed description about this changes. Most of them are
not so important bugfixes, as listed above and several minor
wishlistes, that should not affect to stability.

Thank you very much!


[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=683080#75


unblock bacula/5.2.6+dfsg-5

-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

unblock bacula/5.2.6+dfsg-5

2012-09-27 Thread Alexander Golovko 
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hi!

Please unblock bacula-* packages, it fixes multiple bugs, include
CVE-2012-4430, crashes and debian policy violations:

#687923 - security issue CVE-2012-4430
#688732 - bacula-fd save only first xattr on file
#682733 - unowned files after purge
#680051 - switch between bacula-director-dbtype
#679958 - incorrect systemd service file
Fix unsafe bacula-director passwords.
Fix bacula-fd crash on saving xattr on btrfs.


Also new version include useful for DSA team [1] security improvement -
ability to run bacula-fd without root privileges (#683080)


There are also other changes in packages, i don't know need you see
more detailed description about this changes. Most of them are
not so important bugfixes, as listed above and several minor
wishlistes, that should not affect to stability.

Thank you very much!


[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=683080#75


unblock bacula/5.2.6+dfsg-5

-- 
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


signature.asc
Description: PGP signature

Re: [pkg-bacula-devel] New versions upload

2012-07-25 Thread Alexander Golovko 

On Wed, 25 Jul 2012 12:03:02 +0100, Adam D. Barratt wrote:

On 25.07.2012 08:41, Geert Stappers wrote:

Op 20120724 om 21:35 schreef Alexander Golovko:

On Tue, 24 Jul 2012 20:14:10 +0200, Julien Cristau wrote:
 On Tue, Jul 24, 2012 at 21:10:49 +0400, Alexander Golovko wrote:

} Upstream position 5.2.x releases as bugfixes, 5.2.7 and 5.2.10 
as

} significant bugfix releases.
 There is a debdiff between current packages and new 5.2.10, 
which

 after fixing all regressions and other bugs can be uploaded:

 We're interested in the source diff, not so much binary.


i use next command for create debdiff:
debdiff --diffstat --exclude bacula.pot --exclude '*.po' \
--exclude configure --exclude ltdl.m4 --exclude 
fix-binutils-gold-linking.patch
--wdiff-source-control bacula_5.2.6+dfsg-2.dsc 
bacula_5.2.10+dfsg-1.dsc  bacula-dsc-debdiff.txt


( haven't checked the debdiff output )


It doesn't sound like you're in a position to comment on its
suitability then?


FWIW from http://www.bacula.org/en/?page=news
  The 5.2.10 version is a significant bug fix release


How many of those fixes fit the acceptance criteria?  This:


including our first cut of AFS support.


certainly doesn't.


In upstream changelog about 70 changes and not all of them has a bug 
number, but at least 40 of them look like fixes for more or less 
significant bugs.

A few changes is backports from development branch.
Other changes are translates, build system for other platforms or 
non-linux specific bugs.



As i can see, only backported changes definetelly don't fit acceptance 
criteria:

 - Backport new StorageId code
 - New overhaul of xattr code.
 - Add rudimentary support for saving AFS acls.


But it will be very hard to apply all changes, except backported.





Regards,

Adam

___
pkg-bacula-devel mailing list
pkg-bacula-de...@lists.alioth.debian.org

http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-bacula-devel


--
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


--
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/fdcf3c4b1edeb073af7a1f1558d44...@ankalagon.ru

New versions upload

2012-07-24 Thread Alexander Golovko 
), libgcc1 (= 1:4.1.1), libssl1.0.0 (= 
1.0.0), libstdc++6 (= 4.1.1), libwrap0 (= 7.6-4~), zlib1g (= 1:1.1.4)

Installed-Size: [-935-] {+989+}
Version: [-5.2.6+dfsg-2-] {+5.2.10+dfsg-1+}

Control files of package bacula-sd-mysql-dbg: lines which differ (wdiff 
format)

---
Depends: bacula-sd-mysql (= [-5.2.6+dfsg-2)-] {+5.2.10+dfsg-1)+}
Installed-Size: [-3728-] {+3810+}
Version: [-5.2.6+dfsg-2-] {+5.2.10+dfsg-1+}

Control files of package bacula-sd-pgsql: lines which differ (wdiff 
format)

---
Depends: bacula-sd (= [-5.2.6+dfsg-2),-] {+5.2.10+dfsg-1),+} 
bacula-common-pgsql (= [-5.2.6+dfsg-2),-] {+5.2.10+dfsg-1),+} 
bacula-common, libc6 (= 2.3.4), libgcc1 (= 1:4.1.1), libssl1.0.0 (= 
1.0.0), libstdc++6 (= 4.1.1), libwrap0 (= 7.6-4~), zlib1g (= 1:1.1.4)

Installed-Size: [-935-] {+989+}
Version: [-5.2.6+dfsg-2-] {+5.2.10+dfsg-1+}

Control files of package bacula-sd-pgsql-dbg: lines which differ (wdiff 
format)

---
Depends: bacula-sd-pgsql (= [-5.2.6+dfsg-2)-] {+5.2.10+dfsg-1)+}
Installed-Size: [-3728-] {+3810+}
Version: [-5.2.6+dfsg-2-] {+5.2.10+dfsg-1+}

Control files of package bacula-sd-sqlite3: lines which differ (wdiff 
format)

-
Depends: bacula-sd (= [-5.2.6+dfsg-2),-] {+5.2.10+dfsg-1),+} 
bacula-common, bacula-common-sqlite3 (= [-5.2.6+dfsg-2),-] 
{+5.2.10+dfsg-1),+} libc6 (= 2.3.4), libgcc1 (= 1:4.1.1), libssl1.0.0 
(= 1.0.0), libstdc++6 (= 4.1.1), libwrap0 (= 7.6-4~), zlib1g (= 
1:1.1.4)

Installed-Size: [-935-] {+989+}
Version: [-5.2.6+dfsg-2-] {+5.2.10+dfsg-1+}

Control files of package bacula-sd-sqlite3-dbg: lines which differ 
(wdiff format)

-
Depends: bacula-sd-sqlite3 (= [-5.2.6+dfsg-2)-] {+5.2.10+dfsg-1)+}
Installed-Size: [-3728-] {+3810+}
Version: [-5.2.6+dfsg-2-] {+5.2.10+dfsg-1+}

Control files of package bacula-server: lines which differ (wdiff 
format)

-
Depends: bacula-director-sqlite3 (= [-5.2.6+dfsg-2)-] 
{+5.2.10+dfsg-1)+} | bacula-director, bacula-sd (= [-5.2.6+dfsg-2),-] 
{+5.2.10+dfsg-1),+} bacula-sd-sqlite3 (= [-5.2.6+dfsg-2)-] 
{+5.2.10+dfsg-1)+} | bacula-sd-tools

Installed-Size: [-78-] {+103+}
Version: [-5.2.6+dfsg-2-] {+5.2.10+dfsg-1+}

Control files of package bacula-traymonitor: lines which differ (wdiff 
format)

--
Depends: bacula-common (= [-5.2.6+dfsg-2),-] {+5.2.10+dfsg-1),+} 
libatk1.0-0 (= 1.12.4), libc6 (= 2.2.5), libcairo2 (= 1.2.4), 
libfontconfig1 (= 2.9.0), libfreetype6 (= 2.2.1), libgcc1 (= 
1:4.1.1), libgdk-pixbuf2.0-0 (= 2.22.0), libglib2.0-0 (= 2.16.0), 
libgtk2.0-0 (= 2.10.0), libpango1.0-0 (= 1.14.0), libssl1.0.0 (= 
1.0.0), libstdc++6 (= 4.1.1), libwrap0 (= 7.6-4~), libx11-6, zlib1g 
(= 1:1.1.4)

Installed-Size: [-130-] {+179+}
Version: [-5.2.6+dfsg-2-] {+5.2.10+dfsg-1+}

Control files of package bacula-traymonitor-dbg: lines which differ 
(wdiff format)

--
Depends: bacula-traymonitor (= [-5.2.6+dfsg-2)-] {+5.2.10+dfsg-1)+}
Installed-Size: [-153-] {+192+}
Version: [-5.2.6+dfsg-2-] {+5.2.10+dfsg-1+}



--
with best regards,
Alexander Golovko
email: alexan...@ankalagon.ru
xmpp: alexan...@ankalagon.ru


--
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/48043219fb6e6bc164fb4d49332af...@ankalagon.ru