Bug#1036884: transition: time64_t

2024-03-18 Thread Emanuele Rocca
On 2024-03-13 02:08, Emanuele Rocca wrote:
> When it comes to actually satisfying build-depends properly it seems
> that as of right now the missing ones are libcurl4-gnutls-dev and
> libgit2-dev.

Cargo is now done. With libcurl4-gnutls-dev and libgit2-dev available I
could bootstrap it on armhf/armel, and Fabian later took care of a
source-only upload. We had to drop git from build-depends, not yet
installable on 32bit arm. Without git a (small) minority of tests are
not being run, but that seemed acceptable.

Next up for the rust world is rustc, which is currently blocked on
llvm-16-dev, itself stuck on a cycle between php and postgres.



Bug#1036884: transition: time64_t

2024-03-13 Thread Emanuele Rocca
Hi,

On 2024-03-12 05:55, Emanuele Rocca wrote:
> I did manage to get cargo to build in a armhf chroot by manually
> installing the various deps

When it comes to actually satisfying build-depends properly it seems
that as of right now the missing ones are libcurl4-gnutls-dev and
libgit2-dev. curl cannot be built on armhf due to stunnel4, and Simon
suggested a workaround for that in https://bugs.debian.org/1066049.

The problem with libgit2 seems to be cmake, which can be built on armhf
with DEB_BUILD_PROFILES=pkg.cmake.bootstrap. Do we plan on performing
binary uploads of packages built with bootstrap profiles, or what is the
general idea forward?



Bug#1036884: transition: time64_t

2024-03-12 Thread Emanuele Rocca
[ debian-rust added to CC ]

Hi,

On 2024-03-12 11:03, Simon McVittie wrote:
> In the medium term, cargo needs re-bootstrapping on the affected
> architectures (armel and armhf, plus a bunch of -ports architectures
> where as far as I can see cargo was never available in the past) -
> that's #1065787, and Steve already replied to that bug describing how
> Ubuntu did this.

I don't think Ubuntu actually fixed cargo yet, at least if the data in
UDD is reliable -- and if I'm looking in the right place. :-)

udd=> select source,version,date from ubuntu_upload_history where 
source='cargo' order by date desc limit 2;
 source |  version   |  date  
++
 cargo  | 0.67.1+ds0ubuntu0.libgit2-0ubuntu0.20.04.2 | 2023-07-05 09:36:28+00
 cargo  | 0.67.1+ds0ubuntu0.libgit2-0ubuntu0.22.04.2 | 2023-07-05 09:36:27+00
(2 rows)

Maybe when Steve mentioned the work done in Ubuntu on
https://bugs.debian.org/1065787#22 he meant other packages?

> Is there a porter who can take responsibility for that?

I did manage to get cargo to build in a armhf chroot by manually
installing the various deps, see the build artifacts at
https://people.debian.org/~ema/cargo/. I can work on armel next. The
tests are green but maybe there's some more meaningful validation we can
do before uploading? Anyone from debian-rust has ideas or comments?



Re: What to do with d-i on armel?

2024-01-09 Thread Emanuele Rocca
Hi Bastian,

On Sun, Jan 07, 2024 at 11:07:48PM +0100, Bastian Blank wrote:
> Do we have any armel subarch that can be installed via d-i?

Not as far as I know, perhaps Sledge has more info on this? Also, I don't think
we've seen anyone mentioning armel in ages on debian-boot, both in terms of
installation reports and in general asking questions. Correct me if I'm wrong
though. Any armel users out there? :-)



Bug#1055211: bookworm-pu: package gcc-12/12.2.0-14+deb12u1 (CVE-2023-4039)

2023-11-02 Thread Emanuele Rocca
-12.2.0/debian/changelog  2023-01-08 10:12:42.0 +0100
+++ gcc-12-12.2.0/debian/changelog  2023-10-09 11:45:48.0 +0200
@@ -1,3 +1,9 @@
+gcc-12 (12.2.0-14+deb12u1) bookworm; urgency=medium
+
+  * Fix -fstack-protector handling of overflows on AArch64 (CVE-2023-4039).
+
+ -- Emanuele Rocca   Mon, 09 Oct 2023 11:45:48 +0200
+
 gcc-12 (12.2.0-14) unstable; urgency=medium
 
   * Update to git 20230108 from the gcc-12 branch.
diff -Nru gcc-12-12.2.0/debian/patches/CVE-2023-4039.diff 
gcc-12-12.2.0/debian/patches/CVE-2023-4039.diff
--- gcc-12-12.2.0/debian/patches/CVE-2023-4039.diff 1970-01-01 
01:00:00.0 +0100
+++ gcc-12-12.2.0/debian/patches/CVE-2023-4039.diff 2023-09-21 
10:08:42.0 +0200
@@ -0,0 +1,1665 @@
+DP: Fix CVE-2023-4039.
+DP: 
+DP: The patch includes the following upstream commits:
+DP: 
+DP: aarch64: Use local frame vars in shrink-wrapping code
+DP: 62fbb215cc817e9f2c1ca80282a64f4ee30806bc
+DP: 
+DP: aarch64: Avoid a use of callee_offset
+DP: 12a8889de169f892d2e927584c00d20b8b7e456f
+DP: 
+DP: aarch64: Explicitly handle frames with no saved registers
+DP: 03d5e89e7f3be53fd7142556e8e0a2774c653dca
+DP: 
+DP: aarch64: Add bytes_below_saved_regs to frame info
+DP: 49c2eb7616756c323b7f6b18d8616ec945eb1263
+DP: 
+DP: aarch64: Add bytes_below_hard_fp to frame info
+DP: 34081079ea4de0c98331843f574b5f6f94d7b234
+DP: 
+DP: aarch64: Tweak aarch64_save/restore_callee_saves
+DP: 187861af7c51db9eddc6f954b589c121b210fc74
+DP: 
+DP: aarch64: Only calculate chain_offset if there is a chain
+DP: 2b983f9064d808daf909bde1d4a13980934a7e6e
+DP: 
+DP: aarch64: Rename locals_offset to bytes_above_locals
+DP: 0a0a824808d1dec51004fb5805c1a0ae2a35433f
+DP: 
+DP: aarch64: Rename hard_fp_offset to bytes_above_hard_fp
+DP: 3fbf0789202b30a67b12e1fb785c7130f098d665
+DP: 
+DP: aarch64: Tweak frame_size comment
+DP: aac8b31379ac3bbd14fc6427dce23f56e54e8485
+DP: 
+DP: aarch64: Measure reg_offset from the bottom of the frame
+DP: 8d5506a8aeb8dd7e8b209a3663b07688478f76b9
+DP: 
+DP: aarch64: Simplify top of frame allocation
+DP: b47766614df3b9df878262efb2ad73aaac108363
+DP: 
+DP: aarch64: Minor initial adjustment tweak
+DP: 08f71b4bb28fb74d20e8d2927a557e8119ce9f4d
+DP: 
+DP: aarch64: Tweak stack clash boundary condition
+DP: f22315d5c19e8310e4dc880fd509678fd291fca8
+DP: 
+DP: aarch64: Put LR save probe in first 16 bytes
+DP: 15e18831bf98fd25af098b970ebf0c9a6200a34b
+DP: 
+DP: aarch64: Simplify probe of final frame allocation
+DP: c4f0e121faa36342f1d21919e54a05ad841c4f86
+DP: 
+DP: aarch64: Explicitly record probe registers in frame info
+DP: 6f0ab0a9f46a17b68349ff6035aa776bf65f0575
+DP: 
+DP: aarch64: Remove below_hard_fp_saved_regs_size
+DP: 8254e1b9cd500e0c278465a3657543477e9d1250
+DP: 
+DP: aarch64: Make stack smash canary protect saved registers
+DP: 75c37e031408262263442f5b4cdb83d3777b6422
+DP: 
+DP: aarch64: Fix return register handling in untyped_call
+DP: 38d0605ac8bc90324170041676fc05e7e595769e
+DP: 
+DP: aarch64: Fix loose ldpstp check [PR111411]
+DP: 74f99f1adc696f446115f36974a3f94f66294a53
+
+Index: gcc-12-12.2.0/src/gcc/config/aarch64/aarch64.cc
+===
+--- gcc-12-12.2.0.orig/src/gcc/config/aarch64/aarch64.cc
 gcc-12-12.2.0/src/gcc/config/aarch64/aarch64.cc
+@@ -8070,18 +8070,32 @@ aarch64_needs_frame_chain (void)
+   return aarch64_use_frame_pointer;
+ }
+ 
++/* Return true if the current function should save registers above
++   the locals area, rather than below it.  */
++
++static bool
++aarch64_save_regs_above_locals_p ()
++{
++  /* When using stack smash protection, make sure that the canary slot
++ comes between the locals and the saved registers.  Otherwise,
++ it would be possible for a carefully sized smash attack to change
++ the saved registers (particularly LR and FP) without reaching the
++ canary.  */
++  return crtl->stack_protect_guard;
++}
++
+ /* Mark the registers that need to be saved by the callee and calculate
+the size of the callee-saved registers area and frame record (both FP
+and LR may be omitted).  */
+ static void
+ aarch64_layout_frame (void)
+ {
+-  poly_int64 offset = 0;
+   int regno, last_fp_reg = INVALID_REGNUM;
+   machine_mode vector_save_mode = aarch64_reg_save_mode (V8_REGNUM);
+   poly_int64 vector_save_size = GET_MODE_SIZE (vector_save_mode);
+   bool frame_related_fp_reg_p = false;
+   aarch64_frame  = cfun->machine->frame;
++  poly_int64 top_of_locals = -1;
+ 
+   frame.emit_frame_chain = aarch64_needs_frame_chain ();
+ 
+@@ -8148,11 +8162,18 @@ aarch64_layout_frame (void)
+   && !crtl->abi->clobbers_full_reg_p (regno))
+   frame.reg_offset[regno] = SLOT_REQUIRED;
+ 
+-  /* With stack-clash, LR must be saved in non-leaf functions.  The saving of
+- LR counts as an implicit probe which allows us to maintain the invariant
+- described in the comment at expand_prologue.  */
+-  gcc_assert (crtl->is_leaf

Re: Upcoming D-I Bookworm RC 4 and pseudo-RC 5

2023-06-05 Thread Emanuele Rocca
Hi,

On 2023-06-03 08:07, Cyril Brulebois wrote:
> Since there was good progress on the arm64 console thing (#1036952), and
> considering the current results of the investigation as to where vt102
> comes from, and why arm64 isn't quite the deciding factor (a busybox
> limitation instead), I'd be happy to consider getting an updated
> rootskel for migration before pseudo-RC 5 and 12.0.0. Such an upload
> would need to happen quickly though… (ema bcc'd, as possible uploader,
> no obligations though!).

I see that Samuel took care of the rootskel upload. Thanks!

  ema



Bug#1035515: [pre-approval] unblock: gdb/13.1-2.1

2023-05-04 Thread Emanuele Rocca
Hi Hector,

On Thu, May 04, 2023 at 05:53:24PM +0200, Hector Oron wrote:
>   Since you have not uploaded the package yet, are you fine if I do a
> regular upload with the patch, then use this unblock request to add
> the package to bookworm.

Of course, please go ahead.

Thanks,
  Emanuele



Bug#1035515: [pre-approval] unblock: gdb/13.1-2.1

2023-05-04 Thread Emanuele Rocca
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: g...@packages.debian.org, debian-...@lists.debian.org
Control: affects -1 + src:gdb

Hello release team,

Please unblock package gdb.

[ Reason ]
The most basic functionality of GDB, namely debugging an hello world C
program, is currently broken in Bookworm for arm64 systems with pointer
authentication enabled. See https://bugs.debian.org/1034611.

There is a patch merged upstream addressing the issue [0]. I've tested
it on a arm64 system and can confirm that it works. See also:
https://bugs.debian.org/1034611#15

I've prepared an NMU, not yet uploaded. Please find the debdiff
attached.

[ Impact ]
GDB entirely unusable for most arm64 users.

[ Tests ]
Upstream test suite passes. Manually verified that #1034611 can be
reproduced with gdb 13.1-2 from Bookworm, and it cannot with the
proposed changes.

[ Risks ]
Minimal, the patch is small and targeted. Additionally, it only touches
arm64-specific code.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

unblock gdb/13.1-2.1

Thanks,
  Emanuele

[0] 
https://sourceware.org/git/?p=binutils-gdb.git;a=patch;h=b3eff3e15576229af9bae026c5c23ee694b90389
diff -Nru gdb-13.1/debian/changelog gdb-13.1/debian/changelog
--- gdb-13.1/debian/changelog	2023-02-24 22:58:29.0 +0100
+++ gdb-13.1/debian/changelog	2023-05-04 13:40:28.0 +0200
@@ -1,3 +1,11 @@
+gdb (13.1-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * aarch64: add aarch64-pauth-registers.patch to check for valid inferior
+thread/regcache before reading pauth registers. (Closes: #1034611)
+
+ -- Emanuele Rocca   Thu, 04 May 2023 13:40:28 +0200
+
 gdb (13.1-2) unstable; urgency=medium
 
   * Apply upstream proposed fix for PR/30158
diff -Nru gdb-13.1/debian/patches/aarch64-pauth-registers.patch gdb-13.1/debian/patches/aarch64-pauth-registers.patch
--- gdb-13.1/debian/patches/aarch64-pauth-registers.patch	1970-01-01 01:00:00.0 +0100
+++ gdb-13.1/debian/patches/aarch64-pauth-registers.patch	2023-05-04 13:40:28.0 +0200
@@ -0,0 +1,283 @@
+From b3eff3e15576229af9bae026c5c23ee694b90389 Mon Sep 17 00:00:00 2001
+From: Luis Machado 
+Date: Fri, 24 Mar 2023 07:58:38 +
+Subject: [PATCH] aarch64: Check for valid inferior thread/regcache before
+ reading pauth registers
+
+There were reports of gdb throwing internal errors when calling
+inferior_thread ()/get_current_regcache () on a system with
+Pointer Authentication enabled.
+
+In such cases, gdb produces the following backtrace, or a variation
+of it (for gdb's with the non-address removal implemented only in
+the aarch64-linux-tdep.c file).
+
+../../../repos/binutils-gdb/gdb/thread.c:86: internal-error: inferior_thread: Assertion `current_thread_ != nullptr' failed.
+A problem internal to GDB has been detected,
+further debugging may prove unreliable.
+- Backtrace -
+0xe04a571f gdb_internal_backtrace_1
+../../../repos/binutils-gdb/gdb/bt-utils.c:122
+0xe04a57f3 _Z22gdb_internal_backtracev
+../../../repos/binutils-gdb/gdb/bt-utils.c:168
+0xe0b52ccf internal_vproblem
+../../../repos/binutils-gdb/gdb/utils.c:401
+0xe0b5310b _Z15internal_verrorPKciS0_St9__va_list
+../../../repos/binutils-gdb/gdb/utils.c:481
+0xe0e24b8f _Z18internal_error_locPKciS0_z
+../../../repos/binutils-gdb/gdbsupport/errors.cc:58
+0xe0a88983 _Z15inferior_threadv
+../../../repos/binutils-gdb/gdb/thread.c:86
+0xe0956c87 _Z20get_current_regcachev
+../../../repos/binutils-gdb/gdb/regcache.c:428
+0xe035223f aarch64_remove_non_address_bits
+../../../repos/binutils-gdb/gdb/aarch64-tdep.c:3572
+0xe03e8abb _Z31gdbarch_remove_non_address_bitsP7gdbarchm
+../../../repos/binutils-gdb/gdb/gdbarch.c:3109
+0xe0a692d7 memory_xfer_partial
+../../../repos/binutils-gdb/gdb/target.c:1620
+0xe0a695e3 _Z19target_xfer_partialP10target_ops13target_objectPKcPhPKhmmPm
+../../../repos/binutils-gdb/gdb/target.c:1684
+0xe0a69e9f target_read_partial
+../../../repos/binutils-gdb/gdb/target.c:1937
+0xe0a69fdf _Z11target_readP10target_ops13target_objectPKcPhml
+../../../repos/binutils-gdb/gdb/target.c:1977
+0xe0a69937 _Z18target_read_memorymPhl
+../../../repos/binutils-gdb/gdb/target.c:1773
+0xe08be523 ps_xfer_memory
+../../../repos/binutils-gdb/gdb/proc-service.c:90
+0xe08be6db ps_pdread
+../../../repos/binutils-gdb/gdb/proc-service.c:124
+0x40001ed7c3b3 _td_fetch_value
+/build/glibc-RIFKjK/glibc-2.31/nptl_db/fetch-value.c:115
+0x40001ed791ef td_ta_map_lwp2thr
+/build/glibc-RIFKjK/glibc-2.31/nptl_db/td_ta_map_lwp2thr.c:194
+0xe07f4473 thread_from_lwp
+../../../repos/binutils-gdb/gdb/linux-thread-db.c:413
+0xe07f6d6f

Bug#1033046: unblock: arm-compute-library/20.08+dfsg-7

2023-03-16 Thread Emanuele Rocca
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package arm-compute-library.

[ Reason ]
Fix RC bug in bookworm, the package fails to build from source due to
missing include directives: https://bugs.debian.org/1032041

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

unblock arm-compute-library/20.08+dfsg-7

Thanks,
  Emanuele

diff -Nru arm-compute-library-20.08+dfsg/debian/changelog arm-compute-library-20.08+dfsg/debian/changelog
--- arm-compute-library-20.08+dfsg/debian/changelog	2020-11-06 01:30:42.0 +0100
+++ arm-compute-library-20.08+dfsg/debian/changelog	2023-03-03 14:31:21.0 +0100
@@ -1,3 +1,17 @@
+arm-compute-library (20.08+dfsg-7) unstable; urgency=medium
+
+  * Actually include d/patches/missing-includes.patch, all changes to d/patches
+got removed by dgit.
+
+ -- Emanuele Rocca   Fri, 03 Mar 2023 14:31:21 +0100
+
+arm-compute-library (20.08+dfsg-6) unstable; urgency=medium
+
+  * Add d/patches/missing-includes.patch to fix FTBFS (Closes: #1032041)
+  * Add myself to Uploaders with Wookey's permission.
+
+ -- Emanuele Rocca   Fri, 03 Mar 2023 14:12:26 +0100
+
 arm-compute-library (20.08+dfsg-5) unstable; urgency=medium
 
   * Re-release as source-only upload
diff -Nru arm-compute-library-20.08+dfsg/debian/control arm-compute-library-20.08+dfsg/debian/control
--- arm-compute-library-20.08+dfsg/debian/control	2020-11-06 01:30:42.0 +0100
+++ arm-compute-library-20.08+dfsg/debian/control	2023-03-03 14:16:04.0 +0100
@@ -2,7 +2,7 @@
 Section: libs
 Priority: optional
 Maintainer: Compute Library Team 
-Uploaders: Georgios Pinitas ,
+Uploaders: Georgios Pinitas , Emanuele Rocca 
 Standards-Version: 4.5.0
 Homepage: https://github.com/ARM-software/ComputeLibrary
 Vcs-git: https://salsa.debian.org/wookey/arm-compute-library
diff -Nru arm-compute-library-20.08+dfsg/debian/patches/missing-includes.patch arm-compute-library-20.08+dfsg/debian/patches/missing-includes.patch
--- arm-compute-library-20.08+dfsg/debian/patches/missing-includes.patch	1970-01-01 01:00:00.0 +0100
+++ arm-compute-library-20.08+dfsg/debian/patches/missing-includes.patch	2023-03-03 14:30:48.0 +0100
@@ -0,0 +1,136 @@
+From: Emanuele Rocca 
+Date: Fri, 03 Mar 2023 14:14:18 +0100
+Subject: add missing includes to fix https://bugs.debian.org/1032041
+
+Index: arm-compute-library-20.08+dfsg/arm_compute/core/ITensorPack.h
+===
+--- arm-compute-library-20.08+dfsg.orig/arm_compute/core/ITensorPack.h
 arm-compute-library-20.08+dfsg/arm_compute/core/ITensorPack.h
+@@ -25,6 +25,7 @@
+ #define ARM_COMPUTE_ITENSORPACK_H
+ 
+ #include 
++#include 
+ #include 
+ 
+ namespace arm_compute
+Index: arm-compute-library-20.08+dfsg/src/core/NEON/kernels/arm_gemm/mergeresults.cpp
+===
+--- arm-compute-library-20.08+dfsg.orig/src/core/NEON/kernels/arm_gemm/mergeresults.cpp
 arm-compute-library-20.08+dfsg/src/core/NEON/kernels/arm_gemm/mergeresults.cpp
+@@ -25,6 +25,7 @@
+ /* As some of the merges need these headers, but are all included in the
+  * arm_gemm namespace, put these headers here.  */
+ #include 
++#include 
+ 
+ #include 
+ 
+Index: arm-compute-library-20.08+dfsg/src/core/NEON/kernels/arm_gemm/kernels/a64_hybrid_fp32_mla_16x4/generic.cpp
+===
+--- arm-compute-library-20.08+dfsg.orig/src/core/NEON/kernels/arm_gemm/kernels/a64_hybrid_fp32_mla_16x4/generic.cpp
 arm-compute-library-20.08+dfsg/src/core/NEON/kernels/arm_gemm/kernels/a64_hybrid_fp32_mla_16x4/generic.cpp
+@@ -24,6 +24,7 @@
+ #ifdef __aarch64__
+ 
+ #include 
++#include 
+ 
+ #include "arm_gemm.hpp"
+ 
+Index: arm-compute-library-20.08+dfsg/src/core/NEON/kernels/arm_gemm/kernels/a64_hybrid_fp32_mla_16x4/a55.cpp
+===
+--- arm-compute-library-20.08+dfsg.orig/src/core/NEON/kernels/arm_gemm/kernels/a64_hybrid_fp32_mla_16x4/a55.cpp
 arm-compute-library-20.08+dfsg/src/core/NEON/kernels/arm_gemm/kernels/a64_hybrid_fp32_mla_16x4/a55.cpp
+@@ -24,6 +24,7 @@
+ #ifdef __aarch64__
+ 
+ #include 
++#include 
+ 
+ #include "arm_gemm.hpp"
+ 
+Index: arm-compute-library-20.08+dfsg/src/core/NEON/kernels/arm_gemm/kernels/a64_hybrid_fp32_mla_16x4/x1.cpp
+===
+--- arm-compute-library-20.08+dfsg.orig/src/core/NEON/kernels/arm_gemm/kernels/a64_hybrid_fp32_mla_16x4/x1.cpp
 arm-compute-library-20.08+dfsg/src/core/NEON/kernels/arm_gemm/kernels/a64_hybrid_fp32_mla_16x4/x1.cpp
+@@ -24,6 +24,7 @@
+ #ifdef __aarch64__
+ 
+ #include 
++#include 
+ 
+ #include "arm_gemm.hpp"
+ 
+Index: arm-compute-library-20

Bug#782563: unblock: ppp/2.4.6-3.1

2015-04-14 Thread Emanuele Rocca
Package: release.debian.org
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock ppp/2.4.6-3.1. It fixes a DoS vulnerability in the pppd
radius plugin.

Thanks,
  ema

diff -Nru ppp-2.4.6/debian/changelog ppp-2.4.6/debian/changelog
--- ppp-2.4.6/debian/changelog  2014-10-19 11:56:12.0 +0200
+++ ppp-2.4.6/debian/changelog  2015-04-14 08:29:42.0 +0200
@@ -1,3 +1,16 @@
+ppp (2.4.6-3.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Urgency high due to fix for DoS vulnerability.
+  * Fix buffer overflow in rc_mksid().
+The function converts the PID of pppd to hex to generate a pseudo-unique
+string. If the process id is bigger than 65535 (), its hex
+representation will be longer than 4 characters, resulting in a buffer
+overflow. This bug can be exploited to cause a remote DoS.
+(Closes: #782450)
+
+ -- Emanuele Rocca e...@debian.org  Tue, 14 Apr 2015 08:18:06 +0200
+
 ppp (2.4.6-3) unstable; urgency=high
 
   * Urgency high due to fix for CVE-2014-3158.
diff -Nru ppp-2.4.6/debian/patches/rc_mksid-no-buffer-overflow 
ppp-2.4.6/debian/patches/rc_mksid-no-buffer-overflow
--- ppp-2.4.6/debian/patches/rc_mksid-no-buffer-overflow1970-01-01 
01:00:00.0 +0100
+++ ppp-2.4.6/debian/patches/rc_mksid-no-buffer-overflow2015-04-14 
08:27:53.0 +0200
@@ -0,0 +1,23 @@
+Description: Fix buffer overflow in rc_mksid()
+ rc_mksid converts the PID of pppd to hex to generate a pseudo-unique string.
+ .
+ If the process id is bigger than 65535 (), its hex representation will be
+ longer than 4 characters, resulting in a buffer overflow.
+ .
+ The bug can be exploited to cause a remote DoS.
+ .
+Author: Emanuele Rocca e...@debian.org
+Bug-Debian: https://bugs.debian.org/782450
+Last-Update: 2015-04-14
+
+--- ppp-2.4.6.orig/pppd/plugins/radius/util.c
 ppp-2.4.6/pppd/plugins/radius/util.c
+@@ -77,7 +77,7 @@ rc_mksid (void)
+   static unsigned short int cnt = 0;
+   sprintf (buf, %08lX%04X%02hX,
+  (unsigned long int) time (NULL),
+- (unsigned int) getpid (),
++ (unsigned int) getpid () % 65535,
+  cnt  0xFF);
+   cnt++;
+   return buf;
diff -Nru ppp-2.4.6/debian/patches/series ppp-2.4.6/debian/patches/series
--- ppp-2.4.6/debian/patches/series 2014-10-19 11:49:55.0 +0200
+++ ppp-2.4.6/debian/patches/series 2015-04-14 08:17:39.0 +0200
@@ -43,3 +43,4 @@
 resolv.conf_no_log
 zzz_config
 secure-card-interpreter-fix
+rc_mksid-no-buffer-overflow


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20150414091834.GA16132@aspi



Bug#782567: unblock: apcupsd/3.14.12-1.1

2015-04-14 Thread Emanuele Rocca
Package: release.debian.org
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock apcupsd/3.14.12-1.1. The NMU fixes apcaccess on ARM (RC
bug #770984).

Thanks,
ema

diff -u apcupsd-3.14.12/debian/changelog apcupsd-3.14.12/debian/changelog
--- apcupsd-3.14.12/debian/changelog
+++ apcupsd-3.14.12/debian/changelog
@@ -1,3 +1,11 @@
+apcupsd (3.14.12-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * src/apcaccess.c: declare ch as int to match getopt return type. Fixes
+apcaccess on ARM. (Closes: #770984)
+
+ -- Emanuele Rocca e...@debian.org  Tue, 14 Apr 2015 09:14:33 +0200
+
 apcupsd (3.14.12-1) unstable; urgency=low
 
   * [84a0ea2] Imported Upstream version 3.14.12
diff -u apcupsd-3.14.12/debian/patches/series 
apcupsd-3.14.12/debian/patches/series
--- apcupsd-3.14.12/debian/patches/series
+++ apcupsd-3.14.12/debian/patches/series
@@ -4,0 +5 @@
+05-apcaccess-arm.patch
only in patch2:
unchanged:
--- apcupsd-3.14.12.orig/debian/patches/05-apcaccess-arm.patch
+++ apcupsd-3.14.12/debian/patches/05-apcaccess-arm.patch
@@ -0,0 +1,13 @@
+Declare ch as int to match getopt return type. Fix apcaccess behavior on
+arm.
+--- a/src/apcaccess.c
 b/src/apcaccess.c
+@@ -146,7 +146,7 @@
+ #endif
+ 
+// Process standard options
+-   char ch;
++   int ch;
+while ((ch = getopt(argc, argv, f:h:p:u)) != -1)
+{
+   switch (ch)


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20150414095846.GA20367@aspi



Re: Please allow gsnes9x 3.12-10.1

2007-03-15 Thread Emanuele Rocca
* Steve Langasek [EMAIL PROTECTED], [2007-03-12  0:52 -0700]:
  On Mon, Mar 12, 2007 at 08:47:11AM +0100, Emanuele Rocca wrote:
   Can't snes9x just be built on mips? It's Architecture: any, so I guess
   it should build properly.
  
  I don't know.  If the package can be built on mips and will *run* on mips,
  then yes, that's an option.

snes9x has been kindly built and tested on mips by Thiemo Seufer, and
is now available in sid:
http://lists.debian.org/debian-mips/2007/03/msg00020.html

Please let gsnes9x enter testing, if you do not see other issues.

Thanks!
ciao,
ema


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Please allow gsnes9x 3.12-10.1

2007-03-12 Thread Emanuele Rocca
Hello guys,
I've NMUed gsnes9x, adding support for sparc. Please let it enter
testing.

Here is the changelog:

gsnes9x (3.12-10.1) unstable; urgency=low
 .
   * Non-maintainer upload
   * Sparc added to the list of supported architectures (closes: #411981)

ciao,
ema


signature.asc
Description: Digital signature


Re: Please allow gsnes9x 3.12-10.1

2007-03-12 Thread Emanuele Rocca
Hello Steve,

* Steve Langasek [EMAIL PROTECTED], [2007-03-12  0:38 -0700]:
  The gsnes9x package also has a binary in the archive for mips, which is
  uninstallable because snes9x-x isn't available for mips.  This needs to be
  fixed, both by requesting removal of the mips binary and by fixing the
  package to no longer build on mips, before the package can be considered for
  a release.

Can't snes9x just be built on mips? It's Architecture: any, so I guess
it should build properly.

ciao,
ema


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Please unblock xfce4-panel 4.3.99.2-2

2007-02-01 Thread Emanuele Rocca
Hi,
I've uploaded a new revision of xfce4-panel to unstable which closes
#409140. Please let it enter etch.

Thanks.
ciao,
ema


signature.asc
Description: Digital signature


Please unblock xfce4-goodies

2007-01-11 Thread Emanuele Rocca
Hello,

I uploaded a new version of xfce4-goodies which removes a broken
dependency on xfburn. Please let it enter testing.

Thanks,
ema


signature.asc
Description: Digital signature


Please unblock xfce4, xfce4-session and xfmw4-themes

2007-01-10 Thread Emanuele Rocca
, xfce4-notes-plugin, xfce4-quicklauncher-plugin, xfce4-screenshooter-plugin, xfce4-sensors-plugin, xfce4-smartbookmark-plugin, xfce4-systemload-plugin, xfce4-verve-plugin, xfce4-wavelan-plugin, xfce4-weather-plugin, mousepad, thunar-media-tags-plugin, xfburn, xfmedia, xfce4-terminal
+Suggests: xfce4-xfapplet-plugin, xfce4-xmms-plugin, xfce4-messenger-plugin, xfce4-mpc-plugin, xfce4-dict-plugin, xfce4-datetime-plugin (= 0.4.0), thunar-archive-plugin
 Conflicts: xfce4-datetime-plugin (= 0.3.1-3), xfce4-notes-plugin (= 0.10.0-2), xfce4-trigger-launcher (= 4.2.3-1), xfce4-cpufreq-plugin (= 0.1-2)
 Description: enhancements for the Xfce4 Desktop Environment
  The Goodies for Xfce project includes additional software and artwork that
diff -u xfwm4-themes-4.3.99.2/debian/changelog xfwm4-themes-4.3.99.2/debian/changelog
--- xfwm4-themes-4.3.99.2/debian/changelog
+++ xfwm4-themes-4.3.99.2/debian/changelog
@@ -1,3 +1,9 @@
+xfwm4-themes (4.3.99.2-2) unstable; urgency=low
+
+  * Added README.Debian, explaining how to use themes.  closes: #286250
+
+ -- Emanuele Rocca [EMAIL PROTECTED]  Mon,  8 Jan 2007 22:39:35 +0100
+
 xfwm4-themes (4.3.99.2-1) unstable; urgency=low
 
   * New upstream release.
only in patch2:
unchanged:
--- xfwm4-themes-4.3.99.2.orig/debian/README.Debian
+++ xfwm4-themes-4.3.99.2/debian/README.Debian
@@ -0,0 +1,10 @@
+README.Debian for xfwm4-themes
+--
+
+The themes provided by xfwm4-themes are installed under /usr/share/themes/.  
+
+To access them, you need to open the settings manager (either via the Xfce menu
+or running xfce-setting-show from the command line) and then clicking on
+Window Manager.
+
+Other themes are under Settings - User Interface.


signature.asc
Description: Digital signature


Re: Please unblock xfce4, xfce4-session and xfmw4-themes

2007-01-10 Thread Emanuele Rocca
Hello Marc,

* Marc 'HE' Brockschmidt [EMAIL PROTECTED], [2007-01-10 13:10 +0100]:
  The diff for the xfce4-session you named in the Subject seems to be a
  bit too big.

It was a lapsus, s/session/goodies/.

Thanks.
ciao,
ema


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Please let fwanalog into etch

2006-12-22 Thread Emanuele Rocca
Just a translation update, closing #399273.

Thanks!

ciao,
ema


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: [Pkg-xfce-devel] 3 removals for xfce

2006-06-03 Thread Emanuele Rocca
Hello Stefan,

* Stefan Ott [EMAIL PROTECTED], [2006-06-03 18:03 +0200]:
  On Sat, Jun 03, 2006 at 02:42:57PM +0100, Simon Huggins wrote:
   Could someone please remove:
  xfce4-notes-plugin #370111
  xfce4-datetime-plugin #370113
  xfce4-cpufreq-plugin #370114
   from etch?
  
  I'm currently working on porting xfce4-cpufreq-plugin to xfce4.4 -
  should be done within a week or two.

You may want to add a note to #370114 then?

ciao,
ema


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Please consider somaplayer 0.5.2-2

2005-05-22 Thread Emanuele Rocca
Hi,
I uploaded a new revision of somaplayer which fixes #309093 (RC) and
#297963 (FTBFS on amd64).

I simply sponsored this upload, the actual work was done by the
maintainer, Riccardo Setti [EMAIL PROTECTED]. Please CC: him on 
replies.

Thanks.
ciao,   
ema


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Just to be sure: will this upload be harmful?

2005-05-18 Thread Emanuele Rocca
First of all: thanks for your work.

Before sponsoring this upload of somaplayer (which fixes RC bug #309093)
I would like to know if there's something wrong with it; here it is the 
interdiff:

diff -u somaplayer-0.5.2/debian/control somaplayer-0.5.2/debian/control
--- somaplayer-0.5.2/debian/control
+++ somaplayer-0.5.2/debian/control
@@ -2,14 +2,14 @@
 Section: sound
 Priority: optional
 Maintainer: Riccardo Setti [EMAIL PROTECTED]
-Build-Depends: debhelper (= 4.0.0), autotools-dev, libmad0-dev, libssl-dev, 
libvorbis-dev, libogg-dev, libid3tag0-dev, libao-dev, libsndfile1-dev, 
libcdaudio0-dev, libcdparanoia0-dev, libgtk2.0-dev
+Build-Depends: debhelper (= 4.0.0), autotools-dev, libmad0-dev, libssl-dev, 
libvorbis-dev, libogg-dev, libasound2-dev, libid3tag0-dev, libid3-3.8.3-dev, 
libao-dev, libsndfile1-dev, libcdaudio0-dev, libcdparanoia0-dev, libgtk2.0-dev, 
dpatch
 Standards-Version: 3.6.1
 
 Package: somaplayer
 Architecture: any
 Section: sound
 Suggests: somaplayer-doc
-Depends: ${shlibs:Depends}
+Depends: ${shlibs:Depends} 
 Description: player audio for the soma suite
  Music player for mp3, ogg, wav, audiocd, mp3 streaming, ogg streaming and
  able to use the appropriate sound drivers, demons, to stream
@@ -40,7 +40,7 @@
 Package: libsds0
 Architecture: any
 Section: libs
-Depends: somaplayer (= ${VERSION})
+Depends: ${shlibs:Depends}
 Description: primary lib for SDS
  This package includes the primary library for the Soma
  Daemon System, which is used by all SDS applications
@@ -50,7 +50,7 @@
 Package: libsomaplayer0
 Architecture: any
 Section: libs
-Depends: somaplayer (= ${VERSION})
+Depends: ${shlibs:Depends} 
 Description: primary lib for somaplayer
  This package includes the primary library for the Soma
  Daemon System, which is used by all SDS applications
diff -u somaplayer-0.5.2/debian/rules somaplayer-0.5.2/debian/rules
--- somaplayer-0.5.2/debian/rules
+++ somaplayer-0.5.2/debian/rules
@@ -11,8 +11,12 @@
 # from having to guess our platform (since we know it already)
 DEB_HOST_GNU_TYPE   ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
 DEB_BUILD_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
-VERSION = `head -n1 debian/changelog | grep -o -e '(.*)' | sed -e 
s/(\(.*\))/\1/m`
-export $(VERSION)
+
+#VERSION = `head -n1 debian/changelog | grep -o -e '(.*)' | sed -e 
s/(\(.*\))/\1/m`
+#export $(VERSION)
+
+PACKAGE=somaplayer
+include /usr/share/dpatch/dpatch.make
 
 CFLAGS = -Wall -g
 
@@ -25,13 +29,13 @@
INSTALL_PROGRAM += -s
 endif
 
-config.status: configure
+config.status: configure patch-stamp
dh_testdir
# Add here commands to configure the package.
CFLAGS=$(CFLAGS) ./configure --host=$(DEB_HOST_GNU_TYPE) 
--build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr \
--mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info 
--enable-ipv6 --disable-lame \
--disable-cdromsearch --enable-mic -enable-somalist 
-build: build-stamp
+build: build-stamp 
 
 build-stamp:  config.status
dh_testdir
@@ -42,7 +46,7 @@
 
touch build-stamp
 
-clean:
+clean: unpatch
dh_testdir
dh_testroot
rm -f build-stamp 
@@ -168,9 +172,10 @@
dh_strip -a
dh_compress -a
dh_fixperms -a
+   dh_makeshlibs
dh_installdeb -a
-   dh_shlibdeps -a
-   dh_gencontrol -a -- -VVERSION=$(VERSION)
+   dh_shlibdeps -a 
+   dh_gencontrol -a 
dh_md5sums -a
dh_builddeb -a
 
diff -u somaplayer-0.5.2/debian/changelog somaplayer-0.5.2/debian/changelog
--- somaplayer-0.5.2/debian/changelog
+++ somaplayer-0.5.2/debian/changelog
@@ -1,3 +1,16 @@
+somaplayer (0.5.2-2) unstable; urgency=high
+
+  * Correctly depend on libsomaplayer0. (closes: #309093)
+  * Added patch for compile somaplayer on amd64 thanks to
+Andreas Jochens (closes: #297963) 
+  * Minor changes in debian/rules (i'll not use anymore dh_gencontrol -- 
$VERSION)
+  * Minor changes in debian/control (remove dependency on $VERSION)
+  * Removed debian/shlibsdep files, switched to dh_shlibs
+  * Updated config.guess / config.sub
+  * Sponsored by Emanuele Rocca [EMAIL PROTECTED]
+  
+ -- Riccardo Setti [EMAIL PROTECTED]  Sun,  16 May 2005 12:45:11 +0100
+
 somaplayer (0.5.2-1) unstable; urgency=low
 
   * New upstream.
reverted:
--- somaplayer-0.5.2/debian/libsds0.shlibs
+++ somaplayer-0.5.2.orig/debian/libsds0.shlibs
@@ -1,2 +0,0 @@
-libsds 1 libsds0 (=  ${VERSION} )
-libsdsdsp 1 libsds0 (=  ${VERSION} )
reverted:
--- somaplayer-0.5.2/debian/libsomaplayer0.shlibs
+++ somaplayer-0.5.2.orig/debian/libsomaplayer0.shlibs
@@ -1 +0,0 @@
-libsomaplayer 1 libsomaplayer0 (= ${VERSION} )
only in patch2:
unchanged:
--- somaplayer-0.5.2.orig/config.guess
+++ somaplayer-0.5.2/config.guess
@@ -1,9 +1,9 @@
 #! /bin/sh
 # Attempt to guess a canonical system name.
 #   Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
-#   2000, 2001, 2002, 2003, 2004 Free Software Foundation, Inc.
+#   2000, 2001, 2002, 2003