Bug#863556: unblock: cinnamon-screensaver/3.2.13-4
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Please unblock package cinnamon-screensaver As with the cinnamon package, Maxy and I went through the upstream changes done to cinnamon-screensaver and cherry picked those that we judged to have the most impact and that we would like to see released with stretch. The latest upload includes the following fixes that I'd like to see included in stretch: cinnamon-screensaver (3.2.13-4) unstable; urgency=medium * Cherry pick: "mediaPlayerWatcher.py: catch SyntaxError exception when evaluating PlaybackStatus property." (0063d84) Prevents the screensaver from dying if the media player returns a status message with invalid syntax. * Cherry pick: "framedImage.py: Just silently fail if a downloaded image fails to be loaded into a pixbuf." (935cde4) Prevents the screensaver from dying if it fails to download the media player artwork. * Cherry pick "some theme fixes for gtk 3.20+" (2b96fb3) Makes the password entry use some new CSS properties in GTK 3.20+ * Cherry pick "xscreensaver plugin: Use GSubprocess instead of g_spawn_async for hacks" (cfa1f1a) Avoids left over screensaver processes when previewing them. * Cherry pick "stage/fader: Realize the stage offscreen, then reposition it before starting our fade in" (2e73a9b) + "stage.py: fix screen changed callback" (39da3f0). Avoids ugly flashes when starting and interrupting the screensaver, by precalculating the image off-screen before rendering (+ a fixup due to a function name change). * Cherry pick "service.py: Add the invocation to the queue prior to calling on the manager to lock" (5561f3c) Prevents possible hung commands when locking the screen. * Cherry pick "passwordEntry.py: Reload the keyboard layout if the xkb configuration changes." (55a26c2) Changes the default keyboard layout in the screensaver when the default is changed for the session. -- Margarita Manterola <ma...@debian.org> Sat, 20 May 2017 12:55:14 +0200 I'm attaching the full debdiff, as well as the separate files for the patches for easier reviewing. unblock cinnamon-screensaver/3.2.13-4 -- Thanks, Margadiff -Nru cinnamon-screensaver-3.2.13/debian/changelog cinnamon-screensaver-3.2.13/debian/changelog --- cinnamon-screensaver-3.2.13/debian/changelog 2017-05-20 12:55:14.0 +0200 +++ cinnamon-screensaver-3.2.13/debian/changelog 2017-04-02 13:24:49.0 +0200 @@ -1,34 +1,3 @@ -cinnamon-screensaver (3.2.13-4) unstable; urgency=medium - - * Cherry pick: "mediaPlayerWatcher.py: catch SyntaxError exception when -evaluating PlaybackStatus property." (0063d84) -Prevents the screensaver from dying if the media player returns a status -message with invalid syntax. - * Cherry pick: "framedImage.py: Just silently fail if a downloaded image fails -to be loaded into a pixbuf." (935cde4) -Prevents the screensaver from dying if it fails to download the media player -artwork. - * Cherry pick "some theme fixes for gtk 3.20+" (2b96fb3) -Makes the password entry use some new CSS properties in GTK 3.20+ - * Cherry pick "xscreensaver plugin: Use GSubprocess instead of g_spawn_async -for hacks" (cfa1f1a) -Avoids left over screensaver processes when previewing them. - * Cherry pick "stage/fader: Realize the stage offscreen, then reposition it -before starting our fade in" (2e73a9b) + "stage.py: fix screen changed -callback" (39da3f0). -Avoids ugly flashes when starting and interrupting the screensaver, by -precalculating the image off-screen before rendering (+ a fixup due to a -function name change). - * Cherry pick "service.py: Add the invocation to the queue prior to calling on -the manager to lock" (5561f3c) -Prevents possible hung commands when locking the screen. - * Cherry pick "passwordEntry.py: Reload the keyboard layout if the xkb - configuration changes." (55a26c2) -Changes the default keyboard layout in the screensaver when the default is -changed for the session. - - -- Margarita Manterola <ma...@debian.org> Sat, 20 May 2017 12:55:14 +0200 - cinnamon-screensaver (3.2.13-3) unstable; urgency=medium * Import upstream's commit f579336 to allow users to select text in the diff -Nru cinnamon-screensaver-3.2.13/debian/patches/fixup-screen-changed-callaback.patch cinnamon-screensaver-3.2.13/debian/patches/fixup-screen-changed-callaback.patch --- cinnamon-screensaver-3.2.13/debian/patches/fixup-screen-changed-callaback.patch 2017-05-20 12:55:14.0 +0200 +++ cinnamon-screensaver-3.2.13/debian/patches/fixup-screen-changed-callaback.patch 1970-01-01 01:00:00.0 +0100 @@ -1,22 +0,0 @@ -From 39da3f
Bug#863555: unblock: cinnamon/3.2.7-4
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Please unblock package cinnamon In order to provide the best experience for our users, Maxy and I went through the upstream patches that had been done to Cinnamon since the last version uploaded to stretch, and identified the ones that impact the user experience and that we would like to see in stretch. The lastest upload includes the following fixes, cherry-picked from upstream: cinnamon (3.2.7-4) unstable; urgency=medium * Cherry pick "window-tracker: fix memory leak" (e2dfda9) Fixes a memory leak when switching between windows of the same application. * Cherry pick "[Sound applet] Fix a segmentation fault" (f8347d6) Fixes a segfault when launching the player from the sound applet if menu animations were disabled. * Cherry pick "theme-node: Fix leak on stylesheet change" (62c7d5c) Fixes a memory leak when previewing the different desktop styles. * Cherry pick "Fix hotcorner hover delay timeout removal" (103967a) Removes 4 useless error lines in .xsession-errors whenever a hot-corner is activated. * Cherry pick "cinnamon-desktop-editor: use the default icon when file is nonexistent" (887e8cd) Fixes a stacktrace when the custom icon for a launcher points to an absolute path that has been removed. * Cherry pick "st-bin.c: Fix y_fill setter (it was setting x_fill to the value of the existing y_fill, before it is set in the same call)." (dec0dd1) Corrects a typo for the y_fill property of one-child containers. * Cherry pick "cs_screensaver.py: Expose setting for floating widgets." (a625a95). Allows the user to easily disable floating widgets from the config screen. -- Margarita Manterola <ma...@debian.org> Sat, 20 May 2017 14:11:02 +0200 Before that, I'd done one upload to remove a file that was no longer used, and that was causing bogus messages on .xsession errors: cinnamon (3.2.7-3) unstable; urgency=medium * Revert the policykit patch now that the new polkit-1-gnome agent gets started by the desktop file. Add a versioned dependency on the fixed polkit-1-agent. -- Margarita Manterola <ma...@debian.org> Sat, 22 Apr 2017 16:15:58 +0200 I'm attaching the full debdiff as well as the separate patches for easier reviewing. unblock cinnamon/3.2.7-4 -- Regards, Margadiff -Nru cinnamon-3.2.7/debian/changelog cinnamon-3.2.7/debian/changelog --- cinnamon-3.2.7/debian/changelog 2017-01-29 16:16:24.0 +0100 +++ cinnamon-3.2.7/debian/changelog 2017-05-20 14:11:02.0 +0200 @@ -1,3 +1,37 @@ +cinnamon (3.2.7-4) unstable; urgency=medium + + * Cherry pick "window-tracker: fix memory leak" (e2dfda9) +Fixes a memory leak when switching between windows of the same +application. + * Cherry pick "[Sound applet] Fix a segmentation fault" (f8347d6) +Fixes a segfault when launching the player from the sound applet if menu +animations were disabled. + * Cherry pick "theme-node: Fix leak on stylesheet change" (62c7d5c) +Fixes a memory leak when previewing the different desktop styles. + * Cherry pick "Fix hotcorner hover delay timeout removal" (103967a) +Removes 4 useless error lines in .xsession-errors whenever a hot-corner is +activated. + * Cherry pick "cinnamon-desktop-editor: use the default icon when file is +nonexistent" (887e8cd) +Fixes a stacktrace when the custom icon for a launcher points to an absolute +path that has been removed. + * Cherry pick "st-bin.c: Fix y_fill setter (it was setting x_fill to the value +of the existing y_fill, before it is set in the same call)." (dec0dd1) +Corrects a typo for the y_fill property of one-child containers. + * Cherry pick "cs_screensaver.py: Expose setting for floating widgets." +(a625a95). +Allows the user to easily disable floating widgets from the config screen. + + -- Margarita Manterola <ma...@debian.org> Sat, 20 May 2017 14:11:02 +0200 + +cinnamon (3.2.7-3) unstable; urgency=medium + + * Revert the policykit patch now that the new polkit-1-gnome agent gets +started by the desktop file. Add a versioned dependency on the fixed +polkit-1-agent. + + -- Margarita Manterola <ma...@debian.org> Sat, 22 Apr 2017 16:15:58 +0200 + cinnamon (3.2.7-2) unstable; urgency=medium * Rename "Adwaita" metacity-1 thumbnail to "Default". Force "Default" theme diff -Nru cinnamon-3.2.7/debian/cinnamon.install cinnamon-3.2.7/debian/cinnamon.install --- cinnamon-3.2.7/debian/cinnamon.install 2017-01-29 16:16:24.0 +0100 +++ cinnamon-3.2.7/debian/cinnamon.install 2017-05-20 14:11:02.0 +0200 @@ -3,7 +3,6 @@ /usr/lib/*/cinnamon /usr/share/applications/cinnamon-killer-daemo
Bug#859922: unblock: cinnamon-screensaver/3.2.13-3
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package cinnamon-screensaver
The latest upload includes the following fixes that I'd like to see included in
stretch:
cinnamon-screensaver (3.2.13-3) unstable; urgency=medium
* Import upstream's commit f579336 to allow users to select text in the
password text entry. Mostly used for selecting all text and re-entering the
password.
* Import upstream's commits 29bd6e6 and f3c3d0f to ensure that the screensaver
is started and the screen locked before the machine goes into
suspend/hibernate.
-- Margarita Manterola <ma...@debian.org> Sun, 02 Apr 2017 13:24:49 +0200
The first change is a small but quite annoying UX issue. A lot of users have
the habit of pressing Ctrl-A to select everything and start again when they
realize that the password was wrong. Without this patch, that's not possible.
The second change is larger, but is also quite important as it's addressing a
security issue, without it, it's possible that the screensaver hasn't locked
the screen when the machine suspends, which means that on un-suspend, the
screen is visible for a brief moment (usually 1 second) until the screensaver
activates.
I'm attaching the full debdiff, as well as the separate files for the patches
for easier reviewing.
unblock cinnamon-screensaver/3.2.13-3
--
Thanks,
Marga
diff -Nru cinnamon-screensaver-3.2.13/debian/changelog cinnamon-screensaver-3.2.13/debian/changelog
--- cinnamon-screensaver-3.2.13/debian/changelog 2017-03-12 12:24:52.0 +0100
+++ cinnamon-screensaver-3.2.13/debian/changelog 2017-04-02 13:24:49.0 +0200
@@ -1,3 +1,14 @@
+cinnamon-screensaver (3.2.13-3) unstable; urgency=medium
+
+ * Import upstream's commit f579336 to allow users to select text in the
+password text entry. Mostly used for selecting all text and re-entering the
+password.
+ * Import upstream's commits 29bd6e6 and f3c3d0f to ensure that the screensaver
+is started and the screen locked before the machine goes into
+suspend/hibernate.
+
+ -- Margarita Manterola <ma...@debian.org> Sun, 02 Apr 2017 13:24:49 +0200
+
cinnamon-screensaver (3.2.13-2) unstable; urgency=medium
* Add debian/cinnamon-screensaver-dialog, a helper script to ease the
diff -Nru cinnamon-screensaver-3.2.13/debian/patches/series cinnamon-screensaver-3.2.13/debian/patches/series
--- cinnamon-screensaver-3.2.13/debian/patches/series 2017-03-12 12:24:52.0 +0100
+++ cinnamon-screensaver-3.2.13/debian/patches/series 2017-04-02 13:24:49.0 +0200
@@ -1,2 +1,4 @@
change-iso-flag-path.patch
move_pamhelper_to_libexec.patch
+upstream_fix-textselection.patch
+upstream_fix-suspend-lock.patch
diff -Nru cinnamon-screensaver-3.2.13/debian/patches/upstream_fix-suspend-lock.patch cinnamon-screensaver-3.2.13/debian/patches/upstream_fix-suspend-lock.patch
--- cinnamon-screensaver-3.2.13/debian/patches/upstream_fix-suspend-lock.patch 1970-01-01 01:00:00.0 +0100
+++ cinnamon-screensaver-3.2.13/debian/patches/upstream_fix-suspend-lock.patch 2017-04-02 13:24:49.0 +0200
@@ -0,0 +1,131 @@
+Description: fix screensaver behavior during suspend/hibernate.
+ Allow the screensaver to be activated synchronously from cinnamon-session in
+ response to suspend/hibernate actions, and ensure it's fully active already
+ when resuming.
+Origin: upstream, 29bd6e61f2fc7164aca5a73de79135945b692d5b,
+upstream, f3c3d0f9bb7e0fa6210b098ad127999c7d2f12e1
+Author: Michael Webster <miketwebs...@gmail.com>
+Date: Mon, 23 Jan 2017 17:46:20 -0500
+
+---
+
+Index: cinnamon-screensaver/src/service.py
+===
+--- cinnamon-screensaver.orig/src/service.py 2017-04-02 12:00:34.079811859 +0200
cinnamon-screensaver/src/service.py 2017-04-02 12:00:34.075811755 +0200
+@@ -69,13 +69,32 @@
+ self.manager = ScreensaverManager()
+ self.manager.connect("active-changed", self.on_active_changed)
+
++"""
++The stage constructs itself and fades in asynchronously, and most importantly,
++as an idle callback. This can cause the screensaver to not be fully active when
++a call to suspend is made. Cinnamon-session calls to lock the screensaver
++synchronously, and if we don't completely finish construction before returning
++the dbus call completion, there's a chance the idle callback won't run until
++after the computer is resumed.
++
++We get an active-changed signal whenever the screensaver becomes completely active
++or inactive, so we'll queue up running iface.complete_lock() until we receive that signal.
++
++This allows the screensaver to be fully activated prior to cinnamon-session allowing
++the suspend/hibernate/whatever process to continue.
++
++For reference, this is
Bug#857543: unblock: cinnamon-screensaver/3.2.13-2
Hi! On 2017-03-12 15:52, Niels Thykier wrote: Ok with me - please remove the moreinfo flag once the upload has been processed and built on all relevant release architectures. Ok. One note though: + dh_install ../cinnamon-screensaver-dialog [...] ^^ This looks suspicious (at first glance, I would have expected debian/cinnamon-screensaver-dialog) Yeah, you are right. I also noticed this when I first looked at the submitted patch, but then forgot to fix it when applying it (it does work, even though it's unexpected). Will fix it before uploading. Thanks!!! -- Regards, Marga
Bug#857543: unblock: cinnamon-screensaver/3.2.13-2
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package cinnamon-screensaver, in order to fix important bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=853064
Version 3.2 of the cinnamon-screensaver is a complete re-write of the
screensaver. Previous versions used a file called "cinnamon-screensaver-dialog"
to show the actual password dialog, while the current version has the password
dialog integrated.
What this means is that for users that are upgrading from a version before 3.2
while running cinnamon-screensaver, they are no longer able to unlock the screen
until they restart the screensaver.
Current users of stretch have most likely already been hit by this (unless they
don't upgrade very often) and have dealt with it, but users of stable will be
hit by this when they upgrade to stretch.
The 3.2.13-2 version includes a transition script, located in the same path as
the old binary, that detects that it's been called and automatically restarts
the screensaver.
I'm attaching the debdiff to the current version in unstable/testing, as well as
the script itself (for easier reviewing). I haven't made the upload yet, please
let me know if it's ok for me to do this upload, thanks.
unblock cinnamon-screensaver/3.2.13-2
--
Thanks,
Marga
diff -Nru cinnamon-screensaver-3.2.13/debian/changelog cinnamon-screensaver-3.2.13/debian/changelog
--- cinnamon-screensaver-3.2.13/debian/changelog 2017-01-03 20:56:14.0 +0100
+++ cinnamon-screensaver-3.2.13/debian/changelog 2017-03-12 12:24:52.0 +0100
@@ -1,3 +1,11 @@
+cinnamon-screensaver (3.2.13-2) unstable; urgency=medium
+
+ * Add debian/cinnamon-screensaver-dialog, a helper script to ease the
+transition from a pre 3.2 screensaver to the 3.2 screensaver. Thanks to
+Michael Schaller for providing the script. (Closes: 853064)
+
+ -- Margarita Manterola <ma...@debian.org> Sun, 12 Mar 2017 12:24:52 +0100
+
cinnamon-screensaver (3.2.13-1) unstable; urgency=medium
* New upstream release (3.2.13).
diff -Nru cinnamon-screensaver-3.2.13/debian/cinnamon-screensaver-dialog cinnamon-screensaver-3.2.13/debian/cinnamon-screensaver-dialog
--- cinnamon-screensaver-3.2.13/debian/cinnamon-screensaver-dialog 1970-01-01 01:00:00.0 +0100
+++ cinnamon-screensaver-3.2.13/debian/cinnamon-screensaver-dialog 2017-03-12 12:24:52.0 +0100
@@ -0,0 +1,131 @@
+#!/usr/bin/env python3
+# License: LGPL-2+
+# Copyright: 2017, Google, Inc
+"""Transitional script to restart older cinnamon-screensavers.
+
+Older cinnamon-screensavers (<= 3.0) use the cinnamon-screensaver-dialog binary
+that is no longer present with newer cinnamon-screensavers (>= 3.2). As the
+binary is missing the unlock prompt can't be shown and hence the older and
+still running cinnamon-screensaver can't be unlocked anymore after a package
+update to a newer cinnamon-screensaver.
+
+This script is placed instead of cinnamon-screensaver-dialog and if it is
+executed it checks that it got executed from cinnamon-screensaver. If that is
+true the currently running older cinnamon-screensaver will be restarted so that
+the newer cinnamon-screensaver runs. Immediately afterwards the screensaver is
+locked via 'cinnamon-screensaver-command --lock'.
+"""
+
+import datetime
+import logging
+import os
+import signal
+import subprocess
+import sys
+
+def Main():
+"""Main function. Returns exit code."""
+xerrors = os.path.expanduser("~/.xsession-errors")
+logformat = ("cinnamon-screensaver-dialog[%(process)d]: %(asctime)s "
+"%(levelname)-8s %(message)s")
+logging.basicConfig(level=logging.DEBUG, filename=xerrors, format=logformat)
+logging.info("Start of cinnamon-screensaver-dialog transition script.")
+
+# Check if the parent process is cinnamon-screensaver.
+ppid = os.getppid()
+with open("/proc/{0}/cmdline".format(ppid)) as f:
+pcmd = f.read()
+if not "cinnamon-screensaver" in pcmd:
+logging.error(
+"Parent process isn't cinnamon-screensaver. Parent PID: %d. "
+"Parent process command line: %s", ppid, pcmd)
+return 1
+
+# Terminate the cinnamon-screensaver process (old version) and wait for it
+# to be gone. We terminate it instead of gracefully shutting it down via
+# 'cinnamon-screensaver-command --exit' as that would also terminate this
+# script. In any case the cinnamon-session will log a warning that the
+# screensaver has left the bus.
+logging.info(
+"Killing old cinnamon-screensaver process with PID %d ...", ppid)
+os.kill(ppid, signal.SIGTERM)
+
+# Wait for the cinnamon-screensaver process to be gone. The timeout is
+# 1 second. The while loop doesn't use any sleep to have the time th
Bug#853089: unblock: cinnamon/3.2.7-2 cinnamon-desktop-data/3.2.4-4
On 2017-01-29 18:34, Emilio Pozuelo Monfort wrote:
I'm attaching the debdiff for both packages for their version
currently in
testing (and unstable). I'd like to have confirmation that the
packages will be
unblocked before uploading them.
Did you forgot to attach those?
*sigh* Indeed, I did. I have attached them now.
--
Regards,
Margadiff -Nru cinnamon-desktop-3.2.4/debian/changelog cinnamon-desktop-3.2.4/debian/changelog
--- cinnamon-desktop-3.2.4/debian/changelog 2016-12-20 23:46:40.0 +0100
+++ cinnamon-desktop-3.2.4/debian/changelog 2017-01-29 16:15:57.0 +0100
@@ -1,3 +1,10 @@
+cinnamon-desktop (3.2.4-4) unstable; urgency=medium
+
+ * Change the default window manager theme to 'Default' as 'Adwaita' doesn't
+exist as a theme anymore. (Closes: #852974)
+
+ -- Margarita Manterola <ma...@debian.org> Sun, 29 Jan 2017 16:15:57 +0100
+
cinnamon-desktop (3.2.4-3) unstable; urgency=medium
* Release to unstable
diff -Nru cinnamon-desktop-3.2.4/debian/patches/change-adwaita-to-default.patch cinnamon-desktop-3.2.4/debian/patches/change-adwaita-to-default.patch
--- cinnamon-desktop-3.2.4/debian/patches/change-adwaita-to-default.patch 1970-01-01 01:00:00.0 +0100
+++ cinnamon-desktop-3.2.4/debian/patches/change-adwaita-to-default.patch 2017-01-29 16:15:57.0 +0100
@@ -0,0 +1,19 @@
+Description: Change the default schema value to Default instead of Adwaita.
+Author: ma...@debian.org
+Forwarded: not yet.
+Last-Update: 2017-01-29
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+Index: cinnamon-desktop/schemas/org.cinnamon.desktop.wm.preferences.gschema.xml.in.in
+===
+--- cinnamon-desktop.orig/schemas/org.cinnamon.desktop.wm.preferences.gschema.xml.in.in 2016-05-16 13:40:04.826893757 +0200
cinnamon-desktop/schemas/org.cinnamon.desktop.wm.preferences.gschema.xml.in.in 2017-01-29 15:56:51.301330070 +0100
+@@ -215,7 +215,7 @@
+
+
+
+- 'Adwaita'
++ 'Default'
+ <_summary>Current theme
+ <_description>
+ The theme determines the appearance of window borders, titlebar,
diff -Nru cinnamon-desktop-3.2.4/debian/patches/series cinnamon-desktop-3.2.4/debian/patches/series
--- cinnamon-desktop-3.2.4/debian/patches/series 2016-12-20 23:46:40.0 +0100
+++ cinnamon-desktop-3.2.4/debian/patches/series 2017-01-29 16:15:57.0 +0100
@@ -0,0 +1 @@
+change-adwaita-to-default.patch
diff -Nru cinnamon-3.2.7/debian/changelog cinnamon-3.2.7/debian/changelog
--- cinnamon-3.2.7/debian/changelog 2017-01-03 21:23:08.0 +0100
+++ cinnamon-3.2.7/debian/changelog 2017-01-29 16:16:24.0 +0100
@@ -1,3 +1,12 @@
+cinnamon (3.2.7-2) unstable; urgency=medium
+
+ * Rename "Adwaita" metacity-1 thumbnail to "Default". Force "Default" theme
+to always be included in the list of available themes. (Closes: #852973).
+ * Ship thumbnails for all metacity-1 and gtk-3.0 themes currently
+shipped in Debian. (Closes: #853064)
+
+ -- Margarita Manterola <ma...@debian.org> Sun, 29 Jan 2017 16:16:24 +0100
+
cinnamon (3.2.7-1) unstable; urgency=medium
* Add muffin runtime dependency
diff -Nru cinnamon-3.2.7/debian/cinnamon-common.install cinnamon-3.2.7/debian/cinnamon-common.install
--- cinnamon-3.2.7/debian/cinnamon-common.install 2017-01-03 21:23:08.0 +0100
+++ cinnamon-3.2.7/debian/cinnamon-common.install 2017-01-29 16:16:24.0 +0100
@@ -5,3 +5,4 @@
/usr/share/glib-2.0/schemas/*cinnamon*
/usr/share/icons
/usr/share/xsessions/cinnamon*
+debian/thumbnails /usr/share/cinnamon/
diff -Nru cinnamon-3.2.7/debian/patches/always-add-default-theme.patch cinnamon-3.2.7/debian/patches/always-add-default-theme.patch
--- cinnamon-3.2.7/debian/patches/always-add-default-theme.patch 1970-01-01 01:00:00.0 +0100
+++ cinnamon-3.2.7/debian/patches/always-add-default-theme.patch 2017-01-29 16:16:24.0 +0100
@@ -0,0 +1,19 @@
+Description: Forcefully add the Default theme to the list of themes.
+Author: ma...@debian.org
+Forwarded: not-yet
+Last-Update: 2017-01-29
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+Index: cinnamon/files/usr/share/cinnamon/cinnamon-settings/modules/cs_themes.py
+===
+--- cinnamon.orig/files/usr/share/cinnamon/cinnamon-settings/modules/cs_themes.py 2016-12-17 20:59:46.518954722 +0100
cinnamon/files/usr/share/cinnamon/cinnamon-settings/modules/cs_themes.py 2017-01-28 16:38:27.370618396 +0100
+@@ -341,7 +341,7 @@
+ dirs = ("/usr/share/themes", os.path.join(os.path.expanduser("~"), ".themes"))
+ valid = walk_directories(dirs, lambda d: os.path.exists(os.path.join(d, "metacity-1")), return_directories=True)
+ valid.sort(lambda a,b: cmp(a[0].lower(), b[0].lower()))
+-res = []
++
Bug#853089: unblock: cinnamon/3.2.7-2 cinnamon-desktop-data/3.2.4-4
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Hi, To fix two important UX bugs in cinnamon (#852973 and #853059), I intend to upload a new version of cinnamon and cinnamon-desktop-data to unstable. The mentioned bugs lead to bad user experience, which is an important feature for a desktop environment, so I'd really like to get them fixed in stretch. I'm attaching the debdiff for both packages for their version currently in testing (and unstable). I'd like to have confirmation that the packages will be unblocked before uploading them. Since the new cinnamon package includes a bunch of images that are not included in the debdiff, you can look at those here: https://anonscm.debian.org/git/pkg-cinnamon/cinnamon.git/tree/debian/thumbnails These would be the requested commands: unblock cinnamon/3.2.7-2 unblock cinnamon-desktop-data/3.2.4-4 -- Thanks! Marga
Bug#818620: jessie-pu: package cinnamon-settings-daemon/2.2.4.repack-7+deb8u1
Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian@packages.debian.org
Usertags: pu
Hi!
Moritz from the security team brought to the attention of the cinnamon team
that cinnamon-settings-daemon in stable contains a minor security issue that has
already been fixed in upstream.
This issue doesn't warrant a DSA, as it's only a circumvention of policykit
restrictions, but it would be good to fix it in a future point release.
I'm attaching the debdiff between the version currently in stable and the
proposed package for the point release.
Thanks!
-- System Information:
Debian Release: 8.2
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru cinnamon-settings-daemon-2.2.4.repack/debian/changelog cinnamon-settings-daemon-2.2.4.repack/debian/changelog
--- cinnamon-settings-daemon-2.2.4.repack/debian/changelog 2014-10-25 16:14:33.0 +0200
+++ cinnamon-settings-daemon-2.2.4.repack/debian/changelog 2016-03-18 20:32:16.0 +0100
@@ -1,3 +1,10 @@
+cinnamon-settings-daemon (2.2.4.repack-7+deb8u1) stable; urgency=medium
+
+ * Add debian/patches/csd-datetime-polkit-auth to fix a minor security bug.
+http://www.openwall.com/lists/oss-security/2015/10/28/3
+
+ -- Margarita Manterola <ma...@debian.org> Fri, 18 Mar 2016 20:13:36 +0100
+
cinnamon-settings-daemon (2.2.4.repack-7) unstable; urgency=medium
[ Fabio Fantoni ]
diff -Nru cinnamon-settings-daemon-2.2.4.repack/debian/patches/csd-datetime-polkit-auth cinnamon-settings-daemon-2.2.4.repack/debian/patches/csd-datetime-polkit-auth
--- cinnamon-settings-daemon-2.2.4.repack/debian/patches/csd-datetime-polkit-auth 1970-01-01 01:00:00.0 +0100
+++ cinnamon-settings-daemon-2.2.4.repack/debian/patches/csd-datetime-polkit-auth 2016-03-18 20:32:16.0 +0100
@@ -0,0 +1,21 @@
+Description: csd-datetime forgets to authorize users
+Author: https://github.com/leigh123linux
+Origin: upstream, ac5e0be8c1817616dbdb056b6881cfc4660f57a8
+Bug: http://www.openwall.com/lists/oss-security/2015/10/28/3
+Last-Update: 2016-03-14
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+Index: cinnamon-settings-daemon/plugins/datetime/csd-datetime-mechanism.c
+===
+--- cinnamon-settings-daemon.orig/plugins/datetime/csd-datetime-mechanism.c 2016-03-14 20:18:33.588428169 +0100
cinnamon-settings-daemon/plugins/datetime/csd-datetime-mechanism.c 2016-03-14 20:26:56.302535208 +0100
+@@ -354,6 +354,9 @@
+ int exit_status;
+ GError *error;
+
++if (!_check_polkit_for_action (mechanism, context))
++return FALSE;
++
+ date_str = g_strdup_printf ("%02d/%02d/%d", month, day, year);
+ error = NULL;
+
diff -Nru cinnamon-settings-daemon-2.2.4.repack/debian/patches/series cinnamon-settings-daemon-2.2.4.repack/debian/patches/series
--- cinnamon-settings-daemon-2.2.4.repack/debian/patches/series 2014-10-25 16:14:33.0 +0200
+++ cinnamon-settings-daemon-2.2.4.repack/debian/patches/series 2016-03-18 20:32:16.0 +0100
@@ -2,3 +2,4 @@
power-manager-upower-0.99-support
calculator-mediakey.patch
enable-3finger-tap.patch
+csd-datetime-polkit-auth
Bug#772147: unblock: cinnamon/2.2.16-5
Package: release.debian.org
User: release.debian@packages.debian.org
Usertags: unblock
Severity: normal
Please unblock package cinnamon
The latest upload includes fixes for 3 important bugs. The fixes are simple,
but the impact on the user experience is large.
The fixes all come from upstream. They are:
photoframe-desklet-fix-memory-leak.patch. (Closes: #761314)
- This prevents a very bad memory leak. The upstream patch includes a
refactoring that makes the diff less readable, so I've modified it to be as
minimal as possible.
Upstream change:
https://github.com/linuxmint/Cinnamon/commit/2f15a99773302db75f8ad1a60a21e7954218f9c6
fix-theme-regressions-with-gtk-3.14.patch. (Closes: #770556)
- This disables shadows on icons, because with the new GTK, the shadows for
SVG icons don't get properly scaled and appear huge in the screen, making some
particular screens (as the dropdown selector for opening a file with a program)
practically unusable.
fix-cinnamon2d-session.patch (Closes: #772145)
- This is a very simple patch, but without it, it's not possible to use
cinnamon2d.
I'm including the full debdiff, plus the three patches on their own, to make it
easier to look at them.
unblock cinnamon/2.2.16-5
--
Thanks!
MargaDescription: Fix theme regressions with gtk 3.14
Author: leigh123linux
Origin: git of fedora packages
---
--- a/data/theme/cinnamon.css
+++ b/data/theme/cinnamon.css
@@ -1445,7 +1445,8 @@
.applet-icon:hover,
.applet-box:hover .applet-icon {
color: #fff;
- icon-shadow: white 0px 0px 3px;
+/* Broken with GNOME 3.14 (icon-size is not honoured)
+ * icon-shadow: white 0px 0px 3px;*/
}
/* ===
--- a/files/usr/lib/cinnamon-settings/modules/cs_themes.py
+++ b/files/usr/lib/cinnamon-settings/modules/cs_themes.py
@@ -91,7 +91,7 @@
def _load_icon_themes(self):
dirs = (/usr/share/icons, os.path.join(os.path.expanduser(~), .icons))
-valid = walk_directories(dirs, lambda d: os.path.isdir(d) and not os.path.exists(os.path.join(d, cursors)) and os.path.exists(os.path.join(d, index.theme)))
+valid = walk_directories(dirs, lambda d: os.path.isdir(d) and os.path.exists(os.path.join(d, index.theme)))
valid.sort(lambda a,b: cmp(a.lower(), b.lower()))
res = []
for i in valid:
diff -Nru cinnamon-2.2.16/debian/changelog cinnamon-2.2.16/debian/changelog
--- cinnamon-2.2.16/debian/changelog 2014-10-25 20:00:57.0 +0200
+++ cinnamon-2.2.16/debian/changelog 2014-12-05 15:43:28.0 +0100
@@ -1,3 +1,12 @@
+cinnamon (2.2.16-5) unstable; urgency=medium
+
+ [ Fabio Fantoni ]
+ * New patch: photoframe-desklet-fix-memory-leak.patch. (Closes: #761314)
+ * New patch: fix-theme-regressions-with-gtk-3.14.patch. (Closes: #770556)
+ * New patch: fix-cinnamon2d-session.patch (Closes: #772145).
+
+ -- Margarita Manterola ma...@debian.org Fri, 05 Dec 2014 15:43:08 +0100
+
cinnamon (2.2.16-4) unstable; urgency=medium
[ Maximiliano Curia ]
diff -Nru cinnamon-2.2.16/debian/patches/fix-cinnamon2d-session.patch cinnamon-2.2.16/debian/patches/fix-cinnamon2d-session.patch
--- cinnamon-2.2.16/debian/patches/fix-cinnamon2d-session.patch 1970-01-01 01:00:00.0 +0100
+++ cinnamon-2.2.16/debian/patches/fix-cinnamon2d-session.patch 2014-12-05 15:43:28.0 +0100
@@ -0,0 +1,13 @@
+Description: Fix 2d session requirements.
+Author: Michael Webster miketwebs...@gmail.com
+Origin: upstream - e9c28b75626f180a67c8ed577ac284ea005e8a2d
+--- a/files/usr/share/cinnamon-session/sessions/cinnamon2d.session
b/files/usr/share/cinnamon-session/sessions/cinnamon2d.session
+@@ -1,6 +1,6 @@
+ [Cinnamon Session]
+ Name=Cinnamon (Software Rendering)
+-RequiredComponents=cinnamon;cinnamon-polkit-gnome-authentication-agent-1;cinnamon-settings-daemon;cinnamon-screensaver;nemo-autostart;nm-applet;
++RequiredComponents=cinnamon2d;cinnamon-polkit-gnome-authentication-agent-1;cinnamon-settings-daemon;cinnamon-screensaver;nemo-autostart;nm-applet;
+ DesktopName=X-Cinnamon
+
+
diff -Nru cinnamon-2.2.16/debian/patches/fix-theme-regressions-with-gtk-3.14.patch cinnamon-2.2.16/debian/patches/fix-theme-regressions-with-gtk-3.14.patch
--- cinnamon-2.2.16/debian/patches/fix-theme-regressions-with-gtk-3.14.patch 1970-01-01 01:00:00.0 +0100
+++ cinnamon-2.2.16/debian/patches/fix-theme-regressions-with-gtk-3.14.patch 2014-12-05 15:43:28.0 +0100
@@ -0,0 +1,27 @@
+Description: Fix theme regressions with gtk 3.14
+Author: leigh123linux
+Origin: git of fedora packages
+---
+--- a/data/theme/cinnamon.css
b/data/theme/cinnamon.css
+@@ -1445,7 +1445,8 @@
+ .applet-icon:hover,
+ .applet-box:hover .applet-icon {
+ color: #fff
Bug#770728: unblock: ruby-em-hiredis/0.2.1-2.1
Package: release.debian.org User: release.debian@packages.debian.org Usertags: unblock Severity: normal Please unblock package ruby-em-hiredis The previous version was removed due to a FTBFS caused by some tests requiring the lo interface to exist. The new version disables these tests. This package is a dependecy of ruby-em-synchrony, which is a build dependency of ruby-faraday, currently FTBFSing because of this removal. I'm attaching the debdiff of the fixed version. unblock ruby-em-hiredis/0.2.1-2.1 -- Cheers, Marga ruby-em-hiredirs.debdiff Description: Binary data
Bug#770728: unblock: ruby-em-hiredis/0.2.1-2.1
Hi, On Sun, Nov 23, 2014 at 6:13 PM, Adam D. Barratt a...@adam-barratt.org.uk wrote: This package is a dependecy of ruby-em-synchrony, which is a build dependency of ruby-faraday, currently FTBFSing because of this removal. Unblocking this package won't make -synchrony eligible for migration, however. Was that an intended (but not stated) effect of this request? Yes, sorry, I'm new to the unblocking process, I thought I would file a separate unblock for -synchrony if this one got approved. If they should be unblocked together, then I guess the request should have been: unblock ruby-em-hiredis/0.2.1-2.1 unblock ruby-em-synchrony/1.0.3-1 -- Thanks, Marga -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/CAL0136zSPmchvpQKHV1XA79gQdCK-J7ALiyiXAp=fesaukj...@mail.gmail.com
Bug#770733: unblock: fontconfig/2.11.0-6.3
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Please unblock package fontconfig The package in jessie includes a postinst that will override changes done by the sysadmin (by recreating links in /etc even if they had been removed). The package in unstable has the postinst modified so that the symlinks are only touched on installation or reconfigure stage. The package in testing is 2.11.0-6.1, the one in unstable is 2.11.0-6.2, and is already has an unblock request (#770370). I'm including the debdiff against that version, plus the wdiff (almost all the lines in my change were just indented), plus the debdiff against the package in testing unblock fontconfig/2.11.0-6.3 -- Thanks, Marga fontconfig-to-testing.debdiff Description: Binary data fontconfig.wdiff Description: Binary data fontconfig-to-unstable.debdiff Description: Binary data
Bug#694093: RM: bcrypt/1.1-6
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: rm Hi, bcrypt is a tool to encrypt files using the blowfish algorithm. It's quite new and after spending a couple of hours with the code, I can say that it's not release quality at all. RC Bugs: * bugs.debian.org/693460 Can't handle files larger than 4GB, causes data loss if used with default parameters. * bugs.debian.org/694091 Loads the whole file into memory, causes processes deaths when trying to allocate more memory than the machine has. Other bugs: * bugs.debian.org/562084 Crashes when decrypting read-only files Pretty much the same functionality that bcrypt offers can be achieved with openssl (openssl bf -in infile -out outfile). I recommend that bcrypt should be removed from testing until these bugs have been addressed. -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 3.2.0-0.bpo.2-686-pae (SMP w/2 CPU cores) Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121123205531.7218.78939.reportbug@ulises.amadeus
Bug#694093: RM: bcrypt/1.1-6
Hola Adam D. Barratt! On Fri, 2012-11-23 at 20:55 +, Margarita Manterola wrote: bcrypt is a tool to encrypt files using the blowfish algorithm. It's quite new and after spending a couple of hours with the code, I can say that it's ^^^ s/new/old/, maybe? :-) [2004-01-19] Accepted 1.1-2 in unstable (low) (Samuele Giovanni Tonon) [...] [2009-11-01] bcrypt 1.1-6 MIGRATED to testing (Britney) Wow. I obviously didn't check the dates. By looking at the code I assumed it was new and immature. -- Regards, Marga -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121123213111.GC7351@localhost
Please unblock splix/1.0.1-1.2
Hi! I've uploaded splix/1.0.1-1.2 a few days ago. It fixes an important usability bug (#439817, ML-2010 printers not working properly) with a very small patch, taken from upstream's svn repo. Users that experienced the problem with the previous package have already sent in their confirmation that this package fixes it for them. I think this bug is important enough to include the fix in Debian Lenny. So, please unblock splix/1.0.1-1.2. Thanks! This is the debdiff: diff -u splix-1.0.1/src/spl2.cpp splix-1.0.1/src/spl2.cpp --- splix-1.0.1/src/spl2.cpp +++ splix-1.0.1/src/spl2.cpp @@ -169,7 +169,8 @@ header[0xd] = _printer-docHeaderValues(1); // ??? XXX header[0xe] = _printer-qpdlVersion(); // QPDL Version header[0xf] = _printer-docHeaderValues(2); // ??? XXX -if (_printer-resolutionY() != _printer-resolutionX()) +if (_printer-resolutionY() != _printer-resolutionX() || +_printer-docHeaderValues(2) == 1) header[0x10] = _printer-resolutionX() / 100; // X Resolution else header[0x10] = 0; // X Resolution = Y Res. diff -u splix-1.0.1/debian/changelog splix-1.0.1/debian/changelog --- splix-1.0.1/debian/changelog +++ splix-1.0.1/debian/changelog @@ -1,3 +1,11 @@ +splix (1.0.1-1.2) unstable; urgency=low + + * Non-maintainer upload to fix important usability bug. + * Applied patch from upstream that corrects a bug for the ML-2010 +printer. Thanks to Pablo De Napoli for the patch. (Closes: #439817) + + -- Margarita Manterola [EMAIL PROTECTED] Sun, 12 Oct 2008 15:46:27 + + splix (1.0.1-1.1) unstable; urgency=medium * Non-maintainer upload. -- Saludos, Marga -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Allowing libtrash into lenny?
Hi! I have sponsored the upload of libtrash_2.4-2, which fixes RC bug #488467, a reproducible segfault in amd64. I see that libtrash was removed from testing last week. I had the diff from the maintainer to do the upload since the 5th, but due to various reasons couldn't do it until today. Could libtrash_2.4-2 be allowed into lenny now that #488467 is fixed? Thanks. -- Margarita Manterola -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Idea for dealing with transitions
Motivation: For some time now, one of the things that the Release Team has had to deal with are complex transitions. One of the requirements for making a transition work is that maintainers of involved packages must not upload. However, for whatever reasons, some maintainers do upload, and thus a lot of time is wasted. Proposal: Implement a new file, that works similarly to the hints file, but that causes uploads to unstable for selected packages to be rejected. Thus, if a maintainer uploads, it won't get through so that it won't get in the way of the transition. I talked about this with Dato and Ganneff. They suggested the file should be a yaml file, listing source packages, and the reason for the blocking (i.e. the transition they are involved in). Ganneff volunteered to prepare the patch after the format of the file is decided. So, what do you think about it? PS: no need to CC me, I'm subscribed. -- Saludos, Marga -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Please unblock linsmith for etch
Hi! The linsmith version in sid was updated 20 days ago to include a couple of bugfixes. This is the changelog entry: linsmith (0.99.1-2) unstable; urgency=low * Added font_name_buffer.dpatch from 0.99.2 to fix a possible buffer overflow with very long font names. * Added other_buffers.dpatch from 0.99.3 to fix some other, less important, buffer overflows. (Closes: #403298) -- Margarita Manterola [EMAIL PROTECTED] Thu, 8 Feb 2007 17:05:16 These bugs are not RC, since the buffer overflows are not easy to exploit, but they are still buffer overflows, and thus I'd like to see this fixes in etch. Thanks. -- Saludos, Marga -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: I ask to put libapache2-mod-fcgid into etch
Hi! I'm not part of the release-team, but I'm replying to you in the wish of being helpful, about the libapache2-mod-fcgid package. I'd like to put libapache2-mod-fcgid into etch certainly. Actually I do't resolve libapache2-mod-fcgid bugs yet. The latest package for libapache2-mod-fcgid was removed from testing for the following reason: Bug #401938: libapache2-mod-fcgid: Segfaults on startup with Apache 2.2 A package that segfaults on startup is considered buggy and therefore cannot be included in a Debian Stable release. But previous version 1.10-1.1 works properly. 1.10-1 has no bugs over 3 monthes, and NMUed -1.1 for apache2.2 dependencies. If the previous version worked properly, what you have to do is find why this one is not working properly, and do an upload that fixes the bug. Only after that should you go back to debian-release and ask for the package to go into testing (which might happen or not). Can I ask to put libapache2-mod-fcgid 1.10-1.1 into etch? Or, do I need surely to fix current version to contain the package into etch? You need to fix your package first, then ask for it to go into testing. -- Love, Marga -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Re: Some observations regardig the progress towards Debian 3.1
On Sun, 16 Nov 2003 02:23:00 +0100, Adrian Bunk wrote: You need a freeze at one point (unstable or testing) to get a base where you can start to fix the remaining problems without new bugs from new upstream versions. The choices are: - freeze testing and start then to backport all the bug fixes and security fixes from unstable - freeze unstable and try to get as many packages as possible from unstable into testing (exactly the work you are currently doing, but based on a more stable basis) - freeze unstable and use unstable as a basis How about changing the way testing works? I mean, we've come to the point when we realize that the testing/unstable structure is not really working, so we added experimental. Now, I suggest: allow a way to add bug-fixes directly into testing, instead of having them go through unstable first. If there's a new (and very buggy) version in unstable, but there's an easy-to-fix bug in testing, why not allow developers to fix this bug without going through the unstable barrier? I'm not a developer, I consider myself a Debian bug-reporter. And I usually report bugs for testing, and many times I've received the reply this is fixed in unstable, but then unstable never comes because there are LOTS of other bugs. So, why not allow the bug-fixes to go into testing, even if the new version does not come? I'm not talking about some manual security update, I'm talking about a systematic way of doing it. For sarge and for the next release as well. I don't know how to implement this, but I think it would be a great idea to allow it, so that testing packages would get less and less buggy, no matter what happens in unstable. Love, Margarita Manterola. PS: As a Debian user, I would really hate to see sarge released as it is right now. I consider an insult to the user that Evolution is not in the release (not even the old woody version). But this is outside my present suggestion.
