Re: Bug#675207: [Dolfin] Please binNMU python-ufc against latest swig

2012-06-21 Thread Johannes Ring
On Sat, Jun 16, 2012 at 10:40 AM, Julien Cristau jcris...@debian.org wrote:
 On Fri, Jun 15, 2012 at 10:32:56 +0200, Johannes Ring wrote:
 On Thu, Jun 14, 2012 at 4:46 PM, Julien Cristau
 julien.cris...@logilab.fr wrote:
  If dolfin only works with the version of swig it was built against, that
  needs to be reflected in the package dependencies.

 Okay, but I'm unsure how to do that. Currently I have Build-Depends:
 swig2.0 in the source package and Depends: swig2.0 in the binary
 package python-dolfin. What should I put there instead? Are you
 suggesting that I should add something like {Build-}Depends: swig2.0
 (= 2.0.7), swig2.0 ( 2.0.8)? Wouldn't that require me to do a new
 upload when swig 2.0.8 is added in the future? If so, is that any
 better than doing binNMU's?

 I'm suggesting you should leave your build-depends alone, check at
 build-time what the swig version is, and generate a Depends on that
 (upstream) version.  binNMUs would still work, and you wouldn't get an
 installable but broken package.

Thanks Julien and sorry about the late reply. I'm not sure how I end
up doing things but I'll keep your suggestion in mind.

Johannes


--
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/caljqy_fhn-ujh4hjp0dlj5ke0imyg6pnk7zf09zzk_z_xxp...@mail.gmail.com



Re: Bug#675207: [Dolfin] Please binNMU python-ufc against latest swig

2012-06-16 Thread Julien Cristau
On Fri, Jun 15, 2012 at 10:32:56 +0200, Johannes Ring wrote:

 On Thu, Jun 14, 2012 at 4:46 PM, Julien Cristau
 julien.cris...@logilab.fr wrote:
  If dolfin only works with the version of swig it was built against, that
  needs to be reflected in the package dependencies.
 
 Okay, but I'm unsure how to do that. Currently I have Build-Depends:
 swig2.0 in the source package and Depends: swig2.0 in the binary
 package python-dolfin. What should I put there instead? Are you
 suggesting that I should add something like {Build-}Depends: swig2.0
 (= 2.0.7), swig2.0 ( 2.0.8)? Wouldn't that require me to do a new
 upload when swig 2.0.8 is added in the future? If so, is that any
 better than doing binNMU's?
 
I'm suggesting you should leave your build-depends alone, check at
build-time what the swig version is, and generate a Depends on that
(upstream) version.  binNMUs would still work, and you wouldn't get an
installable but broken package.

Cheers,
Julien


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120616084047.gd12...@radis.cristau.org



Re: Bug#675207: [Dolfin] Please binNMU python-ufc against latest swig

2012-06-15 Thread Johannes Ring
On Thu, Jun 14, 2012 at 4:46 PM, Julien Cristau
julien.cris...@logilab.fr wrote:
 If dolfin only works with the version of swig it was built against, that
 needs to be reflected in the package dependencies.

Okay, but I'm unsure how to do that. Currently I have Build-Depends:
swig2.0 in the source package and Depends: swig2.0 in the binary
package python-dolfin. What should I put there instead? Are you
suggesting that I should add something like {Build-}Depends: swig2.0
(= 2.0.7), swig2.0 ( 2.0.8)? Wouldn't that require me to do a new
upload when swig 2.0.8 is added in the future? If so, is that any
better than doing binNMU's?

Johannes


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/CALjQY_FCOtcUcMOz1=P_wiK5YidAKiSUFZvkzwDZ3ZR=xng...@mail.gmail.com



Re: [Dolfin] Please binNMU python-ufc against latest swig

2012-06-14 Thread Johannes Ring
On Wed, Jun 13, 2012 at 10:38 PM, Anders Logg l...@simula.no wrote:
 Does it work if you remove those checks in

    dolfin/site-packages/dolfin/compilemodules/compilemodule.py
    dolfin/site-packages/dolfin/compilemodules/jit.py

 ?

Yes, it works fine, but I also had to remove the check in
ufc_utils/build.py in UFC.

 If so, we might turn those into warnings.

Yes, maybe that is a good idea.

Johannes


--
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/CALjQY_F2k4HdJ==ckxsfkczqcbu5ptyzau+ogpeaykn-yub...@mail.gmail.com



Re: [Dolfin] Please binNMU python-ufc against latest swig

2012-06-14 Thread Johan Hake

On 06/14/2012 09:46 AM, Johannes Ring wrote:

On Wed, Jun 13, 2012 at 10:38 PM, Anders Loggl...@simula.no  wrote:

Does it work if you remove those checks in

dolfin/site-packages/dolfin/compilemodules/compilemodule.py
dolfin/site-packages/dolfin/compilemodules/jit.py

?


Yes, it works fine, but I also had to remove the check in
ufc_utils/build.py in UFC.


If so, we might turn those into warnings.


Not sure why we would like to do that? If we are going to ship 
precompiled binaries we better make sure all packages including JIT 
compiled stuff are using the same SWIG version.


We have not got any reports of this not working (because we have 
prevented it), but I think it would be gambling to allow this. If an 
error occur it will most probably be very cryptic and implode the user 
experience.


Can't this be handled by some elaborated debain version logic?

Johan


Yes, maybe that is a good idea.

Johannes

___
Mailing list: https://launchpad.net/~dolfin
Post to : dol...@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dolfin
More help   : https://help.launchpad.net/ListHelp



--
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4fd9cef4.7040...@gmail.com



Re: [Dolfin] Please binNMU python-ufc against latest swig

2012-06-14 Thread Johannes Ring
On Thu, Jun 14, 2012 at 1:45 PM, Johan Hake hake@gmail.com wrote:
 On 06/14/2012 09:46 AM, Johannes Ring wrote:
 On Wed, Jun 13, 2012 at 10:38 PM, Anders Loggl...@simula.no  wrote:
 Does it work if you remove those checks in

    dolfin/site-packages/dolfin/compilemodules/compilemodule.py
    dolfin/site-packages/dolfin/compilemodules/jit.py

 ?

 Yes, it works fine, but I also had to remove the check in
 ufc_utils/build.py in UFC.

 If so, we might turn those into warnings.

 Not sure why we would like to do that? If we are going to ship precompiled
 binaries we better make sure all packages including JIT compiled stuff are
 using the same SWIG version.

 We have not got any reports of this not working (because we have prevented
 it), but I think it would be gambling to allow this. If an error occur it
 will most probably be very cryptic and implode the user experience.

Good point.

 Can't this be handled by some elaborated debain version logic?

The simplest solution would be to rebuild UFC and DOLFIN whenever a
new version of SWIG is added in Debian. That's why i requested a
binNMU. Not sure if it would be possible to automate this in some way.

Johannes


--
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/caljqy_fu4svhccgznqf+xv3n3p6xkboexcbump0muubtau_...@mail.gmail.com



Re: Bug#675207: [Dolfin] Please binNMU python-ufc against latest swig

2012-06-14 Thread Julien Cristau
On Thu, Jun 14, 2012 at 14:19:21 +0200, Johannes Ring wrote:

 The simplest solution would be to rebuild UFC and DOLFIN whenever a
 new version of SWIG is added in Debian. That's why i requested a
 binNMU. Not sure if it would be possible to automate this in some way.
 
If dolfin only works with the version of swig it was built against, that
needs to be reflected in the package dependencies.

Cheers,
Julien
-- 
Julien Cristau  julien.cris...@logilab.fr
Logilab http://www.logilab.fr/
Informatique scientifique  gestion de connaissances


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120614144635.gb...@crater1.logilab.fr



Re: [Dolfin] Please binNMU python-ufc against latest swig

2012-06-13 Thread Anders Logg
On Tue, Jun 05, 2012 at 09:33:36AM +0200, Johannes Ring wrote:
 On Mon, Jun 4, 2012 at 7:30 PM, Julien Cristau jcris...@debian.org wrote:
  On Mon, Jun  4, 2012 at 08:43:54 +0200, Johannes Ring wrote:
 
  On Mon, Jun 4, 2012 at 2:05 AM, Cyril Brulebois k...@debian.org wrote:
   Johannes Ring joha...@simula.no (31/05/2012):
   python-ufc needs to be rebuilt against the latest swig (2.0.7). Please
   binNMU it.
  
     nmu python-ufc_2.0.5-2 . ALL . -m 'Rebuild against swig 2.0.7, see 
   #675207.'
  
   if this package has such strict dependencies on swig, why aren't they
   exposed through strict package dependencies?
 
  You mean by adding something like swig2.0 (= 2.0.7) in
  Build-Depends? The thing is that UFC only depends on SWIG = 2.0.0,
  however, it will always need to be rebuilt whenever a new SWIG release
  enters the archive. Can this be automated or will I need to request a
  binNMU each time?
 
  That sounds broken.  Why is that necessary?

 When you run DOLFIN, efficient low-level C++ code (UFC) is
 automatically generated. This is done using SWIG and the SWIG version
 needs to be the same that was used when building UFC and DOLFIN.

 I'm Cc'ing the DOLFIN list to get more input on this.

 Johannes

Does this break because we check the SWIG version in the JIT compiler,
or because it actually breaks (with some link error)?

--
Anders


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120613191510.GL2562@glaurung



Re: [Dolfin] Please binNMU python-ufc against latest swig

2012-06-13 Thread Johannes Ring
On Wed, Jun 13, 2012 at 9:15 PM, Anders Logg l...@simula.no wrote:
 Does this break because we check the SWIG version in the JIT compiler,
 or because it actually breaks (with some link error)?

It is the version check that makes it break. This is the error message:

  OSError: PyDOLFIN was not compiled with the present version of swig.
  Install swig version 2.0.5 or recompiled PyDOLFIN with present swig

Both UFC and DOLFIN was built with SWIG 2.0.5, while 2.0.7 is the
current version in Debian unstable.

Johannes


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/caljqy_fyerltdw1xqmmn-o8jqgx_ncdxa+gfg43uswefavn...@mail.gmail.com



Re: [Dolfin] Please binNMU python-ufc against latest swig

2012-06-13 Thread Anders Logg
On Wed, Jun 13, 2012 at 09:53:48PM +0200, Johannes Ring wrote:
 On Wed, Jun 13, 2012 at 9:15 PM, Anders Logg l...@simula.no wrote:
  Does this break because we check the SWIG version in the JIT compiler,
  or because it actually breaks (with some link error)?

 It is the version check that makes it break. This is the error message:

   OSError: PyDOLFIN was not compiled with the present version of swig.
   Install swig version 2.0.5 or recompiled PyDOLFIN with present swig

 Both UFC and DOLFIN was built with SWIG 2.0.5, while 2.0.7 is the
 current version in Debian unstable.

Does it work if you remove those checks in

dolfin/site-packages/dolfin/compilemodules/compilemodule.py
dolfin/site-packages/dolfin/compilemodules/jit.py

?

If so, we might turn those into warnings.

Johan Hake can comment on whether the checks could be losened.

--
Anders


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120613203803.GI5177@glaurung