Bug#1042730: Follow-up on zfs-linux in bookworm-pu
Hi, > Please cherry-pick a fix for this and propose a new debdiff; the upstream > release contains too much else to be accepted. The current version 2.1.11 of zfs-linux in bookworm suffers from CVE-2023-49298, which leads to potential data loss. I believe Aron’s latest proposed patch contains some useful stability fixes including this one. Would there be any follow-up on this bug? Or do we need to further narrow down the patch for it to be accepted? Thanks, Shengqi Chen
Bug#1042730:
Control: retitle -1 bookworm-pu: package zfs-linux/2.1.11-1+deb12u1 Hi, Please find a further updated version of debdiff in the attachment, it includes the fix for Bug #1056752 which is a data loss issue. The debdiff itself looks very large (2298 insertions), but filtering the actual changes there are quite a lot of upstream commit messages and noises of test cases: $ cd zfs-linux-2.1.11/debian/patches/ $ diffstat 001[2-9]*.patch 002*.patch b/cmd/zed/agents/zfs_mod.c |2 b/cmd/zed/agents/zfs_retire.c |8 + b/contrib/bash_completion.d/zfs.in |2 b/contrib/initramfs/scripts/zfs |6 - b/contrib/pam_zfs_key/pam_zfs_key.c | 13 -- b/include/sys/spa.h |1 b/module/os/linux/spl/spl-kmem-cache.c | 12 ++ b/module/os/linux/zfs/zfs_vnops_os.c |6 + b/module/zfs/dmu_recv.c | 26 + b/module/zfs/dmu_send.c |8 + b/module/zfs/dnode.c | 12 ++ b/module/zfs/mmp.c |2 b/module/zfs/spa.c |5 - b/module/zfs/spa_misc.c | 29 +- b/module/zfs/vdev.c | 12 ++ b/module/zfs/vdev_label.c |3 b/module/zfs/vdev_trim.c | 28 -- b/module/zfs/zil.c |1 b/tests/runfiles/common.run |2 b/tests/runfiles/sanity.run |1 b/tests/zfs-tests/tests/functional/cli_root/zpool_import/Makefile.am |1 b/tests/zfs-tests/tests/functional/cli_root/zpool_import/import_log_missing.ksh | 75 + b/tests/zfs-tests/tests/functional/cli_root/zpool_resilver/Makefile.am |3 b/tests/zfs-tests/tests/functional/cli_root/zpool_resilver/zpool_resilver_concurrent.ksh | 101 +++ b/tests/zfs-tests/tests/functional/l2arc/persist_l2arc_001_pos.ksh | 19 +--- b/tests/zfs-tests/tests/functional/rsend/Makefile.am |1 b/tests/zfs-tests/tests/functional/rsend/send_encrypted_freeobjects.ksh | 87 +++ cmd/zed/agents/zfs_retire.c |5 + include/sys/spa.h |2 module/zfs/spa.c | 15 +++ module/zfs/vdev.c | 24 - tests/runfiles/common.run |9 +- 32 files changed, 460 insertions(+), 61 deletions(-) There are totally 299 changes in tests which are mostly insertions. Thanks, Aron zfs-linux_2.1.11-1+deb12u1.debdiff Description: Binary data
Bug#1042730: bookworm-pu: package zfs-linux/2.1.12-1~deb12u1
Control: tag -1 - moreinfo Hi, On Wed, Aug 2, 2023 at 3:57 AM Jonathan Wiltshire wrote: > > On Mon, Jul 31, 2023 at 03:53:23PM +0800, Aron Xu wrote: > > zfs-linux in bookworm is affected by #1040183 which is considered an > > important malfunction. > > Please cherry-pick a fix for this and propose a new debdiff; the upstream > release contains too much else to be accepted. > I've tried to narrow down to a couple of stability fixes, with explanations for each patch in d/changelog, would you mind having a look? Thanks, Aron zfs-linux_2.1.11-1+deb12u1.debdiff Description: Binary data
Processed: Re: Bug#1042730: bookworm-pu: package zfs-linux/2.1.12-1~deb12u1
Processing control commands: > tag -1 - moreinfo Bug #1042730 [release.debian.org] bookworm-pu: package zfs-linux/2.1.12-1~deb12u1 Removed tag(s) moreinfo. -- 1042730: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1042730 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Re: Bug#1042730: bookworm-pu: package zfs-linux/2.1.12-1~deb12u1
Processing control commands: > tag -1 moreinfo Bug #1042730 [release.debian.org] bookworm-pu: package zfs-linux/2.1.12-1~deb12u1 Added tag(s) moreinfo. -- 1042730: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1042730 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#1042730: bookworm-pu: package zfs-linux/2.1.12-1~deb12u1
Control: tag -1 moreinfo On Mon, Jul 31, 2023 at 03:53:23PM +0800, Aron Xu wrote: > zfs-linux in bookworm is affected by #1040183 which is considered an > important malfunction. Please cherry-pick a fix for this and propose a new debdiff; the upstream release contains too much else to be accepted. Thanks, -- Jonathan Wiltshire j...@debian.org Debian Developer http://people.debian.org/~jmw 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51 ed25519/0x196418AAEB74C8A1: CA619D65A72A7BADFC96D280196418AAEB74C8A1