Bug#596364: unblock: cracklib2/2.8.16-3
On Mon, Sep 13, 2010 at 07:33:40PM +0200, Jan Dittberner wrote: On Sat, Sep 11, 2010 at 11:24:59PM +0200, Philipp Kern wrote: On Sat, Sep 11, 2010 at 10:31:27PM +0200, Jan Dittberner wrote: I checked all Breaks, Provides and Conflicts statements in debian/control. They all refer to version prior to Lenny. The binary package python-crack was a transitional package in Lenny the other were even older. I think it is best to remove all the unnecessary Provides, Conflicts and Breaks. I think you need to retain the conflicts against python-crack then, because it should still get deinstalled on upgrades to squeeze. I re-added the Conflicts: python-crack (an updated debdiff is attached to this mail). I tested the upgrade from Lenny with the installed transitional package to this version and it removed python-crack properly. Please tell me whether you would unblock an upload with this change. Yep. Kind regards, Philipp Kern signature.asc Description: Digital signature
Bug#596364: unblock: cracklib2/2.8.16-3
retitle 596364 unblock: cracklib2/2.8.16-4 thanks On Sat, Sep 18, 2010 at 06:12:47PM +0200, Philipp Kern wrote: On Mon, Sep 13, 2010 at 07:33:40PM +0200, Jan Dittberner wrote: I re-added the Conflicts: python-crack (an updated debdiff is attached to this mail). I tested the upgrade from Lenny with the installed transitional package to this version and it removed python-crack properly. Please tell me whether you would unblock an upload with this change. Yep. Great, I uploaded cracklib2_2.8.16-4 with the approved changes. Please unblock cracklib2/2.8.16-4 Regards Jan Dittberner -- Jan Dittberner - Debian Developer GPG-key: 4096R/558FB8DD 2009-05-10 B2FF 1D95 CE8F 7A22 DF4C F09B A73E 0055 558F B8DD http://ddportfolio.debian.net/ - http://people.debian.org/~jandd/ signature.asc Description: Digital signature
Processed: Re: Bug#596364: unblock: cracklib2/2.8.16-3
Processing commands for cont...@bugs.debian.org: retitle 596364 unblock: cracklib2/2.8.16-4 Bug #596364 [release.debian.org] future unblock: cracklib2/2.8.16-4 Changed Bug title to 'unblock: cracklib2/2.8.16-4' from 'future unblock: cracklib2/2.8.16-4' thanks Stopping processing here. Please contact me if you need assistance. -- 596364: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=596364 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.1284834653945.transcr...@bugs.debian.org
Bug#596364: unblock: cracklib2/2.8.16-3
On Sat, Sep 11, 2010 at 11:24:59PM +0200, Philipp Kern wrote:
On Sat, Sep 11, 2010 at 10:31:27PM +0200, Jan Dittberner wrote:
I checked all Breaks, Provides and Conflicts statements in debian/control.
They
all refer to version prior to Lenny. The binary package python-crack was a
transitional package in Lenny the other were even older. I think it is best
to
remove all the unnecessary Provides, Conflicts and Breaks.
I think you need to retain the conflicts against python-crack then, because it
should still get deinstalled on upgrades to squeeze.
I re-added the Conflicts: python-crack (an updated debdiff is attached to this
mail). I tested the upgrade from Lenny with the installed transitional package
to this version and it removed python-crack properly.
Please tell me whether you would unblock an upload with this change.
Regards
Jan Dittberner
--
Jan Dittberner - Debian Developer
GPG-key: 4096R/558FB8DD 2009-05-10
B2FF 1D95 CE8F 7A22 DF4C F09B A73E 0055 558F B8DD
http://ddportfolio.debian.net/ - http://people.debian.org/~jandd/
diff -Nru cracklib2-2.8.16/debian/changelog cracklib2-2.8.16/debian/changelog
--- cracklib2-2.8.16/debian/changelog 2010-09-10 18:44:28.0 +0200
+++ cracklib2-2.8.16/debian/changelog 2010-09-13 19:00:08.0 +0200
@@ -1,3 +1,11 @@
+cracklib2 (2.8.16-4) unstable; urgency=low
+
+ * debian/control: remove Conflicts, Provides and Breaks refering to versions
+and packages before Lenny, keep python-cracklib's Conflicts with
+python-crack to force deinstallation of transitional package
+
+ -- Jan Dittberner ja...@debian.org Mon, 13 Sep 2010 19:00:03 +0200
+
cracklib2 (2.8.16-3) unstable; urgency=low
* debian/control: update to Standards-Version to 3.9.1
diff -Nru cracklib2-2.8.16/debian/control cracklib2-2.8.16/debian/control
--- cracklib2-2.8.16/debian/control 2010-09-10 18:44:28.0 +0200
+++ cracklib2-2.8.16/debian/control 2010-09-13 19:00:08.0 +0200
@@ -16,10 +16,6 @@
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
Recommends: cracklib-runtime
-Conflicts: cracklib2.6
-Breaks: cracklib2 ( 2.8.12-1)
-Provides: cracklib2
-Replaces: cracklib2.6, cracklib2 ( 2.8.12-1)
Description: pro-active password checker library
Shared library for cracklib2 which contains a C function which may be
used in a passwd like program. The idea is simple: try to prevent
@@ -33,10 +29,6 @@
Architecture: any
Depends: libcrack2 (=${binary:Version}), ${misc:Depends}
Recommends: cracklib-runtime
-Provides: cracklib-dev, cracklib2-dev
-Conflicts: cracklib-dev
-Breaks: cracklib2-dev ( 2.8.12-1)
-Replaces: cracklib-dev, cracklib2-dev ( 2.8.12-1)
Description: pro-active password checker library - development files
Header files, static libraries, documentation, and symbolic links
developers using cracklib2 will need.
@@ -64,7 +56,6 @@
(=${binary:Version})
Provides: ${python:Provides}
Conflicts: python-crack
-Replaces: python-crack
XB-Python-Version: ${python:Versions}
Description: Python bindings for password checker library cracklib2
This package provides Python bindings for cracklib. It contains a
signature.asc
Description: Digital signature
Bug#596364: unblock: cracklib2/2.8.16-3
Jan, On Fri, Sep 10, 2010 at 08:21:08PM +0200, Jan Dittberner wrote: Please unblock package cracklib2 it includes a bugfix for RC bug #596281. A diff to the previous version is attached. unblock cracklib2/2.8.16-3 I'm not happy about the Breaks change. First of all, why changing a version constraint on something pre-Lenny at all at this point, instead of removing it, because we don't support skipping releases. Secondly there's nothing to upgrade to, to solve the Breaks. But then policy suggests that the package management will deconfigure the offending package. I'm fearing that all this random let's convert stuff to Breaks will cause trouble in upgrading from Lenny. I'd suggest you to just drop it instead. Kind regards, Philipp Kern signature.asc Description: Digital signature
Bug#596364: unblock: cracklib2/2.8.16-3
On Sat, Sep 11, 2010 at 12:09:19PM +0200, Philipp Kern wrote:
Jan,
On Fri, Sep 10, 2010 at 08:21:08PM +0200, Jan Dittberner wrote:
Please unblock package cracklib2
it includes a bugfix for RC bug #596281. A diff to the previous
version is attached.
unblock cracklib2/2.8.16-3
I'm not happy about the Breaks change. First of all, why changing a version
constraint on something pre-Lenny at all at this point, instead of removing
it,
because we don't support skipping releases. Secondly there's nothing to
upgrade to, to solve the Breaks. But then policy suggests that the package
management will deconfigure the offending package.
I'm fearing that all this random let's convert stuff to Breaks will cause
trouble in upgrading from Lenny. I'd suggest you to just drop it instead.
I checked all Breaks, Provides and Conflicts statements in debian/control. They
all refer to version prior to Lenny. The binary package python-crack was a
transitional package in Lenny the other were even older. I think it is best to
remove all the unnecessary Provides, Conflicts and Breaks.
I prepared a new version (not uploaded yet). Would you please confirm whether
the change is appropriate and whether you would unblock a new version that
includes only this change to the current version in unstable.
Regards,
Jan Dittberner
--
Jan Dittberner - Debian Developer
GPG-key: 4096R/558FB8DD 2009-05-10
B2FF 1D95 CE8F 7A22 DF4C F09B A73E 0055 558F B8DD
http://ddportfolio.debian.net/ - http://people.debian.org/~jandd/
diff -Nru cracklib2-2.8.16/debian/changelog cracklib2-2.8.16/debian/changelog
--- cracklib2-2.8.16/debian/changelog 2010-09-10 18:44:28.0 +0200
+++ cracklib2-2.8.16/debian/changelog 2010-09-11 22:21:26.0 +0200
@@ -1,3 +1,10 @@
+cracklib2 (2.8.16-4) unstable; urgency=low
+
+ * remove Conflicts, Provides and Breaks refering to versions and
+packages before Lenny
+
+ -- Jan Dittberner ja...@debian.org Sat, 11 Sep 2010 22:14:29 +0200
+
cracklib2 (2.8.16-3) unstable; urgency=low
* debian/control: update to Standards-Version to 3.9.1
diff -Nru cracklib2-2.8.16/debian/control cracklib2-2.8.16/debian/control
--- cracklib2-2.8.16/debian/control 2010-09-10 18:44:28.0 +0200
+++ cracklib2-2.8.16/debian/control 2010-09-11 22:21:26.0 +0200
@@ -16,10 +16,6 @@
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
Recommends: cracklib-runtime
-Conflicts: cracklib2.6
-Breaks: cracklib2 ( 2.8.12-1)
-Provides: cracklib2
-Replaces: cracklib2.6, cracklib2 ( 2.8.12-1)
Description: pro-active password checker library
Shared library for cracklib2 which contains a C function which may be
used in a passwd like program. The idea is simple: try to prevent
@@ -33,10 +29,6 @@
Architecture: any
Depends: libcrack2 (=${binary:Version}), ${misc:Depends}
Recommends: cracklib-runtime
-Provides: cracklib-dev, cracklib2-dev
-Conflicts: cracklib-dev
-Breaks: cracklib2-dev ( 2.8.12-1)
-Replaces: cracklib-dev, cracklib2-dev ( 2.8.12-1)
Description: pro-active password checker library - development files
Header files, static libraries, documentation, and symbolic links
developers using cracklib2 will need.
@@ -63,8 +55,6 @@
libcrack2 (=${binary:Version}), cracklib-runtime
(=${binary:Version})
Provides: ${python:Provides}
-Conflicts: python-crack
-Replaces: python-crack
XB-Python-Version: ${python:Versions}
Description: Python bindings for password checker library cracklib2
This package provides Python bindings for cracklib. It contains a
signature.asc
Description: Digital signature
Bug#596364: unblock: cracklib2/2.8.16-3
On Sat, Sep 11, 2010 at 10:31:27PM +0200, Jan Dittberner wrote: I checked all Breaks, Provides and Conflicts statements in debian/control. They all refer to version prior to Lenny. The binary package python-crack was a transitional package in Lenny the other were even older. I think it is best to remove all the unnecessary Provides, Conflicts and Breaks. I think you need to retain the conflicts against python-crack then, because it should still get deinstalled on upgrades to squeeze. Kind regards, Philipp Kern signature.asc Description: Digital signature
Bug#596364: unblock: cracklib2/2.8.16-3
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package cracklib2
it includes a bugfix for RC bug #596281. A diff to the previous
version is attached.
unblock cracklib2/2.8.16-3
Regards
Jan Dittberner
--
Jan Dittberner - Debian Developer
GPG-key: 4096R/558FB8DD 2009-05-10
B2FF 1D95 CE8F 7A22 DF4C F09B A73E 0055 558F B8DD
http://ddportfolio.debian.net/ - http://people.debian.org/~jandd/
diff -Nru cracklib2-2.8.16/debian/changelog cracklib2-2.8.16/debian/changelog
--- cracklib2-2.8.16/debian/changelog 2010-05-13 11:59:02.0 +0200
+++ cracklib2-2.8.16/debian/changelog 2010-09-10 18:44:28.0 +0200
@@ -1,3 +1,19 @@
+cracklib2 (2.8.16-3) unstable; urgency=low
+
+ * debian/control: update to Standards-Version to 3.9.1
+- use Breaks instead of Conflicts for libcrack2's incompatibility with
+ cracklib2 ( 2.8.12-1) and libcrack2-dev's incompatibility with
+ cracklib2-dev ( 2.8.12-1)
+ * add debian/patches/596281-fix-python-extension-segfault.patch: in
+cracklib-python's C module, make sure we initialize defaultdict to
+NULL at the start of _cracklib_FascistCheck. This fixes a bug where
+that variable was freed when not NULL without ever having been
+assigned any value to. This happened when we called FascistCheck()
+with a dictionary path of our own. Thanks to Peter Palfrader for the
+patch (Closes: #596281).
+
+ -- Jan Dittberner ja...@debian.org Fri, 10 Sep 2010 18:44:23 +0200
+
cracklib2 (2.8.16-2) unstable; urgency=low
* fix bashism in debian/rules (Closes: #581479)
diff -Nru cracklib2-2.8.16/debian/control cracklib2-2.8.16/debian/control
--- cracklib2-2.8.16/debian/control 2010-05-13 11:59:02.0 +0200
+++ cracklib2-2.8.16/debian/control 2010-09-10 18:44:28.0 +0200
@@ -3,7 +3,7 @@
Priority: optional
Maintainer: Jan Dittberner ja...@debian.org
Uploaders: Martin Pitt mp...@debian.org
-Standards-Version: 3.8.4
+Standards-Version: 3.9.1
Build-Depends: debhelper (= 7.0.50), python-support (= 1.0.2),
python-all-dev, python-all, chrpath, xmlto, automake (= 1.10),
autoconf (=2.61), libtool, python-setuptools
@@ -16,7 +16,8 @@
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
Recommends: cracklib-runtime
-Conflicts: cracklib2.6, cracklib2 ( 2.8.12-1)
+Conflicts: cracklib2.6
+Breaks: cracklib2 ( 2.8.12-1)
Provides: cracklib2
Replaces: cracklib2.6, cracklib2 ( 2.8.12-1)
Description: pro-active password checker library
@@ -33,7 +34,8 @@
Depends: libcrack2 (=${binary:Version}), ${misc:Depends}
Recommends: cracklib-runtime
Provides: cracklib-dev, cracklib2-dev
-Conflicts: cracklib-dev, cracklib2-dev ( 2.8.12-1)
+Conflicts: cracklib-dev
+Breaks: cracklib2-dev ( 2.8.12-1)
Replaces: cracklib-dev, cracklib2-dev ( 2.8.12-1)
Description: pro-active password checker library - development files
Header files, static libraries, documentation, and symbolic links
diff -Nru cracklib2-2.8.16/debian/patches/596281-fix-python-extension-segfault.patch cracklib2-2.8.16/debian/patches/596281-fix-python-extension-segfault.patch
--- cracklib2-2.8.16/debian/patches/596281-fix-python-extension-segfault.patch 1970-01-01 01:00:00.0 +0100
+++ cracklib2-2.8.16/debian/patches/596281-fix-python-extension-segfault.patch 2010-09-10 18:44:28.0 +0200
@@ -0,0 +1,26 @@
+Subject: Fix for segmentation fault in the Python extension
+Author: Peter Palfrader wea...@debian.org
+Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=596281
+--- a/python/_cracklibmodule.c
b/python/_cracklibmodule.c
+@@ -64,7 +64,8 @@
+ static PyObject *
+ _cracklib_FascistCheck(PyObject *self, PyObject *args, PyObject *kwargs)
+ {
+-char *candidate, *dict, *defaultdict;
++char *candidate, *dict;
++char *defaultdict = NULL;
+ const char *result;
+ struct stat st;
+ char *keywords[] = {pw, dictpath, NULL};
+--- a/python/Makefile.am
b/python/Makefile.am
+@@ -1,7 +1,7 @@
+ if BUILD_PYTHON
+ python_PYTHON = cracklib.py
+ pyexec_LTLIBRARIES = _cracklibmodule.la
+-AM_CFLAGS = -I$(top_srcdir)/lib
++AM_CFLAGS = -I$(top_srcdir)/lib -Wall
+ _cracklibmodule_la_LDFLAGS = -module -avoid-version $(top_builddir)/lib/libcrack.la
+ DEFS += '-DDEFAULT_CRACKLIB_DICT=$(DEFAULT_CRACKLIB_DICT)'
+ DEFS += '-DPYTHON_H=pyt...@python_version@/Python.h'
diff -Nru cracklib2-2.8.16/debian/patches/series cracklib2-2.8.16/debian/patches/series
--- cracklib2-2.8.16/debian/patches/series 1970-01-01 01:00:00.0 +0100
+++ cracklib2-2.8.16/debian/patches/series 2010-09-10 18:44:28.0 +0200
@@ -0,0 +1 @@
+596281-fix-python-extension-segfault.patch
signature.asc
Description: Digital signature
