Bug#606258: unblock: distcc/3.1-3.2

2010-12-08 Thread Moritz Muehlenhoff 
On Tue, Dec 07, 2010 at 10:35:06PM +, Adam D. Barratt wrote:
 On Tue, 2010-12-07 at 22:25 +0100, Moritz Muehlenhoff wrote:
  Please unblock package distcc. It fixes another of the yet CVE-less
  PYTHONPATH issues.
 
 Looking at the diff, either the original code is more broken than the
 general case, or it's intentionally adding an empty entry to PYTHONPATH.
 It seems an odd choice, but part of me does wonder if it was
 intentional.
 
 -  PYTHONPATH='$pythonpath::$PYTHONPATH'  \
 +  PYTHONPATH='$pythonpath${PYTHONPATH:+:$PYTHONPATH}'  \

Adding the NMUer and the maintainer to CC.

Cheers,
Moritz



-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20101208183201.ga2...@galadriel.inutil.org

Bug#606258: unblock: distcc/3.1-3.2

2010-12-08 Thread Steve M. Robbins 
Hi,

On Wed, Dec 08, 2010 at 07:32:01PM +0100, Moritz Muehlenhoff wrote:
 On Tue, Dec 07, 2010 at 10:35:06PM +, Adam D. Barratt wrote:

  Looking at the diff, either the original code is more broken than the
  general case, or it's intentionally adding an empty entry to PYTHONPATH.
  It seems an odd choice, but part of me does wonder if it was
  intentional.
  
  -  PYTHONPATH='$pythonpath::$PYTHONPATH'  \
  +  PYTHONPATH='$pythonpath${PYTHONPATH:+:$PYTHONPATH}'  \
 
 Adding the NMUer and the maintainer to CC.

I did the NMU.  I simply assumed the original code is in error: I
can't imagine why the script would want the current dir in the
PYTHONPATH.

Regards,
-Steve


signature.asc
Description: Digital signature

Bug#606258: unblock: distcc/3.1-3.2

2010-12-07 Thread Moritz Muehlenhoff 
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package distcc. It fixes another of the yet CVE-less
PYTHONPATH issues.

unblock distcc/3.1-3.2

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-686 (SMP w/1 CPU core)
Locale: LANG=C, lc_ctype=de_de.iso-8859...@euro (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash



-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/20101207212528.6504.84287.report...@localhost.localdomain

Bug#606258: unblock: distcc/3.1-3.2

2010-12-07 Thread Adam D. Barratt 
On Tue, 2010-12-07 at 22:25 +0100, Moritz Muehlenhoff wrote:
 Please unblock package distcc. It fixes another of the yet CVE-less
 PYTHONPATH issues.

Looking at the diff, either the original code is more broken than the
general case, or it's intentionally adding an empty entry to PYTHONPATH.
It seems an odd choice, but part of me does wonder if it was
intentional.

-  PYTHONPATH='$pythonpath::$PYTHONPATH'  \
+  PYTHONPATH='$pythonpath${PYTHONPATH:+:$PYTHONPATH}'  \

Regards,

Adam




-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1291761306.4384.479.ca...@hathi.jungle.funky-badger.org