Bug#685456: Freeze exception for kde-gtk-config
Le dimanche, 26 août 2012 13.02:04, Boris Pek a écrit : we would normally not accept new packages into testing, but that one seems a bit special. If I parse it properly, it was previously available in squeeze, from the src:gtk-qt-engine package, but it has now moved to a dedicated source package? Yes, binary package kde-config-gtk-style in Squeeze was built from source package kcm-gtk. Wrong. It was built from source package gtk-qt-engine indeed. kcm-gtk was introduced in unstable later as the result of the split of gtk-qt-engine by Ubuntu and didn't introduce code changes. This new kde-gtk-config is a rewrite of kcm-gtk for GTK3 and takes over where kcm-gtk was left (no updates, no plan to support GTK3). And package src:kde-gtk-config is not new. It was uploaded to unstable before freeze. But new bug report prevented its automatic migration to testing. Yes. This created a new problem though: as kde-gtk-config replaced kcm-gtk's binaries (on purpose), kcm-gtk also got removed from Wheezy, breaking the upgrade path of gtk-qt-engine from Squeeze. IMHO, one of kcm-gtk or kde-gtk- config has to enter Wheezy to permit an upgrade path for this tool. Anyway, get back to us once the package is no longer RC buggy. But I can't upload package into unstable until this is not allowed by release team. Don't you think this is a closed circle? Given the current situation (and sorry for the time it took), I will review and upload 2.1-1 to fix the remaining RC bug really soon now. OdyX -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201209050820.29186.o...@debian.org
Bug#685456: Freeze exception for kde-gtk-config
X-Debbugs-Cc: Didier Raboud o...@debian.org Hi, Thank you for a reply. we would normally not accept new packages into testing, but that one seems a bit special. If I parse it properly, it was previously available in squeeze, from the src:gtk-qt-engine package, but it has now moved to a dedicated source package? Yes, binary package kde-config-gtk-style in Squeeze was built from source package kcm-gtk. But it was replaced by new program with more features. (For example, it supports Gtk 3.x.) And package src:kde-gtk-config is not new. It was uploaded to unstable before freeze. But new bug report prevented its automatic migration to testing. I subscribe my sponsor to this thread. Hope he can describe situation better. BTW, it would have been nice to mention the previous discussion in your bug report. Apparently Julien and I share the same opinion on this package: https://lists.debian.org/debian-release/2012/07/msg00679.html Yes, I have seen this reply. Quotation: Anyway, get back to us once the package is no longer RC buggy. But I can't upload package into unstable until this is not allowed by release team. Don't you think this is a closed circle? Best regards, Boris -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1388561345978...@web1f.yandex.ru
Bug#685456: Freeze exception for kde-gtk-config
reopen 685456 thanks Cyril Brulebois k...@debian.org (26/08/2012): we would normally not accept new packages into testing, but that one seems a bit special. If I parse it properly, it was previously available in squeeze, from the src:gtk-qt-engine package, but it has now moved to a dedicated source package? Oops. I initially meant to close this bug report but failed to edit the “To:” line after having digged a bit more. BTW, it would have been nice to mention the previous discussion in your bug report. Apparently Julien and I share the same opinion on this package: https://lists.debian.org/debian-release/2012/07/msg00679.html Need to think about it/sleep anyway. Mraw, KiBi. signature.asc Description: Digital signature
Processed: Re: Bug#685456: Freeze exception for kde-gtk-config
Processing commands for cont...@bugs.debian.org:
reopen 685456
Bug #685456 {Done: Cyril Brulebois k...@debian.org} [release.debian.org]
Freeze exception for kde-gtk-config
Bug reopened
Ignoring request to alter fixed versions of bug #685456 to the same values
previously set
thanks
Stopping processing here.
Please contact me if you need assistance.
--
685456: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=685456
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/handler.s.c.134594694431218.transcr...@bugs.debian.org
Bug#685456: Freeze exception for kde-gtk-config
Package: release.debian.org
Severity: normal
Dear release team,
Please consider a release exception for the package kde-gtk-config version
2.1-1.
In new upstream release only translations files were updated and one tiny patch
from debian package was accepted.
This upload fixes RC bug #678714 which had prevented automatic migration to
testing before freeze.
File in attachment was produced using command:
$ debdiff kde-gtk-config_2.0-3.dsc kde-gtk-config_2.1-1.dsc | \
filterdiff -x '*/po/*' -x '*.desktop' kde-gtk-config_2.0-3:2.1-1.diff
Best regards,
Boris
diff -Nru kde-gtk-config-2.0/debian/changelog kde-gtk-config-2.1/debian/changelog
--- kde-gtk-config-2.0/debian/changelog 2012-06-08 07:07:18.0 +0300
+++ kde-gtk-config-2.1/debian/changelog 2012-08-21 00:26:50.0 +0300
@@ -1,3 +1,16 @@
+kde-gtk-config (3:2.1-1) unstable; urgency=low
+
+ * Update to stable release 2.1.
+ * Deleted file debian/patches/fix-build-on-kfreebsd-and-hurd-i386:
+accepted in upstream.
+ * Added file debian/patches/fix-loading-icons:
+without this patch KDE-GTK-Config module scans ./ directory if option
+gtk-icon-theme-name or option gtk-fallback-icon-theme is empty or invalid,
+now first element from the list of found icon themes is used.
+(Closes: #678714)
+
+ -- Boris Pek tehnic...@mail.ru Tue, 21 Aug 2012 00:22:23 +0300
+
kde-gtk-config (3:2.0-3) unstable; urgency=low
* Package moved to unstable after tests: no changes required.
diff -Nru kde-gtk-config-2.0/debian/patches/fix-build-on-kfreebsd-and-hurd-i386 kde-gtk-config-2.1/debian/patches/fix-build-on-kfreebsd-and-hurd-i386
--- kde-gtk-config-2.0/debian/patches/fix-build-on-kfreebsd-and-hurd-i386 2012-06-08 07:06:49.0 +0300
+++ kde-gtk-config-2.1/debian/patches/fix-build-on-kfreebsd-and-hurd-i386 1970-01-01 03:00:00.0 +0300
@@ -1,15 +0,0 @@
-Description: Fix build in Debian GNU/kFreeBSD and in Debian GNU/Hurd
-Author: Boris Pek tehnic...@mail.ru
-Last-Update: 2012-06-06
-
a/gtk3proxies/preview3.c
-+++ b/gtk3proxies/preview3.c
-@@ -24,8 +24,6 @@
- #include stdio.h
- #include assert.h
- #include stdlib.h
--
--#include sys/inotify.h
- #include string.h
-
- void printHelp()
diff -Nru kde-gtk-config-2.0/debian/patches/fix-loading-icons kde-gtk-config-2.1/debian/patches/fix-loading-icons
--- kde-gtk-config-2.0/debian/patches/fix-loading-icons 1970-01-01 03:00:00.0 +0300
+++ kde-gtk-config-2.1/debian/patches/fix-loading-icons 2012-08-21 00:26:50.0 +0300
@@ -0,0 +1,51 @@
+Description: Fix loading icons
+ Without this patch KDE-GTK-Config module scans ./ directory if option
+ gtk-icon-theme-name or option gtk-fallback-icon-theme is empty or invalid.
+ Now first element from the list of found icon themes is used.
+Bug-Debian: http://bugs.debian.org/678714
+Author: Boris Pek tehnic...@mail.ru
+Last-Update: 2012-08-21
+
+--- a/src/gtkconfigkcmodule.cpp
b/src/gtkconfigkcmodule.cpp
+@@ -200,7 +200,9 @@
+ {
+ label-setToolTip(iconName);
+
+-QString ret = IconThemesModel::findFilesRecursively(QStringList(iconName+.*), theme);
++QString ret;
++if(!theme.isEmpty())
++ret = IconThemesModel::findFilesRecursively(QStringList(iconName+.*), theme);
+ if(!ret.isEmpty()) {
+ QPixmap p(ret);
+ Q_ASSERT(!p.isNull());
+@@ -208,7 +210,9 @@
+ return;
+ }
+
+-ret = IconThemesModel::findFilesRecursively(QStringList(iconName+.*), fallback);
++if(!fallback.isEmpty())
++ret = IconThemesModel::findFilesRecursively(QStringList(iconName+.*), fallback);
++
+ if(!ret.isEmpty()) {
+ QPixmap p(ret);
+ Q_ASSERT(!p.isNull());
+@@ -401,10 +401,14 @@
+ appareance-gtk3Appearance()-installedThemesNames());
+
+ //icons
+-QString currentIcon = useConfig ? appareance-getIcon() : ui-cb_icon-currentText(),
+-currentFallback = useConfig ? appareance-getIconFallback() : ui-cb_icon_fallback-currentText();
+-ui-cb_icon-setCurrentIndex(ui-cb_icon-findData(currentIcon, IconThemesModel::DirNameRole));
+-ui-cb_icon_fallback-setCurrentIndex(ui-cb_icon_fallback-findData(currentFallback, IconThemesModel::DirNameRole));
++if (ui-cb_icon-count() 0 ui-cb_icon_fallback-count() 0) {
++QString currentIcon = useConfig ? appareance-getIcon() : ui-cb_icon-currentText(),
++currentFallback = useConfig ? appareance-getIconFallback() : ui-cb_icon_fallback-currentText();
++int currentIconIndex = ui-cb_icon-findData(currentIcon, IconThemesModel::DirNameRole),
++currentFallbackIndex = ui-cb_icon_fallback-findData(currentFallback, IconThemesModel::DirNameRole);
++ui-cb_icon-setCurrentIndex(currentIconIndex = 0 ? currentFallbackIndex : 0);
++ui-cb_icon_fallback-setCurrentIndex(currentFallbackIndex = 0 ? currentFallbackIndex : 0);
++}
+
+ m_saveEnabled = wasenabled;
+ }
diff -Nru kde-gtk-config-2.0/debian/patches/series
