Bug#685929: unblock: torcs/1.3.3+dfsg-0.1

2012-08-26 Thread David Prévot
Subject: unblock: torcs/1.3.3+dfsg-0.1
Package: release.debian.org
User: release.debian@packages.debian.org
Usertags: unblock
Severity: normal
X-Debbugs-CC: Rudy Godoy r...@stone-head.org

Please unblock package torcs

It fixes an RC-bug (#685144) by simply removing the useless windows
directory from the source package (and the useless CVS directories as
advised by Ansgar in the bug report, that were causing FTBFS issue anyway).

It also fixes another FTBFS RC-bug (#684845) by protecting the files
automatically changed during the build process.

The torcs_unstable.diff (with --exclude windows --exclude CVS) shows
only those changes.

As previously asked in the “torcs and torcs-data-*” thread I'm replying
to, the maintainer prepared some other fixes in unstable, mostly
documentation related, and a detail in rules already almost accepted by
Adam (I hope I read you correctly on this one, apologies if I didn't).
The full torcs_testing.diff (with --exclude windows --exclude CVS) show
the actual differences from testing.

Thanks in Advance.

Regards

David

unblock torcs/1.3.3+dfsg-0.1


P.-S.: copy of 1343243139.495.30.ca...@jacala.jungle.funky-badger.org
in case my “Reply-to” is broken.

Le 25/07/2012 15:05, Adam D. Barratt a écrit :
 On Wed, 2012-07-25 at 07:25 -0500, Rudy Godoy wrote:
 On Mon, Jul 23, 2012 at 07:59:08PM +0100, Adam D. Barratt wrote:
 On Mon, 2012-07-23 at 12:29 -0500, Rudy Godoy wrote:
 So, in that case I'd like you to let pass rev. 6 (1.3.3-6)
 packages from sid.

 You're supposed to provide a rationale, not just say oh, go on,
 please. ;-p

 From a quick look at the diff from the version in testing, lintian fixes
 generally don't qualify for unblocks, nor does a complete rewrite of the
 copyright file in to DEP-5 format.

 I guess one could claim that some of the changes are documentation
 updates, but that's certainly stretching it for the copyright file.

 Basically, the DEP-5 involved primarily more detailed licensing terms
 for the game's artwork. Which was not included in the past.
 
From an unblock / review perspective, it would have been more helpful to
 have simply added those to the existing file. :-(
 
 Few
 things remain to clean-up for some data files, I might need to
 contact designers/authors for that.
 
 Is there an ETA for having that sorted out?
 
 Second, with the new packaging layout I also created an VCs repo
 under the pkg-games umbrella, so that we are able to maintain
 and support on stable releases.
 
 That's already been in testing since May, so isn't really an argument
 for an unblock. ;-p
[…]
 As I indicated at the time, I'd still
 appreciate the first being answered.
 
 Regards,
 
 Adam
 
 

diffstat for torcs-1.3.3 torcs-1.3.3+dfsg

 README.Debian-source |   12 
 changelog|   11 +++
 rules|   10 ++
 3 files changed, 33 insertions(+)

diff -Nru --exclude windows --exclude CVS torcs-1.3.3/debian/changelog torcs-1.3.3+dfsg/debian/changelog
--- torcs-1.3.3/debian/changelog	2012-07-05 11:42:03.0 -0400
+++ torcs-1.3.3+dfsg/debian/changelog	2012-08-24 01:10:15.0 -0400
@@ -1,3 +1,14 @@
+torcs (1.3.3+dfsg-0.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Repack source, removing src/windows including libraries for Win32 in
+binary form only, and useless CVS directories. (Closes: #685144)
+  * debian/rules: protect automatically modified files during the source
+building, restore them at the end of the process, and remove other extra
+files during the clean target. (Closes: #684845)
+
+ -- David Prévot taf...@debian.org  Fri, 24 Aug 2012 01:08:42 -0400
+
 torcs (1.3.3-6) unstable; urgency=low
 
   * Resolved Lintian warnings
diff -Nru --exclude windows --exclude CVS torcs-1.3.3/debian/README.Debian-source torcs-1.3.3+dfsg/debian/README.Debian-source
--- torcs-1.3.3/debian/README.Debian-source	2012-07-05 11:42:03.0 -0400
+++ torcs-1.3.3+dfsg/debian/README.Debian-source	2012-08-23 22:32:29.0 -0400
@@ -1,3 +1,15 @@
+torcs (1.3.3+dfsg-0.1) unstable; urgency=low
+
+  * Repack source package:
+ tar xaf torcs_1.3.3.orig.tar.bz2
+ find torcs-1.3.3 -type d -name CVS | xargs rm -r
+ rm -r torcs-1.3.3/src/windows
+ mv torcs-1.3.3 torcs-1.3.3+dfsg
+ tar -cf torcs_1.3.3+dfsg.orig.tar torcs-1.3.3+dfsg
+ xz torcs_1.3.3+dfsg.orig.tar
+
+ -- David Prévot taf...@debian.org  Thu, 23 Aug 2012 20:53:34 -0400
+
 torcs (1.3.3-2) unstable; urgency=low
 
   * Package building now uses upstream's all-in-one source package.
diff -Nru --exclude windows --exclude CVS torcs-1.3.3/debian/rules torcs-1.3.3+dfsg/debian/rules
--- torcs-1.3.3/debian/rules	2012-07-05 11:42:03.0 -0400
+++ torcs-1.3.3+dfsg/debian/rules	2012-08-24 00:52:07.0 -0400
@@ -30,6 +30,16 @@
 # remove VCS files present in source
 	find $(CURDIR) -type d -name CVS | xargs rm -rf
 	rm -f $(CURDIR)/debian/stamp*
+	mkdir debian/memory
+	cp Make-config config.h src/doc/torcsdoc.conf 

Bug#685929: unblock: torcs/1.3.3+dfsg-0.1

2012-08-26 Thread Adam D. Barratt

On 26.08.2012 17:47, David Prévot wrote:

Please unblock package torcs

It fixes an RC-bug (#685144) by simply removing the useless windows
directory from the source package (and the useless CVS directories as
advised by Ansgar in the bug report, that were causing FTBFS issue 
anyway).


It also fixes another FTBFS RC-bug (#684845) by protecting the files
automatically changed during the build process.

The torcs_unstable.diff (with --exclude windows --exclude CVS) shows
only those changes.

As previously asked in the “torcs and torcs-data-*” thread I'm 
replying

to, the maintainer prepared some other fixes in unstable, mostly
documentation related, and a detail in rules already almost accepted 
by
Adam (I hope I read you correctly on this one, apologies if I 
didn't).


Almost accepted, because I don't believe I ever actually received a 
response to:



 What's this change about?

 -build-predeb/torcs-data::
 +binary-predeb/torcs-data::


Regards,

Adam


--
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/f186ad5e795d230875a1eb74cc757...@mail.adsl.funky-badger.org



Bug#685929: unblock: torcs/1.3.3+dfsg-0.1

2012-08-26 Thread David Prévot
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hi Adam,

Le 26/08/2012 16:15, Adam D. Barratt a écrit :

 Almost accepted, because I don't believe I ever actually received a
 response to:
 
  What's this change about?
 
  -build-predeb/torcs-data::
  +binary-predeb/torcs-data::

It's just a typo fix. According to the maintainer's repository, it's
about cleaning a Lintian warning:

http://anonscm.debian.org/gitweb/?p=pkg-games/torcs.git;a=commitdiff;h=9ef10a7c0e6158c687922e70706b77fc2f930c2e

After rebuilding the package in the former version, I think I
understood: build-predeb was a typo (I don't know much about CDBS, but
the only occurrence on the web I was able to find, is the current
thread), so the following rule:

 # removing empty script until it's ready  
 
 rm -f debian/torcs-data/usr/share/games/torcs/telemetry/telemetry.sh 

was never called, and the empty script was shipped in torcs-data,
triggering the “script-not-executable” Lintian warning for torcs-data
about usr/share/games/torcs/telemetry/telemetry.sh.

Regards

David

P.-S.: Thanks a lot for your work in the release team, I don't bother to
spam you with a “thank you” each time you unblock, often in a very
timely manner, one package after I've submitted a bug, but yay!

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQOug7AAoJELgqIXr9/gnyYGsQAJH0/8rD7K1trE6KYmUQpsJK
RQ2vKePCKwPjTF4qx86rteUJ9fgWOpTGPh8wZw4oWSFfVzjFl0Gi0PUDX5MRaAfX
K7j4CT2EEhGdHpLo9NQ0dOqxF937QrngGTICo7FIrHtYH+2n+Qj3MjylvIgMR2Ul
8i80wM0+rVCCyB8orcJD8fEBW6C+vRpKJLeb9rAnai08ayM6lceYoBMxzPqFSX9o
17qhWzODmkfDB5rpq2xY2VxF2T+Z8/aTiI1Jd3KIWyh+d+sZTp05CUAFiRh2fgFx
v1M+ExPMyPm7vxOyhf/4Eq/SFxynnm3qlD5DOLzuj7RxlQev2HZbxzW6GNitN+0H
SSQgvkS11Q8/7+JJH2E2NrUhyRBnMwXxPzotlc3HCMXxHHd+0uW5bMLubEOZnpU2
Izk/xDn9KfaSe10xliKNbfYz9SmkmNUJIKV59LLna5kkfkVJJNJGe2fTaOp0g/Cq
cbA0tZQShCdcbLiXECSItu3wcZuUeZKKN/iMzNv296Zg1JU0E44/uwIrXSOm1IMq
POdCVGuLZvrbQSfHgnM7DNnN1mG1oLrgXWuwIauIFShcfO4G7mfsAlBk0GK+Zk+g
cyGUpeIGGR3yVpvVDHBRa3zVpaULmDMjCtu3YNhlUgqDmvaOguIaKOpFg7pgSdEw
9wtdQbNP26GfufoU9jzg
=Egp3
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/503ae83d.1050...@debian.org