Bug#687614: unblock: gdebi/0.8.6 (pre-approval)
gDebi has been uploaded some time ago, and nobody played Vodoo on me, so it seems it's behaving good ;) Please consider unblocking it. Other than the changes listed in the debdiff, I refreshed translations as anticipated in my first message. Thanks in advance! -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cadk7b0osjg1spt8bhbdvss43jsy59a6fmey7rxbtkxnuhen...@mail.gmail.com
Bug#687614: unblock: gdebi/0.8.6 (pre-approval)
tags 687614 - moreinfo thanks 2012/10/6 Niels Thykier ni...@thykier.net: In the 0.8.5 code, there are a couple of places where GDebiCli.install returns False on error[1], which I believe python translates to 0 leading to exit 0 with errors (and I suspect that is not what you wanted). Good catch! I'm attaching a new debdiff implementing a fix for the return value. 0.8.6.debdiff Description: Binary data
Bug#687614: unblock: gdebi/0.8.6 (pre-approval)
On 2012-10-11 21:08, Luca Falavigna wrote: tags 687614 - moreinfo thanks 2012/10/6 Niels Thykier ni...@thykier.net: In the 0.8.5 code, there are a couple of places where GDebiCli.install returns False on error[1], which I believe python translates to 0 leading to exit 0 with errors (and I suspect that is not what you wanted). Good catch! I'm attaching a new debdiff implementing a fix for the return value. Looks better. :) Feel free to go ahead. Please ping us when it has been in unstable for a couple of days. ~Niels -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/50771a1f.8060...@thykier.net
Processed: Re: Bug#687614: unblock: gdebi/0.8.6 (pre-approval)
Processing control commands: tags -1 moreinfo Bug #687614 [release.debian.org] unblock: gdebi/0.8.6 (pre-approval) Added tag(s) moreinfo. -- 687614: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=687614 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.b687614.13495224921976.transcr...@bugs.debian.org
Bug#687614: unblock: gdebi/0.8.6 (pre-approval)
Control: tags -1 moreinfo On 2012-09-14 11:31, Luca Falavigna wrote: Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Dear Release Team, I'd like to upload a new gdebi version in unstable fixing some bugs I recently triaged. They were reported on Launchpad, but most of them affect Debian too. Here's a description of the changes introduced since 0.8.5: [...] Other than those, I plan to include new translations in the package, I'm currently waiting for Launchpad to finalize them. I'm attaching a full debdiff (not including translations, at the moment) of the changes I'd like to introduce. Cheers, Luca The changes are mostly reasonable and I would be okay with them except the part where GDebiCli.py calls sys.exit(app.install())[0]. I had a brief look at the code and app.install() (being GDebiCli.install()) appears to return a mix of int and boolean. Like @@ -141,9 +141,7 @@ #os.system(gdebi %s_%s_*.deb % (...)) pass else: -ret = call([dpkg,...]) -if (ret != 0): -return False +return call([dpkg,...]) ^^^ (ret != 0 suggests int) vvv (clearly boolean) return True In the 0.8.5 code, there are a couple of places where GDebiCli.install returns False on error[1], which I believe python translates to 0 leading to exit 0 with errors (and I suspect that is not what you wanted). ~Niels [0] Actually, this also appears in gdebi AFAICT (w. s/app/debi/). [1] I have marked the first two return False on error I noticed. def install(self): # install the dependecnies (install,remove,unauthenticated) = self._deb.required_changes if len(install) 0 or len(remove) 0: fprogress = apt.progress.text.AcquireProgress() iprogress = apt.progress.base.InstallProgress() try: res = self._cache.commit(fprogress,iprogress) except apt.cache.FetchFailedException, e: sys.stderr.write(_(Error during install: '%s') % e) return False except SystemError, e: sys.stderr.write(_(Error during install: '%s') % e) return False [...] -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/50701432.5080...@thykier.net
Bug#687614: unblock: gdebi/0.8.6 (pre-approval)
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Dear Release Team, I'd like to upload a new gdebi version in unstable fixing some bugs I recently triaged. They were reported on Launchpad, but most of them affect Debian too. Here's a description of the changes introduced since 0.8.5: * Add xz-utils to gdebi Suggests field (fixing #685193) http://bazaar.launchpad.net/~gdebi-developers/gdebi/trunk/revision/421 * Handle ValueError exception to fix a crash with malformed packages http://bazaar.launchpad.net/~gdebi-developers/gdebi/trunk/revision/422 * Convert help options with unicode, fix crash displaying help in some locales http://bazaar.launchpad.net/~gdebi-developers/gdebi/trunk/revision/423 * Return dpkg error code instead of always return 0 http://bazaar.launchpad.net/~gdebi-developers/gdebi/trunk/revision/424 * Fix translation string which caused a crash due to unmatched format string http://bazaar.launchpad.net/~gdebi-developers/gdebi/trunk/revision/425 * Port to new GIO API to fix a crash when accessing packages on GVFS mounts http://bazaar.launchpad.net/~gdebi-developers/gdebi/trunk/revision/426 * Fall-back on kdesu if kdesudo is not avaliable, this is a no-op for Debian, but makes gdebi-kde almost useless in Ubuntu, and I'd like to sync package there http://bazaar.launchpad.net/~gdebi-developers/gdebi/trunk/revision/427 * Mark menu and labels as sensitive at startup, this causes a visual glitch http://bazaar.launchpad.net/~gdebi-developers/gdebi/trunk/revision/428 Other than those, I plan to include new translations in the package, I'm currently waiting for Launchpad to finalize them. I'm attaching a full debdiff (not including translations, at the moment) of the changes I'd like to introduce. Cheers, Luca 0.8.6.debdiff Description: Binary data
