Hi Julien, hi Laszlo,
Probably not of much help, maybe for deciding, but I stumbled over
this looking at current issues for wheezy:
On Sun, Nov 25, 2012 at 09:52:03PM +0100, Julien Cristau wrote:
On Sun, Nov 25, 2012 at 15:10:15 +0100, Laszlo Kajan wrote:
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package src:rgl
Dear Release Team!
This is Laszlo from BSP Munich addressing bug #684810.
Maintainer of rgl would have liked to have the fixed version
(rgl/0.92.892-1) or the current (0.92.894-1) in unstable unblocked, but has
forgotten to send the unblock request.
The changes are quite extensive (diffs are attached for both versions), but
the maintainer says that 'Just push the updated package. These interfaces
are stable -- the rgl package only does one thing -- and there should not
be side effect.'
I have prepared a fix that addresses the bug (and does no more) - diff
attached.
I see no versioned = == dependency on r-cran-rgl (binary pack build
from rgl).
Please tell us: which diff should we - if any - turn into an upload to
testing-proposed-updates?
rgl_0.92.798-1_0.92.798-1+deb7u1.diff
rgl_0.92.798-1_0.92.892-1.diff
rgl_0.92.798-1_0.92.894-1.diff
Only the first of those might be acceptable. Although the addition of
debian/compat makes me kind of suspicious, as does the lintian override.
Also, please don't send insanely big diffs by mail, otherwise mails are
dropped by the list software (I was getting ready to remove this package
from testing when I was pointed at this bug).
I tried to rebuild the package prepared by Laszlo without the added
debian/compat, so resulting debdiff attached. At first glance it looks
okay to me.
The lintian override probably was added, as the embedded-library tag
is listed in the autorejects list for ftp-masters[1].
[1]: http://ftp-master.debian.org/static/lintian.tags
binary debdiff shows that a css file get's added to the rebuilded
package.
cut-cut-cut-cut-cut-cut-
debdiff binary-r-cran-rgl/r-cran-rgl_0.92.798-1_amd64.deb
r-cran-rgl_0.92.798-1+deb7u1_amd64.deb
[The following lists of changes regard files as different if they have
different names, permissions or owners.]
Files in second .deb but not in first
-
-rw-r--r-- root/root /usr/lib/R/site-library/rgl/html/R.css
Control files: lines which differ (wdiff format)
Depends: libc6 (= 2.2.5), libgcc1 (= 1:4.1.1), libgl1-mesa-glx | libgl1,
libglu1-mesa | libglu1, libpng12-0 (= 1.2.13-4), libstdc++6 (= [-4.1.1),-]
{+4.6),+} libx11-6, r-base-core (= 2.12.1)
Installed-Size: [-3224-] {+3146+}
Version: [-0.92.798-1-] {+0.92.798-1+deb7u1+}
cut-cut-cut-cut-cut-cut-
Maintainer replied also [2] that if this does not mesh with the rest
of
testing/stable, I'd say let us remove it.
[2]: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=684810#36
cut-cut-cut-cut-cut-cut-
$ dak rm -R -n -s testing rgl
Working... done.
Will remove the following packages from testing:
r-cran-rgl | 0.92.798-1 | amd64, armel, armhf, i386, ia64, kfreebsd-amd64,
kfreebsd-i386, mips, mipsel, powerpc, s390, s390x, sparc
rgl | 0.92.798-1 | source
Maintainer: Dirk Eddelbuettel e...@debian.org
--- Reason ---
--
Checking reverse dependencies...
# Broken Depends:
misc3d: r-cran-misc3d
rcmdr: r-cran-rcmdr
Dependency problem found.
cut-cut-cut-cut-cut-cut-
So if removal of rgl should happen, also some other packages needs to
be removed.
Regards,
Salvatore
diff -u rgl-0.92.798/debian/changelog rgl-0.92.798/debian/changelog
--- rgl-0.92.798/debian/changelog
+++ rgl-0.92.798/debian/changelog
@@ -1,3 +1,12 @@
+rgl (0.92.798-1+deb7u1) wheezy; urgency=low
+
+ * Non-maintainer upload.
+ * FTBFS: types.h:98:5: error: 'copy' was not declared in this scope, and no
+declarations were found by argument-dependent lookup at the point of
+instantiation [-fpermissive] (Closes: #684810).
+
+ -- Laszlo Kajan lka...@rostlab.org Sun, 25 Nov 2012 13:08:19 +
+
rgl (0.92.798-1) unstable; urgency=low
* New upstream release
only in patch2:
unchanged:
--- rgl-0.92.798.orig/src/types.h
+++ rgl-0.92.798/src/types.h
@@ -6,7 +6,7 @@
// C++ header file
// This file is part of RGL
//
-// $Id: types.h 494 2006-08-01 17:25:31Z dmurdoch $
+// $Id: types.h 880 2012-05-08 11:54:12Z murdoch $
#include cstring
@@ -80,6 +80,16 @@
};
//
+// mem copy
+//
+
+templateclass A, class B
+inline void copy(A* from, B* to, int size)
+{
+ memcpy( (void*) to, (const void*) from, size*sizeof(A) );
+ }
+
+//
// TEMPLATE
// ARRAY
//
@@
