Bug#782426: unblock: systemd/215-15
Hi Julien,
Am 13.04.2015 um 22:18 schrieb Julien Cristau:
On Mon, Apr 13, 2015 at 22:03:51 +0200, Michael Biebl wrote:
++static int manager_dispatch_ask_password_fd(sd_event_source *source,
++int fd, uint32_t revents, void
*userdata) {
++Manager *m = userdata;
++
++assert(m);
++
++flush_fd(fd);
++
++m-have_ask_password = have_ask_password();
++if (m-have_ask_password 0)
++/* Log error but continue. Negative have_ask_password
++ * is treated as unknown status. */
++log_error(Failed to list /run/systemd/ask-password: %s,
strerror(m-have_ask_password));
shouldn't that be strerror(-m-have_ask_password)?
I think you are right. Thanks for checking so carefully.
I notice, that this line was changed later on in commit c33b3297 to
log_error_errno(m-have_ask_password, Failed to list
/run/systemd/ask-password: %m);
That helper function does use inverted error numbers. So v219 is indeed
not affected by this.
In any case, CCed Zbigniew, the author of the patch, maybe he can comment.
Julien, do you want me to make a followup upload fixing that (pending
confirmation from Zbigniew)?
Michael
--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
Processed: Re: Bug#782426: unblock: systemd/215-15
Processing control commands: tag -1 confirmed Bug #782426 [release.debian.org] unblock: systemd/215-16 Added tag(s) confirmed. -- 782426: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=782426 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.b782426.142896076712850.transcr...@bugs.debian.org
Bug#782426: unblock: systemd/215-15
Control: retitle -1 unblock: systemd/215-16
Hi Julien,
Am 12.04.2015 um 10:43 schrieb Julien Cristau:
Control: tags -1 d-i
On Sat, Apr 11, 2015 at 13:40:57 +0100, Martin Pitt wrote:
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
systemd 215-15 hit unstable two days ago. There have been no new RC
bugs since 215-14, so for a change this is a polishing upload with
small and safe fixes for some corner cases. One was already
pre-approved.
So far there have been no regression reports, and these changes have
already been tested in experimental, Ubuntu, and upstream for a much
longer time, so I'm quite confident in them.
I attach the full debdiff between 215-14 and -15, but as usual I also
link to the individual commits on anonscm.
Note that there are zero changes for udev-udeb (for d-i).
Looks ok to me, but still would like a d-i ack :)
I decided to make another upload today.
It includes 3 changes.
| [ Christian Seiler ]
| * Don't run hwclock-save.service in containers. (Closes: #782377)
http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=c22859a6897e9d6e5483bd0164b687875442f10a
The hwclock-save.service is a recent addition and this is an obvious
one-line fix. Didn't see a good reason to not include it even though it
doesn't qualify as release critical.
| [ Michael Biebl ]
| * Do not print anything while passwords are being queried. This
should make
|password prompts without plymouth more usable. (Closes: #765013)
http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=12483a05fe541014d5eee3f5b03072c51ad7c584
This is a cherry-pick of an upstream commit which has been part of v219,
thus seen fairly extensive testing in experimental and ubuntu.
It suppresses output while a password query is running. As we don't
install plymouth by default, I think this is a rather important fix to
get into jessie, since it makes those password prompts decently usable.
| * Skip filesystem check if already done by the initramfs. (Closes:
#782522)
http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=b5db1e5ab22a53e8e8a9facebdd2e08204cc8cf9
This is a followup for the recent changes in initramfs-tools, which now
provide flag files which we use to skip the fsck for / and /usr.
Since I expect systems with local time being not that uncommon, I'd like
to see this fix in jessie to avoid those Superblock time checks.
Complete debdiff between -15 and -16 is attached as well.
Baring any new RC bugs, this should hopefully be the final upload for
jessie.
Thanks for considering.
Michael
--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
diff --git a/debian/changelog b/debian/changelog
index 929502c..29ff5a3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,15 @@
+systemd (215-16) unstable; urgency=medium
+
+ [ Christian Seiler ]
+ * Don't run hwclock-save.service in containers. (Closes: #782377)
+
+ [ Michael Biebl ]
+ * Do not print anything while passwords are being queried. This should make
+password prompts without plymouth more usable. (Closes: #765013)
+ * Skip filesystem check if already done by the initramfs. (Closes: #782522)
+
+ -- Michael Biebl bi...@debian.org Mon, 13 Apr 2015 19:42:32 +0200
+
systemd (215-15) unstable; urgency=medium
[ Adam Conrad ]
diff --git a/debian/extra/hwclock-save.service
b/debian/extra/hwclock-save.service
index 1e0f99a..16fbade 100644
--- a/debian/extra/hwclock-save.service
+++ b/debian/extra/hwclock-save.service
@@ -5,6 +5,7 @@ Before=shutdown.target
ConditionFileIsExecutable=!/usr/sbin/ntpd
ConditionFileIsExecutable=!/usr/sbin/openntpd
ConditionFileIsExecutable=!/usr/sbin/chrony
+ConditionVirtualization=!container
[Service]
Type=oneshot
diff --git
a/debian/patches/Skip-filesystem-check-if-already-done-by-the-initram.patch
b/debian/patches/Skip-filesystem-check-if-already-done-by-the-initram.patch
new file mode 100644
index 000..70ab1ed
--- /dev/null
+++ b/debian/patches/Skip-filesystem-check-if-already-done-by-the-initram.patch
@@ -0,0 +1,44 @@
+From: Michael Biebl bi...@debian.org
+Date: Mon, 13 Apr 2015 19:34:23 +0200
+Subject: Skip filesystem check if already done by the initramfs
+
+Newer versions of initramfs-tools already fsck and mount / and /usr in
+the initramfs. Skip the filesystem check in this case.
+
+Closes: #782522
+---
+ src/fstab-generator/fstab-generator.c | 4 +++-
+ units/systemd-fsck-root.service.in| 1 +
+ 2 files changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/src/fstab-generator/fstab-generator.c
b/src/fstab-generator/fstab-generator.c
+index cb3d9dc..3323884 100644
+--- a/src/fstab-generator/fstab-generator.c
b/src/fstab-generator/fstab-generator.c
+@@ -163,11 +163,13 @@ static bool mount_is_network(struct mntent *me) {
+ }
+
+ static bool mount_in_initrd(struct mntent *me) {
++struct stat sb;
++
+
Processed: Re: Bug#782426: unblock: systemd/215-15
Processing control commands: retitle -1 unblock: systemd/215-16 Bug #782426 [release.debian.org] unblock: systemd/215-15 Changed Bug title to 'unblock: systemd/215-16' from 'unblock: systemd/215-15' -- 782426: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=782426 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.b782426.142895543611348.transcr...@bugs.debian.org
Bug#782426: unblock: systemd/215-15
On Mon, Apr 13, 2015 at 22:03:51 +0200, Michael Biebl wrote:
++static int manager_dispatch_ask_password_fd(sd_event_source *source,
++int fd, uint32_t revents, void
*userdata) {
++Manager *m = userdata;
++
++assert(m);
++
++flush_fd(fd);
++
++m-have_ask_password = have_ask_password();
++if (m-have_ask_password 0)
++/* Log error but continue. Negative have_ask_password
++ * is treated as unknown status. */
++log_error(Failed to list /run/systemd/ask-password: %s,
strerror(m-have_ask_password));
shouldn't that be strerror(-m-have_ask_password)?
Cheers,
Julien
++
++return 0;
++}
++
signature.asc
Description: Digital signature
Bug#782426: unblock: systemd/215-15
Control: tag -1 confirmed Julien Cristau jcris...@debian.org (2015-04-12): Control: tags -1 d-i On Sat, Apr 11, 2015 at 13:40:57 +0100, Martin Pitt wrote: Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock systemd 215-15 hit unstable two days ago. There have been no new RC bugs since 215-14, so for a change this is a polishing upload with small and safe fixes for some corner cases. One was already pre-approved. So far there have been no regression reports, and these changes have already been tested in experimental, Ubuntu, and upstream for a much longer time, so I'm quite confident in them. I attach the full debdiff between 215-14 and -15, but as usual I also link to the individual commits on anonscm. Note that there are zero changes for udev-udeb (for d-i). Looks ok to me, but still would like a d-i ack :) No objections, thanks. Mraw, KiBi. signature.asc Description: Digital signature
Bug#782426: unblock: systemd/215-15
On Mon, Apr 13, 2015 at 10:56:45PM +0200, Michael Biebl wrote:
Hi Julien,
Am 13.04.2015 um 22:18 schrieb Julien Cristau:
On Mon, Apr 13, 2015 at 22:03:51 +0200, Michael Biebl wrote:
++static int manager_dispatch_ask_password_fd(sd_event_source *source,
++int fd, uint32_t revents,
void *userdata) {
++Manager *m = userdata;
++
++assert(m);
++
++flush_fd(fd);
++
++m-have_ask_password = have_ask_password();
++if (m-have_ask_password 0)
++/* Log error but continue. Negative have_ask_password
++ * is treated as unknown status. */
++log_error(Failed to list /run/systemd/ask-password:
%s, strerror(m-have_ask_password));
shouldn't that be strerror(-m-have_ask_password)?
I think you are right. Thanks for checking so carefully.
I notice, that this line was changed later on in commit c33b3297 to
log_error_errno(m-have_ask_password, Failed to list
/run/systemd/ask-password: %m);
That helper function does use inverted error numbers. So v219 is indeed
not affected by this.
In any case, CCed Zbigniew, the author of the patch, maybe he can comment.
Yes, looks like a bug.
Julien, do you want me to make a followup upload fixing that (pending
confirmation from Zbigniew)?
Can you cc me on the patch so I can push it to -stable or push it yourself?
217-stable at least is affected.
Zbyszek
--
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20150414000911.gf25...@in.waw.pl
Bug#782426: unblock: systemd/215-15
Control: tags -1 d-i On Sat, Apr 11, 2015 at 13:40:57 +0100, Martin Pitt wrote: Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock systemd 215-15 hit unstable two days ago. There have been no new RC bugs since 215-14, so for a change this is a polishing upload with small and safe fixes for some corner cases. One was already pre-approved. So far there have been no regression reports, and these changes have already been tested in experimental, Ubuntu, and upstream for a much longer time, so I'm quite confident in them. I attach the full debdiff between 215-14 and -15, but as usual I also link to the individual commits on anonscm. Note that there are zero changes for udev-udeb (for d-i). Looks ok to me, but still would like a d-i ack :) Cheers, Julien signature.asc Description: Digital signature
Processed: Re: Bug#782426: unblock: systemd/215-15
Processing control commands: tags -1 d-i Bug #782426 [release.debian.org] unblock: systemd/215-15 Added tag(s) d-i. -- 782426: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=782426 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.b782426.142882820724271.transcr...@bugs.debian.org
Bug#782426: unblock: systemd/215-15
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
systemd 215-15 hit unstable two days ago. There have been no new RC
bugs since 215-14, so for a change this is a polishing upload with
small and safe fixes for some corner cases. One was already
pre-approved.
So far there have been no regression reports, and these changes have
already been tested in experimental, Ubuntu, and upstream for a much
longer time, so I'm quite confident in them.
I attach the full debdiff between 215-14 and -15, but as usual I also
link to the individual commits on anonscm.
Note that there are zero changes for udev-udeb (for d-i).
Annotated changelog:
|systemd (215-15) unstable; urgency=medium
|
| [ Adam Conrad ]
| * debian/systemd.{triggers,postinst}: Trigger a systemctl daemon-reload
|when init scripts are installed or removed (Closes: #766429)
http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=e32b9e9b8b
Adam got this pre-ack'ed by the release team already. This doesn't
actually affect any existing package in Jessie, but there were several
reports about I am packaging foo and stumbled over this. There might
also be some third-party packages which are affected by this. After
the update-rc.d fix in sysvinit for the same bug this really just
covers some small corner cases, but systemctl daemon-reload is
relatively cheap and quite safe (it's already called from update-rc.d,
invoke-rc.d, and various maintscripts).
| [ Martin Pitt ]
| * Fix getty restart loop when PTS device is gone. (Closes: #780711)
http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=72f6dc81
Backported from upstream, affects containers, simple declarative
change. No practical effect on real iron and VM installs as PTYs
don't just disappear there.
| * Run timesyncd in virtual machines. (Closes: #762343)
http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=3138dc8dc5
Backported from upstream, affects VMs only, simple declarative change.
No practical effect on real iron installs. Also, in jessie timesyncd
is *not* enabled by default anyway (only in experimental), so it does
not even affect default installs in VMs.
| * Make logind work in environments without CAP_SYS_ADMIN (mostly
|containers). Thanks Christian Seiler for the backporting!
|(Closes: #778608)
http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=50446f97
Backported from upstream. Affects containers only (i. e. makes
containers without CAP_SYS_ADMIN actually work). No practical effect
on real-iron and VMs as they do have CAP_SYS_ADMIN and this code
change only affects the fallback code paths in the error handling.
| * Check for correct signatures when setting properties. Fixes systemd
|getting stuck on trying to set invalid property types. (Closes: #781602)
http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=bf86d1
Backported from upstream. Affects all kinds of installations. I'd like
to get this in as without the type check it's very simple to send an
ill-typed D-Bus property set request to essentially wreck pid 1. The
code change is straightforward (just an additional type check).
| -- Martin Pitt mp...@debian.org Thu, 09 Apr 2015 10:12:37 +0200
Thanks for considering,
Martin
unblock systemd/215-15
--
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
diff --git a/debian/changelog b/debian/changelog
index b5ac97e..929502c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,20 @@
+systemd (215-15) unstable; urgency=medium
+
+ [ Adam Conrad ]
+ * debian/systemd.{triggers,postinst}: Trigger a systemctl daemon-reload
+when init scripts are installed or removed (Closes: #766429)
+
+ [ Martin Pitt ]
+ * Fix getty restart loop when PTS device is gone. (Closes: #780711)
+ * Run timesyncd in virtual machines. (Closes: #762343)
+ * Make logind work in environments without CAP_SYS_ADMIN (mostly
+containers). Thanks Christian Seiler for the backporting!
+(Closes: #778608)
+ * Check for correct signatures when setting properties. Fixes systemd
+getting stuck on trying to set invalid property types. (Closes: #781602)
+
+ -- Martin Pitt mp...@debian.org Thu, 09 Apr 2015 10:12:37 +0200
+
systemd (215-14) unstable; urgency=medium
[ Michael Biebl ]
diff --git
a/debian/patches/logind-handle-runtime-dir-without-CAP_SYS_ADMIN.patch
b/debian/patches/logind-handle-runtime-dir-without-CAP_SYS_ADMIN.patch
new file mode 100644
index 000..d5ab4ae
--- /dev/null
+++ b/debian/patches/logind-handle-runtime-dir-without-CAP_SYS_ADMIN.patch
@@ -0,0 +1,56 @@
+From: Christian Seiler christ...@iwakd.de
+Date: Wed, 8 Apr 2015 11:11:46 +0200
+Subject: logind: handle runtime dir without CAP_SYS_ADMIN
+
+In (e.g. LXC) containers without CAP_SYS_ADMIN, logind fails to mount
+a tmpfs over /run/user/$UID (lacking mount permissions).
+
+Now, logind
