Bug#802851: jessie-pu: package qpsmtpd/0.84-11
Control: tags -1 + pending On Wed, 2015-11-11 at 18:57 +, Adam D. Barratt wrote: > Control: tags -1 -moreinfo +confirmed > > On Wed, 2015-11-11 at 00:36 -0800, Devin Carraway wrote: > > On Sun, Oct 25, 2015 at 01:23:11PM +, Adam D. Barratt wrote: > > > > > While the proposed patch on its own looks fine, in order for us to give > > > an ack on the upload please prepare, build and test a package on jessie > > > - versioned as 0.84-11+deb8u1 rather than -12 - and send the source > > > debdiff to this bug report. > > > > Debdiff attached. > > diff -Nru qpsmtpd-0.84/debian/files qpsmtpd-0.84/debian/files > --- qpsmtpd-0.84/debian/files 1969-12-31 16:00:00.0 -0800 > +++ qpsmtpd-0.84/debian/files 2015-11-11 00:22:31.0 -0800 > @@ -0,0 +1 @@ > +qpsmtpd_0.84-11+deb8u1_all.deb mail extra > > That shouldn't really be ending up in the diff. > > Other than that, please go ahead; thanks. Uploaded and flagged for acceptance. Regards, Adam
Processed: Re: Bug#802851: jessie-pu: package qpsmtpd/0.84-11
Processing control commands: > tags -1 + pending Bug #802851 [release.debian.org] jessie-pu: package qpsmtpd/0.84-11 Added tag(s) pending. -- 802851: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=802851 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Re: Bug#802851: jessie-pu: package qpsmtpd/0.84-11
Processing control commands: > tags -1 -moreinfo +confirmed Bug #802851 [release.debian.org] jessie-pu: package qpsmtpd/0.84-11 Removed tag(s) moreinfo. Bug #802851 [release.debian.org] jessie-pu: package qpsmtpd/0.84-11 Added tag(s) confirmed. -- 802851: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=802851 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#802851: jessie-pu: package qpsmtpd/0.84-11
Control: tags -1 -moreinfo +confirmed On Wed, 2015-11-11 at 00:36 -0800, Devin Carraway wrote: > On Sun, Oct 25, 2015 at 01:23:11PM +, Adam D. Barratt wrote: > > > While the proposed patch on its own looks fine, in order for us to give > > an ack on the upload please prepare, build and test a package on jessie > > - versioned as 0.84-11+deb8u1 rather than -12 - and send the source > > debdiff to this bug report. > > Debdiff attached. diff -Nru qpsmtpd-0.84/debian/files qpsmtpd-0.84/debian/files --- qpsmtpd-0.84/debian/files 1969-12-31 16:00:00.0 -0800 +++ qpsmtpd-0.84/debian/files 2015-11-11 00:22:31.0 -0800 @@ -0,0 +1 @@ +qpsmtpd_0.84-11+deb8u1_all.deb mail extra That shouldn't really be ending up in the diff. Other than that, please go ahead; thanks. Regards, Adam
Bug#802851: jessie-pu: package qpsmtpd/0.84-11
On Sun, Oct 25, 2015 at 01:23:11PM +, Adam D. Barratt wrote:
> While the proposed patch on its own looks fine, in order for us to give
> an ack on the upload please prepare, build and test a package on jessie
> - versioned as 0.84-11+deb8u1 rather than -12 - and send the source
> debdiff to this bug report.
Debdiff attached.
--
Devin \ aqua(at)devin.com, IRC:Requiem; http://www.devin.com
Carraway \ 4096R/9197B5F9: 9C64 37CD 1B7B 029D 0933 49EA 1E52 7672 9197 B5F9
diff -Nru qpsmtpd-0.84/debian/changelog qpsmtpd-0.84/debian/changelog
--- qpsmtpd-0.84/debian/changelog 2013-08-13 00:39:07.0 -0700
+++ qpsmtpd-0.84/debian/changelog 2015-11-11 00:18:17.0 -0800
@@ -1,3 +1,11 @@
+qpsmtpd (0.84-11+deb8u1) stable; urgency=medium
+
+ * Patch for compatibility-breaker change in Net::DNS (Closes: #795836)
+ * Depend on libnet-dns-perl >= 0.81, since 0.66 from oldstable has the
+opposite compatibility problem
+
+ -- Devin Carraway Sat, 24 Oct 2015 07:27:50 +
+
qpsmtpd (0.84-11) unstable; urgency=low
* Add Japanese debconf translation; thanks to victory (Closes:
diff -Nru qpsmtpd-0.84/debian/control qpsmtpd-0.84/debian/control
--- qpsmtpd-0.84/debian/control 2013-07-01 19:28:34.0 -0700
+++ qpsmtpd-0.84/debian/control 2015-10-24 01:04:20.0 -0700
@@ -7,7 +7,7 @@
Package: qpsmtpd
Architecture: all
-Depends: ${misc:Depends}, ${perl:Depends}, debconf (>= 1.0.0), adduser (>=
3.0), libdigest-hmac-perl, libmail-spf-perl (>= 2.8.0), libnet-dns-perl,
libnet-perl, libmailtools-perl, libipc-shareable-perl, libclamav-client-perl,
libsocket6-perl, libio-socket-inet6-perl
+Depends: ${misc:Depends}, ${perl:Depends}, debconf (>= 1.0.0), adduser (>=
3.0), libdigest-hmac-perl, libmail-spf-perl (>= 2.8.0), libnet-dns-perl (>=
0.81), libnet-perl, libmailtools-perl, libipc-shareable-perl,
libclamav-client-perl, libsocket6-perl, libio-socket-inet6-perl
Suggests: spamassassin (>= 3.0.0), clamav-daemon, tinycdb
Homepage: http://smtpd.develooper.com/
Description: Flexible SMTP daemon for network-level spam detection
diff -Nru qpsmtpd-0.84/debian/files qpsmtpd-0.84/debian/files
--- qpsmtpd-0.84/debian/files 1969-12-31 16:00:00.0 -0800
+++ qpsmtpd-0.84/debian/files 2015-11-11 00:22:31.0 -0800
@@ -0,0 +1 @@
+qpsmtpd_0.84-11+deb8u1_all.deb mail extra
diff -Nru qpsmtpd-0.84/debian/patches/netdns_header_compat-bug795836.patch
qpsmtpd-0.84/debian/patches/netdns_header_compat-bug795836.patch
--- qpsmtpd-0.84/debian/patches/netdns_header_compat-bug795836.patch
1969-12-31 16:00:00.0 -0800
+++ qpsmtpd-0.84/debian/patches/netdns_header_compat-bug795836.patch
2015-10-24 00:25:59.0 -0700
@@ -0,0 +1,13 @@
+Index: qpsmtpd-0.84/qpsmtpd-forkserver
+===
+--- qpsmtpd-0.84.orig/qpsmtpd-forkserver 2015-10-24 05:35:24.0
+
qpsmtpd-0.84/qpsmtpd-forkserver2015-10-24 07:23:18.815328768 +
+@@ -281,7 +281,7 @@
+ # all children should have different seeds, to prevent conflicts
+ srand();
+ for (0 .. rand(65536)) {
+- Net::DNS::Header::nextid();
++ Net::DNS::Header::id();
+ }
+
+ close $_ for $select->handles;
diff -Nru qpsmtpd-0.84/debian/patches/series qpsmtpd-0.84/debian/patches/series
--- qpsmtpd-0.84/debian/patches/series 2013-07-01 19:21:52.0 -0700
+++ qpsmtpd-0.84/debian/patches/series 2015-10-24 00:23:00.0 -0700
@@ -2,3 +2,4 @@
spf_plugin-upstream-02912602842.patch
spf_plugin-bug693181.patch
ipv6_warnings-bug693179.patch
+netdns_header_compat-bug795836.patch
signature.asc
Description: Digital signature
Bug#802851: jessie-pu: package qpsmtpd/0.84-11
Control: tags -1 + moreinfo On Sat, 2015-10-24 at 01:53 -0700, Devin Carraway wrote: > I propose a patch to qpsmtpd in jessie-proposed-updates; this is a one-line > patch to address a compatibility breaking API change introduced in > libnet-dns-perl 0.81. The effect of the incompatibility causes qpsmtpd (an > SMTP daemon) to abruptly disconnect incoming SMTP sessions, breaking > functionality pretty much completely and justifying severity=grave (in the > context of a package with a few dozen installs on stable.) > > Proposed 0.84-12 updates a method name to the one in libnet-dns-perl_0.81 > from jessie, and bumps the Depends: accordingly. Thanks for looking at fixing this in jessie. While the proposed patch on its own looks fine, in order for us to give an ack on the upload please prepare, build and test a package on jessie - versioned as 0.84-11+deb8u1 rather than -12 - and send the source debdiff to this bug report. Regards, Adam
Processed: Re: Bug#802851: jessie-pu: package qpsmtpd/0.84-11
Processing control commands: > tags -1 + moreinfo Bug #802851 [release.debian.org] jessie-pu: package qpsmtpd/0.84-11 Added tag(s) moreinfo. -- 802851: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=802851 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#802851: jessie-pu: package qpsmtpd/0.84-11
Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian@packages.debian.org
Usertags: pu
I propose a patch to qpsmtpd in jessie-proposed-updates; this is a one-line
patch to address a compatibility breaking API change introduced in
libnet-dns-perl 0.81. The effect of the incompatibility causes qpsmtpd (an
SMTP daemon) to abruptly disconnect incoming SMTP sessions, breaking
functionality pretty much completely and justifying severity=grave (in the
context of a package with a few dozen installs on stable.)
Proposed 0.84-12 updates a method name to the one in libnet-dns-perl_0.81
from jessie, and bumps the Depends: accordingly.
This closes bug#795836 (originally tagged for wheezy, I believe erroneously; my
testing on a wheezy install and the version of libnet-dns-perl from that
release does not reproduce the behavior).
Proposed quilt patch attached.
-- System Information:
Debian Release: stretch/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armhf
Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Index: qpsmtpd-0.84/qpsmtpd-forkserver
===
--- qpsmtpd-0.84.orig/qpsmtpd-forkserver 2015-10-24 05:35:24.0 +
+++ qpsmtpd-0.84/qpsmtpd-forkserver 2015-10-24 07:23:18.815328768 +
@@ -281,7 +281,7 @@
# all children should have different seeds, to prevent conflicts
srand();
for (0 .. rand(65536)) {
- Net::DNS::Header::nextid();
+ Net::DNS::Header::id();
}
close $_ for $select->handles;
