Bug#894159: Bug#898542: qt4-x11: FTBFS with libicu60

2018-05-15 Thread Lisandro Damián Nicanor Pérez Meyer 
JFTR: I'm trying to get this done now.

Bug#894159: Bug#898542: qt4-x11: FTBFS with libicu60

2018-05-13 Thread Lisandro Damián Nicanor Pérez Meyer 
El dom., 13 de may. de 2018 10:51, John Paul Adrian Glaubitz <
glaub...@physik.fu-berlin.de> escribió:

> Control: tags 898542 +patch
>
> On 05/13/2018 03:35 PM, John Paul Adrian Glaubitz wrote:
> > openSUSE seems to have a patch [1] we can use that is also already used
> > in Fedora. I'll test it.
>
> Attaching openSUSE's patch which fixes the problem for me.


The patch looks good. I won't be able to put my hands on it at very least
until tomorrow... If I get to. So if you want to do a NMU please go ahead.

Bug#894159: Bug#898542: qt4-x11: FTBFS with libicu60

2018-05-13 Thread John Paul Adrian Glaubitz 

Control: tags 898542 +patch

On 05/13/2018 03:35 PM, John Paul Adrian Glaubitz wrote:

openSUSE seems to have a patch [1] we can use that is also already used
in Fedora. I'll test it.


Attaching openSUSE's patch which fixes the problem for me.

Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
From: Fabian Vogt 
Subject: Fix build with ICU >= 59

ICU >= 59 requires C++11 for its header files.
Qt can't be compiled with -std=c++11 as a whole, so only enable
it for qlocale_icu.cpp.

Index: qt-everywhere-opensource-src-4.8.7/src/corelib/tools/tools.pri
===
--- qt-everywhere-opensource-src-4.8.7.orig/src/corelib/tools/tools.pri
+++ qt-everywhere-opensource-src-4.8.7/src/corelib/tools/tools.pri
@@ -102,7 +102,15 @@ contains(QT_CONFIG, zlib):include($$PWD/
 else:include($$PWD/../../3rdparty/zlib_dependency.pri)
 
 contains(QT_CONFIG,icu) {
-SOURCES += tools/qlocale_icu.cpp
+cpp11.name = cpp11
+cpp11.input = SOURCES_CPP11
+cpp11.dependency_type = TYPE_C
+cpp11.variable_out = OBJECTS
+cpp11.output = ${QMAKE_VAR_OBJECTS_DIR}${QMAKE_FILE_IN_BASE}$${first(QMAKE_EXT_OBJ)}
+cpp11.commands = $${QMAKE_CXX} $(CXXFLAGS) -std=c++11 $(INCPATH) -c ${QMAKE_FILE_IN} -o ${QMAKE_FILE_OUT}
+QMAKE_EXTRA_COMPILERS += cpp11
+
+SOURCES_CPP11 += tools/qlocale_icu.cpp
 DEFINES += QT_USE_ICU
 }

Bug#894159: Bug#898542: qt4-x11: FTBFS with libicu60

2018-05-13 Thread John Paul Adrian Glaubitz 
On 05/13/2018 03:08 PM, Lisandro Damián Nicanor Pérez Meyer wrote:
> I have not checked if other distros ship a patch for this (or maybe
> they switched to the embedded copy, if applicable). I will at some
> point but I can't promise being fast here.

openSUSE seems to have a patch [1] we can use that is also already used
in Fedora. I'll test it.

Adrian

> [1] 
> https://build.opensuse.org/package/view_file/KDE:Qt/libqt4/fix-build-icu59.patch?expand=1

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Bug#894159: Bug#898542: qt4-x11: FTBFS with libicu60

2018-05-13 Thread Lisandro Damián Nicanor Pérez Meyer 
Hi John! This seems to be related to the icu transition, so CCing the bug.

On 13 May 2018 at 07:02, John Paul Adrian Glaubitz
 wrote:
> Source: qt4-x11
> Version: 4:4.8.7+dfsg-16
> Severity: serious
> Justification: fails to build from source
>
> Hi!
>
> qt4-x11 fails to build from source due to incompatible changes in libicu60:

Well unfortunately:

- No one seems to have checked this before starting the transition.
- qt4-x11 is dead upstream, so we do not have upstreams to try to get
a patch from.

I have not checked if other distros ship a patch for this (or maybe
they switched to the embedded copy, if applicable). I will at some
point but I can't promise being fast here.

So for a fast solution someone needs to come up with a patch I'm afraid.

Sorry for the bad news.

-- 
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/