Processed: Re: Bug#916650: stretch-pu: package liquidsoap/1.1.1-7.2
Processing control commands: > tags -1 -moreinfo +confirmed Bug #916650 [release.debian.org] stretch-pu: package liquidsoap/1.1.1-7.2 Removed tag(s) moreinfo. Bug #916650 [release.debian.org] stretch-pu: package liquidsoap/1.1.1-7.2 Added tag(s) confirmed. -- 916650: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916650 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#916650: stretch-pu: package liquidsoap/1.1.1-7.2
Control: tags -1 -moreinfo +confirmed On Sat, 2019-02-09 at 22:05 +0200, Kyle Robbertze wrote: > On 2019/02/09 16:08, Adam D. Barratt wrote: > > Control: tags -1 + moreinfo > > > > On Sun, 2018-12-16 at 23:58 +0200, Kyle Robbertze wrote: > > > The current liquidsoap package in stable segfaults imediately on > > > run. > > > Details are in bug #812591. The segfault is due to Ocaml version > > > 4.02 > > > which is present in stable. The fix upstream has been applied > > > here > > > (sourced from Ubuntu where it has been working since 17.10). It > > > is > > > part of the version currently in buster and unstable. > > > > Apologies for not getting back to you sooner. > > No worries, we all get busy :) Apparently so. *sigh* [...] > > If a package is incompatible with a newer version of Ocaml, is > > there no > > way of indicating this via e.g. dependency relationships, or the > > package somehow indicating which versions of Ocaml it is compatible > > with? This seems like the sort of thing that could also cause > > issues > > with partial upgrades between stable releases. > > With this fix, it is compatible with newer Ocaml versions and the new > version in buster and unstable are too. As far as I can tell, there > have > been no issues with newer versions outside of this. The common > convention seems to be to declare an un-versioned or minimum version > dependency on Ocaml and expect it to work with future versions. > OK, I guess we can go with this. Sorry for the delay (again). Regards, Adam
Bug#916650: stretch-pu: package liquidsoap/1.1.1-7.2
On 2019/02/09 16:08, Adam D. Barratt wrote: > Control: tags -1 + moreinfo > > On Sun, 2018-12-16 at 23:58 +0200, Kyle Robbertze wrote: >> The current liquidsoap package in stable segfaults imediately on run. >> Details are in bug #812591. The segfault is due to Ocaml version 4.02 >> which is present in stable. The fix upstream has been applied here >> (sourced from Ubuntu where it has been working since 17.10). It is >> part of the version currently in buster and unstable. > > Apologies for not getting back to you sooner. No worries, we all get busy :) > > I have to admit that I'm a little concerned that it took quite so long > for this bug to be fixed, given that it appears to have been reported > well before the stretch freeze. The package was abandoned for a long while, I have only just adopted it and fixed it up. > > If a package is incompatible with a newer version of Ocaml, is there no > way of indicating this via e.g. dependency relationships, or the > package somehow indicating which versions of Ocaml it is compatible > with? This seems like the sort of thing that could also cause issues > with partial upgrades between stable releases. With this fix, it is compatible with newer Ocaml versions and the new version in buster and unstable are too. As far as I can tell, there have been no issues with newer versions outside of this. The common convention seems to be to declare an un-versioned or minimum version dependency on Ocaml and expect it to work with future versions. Cheers Kyle signature.asc Description: OpenPGP digital signature
Processed: Re: Bug#916650: stretch-pu: package liquidsoap/1.1.1-7.2
Processing control commands: > tags -1 + moreinfo Bug #916650 [release.debian.org] stretch-pu: package liquidsoap/1.1.1-7.2 Added tag(s) moreinfo. -- 916650: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916650 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#916650: stretch-pu: package liquidsoap/1.1.1-7.2
Control: tags -1 + moreinfo On Sun, 2018-12-16 at 23:58 +0200, Kyle Robbertze wrote: > The current liquidsoap package in stable segfaults imediately on run. > Details are in bug #812591. The segfault is due to Ocaml version 4.02 > which is present in stable. The fix upstream has been applied here > (sourced from Ubuntu where it has been working since 17.10). It is > part of the version currently in buster and unstable. Apologies for not getting back to you sooner. I have to admit that I'm a little concerned that it took quite so long for this bug to be fixed, given that it appears to have been reported well before the stretch freeze. If a package is incompatible with a newer version of Ocaml, is there no way of indicating this via e.g. dependency relationships, or the package somehow indicating which versions of Ocaml it is compatible with? This seems like the sort of thing that could also cause issues with partial upgrades between stable releases. Regards, Adam
Bug#916650: stretch-pu: package liquidsoap/1.1.1-7.2
Package: release.debian.org Severity: normal Tags: stretch User: release.debian@packages.debian.org Usertags: pu The current liquidsoap package in stable segfaults imediately on run. Details are in bug #812591. The segfault is due to Ocaml version 4.02 which is present in stable. The fix upstream has been applied here (sourced from Ubuntu where it has been working since 17.10). It is part of the version currently in buster and unstable. I have tested it within a stable chroot (install and execution of simple scripts). Please accept the attached patch if possible. I have someone willing to sponsor the upload. -- System Information: Debian Release: buster/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.18.0-3-amd64 (SMP w/4 CPU cores) Locale: LANG=en_ZA.UTF-8, LC_CTYPE=en_ZA.UTF-8 (charmap=UTF-8), LANGUAGE=en_ZA:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled diff -Nru liquidsoap-1.1.1/debian/changelog liquidsoap-1.1.1/debian/changelog --- liquidsoap-1.1.1/debian/changelog 2016-11-29 21:37:34.0 + +++ liquidsoap-1.1.1/debian/changelog 2018-12-01 18:41:23.0 + @@ -1,3 +1,9 @@ +liquidsoap (1.1.1-7.2+deb9u1) stretch; urgency=medium + + * Fix compilation with Ocaml 4.02 (Closes: #812591) + * Added new uploader + + -- Kyle Robbertze Sat, 01 Dec 2018 20:41:23 +0200 + liquidsoap (1.1.1-7.2) unstable; urgency=medium * Non-maintainer upload. diff -Nru liquidsoap-1.1.1/debian/control liquidsoap-1.1.1/debian/control --- liquidsoap-1.1.1/debian/control 2016-11-29 21:35:41.0 + +++ liquidsoap-1.1.1/debian/control 2018-12-01 18:38:23.0 + @@ -3,6 +3,7 @@ Priority: optional Maintainer: Debian OCaml Maintainers Uploaders: + Kyle Robbertze , Romain Beauxis , Samuel Mimram Build-Depends: diff -Nru liquidsoap-1.1.1/debian/files liquidsoap-1.1.1/debian/files --- liquidsoap-1.1.1/debian/files 2016-11-29 21:37:34.0 + +++ liquidsoap-1.1.1/debian/files 1970-01-01 00:00:00.0 + @@ -1 +0,0 @@ -liquidsoap_1.1.1-7.2_source.buildinfo sound optional diff -Nru liquidsoap-1.1.1/debian/patches/bf0640779b2e7095e01755d3660c7e3f0865171d.patch liquidsoap-1.1.1/debian/patches/bf0640779b2e7095e01755d3660c7e3f0865171d.patch --- liquidsoap-1.1.1/debian/patches/bf0640779b2e7095e01755d3660c7e3f0865171d.patch 1970-01-01 00:00:00.0 + +++ liquidsoap-1.1.1/debian/patches/bf0640779b2e7095e01755d3660c7e3f0865171d.patch 2018-12-01 18:37:32.0 + @@ -0,0 +1,456 @@ +From bf0640779b2e7095e01755d3660c7e3f0865171d Mon Sep 17 00:00:00 2001 +From: Romain Beauxis +Date: Thu, 14 May 2015 14:38:40 -0500 +Subject: [PATCH] More stuff to compile with 3.12.1 -> 4.03.0 + +--- + src/Makefile | 2 +- + src/decoder/decoder.ml | 6 +-- + src/decoder/image_decoder.ml | 2 +- + src/decoder/ogg_decoder.ml | 2 +- + src/encoder/encoder.ml | 2 +- + src/encoder/taglib_id3v2.ml | 2 +- + src/lang/lang_builtins.ml| 8 ++-- + src/lang/lang_encoders.ml| 86 + src/lang/lang_pp.ml | 2 +- + src/lang/lang_types.ml | 2 +- + src/operators/frei0r_op.ml | 2 +- + src/operators/setvol.ml | 2 +- + src/outputs/harbor_output.camlp4 | 2 +- + src/outputs/harbor_output.ml | 6 +-- + src/outputs/icecast2.ml | 2 +- + src/playlists/playlist_basic.ml | 2 +- + src/protocols/mpd.ml | 2 +- + src/request.ml | 2 +- + src/stream/frame.ml | 2 +- + src/tools/harbor.camlp4 | 12 +++--- + src/tools/harbor.ml | 17 +--- + src/tools/http.ml| 8 ++-- + src/tools/plug.ml| 4 +- + src/tools/utils.ml | 60 ++-- + 24 files changed, 147 insertions(+), 90 deletions(-) + +Index: liquidsoap-1.1.1/src/Makefile +=== +--- liquidsoap-1.1.1.orig/src/Makefile liquidsoap-1.1.1/src/Makefile +@@ -173,7 +173,7 @@ $(call conditional_compilation,io,$(W_OS + $(call conditional_compilation,io,$(W_PULSEAUDIO),io/pulseaudio_io.ml) + $(call conditional_compilation,io,$(W_PORTAUDIO),io/portaudio_io.ml) + +-tools = tools/stdlib.ml tools/doc.ml tools/plug.ml tools/utils.ml \ ++tools = tools/stdlib.ml tools/doc.ml tools/utils.ml tools/plug.ml \ + $(if $(W_DYNLINK),tools/dyntools.ml) \ + tools/rqueue.ml \ + $(if $(W_LAME_DYN),tools/lame_dynlink.ml) \ +Index: liquidsoap-1.1.1/src/decoder/decoder.ml +=== +--- liquidsoap-1.1.1.orig/src/decoder/decoder.ml liquidsoap-1.1.1/src/decoder/decoder.ml +@@ -277,7 +277,7 @@ let get_image_file_decoder filename = + with + | Pervasives.Exit ->
