Bug#990939: unblock: newlisp/10.7.5-2

2021-07-17 Thread Sergio Durigan Junior
On Wednesday, July 14 2021, Paul Gevers wrote:

> On 11-07-2021 20:29, Sergio Durigan Junior wrote:
>>> Please unblock package newlisp
>
> unblocked.

Thanks, Paul.

>>> Depending on the -dev packages instead is not nice,
>>> but it is actually the fix with the smallest change.
>> 
>> I'm open to suggestions here.
>
> The original bug mentions:
> Use e.g. dpkg-shlibdeps/dh_shlibdeps for that. See option -d
> in dpkg-shlibdeps(1) for a hint on how to do that.

I don't know if the original bug was filed using a template or not, but
using dpkg-shlibdeps doesn't make sense in this case because the newlisp
binary doesn't link against the specified libraries.

Instead, the newlisp *scripts* (which are installed under
/usr/share/newlisp) contain explicit commands to make the newlisp
interpreter load the necessary libraries (via dlopen).

I can be really wrong here, but I don't see another way to tackle this
problem.  Either way, I don't want to hijack this thread either, but I
just thought I'd point this out.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/


signature.asc
Description: PGP signature


Bug#990939: unblock: newlisp/10.7.5-2

2021-07-11 Thread Sergio Durigan Junior
On Sunday, July 11 2021, Adrian Bunk wrote:

> Please unblock package newlisp
>
>   * d/p/0009-Fix-shared-library-loading-for-modules.patch:
> Adjust patch so that the modules don't try to load a versioned shared
> library.
>   * d/control: Don't recommend hardcoded ABI versions in library packages.
> We should recommend the '-dev' packages instead, which will install
> the proper .so files that will get loaded by the modules. (Closes: 
> #984686)
>   * d/p/0009-Set-NEWLISPDIR-to-usr-share-newlisp.patch:
> Inform newlisp that the common files are installed under
> /usr/share/newlisp, not /usr/local/share.
> (changes by Sergio Durigan Junior)

Thanks for request the unblock on this one.

> Depending on the -dev packages instead is not nice,
> but it is actually the fix with the smallest change.

I'm open to suggestions here.  A small correction: the package doesn't
depend on the -dev packages; it recommends them.

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/



Bug#990939: unblock: newlisp/10.7.5-2

2021-07-11 Thread Adrian Bunk
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package newlisp

  * d/p/0009-Fix-shared-library-loading-for-modules.patch:
Adjust patch so that the modules don't try to load a versioned shared
library.
  * d/control: Don't recommend hardcoded ABI versions in library packages.
We should recommend the '-dev' packages instead, which will install
the proper .so files that will get loaded by the modules. (Closes: #984686)
  * d/p/0009-Set-NEWLISPDIR-to-usr-share-newlisp.patch:
Inform newlisp that the common files are installed under
/usr/share/newlisp, not /usr/local/share.
(changes by Sergio Durigan Junior)


Recommending no longer existing shared libraries is bad,
even worse is trying to open them at runtime.

Depending on the -dev packages instead is not nice,
but it is actually the fix with the smallest change.

The NEWLISPDIR change looks correct to me.
diff -Nru newlisp-10.7.5/debian/changelog newlisp-10.7.5/debian/changelog
--- newlisp-10.7.5/debian/changelog 2019-07-21 02:47:33.0 +0300
+++ newlisp-10.7.5/debian/changelog 2021-03-07 22:17:34.0 +0200
@@ -1,3 +1,17 @@
+newlisp (10.7.5-2) unstable; urgency=medium
+
+  * d/p/0009-Fix-shared-library-loading-for-modules.patch:
+Adjust patch so that the modules don't try to load a versioned shared
+library.
+  * d/control: Don't recommend hardcoded ABI versions in library packages.
+We should recommend the '-dev' packages instead, which will install
+the proper .so files that will get loaded by the modules. (Closes: #984686)
+  * d/p/0009-Set-NEWLISPDIR-to-usr-share-newlisp.patch:
+Inform newlisp that the common files are installed under
+/usr/share/newlisp, not /usr/local/share.
+
+ -- Sergio Durigan Junior   Sun, 07 Mar 2021 15:17:34 
-0500
+
 newlisp (10.7.5-1) unstable; urgency=medium
 
   * New upstream version 10.7.5.
diff -Nru newlisp-10.7.5/debian/control newlisp-10.7.5/debian/control
--- newlisp-10.7.5/debian/control   2019-07-21 02:46:32.0 +0300
+++ newlisp-10.7.5/debian/control   2021-03-07 22:08:21.0 +0200
@@ -17,11 +17,11 @@
 Depends: ${shlibs:Depends}, ${misc:Depends}
 # For newLISP modules.
 Recommends:
- libcrypto++6,
- libmysqlclient18,
- libpq5,
- libsqlite3-0,
- zlib1g,
+ libssl-dev,
+ default-libmysqlclient-dev,
+ libpq-dev,
+ libsqlite3-dev,
+ zlib1g-dev,
  sensible-utils,
 Description: LISP like, general purpose scripting language
  newLISP is a scripting language for developing web applications and
diff -Nru 
newlisp-10.7.5/debian/patches/0009-Fix-shared-library-loading-for-modules.patch 
newlisp-10.7.5/debian/patches/0009-Fix-shared-library-loading-for-modules.patch
--- 
newlisp-10.7.5/debian/patches/0009-Fix-shared-library-loading-for-modules.patch 
2019-07-21 02:46:32.0 +0300
+++ 
newlisp-10.7.5/debian/patches/0009-Fix-shared-library-loading-for-modules.patch 
2021-03-07 22:16:26.0 +0200
@@ -22,7 +22,7 @@
  8 files changed, 9 insertions(+), 126 deletions(-)
 
 diff --git a/modules/crypto.lsp b/modules/crypto.lsp
-index 26d7bda..e52af3a 100644
+index 26d7bda..289a027 100644
 --- a/modules/crypto.lsp
 +++ b/modules/crypto.lsp
 @@ -41,28 +41,7 @@
@@ -51,7 +51,7 @@
 -  (throw-error "cannot find crypto library"
 -
 -(set 'option (if (= ostype "Windows") "cdecl"))
-+(set 'library "libcrypto.so.1")
++(set 'library "libcrypto.so")
  
  (import library "MD5" option)
  (import library "RIPEMD160" option)
@@ -85,7 +85,7 @@
  ; structs are defined but only needed for debugging, instead use "void*"
  (struct 'complex "double" "double") ; complex numbers
 diff --git a/modules/mysql.lsp b/modules/mysql.lsp
-index 05faded..bd93a21 100644
+index 05faded..20a6093 100644
 --- a/modules/mysql.lsp
 +++ b/modules/mysql.lsp
 @@ -118,20 +118,7 @@
@@ -106,7 +106,7 @@
 -(set 'library (files (or 
 - (find true (map file? files)) 
 - (throw-error "cannot find libmysqlclient library"
-+(set 'library "libmysqlclient.so.18")
++(set 'library "libmysqlclient.so")
  
  (import library "mysql_init")
  (import library "mysql_real_connect")
@@ -125,7 +125,7 @@
  ; Constants used, make sure these constants are Ok on your Operating System 
or Platform.
  ; Note, that (define var value) is the same as as saying (set 'var value), it 
is here more
 diff --git a/modules/postgres.lsp b/modules/postgres.lsp
-index 0fe5ec5..c620f92 100644
+index 0fe5ec5..5af0c6c 100644
 --- a/modules/postgres.lsp
 +++ b/modules/postgres.lsp
 @@ -128,34 +128,7 @@
@@ -160,7 +160,7 @@
 -(delete 'pg_config)
 -(delete 'pg_lib_dir)
 -(delete 'files)
-+(set 'library "libpq.so.5")
++(set 'library "libpq.so")
  
  ; import functions and throw error if not found
  (define (pg_import fun_name)
@@ -198,7 +198,7 @@
  (import library "sqlite3_open" "cdecl")
  (import library "sqlite3_close" "cdecl")
 diff --git a/modules/unix.lsp b/modules/unix.lsp