Re: Fix for bug #680814

2012-08-08 Thread Luca Falavigna
Thanks for the suggestions.
I changed the patch following your advices and uploaded a NMU to
DELAYED/2, patch attached.


680814.patch
Description: Binary data


Re: Fix for bug #680814

2012-08-06 Thread Julien Cristau
On Sun, Aug  5, 2012 at 22:43:50 +0200, Luca Falavigna wrote:

> tags 680814 + patch
> thanks
> 
> 
> This bug is reproducible only on systems without networking access.
> I'm attaching a patch which fixes the issue.
> 
> Hi Release Team,
> would you consider this patch acceptable for an unblock request?

NAK on the part that changes the xml files, that shouldn't be necessary.
ACK for the added build-dep.

Cheers,
Julien


signature.asc
Description: Digital signature


Re: Fix for bug #680814

2012-08-06 Thread Jakub Wilk

* Luca Falavigna , 2012-08-06, 08:40:

Ouch, wouldn't that break the validity of the XML files?


ACK, changing document declarations sounds like a bad idea.


Maybe using the --nonet option of xsltproc would be proper.


I just tried using --nonet, using different positions, but I always get
failed to load external entity
"http://www.oasis-open.org/docbook/xml/4.1.2/docbookx.dtd";


Do you have docbook-xml installed?

I tried building the package with added docbook-xml build-dependency 
(but no other changes), and it builds fine here without network 
connection.


--nonet is an extra safety belt, but it's not really necessary if you 
have all DTDs installed.


--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120806070638.ga3...@jwilk.net



Re: Fix for bug #680814

2012-08-05 Thread Luca Falavigna
2012/8/6 David Prévot :
> Ouch, wouldn't that break the validity of the XML files? Maybe using the
> --nonet option of xsltproc would be proper.

I just tried using --nonet, using different positions, but I always get
failed to load external entity
"http://www.oasis-open.org/docbook/xml/4.1.2/docbookx.dtd";


--
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/cadk7b0nx3dbd5e-doiduyc+uv2xalykaf9xretem23dmnu0...@mail.gmail.com



Re: Fix for bug #680814

2012-08-05 Thread David Prévot
Hi,

Le 05/08/2012 16:43, Luca Falavigna a écrit :

> This bug is reproducible only on systems without networking access.

[…]

> I'm attaching a patch which fixes the issue.

> +--- conduit-0.3.17~/help/C/conduit.xml   2010-01-28 23:31:07.0 
> +0100
>  conduit-0.3.17/help/C/conduit.xml2012-08-05 22:12:11.386464766 
> +0200
> +@@ -1,6 +1,6 @@
> + 
> +  +-"http://www.oasis-open.org/docbook/xml/4.1.2/docbookx.dtd"; [
> ++"/usr/share/sgml/docbook/dtd/4.1.2/docbookx.dtd" [

Ouch, wouldn't that break the validity of the XML files? Maybe using the
--nonet option of xsltproc would be proper.

Regards

David




signature.asc
Description: OpenPGP digital signature


Fix for bug #680814

2012-08-05 Thread Luca Falavigna
tags 680814 + patch
thanks


This bug is reproducible only on systems without networking access.
I'm attaching a patch which fixes the issue.

Hi Release Team,
would you consider this patch acceptable for an unblock request?


680814.patch
Description: Binary data