Re: Freeze exception: net6, obby, gobby
On Mon, Mar 12, 2007 at 11:05:21PM -0700, Steve Langasek wrote: Because on a simple rebuild, someone may be building against a different version of net6? I see. That's a general problem here, that's true. But at least the libraries aren't so much a moving target anymore. gobby changes: * Fix mime type mapping. * Lack of avahi-daemon now fails silently instead of a verbose message confusing the user. Zeroconf is a `nice to have' but in no means required. I don't see that a freeze exception is justified here. I see that you fear regressions. It's your decision of course, but I tried to keep the debdiff as tiny as possible to make it easier to review. Mmm, ok. Well, even if gobby isn't unblocked, it would be possible to fix the template lib bit (gah) with binNMUs in testing. I'll take another look at the gobby in unstable anyway, and let you know. Could you please also schedule a BinNMU on Sobby? This package does not need any source changes, just updated net6 and obby templates. Kind regards, Philipp Kern Debian Developer signature.asc Description: Digital signature
Re: Freeze exception: net6, obby, gobby
On Wed, Mar 14, 2007 at 10:51:46AM +0100, Philipp Kern wrote: On Mon, Mar 12, 2007 at 11:05:21PM -0700, Steve Langasek wrote: gobby changes: * Fix mime type mapping. * Lack of avahi-daemon now fails silently instead of a verbose message confusing the user. Zeroconf is a `nice to have' but in no means required. I don't see that a freeze exception is justified here. I see that you fear regressions. It's your decision of course, but I tried to keep the debdiff as tiny as possible to make it easier to review. Yeah. I've unblocked it now. Mmm, ok. Well, even if gobby isn't unblocked, it would be possible to fix the template lib bit (gah) with binNMUs in testing. I'll take another look at the gobby in unstable anyway, and let you know. Could you please also schedule a BinNMU on Sobby? This package does not need any source changes, just updated net6 and obby templates. Done. Thanks, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. [EMAIL PROTECTED] http://www.debian.org/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Freeze exception: net6, obby, gobby
Dear release team,
could you please grant net6, obby and gobby a freeze exception? The uploads
of net6 and obby allow Gobby to be used with kernels without IPv6
support (i.e. self-compiled ones or kernels provided by hosting facilities).
Furthermore invalid input on the connection (i.e. send by a hostile
server) does no longer cause an exception propagating to the
application, which did terminate Gobby.
The IPv6 patch added a new default parameter. Tests of mine shows that
it was ABI- and API-compatible, but I guess you judge that better than I
could.
The Gobby changes are fairly trivial, adopting the provided mime mapping
to the current one present in GtkSourceView (which is quite
inconsistent, but probably in line with mime.types). And there is a
more or less one line patch to remove a dialog window which pops up
when avahi-daemon is not started. This is not critical and just disables
one control in the application (it's then hidden, not greyed out).
net6 changes:
* Adopted dpatch.
- Fix IPv6 usage: Every application could now choose to use IPv6
on connect which enables them to retry without if the first
attempt fails due to missing kernel support.
- Errors caused by invalid data on the connection does propagate
as a seperate exception.
- Moved gettext compatibility patch into a seperate patch file.
* Bump versioned dependency in shlibs file.
obby changes:
* Adopt dpatch:
- Add a patch to retry IPv6 if it's unavailable.
gobby changes:
* Fix mime type mapping.
* Lack of avahi-daemon now fails silently instead of a verbose message
confusing the user. Zeroconf is a `nice to have' but in no means
required.
The debdiffs of all three packages are attached. net6 and obby were
uploaded on 2007-01-17, gobby today.
Kind regards,
Philipp Kern
Debian Developer
reverted:
--- net6-1.3.1/inc/gettext_package.hpp
+++ net6-1.3.1.orig/inc/gettext_package.hpp
@@ -22,13 +22,6 @@
#include string
#include non_copyable.hpp
-/* This is a bugfix specifically for Debian Sarge. It is included here as
- * a patch because it does no harm and fixes problems with backports to
- * that platform.
- */
-#undef gettext
-#undef ngettext
-
namespace net6
{
diff -u net6-1.3.1/debian/control net6-1.3.1/debian/control
--- net6-1.3.1/debian/control
+++ net6-1.3.1/debian/control
@@ -2,8 +2,8 @@
Section: net
Priority: optional
Maintainer: Philipp Kern [EMAIL PROTECTED]
-Build-Depends: debhelper (= 5.0.0), libtool, autotools-dev, libsigc++-2.0-dev
(= 2.0.16-2), libgnutls-dev
-Standards-Version: 3.6.2
+Build-Depends: debhelper (= 5.0.0), dpatch (= 2.0.0), libtool,
autotools-dev, libsigc++-2.0-dev (= 2.0.16-2), libgnutls-dev
+Standards-Version: 3.7.2
Package: libnet6-1.3-dev
Section: libdevel
diff -u net6-1.3.1/debian/rules net6-1.3.1/debian/rules
--- net6-1.3.1/debian/rules
+++ net6-1.3.1/debian/rules
@@ -1,4 +1,5 @@
#!/usr/bin/make -f
+#!/usr/bin/make -f
# -*- makefile -*-
# Uncomment this to turn on verbose mode.
@@ -35,33 +36,30 @@
--mandir=\$${prefix}/share/man \
--infodir=\$${prefix}/share/info
-
build: build-stamp
-build-stamp: config.status
+build-stamp: patch config.status
+ @echo Starting compile (`date`)...
dh_testdir
-
$(MAKE)
-
touch build-stamp
-clean:
+clean: clean1 unpatch
+
+clean1:
+ @echo Cleaning...
dh_testdir
dh_testroot
rm -f build-stamp
-
-$(MAKE) distclean
-
# Kill auto-generated files so that they do not enter the diff.
rm -rf config.guess config.log config.sub
-
dh_clean
-install: build
+install: build-stamp
dh_testdir
dh_testroot
dh_clean -k
dh_installdirs
-
$(MAKE) install DESTDIR=$(CURDIR)/debian/tmp
# Build architecture-independent files here.
@@ -90,2 +88,14 @@
+patch: patch-stamp
+
+patch-stamp:
+ dpatch apply-all
+ dpatch cat-all patch-stamp
+ touch patch-stamp
+
+unpatch:
+ dpatch deapply-all
+ rm -rf patch-stamp debian/patched
+
binary: binary-indep binary-arch
-.PHONY: build clean binary-indep binary-arch binary install
+.PHONY: build clean binary-indep binary-arch binary install patch unpatch \
+ clean1
diff -u net6-1.3.1/debian/changelog net6-1.3.1/debian/changelog
--- net6-1.3.1/debian/changelog
+++ net6-1.3.1/debian/changelog
@@ -1,3 +1,16 @@
+net6 (1:1.3.1-3) unstable; urgency=low
+
+ * Adopted dpatch.
+- Fix IPv6 usage: Every application could now choose to use IPv6
+ on connect which enables them to retry without if the first
+ attempt fails due to missing kernel support.
+- Errors caused by invalid data on the connection does propagate
+ as a seperate exception.
+- Moved gettext compatibility patch into a seperate patch file.
+ * Bump versioned dependency in shlibs file.
+
+ -- Philipp Kern [EMAIL PROTECTED] Wed, 17 Jan 2007 00:17:58 +0100
+
net6 (1:1.3.1-2)
Re: Freeze exception: net6, obby, gobby
Hi Philipp, On Mon, Mar 12, 2007 at 08:39:12PM +0100, Philipp Kern wrote: could you please grant net6, obby and gobby a freeze exception? The uploads of net6 and obby allow Gobby to be used with kernels without IPv6 support (i.e. self-compiled ones or kernels provided by hosting facilities). Furthermore invalid input on the connection (i.e. send by a hostile server) does no longer cause an exception propagating to the application, which did terminate Gobby. --- net6-1.3.1/debian/rules +++ net6-1.3.1/debian/rules @@ -1,4 +1,5 @@ #!/usr/bin/make -f +#!/usr/bin/make -f # -*- makefile -*- # Uncomment this to turn on verbose mode. Um, doubled interpreter line? The IPv6 patch added a new default parameter. Tests of mine shows that it was ABI- and API-compatible, but I guess you judge that better than I could. Ok, then why have you bumped the shlibs in this version? I guess the 'fatal' class is a new exported class? obby changes: * Adopt dpatch: - Add a patch to retry IPv6 if it's unavailable. Obby also includes changes to the dependencies of libobby-0.4-dev. Why does the libnet6-1.3-dev dependency need to change so frequently? If it actually needs to be changed so often, doesn't that mean the dependency will be wrong on a simple rebuild of the package? Anyway, I'm not sure that 'retry' is the correct solution here, but I don't have any evidence to the contrary, so I've unblocked both of these. gobby changes: * Fix mime type mapping. * Lack of avahi-daemon now fails silently instead of a verbose message confusing the user. Zeroconf is a `nice to have' but in no means required. I don't see that a freeze exception is justified here. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. [EMAIL PROTECTED] http://www.debian.org/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Freeze exception: net6, obby, gobby
Hey Steve, On Mon, Mar 12, 2007 at 04:38:30PM -0700, Steve Langasek wrote: | --- net6-1.3.1/debian/rules | +++ net6-1.3.1/debian/rules | @@ -1,4 +1,5 @@ | #!/usr/bin/make -f | +#!/usr/bin/make -f | # -*- makefile -*- Um, doubled interpreter line? Uh... Gotcha. Sorry, I don't know where that comes from. I will fix that in a future upload, as luckily enough this doesn't do any harm. *cough* obby changes: * Adopt dpatch: - Add a patch to retry IPv6 if it's unavailable. Obby also includes changes to the dependencies of libobby-0.4-dev. Why does the libnet6-1.3-dev dependency need to change so frequently? If it actually needs to be changed so often, doesn't that mean the dependency will be wrong on a simple rebuild of the package? Well, obby is a library relying heavily on templates. As the newer obby retries on IPv6, which is specified in the header, it depends on the new parameter introduced with the net6 upload. Thus the new tighter dependency. I don't see why the dependency should be wrong on a simple rebuild, though. Anyway, I'm not sure that 'retry' is the correct solution here, but I don't have any evidence to the contrary, so I've unblocked both of these. Binding to the socket fails when the IPv6 socket is tried (which is used for both IPv6 and IPv4) and kernel support is not present. Thus it's then safe to retry with IPv4-only. Currently binding just fails with Address family not supported (from mind only), because IPv6 support is explicitly requested by the API which is not available on the target platform at times. (Which is more critical with Sobby on a server than with Gobby on a client...) gobby changes: * Fix mime type mapping. * Lack of avahi-daemon now fails silently instead of a verbose message confusing the user. Zeroconf is a `nice to have' but in no means required. I don't see that a freeze exception is justified here. Well, it's also a rebuild against current net6 and obby, and as the former two are mostly template libraries the changes only get instanciated in the final application which provides the selector template argument, which is Gobby. Thus the changes in net6 and obby are not visible until Gobby is rebuilt, and as the two changes are annoying I fixed them on the way.[1] The IPv6 patch added a new default parameter. Tests of mine shows that it was ABI- and API-compatible, but I guess you judge that better than I could. Ok, then why have you bumped the shlibs in this version? I guess the 'fatal' class is a new exported class? I guess technically a shlibs bump is not necessary as we did not modify symbols in the real library, that's right. In fact I only wanted obby to depend on the newer net6 library for cleanliness, because it needs to depend on the newer development package. I already questioned the sense of packaging template libraries because they export only very few symbols and have the remaining code in headers which are only instantiated in the final application. This is just as bad as statical linking. I guess it's too late to merge all the packages into one big package building the whole package set... But I will certainly consider that for the time after Etch...[2] Kind regards, Philipp Kern Debian Developer [1] At work I cannot install avahi-daemon because we use local as a domain suffix. Thus all users get this annoying warning at startup. And the mime types bug prevented Gobby to provide proper highlighting for C++ out of the box, although it is supported. This part of the application depends on the proper specification of the type. [2] Except of course that you state that you cannot risk this situation in Etch and thus decide to remove the packages altogether. signature.asc Description: Digital signature
Re: Freeze exception: net6, obby, gobby
On Tue, Mar 13, 2007 at 01:27:58AM +0100, Philipp Kern wrote: obby changes: * Adopt dpatch: - Add a patch to retry IPv6 if it's unavailable. Obby also includes changes to the dependencies of libobby-0.4-dev. Why does the libnet6-1.3-dev dependency need to change so frequently? If it actually needs to be changed so often, doesn't that mean the dependency will be wrong on a simple rebuild of the package? Well, obby is a library relying heavily on templates. As the newer obby retries on IPv6, which is specified in the header, it depends on the new parameter introduced with the net6 upload. Thus the new tighter dependency. I don't see why the dependency should be wrong on a simple rebuild, though. Because on a simple rebuild, someone may be building against a different version of net6? gobby changes: * Fix mime type mapping. * Lack of avahi-daemon now fails silently instead of a verbose message confusing the user. Zeroconf is a `nice to have' but in no means required. I don't see that a freeze exception is justified here. Well, it's also a rebuild against current net6 and obby, and as the former two are mostly template libraries the changes only get instanciated in the final application which provides the selector template argument, which is Gobby. Thus the changes in net6 and obby are not visible until Gobby is rebuilt, and as the two changes are annoying I fixed them on the way.[1] Mmm, ok. Well, even if gobby isn't unblocked, it would be possible to fix the template lib bit (gah) with binNMUs in testing. I'll take another look at the gobby in unstable anyway, and let you know. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. [EMAIL PROTECTED] http://www.debian.org/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
