Re: jd uploaded to s-p-u, please accept (was Re: JD package for Lenny point release)
Hi Holger, Thanks to check and your comment. On Sat, 9 May 2009 18:01:46 +0200 Holger Levsen wrote: > It's better and I've uploaded it now. But please, > > a.) you bumped Standards-Version in debian/control, without mentioning in > debian/changelog, and really you shouldn't have bumped the version in the > first place (I've set it back to 3.8.0) > > b.) you left the distribution in changelog at "unstable", it has to > be "stable-proposed-updates" for uploads targeted at lenny. OKay, I'll care about that next time. > c.) I only noticed this after building the package. Then I learned that jd > fails to build twice in a row. Please check in unstable that this isn't the > case and if so, please fix that. Um? I've never got such build failure (and I always use pbuilder as well). Please tell me what you got at build. -- Regards, Hideki Yamane henrich @ debian.or.jp/iijmio-mail.jp http://wiki.debian.org/HidekiYamane -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
jd uploaded to s-p-u, please accept (was Re: JD package for Lenny point release)
Hi, On Donnerstag, 30. April 2009, Hideki Yamane wrote: > henr...@babytalk:~/src/2ch-browser/jd$ debdiff jd_2.0.0-080722-2.dsc > jd_2.0.0-080722-2+lenny1.dsc |diffstat debian/patches/post-cookie.dpatch > | 379 ++ jd-2.0.0-080722/debian/changelog > |7 > jd-2.0.0-080722/debian/control|2 > jd-2.0.0-080722/debian/patches/00list |1 > 4 files changed, 388 insertions(+), 1 deletion(-) > > How about this one? It's better and I've uploaded it now. But please, a.) you bumped Standards-Version in debian/control, without mentioning in debian/changelog, and really you shouldn't have bumped the version in the first place (I've set it back to 3.8.0) b.) you left the distribution in changelog at "unstable", it has to be "stable-proposed-updates" for uploads targeted at lenny. c.) I only noticed this after building the package. Then I learned that jd fails to build twice in a row. Please check in unstable that this isn't the case and if so, please fix that. SRMs, please accept this package into stable. Thanks. regards, Holger signature.asc Description: This is a digitally signed message part.
Re: JD package for Lenny point release
Hi RM, On Sat, 25 Apr 2009 14:29:23 +0200 Philipp Kern wrote: > > $ debdiff jd_2.0.0-080722-2.dsc jd_2.0.0-080722-2+lenny1.dsc|diffstat > > debian/patches/post-cookie.dpatch | 2696 > > ++ > > jd-2.0.0-080722/debian/changelog |7 > > jd-2.0.0-080722/debian/control|2 > > jd-2.0.0-080722/debian/patches/00list |1 > > 4 files changed, 2705 insertions(+), 1 deletion(-) > > > > SRMs, would that be ok for 5.0.2? If not, I'd suggest removal from stable. henr...@babytalk:~/src/2ch-browser/jd$ debdiff jd_2.0.0-080722-2.dsc jd_2.0.0-080722-2+lenny1.dsc |diffstat debian/patches/post-cookie.dpatch | 379 ++ jd-2.0.0-080722/debian/changelog |7 jd-2.0.0-080722/debian/control|2 jd-2.0.0-080722/debian/patches/00list |1 4 files changed, 388 insertions(+), 1 deletion(-) How about this one? -- Regards, Hideki Yamane henrich @ debian.or.jp/iijmio-mail.jp http://wiki.debian.org/HidekiYamane jd.diff.gz Description: Binary data pgptpqeoGH6Cx.pgp Description: PGP signature
Re: JD package for Lenny point release
Hi, On Sat, 25 Apr 2009 14:33:40 +0200 Philipp Kern wrote: > I am afraid that there are differences in handling packages which have 23000 > users reporting to popcon and 83. First, popcon is disabled by default. And second, 2ch BBS is "anonymous" BBS, so its users don't want to report their profile for others. 3rd, 2ch is huge, its pageview number is... about 6,000,000,000/month in Nov 2008. And some Debian related articles are there, so I want to follow them. > We blocked packages for screenscraping late in the release and although > protocol changes can happen with ICQ et al. we expect them to be of lower > frequency than websites usually change. (Of course, ICQ can always prove > us wrong on the whim.) > > And postgresql got a special exeception with upstream doing bugfix-only > releases with enough QA. Okay, you're right. And I hope not to get frequently such change for jd. -- Regards, Hideki Yamane henrich @ debian.or.jp/iijmio-mail.jp http://wiki.debian.org/HidekiYamane -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: JD package for Lenny point release
On Sat, Apr 18, 2009 at 08:12:56AM +0900, Hideki Yamane wrote: > And for example, at the first point release > > >pidgin Fix failure while connecting to ICQ servers due to protocol > >changes > >postgresql-8.3 New upstream bugfix release > > pidgin deals with protocol changes and postgresql is new release. > What's the difference with JD package's change? I think it is same issue. I am afraid that there are differences in handling packages which have 23000 users reporting to popcon and 83. We blocked packages for screenscraping late in the release and although protocol changes can happen with ICQ et al. we expect them to be of lower frequency than websites usually change. (Of course, ICQ can always prove us wrong on the whim.) And postgresql got a special exeception with upstream doing bugfix-only releases with enough QA. Kind regards, Philipp Kern -- .''`. Philipp KernDebian Developer : :' : http://philkern.de Stable Release Manager `. `' xmpp:p...@0x539.de Wanna-Build Admin `-finger pkern/k...@db.debian.org signature.asc Description: Digital signature
Re: JD package for Lenny point release
On Wed, Apr 01, 2009 at 05:20:38PM +0100, Holger Levsen wrote: > Hi, > > On Mittwoch, 1. April 2009, Hideki Yamane wrote: > > Until change happened in BBS, hardcoded cookie "hana=mogera" was used. > > After the change, JD needs to add functions and fixes for that cookie > > code, so it's big but is needed (to make it from "half-broken" to fixed > > one). > > http://mentors.debian.net/debian/pool/main/j/jd/jd_2.0.0-080722-2+lenny1.dsc > > $ debdiff jd_2.0.0-080722-2.dsc jd_2.0.0-080722-2+lenny1.dsc|diffstat > debian/patches/post-cookie.dpatch | 2696 > ++ > jd-2.0.0-080722/debian/changelog |7 > jd-2.0.0-080722/debian/control|2 > jd-2.0.0-080722/debian/patches/00list |1 > 4 files changed, 2705 insertions(+), 1 deletion(-) > > SRMs, would that be ok for 5.0.2? If not, I'd suggest removal from stable. The diffstat is a bit off because the dpatch is very unclean. Here's the diffstat for the dpatch: pk...@asterix:/tmp/jd-2.0.0-080722/debian/patches$ diffstat post-cookie.dpatch board/preference.cpp | 18 board/preference.cpp.orig | 404 + board/preference.h|2 dbtree/article2ch.cpp |6 dbtree/board2ch.cpp | 67 ++ dbtree/board2ch.h |4 dbtree/boardbase.h| 16 dbtree/boardbase.h.orig | 444 +++ dbtree/interface.cpp | 14 dbtree/interface.cpp.orig | 1057 ++ dbtree/interface.h|5 message/post.cpp | 46 -- message/post.cpp.orig | 396 + message/post.h|3 14 files changed, 2426 insertions(+), 56 deletions(-) As you see many complete origs in there. I am, however, unable to review the remainder as the source comments are in Japanese. I think considering the much fewer size than we originally assumed that this could be safe for stable inclusion. So please go ahead and get it into p-u-NEW. (Pretty please, with a clean dpatch.) Kind regards, Philipp Kern -- .''`. Philipp KernDebian Developer : :' : http://philkern.de Stable Release Manager `. `' xmpp:p...@0x539.de Wanna-Build Admin `-finger pkern/k...@db.debian.org signature.asc Description: Digital signature
Re: JD package for Lenny point release
Hi, On Thu, 2 Apr 2009 12:06:10 +0200 Holger Levsen wrote: > If the fix is too intrusive for a lenny point release the way to support it > is > in backports.org, where it already is. I don't think "too intrusive", because no packages are depending on JD package. And is there any wrong side effect? Its changes is huge, yes, I agree. But it is not depended from other packages. And for example, at the first point release >pidgin Fix failure while connecting to ICQ servers due to protocol >changes >postgresql-8.3 New upstream bugfix release pidgin deals with protocol changes and postgresql is new release. What's the difference with JD package's change? I think it is same issue. (it is like that suddenly protocol is changed, and there was no annouce before that change...) So, please, don't remove jd package from lenny and update (or provide from volatile). -- Regards, Hideki Yamane henrich @ debian.or.jp/iijmio-mail.jp http://wiki.debian.org/HidekiYamane -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: JD package for Lenny point release
Hi Hideki, On Donnerstag, 2. April 2009, Hideki Yamane wrote: > > SRMs, would that be ok for 5.0.2? If not, I'd suggest removal from > > stable. > Or put it into volatile, please. Thats a bug, which makes the package unusable, so the solution is either to fix it or to remove it. Volatile is for packages which constantly change (in parts). If the fix is too intrusive for a lenny point release the way to support it is in backports.org, where it already is. regards, Holger signature.asc Description: This is a digitally signed message part.
Re: JD package for Lenny point release
On Wed, 1 Apr 2009 17:20:38 +0100 Holger Levsen wrote: > On Mittwoch, 1. April 2009, Hideki Yamane wrote: > > Until change happened in BBS, hardcoded cookie "hana=mogera" was used. > > After the change, JD needs to add functions and fixes for that cookie > > code, so it's big but is needed (to make it from "half-broken" to fixed > > one). > > http://mentors.debian.net/debian/pool/main/j/jd/jd_2.0.0-080722-2+lenny1.dsc > > $ debdiff jd_2.0.0-080722-2.dsc jd_2.0.0-080722-2+lenny1.dsc|diffstat > debian/patches/post-cookie.dpatch | 2696 > ++ > jd-2.0.0-080722/debian/changelog |7 > jd-2.0.0-080722/debian/control|2 > jd-2.0.0-080722/debian/patches/00list |1 > 4 files changed, 2705 insertions(+), 1 deletion(-) > > SRMs, would that be ok for 5.0.2? If not, I'd suggest removal from stable. Or put it into volatile, please. -- Regards, Hideki Yamane henrich @ debian.or.jp/iijmio-mail.jp http://wiki.debian.org/HidekiYamane -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: JD package for Lenny point release
Hi, On Mittwoch, 1. April 2009, Hideki Yamane wrote: > Until change happened in BBS, hardcoded cookie "hana=mogera" was used. > After the change, JD needs to add functions and fixes for that cookie > code, so it's big but is needed (to make it from "half-broken" to fixed > one). > http://mentors.debian.net/debian/pool/main/j/jd/jd_2.0.0-080722-2+lenny1.dsc $ debdiff jd_2.0.0-080722-2.dsc jd_2.0.0-080722-2+lenny1.dsc|diffstat debian/patches/post-cookie.dpatch | 2696 ++ jd-2.0.0-080722/debian/changelog |7 jd-2.0.0-080722/debian/control|2 jd-2.0.0-080722/debian/patches/00list |1 4 files changed, 2705 insertions(+), 1 deletion(-) SRMs, would that be ok for 5.0.2? If not, I'd suggest removal from stable. regards, Holger signature.asc Description: This is a digitally signed message part.
Re: JD package for Lenny point release (Re: upcoming point releases
Hi, On Mon, 30 Mar 2009 06:45:53 +0900 Hideki Yamane wrote: > > Still I'm not sure the stable release managers like such a big diff - or am > > I > > wrong? If so, please comment, I'd be happy to sponsor this to s-p-u Until change happened in BBS, hardcoded cookie "hana=mogera" was used. After the change, JD needs to add functions and fixes for that cookie code, so it's big but is needed (to make it from "half-broken" to fixed one). I've uploaded again, and I hope this would go into Lenny. http://mentors.debian.net/debian/pool/main/j/jd/jd_2.0.0-080722-2+lenny1.dsc -- Regards, Hideki Yamane henrich @ debian.or.jp/iijmio-mail.jp http://wiki.debian.org/HidekiYamane pgpAh6TXKuy4i.pgp Description: PGP signature
