Re: Please unblock schroot 1.4.18-1
On Tue, January 11, 2011 13:03, Roger Leigh wrote: > On Tue, Jan 11, 2011 at 01:01:53AM +0100, Cyril Brulebois wrote: >> Roger Leigh (10/01/2011): >> > Thanks, I have released, tested, built and uploaded. >> >> #609619 > > This has been fixed and now autobuilds OK on kfreebsd-*. Please > could you unblock 1.4.19-1 which contains just this single fix > compared against 1.4.18-1. Unblocked; thanks. Regards, Adam -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/91ce374db7a29978f12c3df9b347765f.squir...@adsl.funky-badger.org
Re: Please unblock schroot 1.4.18-1
On Tue, Jan 11, 2011 at 01:01:53AM +0100, Cyril Brulebois wrote: > Roger Leigh (10/01/2011): > > Thanks, I have released, tested, built and uploaded. > > #609619 This has been fixed and now autobuilds OK on kfreebsd-*. Please could you unblock 1.4.19-1 which contains just this single fix compared against 1.4.18-1. Thanks, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `-GPG Public Key: 0x25BFB848 Please GPG sign your mail. signature.asc Description: Digital signature
Re: Please unblock schroot 1.4.18-1
Roger Leigh (10/01/2011): > Thanks, I have released, tested, built and uploaded. #609619 KiBi. signature.asc Description: Digital signature
Re: Please unblock schroot 1.4.18-1
On Mon, Jan 10, 2011 at 08:36:12PM +, Adam D. Barratt wrote: > On Sun, 2011-01-09 at 23:39 +, Roger Leigh wrote: > > On Sun, Jan 09, 2011 at 10:38:09PM +, Adam D. Barratt wrote: > > > On Fri, 2011-01-07 at 15:06 +, Roger Leigh wrote: > > > > We also update > > > > the 50chrootname setup script to handle non-UUID generated session > > > > names. > > > > > > That's presumably this addition: > > > > > > 's/-[0-9][0-9]*-[0-9][0-9]*//g' > [...] > > > Apologies if I'm missing something related to the context, but isn't > > > there a danger of that regex being insufficiently specific? > > > > No, you're right. The non-UUID session names we use for kfreebsd are > > made from the time (seconds since epoch) + PID to guarantee uniqueness. > > I could require more digits to make it specific. The PID should always > > be at least three digits and the time at least 10 digits, so I can add > > the extra [0-9] to the regex to do that. > > That would seem cleaner, although by the sound of it the practical > impact either way is minimal. I have made (and tested) this change, including accounting for PID wraparound. > schroot 1.4.17-1 has now migrated, so please feel free to upload 1.4.18 > (although preferably without much delay). Thanks, I have released, tested, built and uploaded. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `-GPG Public Key: 0x25BFB848 Please GPG sign your mail. signature.asc Description: Digital signature
Re: Please unblock schroot 1.4.18-1
On Sun, 2011-01-09 at 23:39 +, Roger Leigh wrote: > On Sun, Jan 09, 2011 at 10:38:09PM +, Adam D. Barratt wrote: > > On Fri, 2011-01-07 at 15:06 +, Roger Leigh wrote: > > > We also update > > > the 50chrootname setup script to handle non-UUID generated session > > > names. > > > > That's presumably this addition: > > > > 's/-[0-9][0-9]*-[0-9][0-9]*//g' [...] > > Apologies if I'm missing something related to the context, but isn't > > there a danger of that regex being insufficiently specific? > > No, you're right. The non-UUID session names we use for kfreebsd are > made from the time (seconds since epoch) + PID to guarantee uniqueness. > I could require more digits to make it specific. The PID should always > be at least three digits and the time at least 10 digits, so I can add > the extra [0-9] to the regex to do that. That would seem cleaner, although by the sound of it the practical impact either way is minimal. schroot 1.4.17-1 has now migrated, so please feel free to upload 1.4.18 (although preferably without much delay). Regards, Adam -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1294691772.5978.459.ca...@hathi.jungle.funky-badger.org
Re: Please unblock schroot 1.4.18-1
On Sun, Jan 09, 2011 at 10:38:09PM +, Adam D. Barratt wrote: > On Fri, 2011-01-07 at 15:06 +, Roger Leigh wrote: > > Sorry to trouble you again, but I found soon after this release > > #609108 which was breaking schroot on all kfreebsd platforms. > > This is actually due to the statfs structure being broken on > > FreeBSD, limiting the mount and umount commands to paths less > > than 88 characters (80 in practice). > > > > While we can't fix that major design flaw, we can reduce the > > path length to <80 in most circumstances by not using long UUIDs > > in session names. > [...] > > We also update > > the 50chrootname setup script to handle non-UUID generated session > > names. > > That's presumably this addition: > > 's/-[0-9][0-9]*-[0-9][0-9]*//g' > > described in the changelog as: > > * 50chrootname: Strip time+PID from session name in addition to UUID. > > Apologies if I'm missing something related to the context, but isn't > there a danger of that regex being insufficiently specific? No, you're right. The non-UUID session names we use for kfreebsd are made from the time (seconds since epoch) + PID to guarantee uniqueness. I could require more digits to make it specific. The PID should always be at least three digits and the time at least 10 digits, so I can add the extra [0-9] to the regex to do that. Note that the stripping is only used for putting a shortened form into /etc/debian_chroot; this is only really used for things like a customised prompt in the bash shell, so it has zero impact on schroot's functioning correctly. Since it's stripping the unique part off and leaving the chroot base name, it's not useful for doing anything with other than informational logging, and inside the chroot you can't do anything with it in any case. The full form is always available as SCHROOT_SESSION_ID in the environment. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `-GPG Public Key: 0x25BFB848 Please GPG sign your mail. signature.asc Description: Digital signature
Re: Please unblock schroot 1.4.18-1
On Fri, 2011-01-07 at 15:06 +, Roger Leigh wrote: > Sorry to trouble you again, but I found soon after this release > #609108 which was breaking schroot on all kfreebsd platforms. > This is actually due to the statfs structure being broken on > FreeBSD, limiting the mount and umount commands to paths less > than 88 characters (80 in practice). > > While we can't fix that major design flaw, we can reduce the > path length to <80 in most circumstances by not using long UUIDs > in session names. [...] > We also update > the 50chrootname setup script to handle non-UUID generated session > names. That's presumably this addition: 's/-[0-9][0-9]*-[0-9][0-9]*//g' described in the changelog as: * 50chrootname: Strip time+PID from session name in addition to UUID. Apologies if I'm missing something related to the context, but isn't there a danger of that regex being insufficiently specific? Regards, Adam -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1294612689.2903.16288.ca...@hathi.jungle.funky-badger.org
Re: Please unblock schroot 1.4.18-1
On Fri, Jan 07, 2011 at 04:26:18PM +0100, Julien Cristau wrote: > On Fri, Jan 7, 2011 at 15:06:35 +, Roger Leigh wrote: > > > Is this OK to upload and be allowed into testing? > > > At least not until the previous version goes in (I didn't look at the > proposed changes). Of course. I won't be uploading anything until then. Thanks, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `-GPG Public Key: 0x25BFB848 Please GPG sign your mail. signature.asc Description: Digital signature
Re: Please unblock schroot 1.4.18-1
On Fri, Jan 7, 2011 at 15:06:35 +, Roger Leigh wrote: > Is this OK to upload and be allowed into testing? > At least not until the previous version goes in (I didn't look at the proposed changes). Cheers, Julien signature.asc Description: Digital signature
Re: Please unblock schroot 1.4.18-1
On Thu, Dec 30, 2010 at 08:14:10PM +, Adam D. Barratt wrote: > On Thu, 2010-12-30 at 15:38 +, Roger Leigh wrote: > > On Wed, Dec 08, 2010 at 08:44:48PM +, Adam D. Barratt wrote: > > > As discussed on IRC, it's a shame that this resulted in a new > > > translatable (and currently untranslated) string, although the fact that > > > the string should rarely be seen and is in the program translation > > > rather than a debconf template mitigates this slightly. > > > > I've allowed a fortnight for translation updates to come back, and > > made a new release (1.4.17-1) containing five translation updates > > and an additional RC bugfix. Please could you unblock this to > > allow it into squeeze? > > Unblocked; thanks. Sorry to trouble you again, but I found soon after this release #609108 which was breaking schroot on all kfreebsd platforms. This is actually due to the statfs structure being broken on FreeBSD, limiting the mount and umount commands to paths less than 88 characters (80 in practice). While we can't fix that major design flaw, we can reduce the path length to <80 in most circumstances by not using long UUIDs in session names. The proposed changes to this bug are in this git diff: http://git.debian.org/?p=buildd-tools/schroot.git;a=commitdiff;h=132cb05f7908f31052998934dd10883bea4a0e93;hp=release/schroot-1.4.17 Here, we fix the libuuid autodetection and enable/disable logic in configure.ac and also fix a similar issue in the PAM logic. On the Debian packaging side, we don't build-dep on uuid-dev on kfreebsd, and deliberately disable it when running configure. We also update the 50chrootname setup script to handle non-UUID generated session names. This has been tested on native kfreebsd by Julián Moreno Patiño and Jakub Wilk, and by myself on KVM/qemu with a kfreebsd-amd64 VM as well as on linux-amd64. Is this OK to upload and be allowed into testing? Thanks, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' Printing on GNU/Linux? http://gutenprint.sourceforge.net/ `-GPG Public Key: 0x25BFB848 Please GPG sign your mail. signature.asc Description: Digital signature
