Re: Pocsuite3 packaging
Just for the record, I have replied to the other thread (and confirmed the upload). Regards, -- Samuel Henrique
Re: Pocsuite3 packaging
Hello fenix, > I just updated pocsuite3 to upstream version 1.9.6. Could you please help me > to review and upload it? > > By the way, as you suggested, I switched the url on d/watch to point to tags > instead :) Perfect, I have uploaded 1.9.6-1 for you, > Have a great day! You too, thanks for contributing! Cheers, -- Samuel Henrique
Re: Pocsuite3 packaging
Hello Samuel, I just updated pocsuite3 to upstream version 1.9.6. Could you please help me to review and upload it? By the way, as you suggested, I switched the url on d/watch to point to tags instead 😊 > > I have just a couple of comments which are not critical and can be fixed > later in a future upload. > I've noticed you switched the url on d/watch to point to releases/latest, > I suggest considering pointing to tags[0] instead, that way uscan can fetch > a list of recent releases and parse that. Using releases/latest might hide > a new unpackaged release if there was another one more recent which for > some reason gets dropped by uscan (weird version or beta/rc, for example) > VCS: https://salsa.debian.org/pkg-security-team/pocsuite3 Have a great day! Cheers, Tian
Re: Pocsuite3 packaging
Thank you very much for your help and advice! Sincerely, Tian > > I uploaded 1.8.10-1 for you. > > I have just a couple of comments which are not critical and can be fixed > later in a future upload. > I've noticed you switched the url on d/watch to point to releases/latest, I > suggest considering pointing to tags[0] instead, that way uscan can fetch a > list of recent releases and parse that. Using releases/latest might hide a > new unpackaged release if there was another one more recent which for some > reason gets dropped by uscan (weird version or beta/rc, for example) > > It's generally better to let the person who uploads the package to push the > debian/ tag (debian/1.8.10-1), this is because sometimes what you tag as > debian/1.8.10-1 might not be what gets uploaded (if the person reviewing it > makes more changes on top, or example). As an extra note, you might want to > consider signing the tags with your GPG keys as well. If you're using gbp, > the setting is "sign-tags = True" under the "DEFAULT" section.
Re: Pocsuite3 packaging
Hello Tian, Happy new year! I just updated pocsuite3 to upstream version 1.8.10, > could you please help me to review and upload it? > Happy new year to you too! I uploaded 1.8.10-1 for you. I have just a couple of comments which are not critical and can be fixed later in a future upload. I've noticed you switched the url on d/watch to point to releases/latest, I suggest considering pointing to tags[0] instead, that way uscan can fetch a list of recent releases and parse that. Using releases/latest might hide a new unpackaged release if there was another one more recent which for some reason gets dropped by uscan (weird version or beta/rc, for example) It's generally better to let the person who uploads the package to push the debian/ tag (debian/1.8.10-1), this is because sometimes what you tag as debian/1.8.10-1 might not be what gets uploaded (if the person reviewing it makes more changes on top, or example). As an extra note, you might want to consider signing the tags with your GPG keys as well. If you're using gbp, the setting is "sign-tags = True" under the "DEFAULT" section. Thank you for your contributions! [0] https://github.com/knownsec/pocsuite3/tags Cheers, -- Samuel Henrique
Re: Pocsuite3 packaging
Hello Tian, > I want to migration pocsuite3 package to testing, > > Could you please help me to do a source-only upload, thanks! Awesome, I've uploaded itr for you, Thank you for your work! -- Samuel Henrique
