Bug#642934: sponsorship for aircrack-ng
Hi, David Francos wrote (01 May 2012 12:15:15 GMT) : > Thank you, I'll fix this as soon as possible, I've been forced to > leave all this behind for a while, hope to be able to catch with > it soon. Any chance you, or Carlos (who still owns the ITP bug) or anyone else fixes this in time for the Wheezy freeze? > About the licensing, there seems to be still an issue, hope it gets > resolved soon enough. To clarify, is this issue the one with the OpenSSL that Carlos raised in message #132? Given there's a patch that was apparently well tested, perhaps the patch could be applied to the Debian package, and this should not be blocking the upload to Debian? (Perhaps I missed something, merely trying to see what's *really* blocking on this front.) Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/857gvibmhh@boum.org
Bug#642934: Sponsorship for aircrack-ng
Hello, I have just packaged and updated a new version of aircrack-ng. I have completely reworked the package. I switched to dh for debian/rules and also switched debian/copyright to machine-readable format. I backported the GnuTLS patch to aircrack-ng 1.1 and also I cherry-picked a few other patches from upstream that fixed some issues with the current codebase. Among the issues fixed, there are included all the Debian bugs with priority greater than Normal that were open against the last version of aircrack-ng on Debian. I have also enabled the hardening-flags. About the injection patches: I simply removed them from the package. Airdriver-ng downloads this patches from Internet, so this files never were an useful thing to have inside the package. About the airdrop-ng and airgraph-ng scripts: * Airdrop-ng depends on Pylorcon libraries that are not packaged on Debian. * Airgraph-ng seems to be still an early work-in-progress not ready for general use. (Ex: it overwrites the input file when the "-o" (output) parameter is not specified) So I am excluding this files from the package for the moment. I have uploaded the new package to mentors.debian.net http://mentors.debian.net/package/aircrack-ng The package is signed with my key that you can import with: gpg --keyserver pgp.mit.edu --recv-keys 965089CE6B95F882 If all looks ok, then I will need somebody to sponsor this package. Just hoping this is still on time to be included on Wheezy. Once it enters into Debian again, I would re-open the bugs that were automatically closed when the package was removed and that are not fixed by this upload. Wishing to hear any comments. Thanks! Best regards! -- ~~~ Carlos Alberto Lopez Perez http://neutrino.es Igalia - Free Software Engineeringhttp://www.igalia.com ~~~ signature.asc Description: OpenPGP digital signature
Bug#642934: Sponsorship for aircrack-ng
On Sun, 2012-06-17 at 08:08 +0200, Carlos Alberto Lopez Perez wrote: > Wishing to hear any comments. Oh, one more thing, how about a README.Debian explaining the situation with OpenSSL and how to rebuild the package with OpenSSL instead, for those users who want the extra speed? -- bye, pabs http://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#642934: Sponsorship for aircrack-ng
On 18/06/12 07:26, Paul Wise wrote: > On Sun, 2012-06-17 at 08:08 +0200, Carlos Alberto Lopez Perez wrote: > >> Wishing to hear any comments. > > Oh, one more thing, how about a README.Debian explaining the situation > with OpenSSL and how to rebuild the package with OpenSSL instead, for > those users who want the extra speed? > I have just re-introduced the README.Debian from the old package and added a new entry summarizing the changes introduced as also commenting how to rebuild the package with OpenSSL. I have re-uploaded it to mentors.debian.net Regards! -- ~~~ Carlos Alberto Lopez Perez http://neutrino.es Igalia - Free Software Engineeringhttp://www.igalia.com ~~~ signature.asc Description: OpenPGP digital signature
Bug#642934: Sponsorship for aircrack-ng
On Mon, 2012-06-18 at 13:04 +0200, Carlos Alberto Lopez Perez wrote: > I have re-uploaded it to mentors.debian.net Please make it -3 since -2 is already in NEW. -- bye, pabs http://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#642934: Sponsorship for aircrack-ng
On 18/06/12 14:45, Paul Wise wrote: > On Mon, 2012-06-18 at 13:04 +0200, Carlos Alberto Lopez Perez wrote: > >> I have re-uploaded it to mentors.debian.net > > Please make it -3 since -2 is already in NEW. > Done... made a new changelog entry (-3) and re-uploaded to mentors Looks ok now? Thanks! -- ~~~ Carlos Alberto Lopez Perez http://neutrino.es Igalia - Free Software Engineeringhttp://www.igalia.com ~~~ signature.asc Description: OpenPGP digital signature
Bug#642934: sponsorship for aircrack-ng
Hi, I've taken bug http://trac.aircrack-ng.org/ticket/953 at aircrack-ng. I've resolved almost all the license issues, except two files from hirte, whom I'm having trouble to contact, and the file crctable.h < http://trac.aircrack-ng.org/svn/trunk/src/crctable.h > whose author we have not yet identified. I was wondering if, because of the content of crctable.h, could be marked as uncopyrightable. Well, also, say that those are the lastest files from this list that Carlos Lopez reported on the trac: # are not GPL licensed ?? # src/airodump-ng.h src/crypto.h src/aircrack-ng.h src/aircrack-ptw-lib.h src/uniqueiv.h src/common.h src/pcap.h src/crctable.h src/osdep/osdep.h src/osdep/common.h src/version.h src/osdep/packed.h ### are GPL licensed and **DON'T** include the OpenSSL Exception ### src/crypto.c src/include/ieee80211.h src/sha1-sse2.h src/osdep/byteorder.h We're almost there, don't let this stop. Also, I should say it, I'm making a package from the svn revision, and it's much easier to package, and has much less lintian warnings (if some), you can have a look at the source of the package at http://github.com/XayOn/Aircrack-ngDebian/ I've written a simpler (and I think better) rules file, installing also scripts and "unstable" tools and updated the recommends to fit with them, also, only one of the patches seemed necesary (the usrlocal one). -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caey15fxqd8a-mytmmxr-s9t2ctrtr6yr7hqr4cpedpevb85...@mail.gmail.com
Bug#642934: sponsorship for aircrack-ng
On 15/02/12 16:47, David Francos wrote: > Hi, I've taken bug http://trac.aircrack-ng.org/ticket/953 at aircrack-ng. > I've resolved almost all the license issues, except two files from > hirte, whom I'm having trouble to contact, and the file crctable.h < > http://trac.aircrack-ng.org/svn/trunk/src/crctable.h > whose author we > have not yet identified. I was wondering if, because of the content of > crctable.h, could be marked as uncopyrightable. > [...] > > We're almost there, don't let this stop. Yes, seems that this issue with the license is finally being resolved. Thanks a lot for your work :) > Also, I should say it, I'm making a package from the svn revision, and > it's much easier to package, and has much less lintian warnings (if > some), you can have a look at the source of the package at > http://github.com/XayOn/Aircrack-ngDebian/ I've written a simpler > (and I think better) rules file, installing also scripts and > "unstable" tools and updated the recommends to fit with them, also, > only one of the patches seemed necesary (the usrlocal one). > > > I will take a look at it, thanks! I don't know if there is any policy inside Debian about packaging development branches of software, but I guess that most people would agree that is better to only package stable releases. So I wonder if once this issue with the license is completely addressed could you make a minor release to be packaged in debian? perhaps something like aircrack-ng-1.1.1 with this license issues fixed and some other fixes/features that you feel to be stable/tested enough to be used on production environments like, for example, the commits of r2008 and r2010. http://trac.aircrack-ng.org/changeset/2008 http://trac.aircrack-ng.org/changeset/2010 Thanks! -- ~~~ Carlos Alberto Lopez Perez http://neutrino.es Igalia - Free Software Engineeringhttp://www.igalia.com ~~~ signature.asc Description: OpenPGP digital signature
Bug#642934: sponsorship for aircrack-ng
Hi, Carlos Alberto Lopez Perez wrote (02 Apr 2012 15:52:53 GMT) : > On 15/02/12 16:47, David Francos wrote: >> We're almost there, don't let this stop. > Yes, seems that this issue with the license is finally being > resolved. Thanks a lot for your work :) Thanks a lot to everyone who made this happen! The Wheezy freeze is planned for June, so I guess now is the right time to make sure all this work converts to a nice aircrack-ng package being part of Debian Wheezy :) >> Also, I should say it, I'm making a package from the svn revision, >> and it's much easier to package, and has much less lintian warnings >> (if some), you can have a look at the source of the package at >> http://github.com/XayOn/Aircrack-ngDebian/ I've written a simpler >> (and I think better) rules file, installing also scripts and >> "unstable" tools and updated the recommends to fit with them, also, >> only one of the patches seemed necesary (the usrlocal one). >> > I will take a look at it, thanks! Any news from this? Is a packaging review needed? > I don't know if there is any policy inside Debian about packaging > development branches of software, None that I know of. > but I guess that most people would agree that is better to only > package stable releases. I guess most people would agree that it is *generally* better to package stable releases, but there are exceptions, and the maintainer is most of the time the best person to make the final decision call, based on their knowledge of upstream code, release timeline and processes. If SVN revision N or M is better for Debian users than the previous stable version, I would personally welcome a package built from this SVN revision into the Debian archive. > So I wonder if once this issue with the license is completely > addressed could you make a minor release to be packaged in debian? > perhaps something like aircrack-ng-1.1.1 with this license issues > fixed and some other fixes/features that you feel to be > stable/tested enough to be used on production environments like, for > example, the commits of r2008 and r2010. This would be great. David, what do you think? Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/85d36xf0lx@boum.org
Bug#642934: sponsorship for aircrack-ng
Hi! On Wed, Feb 15, 2012 at 04:47:17PM +0100, David Francos wrote: > Also, I should say it, I'm making a package from the svn revision, and > it's much easier to package, and has much less lintian warnings (if > some), you can have a look at the source of the package at > http://github.com/XayOn/Aircrack-ngDebian/ I've written a simpler > (and I think better) rules file, installing also scripts and > "unstable" tools and updated the recommends to fit with them, also, > only one of the patches seemed necesary (the usrlocal one). I tested this package but it does not work for me. It seems that you are using $(MAKE) install DESTDIR=/root/aircrack-ng-1.1/debian/aircrack-ng which seems very wrong. :-) Most likely, you want to use $$(pwd). Petr "Pasky" Baudis -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120501114121.ga2...@machine.or.cz
Bug#642934: sponsorship for aircrack-ng
2012/5/1 Petr Baudis : > Hi! > > On Wed, Feb 15, 2012 at 04:47:17PM +0100, David Francos wrote: >> Also, I should say it, I'm making a package from the svn revision, and >> it's much easier to package, and has much less lintian warnings (if >> some), you can have a look at the source of the package at >> http://github.com/XayOn/Aircrack-ngDebian/ I've written a simpler >> (and I think better) rules file, installing also scripts and >> "unstable" tools and updated the recommends to fit with them, also, >> only one of the patches seemed necesary (the usrlocal one). > > I tested this package but it does not work for me. It seems that > you are using > > $(MAKE) install DESTDIR=/root/aircrack-ng-1.1/debian/aircrack-ng > > which seems very wrong. :-) Most likely, you want to use $$(pwd). > > Petr "Pasky" Baudis Thank you, I'll fix this as soon as possible, I've been forced to leave all this behind for a while, hope to be able to catch with it soon. About the licensing, there seems to be still an issue, hope it gets resolved soon enough. I've to build a new package for my repo too... -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caey15fyzzz-f+pqgouzbr+pi5cgqaw4pw1foys+_0hmdcks...@mail.gmail.com
Bug#642934: sponsorship for aircrack-ng
On 09/11/11 17:05, Paul Wise wrote: > On Wed, 2011-11-09 at 13:27 +0100, Carlos Alberto Lopez Perez wrote: > >> I wish to take care of the aircrack-ng package if it is still possible. > > Excellent! > >> I would also like to seize this opportunity to become Debian Maintainer, >> a thing that has been in my TODO list for a long time. > > Also good :) > >> Also I would be happy of joining the Debian wireless team. > > Please register an account on alioth if you do not have one and then > click on the request to join link here: > > http://alioth.debian.org/projects/pkg-wpa > > Mention that you plan to maintain aircrack-ng within the team in your > request and that I will sponsor you whenever needed. You may want to > help them maintain wpasupplicant and other WiFi related packages. They > use SVN and presumably svn-buildpackage so you might want to take a look > at how they do that. > >> I will be happy and thankful if you can guide me through this process. > > I would be happy to. > >> What would be the first step? > > Signal your intention to package aircrack-ng. In Debian we do this by > filing bugs against the wnpp pseudo-package. wnpp is explained here: > > http://www.debian.org/devel/wnpp/ > > The bugs filed against wnpp can be seen here: > > http://bugs.debian.org/wnpp > http://wnpp.debian.net/ > > I would suggest you should reassign the removal bug (#642934) to the > wnpp pseudo-package, retitle it to an ITP bug and change the severity to > wishlist. You can find instructions for bug manipulation here: > > http://www.debian.org/Bugs/server-control > > You can CC the mail changing the bug into an ITP to debian-devel so that > more folks are likely to notice and not duplicate your work. Probably > the mail should explain why you are reintroducing aircrack-ng. > >> Create a new package for aircrack-ng fixing the licensing issue? > > Take the last version of aircrack-ng that was available in Debian and > update it to an upstream VCS snapshot that fixes the licensing issue (or > just the latest one), closing the ITP bug with something like "Re-upload > to unstable (Closes: #642934)" in the debian/changelog. A second line > should say that the update fixes the licensing issue and close that bug > too. > > The last version available in Debian is available from snapshot.d.o: > > http://snapshot.debian.org/package/aircrack-ng/1%3A1.1-1.1/ > > If you are unfamiliar with Debian packaging you will want to read this: > > http://www.debian.org/doc/manuals/maint-guide/ > > Some more links you may want to read: > > http://ftp-master.debian.org/REJECT-FAQ.html > http://www.debian.org/doc/manuals/developers-reference/ > http://www.debian.org/doc/debian-policy/ > > Re-open any bugs marked as fixed in a version that ends in +rm, if you > have JavaScript turned on, click "Toggle all extra information" at the > bottom of this page, then search the page for +rm and then reopen all > those bugs and removed the +rm fixed versions using the notfixed > command. This is unfortunately necessary because ftp-master close all > the bugs when they remove a package. It would be better if debbugs knew > a package was removed and acted appropriately, but debbugs maintenance > is not as active as it used to be. Then put closes entries in > debian/changelog for any bugs that are closed by the new upstream > snapshot. > > http://bugs.debian.org/cgi-bin/pkgreport.cgi?archive=both;src=aircrack-ng > > If you have any questions, feel free to ask me directly or (preferably) > on the #debian-mentors IRC channel or debian-mentors mailing list. I > will reply as I am able and if others reply first then that works too. > > Once you have a package ready you can send an RFS to the debian-mentors > list and I will take a look at it. > > The PTS page for aircrack-ng is here, you should keep an eye on it while > you are the maintainer and look at the links there: > > http://packages.qa.debian.org/a/aircrack-ng.html > > Please also contact upstream to tell them you are the new maintainer and > ask them about making a new release. > Hello, I have just packaged and updated a new version of aircrack-ng based on the previous one from Adam Cécile. I uploaded it to mentors.debian.net http://mentors.debian.net/package/aircrack-ng Once it enters into debian again I would re-open the bugs that were automatically closed when the package was removed Wishing to hear any comments. Regards! signature.asc Description: OpenPGP digital signature
Bug#642934: sponsorship for aircrack-ng
On 25/11/11 21:47, Carlos Alberto Lopez Perez wrote: > Hello, > > I have just packaged and updated a new version of aircrack-ng based on > the previous one from Adam Cécile. > > I uploaded it to mentors.debian.net > > http://mentors.debian.net/package/aircrack-ng > > Once it enters into debian again I would re-open the bugs that were > automatically closed when the package was removed > > Wishing to hear any comments. > > Regards! > Just a quick note to let you know that the package is signed with mi recently created 4096RSA key that you can import with: gpg --keyserver pgp.mit.edu --recv-keys 965089CE6B95F882 Or with: curl key.neutrino.es | gpg --import Then you can download the package with: dget -x http://mentors.debian.net/debian/pool/main/a/aircrack-ng/aircrack-ng_1.1-2.dsc But, as I just discovered now, dscverify will give error unless you configure it to trust your local gpg keyring by setting: DSCVERIFY_KEYRINGS=~/.gnupg/pubring.gpg on the file ~/.devscripts Regards! signature.asc Description: OpenPGP digital signature
Bug#642934: sponsorship for aircrack-ng
On Sat, 2011-11-26 at 03:02 +0100, Carlos Alberto Lopez Perez wrote: > dget -x > http://mentors.debian.net/debian/pool/main/a/aircrack-ng/aircrack-ng_1.1-2.dsc Blockers for the upload: The OpenSSL and GPL licenses are incompatible. A number of files do not have the OpenSSL exception to the GPL. This means that we cannot distribute any executables that link against OpenSSL and are also built from those files. You will need to check which executables link against OpenSSL, then check the license for all the associated source files looking for ones licensed under the GPL without the exception. Once you have done these checks, please document the results in debian/copyright. If there are any binaries that have an issue, please delete those from the package and ask upstream to fix the licenses. Non-blockers that would be nice to have fixed: You might want to adopt the machine-readable format for debian/copyright http://dep.debian.net/deps/dep5/ Please remove me from Uploaders, I only plan to sponsor you, not co-maintain the package. Please update to debhelper compat level 7 or higher. You may also want switch from a completely manual debian/rules to dh. debian/more-examples/README can be dropped from the source package since that is covered by the upstream README. debian/README.source can be dropped since you are using dpkg-source v3. There are quite a few complaints from lintian (see bottom of the mail). Please add DEP-3 headers to all of the patches: http://dep.debian.net/deps/dep3/ I note that airdrop-ng and airgraph-ng are not installed in the package. Please forward the patches upstream that haven't been forwarded yet. There are lots of compiler warnings, please notify upstream about those. Please ask upstream what the status of the next release is. As a longer-term project, please consider figuring out which of the injection patches are merged upstream, ask upstream to move those into old/, drop those from the Debian package and talk to upstream about merging the remainder into Linux mainline. lintian: I: aircrack-ng source: quilt-patch-missing-description 002-Fix_airodump-ng_manpage.diff I: aircrack-ng source: quilt-patch-missing-description 004-fix-license-sha1-sse2.diff W: aircrack-ng source: debian-rules-missing-recommended-target build-arch W: aircrack-ng source: debian-rules-missing-recommended-target build-indep P: aircrack-ng: copyright-refers-to-symlink-license usr/share/common-licenses/GPL X: aircrack-ng: duplicate-files usr/share/doc/aircrack-ng/injection-patches/ieee80211_inject.patch usr/share/doc/aircrack-ng/injection-patches/old/ieee80211_inject.patch I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airbase-ng.1.gz:40 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airbase-ng.1.gz:46 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airbase-ng.1.gz:47 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airbase-ng.1.gz:50 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airbase-ng.1.gz:53 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airbase-ng.1.gz:55 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airbase-ng.1.gz:60 I: aircrack-ng: spelling-error-in-manpage usr/share/man/man1/airbase-ng.1.gz surpresses suppresses I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airbase-ng.1.gz:78 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airbase-ng.1.gz:81 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airbase-ng.1.gz:85 I: aircrack-ng: spelling-error-in-manpage usr/share/man/man1/airbase-ng.1.gz replys replies I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airbase-ng.1.gz 7 more occurrences not shown I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/aircrack-ng.1.gz:116 I: aircrack-ng: spelling-error-in-manpage usr/share/man/man1/aireplay-ng.1.gz allows to allows one to I: aircrack-ng: spelling-error-in-manpage usr/share/man/man1/airodump-ng.1.gz Allows to Allows one to I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airodump-ng.1.gz:45 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airodump-ng.1.gz:58 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airodump-ng.1.gz:151 I: aircrack-ng: spelling-error-in-manpage usr/share/man/man1/buddy-ng.1.gz runned ran I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:7 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:9 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:15 I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:17 W: aircrack-ng: binary-without-manpage usr/sbin/airodump-ng-oui-update -- bye, pabs http://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#642934: sponsorship for aircrack-ng
On 26/11/11 04:45, Paul Wise wrote: > On Sat, 2011-11-26 at 03:02 +0100, Carlos Alberto Lopez Perez wrote: > >> dget -x >> http://mentors.debian.net/debian/pool/main/a/aircrack-ng/aircrack-ng_1.1-2.dsc > > Blockers for the upload: > > The OpenSSL and GPL licenses are incompatible. A number of files do not > have the OpenSSL exception to the GPL. This means that we cannot > distribute any executables that link against OpenSSL and are also built > from those files. You will need to check which executables link against > OpenSSL, then check the license for all the associated source files > looking for ones licensed under the GPL without the exception. Once you > have done these checks, please document the results in debian/copyright. > If there are any binaries that have an issue, please delete those from > the package and ask upstream to fix the licenses. > Thanks for notifying this (my fault for not checked it in advance). I have scanned all the source code and I found two files that are linking with OpenSSL and are GPL licensed without an exception to allow this. I have just reported it to upstream and also contacted Thomas. http://trac.aircrack-ng.org/ticket/953 > > Non-blockers that would be nice to have fixed: > > You might want to adopt the machine-readable format for debian/copyright > > http://dep.debian.net/deps/dep5/ > I will rewrite it with this format, thanks for the link ;) > Please remove me from Uploaders, I only plan to sponsor you, not > co-maintain the package. > Then.. who should put in Uploaders? me? nobody? > Please update to debhelper compat level 7 or higher. > > You may also want switch from a completely manual debian/rules to dh. > > debian/more-examples/README can be dropped from the source package since > that is covered by the upstream README. > > debian/README.source can be dropped since you are using dpkg-source v3. > > There are quite a few complaints from lintian (see bottom of the mail). > > Please add DEP-3 headers to all of the patches: > > http://dep.debian.net/deps/dep3/ > > I note that airdrop-ng and airgraph-ng are not installed in the package. > > Please forward the patches upstream that haven't been forwarded yet. > > There are lots of compiler warnings, please notify upstream about those. > > Please ask upstream what the status of the next release is. > > As a longer-term project, please consider figuring out which of the > injection patches are merged upstream, ask upstream to move those into > old/, drop those from the Debian package and talk to upstream about > merging the remainder into Linux mainline. > > lintian: > I: aircrack-ng source: quilt-patch-missing-description > 002-Fix_airodump-ng_manpage.diff > I: aircrack-ng source: quilt-patch-missing-description > 004-fix-license-sha1-sse2.diff > W: aircrack-ng source: debian-rules-missing-recommended-target build-arch > W: aircrack-ng source: debian-rules-missing-recommended-target build-indep > P: aircrack-ng: copyright-refers-to-symlink-license > usr/share/common-licenses/GPL > X: aircrack-ng: duplicate-files > usr/share/doc/aircrack-ng/injection-patches/ieee80211_inject.patch > usr/share/doc/aircrack-ng/injection-patches/old/ieee80211_inject.patch > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:40 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:46 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:47 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:50 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:53 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:55 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:60 > I: aircrack-ng: spelling-error-in-manpage usr/share/man/man1/airbase-ng.1.gz > surpresses suppresses > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:78 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:81 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:85 > I: aircrack-ng: spelling-error-in-manpage usr/share/man/man1/airbase-ng.1.gz > replys replies > I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airbase-ng.1.gz > 7 more occurrences not shown > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/aircrack-ng.1.gz:116 > I: aircrack-ng: spelling-error-in-manpage usr/share/man/man1/aireplay-ng.1.gz > allows to allows one to > I: aircrack-ng: spelling-error-in-manpage usr/share/man/man1/airodump-ng.1.gz > Allows to Allows one to > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airodump-ng.1.gz:45 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airodump-ng.1.gz:58 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airodump-ng.1.gz:151 > I: aircrack-ng: spelling-error-in-manp
Bug#642934: sponsorship for aircrack-ng
On Sat, 2011-11-26 at 21:03 +0100, Carlos Alberto Lopez Perez wrote: > Thanks for notifying this (my fault for not checked it in advance). > > I have scanned all the source code and I found two files that are > linking with OpenSSL and are GPL licensed without an exception to allow > this. > > I have just reported it to upstream and also contacted Thomas. > > http://trac.aircrack-ng.org/ticket/953 I'm surprised there were only two such files. Indeed I would expect src/sha1-sse2.S to also be one such file (it is part GPL, part public domain), but you seem to have missed that. > Then.. who should put in Uploaders? me? nobody? Just delete the line unless there is someone else who wants to help maintain the package. -- bye, pabs http://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#642934: sponsorship for aircrack-ng
On 27/11/11 03:35, Paul Wise wrote: > I'm surprised there were only two such files. Indeed I would expect > src/sha1-sse2.S to also be one such file (it is part GPL, part public > domain), but you seem to have missed that. I was not sure about src/sha1-sse2.S since it contains only assembly code and don't calls any function from libssl. But later this file is linked with libssl to build the aicrack-ng binary So I would request this file to include also this exception. Looking at all files that are linked with libssl in the build process I have just found another file that link against OpenSSL and don't have the OpenSSL exception for GPL src/common.c I would request this file also to include the exception. Thanks! Best Regards! signature.asc Description: OpenPGP digital signature
Bug#642934: sponsorship for aircrack-ng
On Sun, 2011-11-27 at 04:57 +0100, Carlos Alberto Lopez Perez wrote: > On 27/11/11 03:35, Paul Wise wrote: > > I'm surprised there were only two such files. Indeed I would expect > > src/sha1-sse2.S to also be one such file (it is part GPL, part public > > domain), but you seem to have missed that. > > I was not sure about src/sha1-sse2.S since it contains only assembly > code and don't calls any function from libssl. Anything that is either statically or dynamically linked into the same binary is considered a derivative work and therefore needs to have compatible licenses. > I would request this file also to include the exception. I see that upstream has already fixed this. Is Thomas the same person as misterx ? Also, I would like to move this outside of private email. Once you have packaged the version with the OpenSSL exceptions, please do a public RFS on debian-mentors (CC the bug) and upload to mentors.d.n as usual. -- bye, pabs http://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#642934: sponsorship for aircrack-ng
On Sat, 2011-11-26 at 11:45 +0800, Paul Wise wrote: > Non-blockers that would be nice to have fixed: cppcheck finds quite a few issues: [src/airdecloak-ng.c:1128]: (error) Memory leak: ivs_table [src/airodump-ng.c:6353]: (error) Possible null pointer dereference: ap_cur - otherwise it is redundant to check if ap_cur is null at line 6355 [src/aircrack-ng.c:323]: (error) Possible null pointer dereference: ap_cur - otherwise it is redundant to check if ap_cur is null at line 325 [src/airtun-ng.c:677]: (error) Resource leak: f [src/airbase-ng.c:1457]: (error) Resource leak: f [src/kstats.c:328]: (error) Resource leak: f [src/kstats.c:322]: (error) Memory leak: ivbuf [src/ivstools.c:168]: (error) Resource leak: f_in [src/ivstools.c:162]: (error) Resource leak: f_out [src/ivstools.c:814]: (error) Resource leak: f_in [src/aireplay-ng.c:1107]: (error) Resource leak: f_cap_out [src/aireplay-ng.c:1162]: (error) Resource leak: f [src/aircrack-ng.c:4392]: (error) Memory leak: key [src/osdep/linux.c:956]: (error) Resource leak: fd2 [src/airodump-ng.c:401]: (error) Resource leak: fp [src/osdep/linux.c:2074]: (error) Resource leak: apm [src/uniqueiv.c:117]: (error) Memory leak: uiv_lvl2 [src/tkiptun-ng.c:1326]: (error) Resource leak: f_cap_out [src/tkiptun-ng.c:1381]: (error) Resource leak: f [src/sha1-sse2.h:72]: (error) Dangerous usage of 'essid' (strncpy doesn't always 0-terminate it) [src/sha1-sse2.h:80]: (error) Dangerous usage of 'key1' (strncpy doesn't always 0-terminate it) -- bye, pabs http://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#642934: sponsorship for aircrack-ng
On 03/12/11 05:52, Paul Wise wrote: > Non-blockers that would be nice to have fixed: Reported upstream: http://trac.aircrack-ng.org/ticket/956 http://trac.aircrack-ng.org/ticket/957 signature.asc Description: OpenPGP digital signature
