[jira] Updated: (DERBY-683) Use correct encoding for ClobOutputStream on client
[ http://issues.apache.org/jira/browse/DERBY-683?page=all ] Deepa Remesh updated DERBY-683: --- Fix Version: 10.1.3.0 Derby Info: [Patch Available] To merge this fix, I have also ported the fix for DERBY-463 which is in the same area. The patch for DERBY-463 is attached to http://issues.apache.org/jira/browse/DERBY-463. This patch has to be applied before running the following merge command: svn merge -r 374468:374469 https://svn.apache.org/repos/asf/db/derby/code/trunk With the patch for DERBY-463 and the merge for DERBY-683, I verified that the attached repro passes with UTF-16 file encoding in v10.1. I also ran derbynetclientmats with Sun jdk 1.4.2 on Windows XP. Please take a look at these. Thanks. Use correct encoding for ClobOutputStream on client --- Key: DERBY-683 URL: http://issues.apache.org/jira/browse/DERBY-683 Project: Derby Type: Bug Components: Network Client Versions: 10.1.1.1, 10.1.1.0 Environment: all Reporter: Sunitha Kambhampati Assignee: Deepa Remesh Fix For: 10.2.0.0, 10.1.3.0 Attachments: DERBY-683_tstpatch3_2006_02_16.diff, DERBY-683_tstpatch3_2006_02_16.stat, ascii.txt, clob.java, derby-683.diff, derby-683_021006.diff, derby-683_021006.stat, derby-683_tests.diff, derby-683_tests.status In client, there is code in ClobOutputStream which uses this api - new String(byte[]). Per the java api http://java.sun.com/j2se/1.4.2/docs/api/java/lang/String.html#String(byte[]) ,this will construct a string by decoding the array of bytes using the platform's default character set. org.apache.derby.client.am.ClobOutputStream is used for Clob.setAsciiStream and the write methods use the String(byte[]) which is incorrect because it will use the default platform encoding. Per the jdbcapi , this should use ascii encoding. In areas related to Clobs, also check for other places where String(byte[]) is used,as it may not be the desired behavior. Dan pointed this problem here : http://issues.apache.org/jira/browse/DERBY-463?page=comments#action_12356742 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-683) Use correct encoding for ClobOutputStream on client
[ http://issues.apache.org/jira/browse/DERBY-683?page=all ] Myrna van Lunteren updated DERBY-683: - Attachment: DERBY-683_tstpatch3_2006_02_16.stat DERBY-683_tstpatch3_2006_02_16.diff Attaching an updated patch for the test harness. (DERBY-683_tstpatch03_2006_02_16.*) This is close to what was created before. Compared to deepa's original, it - skips any test run with derbyTesting.encoding if the jvm is not jdk15 - does not set file.encoding in the RunSuite thus will get set unset for every test where it applies - includes a brief mention of the property in the java/testing/READEM.htm I also took advantage of touching up the README.htm to mention with the remote server functionality that derby.jar needs to be available (although not in the classpath), and to list the junit tests as a valid test type. Use correct encoding for ClobOutputStream on client --- Key: DERBY-683 URL: http://issues.apache.org/jira/browse/DERBY-683 Project: Derby Type: Bug Components: Network Client Versions: 10.1.1.1, 10.1.1.0 Environment: all Reporter: Sunitha Kambhampati Assignee: Deepa Remesh Fix For: 10.2.0.0 Attachments: DERBY-683_tstpatch3_2006_02_16.diff, DERBY-683_tstpatch3_2006_02_16.stat, ascii.txt, clob.java, derby-683.diff, derby-683_021006.diff, derby-683_021006.stat, derby-683_tests.diff, derby-683_tests.status In client, there is code in ClobOutputStream which uses this api - new String(byte[]). Per the java api http://java.sun.com/j2se/1.4.2/docs/api/java/lang/String.html#String(byte[]) ,this will construct a string by decoding the array of bytes using the platform's default character set. org.apache.derby.client.am.ClobOutputStream is used for Clob.setAsciiStream and the write methods use the String(byte[]) which is incorrect because it will use the default platform encoding. Per the jdbcapi , this should use ascii encoding. In areas related to Clobs, also check for other places where String(byte[]) is used,as it may not be the desired behavior. Dan pointed this problem here : http://issues.apache.org/jira/browse/DERBY-463?page=comments#action_12356742 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-683) Use correct encoding for ClobOutputStream on client
[ http://issues.apache.org/jira/browse/DERBY-683?page=all ] Deepa Remesh updated DERBY-683: --- Attachment: derby-683_tests.diff derby-683_tests.status I am attaching a patch 'derby-683_tests.diff' which adds testing for this issue. The patch changes the harness to enable running tests/suites using an encoding different from the default system encoding. Background: To test DERBY-683, I wanted to run an existing test (jdbcapi/lobStreams.java) using an encoding which will have different representation for ASCII characters. I found that UTF-16 uses more number of bits and different representation for ASCII characters than the US-ASCII encoding. Also, UTF-16 is in the list of standard charsets supported by all jvms specified at http://java.sun.com/j2se/1.5.0/docs/api/java/nio/charset/Charset.html For this, I first tried using 'jvmflags' property in the test harness. Harness uses this property to launch the jvm process to run tests. So it is possible to do this only when useprocess=true. I could run the test by specifying jvmflags=-Dfile.encoding=UTF-16 in test_app.properties file. However, the test output gets written using UTF-16 encoding and it appears in strange format. To read the output, harness needs to know what encoding the test jvm used. For this, it has to parse the jvmflags, look for -Dfile.encoding=, get and store the encoding specified, launch the jvm using the encoding, and later use that encoding to read the test output. Since jvmflags property is used by harness for other purposes, I added a new property 'derbyTesting.encoding' to the harness. Harness will read this property to get the encoding and internally change jvmflags before launching the jvm to run tests. As mentioned before, all this is possible only when useprocess=true. I don't think my changes cover all the things that harness needs to support to run tests with different encodings. So I am trying to list what we can/cannot do with these changes: * Can specify the encoding in test_app.properties file and run an individual test (not as part of a suite). If the encoding property is specified for a test, it gets used only if the test is run individually using RunTest. When the test gets run as part of a suite, useprocess is set to false in RunTest and no new jvm gets launched for the test. So the encoding property won't get used. * Can specify the encoding in suite.properties file and run the whole suite of tests using that encoding. In this case, a new jvm is launched for RunTest class and all tests are run with the encoding specified. * Cannot successfully run sql tests if the encoding property is specified. The sql files will get read using the specified encoding and may not be meaningful. If the sql files always get read using fixed encoding, this will not be a problem. I think this change is planned in DERBY-658 by Myrna. * Can run tests/suites using encoding property and look for possible areas for cleanup. Once the patch is reviewed and if it is okay, I will update the testing readme file with this information. Changes: This patch does the following: * Adds a new property 'derbyTesting.encoding' to the test harness. This property can be specified as a suite in suite.properties file or as test property in test_app.properties file. If this property is set at suite level, it overrides the property set in the tests inside that suite. For this, I made changes to RunSuite.java, RunList.java and RunTest.java to read the property at each level only if it is not set at the higher level. * The patch uses the value specified in 'derbyTesting.encoding=enc_value' for two things: 1. To append to the jvmflags property used to start the child jvm process. Following is appended: -Dfile.encoding=enc_value. Currently, I have hard-coded the prefix -Dfile.encoding= in the code. In case any new jvm uses a different property name, the prefix can be specified for each jvm in the corresponding jvm class and this can be retrieved and used. 2. To read the test output: - when using RunTest, ProcessStreamResult class is used to read the output of the jvm process and write to the output file. The patch changes this class to use InputStreamReader which is created using enc_value encoding. The OutputStreamWriter which writes to .out file is created using system default encoding. This needs to use the default encoding because the harness will compare the .out file to master using default_enc. - when using RunSuite, HandleResult class is used to read the test output. The patch changes this class to use InputStreamReader which is created using enc_value encoding. * Creates a new suite encodingTests with jdbcapi/lobStreams.java in .runall file. I created a new suite because I
Re: [jira] Updated: (DERBY-683) Use correct encoding for ClobOutputStream on client
Deepa Remesh (JIRA) wrote: * Adds derbyTesting.encoding=UTF-16 to encodingTests.properties file. Adds excludes for all jvms except Sun jdk1.5. What's the reason for not running this test on other JDKs? Seems like it would run on JDK 1.3 and JDK 1.4. Dan.
Re: [jira] Updated: (DERBY-683) Use correct encoding for ClobOutputStream on client
On 2/2/06, Daniel John Debrunner [EMAIL PROTECTED] wrote: Deepa Remesh (JIRA) wrote: * Adds derbyTesting.encoding=UTF-16 to encodingTests.properties file. Adds excludes for all jvms except Sun jdk1.5. What's the reason for not running this test on other JDKs? Seems like it would run on JDK 1.3 and JDK 1.4. When I run any java program using UTF-16 encoding on jdk1.4, it is not able to read the class file itself. UTF-16 encoding is supported on this jvm but I get this exception: C:\deepa\Derby\derby_src\patches\reprosjava -Dfile.encoding=UTF-16 Encoding Exception in thread main ■ j a v a . l a n g . N o C l a s s D e f F o u n d E r r o r : Encodin I have not looked into why it is not working on jdk1.4. I had not tried earlier on jdk 1.3. I just checked now and it works with jdk 1.3. When it did'nt work with jdk1.4, I assumed it will not work on previous jdks. I'll check on other jvms and change the excludes. Thanks, Deepa
[jira] Updated: (DERBY-683) Use correct encoding for ClobOutputStream on client
[ http://issues.apache.org/jira/browse/DERBY-683?page=all ] Deepa Remesh updated DERBY-683: --- Attachment: (was: clob.java) Use correct encoding for ClobOutputStream on client --- Key: DERBY-683 URL: http://issues.apache.org/jira/browse/DERBY-683 Project: Derby Type: Bug Components: Network Client Versions: 10.1.1.1, 10.1.1.0 Environment: all Reporter: Sunitha Kambhampati Assignee: Deepa Remesh Fix For: 10.2.0.0 Attachments: ascii.txt In client, there is code in ClobOutputStream which uses this api - new String(byte[]). Per the java api http://java.sun.com/j2se/1.4.2/docs/api/java/lang/String.html#String(byte[]) ,this will construct a string by decoding the array of bytes using the platform's default character set. org.apache.derby.client.am.ClobOutputStream is used for Clob.setAsciiStream and the write methods use the String(byte[]) which is incorrect because it will use the default platform encoding. Per the jdbcapi , this should use ascii encoding. In areas related to Clobs, also check for other places where String(byte[]) is used,as it may not be the desired behavior. Dan pointed this problem here : http://issues.apache.org/jira/browse/DERBY-463?page=comments#action_12356742 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-683) Use correct encoding for ClobOutputStream on client
[ http://issues.apache.org/jira/browse/DERBY-683?page=all ] Deepa Remesh updated DERBY-683: --- Attachment: (was: derby-683-for-review.diff) Use correct encoding for ClobOutputStream on client --- Key: DERBY-683 URL: http://issues.apache.org/jira/browse/DERBY-683 Project: Derby Type: Bug Components: Network Client Versions: 10.1.1.1, 10.1.1.0 Environment: all Reporter: Sunitha Kambhampati Assignee: Deepa Remesh Fix For: 10.2.0.0 Attachments: ascii.txt In client, there is code in ClobOutputStream which uses this api - new String(byte[]). Per the java api http://java.sun.com/j2se/1.4.2/docs/api/java/lang/String.html#String(byte[]) ,this will construct a string by decoding the array of bytes using the platform's default character set. org.apache.derby.client.am.ClobOutputStream is used for Clob.setAsciiStream and the write methods use the String(byte[]) which is incorrect because it will use the default platform encoding. Per the jdbcapi , this should use ascii encoding. In areas related to Clobs, also check for other places where String(byte[]) is used,as it may not be the desired behavior. Dan pointed this problem here : http://issues.apache.org/jira/browse/DERBY-463?page=comments#action_12356742 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-683) Use correct encoding for ClobOutputStream on client
[ http://issues.apache.org/jira/browse/DERBY-683?page=all ] Deepa Remesh updated DERBY-683: --- Attachment: derby-683.diff clob.java Attaching a patch 'derby-683.diff'. The write methods in ClobOutputStream were using default encoding when constructing a String from bytes. ClobOutputStream is the output stream returned by call to Clob.setAsciiStream. This is meant to be a stream to which ascii encoded characters can be written. So the writes to this stream should not be using default encoding. This patch changes the write methods to use String constructors with ascii encoding. Currently, I have a repro to test this. I am working on adding a test to the harness. This requires some changes to the test harness and I would like to submit this as a separate patch. To test this using the repro, run the following command on Windows with Sun JDK1.5: java -Dfile.encoding=UTF-16 -Doutput.encoding=Cp1252 clob With this patch, I have run derbyall on Windows with Sun JDK 1.4.2. No failures. It would be good if someone can look at this patch and commit the code changes if they are okay. I will submit the harness changes and a test in a separate patch. Use correct encoding for ClobOutputStream on client --- Key: DERBY-683 URL: http://issues.apache.org/jira/browse/DERBY-683 Project: Derby Type: Bug Components: Network Client Versions: 10.1.1.1, 10.1.1.0 Environment: all Reporter: Sunitha Kambhampati Assignee: Deepa Remesh Fix For: 10.2.0.0 Attachments: ascii.txt, clob.java, derby-683.diff In client, there is code in ClobOutputStream which uses this api - new String(byte[]). Per the java api http://java.sun.com/j2se/1.4.2/docs/api/java/lang/String.html#String(byte[]) ,this will construct a string by decoding the array of bytes using the platform's default character set. org.apache.derby.client.am.ClobOutputStream is used for Clob.setAsciiStream and the write methods use the String(byte[]) which is incorrect because it will use the default platform encoding. Per the jdbcapi , this should use ascii encoding. In areas related to Clobs, also check for other places where String(byte[]) is used,as it may not be the desired behavior. Dan pointed this problem here : http://issues.apache.org/jira/browse/DERBY-463?page=comments#action_12356742 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-683) Use correct encoding for ClobOutputStream on client
[ http://issues.apache.org/jira/browse/DERBY-683?page=all ] Deepa Remesh updated DERBY-683: --- Attachment: derby-683-for-review.diff clob.java ascii.txt The patch for this seems to be a small change but I am having trouble adding a test for this. I have been trying for some time to write a test for verifying that ascii encoding gets used when writing with OutputStream returned by Clob.setAsciiStream. I do not know how to add a test which can run with the test harness because the test will need to set the property file.encoding. I have been able to verify my changes using a java program which uses a test in jdbcapi/lobStreams.java. I am attaching the repro program and my patch (not ready for commit) to this JIRA. To run the repro, 1. Start network server on port . 2. Using Sun JDK1.5, run: java -Dfile.encoding=UTF-16 clob Output without my patch: S t a r t t e s t C l o b W r i t e 3 P a r a m F A I L - - w r o n g c l o b l e n g t h ; o r i g i n a l : 9 4 c l o b l e n g t h : 4 7 t e s t C l o b W r i t e 3 P a r a m f i n i s h e d Output with my patch: S t a r t t e s t C l o b W r i t e 3 P a r a m C o m p a r i n g f i l e a n d c l o b T e s t 3 - P A S S - C l o b a n d f i l e c o n t e n t s m a t c h t e s t C l o b W r i t e 3 P a r a m f i n i s h e d The output of the repro is not in a very good format as you can see above but this is the only charset I could find to repro this problem on my Windows machine. I have a few questions and I'd appreciate if someone can answer them. 1. Does my test cover the problem described in the JIRA? 2. Is there some other charset I can use instead of UTF-16? I need a charset which will have different encoding for any ascii character than the ASCII encoding? I am using a Windows machine. To add to test harness, we will need a charset which is available on all platforms. 3. How can I run this repro as a test inside the test harness? Test harness seems to treat file.encoding property differently and I see RunTest using it to set derby.ui.codeset. In my repro, I tried using System.setProperty(file.encoding, UTF-16); but that did not work. Only command-line -Dfile.encoding works. 4. Is there some other way to test this? Maybe there is another way to test this and then rest of my questions are invalid. I'd appreciate help in this. Thanks. Use correct encoding for ClobOutputStream on client --- Key: DERBY-683 URL: http://issues.apache.org/jira/browse/DERBY-683 Project: Derby Type: Bug Components: Network Client Versions: 10.1.1.1, 10.1.1.0 Environment: all Reporter: Sunitha Kambhampati Assignee: Deepa Remesh Fix For: 10.2.0.0 Attachments: ascii.txt, clob.java, derby-683-for-review.diff In client, there is code in ClobOutputStream which uses this api - new String(byte[]). Per the java api http://java.sun.com/j2se/1.4.2/docs/api/java/lang/String.html#String(byte[]) ,this will construct a string by decoding the array of bytes using the platform's default character set. org.apache.derby.client.am.ClobOutputStream is used for Clob.setAsciiStream and the write methods use the String(byte[]) which is incorrect because it will use the default platform encoding. Per the jdbcapi , this should use ascii encoding. In areas related to Clobs, also check for other places where String(byte[]) is used,as it may not be the desired behavior. Dan pointed this problem here : http://issues.apache.org/jira/browse/DERBY-463?page=comments#action_12356742 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
