Re: 551 JIRA Tickets Over 2 Years Old
+1 to using Won't Fix. Won't can mean won't anytime soon. Labeling as someday or wishlist or something sounds great to me. The tickets remain in JIRA, so they can be resurrected if we change our minds or if an eager contributor comes along. Nothing is lost. I'll look into getting our ASF wiki space established if no one is doing so already. This isn't the only time it's been proposed for use lately. Thanks to David and everybody doing the spring cleaning. On Mon, Apr 21, 2014 at 1:07 AM, Sean Busbey bus...@cloudera.com wrote: What do we want Jira to represent? I prefer it when projects use Jira as a work queue. If a feature request hasn't gotten interest in 2 years, it's very unlikely it will suddenly jump to the top of our priority list. I'm all for suggesting that requestors work on a patch and offering feedback to guide them. But if there isn't someone willing to do the work, the ticket is effectively wontfix. We should make sure there's a comment that explains that we're open to a feature if someone comes forward to do the work. We could also add a label so it's easier for the interested to find them. There is a cost to keeping these defunct tickets around. Old, untended tickets discourage new participants. They make us look unresponsive and they represent noise for those trying to look at what's going on. We do need a place for ideas we find interesting but don't have resources to handle yet. Many projects request that feature requests start on the mailing list to gauge interest. We could just do that, though the mail archive is neither super easy to search nor a convenient point of reference. Maybe this would be a good use of our ASF wiki space? On Sat, Apr 19, 2014 at 3:50 PM, Corey Nolet cjno...@gmail.com wrote: I agree. Are those tickets really getting in the way? Maybe they could be labeled differently to separate them from tech debt, bugs, and other active features? On Apr 19, 2014 3:51 PM, John Vines vi...@apache.org wrote: Won't fix isn't accurate though. We're not saying we will reject work on them, they're just not a high priority. On Sat, Apr 19, 2014 at 3:03 PM, Christopher ctubb...@apache.org wrote: Resolving them as Won't Fix seems valid to me, if the fact that a ticket is open helps us track/manage outstanding work. (The obvious question, then, is does it help in some way?). They can always be re-opened if we decide it's worth doing. -- Christopher L Tubbs II http://gravatar.com/ctubbsii On Sat, Apr 19, 2014 at 1:05 PM, John Vines vi...@apache.org wrote: Just because they're old doesn't make them invalid. They're just at a lower priority. Closing them for the sake of closing them seems like a bad idea. But if they're actually invalid now, that's an entirely different notion. Sent from my phone, please pardon the typos and brevity. On Apr 19, 2014 12:42 PM, David Medinets david.medin...@gmail.com wrote: ACCUMULO-483 https://issues.apache.org/jira/browse/ACCUMULO-483 , for example, involves creating a purge locality utility. However, there have been no comments since Oct 2012. If the feature has not risen in priority since then, how will it become more important in the future. Perhaps a 'good ideas' page or 'roadmap' page could be added to http://accumulo.apache.org/? I don't see a benefit to keeping these old tickets. On Sat, Apr 19, 2014 at 10:11 AM, Corey Nolet cjno...@gmail.com wrote: Some of these tickets still look like very valid feature/integration requests that would still be reasonable to have. See ACCUMULO-74, ACCUMULO-143, ACCUMULO-136, ACCUMULO-211, ACCUMULO-483, ACCUMULO-490, ACCUMULO-508 On Sat, Apr 19, 2014 at 9:54 AM, Mike Drob md...@mdrob.com wrote: Deleting tickets is a no-no, but flagging them is certainly fine. On Apr 19, 2014 12:03 AM, David Medinets david.medin...@gmail.com wrote: Opps. Sorry, I did my filtering badly. There are 68 tickets over 2 years old. https://issues.apache.org/jira/browse/ACCUMULO-18?jql=project%20%3D%20ACCUMULO%20AND%20status%20in%20%28Open%2C%20%22In%20Progress%22%2C%20Reopened%2C%20%22Patch%20Available%22%29%20AND%20created%20%3C%3D%20-104w%20ORDER%20BY%20key%20ASC On Sat, Apr 19, 2014 at 12:01 AM, David Medinets david.medin...@gmail.comwrote: https://issues.apache.org/jira/browse/ACCUMULO-551?jql=project%20%3D%20ACCUMULO%20AND%20created%20%3C%3D%20-104w%20ORDER%20BY%20key%20DESC Is there a technique we can use to curate old tickets? Would anyone mind if I review them
Re: [VOTE] Accumulo Blog
Sure thing! It doesn't appear that you have a blog account, so you need to file an INFRA ticket with your Apache ID and requesting access to the Accumulo blog. I'll make sure you're on the admin list after it's done. http://www.apache.org/dev/project-blogs#blogusers Bill H On Fri, Apr 18, 2014 at 6:43 PM, Corey Nolet cjno...@gmail.com wrote: I'd like initial posting privileges. Thanks for setting this up! On Apr 18, 2014 11:23 AM, Bill Havanki bhava...@clouderagovt.com wrote: Sure thing Dave, happy to. We need to determine an initial list of people with posting privileges. I'll start with Dave and myself. If any other PMC member wants in, just let me know by COB eastern time, and I'll add you to the infra ticket to establish the blog. Don't worry if you miss out, another infra ticket is all it takes to get added. (Or, maybe, if you already have a blog account, we can add you.) Bill H On Thu, Apr 17, 2014 at 12:27 PM, dlmar...@comcast.net wrote: This vote passes with eight +1 votes (5 binding, 3 non-binding) and one +0 vote. Bill H - I think you volunteered to help with the setup. The instructions are located at http://www.apache.org/dev/project-blogs . If you are unable to do this let me know. Thanks, Dave - Original Message - From: dlmar...@comcast.net To: dev@accumulo.apache.org Sent: Sunday, April 13, 2014 8:11:07 PM Subject: [VOTE] Accumulo Blog I have reviewed the feedback from the proposal thread and consolidated it into a set of guidelines for an Accumulo Blog. In accordance with the bylaws this vote will require Lazy Approval to pass and will remain open for 3 business days. I'll tally the votes on Thursday morning. 1. The blog will be hosted on the Apache Blogs site[1]. 2. The blog will be set up using the instructions at [2] to enable public preview. 3. Proposed blog content will be posted in full-text or link form to the dev mailing list. 4. Blog content requires Lazy Approval votes that are open for at least 3 days. 5. Content may be cross-posted from other sites provided that the content is more than just a link to the other site. The full text of the original article is preferred. 6. Content may be cross-posted to other sites provided that there is a link back to the Accumulo blog site. [1] http://blogs.apache.org/ [2] http://www.apache.org/dev/project-blogs -- // Bill Havanki // Solutions Architect, Cloudera Govt Solutions // 443.686.9283 -- // Bill Havanki // Solutions Architect, Cloudera Govt Solutions // 443.686.9283
Re: increasing balancing problems to WARN
Can you elaborate a bit more on this, Bill? On Sat, Apr 19, 2014 at 12:03 AM, William Slacum wilhelm.von.cl...@accumulo.net wrote: We could consider the use of markers to throw in more metadata about the relevance of a particular log message. On Fri, Apr 18, 2014 at 10:46 PM, Sean Busbey bus...@cloudera.com wrote: I also try to limit what goes at higher warning levels. One of my goals over hte next few months is to improve our current logging. It sounds like this is a good time to make sure we're on the same page. We're going to have to train users on something (esp since our currently logging is very noisy). The short version I like is Info and more severe are for operators; info and less severe are for developers. Here's what I usually use as a guideline (constrained to slf4j levels): = ERROR Something is wrong and an operator needs to do something, preferably very soon. In other words, if I was on call I'd expect to get paged. = WARN Something is amiss, but not of immediate concern. An operator who is on call but not busy at the moment might want to investigate some kind of underlying issue, but the system will continue to function within some reasonable bound. = INFO Summary information about normal operations that is safe to ignore. GC information, throughput stats, that kind of thing. = DEBUG Low level information that is not normally useful, but will help determine the cause of a system malfunction. Usually something a developer or tier 3 supporter would want when something was going wrong (e.g. stack traces). = TRACE Detailed low level information at a volume that probably can't be gathered in production. Eric, do those all sound reasonable? I want to make sure we have a common basis before I get into the specifics of this case. -Sean On Fri, Apr 18, 2014 at 8:21 PM, Eric Newton eric.new...@gmail.com wrote: -1 I would hesitate to put *any* message at WARN. It is normal for balancing to take a little while, especially for some of my users who have their own balancing algorithm. Users feel the need to fix the problem; after all, it's there in big scary yellow on the monitor page. I don't like training users to ignore scary yellow. Is it a problem, or not? Alternatively, put the balance info into the master status, and display it. Like GC collection time... hey, I've been migrating these tablets for a long time... turn yellow/red. -Eric On Fri, Apr 18, 2014 at 4:03 PM, Sean Busbey bus...@cloudera.com wrote: At the moment all of our logs about problems balancing are at DEBUG. Given the impact to a cluster when this happens (skewing load onto few servers, in some case severely), I'd like to raise it to WARN so that it surfaces for operators in the Monitor and in the non-debug log. Thought I'd do a quick lazy consensus check before filing a jira and taking care of it. -- Sean -- Sean
Re: increasing balancing problems to WARN
Eric, do those all sound reasonable? I want to make sure we have a common basis before I get into the specifics of this case. Yes, this is a reasonable list. Do I seem so disagreeable that this was necessary? To be clear, I am against raising the log message Did not balance because a tablet was offline to warning. I am for raising the message Balancer has not run for the last 30 minutes to warning, except that it does not exist. Let us not have a silly email discussion on log levels, or I will start a fascinating discussion on the placement of braces and the use of whitespace. From now on, this threat shall be known as EricsRule#0:JustBuildStuff. Please feel empowered to make whatever change you like, regardless of my thoughts. I trust you. -Eric
Re: Review Request 20467: ACCUMULO-2654 updates for 1.6 branch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20467/#review40878 --- Ship it! I'm not an expert in this area, but I don't see any problems. So this is more like a +0. - Bill Havanki On April 17, 2014, 5:45 p.m., Sean Busbey wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20467/ --- (Updated April 17, 2014, 5:45 p.m.) Review request for accumulo and kturner. Bugs: ACCUMULO-2654 https://issues.apache.org/jira/browse/ACCUMULO-2654 Repository: accumulo Description --- Results of merging 1.5.2-SNAPSHOT version forward to 1.6.0-SNAPSHOT (involved some package / class changes for information about e.g. compression algos) and then updating the functional test to be an IT. Main review here is of the IT version of hte test. Diffs - core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java b361413 core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java 66ca07f test/src/test/java/org/apache/accumulo/test/functional/ReadWriteIT.java cb803f8 test/src/test/java/org/apache/accumulo/test/functional/RecoveryWithEmptyRFileIT.java PRE-CREATION Diff: https://reviews.apache.org/r/20467/diff/ Testing --- ran through IT again. tested creating files on real cluster. Thanks, Sean Busbey
Re: Review Request 20422: ACCUMULO-1834 - Review Board guidelines
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20422/ --- (Updated April 21, 2014, 10:50 a.m.) Review request for accumulo. Changes --- Incorporated most (not all) feedback from first draft. Issue on how to form diffs / patches remains. Bugs: ACCUMULO-1834 https://issues.apache.org/jira/browse/ACCUMULO-1834 Repository: accumulo Description --- A proposed set of guidelines for using Review Board, in deference to our recently-approved and improved bylaws. Diffs (updated) - docs/src/main/resources/RB.md PRE-CREATION Diff: https://reviews.apache.org/r/20422/diff/ Testing --- Thanks, Bill Havanki
Re: Review Request 20422: ACCUMULO-1834 - Review Board guidelines
On April 16, 2014, 2:24 p.m., Christopher Tubbs wrote: docs/src/main/resources/RB.md, line 39 https://reviews.apache.org/r/20422/diff/1/?file=561011#file561011line39 A link to the Review in RB should also be added to the JIRA issue (More - Link - Web Link), to help visitors to the JIRA find the current review progress. Sean Busbey wrote: better to add the parenthetical to the final bullet point, where it says to add a link to the RB on the jira? Christopher Tubbs wrote: Yes, that makes sense. Also, my wording is a bit rough, and could probably be polished a bit, depending on where it lands. I made the final bullet point its own paragraph, since it doesn't pertain directly to using RB, but JIRA, and I incorporated some of Christopher's verbiage and the parenthetical there. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20422/#review40583 --- On April 21, 2014, 10:50 a.m., Bill Havanki wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20422/ --- (Updated April 21, 2014, 10:50 a.m.) Review request for accumulo. Bugs: ACCUMULO-1834 https://issues.apache.org/jira/browse/ACCUMULO-1834 Repository: accumulo Description --- A proposed set of guidelines for using Review Board, in deference to our recently-approved and improved bylaws. Diffs - docs/src/main/resources/RB.md PRE-CREATION Diff: https://reviews.apache.org/r/20422/diff/ Testing --- Thanks, Bill Havanki
Re: 551 JIRA Tickets Over 2 Years Old
what about just changing them from being improvements to wishes? On Mon, Apr 21, 2014 at 9:26 AM, Bill Havanki bhava...@clouderagovt.comwrote: +1 to using Won't Fix. Won't can mean won't anytime soon. Labeling as someday or wishlist or something sounds great to me. The tickets remain in JIRA, so they can be resurrected if we change our minds or if an eager contributor comes along. Nothing is lost. I'll look into getting our ASF wiki space established if no one is doing so already. This isn't the only time it's been proposed for use lately. Thanks to David and everybody doing the spring cleaning. On Mon, Apr 21, 2014 at 1:07 AM, Sean Busbey bus...@cloudera.com wrote: What do we want Jira to represent? I prefer it when projects use Jira as a work queue. If a feature request hasn't gotten interest in 2 years, it's very unlikely it will suddenly jump to the top of our priority list. I'm all for suggesting that requestors work on a patch and offering feedback to guide them. But if there isn't someone willing to do the work, the ticket is effectively wontfix. We should make sure there's a comment that explains that we're open to a feature if someone comes forward to do the work. We could also add a label so it's easier for the interested to find them. There is a cost to keeping these defunct tickets around. Old, untended tickets discourage new participants. They make us look unresponsive and they represent noise for those trying to look at what's going on. We do need a place for ideas we find interesting but don't have resources to handle yet. Many projects request that feature requests start on the mailing list to gauge interest. We could just do that, though the mail archive is neither super easy to search nor a convenient point of reference. Maybe this would be a good use of our ASF wiki space? On Sat, Apr 19, 2014 at 3:50 PM, Corey Nolet cjno...@gmail.com wrote: I agree. Are those tickets really getting in the way? Maybe they could be labeled differently to separate them from tech debt, bugs, and other active features? On Apr 19, 2014 3:51 PM, John Vines vi...@apache.org wrote: Won't fix isn't accurate though. We're not saying we will reject work on them, they're just not a high priority. On Sat, Apr 19, 2014 at 3:03 PM, Christopher ctubb...@apache.org wrote: Resolving them as Won't Fix seems valid to me, if the fact that a ticket is open helps us track/manage outstanding work. (The obvious question, then, is does it help in some way?). They can always be re-opened if we decide it's worth doing. -- Christopher L Tubbs II http://gravatar.com/ctubbsii On Sat, Apr 19, 2014 at 1:05 PM, John Vines vi...@apache.org wrote: Just because they're old doesn't make them invalid. They're just at a lower priority. Closing them for the sake of closing them seems like a bad idea. But if they're actually invalid now, that's an entirely different notion. Sent from my phone, please pardon the typos and brevity. On Apr 19, 2014 12:42 PM, David Medinets david.medin...@gmail.com wrote: ACCUMULO-483 https://issues.apache.org/jira/browse/ACCUMULO-483 , for example, involves creating a purge locality utility. However, there have been no comments since Oct 2012. If the feature has not risen in priority since then, how will it become more important in the future. Perhaps a 'good ideas' page or 'roadmap' page could be added to http://accumulo.apache.org/? I don't see a benefit to keeping these old tickets. On Sat, Apr 19, 2014 at 10:11 AM, Corey Nolet cjno...@gmail.com wrote: Some of these tickets still look like very valid feature/integration requests that would still be reasonable to have. See ACCUMULO-74, ACCUMULO-143, ACCUMULO-136, ACCUMULO-211, ACCUMULO-483, ACCUMULO-490, ACCUMULO-508 On Sat, Apr 19, 2014 at 9:54 AM, Mike Drob md...@mdrob.com wrote: Deleting tickets is a no-no, but flagging them is certainly fine. On Apr 19, 2014 12:03 AM, David Medinets david.medin...@gmail.com wrote: Opps. Sorry, I did my filtering badly. There are 68 tickets over 2 years old. https://issues.apache.org/jira/browse/ACCUMULO-18?jql=project%20%3D%20ACCUMULO%20AND%20status%20in%20%28Open%2C%20%22In%20Progress%22%2C%20Reopened%2C%20%22Patch%20Available%22%29%20AND%20created%20%3C%3D%20-104w%20ORDER%20BY%20key%20ASC On Sat, Apr 19, 2014 at 12:01 AM, David Medinets david.medin...@gmail.comwrote:
Re: 551 JIRA Tickets Over 2 Years Old
+1 On Apr 21, 2014 11:47 AM, John Vines vi...@apache.org wrote: what about just changing them from being improvements to wishes? On Mon, Apr 21, 2014 at 9:26 AM, Bill Havanki bhava...@clouderagovt.com wrote: +1 to using Won't Fix. Won't can mean won't anytime soon. Labeling as someday or wishlist or something sounds great to me. The tickets remain in JIRA, so they can be resurrected if we change our minds or if an eager contributor comes along. Nothing is lost. I'll look into getting our ASF wiki space established if no one is doing so already. This isn't the only time it's been proposed for use lately. Thanks to David and everybody doing the spring cleaning. On Mon, Apr 21, 2014 at 1:07 AM, Sean Busbey bus...@cloudera.com wrote: What do we want Jira to represent? I prefer it when projects use Jira as a work queue. If a feature request hasn't gotten interest in 2 years, it's very unlikely it will suddenly jump to the top of our priority list. I'm all for suggesting that requestors work on a patch and offering feedback to guide them. But if there isn't someone willing to do the work, the ticket is effectively wontfix. We should make sure there's a comment that explains that we're open to a feature if someone comes forward to do the work. We could also add a label so it's easier for the interested to find them. There is a cost to keeping these defunct tickets around. Old, untended tickets discourage new participants. They make us look unresponsive and they represent noise for those trying to look at what's going on. We do need a place for ideas we find interesting but don't have resources to handle yet. Many projects request that feature requests start on the mailing list to gauge interest. We could just do that, though the mail archive is neither super easy to search nor a convenient point of reference. Maybe this would be a good use of our ASF wiki space? On Sat, Apr 19, 2014 at 3:50 PM, Corey Nolet cjno...@gmail.com wrote: I agree. Are those tickets really getting in the way? Maybe they could be labeled differently to separate them from tech debt, bugs, and other active features? On Apr 19, 2014 3:51 PM, John Vines vi...@apache.org wrote: Won't fix isn't accurate though. We're not saying we will reject work on them, they're just not a high priority. On Sat, Apr 19, 2014 at 3:03 PM, Christopher ctubb...@apache.org wrote: Resolving them as Won't Fix seems valid to me, if the fact that a ticket is open helps us track/manage outstanding work. (The obvious question, then, is does it help in some way?). They can always be re-opened if we decide it's worth doing. -- Christopher L Tubbs II http://gravatar.com/ctubbsii On Sat, Apr 19, 2014 at 1:05 PM, John Vines vi...@apache.org wrote: Just because they're old doesn't make them invalid. They're just at a lower priority. Closing them for the sake of closing them seems like a bad idea. But if they're actually invalid now, that's an entirely different notion. Sent from my phone, please pardon the typos and brevity. On Apr 19, 2014 12:42 PM, David Medinets david.medin...@gmail.com wrote: ACCUMULO-483 https://issues.apache.org/jira/browse/ACCUMULO-483 , for example, involves creating a purge locality utility. However, there have been no comments since Oct 2012. If the feature has not risen in priority since then, how will it become more important in the future. Perhaps a 'good ideas' page or 'roadmap' page could be added to http://accumulo.apache.org/? I don't see a benefit to keeping these old tickets. On Sat, Apr 19, 2014 at 10:11 AM, Corey Nolet cjno...@gmail.com wrote: Some of these tickets still look like very valid feature/integration requests that would still be reasonable to have. See ACCUMULO-74, ACCUMULO-143, ACCUMULO-136, ACCUMULO-211, ACCUMULO-483, ACCUMULO-490, ACCUMULO-508 On Sat, Apr 19, 2014 at 9:54 AM, Mike Drob md...@mdrob.com wrote: Deleting tickets is a no-no, but flagging them is certainly fine. On Apr 19, 2014 12:03 AM, David Medinets david.medin...@gmail.com wrote: Opps. Sorry, I did my filtering badly. There are 68 tickets over 2 years old.
Re: 551 JIRA Tickets Over 2 Years Old
+1 I thought proposal would be good enough to convey the message. Wont fix is confusing and I could see possible contributors being starred away by it. On Apr 21, 2014 1:04 PM, cjno...@gmail.com wrote: +1 On Apr 21, 2014 11:47 AM, John Vines vi...@apache.org wrote: what about just changing them from being improvements to wishes? On Mon, Apr 21, 2014 at 9:26 AM, Bill Havanki bhava...@clouderagovt.com wrote: +1 to using Won't Fix. Won't can mean won't anytime soon. Labeling as someday or wishlist or something sounds great to me. The tickets remain in JIRA, so they can be resurrected if we change our minds or if an eager contributor comes along. Nothing is lost. I'll look into getting our ASF wiki space established if no one is doing so already. This isn't the only time it's been proposed for use lately. Thanks to David and everybody doing the spring cleaning. On Mon, Apr 21, 2014 at 1:07 AM, Sean Busbey bus...@cloudera.com wrote: What do we want Jira to represent? I prefer it when projects use Jira as a work queue. If a feature request hasn't gotten interest in 2 years, it's very unlikely it will suddenly jump to the top of our priority list. I'm all for suggesting that requestors work on a patch and offering feedback to guide them. But if there isn't someone willing to do the work, the ticket is effectively wontfix. We should make sure there's a comment that explains that we're open to a feature if someone comes forward to do the work. We could also add a label so it's easier for the interested to find them. There is a cost to keeping these defunct tickets around. Old, untended tickets discourage new participants. They make us look unresponsive and they represent noise for those trying to look at what's going on. We do need a place for ideas we find interesting but don't have resources to handle yet. Many projects request that feature requests start on the mailing list to gauge interest. We could just do that, though the mail archive is neither super easy to search nor a convenient point of reference. Maybe this would be a good use of our ASF wiki space? On Sat, Apr 19, 2014 at 3:50 PM, Corey Nolet cjno...@gmail.com wrote: I agree. Are those tickets really getting in the way? Maybe they could be labeled differently to separate them from tech debt, bugs, and other active features? On Apr 19, 2014 3:51 PM, John Vines vi...@apache.org wrote: Won't fix isn't accurate though. We're not saying we will reject work on them, they're just not a high priority. On Sat, Apr 19, 2014 at 3:03 PM, Christopher ctubb...@apache.org wrote: Resolving them as Won't Fix seems valid to me, if the fact that a ticket is open helps us track/manage outstanding work. (The obvious question, then, is does it help in some way?). They can always be re-opened if we decide it's worth doing. -- Christopher L Tubbs II http://gravatar.com/ctubbsii On Sat, Apr 19, 2014 at 1:05 PM, John Vines vi...@apache.org wrote: Just because they're old doesn't make them invalid. They're just at a lower priority. Closing them for the sake of closing them seems like a bad idea. But if they're actually invalid now, that's an entirely different notion. Sent from my phone, please pardon the typos and brevity. On Apr 19, 2014 12:42 PM, David Medinets david.medin...@gmail.com wrote: ACCUMULO-483 https://issues.apache.org/jira/browse/ACCUMULO-483 , for example, involves creating a purge locality utility. However, there have been no comments since Oct 2012. If the feature has not risen in priority since then, how will it become more important in the future. Perhaps a 'good ideas' page or 'roadmap' page could be added to http://accumulo.apache.org/? I don't see a benefit to keeping these old tickets. On Sat, Apr 19, 2014 at 10:11 AM, Corey Nolet cjno...@gmail.com wrote: Some of these tickets still look like very valid feature/integration requests that would still be reasonable to have. See ACCUMULO-74, ACCUMULO-143, ACCUMULO-136, ACCUMULO-211, ACCUMULO-483, ACCUMULO-490, ACCUMULO-508 On Sat, Apr 19, 2014 at 9:54 AM, Mike Drob md...@mdrob.com wrote: Deleting tickets is a no-no, but flagging them is certainly fine. On Apr 19, 2014 12:03 AM, David Medinets david.medin...@gmail.com wrote: Opps. Sorry, I did my filtering badly. There are 68 tickets over 2 years old.
Re: 551 JIRA Tickets Over 2 Years Old
On Mon, Apr 21, 2014 at 12:07 PM, Corey Nolet cjno...@gmail.com wrote: +1 I thought proposal would be good enough to convey the message. Wont fix is confusing and I could see possible contributors being starred away by it. What about with a final comment that says something like: Unfortunately, we don't have any spare cycles to handle an implementation for this request. If anyone would like to take on championing this feature, please reopen the ticket and ask to have it assigned to you. Even then you think the won't fix label will scare them away? What about closing them incomplete? -- Sean
Re: 551 JIRA Tickets Over 2 Years Old
Perhaps (hence my caveat with regard to whether the fact of a ticket being open is problematic). Since it's reversible, Won't Fix can easily be interpreted as Won't Fix at this time. It could always be reopened, if we decide there's more value in not having open tickets. To avoid possibly deterring volunteers, we could easily document why we won't fix (eg. Won't Fix, low priority, little interest; reopen if interest resurges). -- Christopher L Tubbs II http://gravatar.com/ctubbsii On Sat, Apr 19, 2014 at 3:51 PM, John Vines vi...@apache.org wrote: Won't fix isn't accurate though. We're not saying we will reject work on them, they're just not a high priority. On Sat, Apr 19, 2014 at 3:03 PM, Christopher ctubb...@apache.org wrote: Resolving them as Won't Fix seems valid to me, if the fact that a ticket is open helps us track/manage outstanding work. (The obvious question, then, is does it help in some way?). They can always be re-opened if we decide it's worth doing. -- Christopher L Tubbs II http://gravatar.com/ctubbsii On Sat, Apr 19, 2014 at 1:05 PM, John Vines vi...@apache.org wrote: Just because they're old doesn't make them invalid. They're just at a lower priority. Closing them for the sake of closing them seems like a bad idea. But if they're actually invalid now, that's an entirely different notion. Sent from my phone, please pardon the typos and brevity. On Apr 19, 2014 12:42 PM, David Medinets david.medin...@gmail.com wrote: ACCUMULO-483 https://issues.apache.org/jira/browse/ACCUMULO-483, for example, involves creating a purge locality utility. However, there have been no comments since Oct 2012. If the feature has not risen in priority since then, how will it become more important in the future. Perhaps a 'good ideas' page or 'roadmap' page could be added to http://accumulo.apache.org/? I don't see a benefit to keeping these old tickets. On Sat, Apr 19, 2014 at 10:11 AM, Corey Nolet cjno...@gmail.com wrote: Some of these tickets still look like very valid feature/integration requests that would still be reasonable to have. See ACCUMULO-74, ACCUMULO-143, ACCUMULO-136, ACCUMULO-211, ACCUMULO-483, ACCUMULO-490, ACCUMULO-508 On Sat, Apr 19, 2014 at 9:54 AM, Mike Drob md...@mdrob.com wrote: Deleting tickets is a no-no, but flagging them is certainly fine. On Apr 19, 2014 12:03 AM, David Medinets david.medin...@gmail.com wrote: Opps. Sorry, I did my filtering badly. There are 68 tickets over 2 years old. https://issues.apache.org/jira/browse/ACCUMULO-18?jql=project%20%3D%20ACCUMULO%20AND%20status%20in%20%28Open%2C%20%22In%20Progress%22%2C%20Reopened%2C%20%22Patch%20Available%22%29%20AND%20created%20%3C%3D%20-104w%20ORDER%20BY%20key%20ASC On Sat, Apr 19, 2014 at 12:01 AM, David Medinets david.medin...@gmail.comwrote: https://issues.apache.org/jira/browse/ACCUMULO-551?jql=project%20%3D%20ACCUMULO%20AND%20created%20%3C%3D%20-104w%20ORDER%20BY%20key%20DESC Is there a technique we can use to curate old tickets? Would anyone mind if I review them and nominate tickets for closure? I can add a message and delete any tickets that don't provoke a response. How useful are tickets that are two years old?
Review Request 20523: Initial refactoring, just structural updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/ --- Review request for accumulo, Bill Havanki and kturner. Bugs: ACCUMULO-2041 https://issues.apache.org/jira/browse/ACCUMULO-2041 Repository: accumulo Description --- Initial refactoring of tablet. Extract inner classes, make members private and final as much as possible, group tablet-related classes into o.a.a.tserver.tablet. Diffs - server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionStats.java d359e95 server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionWatcher.java 2e4d7b7 server/tserver/src/main/java/org/apache/accumulo/tserver/Compactor.java 822171c server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java e8958b1 server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java dc36718 server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactionReason.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactor.java b2e84e5 server/tserver/src/main/java/org/apache/accumulo/tserver/Rate.java b0ed9ee server/tserver/src/main/java/org/apache/accumulo/tserver/RootFiles.java f23c55d server/tserver/src/main/java/org/apache/accumulo/tserver/TConstraintViolationException.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java fadf4ed server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java e13594d server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 144d59b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java f26c74b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletStatsKeeper.java 58e16be server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java 871f4ae server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Batch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionRunner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionStats.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionWatcher.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/KVEntry.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Rate.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/RootFiles.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanBatch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanOptions.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Scanner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitRowSpec.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletClosedException.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletCommitter.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletMemory.java PRE-CREATION server/tserver/src/test/java/org/apache/accumulo/tserver/CountingIteratorTest.java c5c3316 server/tserver/src/test/java/org/apache/accumulo/tserver/RootFilesTest.java f216e93 Diff: https://reviews.apache.org/r/20523/diff/ Testing --- Unit and IT's Thanks, Eric Newton
Review Request 20524: ACCUMULO-2702 Create separate MR Client Opts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20524/ --- Review request for accumulo and Sean Busbey. Bugs: ACCUMULO-2702 https://issues.apache.org/jira/browse/ACCUMULO-2702 Repository: accumulo Description --- ACCUMULO-2702 Create separate MR Client Opts Separate the MR opts from the core client opts. There is plenty more work to be done, but this is a reasonable first step in that direction. We should probably be using a lot more composition than inheritance overall, and this resulted in some slight code duplication, but the change set would have been *much* more extensive otherwise. Diffs - core/src/main/java/org/apache/accumulo/core/cli/ClientOnDefaultTable.java b86638a2e73e03c46ce125dc82f32ad9f3c4daeb core/src/main/java/org/apache/accumulo/core/cli/ClientOnRequiredTable.java a4513157cfa3834e97eae79071a60a135a1a94c1 core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java d209d3feb798c593dc83353f1ceb032925b90656 core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnDefaultTable.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnRequiredTable.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOpts.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/util/Merge.java 4c0a3ea497b5b25a18d1cb808b675b7bb6103e5a examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/Flush.java 225fac241b3bfe25f12b441255b91856536b7467 examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchScanner.java 5fe23a5a65fc13b8be6852848cd11a11ebe4290b examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchWriter.java 44947d16f9b95d148028067821f1d3d05ee6c4df examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/SequentialBatchWriter.java c37c1c3ffbbe08a09ab9a8f8113cb83bdb03fa50 examples/simple/src/main/java/org/apache/accumulo/examples/simple/dirlist/FileCount.java a810b3853dc6ab2746e4638222d117deb8fcc638 examples/simple/src/main/java/org/apache/accumulo/examples/simple/dirlist/QueryUtil.java 7795ec338779644c0808ae4f81dec7bd4ea73b0b examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/CharacterHistogram.java d0662b62c38305278dd752e65c0a7b32020cf1d1 examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/FileDataIngest.java 78fef0de56db988d39c170e5e7e64206c97c6214 examples/simple/src/main/java/org/apache/accumulo/examples/simple/helloworld/InsertWithBatchWriter.java b980133c0f2830ad463228b7848111d362cd8233 examples/simple/src/main/java/org/apache/accumulo/examples/simple/helloworld/ReadData.java 97bb6332b5101cd77a8fada9c842d8ff109b6d7e examples/simple/src/main/java/org/apache/accumulo/examples/simple/isolation/InterferenceTest.java a90848edfa034ecedac0c51e10188d30b61382c5 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/NGramIngest.java f8d0b0b6d244038daeb01dedce25a65cd20a1745 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/RegexExample.java 47e587926a49792d47fb94aa2fb91fe81264b4c9 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/RowHash.java 1fa9b8f21239b81a3716080023e246f2450fbe0b examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TableToFile.java 094e6c1c5e4f529df1acfef5f8324b3e746ce911 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TeraSortIngest.java f9f2d393b2df75abe095128abe4babf3813965ab examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/UniqueColumns.java e0e29ce8ed1669190c89497ce619c3a0d8076fd7 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/WordCount.java 220b85cecca972051ccd25135fc79eaecdd3e87f examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/bulk/BulkIngestExample.java 72bd7eb95ac7648234e993b28b876f6c5a61ea89 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/bulk/SetupTable.java b6d3d139904896aa2ada5f6ba9831e15cca79247 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/bulk/VerifyIngest.java 4366416f7886f9395b2db8787a51f80074fe6d4a examples/simple/src/main/java/org/apache/accumulo/examples/simple/shard/Index.java 47310612c4ff05c5ad15eeb270881d0a8c1e77da examples/simple/src/main/java/org/apache/accumulo/examples/simple/shard/Query.java aa12c712fd4b5b96388f5449767890e59d7a6871 examples/simple/src/test/java/org/apache/accumulo/examples/simple/dirlist/CountTest.java b32918ecc43cca4aacbdbd0bc36b9a974bb598a2 test/src/main/java/org/apache/accumulo/test/BulkImportDirectory.java 42a80410e81760afcc0cbe22112414122389ce3c
Re: Review Request 20523: Initial refactoring, just structural updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/#review40898 --- server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Batch.java https://reviews.apache.org/r/20523/#comment74146 Might be useful to have an accompanying BatchBuilder, depending on the usage patterns. server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java https://reviews.apache.org/r/20523/#comment74145 Do we need to worry about thread safety? server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionRunner.java https://reviews.apache.org/r/20523/#comment74150 class should either be final or implement Comparable? extends CompactionRunner server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionWatcher.java https://reviews.apache.org/r/20523/#comment74151 Missing @Override server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java https://reviews.apache.org/r/20523/#comment74153 Could be it's own class. server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java https://reviews.apache.org/r/20523/#comment74154 A builder would be good here. 10 argument constructors are hard to grok. server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Rate.java https://reviews.apache.org/r/20523/#comment74157 Is there something in commons-math to do this for us? (Can be follow-on task). server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanOptions.java https://reviews.apache.org/r/20523/#comment74161 Builder. server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Scanner.java https://reviews.apache.org/r/20523/#comment74163 Style: Missing braces. - Mike Drob On April 21, 2014, 5:23 p.m., Eric Newton wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/ --- (Updated April 21, 2014, 5:23 p.m.) Review request for accumulo, Bill Havanki and kturner. Bugs: ACCUMULO-2041 https://issues.apache.org/jira/browse/ACCUMULO-2041 Repository: accumulo Description --- Initial refactoring of tablet. Extract inner classes, make members private and final as much as possible, group tablet-related classes into o.a.a.tserver.tablet. Diffs - server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionStats.java d359e95 server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionWatcher.java 2e4d7b7 server/tserver/src/main/java/org/apache/accumulo/tserver/Compactor.java 822171c server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java e8958b1 server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java dc36718 server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactionReason.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactor.java b2e84e5 server/tserver/src/main/java/org/apache/accumulo/tserver/Rate.java b0ed9ee server/tserver/src/main/java/org/apache/accumulo/tserver/RootFiles.java f23c55d server/tserver/src/main/java/org/apache/accumulo/tserver/TConstraintViolationException.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java fadf4ed server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java e13594d server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 144d59b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java f26c74b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletStatsKeeper.java 58e16be server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java 871f4ae server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Batch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionRunner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionStats.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionWatcher.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java PRE-CREATION
Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/ --- Review request for accumulo, Eric Newton and Mike Drob. Bugs: ACCUMULO-2694 https://issues.apache.org/jira/browse/ACCUMULO-2694 Repository: accumulo Description --- ACCUMULO-2694 Fix handling of tablet migrations for offline tables. * Adds a funtional test that fails due to not rebalancing * Fix master to clear migrations when it learns that a table has gone offline * Update master to periodically clean up migrations for offline tables * Fix balancers to make sure they log if they can't balance. Diffs - src/server/pom.xml dbe4fb4 src/server/src/main/java/org/apache/accumulo/server/master/Master.java fb7be51 src/server/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java 02a4e89 src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java 4826097 src/server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java ad62360 test/system/auto/stress/migrations.py d07d7a8 Diff: https://reviews.apache.org/r/20525/diff/ Testing --- Ran functional test without other changes - failed. After full patch functional test passes. Thanks, Sean Busbey
Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/#review40907 --- src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java https://reviews.apache.org/r/20525/#comment74178 Can this cause a lot of unnecessary logs? - Mike Drob On April 21, 2014, 6:15 p.m., Sean Busbey wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/ --- (Updated April 21, 2014, 6:15 p.m.) Review request for accumulo, Eric Newton and Mike Drob. Bugs: ACCUMULO-2694 https://issues.apache.org/jira/browse/ACCUMULO-2694 Repository: accumulo Description --- ACCUMULO-2694 Fix handling of tablet migrations for offline tables. * Adds a funtional test that fails due to not rebalancing * Fix master to clear migrations when it learns that a table has gone offline * Update master to periodically clean up migrations for offline tables * Fix balancers to make sure they log if they can't balance. Diffs - src/server/pom.xml dbe4fb4 src/server/src/main/java/org/apache/accumulo/server/master/Master.java fb7be51 src/server/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java 02a4e89 src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java 4826097 src/server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java ad62360 test/system/auto/stress/migrations.py d07d7a8 Diff: https://reviews.apache.org/r/20525/diff/ Testing --- Ran functional test without other changes - failed. After full patch functional test passes. Thanks, Sean Busbey
Re: Review Request 20524: ACCUMULO-2702 Create separate MR Client Opts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20524/#review40906 --- core/src/main/java/org/apache/accumulo/core/cli/ClientOnDefaultTable.java https://reviews.apache.org/r/20524/#comment74176 Why not initialize this to defaultTable? That way jCommander will properly say what the default table is in the cli help output. Follow on issue? Doing it here looks like it would simplify some of the other changes. core/src/main/java/org/apache/accumulo/core/cli/ClientOnRequiredTable.java https://reviews.apache.org/r/20524/#comment74179 why the get/set when this param is public? core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnDefaultTable.java https://reviews.apache.org/r/20524/#comment74182 I believe you can do this by setting tableName to the default table. This will also let jcommander give the default in help text. core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnRequiredTable.java https://reviews.apache.org/r/20524/#comment74183 no reason to use a method instead of the field directly. - Sean Busbey On April 21, 2014, 5:44 p.m., Mike Drob wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20524/ --- (Updated April 21, 2014, 5:44 p.m.) Review request for accumulo and Sean Busbey. Bugs: ACCUMULO-2702 https://issues.apache.org/jira/browse/ACCUMULO-2702 Repository: accumulo Description --- ACCUMULO-2702 Create separate MR Client Opts Separate the MR opts from the core client opts. There is plenty more work to be done, but this is a reasonable first step in that direction. We should probably be using a lot more composition than inheritance overall, and this resulted in some slight code duplication, but the change set would have been *much* more extensive otherwise. Diffs - core/src/main/java/org/apache/accumulo/core/cli/ClientOnDefaultTable.java b86638a2e73e03c46ce125dc82f32ad9f3c4daeb core/src/main/java/org/apache/accumulo/core/cli/ClientOnRequiredTable.java a4513157cfa3834e97eae79071a60a135a1a94c1 core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java d209d3feb798c593dc83353f1ceb032925b90656 core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnDefaultTable.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnRequiredTable.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOpts.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/util/Merge.java 4c0a3ea497b5b25a18d1cb808b675b7bb6103e5a examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/Flush.java 225fac241b3bfe25f12b441255b91856536b7467 examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchScanner.java 5fe23a5a65fc13b8be6852848cd11a11ebe4290b examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchWriter.java 44947d16f9b95d148028067821f1d3d05ee6c4df examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/SequentialBatchWriter.java c37c1c3ffbbe08a09ab9a8f8113cb83bdb03fa50 examples/simple/src/main/java/org/apache/accumulo/examples/simple/dirlist/FileCount.java a810b3853dc6ab2746e4638222d117deb8fcc638 examples/simple/src/main/java/org/apache/accumulo/examples/simple/dirlist/QueryUtil.java 7795ec338779644c0808ae4f81dec7bd4ea73b0b examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/CharacterHistogram.java d0662b62c38305278dd752e65c0a7b32020cf1d1 examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/FileDataIngest.java 78fef0de56db988d39c170e5e7e64206c97c6214 examples/simple/src/main/java/org/apache/accumulo/examples/simple/helloworld/InsertWithBatchWriter.java b980133c0f2830ad463228b7848111d362cd8233 examples/simple/src/main/java/org/apache/accumulo/examples/simple/helloworld/ReadData.java 97bb6332b5101cd77a8fada9c842d8ff109b6d7e examples/simple/src/main/java/org/apache/accumulo/examples/simple/isolation/InterferenceTest.java a90848edfa034ecedac0c51e10188d30b61382c5 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/NGramIngest.java f8d0b0b6d244038daeb01dedce25a65cd20a1745 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/RegexExample.java 47e587926a49792d47fb94aa2fb91fe81264b4c9 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/RowHash.java 1fa9b8f21239b81a3716080023e246f2450fbe0b
Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
On April 21, 2014, 6:20 p.m., Mike Drob wrote: src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java, line 317 https://reviews.apache.org/r/20525/diff/1/?file=563229#file563229line317 Can this cause a lot of unnecessary logs? When migrations are moving slowly for some reason, it would produce a message every ~5 seconds. the monitor would roll them up into a single message, but the log4j would have no such dampening. I could put in a time threshold, if you'd prefer to keep that down. - Sean --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/#review40907 --- On April 21, 2014, 6:15 p.m., Sean Busbey wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/ --- (Updated April 21, 2014, 6:15 p.m.) Review request for accumulo, Eric Newton and Mike Drob. Bugs: ACCUMULO-2694 https://issues.apache.org/jira/browse/ACCUMULO-2694 Repository: accumulo Description --- ACCUMULO-2694 Fix handling of tablet migrations for offline tables. * Adds a funtional test that fails due to not rebalancing * Fix master to clear migrations when it learns that a table has gone offline * Update master to periodically clean up migrations for offline tables * Fix balancers to make sure they log if they can't balance. Diffs - src/server/pom.xml dbe4fb4 src/server/src/main/java/org/apache/accumulo/server/master/Master.java fb7be51 src/server/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java 02a4e89 src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java 4826097 src/server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java ad62360 test/system/auto/stress/migrations.py d07d7a8 Diff: https://reviews.apache.org/r/20525/diff/ Testing --- Ran functional test without other changes - failed. After full patch functional test passes. Thanks, Sean Busbey
Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
On April 21, 2014, 6:20 p.m., Mike Drob wrote: src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java, line 317 https://reviews.apache.org/r/20525/diff/1/?file=563229#file563229line317 Can this cause a lot of unnecessary logs? Sean Busbey wrote: When migrations are moving slowly for some reason, it would produce a message every ~5 seconds. the monitor would roll them up into a single message, but the log4j would have no such dampening. I could put in a time threshold, if you'd prefer to keep that down. in the case of ACCUMULO-2694, that's a max of 60 messages before self correction. That seems excessive. once a minute sound better? - Sean --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/#review40907 --- On April 21, 2014, 6:15 p.m., Sean Busbey wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/ --- (Updated April 21, 2014, 6:15 p.m.) Review request for accumulo, Eric Newton and Mike Drob. Bugs: ACCUMULO-2694 https://issues.apache.org/jira/browse/ACCUMULO-2694 Repository: accumulo Description --- ACCUMULO-2694 Fix handling of tablet migrations for offline tables. * Adds a funtional test that fails due to not rebalancing * Fix master to clear migrations when it learns that a table has gone offline * Update master to periodically clean up migrations for offline tables * Fix balancers to make sure they log if they can't balance. Diffs - src/server/pom.xml dbe4fb4 src/server/src/main/java/org/apache/accumulo/server/master/Master.java fb7be51 src/server/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java 02a4e89 src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java 4826097 src/server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java ad62360 test/system/auto/stress/migrations.py d07d7a8 Diff: https://reviews.apache.org/r/20525/diff/ Testing --- Ran functional test without other changes - failed. After full patch functional test passes. Thanks, Sean Busbey
Re: Review Request 20523: Initial refactoring, just structural updates.
On April 21, 2014, 6 p.m., Mike Drob wrote: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanOptions.java, line 39 https://reviews.apache.org/r/20523/diff/1/?file=563129#file563129line39 Builder. I don't know what it would accomplish. It's a read-only record that is constructed in 2 places. On April 21, 2014, 6 p.m., Mike Drob wrote: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Rate.java, line 19 https://reviews.apache.org/r/20523/diff/1/?file=563125#file563125line19 Is there something in commons-math to do this for us? (Can be follow-on task). Not that I can see. On April 21, 2014, 6 p.m., Mike Drob wrote: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java, lines 50-74 https://reviews.apache.org/r/20523/diff/1/?file=563115#file563115line50 Do we need to worry about thread safety? Yes, we need to worry about thread safety. I'm hoping [~kturner] will help document the concurrency model. - Eric --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/#review40898 --- On April 21, 2014, 5:23 p.m., Eric Newton wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/ --- (Updated April 21, 2014, 5:23 p.m.) Review request for accumulo, Bill Havanki and kturner. Bugs: ACCUMULO-2041 https://issues.apache.org/jira/browse/ACCUMULO-2041 Repository: accumulo Description --- Initial refactoring of tablet. Extract inner classes, make members private and final as much as possible, group tablet-related classes into o.a.a.tserver.tablet. Diffs - server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionStats.java d359e95 server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionWatcher.java 2e4d7b7 server/tserver/src/main/java/org/apache/accumulo/tserver/Compactor.java 822171c server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java e8958b1 server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java dc36718 server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactionReason.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactor.java b2e84e5 server/tserver/src/main/java/org/apache/accumulo/tserver/Rate.java b0ed9ee server/tserver/src/main/java/org/apache/accumulo/tserver/RootFiles.java f23c55d server/tserver/src/main/java/org/apache/accumulo/tserver/TConstraintViolationException.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java fadf4ed server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java e13594d server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 144d59b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java f26c74b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletStatsKeeper.java 58e16be server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java 871f4ae server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Batch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionRunner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionStats.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionWatcher.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/KVEntry.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Rate.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/RootFiles.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanBatch.java PRE-CREATION
Re: Review Request 20524: ACCUMULO-2702 Create separate MR Client Opts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20524/ --- (Updated April 21, 2014, 6:59 p.m.) Review request for accumulo and Sean Busbey. Bugs: ACCUMULO-2702 https://issues.apache.org/jira/browse/ACCUMULO-2702 Repository: accumulo Description --- ACCUMULO-2702 Create separate MR Client Opts Separate the MR opts from the core client opts. There is plenty more work to be done, but this is a reasonable first step in that direction. We should probably be using a lot more composition than inheritance overall, and this resulted in some slight code duplication, but the change set would have been *much* more extensive otherwise. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/cli/ClientOnDefaultTable.java b86638a2e73e03c46ce125dc82f32ad9f3c4daeb core/src/main/java/org/apache/accumulo/core/cli/ClientOnRequiredTable.java a4513157cfa3834e97eae79071a60a135a1a94c1 core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java d209d3feb798c593dc83353f1ceb032925b90656 core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnDefaultTable.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnRequiredTable.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOpts.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/util/Merge.java 4c0a3ea497b5b25a18d1cb808b675b7bb6103e5a core/src/test/java/org/apache/accumulo/core/cli/ClientOnDefaultTableTest.java PRE-CREATION examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/Flush.java 225fac241b3bfe25f12b441255b91856536b7467 examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchScanner.java 5fe23a5a65fc13b8be6852848cd11a11ebe4290b examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchWriter.java 44947d16f9b95d148028067821f1d3d05ee6c4df examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/SequentialBatchWriter.java c37c1c3ffbbe08a09ab9a8f8113cb83bdb03fa50 examples/simple/src/main/java/org/apache/accumulo/examples/simple/dirlist/FileCount.java a810b3853dc6ab2746e4638222d117deb8fcc638 examples/simple/src/main/java/org/apache/accumulo/examples/simple/dirlist/QueryUtil.java 7795ec338779644c0808ae4f81dec7bd4ea73b0b examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/CharacterHistogram.java d0662b62c38305278dd752e65c0a7b32020cf1d1 examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/FileDataIngest.java 78fef0de56db988d39c170e5e7e64206c97c6214 examples/simple/src/main/java/org/apache/accumulo/examples/simple/helloworld/InsertWithBatchWriter.java b980133c0f2830ad463228b7848111d362cd8233 examples/simple/src/main/java/org/apache/accumulo/examples/simple/helloworld/ReadData.java 97bb6332b5101cd77a8fada9c842d8ff109b6d7e examples/simple/src/main/java/org/apache/accumulo/examples/simple/isolation/InterferenceTest.java a90848edfa034ecedac0c51e10188d30b61382c5 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/NGramIngest.java f8d0b0b6d244038daeb01dedce25a65cd20a1745 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/RegexExample.java 47e587926a49792d47fb94aa2fb91fe81264b4c9 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/RowHash.java 1fa9b8f21239b81a3716080023e246f2450fbe0b examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TableToFile.java 094e6c1c5e4f529df1acfef5f8324b3e746ce911 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TeraSortIngest.java f9f2d393b2df75abe095128abe4babf3813965ab examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/UniqueColumns.java e0e29ce8ed1669190c89497ce619c3a0d8076fd7 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/WordCount.java 220b85cecca972051ccd25135fc79eaecdd3e87f examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/bulk/BulkIngestExample.java 72bd7eb95ac7648234e993b28b876f6c5a61ea89 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/bulk/SetupTable.java b6d3d139904896aa2ada5f6ba9831e15cca79247 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/bulk/VerifyIngest.java 4366416f7886f9395b2db8787a51f80074fe6d4a examples/simple/src/main/java/org/apache/accumulo/examples/simple/shard/Index.java 47310612c4ff05c5ad15eeb270881d0a8c1e77da examples/simple/src/main/java/org/apache/accumulo/examples/simple/shard/Query.java aa12c712fd4b5b96388f5449767890e59d7a6871 examples/simple/src/test/java/org/apache/accumulo/examples/simple/dirlist/CountTest.java
Re: Review Request 20523: Initial refactoring, just structural updates.
On April 21, 2014, 6 p.m., Mike Drob wrote: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanOptions.java, line 39 https://reviews.apache.org/r/20523/diff/1/?file=563129#file563129line39 Builder. Eric Newton wrote: I don't know what it would accomplish. It's a read-only record that is constructed in 2 places. Knee-jerk reaction to lots of constructor args. Might help with testability to have a builder + private fields + getters. Feel free to drop or create a follow-on as appropriate. - Mike --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/#review40898 --- On April 21, 2014, 5:23 p.m., Eric Newton wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/ --- (Updated April 21, 2014, 5:23 p.m.) Review request for accumulo, Bill Havanki and kturner. Bugs: ACCUMULO-2041 https://issues.apache.org/jira/browse/ACCUMULO-2041 Repository: accumulo Description --- Initial refactoring of tablet. Extract inner classes, make members private and final as much as possible, group tablet-related classes into o.a.a.tserver.tablet. Diffs - server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionStats.java d359e95 server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionWatcher.java 2e4d7b7 server/tserver/src/main/java/org/apache/accumulo/tserver/Compactor.java 822171c server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java e8958b1 server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java dc36718 server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactionReason.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactor.java b2e84e5 server/tserver/src/main/java/org/apache/accumulo/tserver/Rate.java b0ed9ee server/tserver/src/main/java/org/apache/accumulo/tserver/RootFiles.java f23c55d server/tserver/src/main/java/org/apache/accumulo/tserver/TConstraintViolationException.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java fadf4ed server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java e13594d server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 144d59b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java f26c74b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletStatsKeeper.java 58e16be server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java 871f4ae server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Batch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionRunner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionStats.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionWatcher.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/KVEntry.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Rate.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/RootFiles.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanBatch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanOptions.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Scanner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitRowSpec.java PRE-CREATION
Re: Review Request 20523: Initial refactoring, just structural updates.
On April 21, 2014, 6:45 p.m., Bill Havanki wrote: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java, line 50 https://reviews.apache.org/r/20523/diff/1/?file=563123#file563123line50 This should be tablet.minorCompactionStarted(). Good catch! On April 21, 2014, 6:45 p.m., Bill Havanki wrote: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java, line 71 https://reviews.apache.org/r/20523/diff/1/?file=563123#file563123line71 MinorCompactionTask may as well get its own logger. Fixed. On April 21, 2014, 6:45 p.m., Bill Havanki wrote: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitRowSpec.java, lines 22-23 https://reviews.apache.org/r/20523/diff/1/?file=563132#file563132line22 Fields private with accessors? Fixed. On April 21, 2014, 6:45 p.m., Bill Havanki wrote: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitInfo.java, lines 36-41 https://reviews.apache.org/r/20523/diff/1/?file=563131#file563131line36 Make fields private with accessors? Fixed. On April 21, 2014, 6:45 p.m., Bill Havanki wrote: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanBatch.java, lines 22-23 https://reviews.apache.org/r/20523/diff/1/?file=563127#file563127line22 Make private with accessors? Fixed. - Eric --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/#review40900 --- On April 21, 2014, 5:23 p.m., Eric Newton wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/ --- (Updated April 21, 2014, 5:23 p.m.) Review request for accumulo, Bill Havanki and kturner. Bugs: ACCUMULO-2041 https://issues.apache.org/jira/browse/ACCUMULO-2041 Repository: accumulo Description --- Initial refactoring of tablet. Extract inner classes, make members private and final as much as possible, group tablet-related classes into o.a.a.tserver.tablet. Diffs - server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionStats.java d359e95 server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionWatcher.java 2e4d7b7 server/tserver/src/main/java/org/apache/accumulo/tserver/Compactor.java 822171c server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java e8958b1 server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java dc36718 server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactionReason.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactor.java b2e84e5 server/tserver/src/main/java/org/apache/accumulo/tserver/Rate.java b0ed9ee server/tserver/src/main/java/org/apache/accumulo/tserver/RootFiles.java f23c55d server/tserver/src/main/java/org/apache/accumulo/tserver/TConstraintViolationException.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java fadf4ed server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java e13594d server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 144d59b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java f26c74b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletStatsKeeper.java 58e16be server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java 871f4ae server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Batch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionRunner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionStats.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionWatcher.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/KVEntry.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java
Re: Review Request 20523: ACCUMULO-2041 Initial refactoring, just structural updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/ --- (Updated April 21, 2014, 7:31 p.m.) Review request for accumulo, Bill Havanki and kturner. Changes --- Making the review title consistent with other titles. Summary (updated) - ACCUMULO-2041 Initial refactoring, just structural updates. Bugs: ACCUMULO-2041 https://issues.apache.org/jira/browse/ACCUMULO-2041 Repository: accumulo Description --- Initial refactoring of tablet. Extract inner classes, make members private and final as much as possible, group tablet-related classes into o.a.a.tserver.tablet. Diffs - server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionStats.java d359e95 server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionWatcher.java 2e4d7b7 server/tserver/src/main/java/org/apache/accumulo/tserver/Compactor.java 822171c server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java e8958b1 server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java dc36718 server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactionReason.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactor.java b2e84e5 server/tserver/src/main/java/org/apache/accumulo/tserver/Rate.java b0ed9ee server/tserver/src/main/java/org/apache/accumulo/tserver/RootFiles.java f23c55d server/tserver/src/main/java/org/apache/accumulo/tserver/TConstraintViolationException.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java fadf4ed server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java e13594d server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 144d59b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java f26c74b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletStatsKeeper.java 58e16be server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java 871f4ae server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Batch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionRunner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionStats.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionWatcher.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/KVEntry.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Rate.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/RootFiles.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanBatch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanOptions.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Scanner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitRowSpec.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletClosedException.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletCommitter.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletMemory.java PRE-CREATION server/tserver/src/test/java/org/apache/accumulo/tserver/CountingIteratorTest.java c5c3316 server/tserver/src/test/java/org/apache/accumulo/tserver/RootFilesTest.java f216e93 Diff: https://reviews.apache.org/r/20523/diff/ Testing --- Unit and IT's Thanks, Eric Newton
Re: Review Request 20523: ACCUMULO-2041 Initial refactoring, just structural updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/#review40921 --- server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java https://reviews.apache.org/r/20523/#comment74233 A line from the old code doesn't appear to have an analogue here. The old line is: tabletResources.setTablet(this, acuTableConf); server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java https://reviews.apache.org/r/20523/#comment74238 Ew, capital E for the exception (and the error in the next catch). Wouldn't hurt to fix it now. server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletCommitter.java https://reviews.apache.org/r/20523/#comment74222 Some Javadoc here would be super keen. :) server/tserver/src/test/java/org/apache/accumulo/tserver/CountingIteratorTest.java https://reviews.apache.org/r/20523/#comment74223 This test ought to move to the o.a.a.tserver.tablet package. server/tserver/src/test/java/org/apache/accumulo/tserver/RootFilesTest.java https://reviews.apache.org/r/20523/#comment74226 This class ought to move to the o.a.a.tserver.tablet package. - Bill Havanki On April 21, 2014, 3:31 p.m., Eric Newton wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/ --- (Updated April 21, 2014, 3:31 p.m.) Review request for accumulo, Bill Havanki and kturner. Bugs: ACCUMULO-2041 https://issues.apache.org/jira/browse/ACCUMULO-2041 Repository: accumulo Description --- Initial refactoring of tablet. Extract inner classes, make members private and final as much as possible, group tablet-related classes into o.a.a.tserver.tablet. Diffs - server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionStats.java d359e95 server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionWatcher.java 2e4d7b7 server/tserver/src/main/java/org/apache/accumulo/tserver/Compactor.java 822171c server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java e8958b1 server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java dc36718 server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactionReason.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactor.java b2e84e5 server/tserver/src/main/java/org/apache/accumulo/tserver/Rate.java b0ed9ee server/tserver/src/main/java/org/apache/accumulo/tserver/RootFiles.java f23c55d server/tserver/src/main/java/org/apache/accumulo/tserver/TConstraintViolationException.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java fadf4ed server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java e13594d server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 144d59b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java f26c74b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletStatsKeeper.java 58e16be server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java 871f4ae server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Batch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionRunner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionStats.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionWatcher.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/KVEntry.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Rate.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/RootFiles.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanBatch.java PRE-CREATION
Re: Review Request 20523: ACCUMULO-2041 Initial refactoring, just structural updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/#review40933 --- server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java https://reviews.apache.org/r/20523/#comment74241 Wasn't this removed as part of ACCUMULO-1948? - Eric Newton On April 21, 2014, 7:31 p.m., Eric Newton wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/ --- (Updated April 21, 2014, 7:31 p.m.) Review request for accumulo, Bill Havanki and kturner. Bugs: ACCUMULO-2041 https://issues.apache.org/jira/browse/ACCUMULO-2041 Repository: accumulo Description --- Initial refactoring of tablet. Extract inner classes, make members private and final as much as possible, group tablet-related classes into o.a.a.tserver.tablet. Diffs - server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionStats.java d359e95 server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionWatcher.java 2e4d7b7 server/tserver/src/main/java/org/apache/accumulo/tserver/Compactor.java 822171c server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java e8958b1 server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java dc36718 server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactionReason.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactor.java b2e84e5 server/tserver/src/main/java/org/apache/accumulo/tserver/Rate.java b0ed9ee server/tserver/src/main/java/org/apache/accumulo/tserver/RootFiles.java f23c55d server/tserver/src/main/java/org/apache/accumulo/tserver/TConstraintViolationException.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java fadf4ed server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java e13594d server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 144d59b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java f26c74b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletStatsKeeper.java 58e16be server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java 871f4ae server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Batch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionRunner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionStats.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionWatcher.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/KVEntry.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Rate.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/RootFiles.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanBatch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanOptions.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Scanner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitRowSpec.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletClosedException.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletCommitter.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletMemory.java PRE-CREATION
Re: Review Request 20523: ACCUMULO-2041 Initial refactoring, just structural updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/#review40939 --- Ship it! For the new files, it would be nice to run the formatter over them to fix up whitespace. Looks like your editor also put in empty class level javadocs in some classes which would be nice to clean up (else Christopher will find himself doing it after you commit). - Josh Elser On April 21, 2014, 7:31 p.m., Eric Newton wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/ --- (Updated April 21, 2014, 7:31 p.m.) Review request for accumulo, Bill Havanki and kturner. Bugs: ACCUMULO-2041 https://issues.apache.org/jira/browse/ACCUMULO-2041 Repository: accumulo Description --- Initial refactoring of tablet. Extract inner classes, make members private and final as much as possible, group tablet-related classes into o.a.a.tserver.tablet. Diffs - server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionStats.java d359e95 server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionWatcher.java 2e4d7b7 server/tserver/src/main/java/org/apache/accumulo/tserver/Compactor.java 822171c server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java e8958b1 server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java dc36718 server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactionReason.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactor.java b2e84e5 server/tserver/src/main/java/org/apache/accumulo/tserver/Rate.java b0ed9ee server/tserver/src/main/java/org/apache/accumulo/tserver/RootFiles.java f23c55d server/tserver/src/main/java/org/apache/accumulo/tserver/TConstraintViolationException.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java fadf4ed server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java e13594d server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 144d59b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java f26c74b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletStatsKeeper.java 58e16be server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java 871f4ae server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Batch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionRunner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionStats.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionWatcher.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/KVEntry.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Rate.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/RootFiles.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanBatch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanOptions.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Scanner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitRowSpec.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletClosedException.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletCommitter.java PRE-CREATION
Re: Review Request 20422: ACCUMULO-1834 - Review Board guidelines
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20422/#review40940 --- docs/src/main/resources/RB.md https://reviews.apache.org/r/20422/#comment74253 It seems odd to me to specify rules for a passing review and duration length when they're not required. I think use your best judgement sums up most of these bullet points. - Josh Elser On April 21, 2014, 2:50 p.m., Bill Havanki wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20422/ --- (Updated April 21, 2014, 2:50 p.m.) Review request for accumulo. Bugs: ACCUMULO-1834 https://issues.apache.org/jira/browse/ACCUMULO-1834 Repository: accumulo Description --- A proposed set of guidelines for using Review Board, in deference to our recently-approved and improved bylaws. Diffs - docs/src/main/resources/RB.md PRE-CREATION Diff: https://reviews.apache.org/r/20422/diff/ Testing --- Thanks, Bill Havanki
Re: Review Request 20422: ACCUMULO-1834 - Review Board guidelines
On April 21, 2014, 8:56 p.m., Josh Elser wrote: docs/src/main/resources/RB.md, line 73 https://reviews.apache.org/r/20422/diff/2/?file=563069#file563069line73 It seems odd to me to specify rules for a passing review and duration length when they're not required. I think use your best judgement sums up most of these bullet points. I thought it already said that? Is your issue with the use of required? - Sean --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20422/#review40940 --- On April 21, 2014, 2:50 p.m., Bill Havanki wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20422/ --- (Updated April 21, 2014, 2:50 p.m.) Review request for accumulo. Bugs: ACCUMULO-1834 https://issues.apache.org/jira/browse/ACCUMULO-1834 Repository: accumulo Description --- A proposed set of guidelines for using Review Board, in deference to our recently-approved and improved bylaws. Diffs - docs/src/main/resources/RB.md PRE-CREATION Diff: https://reviews.apache.org/r/20422/diff/ Testing --- Thanks, Bill Havanki
Re: Review Request 20523: ACCUMULO-2041 Initial refactoring, just structural updates.
On April 21, 2014, 8:39 p.m., Josh Elser wrote: For the new files, it would be nice to run the formatter over them to fix up whitespace. Looks like your editor also put in empty class level javadocs in some classes which would be nice to clean up (else Christopher will find himself doing it after you commit). I've removed the empty comments: they were there before I started. - Eric --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/#review40939 --- On April 21, 2014, 7:31 p.m., Eric Newton wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20523/ --- (Updated April 21, 2014, 7:31 p.m.) Review request for accumulo, Bill Havanki and kturner. Bugs: ACCUMULO-2041 https://issues.apache.org/jira/browse/ACCUMULO-2041 Repository: accumulo Description --- Initial refactoring of tablet. Extract inner classes, make members private and final as much as possible, group tablet-related classes into o.a.a.tserver.tablet. Diffs - server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionStats.java d359e95 server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionWatcher.java 2e4d7b7 server/tserver/src/main/java/org/apache/accumulo/tserver/Compactor.java 822171c server/tserver/src/main/java/org/apache/accumulo/tserver/FileManager.java e8958b1 server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java dc36718 server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactionReason.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/MinorCompactor.java b2e84e5 server/tserver/src/main/java/org/apache/accumulo/tserver/Rate.java b0ed9ee server/tserver/src/main/java/org/apache/accumulo/tserver/RootFiles.java f23c55d server/tserver/src/main/java/org/apache/accumulo/tserver/TConstraintViolationException.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java fadf4ed server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java e13594d server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 144d59b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java f26c74b server/tserver/src/main/java/org/apache/accumulo/tserver/TabletStatsKeeper.java 58e16be server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java 871f4ae server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Batch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionRunner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionStats.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionWatcher.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/KVEntry.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Rate.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/RootFiles.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanBatch.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanOptions.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Scanner.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitInfo.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/SplitRowSpec.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletClosedException.java PRE-CREATION
Re: Review Request 20465: ACCUMULO-2343 - AsyncSocketAppender
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20465/#review40942 --- Did you also verify that you can run an instance using only the log4j.properties? Perhaps wrapping back around to earlier comments, have you also verified that updates to log4j.properties reload the logging backend? I'm not sure if log4j configures and watches log4j.properties by default. Also, what happens if I have both *_logger.xml files and log4j.properties files on the classpath which conflict each other (one sets some logger to WARN and the other to DEBUG) -- which one will actually be set? test/src/test/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java https://reviews.apache.org/r/20465/#comment74265 Starting the Monitor before the cluster starts mind eliminate some churn. I forget if the tserver just has a watcher set to see the update or if it polls periodically. test/src/test/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java https://reviews.apache.org/r/20465/#comment74259 Would be better to actually look in zookeeper for when the monitor registers itself using a Watcher than just guessing that 10s is long enough. test/src/test/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java https://reviews.apache.org/r/20465/#comment74261 You can easily create a monitor entry by trying to scan a table with a SKVI of java.lang.String or something of the sort. It would be good to ensure that you generated a message before checking. - Josh Elser On April 18, 2014, 7:14 p.m., Bill Havanki wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20465/ --- (Updated April 18, 2014, 7:14 p.m.) Review request for accumulo and Josh Elser. Bugs: ACCUMULO-2343 https://issues.apache.org/jira/browse/ACCUMULO-2343 Repository: accumulo Description --- AsyncSocketAppender is a Log4J AsyncAppender with its own internal SocketAppender. Configuration for either appender can be set on the AsyncSocketAppender itself. An AsyncSocketAppender can be configured using a Log4J properties file, while an ordinary AsyncAppender cannot. Diffs - core/src/main/java/org/apache/accumulo/core/util/AsyncSocketAppender.java PRE-CREATION core/src/test/java/org/apache/accumulo/core/util/AsyncSocketAppenderTest.java PRE-CREATION test/src/test/java/org/apache/accumulo/test/functional/ConfigurableMacIT.java d9bed7f test/src/test/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java PRE-CREATION test/src/test/resources/conf/generic_logger.xml PRE-CREATION test/src/test/resources/conf/monitor_logger.xml PRE-CREATION Diff: https://reviews.apache.org/r/20465/diff/ Testing --- Unit test created and passed. Also used main() method to send log messages to a running Log4J SimpleSocketServer instance. Thanks, Bill Havanki
Re: Review Request 20467: ACCUMULO-2654 updates for 1.6 branch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20467/#review40947 --- Ship it! test/src/test/java/org/apache/accumulo/test/functional/RecoveryWithEmptyRFileIT.java https://reviews.apache.org/r/20467/#comment74266 speeling - Josh Elser On April 17, 2014, 9:45 p.m., Sean Busbey wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20467/ --- (Updated April 17, 2014, 9:45 p.m.) Review request for accumulo and kturner. Bugs: ACCUMULO-2654 https://issues.apache.org/jira/browse/ACCUMULO-2654 Repository: accumulo Description --- Results of merging 1.5.2-SNAPSHOT version forward to 1.6.0-SNAPSHOT (involved some package / class changes for information about e.g. compression algos) and then updating the functional test to be an IT. Main review here is of the IT version of hte test. Diffs - core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java b361413 core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java 66ca07f test/src/test/java/org/apache/accumulo/test/functional/ReadWriteIT.java cb803f8 test/src/test/java/org/apache/accumulo/test/functional/RecoveryWithEmptyRFileIT.java PRE-CREATION Diff: https://reviews.apache.org/r/20467/diff/ Testing --- ran through IT again. tested creating files on real cluster. Thanks, Sean Busbey
Re: Review Request 20524: ACCUMULO-2702 Create separate MR Client Opts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20524/#review40948 --- Ship it! Ship It! - Josh Elser On April 21, 2014, 6:59 p.m., Mike Drob wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20524/ --- (Updated April 21, 2014, 6:59 p.m.) Review request for accumulo and Sean Busbey. Bugs: ACCUMULO-2702 https://issues.apache.org/jira/browse/ACCUMULO-2702 Repository: accumulo Description --- ACCUMULO-2702 Create separate MR Client Opts Separate the MR opts from the core client opts. There is plenty more work to be done, but this is a reasonable first step in that direction. We should probably be using a lot more composition than inheritance overall, and this resulted in some slight code duplication, but the change set would have been *much* more extensive otherwise. Diffs - core/src/main/java/org/apache/accumulo/core/cli/ClientOnDefaultTable.java b86638a2e73e03c46ce125dc82f32ad9f3c4daeb core/src/main/java/org/apache/accumulo/core/cli/ClientOnRequiredTable.java a4513157cfa3834e97eae79071a60a135a1a94c1 core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java d209d3feb798c593dc83353f1ceb032925b90656 core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnDefaultTable.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnRequiredTable.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOpts.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/util/Merge.java 4c0a3ea497b5b25a18d1cb808b675b7bb6103e5a core/src/test/java/org/apache/accumulo/core/cli/ClientOnDefaultTableTest.java PRE-CREATION examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/Flush.java 225fac241b3bfe25f12b441255b91856536b7467 examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchScanner.java 5fe23a5a65fc13b8be6852848cd11a11ebe4290b examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchWriter.java 44947d16f9b95d148028067821f1d3d05ee6c4df examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/SequentialBatchWriter.java c37c1c3ffbbe08a09ab9a8f8113cb83bdb03fa50 examples/simple/src/main/java/org/apache/accumulo/examples/simple/dirlist/FileCount.java a810b3853dc6ab2746e4638222d117deb8fcc638 examples/simple/src/main/java/org/apache/accumulo/examples/simple/dirlist/QueryUtil.java 7795ec338779644c0808ae4f81dec7bd4ea73b0b examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/CharacterHistogram.java d0662b62c38305278dd752e65c0a7b32020cf1d1 examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/FileDataIngest.java 78fef0de56db988d39c170e5e7e64206c97c6214 examples/simple/src/main/java/org/apache/accumulo/examples/simple/helloworld/InsertWithBatchWriter.java b980133c0f2830ad463228b7848111d362cd8233 examples/simple/src/main/java/org/apache/accumulo/examples/simple/helloworld/ReadData.java 97bb6332b5101cd77a8fada9c842d8ff109b6d7e examples/simple/src/main/java/org/apache/accumulo/examples/simple/isolation/InterferenceTest.java a90848edfa034ecedac0c51e10188d30b61382c5 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/NGramIngest.java f8d0b0b6d244038daeb01dedce25a65cd20a1745 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/RegexExample.java 47e587926a49792d47fb94aa2fb91fe81264b4c9 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/RowHash.java 1fa9b8f21239b81a3716080023e246f2450fbe0b examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TableToFile.java 094e6c1c5e4f529df1acfef5f8324b3e746ce911 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TeraSortIngest.java f9f2d393b2df75abe095128abe4babf3813965ab examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/UniqueColumns.java e0e29ce8ed1669190c89497ce619c3a0d8076fd7 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/WordCount.java 220b85cecca972051ccd25135fc79eaecdd3e87f examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/bulk/BulkIngestExample.java 72bd7eb95ac7648234e993b28b876f6c5a61ea89 examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/bulk/SetupTable.java b6d3d139904896aa2ada5f6ba9831e15cca79247
Re: [VOTE] Accumulo 1.6.0-RC2
In the interest of documentation, this vote failed with: -6, +2 -- Christopher L Tubbs II http://gravatar.com/ctubbsii On Fri, Apr 18, 2014 at 11:13 PM, Bill Havanki bhava...@clouderagovt.com wrote: And for proper form: -1 due to ACCUMULO-2700. On Fri, Apr 18, 2014 at 11:12 PM, Bill Havanki bhava...@clouderagovt.comwrote: -1 Dogpile! On Fri, Apr 18, 2014 at 5:08 PM, Keith Turner ke...@deenlo.com wrote: -1 because of ACCUMULO-2700 I was getting ready to +1 before Christopher found 2700 I did the following checks * sigs @ hashes of bin.tgz are ok * ran through a few examples and found ACCUMULO-2691 * upgrade 1.5.1 to 1.6.0 RC2 went ok * built native lib ok Ran the following test on 20 node cluster * 24 hr ci w/o ag RC1 + ACCUMULO_2668 patch (~31B k/v verified clean, ran into ACCUMULO-2677) * 24 hr RW conditional w/o agitation RC2 (all 20 walkers ran until I killed them) * 24 hr RW conditional w/ agitation RC2 and found ACCUMULO-2695 (7 of 17 walkers hung) On Tue, Apr 15, 2014 at 9:57 PM, Christopher ctubb...@apache.org wrote: Accumulo Developers, Please consider the following candidate for Accumulo 1.6.0. Git Commit: e7863ea0dd523f0c6d3552e6844ff7411d78d557 Branch: 1.6.0-RC2 Staging repo: https://repository.apache.org/content/repositories/orgapacheaccumulo-1008 Source: https://repository.apache.org/content/repositories/orgapacheaccumulo-1008/org/apache/accumulo/accumulo/1.6.0/accumulo-1.6.0-src.tar.gz Binary: https://repository.apache.org/content/repositories/orgapacheaccumulo-1008/org/apache/accumulo/accumulo/1.6.0/accumulo-1.6.0-bin.tar.gz (Append .sha1, .md5 or .asc to download the signature/hash for a given artifact.) All artifacts were built and staged with: mvn release:prepare mvn release:perform Signing keys available at: https://www.apache.org/dist/accumulo/KEYS Release notes (in progress): http://accumulo.apache.org/release_notes/1.6.0 Changes since RC1 (`git log 019edb1..origin/1.6.0-RC2`): https://issues.apache.org/jira/browse/ACCUMULO-2667 https://issues.apache.org/jira/browse/ACCUMULO-2670 https://issues.apache.org/jira/browse/ACCUMULO-2665 https://issues.apache.org/jira/browse/ACCUMULO-2668 https://issues.apache.org/jira/browse/ACCUMULO-2666 https://issues.apache.org/jira/browse/ACCUMULO-2621 https://issues.apache.org/jira/browse/ACCUMULO-2657 This vote will remain open for 96 hours (4 days, because I'm getting this out so late today, I doubt anybody will look at it tonight), until Sun, April 20, 02:00 UTC 2014. (That's Saturday, April 19, 10pm EDT.) [ ] +1 - I have verified and accept... [ ] +0 - I have reservations, but not strong enough to vote against... [ ] -1 - Because..., I do not accept... ... these artifacts as the 1.6.0 release of Apache Accumulo. Thanks. P.S. Hint: download the whole staging repo with wget -erobots=off -r -l inf -np -nH https://repository.apache.org/content/repositories/orgapacheaccumulo-1008/ # note the trailing slash is needed -- Christopher L Tubbs II http://gravatar.com/ctubbsii -- // Bill Havanki // Solutions Architect, Cloudera Govt Solutions // 443.686.9283 -- // Bill Havanki // Solutions Architect, Cloudera Govt Solutions // 443.686.9283
Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/#review40950 --- src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java https://reviews.apache.org/r/20525/#comment74269 Seems like this could get rather spammy. If we have no tservers, we *know* that things are already bad, probably don't need to be re-WARN'ed. - Josh Elser On April 21, 2014, 6:15 p.m., Sean Busbey wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/ --- (Updated April 21, 2014, 6:15 p.m.) Review request for accumulo, Eric Newton and Mike Drob. Bugs: ACCUMULO-2694 https://issues.apache.org/jira/browse/ACCUMULO-2694 Repository: accumulo Description --- ACCUMULO-2694 Fix handling of tablet migrations for offline tables. * Adds a funtional test that fails due to not rebalancing * Fix master to clear migrations when it learns that a table has gone offline * Update master to periodically clean up migrations for offline tables * Fix balancers to make sure they log if they can't balance. Diffs - src/server/pom.xml dbe4fb4 src/server/src/main/java/org/apache/accumulo/server/master/Master.java fb7be51 src/server/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java 02a4e89 src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java 4826097 src/server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java ad62360 test/system/auto/stress/migrations.py d07d7a8 Diff: https://reviews.apache.org/r/20525/diff/ Testing --- Ran functional test without other changes - failed. After full patch functional test passes. Thanks, Sean Busbey
Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/ --- (Updated April 21, 2014, 9:32 p.m.) Review request for accumulo, Eric Newton and Mike Drob. Changes --- Limit the frequency of warnings to avoid transient blockage and flooding messages. Previous patch: $ grep -i WARN : not balancing logs/host1-9873/master_host1.example.com.log | grep -i outstanding migrations | wc -l 816 And now: $ grep -i WARN : not balancing logs/host1-19121/master_host1.example.com.log | grep -i outstanding migrations | wc -l 12 The test is set to use per-table balancers and has 3 tables, so that 12 count represents four minutes with a set of 3 messages per minute. Bugs: ACCUMULO-2694 https://issues.apache.org/jira/browse/ACCUMULO-2694 Repository: accumulo Description --- ACCUMULO-2694 Fix handling of tablet migrations for offline tables. * Adds a funtional test that fails due to not rebalancing * Fix master to clear migrations when it learns that a table has gone offline * Update master to periodically clean up migrations for offline tables * Fix balancers to make sure they log if they can't balance. Diffs (updated) - src/server/pom.xml dbe4fb4 src/server/src/main/java/org/apache/accumulo/server/master/Master.java fb7be51 src/server/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java 02a4e89 src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java 4826097 src/server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java ad62360 test/system/auto/stress/migrations.py d07d7a8 Diff: https://reviews.apache.org/r/20525/diff/ Testing --- Ran functional test without other changes - failed. After full patch functional test passes. Thanks, Sean Busbey
Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
On April 21, 2014, 6:20 p.m., Mike Drob wrote: src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java, line 317 https://reviews.apache.org/r/20525/diff/1/?file=563229#file563229line317 Can this cause a lot of unnecessary logs? Sean Busbey wrote: When migrations are moving slowly for some reason, it would produce a message every ~5 seconds. the monitor would roll them up into a single message, but the log4j would have no such dampening. I could put in a time threshold, if you'd prefer to keep that down. Sean Busbey wrote: in the case of ACCUMULO-2694, that's a max of 60 messages before self correction. That seems excessive. once a minute sound better? Take a look at the change and let me know if this sounds sufficiently fixed? It'll only message if balance calls fail for one contiguous minute, and only repeat the message once per minute. - Sean --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/#review40907 --- On April 21, 2014, 9:32 p.m., Sean Busbey wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/ --- (Updated April 21, 2014, 9:32 p.m.) Review request for accumulo, Eric Newton and Mike Drob. Bugs: ACCUMULO-2694 https://issues.apache.org/jira/browse/ACCUMULO-2694 Repository: accumulo Description --- ACCUMULO-2694 Fix handling of tablet migrations for offline tables. * Adds a funtional test that fails due to not rebalancing * Fix master to clear migrations when it learns that a table has gone offline * Update master to periodically clean up migrations for offline tables * Fix balancers to make sure they log if they can't balance. Diffs - src/server/pom.xml dbe4fb4 src/server/src/main/java/org/apache/accumulo/server/master/Master.java fb7be51 src/server/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java 02a4e89 src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java 4826097 src/server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java ad62360 test/system/auto/stress/migrations.py d07d7a8 Diff: https://reviews.apache.org/r/20525/diff/ Testing --- Ran functional test without other changes - failed. After full patch functional test passes. Thanks, Sean Busbey
Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
On April 21, 2014, 9:22 p.m., Josh Elser wrote: src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java, line 321 https://reviews.apache.org/r/20525/diff/1/?file=563229#file563229line321 Seems like this could get rather spammy. If we have no tservers, we *know* that things are already bad, probably don't need to be re-WARN'ed. a balancer's notion of there are online tservers might differ from other points in the system, so I think it's still worth calling out if a balancer thinks there are none. Take a look at the change and let me know if this sounds sufficiently fixed? It'll only message if balance calls fail for one contiguous minute, and only repeat the message once per minute. - Sean --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/#review40950 --- On April 21, 2014, 9:32 p.m., Sean Busbey wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20525/ --- (Updated April 21, 2014, 9:32 p.m.) Review request for accumulo, Eric Newton and Mike Drob. Bugs: ACCUMULO-2694 https://issues.apache.org/jira/browse/ACCUMULO-2694 Repository: accumulo Description --- ACCUMULO-2694 Fix handling of tablet migrations for offline tables. * Adds a funtional test that fails due to not rebalancing * Fix master to clear migrations when it learns that a table has gone offline * Update master to periodically clean up migrations for offline tables * Fix balancers to make sure they log if they can't balance. Diffs - src/server/pom.xml dbe4fb4 src/server/src/main/java/org/apache/accumulo/server/master/Master.java fb7be51 src/server/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java 02a4e89 src/server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java 4826097 src/server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java ad62360 test/system/auto/stress/migrations.py d07d7a8 Diff: https://reviews.apache.org/r/20525/diff/ Testing --- Ran functional test without other changes - failed. After full patch functional test passes. Thanks, Sean Busbey
[VOTE] Accumulo 1.6.0-RC3
Accumulo Developers, Please consider the following candidate for Accumulo 1.6.0. Git Commit: 901c35857ce982f2e4a6f609590a04a7b5a1a815 Branch: 1.6.0-RC3 Staging repo: https://repository.apache.org/content/repositories/orgapacheaccumulo-1009 Source: https://repository.apache.org/content/repositories/orgapacheaccumulo-1009/org/apache/accumulo/accumulo/1.6.0/accumulo-1.6.0-src.tar.gz Binary: https://repository.apache.org/content/repositories/orgapacheaccumulo-1009/org/apache/accumulo/accumulo/1.6.0/accumulo-1.6.0-bin.tar.gz (Append .sha1, .md5 or .asc to download the signature/hash for a given artifact.) All artifacts were built and staged with: mvn release:prepare mvn release:perform Signing keys available at: https://www.apache.org/dist/accumulo/KEYS Release notes (in progress): http://accumulo.apache.org/release_notes/1.6.0 Changes since RC2 (`git log 73fae63..origin/1.6.0-RC3`): https://issues.apache.org/jira/browse/ACCUMULO-2529 https://issues.apache.org/jira/browse/ACCUMULO-2671 https://issues.apache.org/jira/browse/ACCUMULO-2675 https://issues.apache.org/jira/browse/ACCUMULO-2680 https://issues.apache.org/jira/browse/ACCUMULO-2682 https://issues.apache.org/jira/browse/ACCUMULO-2686 https://issues.apache.org/jira/browse/ACCUMULO-2690 https://issues.apache.org/jira/browse/ACCUMULO-2695 https://issues.apache.org/jira/browse/ACCUMULO-2697 https://issues.apache.org/jira/browse/ACCUMULO-2700 This vote will remain open for 72 hours (3 days), until Thu, April 24, 22:00 UTC 2014. (That's 6pm EDT.) [ ] +1 - I have verified and accept... [ ] +0 - I have reservations, but not strong enough to vote against... [ ] -1 - Because..., I do not accept... ... these artifacts as the 1.6.0 release of Apache Accumulo. Thanks. P.S. Hint: download the whole staging repo with wget -erobots=off -r -l inf -np -nH https://repository.apache.org/content/repositories/orgapacheaccumulo-1009/ # note the trailing slash is needed -- Christopher L Tubbs II http://gravatar.com/ctubbsii
Re: Review Request 20467: ACCUMULO-2654 updates for 1.6 branch
On April 21, 2014, 9:13 p.m., Josh Elser wrote: test/src/test/java/org/apache/accumulo/test/functional/RecoveryWithEmptyRFileIT.java, line 128 https://reviews.apache.org/r/20467/diff/1/?file=561799#file561799line128 speeling fixed locally prior to push. - Sean --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20467/#review40947 --- On April 17, 2014, 9:45 p.m., Sean Busbey wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20467/ --- (Updated April 17, 2014, 9:45 p.m.) Review request for accumulo and kturner. Bugs: ACCUMULO-2654 https://issues.apache.org/jira/browse/ACCUMULO-2654 Repository: accumulo Description --- Results of merging 1.5.2-SNAPSHOT version forward to 1.6.0-SNAPSHOT (involved some package / class changes for information about e.g. compression algos) and then updating the functional test to be an IT. Main review here is of the IT version of hte test. Diffs - core/src/main/java/org/apache/accumulo/core/file/rfile/CreateEmpty.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java b361413 core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java 66ca07f test/src/test/java/org/apache/accumulo/test/functional/ReadWriteIT.java cb803f8 test/src/test/java/org/apache/accumulo/test/functional/RecoveryWithEmptyRFileIT.java PRE-CREATION Diff: https://reviews.apache.org/r/20467/diff/ Testing --- ran through IT again. tested creating files on real cluster. Thanks, Sean Busbey
