Artemis with License Checks on PR/s build
Just a heads up, Justin Bertram has enabled license checks on the build again, and the PR checks... So, from now on committing java files without headers won't get un noticed without a build failure ;)
[GitHub] activemq-artemis pull request: License stuff
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: License stuff
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/228#discussion_r29716501 --- Diff: examples/core/vertx-connector/pom.xml --- @@ -32,8 +32,10 @@ under the License. ActiveMQ Artemis Vert.x Example + ${project.basedir}/../../.. --- End diff -- I'm pretty sure this will be broken under the distribution.. can you try running this after building the distribution? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: License stuff
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/228 License stuff All the example poms needed to be updated so they would use the same location from the license report file (i.e. ratReport.txt). This is necessary so this file can be printed at the end of the Jenkins build so that if the license check fails the developer will know which file caused it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/228.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #228 commit 26a97dc850be3ae92334e44b8092de5193c43aa3 Author: jbertram Date: 2015-05-05T19:27:32Z Revert "disabled RAT plugin by default and updated the docs for releasing explaining how to enable it." This reverts commit d30ffb79c82e513f62b962aa02417e05bf39a204. Reverted because the PR build was missing files without the right license. commit 9dcb2d2faa8026a7c11636a1f72db52d7cb45ec2 Author: jbertram Date: 2015-05-05T21:34:41Z Add license header commit dc78dd4c50b70272675c5c379ef99063446c0c98 Author: jbertram Date: 2015-05-05T21:35:09Z Re-enable & refactor license check --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Artemis options
good point.. will do it! On Tue, May 5, 2015 at 5:18 PM, Hiram Chirino wrote: > perhaps you should print out a nicer error messages saying they should > use the --bindings / --journal options :) > > On Tue, May 5, 2015 at 5:14 PM, Clebert Suconic > wrote: >> I did it like that but I always analyze user's data without a running >> instance. So I would be able to do something like -- >> >> ./artemis data print --bindings /users-data --journal /users-data >> >> >> >> >> Maybe I should ignore that error and just print an empty report if no >> folders are available? >> >> >> >> >> >> On Tue, May 5, 2015 at 4:35 PM, Hiram Chirino wrote: >>> Nice! >>> >>> But perhaps the 'data' command should only be enabled in the >>> ${ARTEMIS_INSTANCE}/bin/artemis case. When used with >>> ${ARTEMIS_HOME}/bin/artemis it fails since it can't find the data >>> files. >>> >>> On Tue, May 5, 2015 at 11:33 AM, Clebert Suconic >>> wrote: I have added data options to the runtime CLI, moved it from artemis-tools, Now users will be able to do: ./artemis data print and print all the data on the journals and paging (the option will open the journals and print all the contents) To export the data ./artemis data exp you can use ./artemis help data print (I - at the end of the email) I tried to be as much user friendly as possible... if you could play with it... it would help me to make sure it's really user friendly :) I: $ ./artemis help data print NAME artemis data print - Print data records information (WARNING: don't use while a production server is running) SYNOPSIS artemis data print [--bindings ] [--broker ] [--journal ] [--large-messages ] [--paging ] [--] [] OPTIONS --bindings The folder used for bindings (default from broker.xml) --broker This would override the broker configuration from the bootstrap --journal The folder used for messages journal (default from broker.xml) --large-messages The folder used for large-messages (default from broker.xml) --paging The folder used for paging (default from broker.xml) -- This option can be used to separate command-line options from the list of argument, (useful when arguments might be mistaken for command-line options Broker Configuration URI, default 'xml:${ARTEMIS_INSTANCE}/etc/bootstrap.xml' >>> >>> >>> >>> -- >>> Hiram Chirino >>> Engineering | Red Hat, Inc. >>> hchir...@redhat.com | fusesource.com | redhat.com >>> skype: hiramchirino | twitter: @hiramchirino >> >> >> >> -- >> Clebert Suconic >> http://community.jboss.org/people/clebert.suco...@jboss.com >> http://clebertsuconic.blogspot.com > > > > -- > Hiram Chirino > Engineering | Red Hat, Inc. > hchir...@redhat.com | fusesource.com | redhat.com > skype: hiramchirino | twitter: @hiramchirino -- Clebert Suconic http://community.jboss.org/people/clebert.suco...@jboss.com http://clebertsuconic.blogspot.com
Re: Artemis options
perhaps you should print out a nicer error messages saying they should use the --bindings / --journal options :) On Tue, May 5, 2015 at 5:14 PM, Clebert Suconic wrote: > I did it like that but I always analyze user's data without a running > instance. So I would be able to do something like -- > > ./artemis data print --bindings /users-data --journal /users-data > > > > > Maybe I should ignore that error and just print an empty report if no > folders are available? > > > > > > On Tue, May 5, 2015 at 4:35 PM, Hiram Chirino wrote: >> Nice! >> >> But perhaps the 'data' command should only be enabled in the >> ${ARTEMIS_INSTANCE}/bin/artemis case. When used with >> ${ARTEMIS_HOME}/bin/artemis it fails since it can't find the data >> files. >> >> On Tue, May 5, 2015 at 11:33 AM, Clebert Suconic >> wrote: >>> I have added data options to the runtime CLI, moved it from artemis-tools, >>> >>> Now users will be able to do: >>> >>> >>> ./artemis data print >>> >>> >>> and print all the data on the journals and paging (the option will >>> open the journals and print all the contents) >>> >>> >>> To export the data >>> >>> ./artemis data exp >>> >>> >>> >>> >>> you can use ./artemis help data print (I - at the end of the email) >>> >>> >>> >>> >>> I tried to be as much user friendly as possible... if you could play >>> with it... it would help me to make sure it's really user friendly :) >>> >>> >>> >>> >>> >>> I: >>> >>> $ ./artemis help data print >>> >>> NAME >>> >>> artemis data print - Print data records information (WARNING: don't >>> use >>> >>> while a production server is running) >>> >>> >>> SYNOPSIS >>> >>> artemis data print [--bindings ] [--broker ] >>> >>> [--journal ] [--large-messages ] >>> >>> [--paging ] [--] [] >>> >>> >>> OPTIONS >>> >>> --bindings >>> >>> The folder used for bindings (default from broker.xml) >>> >>> >>> --broker >>> >>> This would override the broker configuration from the bootstrap >>> >>> >>> --journal >>> >>> The folder used for messages journal (default from broker.xml) >>> >>> >>> --large-messages >>> >>> The folder used for large-messages (default from broker.xml) >>> >>> >>> --paging >>> >>> The folder used for paging (default from broker.xml) >>> >>> >>> -- >>> >>> This option can be used to separate command-line options from >>> the >>> >>> list of argument, (useful when arguments might be mistaken for >>> >>> command-line options >>> >>> >>> >>> >>> Broker Configuration URI, default >>> >>> 'xml:${ARTEMIS_INSTANCE}/etc/bootstrap.xml' >> >> >> >> -- >> Hiram Chirino >> Engineering | Red Hat, Inc. >> hchir...@redhat.com | fusesource.com | redhat.com >> skype: hiramchirino | twitter: @hiramchirino > > > > -- > Clebert Suconic > http://community.jboss.org/people/clebert.suco...@jboss.com > http://clebertsuconic.blogspot.com -- Hiram Chirino Engineering | Red Hat, Inc. hchir...@redhat.com | fusesource.com | redhat.com skype: hiramchirino | twitter: @hiramchirino
[GitHub] activemq-artemis pull request: HornetQ Protocol Support
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/227#issuecomment-99225003 @mtaylor cool... also please make sure you rebase on top of master tomorrow as I have merged a few other PRs today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Artemis options
I did it like that but I always analyze user's data without a running instance. So I would be able to do something like -- ./artemis data print --bindings /users-data --journal /users-data Maybe I should ignore that error and just print an empty report if no folders are available? On Tue, May 5, 2015 at 4:35 PM, Hiram Chirino wrote: > Nice! > > But perhaps the 'data' command should only be enabled in the > ${ARTEMIS_INSTANCE}/bin/artemis case. When used with > ${ARTEMIS_HOME}/bin/artemis it fails since it can't find the data > files. > > On Tue, May 5, 2015 at 11:33 AM, Clebert Suconic > wrote: >> I have added data options to the runtime CLI, moved it from artemis-tools, >> >> Now users will be able to do: >> >> >> ./artemis data print >> >> >> and print all the data on the journals and paging (the option will >> open the journals and print all the contents) >> >> >> To export the data >> >> ./artemis data exp >> >> >> >> >> you can use ./artemis help data print (I - at the end of the email) >> >> >> >> >> I tried to be as much user friendly as possible... if you could play >> with it... it would help me to make sure it's really user friendly :) >> >> >> >> >> >> I: >> >> $ ./artemis help data print >> >> NAME >> >> artemis data print - Print data records information (WARNING: don't >> use >> >> while a production server is running) >> >> >> SYNOPSIS >> >> artemis data print [--bindings ] [--broker ] >> >> [--journal ] [--large-messages ] >> >> [--paging ] [--] [] >> >> >> OPTIONS >> >> --bindings >> >> The folder used for bindings (default from broker.xml) >> >> >> --broker >> >> This would override the broker configuration from the bootstrap >> >> >> --journal >> >> The folder used for messages journal (default from broker.xml) >> >> >> --large-messages >> >> The folder used for large-messages (default from broker.xml) >> >> >> --paging >> >> The folder used for paging (default from broker.xml) >> >> >> -- >> >> This option can be used to separate command-line options from the >> >> list of argument, (useful when arguments might be mistaken for >> >> command-line options >> >> >> >> >> Broker Configuration URI, default >> >> 'xml:${ARTEMIS_INSTANCE}/etc/bootstrap.xml' > > > > -- > Hiram Chirino > Engineering | Red Hat, Inc. > hchir...@redhat.com | fusesource.com | redhat.com > skype: hiramchirino | twitter: @hiramchirino -- Clebert Suconic http://community.jboss.org/people/clebert.suco...@jboss.com http://clebertsuconic.blogspot.com
[GitHub] activemq-artemis pull request: HornetQ Protocol Support
Github user mtaylor commented on the pull request: https://github.com/apache/activemq-artemis/pull/227#issuecomment-99220614 @clebertsuconic Looks like IntelliJ settings are screwing things up. I'll get to this tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: HornetQ Protocol Support
Github user mtaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/227#discussion_r29711018 --- Diff: artemis-protocols/artemis-hornetq-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/hornetq/HQPropertiesConversionInterceptor.java --- @@ -0,0 +1,81 @@ +package org.apache.activemq.artemis.core.protocol.hornetq; --- End diff -- @johnament Thanks John. This is now added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Artemis options
Nice! But perhaps the 'data' command should only be enabled in the ${ARTEMIS_INSTANCE}/bin/artemis case. When used with ${ARTEMIS_HOME}/bin/artemis it fails since it can't find the data files. On Tue, May 5, 2015 at 11:33 AM, Clebert Suconic wrote: > I have added data options to the runtime CLI, moved it from artemis-tools, > > Now users will be able to do: > > > ./artemis data print > > > and print all the data on the journals and paging (the option will > open the journals and print all the contents) > > > To export the data > > ./artemis data exp > > > > > you can use ./artemis help data print (I - at the end of the email) > > > > > I tried to be as much user friendly as possible... if you could play > with it... it would help me to make sure it's really user friendly :) > > > > > > I: > > $ ./artemis help data print > > NAME > > artemis data print - Print data records information (WARNING: don't > use > > while a production server is running) > > > SYNOPSIS > > artemis data print [--bindings ] [--broker ] > > [--journal ] [--large-messages ] > > [--paging ] [--] [] > > > OPTIONS > > --bindings > > The folder used for bindings (default from broker.xml) > > > --broker > > This would override the broker configuration from the bootstrap > > > --journal > > The folder used for messages journal (default from broker.xml) > > > --large-messages > > The folder used for large-messages (default from broker.xml) > > > --paging > > The folder used for paging (default from broker.xml) > > > -- > > This option can be used to separate command-line options from the > > list of argument, (useful when arguments might be mistaken for > > command-line options > > > > > Broker Configuration URI, default > > 'xml:${ARTEMIS_INSTANCE}/etc/bootstrap.xml' -- Hiram Chirino Engineering | Red Hat, Inc. hchir...@redhat.com | fusesource.com | redhat.com skype: hiramchirino | twitter: @hiramchirino
[GitHub] activemq-artemis pull request: HornetQ Protocol Support
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/227#issuecomment-99195052 @johnament actually header check is disabled on the build.. we are fixing it back... thanks for raising the issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: HornetQ Protocol Support
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/227#issuecomment-99188011 @mtaylor this PR is not valid... there are a few checkstyle and a missing license header as @johnament mentioned (although the PR check would have failed because of that). You said you changed it.. but I don't see any changes.. the build still broken.. I just tried to merge it manually and these issues are still there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: ACTIVEMQ6-96 ensure connectionsAllo...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: HornetQ Protocol Support
Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/227#discussion_r29698636 --- Diff: artemis-protocols/artemis-hornetq-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/hornetq/HQPropertiesConversionInterceptor.java --- @@ -0,0 +1,81 @@ +package org.apache.activemq.artemis.core.protocol.hornetq; --- End diff -- license header? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: HornetQ Protocol Support
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/227#issuecomment-99168844 protocol/src/main/java/org/apache/activemq/artemis/core/protocol/hornetq/HQPropertiesConversionInterceptor.java:12: Using the '.*' form of import should be avoided - java.util.*. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: HornetQ Protocol Support
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/227#issuecomment-99164100 Build failure... The right name is Legacy Protocol Support... I would avoid the H name now :8ball: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: HornetQ Protocol Support
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/227 HornetQ Protocol Support You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis hornetq-support Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/227.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #227 commit eb823f440766e6e740e2e3c1f3aa0fb94ab028cb Author: Martyn Taylor Date: 2015-04-30T11:11:38Z Changed core protocol handshake to use ARTEMIS commit 43379f9c20b11c58bb4da708d32db370afa66649 Author: Martyn Taylor Date: 2015-04-30T13:12:34Z ACTIVEMQ6-100 Add support for HornetQ clients --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: ACTIVEMQ6-96 ensure connectionsAllo...
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/226#issuecomment-99120166 what about Netty? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: ACTIVEMQ6-96 ensure connectionsAllo...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/226 ACTIVEMQ6-96 ensure connectionsAllowed work on invm acceptor URI You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/226.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #226 commit 4fa76f600098c3a35dc143d7b7cd2f9229dc4d4a Author: jbertram Date: 2015-05-05T15:39:36Z ACTIVEMQ6-96 ensure connectionsAllowed work on invm acceptor URI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Artemis options
I have added data options to the runtime CLI, moved it from artemis-tools, Now users will be able to do: ./artemis data print and print all the data on the journals and paging (the option will open the journals and print all the contents) To export the data ./artemis data exp you can use ./artemis help data print (I - at the end of the email) I tried to be as much user friendly as possible... if you could play with it... it would help me to make sure it's really user friendly :) I: $ ./artemis help data print NAME artemis data print - Print data records information (WARNING: don't use while a production server is running) SYNOPSIS artemis data print [--bindings ] [--broker ] [--journal ] [--large-messages ] [--paging ] [--] [] OPTIONS --bindings The folder used for bindings (default from broker.xml) --broker This would override the broker configuration from the bootstrap --journal The folder used for messages journal (default from broker.xml) --large-messages The folder used for large-messages (default from broker.xml) --paging The folder used for paging (default from broker.xml) -- This option can be used to separate command-line options from the list of argument, (useful when arguments might be mistaken for command-line options Broker Configuration URI, default 'xml:${ARTEMIS_INSTANCE}/etc/bootstrap.xml'
[GitHub] activemq-artemis pull request: create CLI fixes
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: add getter method for channel and c...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: create CLI fixes
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/225 create CLI fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/andytaylor/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/225.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #225 commit 6fda5e3a6cc8ab50eeb6d8efb8015de75573450f Author: Andy Taylor Date: 2015-05-05T09:36:08Z fixed create CLI typo commit ea26a9dd7815ab8699540d727ee7274d7c5fbbaf Author: Andy Taylor Date: 2015-05-05T10:08:52Z use host argument properly with CLI create command --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request: add getter method for channel and c...
GitHub user jmesnil opened a pull request: https://github.com/apache/activemq-artemis/pull/224 add getter method for channel and channelName fields You can merge this pull request into a Git repository by running: $ git pull https://github.com/jmesnil/activemq-artemis ChannelBroadcastEndpointFactory_getter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/224.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #224 commit 0648d47e34bb83517f20ed08cb73f957952e6d71 Author: Jeff Mesnil Date: 2015-04-28T14:44:38Z add getter method for channel and channelName fields --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---