Re: [PROPOSAL] Apache ActiveMQ 5.15.7 release
Sounds good, thanks ! Regards JB On 23/10/2018 17:43, Christopher Shannon wrote: > I will take care of it but I’m unexpectedly out of the office today so I > plan to do the release first thing early tomorrow morning (US eastern time) > > On Mon, Oct 22, 2018 at 12:06 PM Jean-Baptiste Onofré > wrote: > >> I can also tackle that if you want. Up to you. >> >> Thanks ! >> >> Regards >> JB >> >> Le 22 oct. 2018 à 18:04, à 18:04, Christopher Shannon < >> christopher.l.shan...@gmail.com> a écrit: >>> I can create the release and call a vote tomorrow morning if there are >>> no >>> other blockers that come up. >>> >>> On Sun, Oct 21, 2018 at 1:46 PM jgenender wrote: >>> Yep... AMQ-7082 certainly should be in 5.15.7, so I merged it. This >>> closes the loop on the delays on shutdown. Hopefully all were cool with me >>> cherry picking it in. -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html >> >
[GitHub] activemq-artemis issue #2391: Add page decoding test for large message …
Github user soul2zimate commented on the issue: https://github.com/apache/activemq-artemis/pull/2391 I updated commit message and PR title. ---
[GitHub] activemq-artemis issue #2391: [ENTMQBR-2035][JBEAP-15599] add page decoding ...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2391 You shouldnât reference an external JiRA on a commit. ---
[GitHub] activemq-artemis pull request #2391: [ENTMQBR-2035][JBEAP-15599] add page de...
GitHub user soul2zimate opened a pull request: https://github.com/apache/activemq-artemis/pull/2391 [ENTMQBR-2035][JBEAP-15599] add page decoding test for large message ⦠â¦with no persistence (cherry picked from commit aba9384139956aaf37bde4fc881c7a0e27bbcf32) Test change port from downstream https://github.com/rh-messaging/jboss-activemq-artemis/pull/276 This just make sure problem described in https://issues.jboss.org/browse/JBEAP-15599 and https://issues.jboss.org/browse/ENTMQBR-2035 does not present in upstream. (Fixed in upstream by https://github.com/rh-messaging/jboss-activemq-artemis/commit/fe0ca4d84fc587b701e4b83ae8e5f2240c222842) You can merge this pull request into a Git repository by running: $ git pull https://github.com/soul2zimate/jboss-activemq-artemis NO_JIRA_TEST Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2391.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2391 commit 111d9f3ea43ea62bc9e9a2e4f9b0cc724c6c1104 Author: Chao Wang Date: 2018-10-23T08:44:40Z [ENTMQBR-2035][JBEAP-15599] add page decoding test for large message with no persistence (cherry picked from commit aba9384139956aaf37bde4fc881c7a0e27bbcf32) ---
[GitHub] activemq-artemis issue #2388: ARTEMIS-1856 support delays before deleting ad...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2388 LGTM, will merge tomorrow if no one beats me to it. ---
[GitHub] activemq-artemis pull request #2389: NO-JIRA Remove dead jms code from broke...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2389 ---
[GitHub] activemq-artemis issue #2390: NO-JIRA Move JMS_SESSION_CLIENT_ID_PROPERTY to...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2390 N.B. this requires https://github.com/apache/activemq-artemis/pull/2389 to merge first, as that removes last usage of this broker side (dead code) ---
[GitHub] activemq-artemis pull request #2390: NO-JIRA Move JMS_SESSION_CLIENT_ID_PROP...
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2390 NO-JIRA Move JMS_SESSION_CLIENT_ID_PROPERTY to JMS module Remove JMS specifics from CORE, that are not used in broker (typically back compatibility only now) You can merge this pull request into a Git repository by running: $ git pull https://github.com/michaelandrepearce/activemq-artemis RemoveJMS_SESSION_CLIENT_ID_PROPERTY Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2390.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2390 commit 3a2bfe5c87724f7e833df400664c057b521bc4b9 Author: Michael André Pearce Date: 2018-10-24T01:24:39Z NO-JIRA Move JMS_SESSION_CLIENT_ID_PROPERTY to JMS module Remove JMS specifics from CORE, that are not used in broker (typically back compatibility only now) ---
[GitHub] activemq-artemis issue #2376: [ARTEMIS-2130]Web console display blank Client...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2376 I agree with @michaelandrepearce - JMS specifics should not be built into the console (or any part of the core broker, for that matter). The session contains generic meta-data which can be displayed on the console and then users can interpret that meta-data as necessary for their applications. We've worked hard to get JMS stuff out of the core broker to better support other protocols. Let's not add it back in. ---
[GitHub] activemq-artemis pull request #2389: NO-JIRA Remove dead jms code from broke...
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2389 NO-JIRA Remove dead jms code from broker You can merge this pull request into a Git repository by running: $ git pull https://github.com/michaelandrepearce/activemq-artemis RemoveDeadJMSCode Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2389.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2389 ---
[GitHub] activemq-artemis pull request #2376: [ARTEMIS-2130]Web console display blank...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2376#discussion_r227610048
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ProducerView.java
---
@@ -79,7 +79,7 @@ public Object getField(ServerProducer producer, String
fieldName) {
case "user":
return session.getUsername();
case "clientID":
-return session.getRemotingConnection().getClientID();
+return session.getMetaData("jms-client-id") == null ?
session.getRemotingConnection().getClientID() :
session.getMetaData("jms-client-id");
--- End diff --
this should not be needed, if anything the session and producer models
should be re-worked to allow for a client id to be set at session level
generically.
---
[GitHub] activemq-artemis pull request #2376: [ARTEMIS-2130]Web console display blank...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2376#discussion_r227610014
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java
---
@@ -82,7 +82,7 @@ public Object getField(ServerConsumer consumer, String
fieldName) {
case "user":
return session.getUsername();
case "clientID":
-return consumer.getConnectionClientID();
+return session.getMetaData("jms-client-id") == null ?
consumer.getConnectionClientID() : session.getMetaData("jms-client-id");
--- End diff --
this should not be needed, if anything the session and consumer models
should be re-worked to allow for a client id to be set at session level
generically.
---
[GitHub] activemq-artemis pull request #2376: [ARTEMIS-2130]Web console display blank...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2376#discussion_r227609704
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConnectionView.java
---
@@ -91,7 +95,14 @@ public Object getField(RemotingConnection connection,
String fieldName) {
case "protocol":
return connection.getProtocolName();
case "clientID":
-return connection.getClientID();
+String clientID = null;
+for (ServerSession session : sessions) {
+ if (clientID == null) {
+ clientID = session.getMetaData("jms-client-id") == null
? connection.getClientID() : session.getMetaData("jms-client-id");
--- End diff --
jms specifics should not be in core broker. Also this is the connection
view, this data is off the session view, so should be visible there, not on the
connection.
---
[GitHub] activemq-artemis pull request #2376: [ARTEMIS-2130]Web console display blank...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2376#discussion_r227609451
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConnectionView.java
---
@@ -51,10 +51,14 @@ public JsonObjectBuilder toJson(RemotingConnection
connection) {
List sessions =
server.getSessions(connection.getID().toString());
Set users = new HashSet<>();
+ String clientID = null;
for (ServerSession session : sessions) {
String username = session.getUsername() == null ? "" :
session.getUsername();
users.add(username);
+ if (clientID == null) {
+clientID = session.getMetaData("jms-client-id") == null ?
connection.getClientID() : session.getMetaData("jms-client-id");
--- End diff --
should avoid jms specifics such as this.
---
[GitHub] activemq-artemis pull request #2388: ARTEMIS-1856 support delays before dele...
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2388#discussion_r227609075
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -1540,6 +1561,75 @@ public void run() {
}
}
+ private final class AddressQueueReaper extends
ActiveMQScheduledComponent {
+
+ AddressQueueReaper(ScheduledExecutorService scheduledExecutorService,
+ Executor executor,
+ long checkPeriod,
+ TimeUnit timeUnit,
+ boolean onDemand) {
+ super(scheduledExecutorService, executor, checkPeriod, timeUnit,
onDemand);
+ }
+
+ @Override
+ public void run() {
+ Map nameMap = addressManager.getBindings();
+
+ List queues = new ArrayList<>();
+
+ for (Binding binding : nameMap.values()) {
+if (binding.getType() == BindingType.LOCAL_QUEUE) {
+ Queue queue = (Queue) binding.getBindable();
+
+ queues.add(queue);
+}
+ }
+
+ for (Queue queue : queues) {
+int consumerCount = queue.getConsumerCount();
+long messageCount = queue.getMessageCount();
+boolean autoCreated = queue.isAutoCreated();
+long consumerRemovedTimestamp =
queue.getConsumerRemovedTimestamp();
+
+if (!queue.isInternalQueue() && autoCreated && messageCount ==
0 && consumerCount == 0 && consumerRemovedTimestamp != -1) {
+ SimpleString queueName = queue.getName();
+ AddressSettings settings =
addressSettingsRepository.getMatch(queue.getAddress().toString());
+ if (settings.isAutoDeleteQueues() &&
(System.currentTimeMillis() - consumerRemovedTimestamp >=
settings.getAutoDeleteQueuesDelay())) {
+ if (ActiveMQServerLogger.LOGGER.isDebugEnabled()) {
+ ActiveMQServerLogger.LOGGER.info("deleting
auto-created queue \"" + queueName + ".\" consumerCount = " + consumerCount +
"; messageCount = " + messageCount + "; isAutoDeleteQueues = " +
settings.isAutoDeleteQueues());
+ }
+
+ try {
+ server.destroyQueue(queueName, null, true, false);
--- End diff --
@michaelandrepearce is right, but I think it's worth mitigating the risk
within the bounds of the current locking scheme. What I don't want to do is
introduce additional locking or synchronization.
---
[GitHub] activemq-artemis issue #2384: ARTEMIS-2141 Add Filter column to Consumers Vi...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2384 Please also update ConsumerFilterPredicate to handle the new field, see QueueFilterPredicate for example of handling filter in the filterpredicates ---
[GitHub] activemq-artemis pull request #2384: ARTEMIS-2141 Add Filter column to Consu...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2384#discussion_r227607588
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java
---
@@ -89,6 +90,8 @@ public Object getField(ServerConsumer consumer, String
fieldName) {
return consumer.getQueueName();
case "queueType":
return consumer.getQueueType();
+ case "filter":
+return consumer.getFilter() == null ? "" :
consumer.getFilter().getFilterString();
--- End diff --
Rather than the dupe logic here and on line 61, create a method to
getFilterString.
Also if null, should return null, not empty string.
return filter != null ? filter.getFilterString().toString() : null;
e.g. should be same logic as in QueueControlImpl
---
[GitHub] activemq-artemis pull request #2388: ARTEMIS-1856 support delays before dele...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2388#discussion_r227604758
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -1540,6 +1561,75 @@ public void run() {
}
}
+ private final class AddressQueueReaper extends
ActiveMQScheduledComponent {
+
+ AddressQueueReaper(ScheduledExecutorService scheduledExecutorService,
+ Executor executor,
+ long checkPeriod,
+ TimeUnit timeUnit,
+ boolean onDemand) {
+ super(scheduledExecutorService, executor, checkPeriod, timeUnit,
onDemand);
+ }
+
+ @Override
+ public void run() {
+ Map nameMap = addressManager.getBindings();
+
+ List queues = new ArrayList<>();
+
+ for (Binding binding : nameMap.values()) {
+if (binding.getType() == BindingType.LOCAL_QUEUE) {
+ Queue queue = (Queue) binding.getBindable();
+
+ queues.add(queue);
+}
+ }
+
+ for (Queue queue : queues) {
+int consumerCount = queue.getConsumerCount();
+long messageCount = queue.getMessageCount();
+boolean autoCreated = queue.isAutoCreated();
+long consumerRemovedTimestamp =
queue.getConsumerRemovedTimestamp();
+
+if (!queue.isInternalQueue() && autoCreated && messageCount ==
0 && consumerCount == 0 && consumerRemovedTimestamp != -1) {
+ SimpleString queueName = queue.getName();
+ AddressSettings settings =
addressSettingsRepository.getMatch(queue.getAddress().toString());
+ if (settings.isAutoDeleteQueues() &&
(System.currentTimeMillis() - consumerRemovedTimestamp >=
settings.getAutoDeleteQueuesDelay())) {
+ if (ActiveMQServerLogger.LOGGER.isDebugEnabled()) {
+ ActiveMQServerLogger.LOGGER.info("deleting
auto-created queue \"" + queueName + ".\" consumerCount = " + consumerCount +
"; messageCount = " + messageCount + "; isAutoDeleteQueues = " +
settings.isAutoDeleteQueues());
+ }
+
+ try {
+ server.destroyQueue(queueName, null, true, false);
--- End diff --
The chance of this existed (and still does) in the existing
QueueManagerImpl logic where no delay is taken into account.
---
Re: Website
What about this. WE could :
- commit this on git
- upload a snapshot for review under our web-site.
On Mon, Oct 22, 2018 at 8:46 AM Clebert Suconic
wrote:
>
> +1000. We had that options discussed here a few times. Having the old
> website somewhere with a link is the way to go for the migration.
>
> On Mon, Oct 22, 2018 at 7:47 AM michael.andre.pearce
> wrote:
>>
>> Sounds good to me.
>>
>>
>> Sent from my Samsung Galaxy smartphone.
>> Original message From: Martyn Taylor
>> Date: 22/10/2018 12:38 (GMT+00:00) To: dev@activemq.apache.org Subject:
>> Re: Website
>> How about an equivalent message on the home page of the new website,
>> directing users to the old site?
>>
>> On Fri, Oct 19, 2018 at 10:39 PM Bruce Snyder
>> wrote:
>>
>> > Check out the Camel website and the message that they posted about their
>> > website changes that are underway:
>> >
>> > https://camel.apache.org/
>> >
>> > Bruce
>> >
>> > On Wed, Oct 17, 2018 at 3:30 AM Martyn Taylor wrote:
>> >
>> > > On Fri, Oct 12, 2018 at 8:38 PM Bruce Snyder
>> > > wrote:
>> > >
>> > > > Fair points, Martyn. I like the idea of a combination of JIRA issues
>> > > plus a
>> > > > list of those issues that is easily visible somewhere such as the wiki.
>> > > >
>> > > > Seeing as how we are moving the website around completely, I believe we
>> > > > need to include the docs to support the older versions in some way. So,
>> > > the
>> > > > first thought that came to mind is a search capability in order for
>> > users
>> > > > to find them easier. Another idea, we could also keep the old site
>> > intact
>> > > > and available as a sub-domain or URL, e.g., 5x.activemq.apache.org,
>> > > > activemq.apache.org/5.x, etc. However, the advantage of a search
>> > feature
>> > > > is
>> > > > that it would be useful across the site, not just for older stuff. We
>> > > might
>> > > > even be able structure the search to allow users to select a version of
>> > > the
>> > > > docs that they would like to search. Anyway, just some thoughts.
>> > > >
>> > > > I agree that we should try to get the new site functional ASAP, but
>> > that
>> > > > should not eliminate the old site entirely. We should not abandon users
>> > > of
>> > > > older versions.
>> > > >
>> > > +1 Bruce.
>> > >
>> > > I had thought that the export of the current site into the gitbook had
>> > all
>> > > the info, but perhaps there are missing pieces. I like the idea of
>> > keeping
>> > > the old site running and link to it from the new site. This ensures
>> > > existing users have all the info they need, but let's us move forward
>> > with
>> > > new content. Perhaps we can switch out the exiting home page for the new
>> > > one and add a link to old website AMQ project page ("Existing users
>> > looking
>> > > for the original ActiveMQ website click here."). If we are able to get
>> > > some stats on number of accesses to a particular page, we can use that
>> > info
>> > > to prioritise porting older content.
>> > >
>> > > Search, feature also a good idea, but I'm not sure how much effort would
>> > be
>> > > involved, there is already a search feature in the gitbook document
>> > (linked
>> > > to on the project page).
>> > >
>> > > How about we fill in the existing placeholder content and add links to
>> > the
>> > > old sites from each project page (and the home page)? We could go live
>> > > with this? Then start working through the nice to haves/criticals. I
>> > > think once we're live and the code is available, the community will be
>> > more
>> > > inclined to report/fixing issues.
>> > >
>> > > Cheers
>> > >
>> > > >
>> > > > Bruce
>> > > >
>> > > > On Fri, Oct 12, 2018 at 2:44 AM Martyn Taylor
>> > > wrote:
>> > > >
>> > > > > Cheers gents, looks like we're all set with the git repos.
>> > > > >
>> > > > > Shall we start putting together a ToDo list for what needs to happen
>> > to
>> > > > > move to the new site? JIRA perhaps?
>> > > > >
>> > > > > Bruce you mentioned a search feature for older content. Can you
>> > > > elaborate
>> > > > > on this. Also, there's the actual content for the pages, key
>> > features,
>> > > > > users etc... Perhaps we can all contribute to these? I could take
>> > care
>> > > > of
>> > > > > the Artemis side of things, if people with more experience in NMS,
>> > CMS
>> > > > and
>> > > > > 5.x could come up with some content for the project home pages?
>> > > > >
>> > > > > I agree with Michael in that it'd be good to get the new site running
>> > > > even
>> > > > > if it's not 100% perfect then iteratively improve on it.
>> > > > >
>> > > > > Cheers
>> > > > >
>> > > > > On Thu, Oct 11, 2018 at 12:56 AM Clebert Suconic <
>> > > > > clebert.suco...@gmail.com>
>> > > > > wrote:
>> > > > >
>> > > > > > How to delete one now ?
>> > > > > >
>> > > > > > On Tue, Oct 9, 2018 at 6:55 PM Bruce Snyder <
>> > bruce.sny...@gmail.com>
>> > > > > > wrote:
>> > > > > >
>> > > > > > > Whoops, I just created one as well:
>>
[GitHub] activemq-artemis pull request #2388: ARTEMIS-1856 support delays before dele...
Github user sebthom commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2388#discussion_r227494586
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -1540,6 +1561,75 @@ public void run() {
}
}
+ private final class AddressQueueReaper extends
ActiveMQScheduledComponent {
+
+ AddressQueueReaper(ScheduledExecutorService scheduledExecutorService,
+ Executor executor,
+ long checkPeriod,
+ TimeUnit timeUnit,
+ boolean onDemand) {
+ super(scheduledExecutorService, executor, checkPeriod, timeUnit,
onDemand);
+ }
+
+ @Override
+ public void run() {
+ Map nameMap = addressManager.getBindings();
+
+ List queues = new ArrayList<>();
+
+ for (Binding binding : nameMap.values()) {
+if (binding.getType() == BindingType.LOCAL_QUEUE) {
+ Queue queue = (Queue) binding.getBindable();
+
+ queues.add(queue);
+}
+ }
+
+ for (Queue queue : queues) {
+int consumerCount = queue.getConsumerCount();
+long messageCount = queue.getMessageCount();
+boolean autoCreated = queue.isAutoCreated();
+long consumerRemovedTimestamp =
queue.getConsumerRemovedTimestamp();
+
+if (!queue.isInternalQueue() && autoCreated && messageCount ==
0 && consumerCount == 0 && consumerRemovedTimestamp != -1) {
+ SimpleString queueName = queue.getName();
+ AddressSettings settings =
addressSettingsRepository.getMatch(queue.getAddress().toString());
+ if (settings.isAutoDeleteQueues() &&
(System.currentTimeMillis() - consumerRemovedTimestamp >=
settings.getAutoDeleteQueuesDelay())) {
+ if (ActiveMQServerLogger.LOGGER.isDebugEnabled()) {
+ ActiveMQServerLogger.LOGGER.info("deleting
auto-created queue \"" + queueName + ".\" consumerCount = " + consumerCount +
"; messageCount = " + messageCount + "; isAutoDeleteQueues = " +
settings.isAutoDeleteQueues());
+ }
+
+ try {
+ server.destroyQueue(queueName, null, true, false);
--- End diff --
What happens if a message was added to the queue in the time between
queue.getMessageCount() was invoked and server.destroyQueue() is executed.
Maybe ActiveMQServer.destroyQueue() needs to be extended by a
"checkMessageCount" parameter?
---
Re: [PROPOSAL] Apache ActiveMQ 5.15.7 release
I will take care of it but I’m unexpectedly out of the office today so I plan to do the release first thing early tomorrow morning (US eastern time) On Mon, Oct 22, 2018 at 12:06 PM Jean-Baptiste Onofré wrote: > I can also tackle that if you want. Up to you. > > Thanks ! > > Regards > JB > > Le 22 oct. 2018 à 18:04, à 18:04, Christopher Shannon < > christopher.l.shan...@gmail.com> a écrit: > >I can create the release and call a vote tomorrow morning if there are > >no > >other blockers that come up. > > > >On Sun, Oct 21, 2018 at 1:46 PM jgenender wrote: > > > >> Yep... AMQ-7082 certainly should be in 5.15.7, so I merged it. This > >closes > >> the loop on the delays on shutdown. Hopefully all were cool with me > >cherry > >> picking it in. > >> > >> > >> > >> -- > >> Sent from: > >> http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html > >> >
[GitHub] activemq-artemis pull request #2388: ARTEMIS-1856 support delays before dele...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2388 ARTEMIS-1856 support delays before deleting addresses & queues You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1856 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2388.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2388 commit e6b099db88317f8eb2913a48d6e8d53fc0e5ea8e Author: Justin Bertram Date: 2018-09-24T21:37:28Z ARTEMIS-1856 support delays before deleting addresses & queues ---
[GitHub] activemq-artemis pull request #2383: ARTEMIS-2096 Adding a test
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2383 ---
[GitHub] activemq-artemis issue #2383: ARTEMIS-2096 Adding a test
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2383 @gaohoward this is actually ARTEMIS-2135, which I fixed in 2.6.x and added a test. Also verified that @tabish121 ' s refactoring fixed it.. but the actual issue for this test is ARTEMIS-2135. Which I had already fixed in 48e0fc8f42346d96bc809593a150e05a586787ee at 2.6.x. ---
[GitHub] activemq-artemis issue #2387: ARTEMIS-2142 Support JMSXGroupSeq -1to close/r...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2387 This is to provide feature parity with ActiveMQ 5.x, with being able to close a group using -1 group sequence. http://activemq.apache.org/message-groups.html ---
[GitHub] activemq-artemis pull request #2387: ARTEMIS-2142 Support JMSXGroupSeq -1to ...
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2387 ARTEMIS-2142 Support JMSXGroupSeq -1to close/reset group Add test cases Add GroupSequence to Message Interface Implement Support closing/reset group in queue impl Change/Fix OpenWireMessageConverter to use default of 0 if not set, for OpenWire as per documentation http://activemq.apache.org/activemq-message-properties.html You can merge this pull request into a Git repository by running: $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-2142 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2387.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2387 commit 75df0dec3e4b02e4a90cdcceaf553c511ba2a483 Author: Michael André Pearce Date: 2018-10-22T15:31:00Z ARTEMIS-2142 Support JMSXGroupSeq -1to close/reset group Add test cases Add GroupSequence to Message Interface Implement Support closing/reset group in queue impl Change/Fix OpenWireMessageConverter to use default of 0 if not set, for OpenWire as per documentation http://activemq.apache.org/activemq-message-properties.html ---
Re: Website
+1.
On Mon, Oct 22, 2018 at 8:46 PM Clebert Suconic
wrote:
> +1000. We had that options discussed here a few times. Having the old
> website somewhere with a link is the way to go for the migration.
>
> On Mon, Oct 22, 2018 at 7:47 AM michael.andre.pearce
> wrote:
>
> > Sounds good to me.
> >
> >
> > Sent from my Samsung Galaxy smartphone.
> > Original message From: Martyn Taylor <
> mtay...@redhat.com>
> > Date: 22/10/2018 12:38 (GMT+00:00) To: dev@activemq.apache.org
> Subject:
> > Re: Website
> > How about an equivalent message on the home page of the new website,
> > directing users to the old site?
> >
> > On Fri, Oct 19, 2018 at 10:39 PM Bruce Snyder
> > wrote:
> >
> > > Check out the Camel website and the message that they posted about
> their
> > > website changes that are underway:
> > >
> > > https://camel.apache.org/
> > >
> > > Bruce
> > >
> > > On Wed, Oct 17, 2018 at 3:30 AM Martyn Taylor
> > wrote:
> > >
> > > > On Fri, Oct 12, 2018 at 8:38 PM Bruce Snyder >
> > > > wrote:
> > > >
> > > > > Fair points, Martyn. I like the idea of a combination of JIRA
> issues
> > > > plus a
> > > > > list of those issues that is easily visible somewhere such as the
> > wiki.
> > > > >
> > > > > Seeing as how we are moving the website around completely, I
> believe
> > we
> > > > > need to include the docs to support the older versions in some way.
> > So,
> > > > the
> > > > > first thought that came to mind is a search capability in order for
> > > users
> > > > > to find them easier. Another idea, we could also keep the old site
> > > intact
> > > > > and available as a sub-domain or URL, e.g., 5x.activemq.apache.org
> ,
> > > > > activemq.apache.org/5.x, etc. However, the advantage of a search
> > > feature
> > > > > is
> > > > > that it would be useful across the site, not just for older stuff.
> We
> > > > might
> > > > > even be able structure the search to allow users to select a
> version
> > of
> > > > the
> > > > > docs that they would like to search. Anyway, just some thoughts.
> > > > >
> > > > > I agree that we should try to get the new site functional ASAP, but
> > > that
> > > > > should not eliminate the old site entirely. We should not abandon
> > users
> > > > of
> > > > > older versions.
> > > > >
> > > > +1 Bruce.
> > > >
> > > > I had thought that the export of the current site into the gitbook
> had
> > > all
> > > > the info, but perhaps there are missing pieces. I like the idea of
> > > keeping
> > > > the old site running and link to it from the new site. This ensures
> > > > existing users have all the info they need, but let's us move forward
> > > with
> > > > new content. Perhaps we can switch out the exiting home page for the
> > new
> > > > one and add a link to old website AMQ project page ("Existing users
> > > looking
> > > > for the original ActiveMQ website click here."). If we are able to
> get
> > > > some stats on number of accesses to a particular page, we can use
> that
> > > info
> > > > to prioritise porting older content.
> > > >
> > > > Search, feature also a good idea, but I'm not sure how much effort
> > would
> > > be
> > > > involved, there is already a search feature in the gitbook document
> > > (linked
> > > > to on the project page).
> > > >
> > > > How about we fill in the existing placeholder content and add links
> to
> > > the
> > > > old sites from each project page (and the home page)? We could go
> live
> > > > with this? Then start working through the nice to haves/criticals.
> I
> > > > think once we're live and the code is available, the community will
> be
> > > more
> > > > inclined to report/fixing issues.
> > > >
> > > > Cheers
> > > >
> > > > >
> > > > > Bruce
> > > > >
> > > > > On Fri, Oct 12, 2018 at 2:44 AM Martyn Taylor
> > > > wrote:
> > > > >
> > > > > > Cheers gents, looks like we're all set with the git repos.
> > > > > >
> > > > > > Shall we start putting together a ToDo list for what needs to
> > happen
> > > to
> > > > > > move to the new site? JIRA perhaps?
> > > > > >
> > > > > > Bruce you mentioned a search feature for older content. Can you
> > > > > elaborate
> > > > > > on this. Also, there's the actual content for the pages, key
> > > features,
> > > > > > users etc... Perhaps we can all contribute to these? I could
> take
> > > care
> > > > > of
> > > > > > the Artemis side of things, if people with more experience in
> NMS,
> > > CMS
> > > > > and
> > > > > > 5.x could come up with some content for the project home pages?
> > > > > >
> > > > > > I agree with Michael in that it'd be good to get the new site
> > running
> > > > > even
> > > > > > if it's not 100% perfect then iteratively improve on it.
> > > > > >
> > > > > > Cheers
> > > > > >
> > > > > > On Thu, Oct 11, 2018 at 12:56 AM Clebert Suconic <
> > > > > > clebert.suco...@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > How to delete one now ?
> > > > > > >
> > > > > > > On Tue, Oct 9, 2018 at 6:55 PM Bruce Snyder
