Re: PR Process on github.com/activemq6 repo
updated the infra ticket to request the hooks - https://issues.apache.org/jira/browse/INFRA-8485?focusedCommentId=14214758&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14214758 On 13 November 2014 12:14, Daniel Kulp wrote: > It looks like when Hiram asked for the activemq-6 GIT repo to be created, > he didn’t specifically ask for all the github integration hooks to be > installed. The pull requests should have been sending email to this list. > It should be commenting on the JIRA’s automatically. I don’t think the log > message thing to close the issues will work either. > > Hiram: can you file another request with infra to have them enable the > complete set of github integration hooks for the activemq-6 repo with > notices and such going to dev@activemq.apache.org? > > Dan > > > On Nov 12, 2014, at 11:21 AM, Clebert Suconic > wrote: > > > > I would like us to use the pull request approach on > > github.com/apache/activemq-6. > > > > To me that's a no brainer... PR commits is the best approach... simpler > to > > handle, review.. and you could even get tests working to validate the > > changes are consistent and accurate with the testsuite. It really > improves > > collaboration with anyone interested in contribute code. > > > > > > However, We have a two issues to get sorted to make that work: > > > > I - PR builds We will need a bot user that would have push authorization > on > > the mirror: > > > https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin > > > > II - Authorization for committers to close PRs. > > We will merge PRs manually but we still need a way to close PRs when we > > reject issues. > > -- > Daniel Kulp > dk...@apache.org - http://dankulp.com/blog > Talend Community Coder - http://coders.talend.com > >
Re: PR Process on github.com/activemq6 repo
It looks like when Hiram asked for the activemq-6 GIT repo to be created, he didn’t specifically ask for all the github integration hooks to be installed. The pull requests should have been sending email to this list. It should be commenting on the JIRA’s automatically. I don’t think the log message thing to close the issues will work either. Hiram: can you file another request with infra to have them enable the complete set of github integration hooks for the activemq-6 repo with notices and such going to dev@activemq.apache.org? Dan > On Nov 12, 2014, at 11:21 AM, Clebert Suconic > wrote: > > I would like us to use the pull request approach on > github.com/apache/activemq-6. > > To me that's a no brainer... PR commits is the best approach... simpler to > handle, review.. and you could even get tests working to validate the > changes are consistent and accurate with the testsuite. It really improves > collaboration with anyone interested in contribute code. > > > However, We have a two issues to get sorted to make that work: > > I - PR builds We will need a bot user that would have push authorization on > the mirror: > https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin > > II - Authorization for committers to close PRs. > We will merge PRs manually but we still need a way to close PRs when we > reject issues. -- Daniel Kulp dk...@apache.org - http://dankulp.com/blog Talend Community Coder - http://coders.talend.com
Re: PR Process on github.com/activemq6 repo
On 12 November 2014 16:55, Clebert Suconic
wrote:
> >
> > In the past this has been ruled out, committers can request addition to
> the
> > 'Apache' organization on github that the mirrors live under, but only
> infra
> > team members have the necessary rights to update anything within it. The
> > expectation seems to be that you either file JIRA requests with infra to
> > clean up stale Pull Requests, ask the person who opened it to close it,
> or
> > leverage commit messages to do so ("This closes #foo" etc) when merging
> to
> > the ASF hosted git repo.
> >
> >
> I got the impression that you would see this empty merge commit message on
> the logs.
> I don't want to increase the log with any message to close a PR.
> If that's not happening it's probably ok... I'm just afraid of the history
> to build up in anyways when we reject PRs.
>
The only committer ability to close Pull Requests is via the log messages
so far as I am aware, otherwise you need to ask infra or the original
requester to close.
That said, as I have never actually merged a pull request I'm not
necessarily the best person to comment, I'm just repeating what I have read
or been told in the past. I have only ever asked infra to close a couple of
stale PRs after the changes were actually committed via raising a JIRA and
attaching a patch, and the resultant commits didn't reference the pull
requst and the original requesters didnt respond to request to close them.
Robbie
Re: PR Process on github.com/activemq6 repo
>
> In the past this has been ruled out, committers can request addition to the
> 'Apache' organization on github that the mirrors live under, but only infra
> team members have the necessary rights to update anything within it. The
> expectation seems to be that you either file JIRA requests with infra to
> clean up stale Pull Requests, ask the person who opened it to close it, or
> leverage commit messages to do so ("This closes #foo" etc) when merging to
> the ASF hosted git repo.
>
>
I got the impression that you would see this empty merge commit message on
the logs.
I don't want to increase the log with any message to close a PR.
If that's not happening it's probably ok... I'm just afraid of the history
to build up in anyways when we reject PRs.
Re: PR Process on github.com/activemq6 repo
On 12 November 2014 16:21, Clebert Suconic
wrote:
> I would like us to use the pull request approach on
> github.com/apache/activemq-6.
>
> To me that's a no brainer... PR commits is the best approach... simpler to
> handle, review.. and you could even get tests working to validate the
> changes are consistent and accurate with the testsuite. It really improves
> collaboration with anyone interested in contribute code.
>
>
> However, We have a two issues to get sorted to make that work:
>
> I - PR builds We will need a bot user that would have push authorization on
> the mirror:
>
> https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin
>
>
I doubt infra would be happy with a bot user having push rights to the
repo. There is a Pull Request build process (sounds like you already found
that though) leveraging the ASF Jenkins instances though. You can log in to
Jenkins with your existing committer ldap credentials, but you will need
granted rights (by the PMC chair usually) to actually configure anything on
it.
https://blogs.apache.org/infra/entry/github_pull_request_builds_now
> II - Authorization for committers to close PRs.
> We will merge PRs manually but we still need a way to close PRs when we
> reject issues.
>
In the past this has been ruled out, committers can request addition to the
'Apache' organization on github that the mirrors live under, but only infra
team members have the necessary rights to update anything within it. The
expectation seems to be that you either file JIRA requests with infra to
clean up stale Pull Requests, ask the person who opened it to close it, or
leverage commit messages to do so ("This closes #foo" etc) when merging to
the ASF hosted git repo.
Robbie
Re: PR Process on github.com/activemq6 repo
I pressed send prematurely by accident... I googled for it and there seems to be an apacheBot user we could use for the PR builds. I would need some help on setting up a JOB for the PR build on the ci.apache. and we also need the authorization to close PRs when they are rejected. Any ideas on how to get it sorted? On Wed, Nov 12, 2014 at 11:21 AM, Clebert Suconic wrote: > I would like us to use the pull request approach on > github.com/apache/activemq-6. > > To me that's a no brainer... PR commits is the best approach... simpler to > handle, review.. and you could even get tests working to validate the > changes are consistent and accurate with the testsuite. It really improves > collaboration with anyone interested in contribute code. > > > However, We have a two issues to get sorted to make that work: > > I - PR builds We will need a bot user that would have push authorization > on the mirror: > > https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin > > II - Authorization for committers to close PRs. > We will merge PRs manually but we still need a way to close PRs when we > reject issues. > -- Clebert Suconic http://community.jboss.org/people/clebert.suco...@jboss.com http://clebertsuconic.blogspot.com
PR Process on github.com/activemq6 repo
I would like us to use the pull request approach on github.com/apache/activemq-6. To me that's a no brainer... PR commits is the best approach... simpler to handle, review.. and you could even get tests working to validate the changes are consistent and accurate with the testsuite. It really improves collaboration with anyone interested in contribute code. However, We have a two issues to get sorted to make that work: I - PR builds We will need a bot user that would have push authorization on the mirror: https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin II - Authorization for committers to close PRs. We will merge PRs manually but we still need a way to close PRs when we reject issues.
