Re: Ant 1.6

[Conor MacNeill]

On Mon, 22 Sep 2003 08:11 pm, Antoine Lévy-Lambert wrote:
> I have tagged the ANT_16_BRANCH (actually 2 hours before schedule, hope it
> does not disturb anyone).
>

The fact that every commit now involves a merge to 1.6 or vice versa would 
indicate to me that this branch is too early. 

IMHO, If we are going to branch then let's fix everything on the branch and 
focus on getting 1.6  out the door. We  then do one merge.

The piecemeal merges will make it hardder to do a single merge and also make 
it more likely than something will be committed in one tree and not the 
other.

Just MHO.

Conor


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Ant 1.6

[Conor MacNeill]

On Tue, 23 Sep 2003 12:40 am, Stefan Bodewig wrote:
> On Mon, 22 Sep 2003, Antoine Lévy-Lambert <[EMAIL PROTECTED]>
>
> wrote:
> > - sort out if possible the CLASSPATH issue by :
>
> What you propose would probably work.
>
> On the other hand, Launcher could give us a chance to break away from
> the "everything is on a single classpath, which is as good as the
> system classpath" architecture of Main that, I fear, won't scale.
>
> Add -lib will solve some problem, the same sort of problems that can
> be solved by not using Launcher but Main.  I'm not sure whether it
> would prevent us from solving a different set of problems.
>
> All in all, I'm a bit neutral here as I fail to see all consequences.
>

I don't know if this will help with the CLASSPATH related issues but a -lib 
option is a good idea, anyway. It allows you to use one or more library 
directories without modifying the main Ant installation.

Conor


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23339] New: - Core Task War, Ear, Jar should have the M feature available

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23339

Core Task War, Ear, Jar should have the M feature available

   Summary: Core Task War, Ear, Jar should have the M feature
available
   Product: Ant
   Version: 1.5.4
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Core tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The MANIFEST.MF file has a Class-Path value that can be set to include jar 
files in the classpath of the above files.  The current core tasks however do 
not give the option to not create the Manifest file (using jar it is the M 
flag).  Because of this, if the Class-Path value is longer than 71 characters a 
hard line is used and the filenames are broken up.  This makes the Class-Path 
entry invalid for any listings after the end of the first line (including a 
separated file on the first line).  Recommend that an option be added to ANT to 
suppress the creation of the MANIFEST.MF file to be used in conjunction with 
the manifest option that allows for declaring the MANIFEST.MF file to be used 
with war, ear or jar.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[PATCH] and problem with patch.xml

[Shatzer, Larry]

While making changes to custom-programing.html, I found an invalid property
in the documentation.

"${mydomain.classes" which should be "${mydomain.classes}". 

When running patch.xml, it has a problem:

Caught exception (org.apache.tools.ant.BuildException) while expanding
no.copyright.set: Syntax error in property: <
classpath="${mydomain.classes"/>

Since patch.txt.tmp has both properties showing (invalid and valid), it
tries to expand them both, and fails.

I'm not quite sure how to fix this in patch.xml for future problems with
this. In the short term I've attached a patch to fix custom-programing.html
(along with a few other changes like use of " to " to be more
consistent, and spelling).

-- Larry

Index: docs/manual/CoreTypes/custom-programming.html
===
RCS file: /home/cvspublic/ant/docs/manual/CoreTypes/custom-programming.html,v
retrieving revision 1.2
diff -u -r1.2 custom-programming.html
--- docs/manual/CoreTypes/custom-programming.html   13 Aug 2003 09:05:22 
-  1.2
+++ docs/manual/CoreTypes/custom-programming.html   22 Sep 2003 21:59:54 
-
@@ -66,7 +66,7 @@
 // This method evaluates the condition
 public boolean eval() {
 if (value == null) {
-throw new BuildException("value attribute is not set");
+throw new BuildException("value attribute is not set");
 }
 return value.toUpperCase().equals(value);
}
@@ -80,9 +80,9 @@
 
   
 
+name="alluppercase"
+classname="com.mydomain.AllUpperCaseCondition"
+classpath="${mydomain.classes}"/>
   
 
 
@@ -91,8 +91,8 @@
 
 
   
-
-   
+
+   
 
   
 
@@ -110,7 +110,7 @@
 
 
   An example of a custom selection that selects filenames ending
-  in ".java" would be:
+  in ".java" would be:
 
 
   
@@ -119,7 +119,7 @@
 import org.apache.tools.ant.types.selectors.FileSelector;
 public class JavaSelector implements FileSelector {
 public boolean isSelected(File b, String filename, File f) {
-   return filename.toLowerCase().endsWith(".java");
+   return filename.toLowerCase().endsWith(".java");
 }
 }
   
@@ -130,9 +130,9 @@
 
   
 
+name="javaselector"
+classname="com.mydomain.JavaSelector"
+classpath="${mydomain.classes}"/>
   
 
 
@@ -141,8 +141,8 @@
 
 
   
-
-   
+
+   
   

 
@@ -190,7 +190,7 @@
 }
 public void verifySettings() {
 if (number < 0) {
-   throw new BuildException("Number attribute should be set");
+   throw new BuildException("Number attribute should be 
set");
 }
 }
 public boolean isSelected(File baseDir, String filename, File file) {
@@ -212,13 +212,13 @@
 
 
   
-
+
 ...
-
-   
-  
-  
+
+   
+  
+  
   

 
@@ -229,7 +229,7 @@
 
 
   The custom selector was the pre ant 1.6 way of defining custom selectors.
-  This method is still supported for backward compatiblity.
+  This method is still supported for backward compatibility.
 
 You can write your own selectors and use them within the selector
   containers by specifying them within the  tag.
@@ -386,7 +386,7 @@
private void lineNumber = 0;
public String filter(String string) {
   lineNumber++;
-  return "" + lineNumber + "\t" + string;
+  return "" + lineNumber + "\t" + string;
}
 }
   

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: ant/src/main/org/apache/tools/ant Main.java

[antoine]

antoine 2003/09/22 14:15:41

  Modified:src/script Tag: ANT_16_BRANCH ant ant.bat runant.pl
   src/main/org/apache/tools/ant/launch Tag: ANT_16_BRANCH
Launcher.java
   src/main/org/apache/tools/ant Tag: ANT_16_BRANCH Main.java
  Log:
  Merge last changes from HEAD
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.38.2.1  +4 -8  ant/src/script/ant
  
  Index: ant
  ===
  RCS file: /home/cvs/ant/src/script/ant,v
  retrieving revision 1.38
  retrieving revision 1.38.2.1
  diff -u -r1.38 -r1.38.2.1
  --- ant   10 Jul 2003 11:29:38 -  1.38
  +++ ant   22 Sep 2003 21:15:41 -  1.38.2.1
  @@ -100,10 +100,6 @@
 exit 1
   fi
   
  -if [ -n "$CLASSPATH" ] ; then
  -  LOCALCLASSPATH="$CLASSPATH"
  -fi
  -
   # in rpm_mode get ant/optional/xml parser&api from JAVALIBDIR
   if $rpm_mode; then
 JAVALIBDIR=/usr/share/java
  @@ -156,14 +152,14 @@
   
   if [ -n "$CYGHOME" ]; then
 if [ -n "$JIKESPATH" ]; then
  -exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" -Djikes.class.path="$JIKESPATH" 
-Dcygwin.user.home="$CYGHOME" org.apache.tools.ant.launch.Launcher $ANT_ARGS 
"$@"
  +exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" -Djikes.class.path="$JIKESPATH" 
-Dcygwin.user.home="$CYGHOME" org.apache.tools.ant.launch.Launcher $ANT_ARGS 
"$@" -lib "$CLASSPATH"
 else
  -exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" -Dcygwin.user.home="$CYGHOME" 
org.apache.tools.ant.launch.Launcher $ANT_ARGS "$@"
  +exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" -Dcygwin.user.home="$CYGHOME" 
org.apache.tools.ant.launch.Launcher $ANT_ARGS "$@" -lib "$CLASSPATH"
 fi
   else
 if [ -n "$JIKESPATH" ]; then
  -exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" -Djikes.class.path="$JIKESPATH" 
org.apache.tools.ant.launch.Launcher $ANT_ARGS "$@"
  +exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" -Djikes.class.path="$JIKESPATH" 
org.apache.tools.ant.launch.Launcher $ANT_ARGS "$@" -lib "$CLASSPATH"
 else
  -exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" org.apache.tools.ant.launch.Launcher $ANT_ARGS "$@"
  +exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" org.apache.tools.ant.launch.Launcher $ANT_ARGS "$@" 
-lib "$CLASSPATH"
 fi
   fi
  
  
  
  1.32.2.1  +11 -1 ant/src/script/ant.bat
  
  Index: ant.bat
  ===
  RCS file: /home/cvs/ant/src/script/ant.bat,v
  retrieving revision 1.32
  retrieving revision 1.32.2.1
  diff -u -r1.32 -r1.32.2.1
  --- ant.bat   10 Jul 2003 11:49:08 -  1.32
  +++ ant.bat   22 Sep 2003 21:15:41 -  1.32.2.1
  @@ -54,7 +54,7 @@
   
   :checkJava
   set _JAVACMD=%JAVACMD%
  -set LOCALCLASSPATH=%ANT_HOME%\lib\ant-launcher.jar;%CLASSPATH%
  +set LOCALCLASSPATH=%ANT_HOME%\lib\ant-launcher.jar
   
   if "%JAVA_HOME%" == "" goto noJavaHome
   if not exist "%JAVA_HOME%\bin\java.exe" goto noJavaHome
  @@ -68,11 +68,21 @@
   if not "%JIKESPATH%"=="" goto runAntWithJikes
   
   :runAnt
  +if not "%CLASSPATH%"=="" goto runAntWithClasspath
   "%_JAVACMD%" %ANT_OPTS% -classpath "%LOCALCLASSPATH%" 
"-Dant.home=%ANT_HOME%" org.apache.tools.ant.launch.Launcher %ANT_ARGS% 
%ANT_CMD_LINE_ARGS%
   goto end
   
  +:runAntWithClasspath
  +"%_JAVACMD%" %ANT_OPTS% -classpath "%LOCALCLASSPATH%" 
"-Dant.home=%ANT_HOME%" org.apache.tools.ant.launch.Launcher %ANT_ARGS% 
%ANT_CMD_LINE_ARGS% -lib "%CLASSPATH%"
  +goto end
  +
   :runAntWithJikes
  +if not "%CLASSPATH%"=="" goto runAntWithJikesAndClasspath
   "%_JAVACMD%" %ANT_OPTS% -classpath "%LOCALCLASSPATH%" 
"-Dant.home=%ANT_HOME%" "-Djikes.class.path=%JIKESPATH%" 
org.apache.tools.ant.launch.Launcher %ANT_ARGS% %ANT_CMD_LINE_ARGS%
  +goto end
  +
  +:runAntWithJikesAndClasspath
  +"%_JAVACMD%" %ANT_OPTS% -classpath "%LOCALCLASSPATH%" 
"-Dant.home=%ANT_HOME%" "-Djikes.class.path=%JIKESPATH%" 
org.apache.tools.ant.launch.Launcher %ANT_ARGS% %ANT_CMD_LINE_ARGS% -lib 
"%CLASSPATH%"
   goto end
   
   :end
  
  
  
  1.7.2.1   +24 -34ant/src/script/runant.pl
  
  Index: runant.pl
  ===
  RCS file: /home/cvs/ant/src/script/runant.pl,v
  retrieving revision 1.7
  retrieving revision 1.7.2.1
  diff -u -r1.7 -r1.7.2.1
  --- runant.pl 1 Sep 2003 10:52:43 -   1.7
  +++ runant.pl 22 Sep 2003 21:15:41 -  1.7.2.1
  @@ -39,7 +39,7 @@
   #use warnings;
   
   #and set $debug to 1 to turn on trace info
  -my $debug=0;
  +my $debug=1;
   
   ###
   #
  @@ -74,26 +74,7 @@

cvs commit: ant/src/main/org/apache/tools/ant Main.java

[antoine]

antoine 2003/09/22 14:10:10

  Modified:src/script ant ant.bat runant.pl
   src/main/org/apache/tools/ant/launch Launcher.java
   src/main/org/apache/tools/ant Main.java
  Log:
  adding a new supported command line argument -lib
  this command line argument is eaten by Launcher
  shell scripts reworked to pass the classpath in the right location
  
  Revision  ChangesPath
  1.39  +4 -8  ant/src/script/ant
  
  Index: ant
  ===
  RCS file: /home/cvs/ant/src/script/ant,v
  retrieving revision 1.38
  retrieving revision 1.39
  diff -u -r1.38 -r1.39
  --- ant   10 Jul 2003 11:29:38 -  1.38
  +++ ant   22 Sep 2003 21:10:10 -  1.39
  @@ -100,10 +100,6 @@
 exit 1
   fi
   
  -if [ -n "$CLASSPATH" ] ; then
  -  LOCALCLASSPATH="$CLASSPATH"
  -fi
  -
   # in rpm_mode get ant/optional/xml parser&api from JAVALIBDIR
   if $rpm_mode; then
 JAVALIBDIR=/usr/share/java
  @@ -156,14 +152,14 @@
   
   if [ -n "$CYGHOME" ]; then
 if [ -n "$JIKESPATH" ]; then
  -exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" -Djikes.class.path="$JIKESPATH" 
-Dcygwin.user.home="$CYGHOME" org.apache.tools.ant.launch.Launcher $ANT_ARGS 
"$@"
  +exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" -Djikes.class.path="$JIKESPATH" 
-Dcygwin.user.home="$CYGHOME" org.apache.tools.ant.launch.Launcher $ANT_ARGS 
"$@" -lib "$CLASSPATH"
 else
  -exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" -Dcygwin.user.home="$CYGHOME" 
org.apache.tools.ant.launch.Launcher $ANT_ARGS "$@"
  +exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" -Dcygwin.user.home="$CYGHOME" 
org.apache.tools.ant.launch.Launcher $ANT_ARGS "$@" -lib "$CLASSPATH"
 fi
   else
 if [ -n "$JIKESPATH" ]; then
  -exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" -Djikes.class.path="$JIKESPATH" 
org.apache.tools.ant.launch.Launcher $ANT_ARGS "$@"
  +exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" -Djikes.class.path="$JIKESPATH" 
org.apache.tools.ant.launch.Launcher $ANT_ARGS "$@" -lib "$CLASSPATH"
 else
  -exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" org.apache.tools.ant.launch.Launcher $ANT_ARGS "$@"
  +exec "$JAVACMD" $ANT_OPTS -classpath "$LOCALCLASSPATH" 
-Dant.home="${ANT_HOME}" org.apache.tools.ant.launch.Launcher $ANT_ARGS "$@" 
-lib "$CLASSPATH"
 fi
   fi
  
  
  
  1.33  +11 -1 ant/src/script/ant.bat
  
  Index: ant.bat
  ===
  RCS file: /home/cvs/ant/src/script/ant.bat,v
  retrieving revision 1.32
  retrieving revision 1.33
  diff -u -r1.32 -r1.33
  --- ant.bat   10 Jul 2003 11:49:08 -  1.32
  +++ ant.bat   22 Sep 2003 21:10:10 -  1.33
  @@ -54,7 +54,7 @@
   
   :checkJava
   set _JAVACMD=%JAVACMD%
  -set LOCALCLASSPATH=%ANT_HOME%\lib\ant-launcher.jar;%CLASSPATH%
  +set LOCALCLASSPATH=%ANT_HOME%\lib\ant-launcher.jar
   
   if "%JAVA_HOME%" == "" goto noJavaHome
   if not exist "%JAVA_HOME%\bin\java.exe" goto noJavaHome
  @@ -68,11 +68,21 @@
   if not "%JIKESPATH%"=="" goto runAntWithJikes
   
   :runAnt
  +if not "%CLASSPATH%"=="" goto runAntWithClasspath
   "%_JAVACMD%" %ANT_OPTS% -classpath "%LOCALCLASSPATH%" 
"-Dant.home=%ANT_HOME%" org.apache.tools.ant.launch.Launcher %ANT_ARGS% 
%ANT_CMD_LINE_ARGS%
   goto end
   
  +:runAntWithClasspath
  +"%_JAVACMD%" %ANT_OPTS% -classpath "%LOCALCLASSPATH%" 
"-Dant.home=%ANT_HOME%" org.apache.tools.ant.launch.Launcher %ANT_ARGS% 
%ANT_CMD_LINE_ARGS% -lib "%CLASSPATH%"
  +goto end
  +
   :runAntWithJikes
  +if not "%CLASSPATH%"=="" goto runAntWithJikesAndClasspath
   "%_JAVACMD%" %ANT_OPTS% -classpath "%LOCALCLASSPATH%" 
"-Dant.home=%ANT_HOME%" "-Djikes.class.path=%JIKESPATH%" 
org.apache.tools.ant.launch.Launcher %ANT_ARGS% %ANT_CMD_LINE_ARGS%
  +goto end
  +
  +:runAntWithJikesAndClasspath
  +"%_JAVACMD%" %ANT_OPTS% -classpath "%LOCALCLASSPATH%" 
"-Dant.home=%ANT_HOME%" "-Djikes.class.path=%JIKESPATH%" 
org.apache.tools.ant.launch.Launcher %ANT_ARGS% %ANT_CMD_LINE_ARGS% -lib 
"%CLASSPATH%"
   goto end
   
   :end
  
  
  
  1.8   +24 -34ant/src/script/runant.pl
  
  Index: runant.pl
  ===
  RCS file: /home/cvs/ant/src/script/runant.pl,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- runant.pl 1 Sep 2003 10:52:43 -   1.7
  +++ runant.pl 22 Sep 2003 21:10:10 -  1.8
  @@ -39,7 +39,7 @@
   #use warnings;
   
   #and set $debug to 1 to turn on trace info
  -my $debug=0;
  +my $debug=1;
   
   ###
   #
  @@ -74,26 +74,7 @@
   }
   
   #build up standard classp

cvs commit: ant/docs/manual/OptionalTasks perforce.html

[antoine]

antoine 2003/09/22 09:46:08

  Modified:docs/manual/OptionalTasks Tag: ANT_16_BRANCH perforce.html
  Log:
  Merging documentation change into ANT_16_BRANCH
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.21.2.1  +4 -2  ant/docs/manual/OptionalTasks/perforce.html
  
  Index: perforce.html
  ===
  RCS file: /home/cvs/ant/docs/manual/OptionalTasks/perforce.html,v
  retrieving revision 1.21
  retrieving revision 1.21.2.1
  diff -u -r1.21 -r1.21.2.1
  --- perforce.html 24 May 2003 15:28:38 -  1.21
  +++ perforce.html 22 Sep 2003 16:46:07 -  1.21.2.1
  @@ -384,7 +384,8 @@
 
 
   view
  -client view to use for label
  +client view to use for label
  +The view can contain multiple lines separated by ; or :
   No
 
 
  @@ -406,6 +407,7 @@
name="NightlyBuild:${DSTAMP}:${TSTAMP}" 
desc="Auto Nightly Build"
lock="locked"
  + label="//firstdepot/...;//secondepot/foo/bar/..."
   />
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: ant/docs/manual/OptionalTasks perforce.html

[antoine]

antoine 2003/09/22 09:42:58

  Modified:docs/manual/OptionalTasks perforce.html
  Log:
  Adding information concerning multiple line labels in 
  
  Revision  ChangesPath
  1.22  +4 -2  ant/docs/manual/OptionalTasks/perforce.html
  
  Index: perforce.html
  ===
  RCS file: /home/cvs/ant/docs/manual/OptionalTasks/perforce.html,v
  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -r1.21 -r1.22
  --- perforce.html 24 May 2003 15:28:38 -  1.21
  +++ perforce.html 22 Sep 2003 16:42:58 -  1.22
  @@ -384,7 +384,8 @@
 
 
   view
  -client view to use for label
  +client view to use for label
  +The view can contain multiple lines separated by ; or :
   No
 
 
  @@ -406,6 +407,7 @@
name="NightlyBuild:${DSTAMP}:${TSTAMP}" 
desc="Auto Nightly Build"
lock="locked"
  + label="//firstdepot/...;//secondepot/foo/bar/..."
   />
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

AW: Ant 1.6

[Antoine Lévy-Lambert]

-Ursprüngliche Nachricht-
Von: Stefan Bodewig [mailto:[EMAIL PROTECTED]
Gesendet: Montag, 22. September 2003 16:41
An: [EMAIL PROTECTED]
Betreff: Re: Ant 1.6


On Mon, 22 Sep 2003, Antoine Lévy-Lambert <[EMAIL PROTECTED]>
wrote:

>> - sort out if possible the CLASSPATH issue by :

>What you propose would probably work.

>On the other hand, Launcher could give us a chance to break away from
>the "everything is on a single classpath, which is as good as the
>system classpath" architecture of Main that, I fear, won't scale.

>Add -lib will solve some problem, the same sort of problems that can
>be solved by not using Launcher but Main.  I'm not sure whether it
>would prevent us from solving a different set of problems.

>All in all, I'm a bit neutral here as I fail to see all consequences.

Making this change (-lib) will allow people using ant from the command line
to still see their usual commands or batches working.

For instance, there are some custom tasks for which some of the extra jar
files required can only be specified via CLASSPATH in ant 1.5.4 ... and not
at all with the current ant 1.6.

This does not prevent us from improving the ant class loading system.



>> - remove the classloader from ant 1.6 simply by removing the
>> corresponding line from defaults.properties in the ANT_16_BRANCH (is
>> this enough ?)

>I'd rather remove the class from the 1.6 branch.

OK, I did not know that it is possible in CVS to remove a file selectively
just from a branch. Will do this.

>> - get the beta build running afterwards.

>What is your opinion on bugs and enhancement requests in bugzilla?
>There is always one enhancement request or another that every single
>one of us would like to see integrated into the next release.

>Given last weekend's reports, I'd like to add a roundup attribute to
>, which would address 17934 (two votes, at least).

>Where would you draw the line in the sand for enhancements?  Bugs are
>always open unless you need a freeze to get a clean build, I assume.

I would like to get the first beta compiled on Thursday evening or at the
latest on Monday next week. (September 29th).

Antoine



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 21037] - Bug in junit report generation

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21037

Bug in junit report generation

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
 AssignedTo|[EMAIL PROTECTED]  |[EMAIL PROTECTED]
 Status|REOPENED|NEW

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Antidote TODO (WAS:RE: antidote diff)

[Jack Woehr]

Christoph Wilhelms wrote:

> You ased me about the Preferences topic: It should fit into the current,
> in most places clean, small and fast, Antidote-code. Oh: And it should
> look similar to the rest of the application ;-). Just an opinion, but I
> think the MozillaFirebird option dialog is one of the nicest I have seen
> ;-).

Not familiar with that, but will try to take a look. There is a *possibility*
(not a certainty) that I will lose my high-speed connection in the near future,
which would make playing with Mozilla a little hard. We'll see what happens.

But ... Preferences and storing them via Properties I understand well. How
we handle the GUI side of that "remains to be seen". There is also the NetBeans
model of a giant Options tree.

-- 
Jack J. Woehr# "[F]ar in the empty sky a solitary esophagus slept
http://www.well.com/~jax #  upon motionless wing; everywhere brooded stillness,
http://www.softwoehr.com #  serenity, and the peace of God." - Mark Twain

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22067] - Logging of "Buildfile: *" directly to System.out instead of through logging mechanism

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22067

Logging of "Buildfile: *" directly to System.out instead of through logging 
mechanism

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22521] - java.endorsed.dirs sysproperty not passed to in-process java task

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22521

java.endorsed.dirs sysproperty not passed to in-process java task

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 15:49 ---
I also think it's because of fork="false".  You are simply not able to convince
the currently running JVM that it should consider some other dirs as endorsed
by changing the property.

WONTFIX means CANTFIX here.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22522] - -Task ignores dest-Attribute

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22522

-Task ignores dest-Attribute

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Major   |Enhancement

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22522] - -Task ignores dest-Attribute

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22522

-Task ignores dest-Attribute

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Major



--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 15:46 ---
OK, so dest does what the manual says, or it doesn't the manual isn't very 
clear.

As dest has been working the way it does since ages, we'd probably break builds
if we changed it.  We'd need a separate attribute for cvs's -d switch, that's
why I change it to enhancement (and I'll adapt the manual).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs AbstractCvsTask.java

[bodewig]

bodewig 2003/09/22 08:42:37

  Modified:docs/manual/CoreTasks Tag: ANT_16_BRANCH cvs.html
   src/main/org/apache/tools/ant/taskdefs Tag: ANT_16_BRANCH
AbstractCvsTask.java
  Log:
  properly document 's dest attribute
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.18.2.1  +4 -1  ant/docs/manual/CoreTasks/cvs.html
  
  Index: cvs.html
  ===
  RCS file: /home/cvs/ant/docs/manual/CoreTasks/cvs.html,v
  retrieving revision 1.18
  retrieving revision 1.18.2.1
  diff -u -r1.18 -r1.18.2.1
  --- cvs.html  2 Sep 2003 14:38:19 -   1.18
  +++ cvs.html  22 Sep 2003 15:42:37 -  1.18.2.1
  @@ -54,7 +54,10 @@
 
 
   dest
  -the directory where the checked out files should be 
placed.
  +the directory where the checked out files should
  +be placed.  Note that this is different from CVS's -d command line
  +switch as Ant will never shorten pathnames to avoid empty
  +directories.
   No, default is project's basedir.
 
 
  
  
  
  No   revision
  No   revision
  1.26.2.1  +4 -0  
ant/src/main/org/apache/tools/ant/taskdefs/AbstractCvsTask.java
  
  Index: AbstractCvsTask.java
  ===
  RCS file: 
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/AbstractCvsTask.java,v
  retrieving revision 1.26
  retrieving revision 1.26.2.1
  diff -u -r1.26 -r1.26.2.1
  --- AbstractCvsTask.java  12 Sep 2003 20:56:46 -  1.26
  +++ AbstractCvsTask.java  22 Sep 2003 15:42:37 -  1.26.2.1
  @@ -571,6 +571,10 @@
   /**
* The directory where the checked out files should be placed.
*
  + * Note that this is different from CVS's -d command line
  + * switch as Ant will never shorten pathnames to avoid empty
  + * directories.
  + *
* @param dest directory where the checked out files should be placed
*/
   public void setDest(File dest) {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs AbstractCvsTask.java

[bodewig]

bodewig 2003/09/22 08:41:44

  Modified:docs/manual/CoreTasks cvs.html
   src/main/org/apache/tools/ant/taskdefs AbstractCvsTask.java
  Log:
  properly document 's dest attribute
  
  Revision  ChangesPath
  1.19  +4 -1  ant/docs/manual/CoreTasks/cvs.html
  
  Index: cvs.html
  ===
  RCS file: /home/cvs/ant/docs/manual/CoreTasks/cvs.html,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- cvs.html  2 Sep 2003 14:38:19 -   1.18
  +++ cvs.html  22 Sep 2003 15:41:44 -  1.19
  @@ -54,7 +54,10 @@
 
 
   dest
  -the directory where the checked out files should be 
placed.
  +the directory where the checked out files should
  +be placed.  Note that this is different from CVS's -d command line
  +switch as Ant will never shorten pathnames to avoid empty
  +directories.
   No, default is project's basedir.
 
 
  
  
  
  1.27  +4 -0  
ant/src/main/org/apache/tools/ant/taskdefs/AbstractCvsTask.java
  
  Index: AbstractCvsTask.java
  ===
  RCS file: 
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/AbstractCvsTask.java,v
  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- AbstractCvsTask.java  12 Sep 2003 20:56:46 -  1.26
  +++ AbstractCvsTask.java  22 Sep 2003 15:41:44 -  1.27
  @@ -571,6 +571,10 @@
   /**
* The directory where the checked out files should be placed.
*
  + * Note that this is different from CVS's -d command line
  + * switch as Ant will never shorten pathnames to avoid empty
  + * directories.
  + *
* @param dest directory where the checked out files should be placed
*/
   public void setDest(File dest) {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23273] - Java task interprets it's arguments incorrectly if terminated with \\

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23273

Java task interprets it's arguments incorrectly if terminated with \\





--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 15:39 ---
I couldn't say if this works under Linux - I'm using Winodes 2000.

The -verbose trace looks Ok (see below)

 [java] Executing 'C:\jre\bin\java.exe' with arguments:
 [java] '-classpath'
 [java] '-classpath'
 [java] 'C:\ant\ant.jar;C:\jre\lib\rt.jar;C:\log4j\log4j.jar
 [java] 'myClass'
 [java] 'Some text\\'
 [java] 'Second argument'

Java -version reports the following

java version "1.4.2"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.4.2-b28)
Java HotSpot(TM) Client VM (build 1.4.2-b28, mixed mode)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22758] - [junit] add sun.reflect to the default trace filters

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22758

[junit] add sun.reflect to the default trace filters

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22863] - Can't efficiently just rename a directory with the move task

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22863

Can't efficiently just rename a directory with the move task

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement
Summary|Can't just rename a |Can't efficiently just
   |directory with the move task|rename a directory with the
   ||move task

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22748] - war task create empty file in case of empty lib dir

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22748

war task create empty file in case of empty lib dir

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22739] - CompileWithWalls ant task.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22739

CompileWithWalls ant task.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 15:30 ---
task has been committed as part of the ant-contrib project.

WONTFIX means it isn't fixed here and unlikely to get fixed.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23049] - OutOfMemoryError on Solaris

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23049

OutOfMemoryError on Solaris





--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 15:29 ---
ping?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23191] - need brief, specific documentation on including custom tasks in deployed apps

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23191

need brief, specific documentation on including custom tasks in deployed apps

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Minor   |Enhancement

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23273] - Java task interprets it's arguments incorrectly if terminated with \\

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23273

Java task interprets it's arguments incorrectly if terminated with \\





--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 15:28 ---
Does ant -verbose geve any extra hint?

This is what I get on Linux using 1.5.4

Buildfile: /tmp/java.xml

java:
0)  Some text\\
1)  Second argument

BUILD SUCCESSFUL
Total time: 2 seconds

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23278] - Project.setName() does not replaceProperties()

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23278

Project.setName() does not replaceProperties()

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Minor   |Enhancement



--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 15:24 ---
There are certain attributes that don't get properties expanded.  In particular,
the attributes of target and project do not get expanded.

At least in the case of , this is intended.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23286] - [PATCH] suppression of useless import in testcase and some enhancements

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23286

[PATCH] suppression of useless import in testcase and some enhancements

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[PATCH] Typos...

[Shatzer, Larry]

More typos...

-- Larry

Index: src/main/org/apache/tools/ant/taskdefs/optional/ejb/EjbJar.java
===
RCS file: 
/home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/ejb/EjbJar.java,v
retrieving revision 1.45
diff -u -r1.45 EjbJar.java
--- src/main/org/apache/tools/ant/taskdefs/optional/ejb/EjbJar.java 19 Jul 
2003 11:20:16 -  1.45
+++ src/main/org/apache/tools/ant/taskdefs/optional/ejb/EjbJar.java 22 Sep 
2003 14:52:13 -
@@ -170,7 +170,7 @@
 public static class NamingScheme extends EnumeratedAttribute {
 /**
  * Naming scheme where generated jar is determined from the ejb-name in
- * the deployment descripor
+ * the deployment descriptor
  */
 public static final String EJB_NAME = "ejb-name";
 
@@ -228,7 +228,7 @@
  * Stores a handle to the directory to put the Jar files in. This is
  * only used by the generic deployment descriptor tool which is created
  * if no other deployment descriptor tools are provided. Normally each
- * deployment tool will specify the desitination dir itself.
+ * deployment tool will specify the destination dir itself.
  */
 private File destDir;
 
@@ -537,7 +537,7 @@
 
 /**
  * Set the suffix for the generated jar file. When generic jars are
- * generated, they have a suffix which is appended to the the bean name
+ * generated, they have a suffix which is appended to the bean name
  * to create the name of the jar file. Note that this suffix includes
  * the extension fo te jar file and should therefore end with an
  * appropriate extension such as .jar or .ear
Index: src/main/org/apache/tools/ant/taskdefs/optional/ejb/Ejbc.java
===
RCS file: 
/home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/ejb/Ejbc.java,v
retrieving revision 1.25
diff -u -r1.25 Ejbc.java
--- src/main/org/apache/tools/ant/taskdefs/optional/ejb/Ejbc.java   19 Jul 
2003 11:20:16 -  1.25
+++ src/main/org/apache/tools/ant/taskdefs/optional/ejb/Ejbc.java   22 Sep 
2003 14:52:13 -
@@ -1,7 +1,7 @@
 /*
  * The Apache Software License, Version 1.1
  *
- * Copyright (c) 2000,2002 The Apache Software Foundation.  All rights
+ * Copyright (c) 2000,2002-2003 The Apache Software Foundation.  All rights
  * reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -70,7 +70,7 @@
  */
 public class Ejbc extends MatchingTask {
 /**
- * The root directory of the tree containing the serialised deployment 
desciptors. The actual
+ * The root directory of the tree containing the serialised deployment 
descriptors. The actual
  * deployment descriptor files are selected using include and exclude 
constructs
  * on the ejbc task provided by the MatchingTask superclass.
  */
@@ -109,7 +109,7 @@
  * interfaces to be available in the classpath, this also avoids having to
  * start ant with the class path of the project it is building.
  *
- * @exception BuildException if someting goes wrong with the build
+ * @exception BuildException if something goes wrong with the build
  */
 public void execute() throws BuildException {
 if (descriptorDirectory == null
@@ -198,7 +198,7 @@
  * Set the name of the generated manifest file.
  *
  * For each EJB that is processed an entry is created in this file. This 
can then be used
- * to create a jar file for dploying the beans.
+ * to create a jar file for deploying the beans.
  *
  * @param manifestFilename the name of the manifest file to be generated.
  */
@@ -217,7 +217,7 @@
  * Set the directory containing the source code for the home interface, 
remote interface
  * and public key class definitions.
  *
- * @param dirName the directory containg the source tree for the EJB's 
interface classes.
+ * @param dirName the directory containing the source tree for the EJB's 
interface classes.
  */
 public void setSrc(String dirName) {
 sourceDirectory = new File(dirName);
Index: src/main/org/apache/tools/ant/taskdefs/optional/ejb/EjbcHelper.java
===
RCS file: 
/home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/ejb/EjbcHelper.java,v
retrieving revision 1.21
diff -u -r1.21 EjbcHelper.java
--- src/main/org/apache/tools/ant/taskdefs/optional/ejb/EjbcHelper.java 19 Jul 
2003 11:20:17 -  1.21
+++ src/main/org/apache/tools/ant/taskdefs/optional/ejb/EjbcHelper.java 22 Sep 
2003 14:52:13 -
@@ -1,7 +1,7 @@
 /*
  * The Apache Software License, Version 1.1
  *
- * Copyright (c) 2000-2002 The Apache Software Foundation.  All rights
+ * Copyright (c) 2000-2003 The Apache Software Foundation.  All rights
  * reserved.
  *
  * Redistribution and use in source and bi

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/splash SplashTask.java

[bodewig]

bodewig 2003/09/22 08:05:21

  Modified:.WHATSNEW build.xml
   docs/manual cover.html
   src/main/org/apache/tools/ant/taskdefs/optional/splash
SplashTask.java
  Log:
  Merge fix for 23320 from 1.6 branch
  
  Revision  ChangesPath
  1.504 +3 -0  ant/WHATSNEW
  
  Index: WHATSNEW
  ===
  RCS file: /home/cvs/ant/WHATSNEW,v
  retrieving revision 1.503
  retrieving revision 1.504
  diff -u -r1.503 -r1.504
  --- WHATSNEW  19 Sep 2003 09:18:16 -  1.503
  +++ WHATSNEW  22 Sep 2003 15:05:21 -  1.504
  @@ -245,6 +245,9 @@
   *  replaced the CLASSPATH instead
 of adding to it.  Bugzilla Report 14971.
   
  +*  could fail on JVMs that use null to indicate the system 
classloader.
  +  Bugzilla Report 23320.
  +
   Other changes:
   --
   * All tasks can be used outside of s.  Note that some tasks
  
  
  
  1.393 +2 -2  ant/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/ant/build.xml,v
  retrieving revision 1.392
  retrieving revision 1.393
  diff -u -r1.392 -r1.393
  --- build.xml 3 Sep 2003 10:01:29 -   1.392
  +++ build.xml 22 Sep 2003 15:05:21 -  1.393
  @@ -25,8 +25,8 @@
 -->
 
 
  -  
  -  
  +  
  +  
 
   
 
  
  
  
  1.7   +3 -3  ant/docs/manual/cover.html
  
  Index: cover.html
  ===
  RCS file: /home/cvs/ant/docs/manual/cover.html,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- cover.html24 Jan 2003 08:55:05 -  1.6
  +++ cover.html22 Sep 2003 15:05:21 -  1.7
  @@ -2,14 +2,14 @@
   
   
   
  -Apache Ant 1.6 User Manual
  +Apache Ant 1.7 User Manual
   
   
   

 
  -  Apache Ant 1.6 Manual
  -  This is the manual for version 1.6alpha of 
  +  Apache Ant 1.7 Manual
  +  This is the manual for version 1.7alpha of 
 http://ant.apache.org/index.html";>Apache Ant. 
   If your version 
   of Ant (as verified with ant -version) is older or newer than 
this 
  
  
  
  1.10  +7 -1  
ant/src/main/org/apache/tools/ant/taskdefs/optional/splash/SplashTask.java
  
  Index: SplashTask.java
  ===
  RCS file: 
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/splash/SplashTask.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- SplashTask.java   22 Aug 2003 15:25:44 -  1.9
  +++ SplashTask.java   22 Sep 2003 15:05:21 -  1.10
  @@ -198,7 +198,13 @@
   }
   
   if (in == null) {
  -in = 
SplashTask.class.getClassLoader().getResourceAsStream("images/ant_logo_large.gif");
  +ClassLoader cl = SplashTask.class.getClassLoader();
  +if (cl != null) {
  +in = cl.getResourceAsStream("images/ant_logo_large.gif");
  +} else {
  +in = ClassLoader
  +.getSystemResourceAsStream("images/ant_logo_large.gif");
  +}
   }
   
   if (in != null) {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23320] - Ant's optional task 'Splash' generates NullPointerException when running it from JBuilder 9

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23320

Ant's optional task 'Splash' generates NullPointerException when running it 
from JBuilder 9

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED
   Target Milestone|--- |1.6



--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 15:05 ---
Should be fixed with nightly build 2003-09-23.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/splash SplashTask.java

[bodewig]

bodewig 2003/09/22 08:02:02

  Modified:.Tag: ANT_16_BRANCH WHATSNEW build.xml
   src/main/org/apache/tools/ant/taskdefs/optional/splash Tag:
ANT_16_BRANCH SplashTask.java
  Log:
  Make  work on VMs that use null to indicate the system classloader, 
PR 23320
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.503.2.1 +5 -2  ant/WHATSNEW
  
  Index: WHATSNEW
  ===
  RCS file: /home/cvs/ant/WHATSNEW,v
  retrieving revision 1.503
  retrieving revision 1.503.2.1
  diff -u -r1.503 -r1.503.2.1
  --- WHATSNEW  19 Sep 2003 09:18:16 -  1.503
  +++ WHATSNEW  22 Sep 2003 15:02:01 -  1.503.2.1
  @@ -1,5 +1,5 @@
  -Changes from Ant 1.5.4 to current CVS version
  -=
  +Changes from Ant 1.5.4 to Ant 1.6
  +=
   
   Changes that could break older environments:
   
  @@ -244,6 +244,9 @@
   
   *  replaced the CLASSPATH instead
 of adding to it.  Bugzilla Report 14971.
  +
  +*  could fail on JVMs that use null to indicate the system 
classloader.
  +  Bugzilla Report 23320.
   
   Other changes:
   --
  
  
  
  1.392.2.1 +1 -1  ant/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/ant/build.xml,v
  retrieving revision 1.392
  retrieving revision 1.392.2.1
  diff -u -r1.392 -r1.392.2.1
  --- build.xml 3 Sep 2003 10:01:29 -   1.392
  +++ build.xml 22 Sep 2003 15:02:02 -  1.392.2.1
  @@ -25,7 +25,7 @@
 -->
 
 
  -  
  +  
 
 
   
  
  
  
  No   revision
  No   revision
  1.9.2.1   +7 -1  
ant/src/main/org/apache/tools/ant/taskdefs/optional/splash/SplashTask.java
  
  Index: SplashTask.java
  ===
  RCS file: 
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/splash/SplashTask.java,v
  retrieving revision 1.9
  retrieving revision 1.9.2.1
  diff -u -r1.9 -r1.9.2.1
  --- SplashTask.java   22 Aug 2003 15:25:44 -  1.9
  +++ SplashTask.java   22 Sep 2003 15:02:02 -  1.9.2.1
  @@ -198,7 +198,13 @@
   }
   
   if (in == null) {
  -in = 
SplashTask.class.getClassLoader().getResourceAsStream("images/ant_logo_large.gif");
  +ClassLoader cl = SplashTask.class.getClassLoader();
  +if (cl != null) {
  +in = cl.getResourceAsStream("images/ant_logo_large.gif");
  +} else {
  +in = ClassLoader
  +.getSystemResourceAsStream("images/ant_logo_large.gif");
  +}
   }
   
   if (in != null) {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23322] - VAJ task run fail if VAJ's project name has some space character

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23322

VAJ task run fail if VAJ's project name has some space character





--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 14:48 ---
Sounds like something that is supposed to be fixed in Ant 1.5.4.  There 
changelog
says:

* URL-encoding in  didn't work properly.

Could you please give 1.5.4 a try?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23327] - Timestamp of the files in WAR file created by war task is different by 2 sec.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23327

Timestamp of the files in WAR file created by war task is different by 2 sec.





--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 14:46 ---
I addition I should note that _isStale() is going to return false for any files
in wars as wars (like any other zip) store file dates with a granularity of
two seconds.  So an in-filesystem and an in-archive resource are not too likely
to have the same timestamps anyway.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Ant 1.6

[Stefan Bodewig]

On Mon, 22 Sep 2003, Antoine Lévy-Lambert <[EMAIL PROTECTED]>
wrote:

> - sort out if possible the CLASSPATH issue by :

What you propose would probably work.

On the other hand, Launcher could give us a chance to break away from
the "everything is on a single classpath, which is as good as the
system classpath" architecture of Main that, I fear, won't scale.

Add -lib will solve some problem, the same sort of problems that can
be solved by not using Launcher but Main.  I'm not sure whether it
would prevent us from solving a different set of problems.

All in all, I'm a bit neutral here as I fail to see all consequences.

> - remove the classloader from ant 1.6 simply by removing the
> corresponding line from defaults.properties in the ANT_16_BRANCH (is
> this enough ?)

I'd rather remove the class from the 1.6 branch.

> - get the beta build running afterwards.

What is your opinion on bugs and enhancement requests in bugzilla?
There is always one enhancement request or another that every single
one of us would like to see integrated into the next release.

Given last weekend's reports, I'd like to add a roundup attribute to
, which would address 17934 (two votes, at least).

Where would you draw the line in the sand for enhancements?  Bugs are
always open unless you need a freeze to get a clean build, I assume.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17934] - Dates too late in jar entries

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17934

Dates too late in jar entries

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 14:36 ---
*** Bug 23327 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23327] - Timestamp of the files in WAR file created by war task is different by 2 sec.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23327

Timestamp of the files in WAR file created by war task is different by 2 sec.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 14:36 ---


*** This bug has been marked as a duplicate of 17934 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23323] - VSS task uses SSDIR environment variable instead of serverPath parameter

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23323

VSS task uses SSDIR environment variable instead of serverPath parameter





--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 12:35 ---
I changed run method to below and it work
protected int run(Commandline cmd) {
try {
Execute exe = new Execute(new LogStreamHandler(this,
   Project.MSG_INFO,
   Project.MSG_WARN));

//exe.setAntRun(project);
// If location of ss.ini is specified we need to set the
// environment-variable SSDIR to this value
if (m_serverPath != null) {
String[] env = exe.getEnvironment();
if (env == null) {
env = new String[0];
}
String[] newEnv = new String[env.length + 1];
//for (int i = 0; i < env.length ; i++) {
//newEnv[i] = env[i];
//}
//newEnv[env.length] = "SSDIR=" + m_serverPath;
boolean bMatch = false;
for (int i = 0; i < env.length ; i++) {
if ((env[i] != null) && (env[i].toUpperCase().startsWith
("SSDIR="))) {
env[i] = "SSDIR=" + m_serverPath;
bMatch = true;
break;
}
newEnv[i] = env[i];
}
if (bMatch) {
exe.setEnvironment(env);
} else {
newEnv[env.length] = "SSDIR=" + m_serverPath;
exe.setEnvironment(newEnv);
}
}

exe.setAntRun(project);

exe.setNewenvironment(true);

exe.setWorkingDirectory(project.getBaseDir());
exe.setCommandline(cmd.getCommandline());
return exe.execute();
} catch (java.io.IOException e) {
throw new BuildException(e, location);
}
}
I think it need exe.setNewenvironment(true);
By the way, I can not get any value for env variable. I dont know why.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23327] New: - Timestamp of the files in WAR file created by war task is different by 2 sec.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23327

Timestamp of the files in WAR file created by war task is different by 2 sec.

   Summary: Timestamp of the files in WAR file created by war task
is different by 2 sec.
   Product: Ant
   Version: 1.5.4
  Platform: PC
   URL: http://cvs.apache.org/viewcvs/ant/src/main/org/apache/to
ols/ant/taskdefs/Zip.java
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Core tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I found out, that ant since 1.5.x (1.5 is OK) war/jar/zip tasks change time 
stamps of the files in archive. The files became "older" compare to originals 
(which are not in archive). 

We are using Weblogic Application Server. It does not verify the timestamps for 
source jsp and corresponding *.class (compiled jsp) direct, but using it own 
method. Files in war look 2 sec. older and web logic server starts to recompile 
the sources!

public boolean _isStale()
{
   StaleChecker stalechecker = (StaleChecker)getServletConfig
().getServletContext();
Object obj = null;
long l = 0L;
return stalechecker.isResourceStale("/adminloginform.jsp",
0xf766bf9c0bL, //THIS IS A TIMESTAMP OF ORIGINAL JSP
"7.0.1.0");
   }

http://cvs.apache.org/viewcvs/ant/src/main/org/apache/tools/ant/taskdefs/Zip.jav
a
protected void zipFile(File file, ZipOutputStream zOut, String vPath, int mode) 
throws IOException 
{
  if (file.equals(zipFile)) { 
throw new BuildException("A zip file cannot include itself", getLocation
()); 
  } 
  FileInputStream fIn = new FileInputStream(file); 
  try { 
   // ZIPs store time with a granularity of 2 seconds, round up 
zipFile(fIn, zOut, vPath, file.lastModified() + 1999, null, mode); 
  } 
  finally { 
   fIn.close(); 
  } 
} 

Thank you in advance
Roman

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

AW: Ant 1.6

[Antoine Lévy-Lambert]

Will do.
My question is more whether my idea makes sense on  the principle.
Antoine

-Ursprüngliche Nachricht-
Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Gesendet: Montag, 22. September 2003 12:24
An: [EMAIL PROTECTED]
Betreff: RE: Ant 1.6


> - sort out if possible the CLASSPATH issue by :
>
> adding a -lib command line flag
> this command line flag would be processed in Launcher, not in Main
> and removed from what is passed to Main
> the locations coming with -lib would be set ahead in the URL
> arrays used to
> construct the loader created in Launcher.

Then we should add a hint in Main.processArgs(String[]), because
the "-lib" will never be passed to that method (and not each person looking
into that method knows why).


Jan


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: Ant 1.6

[Jan . Materne]

> - sort out if possible the CLASSPATH issue by :
> 
> adding a -lib command line flag
> this command line flag would be processed in Launcher, not in Main
> and removed from what is passed to Main
> the locations coming with -lib would be set ahead in the URL 
> arrays used to
> construct the loader created in Launcher.

Then we should add a hint in Main.processArgs(String[]), because
the "-lib" will never be passed to that method (and not each person looking
into that method knows why).


Jan

DO NOT REPLY [Bug 23323] New: - VSS task uses SSDIR environment variable instead of serverPath parameter

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23323

VSS task uses SSDIR environment variable instead of serverPath parameter

   Summary: VSS task uses SSDIR environment variable instead of
serverPath parameter
   Product: Ant
   Version: 1.5.3
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Optional Tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I have a SSDIR environment variable. And when I perform VSS task, VSS task uses 
SSDIR environment variable instead of serverPath parameter. I saw 
org.apache.tools.ant.taskdefs.optional.vss.MSVSS.java and found some command in 
run method:
protected int run(Commandline cmd) {
try {
Execute exe = new Execute(new LogStreamHandler(this,
   Project.MSG_INFO,
   Project.MSG_WARN));

// If location of ss.ini is specified we need to set the
// environment-variable SSDIR to this value
if (m_serverPath != null) {
String[] env = exe.getEnvironment();
if (env == null) {
env = new String[0];
}
String[] newEnv = new String[env.length + 1];
*
--->for (int i = 0; i < env.length ; i++) {
--->newEnv[i] = env[i];
--->}
--->newEnv[env.length] = "SSDIR=" + m_serverPath;
I think should change to
for (int i = 0; i < env.length ; i++) {
newEnv[i + 1] = env[i];
}
newEnv[0] = "SSDIR=" + m_serverPath;

***
exe.setEnvironment(newEnv);
}

exe.setAntRun(project);
exe.setWorkingDirectory(project.getBaseDir());
exe.setCommandline(cmd.getCommandline());
return exe.execute();
} catch (java.io.IOException e) {
throw new BuildException(e, location);
}
}

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23322] New: - VAJ task run fail if VAJ's project name has some space character

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23322

VAJ task run fail if VAJ's project name has some space character

   Summary: VAJ task run fail if VAJ's project name has some space
character
   Product: Ant
   Version: 1.5.3
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Optional Tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I use a project in VAJ with some space character in it, example 'VAJ Project' 
then perform import file into this project from command line (I use Remote 
Access To Tool API). I got an error.
That cause of when Ant send request to Remote Access To Tool API, Ant doesn't 
change VAJ's project name. Ant must change VAJ's project name from 'VAJ 
Project' to 'VAJ+Project' (Replace one space character by one plus character).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Ant 1.6

[Antoine Lévy-Lambert]

I have tagged the ANT_16_BRANCH (actually 2 hours before schedule, hope it
does not disturb anyone).

I am interested in the following next activities :

- sort out if possible the CLASSPATH issue by :

adding a -lib command line flag
this command line flag would be processed in Launcher, not in Main
and removed from what is passed to Main
the locations coming with -lib would be set ahead in the URL arrays used to
construct the loader created in Launcher.

The ant and ant.bat scripts will be changed so that :
LOCALCLASSPATH will not contain CLASSPATH anymore
CLASSPATH will be passed, if defined, with -lib $CLASSPATH (-lib
%CLASSPATH%) in the bat version

Does this sound OK ?

- remove the classloader from ant 1.6 simply by removing the corresponding
line from defaults.properties in the ANT_16_BRANCH (is this enough ?)

- get the beta build running afterwards.

Antoine



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23320] New: - Ant's optional task 'Splash' generates NullPointerException when running it from JBuilder 9

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23320

Ant's optional task 'Splash' generates NullPointerException when running it 
from JBuilder 9

   Summary: Ant's optional task 'Splash' generates
NullPointerException when running it from JBuilder 9
   Product: Ant
   Version: 1.5.4
  Platform: All
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Optional Tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The Splash optional task of Ant 1.5.4 has the following code:

--- SplashTask.java, line 201 - 
in = SplashTask.class.getClassLoader().getResourceAsStream
("images/ant_logo_large.gif");
---
This code will generate a NullPointerException when running from JBuilder 9.  
The reason is because SplashTask.class.getClassLoader() returns null

 We can fix it by change the code to something like:
-
 if (SplashTask.class.getClassLoader() == null) {
   in = ClassLoader.getSystemResourceAsStream("images/ant_logo_large.gif");
 } else {
   in = SplashTask.class.getClassLoader().getResourceAsStream  
("images/ant_logo_large.gif");
 }


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: ant/docs/manual/CoreTypes antlib.html

[peterreilly]

peterreilly2003/09/22 02:00:17

  Modified:docs/manual/CoreTypes antlib.html
  Log:
  change AntlibInterface to AntlibDefintion
  
  Revision  ChangesPath
  1.3   +2 -2  ant/docs/manual/CoreTypes/antlib.html
  
  Index: antlib.html
  ===
  RCS file: /home/cvs/ant/docs/manual/CoreTypes/antlib.html,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- antlib.html   17 Sep 2003 15:47:55 -  1.2
  +++ antlib.html   22 Sep 2003 09:00:17 -  1.3
  @@ -20,8 +20,8 @@
 Antlib's elements are ant definition tasks - like
 Typedef
 and Taskdef,
  -  or any ant task that implements
  -  org.apache.tools.ant.taskdefs.AntlibInterface.
  +  or any ant task that extends
  +  org.apache.tools.ant.taskdefs.AntlibDefinition.
   
   
 A group of tasks and types may be defined together in an antlib
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/script ScriptDef.java

[peterreilly]

peterreilly2003/09/22 01:58:58

  Modified:src/main/org/apache/tools/ant/taskdefs Antlib.java
DefBase.java Definer.java MacroDef.java
   src/main/org/apache/tools/ant/taskdefs/optional/script
ScriptDef.java
  Added:   src/main/org/apache/tools/ant/taskdefs AntlibDefinition.java
  Removed: src/main/org/apache/tools/ant/taskdefs AntlibInterface.java
  Log:
  Remove interface AntlibInterface - replace with class AntlibDefintion
  which is a Task and handles setURI and setAntlibClassLoader (from
  a e-mail by Knut Wannheden)
  
  Revision  ChangesPath
  1.12  +14 -12ant/src/main/org/apache/tools/ant/taskdefs/Antlib.java
  
  Index: Antlib.java
  ===
  RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Antlib.java,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- Antlib.java   17 Sep 2003 17:06:44 -  1.11
  +++ Antlib.java   22 Sep 2003 08:58:58 -  1.12
  @@ -70,7 +70,9 @@
   
   
   /**
  - * Antlib task.
  + * Antlib task. It does not
  + * occur in an ant build file. It is the root element
  + * an antlib xml file.
*
* @author Peter Reilly
*
  @@ -179,21 +181,21 @@
   UnknownElement ue = (UnknownElement) i.next();
   setLocation(ue.getLocation());
   ue.maybeConfigure();
  -Task t = ue.getTask();
  -if (t == null) {
  +Object configuredObject = ue.getRealThing();
  +if (configuredObject == null) {
   continue;
   }
  -if (!(t instanceof AntlibInterface)) {
  +if (!(configuredObject instanceof AntlibDefinition)) {
   throw new BuildException(
  -"Invalid element in antlib " + ue.getTag());
  +"Invalid task in antlib " + ue.getTag()
  ++ " " + configuredObject.getClass() + " does not "
  ++ "extend 
org.apache.tools.ant.taskdefs.AntlibDefinition");
   }
  -if (t instanceof AntlibInterface) {
  -AntlibInterface d = (AntlibInterface) t;
  -d.setURI(uri);
  -d.setAntlibClassLoader(getClassLoader());
  -}
  -t.init();
  -t.execute();
  +AntlibDefinition def = (AntlibDefinition) configuredObject;
  +def.setURI(uri);
  +def.setAntlibClassLoader(getClassLoader());
  +def.init();
  +def.execute();
   }
   }
   
  
  
  
  1.6   +3 -44 ant/src/main/org/apache/tools/ant/taskdefs/DefBase.java
  
  Index: DefBase.java
  ===
  RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/DefBase.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- DefBase.java  13 Sep 2003 12:58:33 -  1.5
  +++ DefBase.java  22 Sep 2003 08:58:58 -  1.6
  @@ -57,8 +57,6 @@
   import org.apache.tools.ant.AntClassLoader;
   import org.apache.tools.ant.BuildException;
   import org.apache.tools.ant.Project;
  -import org.apache.tools.ant.ProjectHelper;
  -import org.apache.tools.ant.Task;
   import org.apache.tools.ant.types.Path;
   import org.apache.tools.ant.types.Reference;
   import org.apache.tools.ant.util.ClasspathUtils;
  @@ -74,50 +72,11 @@
*
* @since Ant 1.6
*/
  -public abstract class DefBase extends Task implements AntlibInterface {
  -private String uri = "";
  -private ClassLoader internalClassLoader;
  +public abstract class DefBase extends AntlibDefinition {
   private ClassLoader createdLoader;
   private ClasspathUtils.Delegate cpDelegate;
   
   /**
  - * The URI for this definition.
  - * If the URI is "ant:core", the uri will be set to "". (This
  - * is the default uri).
  - * URIs that start with "ant:" and are not
  - * "ant:core" are reserved and are not allowed in this context.
  - * @param uri the namespace URI
  - * @throws BuildException if a reserved URI is used
  - */
  -public void setURI(String uri) throws BuildException {
  -if (uri.equals(ProjectHelper.ANT_CORE_URI)) {
  -uri = "";
  -}
  -if (uri.startsWith("ant:")) {
  -throw new BuildException("Attempt to use a reserved URI " + uri);
  -}
  -this.uri = uri;
  -}
  -
  -/**
  - * @return the namespace uri for this definition
  - */
  -public String getUri() {
  -return uri;
  -}
  -
  -
  -/**
  - * Set the class loader, overrides the cpDelagate
  - * classloader.
  - *
  - * @param classLoader a ClassLoader value
  - */
  -public void setAntlibClassLoader(ClassLoader classLoader) {
  -this.inter

Re: [patch] Having execute a nested if the target is out of date

[peter reilly]

In ant-contrib, there is an  task
that contains a  which
gets executed if the target(s) is(are) out of date.

http://ant-contrib.sourceforge.net/

Peter.

On Saturday 20 September 2003 01:32, Paul Mclachlan wrote:
> Martijn Kruithof wrote:
> > If you make something like this (I don't see a direct benefit), why
> > not make uptodate an taskcontainer so that you can wrap any task in
> > there without the need of indirection via the sequential task.
>
> But if you make  a task container itself, it couldn't have
> nested elements that *weren't* tasks (such as it's existing feature of
> nested  or nested ).  Right?  Or maybe I'm missing
> something.  But (even if I was) it seems like if you adopt this approach
> in general (and make it work), you could have problems with a task name
> conflicting with the name of a normally nested element.
>
> I think it's much better to use a nested .  It wouldn't have
> to be called "sequential", of course, we could call it something else,
> like "runIfOutOfDate", but  seemed more fitting (since
> people will - presumably - already know what it does & what it should
> contain)
>
> - Paul
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23286] - [PATCH] suppression of useless import in testcase and some enhancements

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23286

[PATCH] suppression of useless import in testcase and some enhancements





--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 08:21 ---
I agree on public promotion but i did it only on classes which had their others 
fiels public (by accessor).

For the protected promotion i disagree because it is not a real problem : 
methods are visible by package and subclasses.
So if it is a problem for a field, it is a problem in conception which should 
not use really private field into a inner class (IMHO).

I may redo a patch with the suppression of useless import or useless variable. 
There is not debate on this point (IMHO).

And i may redo another for field visibility issues. So it will be more easy to 
check on every classes if it is a good solution or if we should refactor the 
source code.

waiting your comments,
Emmanuel

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23286] - [PATCH] suppression of useless import in testcase and some enhancements

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23286

[PATCH] suppression of useless import in testcase and some enhancements





--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 08:07 ---
This patch exposes more info about classes than are needed
(a number of private to protected/public promotions).
This is not a good idea as ant has to be Backward Compatible in the
future and should expose as little as possible now.

Inner classes have access to private methods and fields of their
containing classes so the access does not need to be promoted.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Mobile Internet Access (WAS: RE: cvs commit: ant/src/testcases/or g/apache/tools/ant/filters ConcatFilterTest.java)

[Jan . Materne]

Not very long. But I have to tune my mobile access.
I think it was working with GMS (9600 baud) instead of GPRS (up to 56k).

Jan

> -Original Message-
> From: Stefan Bodewig [mailto:[EMAIL PROTECTED]
> Sent: Friday, September 19, 2003 8:45 AM
> To: [EMAIL PROTECTED]
> Subject: Re: cvs commit: 
> ant/src/testcases/org/apache/tools/ant/filters
> Co ncatFilterTest.java
> 
> 
> On Thu, 18 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote:
> 
> > More interesting for me was the update from my notebook via mobile
> > phone :-)
> 
> How long did it take?
> 
> Stefan
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 

DO NOT REPLY [Bug 23286] - [PATCH] suppression of useless import in testcase and some enhancements

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23286

[PATCH] suppression of useless import in testcase and some enhancements





--- Additional Comments From [EMAIL PROTECTED]  2003-09-22 08:03 ---
We should want.

It is better for the object conception and is better for performances

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: Antidote TODO (WAS:RE: antidote diff)

[Christoph Wilhelms]

Hi Jack!

I've committed your updates to the TODO-List. Thanx! I'll integrate it
in the WebPage shortly...
Now it would be really nice, if you pick up a task (a single one if you
do not mind) and implement it- if you like :-)!

You ased me about the Preferences topic: It should fit into the current,
in most places clean, small and fast, Antidote-code. Oh: And it should
look similar to the rest of the application ;-). Just an opinion, but I
think the MozillaFirebird option dialog is one of the nicest I have seen
;-).

If you like to talk about design of specific things THIS is the right
place!

Greetings,
Christoph

P.S.: And do us all (including yourself ;-) a favour and disabe
HTML-E-Mails :-)


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: ant-antidote TODO

[chrisw]

chrisw  2003/09/21 22:50:07

  Modified:.TODO
  Log:
  Applied Jack Wohrs updates to the TODO List
  
  Revision  ChangesPath
  1.3   +45 -22ant-antidote/TODO
  
  Index: TODO
  ===
  RCS file: /home/cvs/ant-antidote/TODO,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- TODO  9 Apr 2001 00:17:47 -   1.2
  +++ TODO  22 Sep 2003 05:50:07 -  1.3
  @@ -1,15 +1,14 @@
   TODO List:
  -* Cleanup build.xml file; make antidote specific.
   
  -* Rewrite ACSFactory to use it's own parser rather than the 
implementation
  -  specific com.sun.xml.tree.SimpleElementFactory class (only available
  -  in JAXP from Sun).
  +* Improve editors for defining file sets, and other "sets".
   
  -* Add editors for defining file sets, and other "sets".
  +* Begin to use wizard framework to develop useful wizards, such
  +  as target creation.
   
  -* Write wizzard framework.
  -
  -* Implement a build progress reporter.
  +* Implement a build progress reporter beyond the console
  +  itself to write a log to a file in addition. Obviously
  +  the log line formtting has to be definable interactively
  +  and stored in preferences.
   
   * Implement a "Worker Thread" pattern that allows workers to have
 their work done in a thread property registered with Antidote, and
  @@ -17,45 +16,70 @@
 the GUI. Should also provide support for hour-glass cursor
 handling, and AWT event blocking until task is completed. This
 would be used for things such as loading files or other tasks
  -  that the user must wait for completion.
  +  that the user must wait for completion. Currently there is no
  +  way to stop Ant once it runs from Antidote!
   
   * Add menu option to select the compiler to use, which then sets
 the "build.compiler" property. Better yet, create a generic menu 
 building capability that allows the setting of a property from a 
  -  list of options.
  +  list of options,  not just setting the complier, but allowing
  +  the option to set all Ant -D parameters from the gui and make
  +  them storable.
   
   * Add ability to put an "all" or "don't care" specifyer on the action
 "enableOn" and "disableOn" properties.
   
  -* Add ability to view task dependencies more fully.
  -
  -* Add better editors for specific tasks.
  +* Add ability to view task dependencies more fully. It would be
  +  nice to be able to show a graphic with all the targets and
  +  arrows between them to show the dependencies.
  +
  +* Add better editors for specific tasks. Not only for tasks, but
  +  properties in addition. We mean editors just like the dependency
  +  chooser.
   
   * Add a Progress Monitor for file loading (especially for slow boxen like
 mine) .
   
   * Implement some for of refid hyperlinking functionality.
  +  DOWNGRADED: We think integration into IDEs is no BIG project aim
  +  anymore or at least at the moment.
   
   * Implement context sensitive menus for the console window, allowing
 an error to be selected and invoked in IDE.
   
   * Write preferences framwork, including persistence support.
   
  -* Provide some sort of class path debugging support.
  +* Provide some sort of class path debugging support, e.g.,
  +  displaying the Ant-build-classpath and introspect the jars one
  +  by one ... search for Classes and multiple occurrences in the
  +  classpath ... and so on.
   
   * Add "syntax" colorization to the console window {done}, 
  -  with a preferences editor for setting up the styles {not-done}.
  +  with a preferences editor for setting up the styles {not-done},
  +  to make the syntax highlighting in the console window
  +  configurable via the Preferences window and persistent via
  +  properties.
   
   * Figure out an approach to gracefully stopping a running build.
  +  "Uneasy to implement without hooks in Ant itself." - (Christoph
  +  Wilhelms)
  +
   
   * Add error handler for SAX parser to better report loading errors.
   
   * Project properties viewer, including the ability to view
  -  dependencies (local and cascading).
  -
  -* Acquire or implement a logging facility.
  -
  -* Eat more dog food.
  +  dependencies (local and cascading). View and modify the project
  +  properties you can override using -D with the Ant commandline
  +  "Cascading" means from imported build.xml's.
  +
  +* Acquire or implement a logging facility. C. Wilhelms would
  +  prefer Log4J. Logkit would be another option, or the jakarta
  +  common logging facility.
  +
  +* Eat more dog food. E.g, When you delete a target, the editor in
  +  which

DO NOT REPLY [Bug 23314] - org.apache.tools.ant.taskdefs.XSTLProcess Standard Parameter

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23314

org.apache.tools.ant.taskdefs.XSTLProcess Standard Parameter

[EMAIL PROTECTED] changed:

   What|Removed |Added

 OS/Version|Other   |All
   Priority|Other   |Medium
Summary|org.apache.tools.ant.taskdef|org.apache.tools.ant.taskdef
   |s.XSTLProcess enhancement   |s.XSTLProcess Standard
   ||Parameter
   Target Milestone|--- |1.6

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23314] New: - org.apache.tools.ant.taskdefs.XSTLProcess enhancement

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23314

org.apache.tools.ant.taskdefs.XSTLProcess enhancement

   Summary: org.apache.tools.ant.taskdefs.XSTLProcess enhancement
   Product: Ant
   Version: 1.6Alpha (nightly)
  Platform: All
OS/Version: Other
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Core tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Provide the path and file name relative to the base directory as a parameter to 
each XSL transform.  We have many applications that need this relative path 
because a derivative of it is output by the transform.  e.g. we generate java 
source and the package in the java source is derived from this relative path.

After inspecting the ant nightly code drop, I think this is a one line change.  
See the one line added in the code sample below 
>From the file org.apache.tools.ant.taskdefs.XSTLProcess ...

For examples sake, I suggested the parameter name "xml-file" which would need 
to be documented as a standard parameter available to all transforms.

I would be happy to effect this change myself if you wish, obviously I would 
need access to the CVS to do so.

I look forward to your response.

Regards
Dave Keeley


/**
 * Processes the given input XML file and stores the result
 * in the given resultFile.
 *
 * @param baseDir the base directory for resolving files.
 * @param xmlFile the input file
 * @param destDir the destination directory
 * @param stylesheet the stylesheet to use.
 * @exception BuildException if the processing fails.
 */
private void process(File baseDir, String xmlFile, File destDir,
 File stylesheet)
throws BuildException {

String fileExt = targetExtension;
File   outFile = null;
File   inFile = null;

try {
long styleSheetLastModified = stylesheet.lastModified();
inFile = new File(baseDir, xmlFile);

if (inFile.isDirectory()) {
log("Skipping " + inFile + " it is a directory.",
Project.MSG_VERBOSE);
return;
}

int dotPos = xmlFile.lastIndexOf('.');
if (dotPos > 0) {
outFile = new File(destDir, 
xmlFile.substring(0, xmlFile.lastIndexOf('.')) + fileExt);
} else {
outFile = new File(destDir, xmlFile + fileExt);
}
if (force ||
inFile.lastModified() > outFile.lastModified() ||
styleSheetLastModified > outFile.lastModified()) {
ensureDirectoryFor(outFile);
log("Processing " + inFile + " to " + outFile);

configureLiaison(stylesheet);
// ONE LINE ENHANCEMENT BELOW...
liaison.addParam("xml-file", xmlFile);
liaison.transform(inFile, outFile);
}
} catch (Exception ex) {
// If failed to process document, must delete target document,
// or it will not attempt to process it the second time
log("Failed to process " + inFile, Project.MSG_INFO);
if (outFile != null) {
outFile.delete();
}

throw new BuildException(ex);
}

} //-- processXML

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Antidote TODO (WAS:RE: antidote diff)

[Jack J. Woehr]

Christoph Wilhelms wrote:
> Maybe the first step is to update the TODO list
:-)
Okay, a revised list is attached at the end of this message. Here's
the discussion:
> * Cleanup build.xml file;
make antidote specific.
>
>  This has been done already, right?
I think so!
Removed.
 
> * Rewrite ACSFactory to use it's own parser
rather than
> the implementation
>   specific com.sun.xml.tree.SimpleElementFactory
class
> (only available
>   in JAXP from Sun).
>
>  Done? Still TODO?
Has to be rececked, but generally it works fin IMHO
Removed.
> * Add editors for defining
file sets, and other "sets".
>
>  This has been done already, right?
Particualry! IMHO there could be mor comfort in defining filesets, what
do you think!?!
I think you mean "partially"? Okay, modified TODO item.
> * Write wizzard framework.
>
>  The framework is there, but there are
currently no
> wizards, right?
There is a "not working" example wizard for an entire build-file. IMO
the wizarg could be used to create targets in addition...
Modified TODO item.
> * Implement a build progress
reporter.
>
>  What would that look like, compared
to the console that
> currently exists?
I thinks the console is ok, but Sim meant to write a log to a file in
addition. Obviously the log line formtting has to be definable
interactively and stored in preferences...
Modified TODO item.
> * Implement a "Worker Thread"
pattern that allows workers to have
>   their work done in a thread property
registered with
> Antidote, and
>   provide support to that worker
to provide progress updates via
>   the GUI. Should also provide
support for hour-glass cursor
>   handling, and AWT event blocking
until task is completed. This
>   would be used for things such
as loading files or other tasks
>   that the user must wait for completion.
>
>  Has this been done or is it still TODO?
I think it is still TODO.
It IS a to do! There is no way to stop Ant once it runs from Antidote!
Modified TODO item.
 
> * Add menu option to select the compiler
to use, which then sets
>   the "build.compiler" property.
Better yet, create a generic menu
>   building capability that allows
the setting of a property from a
>   list of options.
>
>  Still TODO, right?
It is a todo! I'd propose not just setting the complier, put the option
to set all Ant -D parameters from the gui and make them storable!
Modified TODO item.
> * Add ability to put an
"all" or "don't care" specifyer
> on the action
>   "enableOn" and "disableOn" properties.
>
>  Still TODO, right?
It is not implemented IIRC! Additionally I am not really shure what
it
should do...
Left this the same, since I don't really understand it :-)
> * Add ability to view task
dependencies more fully.
>
>  Describe this facility?
It should say "target-dependency". It would be nice to be able to show
a
grafic with all the tragets and arrows between them to show the
dependency (depends). Would be really a feature for many guys using
Ant,
I know...
Modified TODO item.
 
> * Add better editors for
specific tasks.
>
>  Examples?
Not only for tasks, but properties in addition. We meant editors just
like the dependency choose!
Modified TODO item.
> * Add a Progress Monitor
for file loading (especially for
> slow boxen like
>   mine) .
>
>  Still TODO, right?
Yes, it is! Progress for loading files and for the time the
introspection rus would be nice!
Left the same.
> * Implement some for of
refid hyperlinking functionality.
>
>  Describe this facility?
Not shure what Sim means... Yould someone else drop in here...!?!
Left the same.
> * Implement context sensitive
menus for the console
> window, allowing
>   an error to be selected and invoked
in IDE.
>
>  "Jump-to" in Antidote itself?
I think integration into IDEs is no BIG project aim anymore or at leas
ATM...
Modified TODO item.
> * Write preferences framwork,
including persistence support.
>
>  Trivial, still TODO? I can borrow this
from my own open
> source code.
Would be nice, if the code is under an Apache compatible OSS License
(like Apache or FreeBSD) LGPL is NOT ok!!
I'd prefer a small, fast an clean implementation as always ;-).
It seems the nucleus of this is already there.  e.g., in core/ProjectManager.java?
Or should this be re-written? Like I said, I've got one of these things
already
written in my "SoftWoehr Class Libraries" that I could modify and "Apachify".
> * Provide some sort of
class path debugging support.
>
>  Describe this facility?
Not 100% shure, but displaying the Ant-build-classpath and introspect
the jars one by one... Search for Classes and multiple occurrences
in
the classpath... And so on!
Modified TODO item.
> * Add "syntax" colorization
to the console window {done},
>   with a preferences editor for
setting up the styles {not-done}.
>
>  Describe this facility?
Just make the syntax hi

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs SQLExec.java

[conor]

conor   2003/09/21 17:54:31

  Modified:src/main/org/apache/tools/ant/taskdefs SQLExec.java
  Log:
  Make SQL task work under Oracle
  
  Revision  ChangesPath
  1.62  +1 -1  ant/src/main/org/apache/tools/ant/taskdefs/SQLExec.java
  
  Index: SQLExec.java
  ===
  RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/SQLExec.java,v
  retrieving revision 1.61
  retrieving revision 1.62
  diff -u -w -u -r1.61 -r1.62
  --- SQLExec.java  15 Sep 2003 16:55:01 -  1.61
  +++ SQLExec.java  22 Sep 2003 00:54:31 -  1.62
  @@ -554,7 +554,7 @@
   ret = statement.getMoreResults();
   updateCount = statement.getUpdateCount();
   resultSet = statement.getResultSet();
  -} while ((resultSet != null) || (updateCount != -1));
  +} while (ret);
   
   log(updateCountTotal + " rows affected",
   Project.MSG_VERBOSE);
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]