Re: Bootstrapping on Solaris does not work because of chmod

2005-10-19 Thread Steve Loughran

Matt Benson wrote:

hmmm... I'm fresh out of *nix boxes at the moment.
 :(  I will try to research starting with attrib.

-Matt


I will think about creating a solaris image under vmware, to sit by the 
win98 image


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



AW: Bootstrapping on Solaris does not work because of chmod

2005-10-19 Thread Jan.Materne
Just an idea - are there any downloadable vm-images for free 
OSes, like Linux, OpenSolaris, FreeBSD, ...?
Maybe we could provide the used images.

Jan 

-Ursprüngliche Nachricht-
Von: Steve Loughran [mailto:[EMAIL PROTECTED] 
Gesendet: Mittwoch, 19. Oktober 2005 09:54
An: Ant Developers List
Betreff: Re: Bootstrapping on Solaris does not work because of chmod

Matt Benson wrote:
 hmmm... I'm fresh out of *nix boxes at the moment.
  :(  I will try to research starting with attrib.
 
 -Matt

I will think about creating a solaris image under vmware, to sit by the
win98 image

-
To unsubscribe, e-mail: [EMAIL PROTECTED] For 
additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[EMAIL PROTECTED]: Project test-ant-no-xerces (in module ant) failed

2005-10-19 Thread Gump Integration Build
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project test-ant-no-xerces has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 20 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- test-ant-no-xerces :  Java based build tool


Full details are available at:
http://vmgump.apache.org/gump/public/ant/test-ant-no-xerces/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/ant/test-ant-no-xerces/gump_work/build_ant_test-ant-no-xerces.html
Work Name: build_ant_test-ant-no-xerces (Type: Build)
Work ended in a state of : Failed
Elapsed: 9 mins 27 secs
Command Line: java -Djava.awt.headless=true org.apache.tools.ant.Main 
-Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only 
-Dtest.haltonfailure=false -Dant.home=/usr/local/gump/public/workspace/ant/dist 
run-tests 
[Working Directory: /usr/local/gump/public/workspace/ant]
CLASSPATH: 
/opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/ant/build/testcases:/usr/local/gump/public/workspace/ant/src/testcases:/usr/local/gump/public/workspace/ant/src/etc/testcases:/usr/local/gump/public/workspace/ant/build/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-javamail.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-apache-bcel.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-apache-regexp.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-commons-net.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-jsch.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-apache-log4j.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-antlr.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-commons-logging.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-jdepend.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-apache-bsf.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-apache-oro.jar:/usr/local/gump/public/workspace/ant/build/lib/ant.jar:/usr/local/gump/public/workspace/ant/build/lib/ant-jai.jar:/usr/local/gump/packages/antlr-2.7.3/antlr.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-19102005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-19102005.jar:/usr/local/gump/public/workspace/jakarta-commons/net/dist/commons-net-19102005.jar:/usr/local/gump/packages/jaf-1.0.1/activation.jar:/usr/local/gump/public/workspace/jakarta-bcel/bin/bcel.jar:/usr/local/gump/public/workspace/jakarta-bsf/build/lib/bsf.jar:/usr/local/gump/public/workspace/logging-log4j/log4j-19102005.jar:/usr/local/gump/public/workspace/jakarta-oro/jakarta-oro-19102005.jar:/usr/local/gump/public/workspace/jakarta-regexp/build/jakarta-regexp-19102005.jar:/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/usr/local/gump/packages/javamail-1.3.2/mail.jar:/usr/local/gump/packages/javamail-1.3.2/lib/mailapi.jar:/usr/local/gump/packages/jdepend-2.6/lib/jdepend.jar:/usr/local/gump/packages/jsch-0.1.18/dist/lib/jsch-gump.jar:/usr/local/gump/public/workspace/xml-stylebook/bin/stylebook-1.0-b3_xalan-2.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/jakarta-tomcat-4.0/dist/common/lib/jasper-compiler.jar:/usr/local/gump/public/workspace/jakarta-tomcat-4.0/dist/common/lib/jasper-runtime.jar:/usr/local/gump/public/workspace/xml-commons/java/build/which.jar:/usr/local/gump/public/workspace/rhino/build/rhino_19102005/js.jar:/usr/local/gump/public/workspace/beanshell/dist/bsh-classpath-19102005.jar:/usr/local/gump/public/workspace/beanshell/dist/bsh-commands-19102005.jar:/usr/local/gump/public/workspace/beanshell/dist/bsh-util-19102005.jar:/usr/local/gump/public/workspace/beanshell/dist/bsh-bsf-19102005.jar:/usr/local/gump/public/workspace/beanshell/dist/bsh-19102005.jar:/usr/local/gump/public/workspace/beanshell/dist/bsh-core-19102005.jar:/usr/local/gump/public/workspace/beanshell/dist/bsh-reflect-19102005.jar:/usr/local/gump/public/workspace/jakarta-commons/codec/dist/commons-codec-19102005.jar
-

[EMAIL PROTECTED]: Project test-ant (in module ant) failed

2005-10-19 Thread Gump Integration Build
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project test-ant has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 20 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- test-ant :  Java based build tool


Full details are available at:
http://vmgump.apache.org/gump/public/ant/test-ant/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/ant/test-ant/gump_work/build_ant_test-ant.html
Work Name: build_ant_test-ant (Type: Build)
Work ended in a state of : Failed
Elapsed: 9 mins 11 secs
Command Line: java -Djava.awt.headless=true 
-Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/usr/local/gump/public/workspace/xml-xalan/java/build/serializer.jar:/usr/local/gump/public/workspace/xml-xalan/java/build/xalan-unbundled.jar
 org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only -Dtest.haltonfailure=false 
-Dant.home=/usr/local/gump/public/workspace/ant/dist run-tests 
[Working Directory: /usr/local/gump/public/workspace/ant]
CLASSPATH: 

DO NOT REPLY [Bug 37151] - Import Task - Edit for import only allowed as a top-level task seems invalid

2005-10-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=37151.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37151


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-10-19 16:35 ---
Tasks executed outside of a declared target are executed in the implicit 
target, whose name is .  So the code is correct.  For more info re: the 
implicit target see oata.helper.ProjectHandler2.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r326636 - in /ant/core/trunk: docs/manual/CoreTasks/ src/etc/testcases/taskdefs/ src/testcases/org/apache/tools/ant/taskdefs/

2005-10-19 Thread bodewig
Author: bodewig
Date: Wed Oct 19 11:37:15 2005
New Revision: 326636

URL: http://svn.apache.org/viewcvs?rev=326636view=rev
Log:
more docs and tests

Modified:
ant/core/trunk/docs/manual/CoreTasks/unpack.html
ant/core/trunk/docs/manual/CoreTasks/unzip.html
ant/core/trunk/src/etc/testcases/taskdefs/bunzip2.xml
ant/core/trunk/src/etc/testcases/taskdefs/gunzip.xml
ant/core/trunk/src/etc/testcases/taskdefs/untar.xml
ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/BUnzip2Test.java
ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/GUnzipTest.java
ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/UntarTest.java

Modified: ant/core/trunk/docs/manual/CoreTasks/unpack.html
URL: 
http://svn.apache.org/viewcvs/ant/core/trunk/docs/manual/CoreTasks/unpack.html?rev=326636r1=326635r2=326636view=diff
==
--- ant/core/trunk/docs/manual/CoreTasks/unpack.html (original)
+++ ant/core/trunk/docs/manual/CoreTasks/unpack.html Wed Oct 19 11:37:15 2005
@@ -56,6 +56,31 @@
 pexpands itest.tar.gz/i to isubdir/test.tar/i (assuming
 subdir is a directory)./p
 
+h3Related tasks/h3
+
+pre
+lt;gunzip src=some-archive.gz dest=some-dest-dir/gt;
+/pre
+
+is identical to
+
+pre
+lt;copy todir=some-dest-dirgt;
+  lt;gzipresourcegt;
+lt;file file=some-archive.gz/gt;
+  lt;/gzipresourcegt;
+  lt;mapper type=glob from=*.gz to=*/gt;
+lt;/copygt;
+/pre
+
+pThe same is also true for codelt;bunzip2gt;/code and
+codelt;bzip2resourcegt;/code.  codelt;copygt;/code offers
+additional features like a
+href=../CoreTypes/filterchains.htmlfiltering files/a on the fly,
+allowing a file to be mapped to multiple destinations, preserving the
+last modified time or a configurable file system timestamp
+granularity./p
+
 hr
 p align=centerCopyright copy; 2000-2001,2004-2005 The Apache Software 
Foundation. All rights
 Reserved./p

Modified: ant/core/trunk/docs/manual/CoreTasks/unzip.html
URL: 
http://svn.apache.org/viewcvs/ant/core/trunk/docs/manual/CoreTasks/unzip.html?rev=326636r1=326635r2=326636view=diff
==
--- ant/core/trunk/docs/manual/CoreTasks/unzip.html (original)
+++ ant/core/trunk/docs/manual/CoreTasks/unzip.html Wed Oct 19 11:37:15 2005
@@ -117,6 +117,38 @@
 lt;mapper type=quot;flattenquot;/gt;
 lt;/unzipgt;
 /pre
+
+h3Related tasks/h3
+
+pre
+lt;unzip src=some-archive dest=some-dirlt;
+  lt;patternsetgt;
+lt;include name=some-pattern/gt;
+  lt;/patternsetgt;
+  lt;mapper type=quot;some-mapperquot;/gt;
+lt;/unzipgt;
+/pre
+
+is identical to
+
+pre
+lt;copy todir=some-dir preservelastmodified=truelt;
+  lt;zipfileset src=some-archivegt;
+lt;patternsetgt;
+  lt;include name=some-pattern/gt;
+lt;/patternsetgt;
+  lt;/zipfilesetgt;
+  lt;mapper type=quot;some-mapperquot;/gt;
+lt;/copygt;
+/pre
+
+pThe same is also true for codelt;untargt;/code and
+codelt;tarfilesetgt;/code.  codelt;copygt;/code offers
+additional features like a
+href=../CoreTypes/filterchains.htmlfiltering files/a on the fly,
+allowing a file to be mapped to multiple destinations or a
+configurable file system timestamp granularity./p
+
 hr
 p align=centerCopyright copy; 2000-2005 The Apache Software Foundation. 
All rights
 Reserved./p

Modified: ant/core/trunk/src/etc/testcases/taskdefs/bunzip2.xml
URL: 
http://svn.apache.org/viewcvs/ant/core/trunk/src/etc/testcases/taskdefs/bunzip2.xml?rev=326636r1=326635r2=326636view=diff
==
--- ant/core/trunk/src/etc/testcases/taskdefs/bunzip2.xml (original)
+++ ant/core/trunk/src/etc/testcases/taskdefs/bunzip2.xml Wed Oct 19 11:37:15 
2005
@@ -14,4 +14,13 @@
   target name=prepare
 gunzip src=expected/asf-logo-huge.tar.gz/
   /target
+
+  target name=testDocumentationClaimsOnCopy
+copy todir=.
+  bzip2resource
+file file=expected/asf-logo-huge.tar.bz2/
+  /bzip2resource
+  mapper type=glob from=*.bz2 to=*/
+/copy
+  /target
 /project

Modified: ant/core/trunk/src/etc/testcases/taskdefs/gunzip.xml
URL: 
http://svn.apache.org/viewcvs/ant/core/trunk/src/etc/testcases/taskdefs/gunzip.xml?rev=326636r1=326635r2=326636view=diff
==
--- ant/core/trunk/src/etc/testcases/taskdefs/gunzip.xml (original)
+++ ant/core/trunk/src/etc/testcases/taskdefs/gunzip.xml Wed Oct 19 11:37:15 
2005
@@ -24,4 +24,13 @@
 gunzip src=expected/asf-logo.gif.gz dest=asf-logo.gif /
   /target
 
+  target name=testDocumentationClaimsOnCopy
+copy todir=.
+  gzipresource
+file file=expected/asf-logo.gif.gz/
+  /gzipresource
+  mapper type=glob from=*.gz to=*/
+/copy
+  /target
+
 /project

Modified: ant/core/trunk/src/etc/testcases/taskdefs/untar.xml
URL: 

svn commit: r326639 - in /ant/core/trunk/src: etc/testcases/taskdefs/unzip.xml testcases/org/apache/tools/ant/taskdefs/UnzipTest.java

2005-10-19 Thread bodewig
Author: bodewig
Date: Wed Oct 19 11:39:27 2005
New Revision: 326639

URL: http://svn.apache.org/viewcvs?rev=326639view=rev
Log:
more docs and tests

Modified:
ant/core/trunk/src/etc/testcases/taskdefs/unzip.xml
ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/UnzipTest.java

Modified: ant/core/trunk/src/etc/testcases/taskdefs/unzip.xml
URL: 
http://svn.apache.org/viewcvs/ant/core/trunk/src/etc/testcases/taskdefs/unzip.xml?rev=326639r1=326638r2=326639view=diff
==
--- ant/core/trunk/src/etc/testcases/taskdefs/unzip.xml (original)
+++ ant/core/trunk/src/etc/testcases/taskdefs/unzip.xml Wed Oct 19 11:39:27 2005
@@ -134,4 +134,14 @@
   /restrict
 /unzip
   /target
+
+  target name=testDocumentationClaimsOnCopy depends=prepareTestZip
+copy todir=unziptestout preservelastmodified=true 
+  zipfileset src=unziptest.zip
+patternset
+  include name=2//
+/patternset
+  /zipfileset
+/copy
+  /target
 /project

Modified: 
ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/UnzipTest.java
URL: 
http://svn.apache.org/viewcvs/ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/UnzipTest.java?rev=326639r1=326638r2=326639view=diff
==
--- ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/UnzipTest.java 
(original)
+++ ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/UnzipTest.java 
Wed Oct 19 11:39:27 2005
@@ -178,4 +178,10 @@
 assertFileExists(junit.jar has been extracted,
  unziptestout/junit/framework/Assert.class);
 }
+
+public void testDocumentationClaimsOnCopy() {
+executeTarget(testDocumentationClaimsOnCopy);
+assertFileMissing(1/foo is excluded, unziptestout/1/foo);
+assertFileExists(2/bar is not excluded, unziptestout/2/bar);
+}
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r326640 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/CompressedResource.java

2005-10-19 Thread bodewig
Author: bodewig
Date: Wed Oct 19 11:40:02 2005
New Revision: 326640

URL: http://svn.apache.org/viewcvs?rev=326640view=rev
Log:
better return the correct size

Modified:

ant/core/trunk/src/main/org/apache/tools/ant/types/resources/CompressedResource.java

Modified: 
ant/core/trunk/src/main/org/apache/tools/ant/types/resources/CompressedResource.java
URL: 
http://svn.apache.org/viewcvs/ant/core/trunk/src/main/org/apache/tools/ant/types/resources/CompressedResource.java?rev=326640r1=326639r2=326640view=diff
==
--- 
ant/core/trunk/src/main/org/apache/tools/ant/types/resources/CompressedResource.java
 (original)
+++ 
ant/core/trunk/src/main/org/apache/tools/ant/types/resources/CompressedResource.java
 Wed Oct 19 11:40:02 2005
@@ -25,12 +25,14 @@
 import org.apache.tools.ant.types.Resource;
 import org.apache.tools.ant.types.Reference;
 import org.apache.tools.ant.types.ResourceCollection;
+import org.apache.tools.ant.util.FileUtils;
 
 /**
  * A compressed resource.
  *
- * pWraps around another resource, delegates all queries to that
- * other resource but uncompresses/compresses streams on the fly./p
+ * pWraps around another resource, delegates all queries (except
+ * getSize) to that other resource but uncompresses/compresses streams
+ * on the fly./p
  *
  * @since Ant 1.7
  */
@@ -124,7 +126,26 @@
  * compatibility with java.io.File), or UNKNOWN_SIZE if not known.
  */
 public long getSize() {
-return getResource().getSize();
+if (isExists()) {
+InputStream in = null;
+try {
+in = getInputStream();
+byte[] buf = new byte[8192];
+int size = 0;
+int readNow;
+while ((readNow = in.read(buf, 0, buf.length))  0) {
+size += readNow;
+}
+return size;
+} catch (IOException ex) {
+throw new BuildException(caught exception while reading 
+ + getName(), ex);
+} finally {
+FileUtils.close(in);
+}
+} else {
+return 0;
+}
 }
 
 public void setSize(long size) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Bootstrapping on Solaris does not work because of chmod

2005-10-19 Thread Stefan Bodewig
On Mon, 17 Oct 2005, Alexey N. Solofnenko [EMAIL PROTECTED]
wrote:

 I found the reason why I cannot build on Solaris - chmod does
 nothing.  I added -v option into bootstrap.sh and this is what was
 printed:

-d might be better since you'll see the results of DirectoryScanner.

One thing I noticed while working on tar's resource collection
support (gonna raise it in a different thread) is that
FileUtils.iterator() doesn't return directories (by design) - maybe
this is a hint.

Gump does bootstrap on Solaris[1], but it never uses the wrapper scripts,
so we wouldn't notice when chmod fails.

Stefan

Footnotes: 
[1]  http://gump.zones.apache.org/


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Bootstrapping on Solaris does not work because of chmod

2005-10-19 Thread Stefan Bodewig
On Mon, 17 Oct 2005, Alexey N. Solofnenko [EMAIL PROTECTED]
wrote:

 I found the reason why I cannot build on Solaris - chmod does
 nothing.

Happens on my Linux box as well.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Tar and resource collections

2005-10-19 Thread Stefan Bodewig
Hi all,

I think this one has earned an extra mail since it has some subtle
effects beyond hey, I can tar up a path now.

tar supports resources now, any resources.

All protected method signatures in tar remained unchanged, I just
added a few new ones.  Classes extending tar shouldn't notice,
they'll reject non-file resources, but any file-system resource
collection should magically be supported by them as well.  Not that I
was aware of any subclass.

tarfileset is a stand-alone data-type now and can read from a source
archive (just like zipfileset did).

zipresource and tarresource know their Unix permissions (read from
the archive) and in tarresource's case their Unix owner and group
information as well.

If you add zipresources (like from a zipfileset src=...) or
tarresources (ditto) to a tar, the original permissions and owners
get retained (unless overridden by the attributes on *fileset).

This lead me to the commented out changes in Ant's build.xml:

tar longfile=gnu
  destfile=${dist.base.binaries}/${dist.name}-bin.tar
  zipfileset src=${dist.base.binaries}/${dist.name}-bin.zip/
/tar

would allow us to read the permissions from the zip file instead of
duplicating the patterns.

Just, it is slow, really really slow.  Replacing both tar tasks made
ant distribution go from 2:45 to 6:39 on my 2GHz Pentium M WinXP
(yes, my work machine) notebook.

The reason for this is that with the zipfileset approach, the zip
archive gets opened and read once for scanning and then once per
resource that is added to the tar archive.  I don't see any easy way
around that, though.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



FileSet#iterator only returning files

2005-10-19 Thread Stefan Bodewig
Hi (Matt ;-),

the design decision to not return directories in FileSet affects the
tasks that want to read files and directories.

If I code a generic task that just uses iterator, I'll never see
directories from FileSet (or any of FileSet's subclasses), instead I
have to check whether I'm dealing with a fileset subclass.

Even worse, there is no way to get the included directories of

union
  fileset dir=A/
  fileset dir=B/
/union

What shall we do?  Return files and directories and let the user
explicitly use a type selector would be my preference.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 37085] - problem refering jars specfied by Class-Path attribute in manifest of a ant task jar file, when this ant task jar file is located in a directory with space

2005-10-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=37085.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37085





--- Additional Comments From [EMAIL PROTECTED]  2005-10-19 21:54 ---
I have done a little bit of debugging and used the findings of Ritesh Adval.
Line 503 of AntClassLoader is the one which might be doing the wrong 
assumptions.
It says : File libraryFile = new File(libraryURL.getFile());
This returns a file located in
/C:/Dokumente%20und%20Einstellungen/antoine/ext/AntTaskDepedentLibrary.jar

for C:/Dokumente und Einstellungen/antoine/ext/AntTaskDependentLibrary.jar.


The wrong assumption is that java.net.URL#getFile() returns a string with which
one can instantiate a java.io.File.

I am wondering whether it is not possible to simplify the loop between the lines
491 and 506 of AntClassLoader, by not converting 
String (representing a path) - URL
then URL - String (representing a path)
but working with java.io.File or String all the way.

Or is there a reason why we do this all this walk ?

Cheers,
Antoine

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: FileSet#iterator only returning files

2005-10-19 Thread Matt Benson
--- Stefan Bodewig [EMAIL PROTECTED] wrote:

 Hi (Matt ;-),
 
 the design decision to not return directories in
 FileSet affects the
 tasks that want to read files and directories.
 
 If I code a generic task that just uses iterator,
 I'll never see
 directories from FileSet (or any of FileSet's
 subclasses), instead I
 have to check whether I'm dealing with a fileset
 subclass.

That is what I had been doing, yes:

  public void add(FileSet fs) {
add((ResourceCollection)
new /*oata.types.resources.*/BCFileSet(fs));
  }
  public void add(ResourceCollection rc) {
 //whatever
  }

 
 Even worse, there is no way to get the included
 directories of
 
 union
   fileset dir=A/
   fileset dir=B/
 /union

Hmm... good point.  :(
 
 What shall we do?  Return files and directories and
 let the user
 explicitly use a type selector would be my
 preference.
 
I don't see that we have much choice given your
example above.  Wouldn't we have to invert the
situation and explicitly ignore directories in tasks
that have historically used only the results of
ds.getIncludedFiles() ?

-Matt

 Stefan
 

-
 To unsubscribe, e-mail:
 [EMAIL PROTECTED]
 For additional commands, e-mail:
 [EMAIL PROTECTED]
 
 





__ 
Yahoo! Mail - PC Magazine Editors' Choice 2005 
http://mail.yahoo.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 37169] New: - SQLExec.runStatements causes problems for JDK 1.5

2005-10-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=37169.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37169

   Summary: SQLExec.runStatements causes problems for JDK 1.5
   Product: Ant
   Version: unspecified
  Platform: All
OS/Version: All
Status: NEW
  Keywords: JDK1.5
  Severity: normal
  Priority: P2
 Component: Core tasks
AssignedTo: dev@ant.apache.org
ReportedBy: [EMAIL PROTECTED]


We are using the sql task to read in a .sql file to populate a database.  One
of the INSERT statements that is used to populate a variable unlimited length
column (declared as TEXT for Postgresql) is 1.5 million characters long.

Using Ant 1.6.5 with JDK 1.4, the task completes in a few seconds.  However,
using the same version of Ant with JDK 1.5.0 (build 1.5.0_05-b05), it takes 36
minutes.

After debugging the SQLExec class, it appears that the runStatements method
contains an inefficient line of code.  Line 483 contains this code:

if ((delimiterType.equals(DelimiterType.NORMAL)
  sql.toString().endsWith(delimiter))

By using the buffer's toString(), the entire buffer is getting searched (in
addition to unneccessarily creating a new string) instead of using the last line
read to locate the delimiter.

If you change it to:

if ((delimiterType.equals(DelimiterType.NORMAL) 
  line.endsWith(delimiter))

the problem is fixed.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: DO NOT REPLY [Bug 37085] - problem refering jars specfied by Class-Path attribute in manifest of a ant task jar file, when this ant task jar file is located in a directory with space

2005-10-19 Thread Antoine Levy-Lambert
Hi,
maybe the simplest solution would be to change this line :

 File libraryFile = new File(libraryURL.getFile());
to

 File  libraryFile = new File(URLDecoder.decode(libraryURL.getFile()));

Comments ?

Cheers,

Antoine
[EMAIL PROTECTED] wrote:

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=37085.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37085





--- Additional Comments From [EMAIL PROTECTED]  2005-10-19 21:54 ---
I have done a little bit of debugging and used the findings of Ritesh Adval.
Line 503 of AntClassLoader is the one which might be doing the wrong 
assumptions.
It says : File libraryFile = new File(libraryURL.getFile());
This returns a file located in
/C:/Dokumente%20und%20Einstellungen/antoine/ext/AntTaskDepedentLibrary.jar

for C:/Dokumente und Einstellungen/antoine/ext/AntTaskDependentLibrary.jar.


The wrong assumption is that java.net.URL#getFile() returns a string with which
one can instantiate a java.io.File.

I am wondering whether it is not possible to simplify the loop between the 
lines
491 and 506 of AntClassLoader, by not converting 
String (representing a path) - URL
then URL - String (representing a path)
but working with java.io.File or String all the way.

Or is there a reason why we do this all this walk ?

Cheers,
Antoine

  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tar and resource collections

2005-10-19 Thread Matt Benson
--- Stefan Bodewig [EMAIL PROTECTED] wrote:
[SNIP]
 This lead me to the commented out changes in Ant's
 build.xml:
 
 tar longfile=gnu
  

destfile=${dist.base.binaries}/${dist.name}-bin.tar
   zipfileset
 src=${dist.base.binaries}/${dist.name}-bin.zip/
 /tar
 
 would allow us to read the permissions from the zip
 file instead of
 duplicating the patterns.
 
 Just, it is slow, really really slow.  Replacing
 both tar tasks made
 ant distribution go from 2:45 to 6:39 on my 2GHz
 Pentium M WinXP
 (yes, my work machine) notebook.
 
 The reason for this is that with the zipfileset
 approach, the zip
 archive gets opened and read once for scanning and
 then once per
 resource that is added to the tar archive.  I don't
 see any easy way
 around that, though.

Hmm... seems like it would take some work (maybe a lot
of stream magic), but would still be doable to try to
augment ZipResource to be able to accept a ZipFile
instance... ZipFile gets an isOpen() method...
ZipScanner passes down its ZipFile and defers close()
to some hook... gets crazy, but it might be possible
Rube Goldberg style...

-Matt

 
 Stefan
 

-
 To unsubscribe, e-mail:
 [EMAIL PROTECTED]
 For additional commands, e-mail:
 [EMAIL PROTECTED]
 
 





__ 
Yahoo! Mail - PC Magazine Editors' Choice 2005 
http://mail.yahoo.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: DO NOT REPLY [Bug 37085] - problem refering jars specfied by Class-Path attribute in manifest of a ant task jar file, when this ant task jar file is located in a directory with space

2005-10-19 Thread Matt Benson
--- Antoine Levy-Lambert [EMAIL PROTECTED] wrote:

 Hi,
 maybe the simplest solution would be to change this
 line :
 
  File libraryFile = new File(libraryURL.getFile());
 to
 
  File  libraryFile = new
 File(URLDecoder.decode(libraryURL.getFile()));
 
 Comments ?

It looks reasonable.  Does it fix the problem?

-Matt
 
 Cheers,
 
 Antoine
 [EMAIL PROTECTED] wrote:
 
 DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR
 BUG·
 RELATED COMMENTS THROUGH THE WEB INTERFACE
 AVAILABLE AT

http://issues.apache.org/bugzilla/show_bug.cgi?id=37085.
 ANY REPLY MADE TO THIS MESSAGE WILL NOT BE
 COLLECTED AND·
 INSERTED IN THE BUG DATABASE.
 

http://issues.apache.org/bugzilla/show_bug.cgi?id=37085
 
 
 
 
 
 --- Additional Comments From [EMAIL PROTECTED]
  2005-10-19 21:54 ---
 I have done a little bit of debugging and used the
 findings of Ritesh Adval.
 Line 503 of AntClassLoader is the one which might
 be doing the wrong assumptions.
 It says : File libraryFile = new
 File(libraryURL.getFile());
 This returns a file located in

/C:/Dokumente%20und%20Einstellungen/antoine/ext/AntTaskDepedentLibrary.jar
 
 for C:/Dokumente und

Einstellungen/antoine/ext/AntTaskDependentLibrary.jar.
 
 
 The wrong assumption is that java.net.URL#getFile()
 returns a string with which
 one can instantiate a java.io.File.
 
 I am wondering whether it is not possible to
 simplify the loop between the lines
 491 and 506 of AntClassLoader, by not converting 
 String (representing a path) - URL
 then URL - String (representing a path)
 but working with java.io.File or String all the
 way.
 
 Or is there a reason why we do this all this walk ?
 
 Cheers,
 Antoine
 
   
 
 
 

-
 To unsubscribe, e-mail:
 [EMAIL PROTECTED]
 For additional commands, e-mail:
 [EMAIL PROTECTED]
 
 




__ 
Start your day with Yahoo! - Make it your home page! 
http://www.yahoo.com/r/hs

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: DO NOT REPLY [Bug 37085] - problem refering jars specfied by Class-Path attribute in manifest of a ant task jar file, when this ant task jar file is located in a directory with space

2005-10-19 Thread Antoine Levy-Lambert
Matt Benson wrote:

--- Antoine Levy-Lambert [EMAIL PROTECTED] wrote:

  

Hi,
maybe the simplest solution would be to change this
line :

 File libraryFile = new File(libraryURL.getFile());
to



File  libraryFile = new
  

File(URLDecoder.decode(libraryURL.getFile()));

Comments ?



It looks reasonable.  Does it fix the problem?

  

Hello Matt,

yes, this fixes the problem.

If we have a way to check whether class path elements listed in the
Class-Path attribute of a manifest denote a protocol and ignore them
with the same warning message,
then we could make the algorithm even more simple and do not put URL in
the equation at all.

It sounds like the current algorithm does the following :

1) resolve the path of the jar explicitly listed in the classpath
according to ant's rules ( relative to the project directory when the
path of the jar is not absolute),
2) add to this path the path of each classpath element

the round-trip String - URL - String is only done with the purpose of
eliminating Class-Path entries like http://foo.com/my.jar or
jar://WEB-INF/lib/mylibrary.jar.

Cheers,

Antoine

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 37174] New: - javac task and the -Xlint compiler switch

2005-10-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=37174.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37174

   Summary: javac task and the -Xlint compiler switch
   Product: Ant
   Version: 1.6.2
  Platform: Other
OS/Version: Solaris
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Core tasks
AssignedTo: dev@ant.apache.org
ReportedBy: [EMAIL PROTECTED]


The javac task give me this following output:

Note: Some input files use unchecked or unsafe operations.Note: Recompile with
-Xlint:unchecked for details.

The javac task doesn't provide a property to enable the -Xlint compiler switch.
 I think It would be nice to have one.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 37174] - javac task and the -Xlint compiler switch

2005-10-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=37174.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37174





--- Additional Comments From [EMAIL PROTECTED]  2005-10-19 23:36 ---
Can't you use compilerarg?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 30576] - cvschangelog task: CVS log date output format changed on CVS 1.12.9

2005-10-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=30576.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30576


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE
   Target Milestone|--- |1.7




--- Additional Comments From [EMAIL PROTECTED]  2005-10-19 23:54 ---


*** This bug has been marked as a duplicate of 30962 ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r326723 - /ant/core/trunk/WHATSNEW

2005-10-19 Thread antoine
Author: antoine
Date: Wed Oct 19 15:00:29 2005
New Revision: 326723

URL: http://svn.apache.org/viewcvs?rev=326723view=rev
Log:
Bugzilla 30962. cvschangelog problem with CVS version = 1.12.x

Modified:
ant/core/trunk/WHATSNEW

Modified: ant/core/trunk/WHATSNEW
URL: 
http://svn.apache.org/viewcvs/ant/core/trunk/WHATSNEW?rev=326723r1=326722r2=326723view=diff
==
--- ant/core/trunk/WHATSNEW (original)
+++ ant/core/trunk/WHATSNEW Wed Oct 19 15:00:29 2005
@@ -140,6 +140,9 @@
 * sshexec closed System.out, disabling output on second and subsequent
   invocations.  Bugzilla report 36302.
 
+* cvschangelog was crashing with CVS versions = 1.12.x due to change in
+  the date format. Bugzilla report 30962.
+
 Other changes:
 --
 * Fixed references to obsoleted CVS web site. Burzilla Report 36854.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 30576] - cvschangelog task: CVS log date output format changed on CVS 1.12.9

2005-10-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=30576.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30576


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC|dev@ant.apache.org  |




--- Additional Comments From [EMAIL PROTECTED]  2005-10-20 00:12 ---
Thanks for the good work of Stephane ... It works, I have tested it. :-)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 30576] - cvschangelog task: CVS log date output format changed on CVS 1.12.9

2005-10-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=30576.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30576


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||dev@ant.apache.org




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 37174] - javac task and the -Xlint compiler switch

2005-10-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=37174.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37174


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
   Platform|Other   |Sun
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-10-20 04:06 ---
Yes it worked.

I was just rushing through the documentation.  Sorry.

May be you should add an example in the documentation like:
compilerarg value=-Xlint/

I'm just sorry that such a usefull option is not brought to light by having a
standard javac property assigned to it.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tar and resource collections

2005-10-19 Thread Stefan Bodewig
On Wed, 19 Oct 2005, Matt Benson [EMAIL PROTECTED] wrote:

 Hmm... seems like it would take some work (maybe a lot
 of stream magic), but would still be doable to try to
 augment ZipResource to be able to accept a ZipFile
 instance... ZipFile gets an isOpen() method...
 ZipScanner passes down its ZipFile and defers close()
 to some hook...

I thought about this as well, but I failed to find a non-intrusive way
to make the hook know when to fire.  zipfileset can be defined
outside of any task, for example.  And I wouldn't want to add cleanup
code that was a no-op for all resource collections and had to be
called in all tasks using resource collections.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: FileSet#iterator only returning files

2005-10-19 Thread Stefan Bodewig
On Wed, 19 Oct 2005, Matt Benson [EMAIL PROTECTED] wrote:

 What shall we do?  Return files and directories and let the user
 explicitly use a type selector would be my preference.
 
 I don't see that we have much choice given your
 example above.  Wouldn't we have to invert the
 situation and explicitly ignore directories in tasks
 that have historically used only the results of
 ds.getIncludedFiles() ?

This or make the task check isDirectory() on the resources, yes.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r326804 - /ant/core/trunk/src/main/org/apache/tools/tar/TarOutputStream.java

2005-10-19 Thread bodewig
Author: bodewig
Date: Wed Oct 19 21:21:07 2005
New Revision: 326804

URL: http://svn.apache.org/viewcvs?rev=326804view=rev
Log:
provide more information

Modified:
ant/core/trunk/src/main/org/apache/tools/tar/TarOutputStream.java

Modified: ant/core/trunk/src/main/org/apache/tools/tar/TarOutputStream.java
URL: 
http://svn.apache.org/viewcvs/ant/core/trunk/src/main/org/apache/tools/tar/TarOutputStream.java?rev=326804r1=326803r2=326804view=diff
==
--- ant/core/trunk/src/main/org/apache/tools/tar/TarOutputStream.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/tar/TarOutputStream.java Wed Oct 
19 21:21:07 2005
@@ -44,6 +44,7 @@
 
 protected boolean   debug;
 protected long  currSize;
+protected StringcurrName;
 protected long  currBytes;
 protected byte[]oneBuf;
 protected byte[]recordBuf;
@@ -191,6 +192,7 @@
 } else {
 this.currSize = entry.getSize();
 }
+currName = entry.getName();
 }
 
 /**
@@ -216,7 +218,8 @@
 }
 
 if (this.currBytes  this.currSize) {
-throw new IOException(entry closed at ' + this.currBytes
+throw new IOException(entry ' + currName + ' closed at '
+  + this.currBytes
   + ' before the ' + this.currSize
   + ' bytes specified in the header were 
written);
 }
@@ -266,7 +269,8 @@
 if ((this.currBytes + numToWrite)  this.currSize) {
 throw new IOException(request to write ' + numToWrite
   + ' bytes exceeds size in header of '
-  + this.currSize + ' bytes);
+  + this.currSize + ' bytes for entry '
+  + currName + ');
 
 //
 // We have to deal with assembly!!!



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]