[GitHub] ant issue #51: [master] Changes for BZ-19516
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/51 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/8/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/51 >> an alternative would be to only wrap the stream inside of zipFile if mark wasn't supported. @bodewig, I actually liked your idea. So I did an additional change in this commit (PR has been updated) to wrap the incoming stream into a stream that supports marking, if the incoming one doesn't. That way, it takes into account input streams that this `Zip` class doesn't construct and instead is passed to this method. Please take a look at the updated PR and let me know what you think. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/51 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/1/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977
Do let me know if there's anything I can do to help investigate this. I'm curious myself to see what's causing this. -Jaikiran On 13/12/17 2:56 AM, Stefan Bodewig wrote: On 2017-12-12, Stefan Bodewig wrote: On 2017-12-12, Jaikiran Pai wrote: So the one final test that's still failing is this one[1]. It's failing consistently only on Jenkins, that too with only Java 8 (jdk1.8.0_131). I have tried reproducing that one locally with that exact Java version and even the latest Java 8 and haven't been able to reproduce it. Before I try and debug this on that Jenkins environment (which doesn't seem to be easy to do), I would like to know if this is reproducible for anyone else. No, I haven't been able either. it also fails in Gump: http://vmgump-vm3.apache.org/ant/test-ant/gump_work/build_ant_test-ant.txt I have got shell access to vmgump-vm3 and will try to find some time understanding the error in the comming days. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977
On 2017-12-12, Stefan Bodewig wrote: > On 2017-12-12, Jaikiran Pai wrote: >> So the one final test that's still failing is this one[1]. It's >> failing consistently only on Jenkins, that too with only Java 8 >> (jdk1.8.0_131). I have tried reproducing that one locally with that >> exact Java version and even the latest Java 8 and haven't been able to >> reproduce it. Before I try and debug this on that Jenkins environment >> (which doesn't seem to be easy to do), I would like to know if this is >> reproducible for anyone else. > No, I haven't been able either. it also fails in Gump: http://vmgump-vm3.apache.org/ant/test-ant/gump_work/build_ant_test-ant.txt I have got shell access to vmgump-vm3 and will try to find some time understanding the error in the comming days. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: Please ignore the github emails for the next hour or so
My experiments have completed [1] and any new mails from github/jenkins jobs are genuine mails. Hopefully, the next time I try something around this, it won't take these many spurious mails. [1] https://www.mail-archive.com/dev@ant.apache.org/msg46284.html -Jaikiran On 12/12/17 7:05 PM, Jaikiran Pai wrote: Sorry about the continuous mails from github/ant repo. I'm (yet again) trying to get the Jenkins job integrated with Ant github repo. I don't have a way to disable these mails while I experiment with it to get it right. Hopefully, it should be sorted out in the next hour or so. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Github ant repo now integrated with Jenkins for pull request testing
We now have integrated our Jenkins build environment hosted by apache.org with our Ant github repo[1], such that whenever a pull request is submitted, it now triggers a build and runs tests against the submitted pull request and then comments/adds a status to the PR on how the build went. This is going to help us in doing some basic verification of the changes that's being proposed in the PR. The job resides at [2]. Few details about this job: 1. The goal of this job is to run tests against the PR. It doesn't produce any binaries. Furthermore, unlike the Ant Matrix builds, this one does _not_ run against all possible combinations of JDK/OS. 2. This job has been configured to be run against Windows (for now). I decided to use Windows since that's the one where we usually run into issues and not many of us Ant developers are on Windows. I _might_ add another job for the PRs which tests against Linux, but I'm not sure if there's a easy way to do that. So for now, it's going to be just Windows. 3. This job uses Java 8 runtime to compile and run the tests, irrespective of which branch the PR is submitted against. What this means is even if you submit this PR against 1.9.x branch of Ant, the minimum compatible Java version of which is Java 5, this job will still use Java 8 to both compile and run the job. This means, it may not be able to catch certain (compilation or other) issues. I did not find a way to conditionally choose a JDK version for the job nor did I find a way to conditionally choose a job for a PR (based on what branch it is submitted). So we will have to do with this, till we support multiple branches. However, given that this is just for basic testing and there will be PR reviewers to actually do the review and then another round of tests that get triggered when the PR is merged, I'm not too worried about this constraint for now. 4. Finally, the regular Ant Matrix builds are unchanged and will continue to build after commits are pushed to relevant branches to the Ant upstream repo. Those jobs will remain unaffected by this change. 5. A very minor detail - I have intentionally named the job with a space character in its name so that the checkout location too will contain that space in the directory path (Jenkins uses the project name to create directories for the checked out job). This will allow us to catch certain issues we typically have with URI parsing and such. But that's just a minor detail and doesn't have anything to do with the PR integration itself. The next few days, I'll probably try and see if I can get a Linux based job to run alongside this Windows job for PRs. One other thing - unlike the similar integration we have for Ant Ivy job/repo, this one is much more advanced (in a good way) plugin that's been configured with this Ant repo. This has much more finer grained controls over what can be triggered and who can trigger/retrigger the jobs from pull requests. This still follows the apache build conventions and in fact uses the same technique as many other apache hosted projects do. I'll migrate the one for Ivy to this scheme once things settle down with this one. [1] https://github.com/apache/ant [2] https://builds.apache.org/job/Ant%20Github-PR-Windows/ -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/51 an alternative would be to only wrap the stream inside of `zipFile` if `mark` wasn't supported. But I'm fine with the change as it is. Thank you for dusting of really old issues. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #38: Do not merge
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/38 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/51 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant-Master%20Github-PR-Windows/7/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977
On 2017-12-12, Jaikiran Pai wrote: > So the one final test that's still failing is this one[1]. It's > failing consistently only on Jenkins, that too with only Java 8 > (jdk1.8.0_131). I have tried reproducing that one locally with that > exact Java version and even the latest Java 8 and haven't been able to > reproduce it. Before I try and debug this on that Jenkins environment > (which doesn't seem to be easy to do), I would like to know if this is > reproducible for anyone else. No, I haven't been able either. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #38: Do not merge
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/38 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant-Master%20Github-PR-Windows/6/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #51: [master] Changes for BZ-19516
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/51 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #51: [master] Changes for BZ-19516
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant/pull/51 [master] Changes for BZ-19516 As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the change in this PR uses `java.io.BufferedInputStream` which can take an underlying `InputStream` and provide `mark` support on the input stream. This should prevent loading a large amount of data into memory, in certain cases, in the `Zip` task. If this PR is approved, I'll then backport this pretty straightforward change to 1.9.x branch too. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaikiran/ant bz-19516-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit 759a9c1263e8bb0a710c638960756af2e0971bc4 Author: Jaikiran Pai Date: 2017-12-12T11:22:26Z BZ-19516 Use BufferedInputStream for reduced memory usage in Zip task, in certain cases --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #38: Do not merge
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: Build Script Templates
MG>quick comments below From: Jochen Wiedmann Sent: Tuesday, December 12, 2017 7:54 AM To: dev@ant.apache.org Subject: Build Script Templates Hi, over the last months, I was working in a larger project in a Java environment, but not directly a Java project. Suffice it to say, that we have a number of Java subprojects, but generally aren't so much interested in Java builds, etc. There's no rule without exceptions, so I've been tasked with streamlining these subprojects into a form, which allows to maintain them in a simple, and uniform manner. Not surprising, I was thinking "Maven" initially, and started to rewrite some of these subprojects for Maven. However, it quickly turned out, that access to the Internet is a problem in my particular corporate environment, MG>my internet access was problematic so i dropped IVY .. MG>in maven you can test your pom.xml against local repository with -o option e.g. MG>mvn -o so I dropped Maven from the picture. What I came up with, instead, was a set of conventions, which closely resemble the Maven projects, and a "Maven Jar Template" (MJT). The MJT is an Ant build script, which is generic, and shared by all our subprojects. The actual build scripts typically specify a small set of properties (project.name, project.version, project.java.source.version, and the like), MG>Nota Bene:if you add project.groupId and project.artifactId you will satisfy the GAV reference to a maven artifact and import the MJT. As the project follows the MJT conventions, that's it in most cases, apart from things like a uber jar, etc., which aren't handled by the MJT. However, these are mostly resolved by "overwriting" one of the imported tasks. MG>same concept applies in maven where you declare template in MG>and / or in parent pom MG>then later on you can 'override' either declaration for plugin or dependency in your artifact's local pom.xml In general, our build scripts are unusually small, and concise (for Ant scripts, that is). The experience is so good, that I wonder, if we couldn't start distributing some of these templates with Ant Core, or as a separate ant-templates.jar? If so, a build script could look like below, Jochen MG>do you have a mock of MavenJarTemplate-0.1.xml you can display for us? MG>assume install target is declared in MavenJarTemplate-0.1.xml ? -- The next time you hear: "Don't reinvent the wheel!" http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg [http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg] - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #38: Do not merge
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #38: Do not merge
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/38 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant-Master%20Github-PR-Windows/5/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #38: Do not merge
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Please ignore the github emails for the next hour or so
Sorry about the continuous mails from github/ant repo. I'm (yet again) trying to get the Jenkins job integrated with Ant github repo. I don't have a way to disable these mails while I experiment with it to get it right. Hopefully, it should be sorted out in the next hour or so. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/51 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant-1.9.x%20Github-PR-Windows/8/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/51 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant-Master%20Github-PR-Windows/4/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #38: Do not merge
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/38 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant-Master%20Github-PR-Windows/3/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/51 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant-1.9.x%20Github-PR-Windows/7/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/51 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #38: Do not merge
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/38 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant-1.9.x%20Github-PR-Windows/6/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/51 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant-Master%20Github-PR-Windows/2/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/51 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #38: Do not merge
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #38: Do not merge
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #38: Do not merge
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/38 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #38: Do not merge
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/38 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Build Script Templates
Hi, over the last months, I was working in a larger project in a Java environment, but not directly a Java project. Suffice it to say, that we have a number of Java subprojects, but generally aren't so much interested in Java builds, etc. There's no rule without exceptions, so I've been tasked with streamlining these subprojects into a form, which allows to maintain them in a simple, and uniform manner. Not surprising, I was thinking "Maven" initially, and started to rewrite some of these subprojects for Maven. However, it quickly turned out, that access to the Internet is a problem in my particular corporate environment, so I dropped Maven from the picture. What I came up with, instead, was a set of conventions, which closely resemble the Maven projects, and a "Maven Jar Template" (MJT). The MJT is an Ant build script, which is generic, and shared by all our subprojects. The actual build scripts typically specify a small set of properties (project.name, project.version, project.java.source.version, and the like), and import the MJT. As the project follows the MJT conventions, that's it in most cases, apart from things like a uber jar, etc., which aren't handled by the MJT. However, these are mostly resolved by "overwriting" one of the imported tasks. In general, our build scripts are unusually small, and concise (for Ant scripts, that is). The experiemce is so good, that I wonder, if we couldn't start distributing some of these templates with Ant Core, or as a separate ant-templates.jar? If so, a build script could look like below, Jochen -- The next time you hear: "Don't reinvent the wheel!" http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #51: [master] Changes for BZ-19516
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/51 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #51: [master] Changes for BZ-19516
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant/pull/51 [master] Changes for BZ-19516 As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the change in this PR uses `java.io.BufferedInputStream` which can take an underlying `InputStream` and provide `mark` support on the input stream. This should prevent loading a large amount of data into memory, in certain cases, in the `Zip` task. If this PR is approved, I'll then backport this pretty straightforward change to 1.9.x branch too. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaikiran/ant bz-19516-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit 759a9c1263e8bb0a710c638960756af2e0971bc4 Author: Jaikiran Pai Date: 2017-12-12T11:22:26Z BZ-19516 Use BufferedInputStream for reduced memory usage in Zip task, in certain cases --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #38: Do not merge
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant/pull/38 Do not merge Testing Jenkins integration. Do not merge this PR You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaikiran/ant dummy Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 commit 7722bab09e2baab9cfb140f537dd045f05aba7f2 Author: Jaikiran Pai Date: 2017-09-17T07:45:52Z do not merge --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #51: [master] Changes for BZ-19516
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/51 [master] Changes for BZ-19516 As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the change in this PR uses `java.io.BufferedInputStream` which can take an underlying `InputStream` and provide `mark` support on the input stream. This should prevent loading a large amount of data into memory, in certain cases, in the `Zip` task. If this PR is approved, I'll then backport this pretty straightforward change to 1.9.x branch too. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaikiran/ant bz-19516-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit 759a9c1263e8bb0a710c638960756af2e0971bc4 Author: Jaikiran Pai Date: 2017-12-12T11:22:26Z BZ-19516 Use BufferedInputStream for reduced memory usage in Zip task, in certain cases --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977
So the one final test that's still failing is this one[1]. It's failing
consistently only on Jenkins, that too with only Java 8 (jdk1.8.0_131).
I have tried reproducing that one locally with that exact Java version
and even the latest Java 8 and haven't been able to reproduce it. Before
I try and debug this on that Jenkins environment (which doesn't seem to
be easy to do), I would like to know if this is reproducible for anyone
else.
[1]
https://builds.apache.org/job/Ant-Build-Matrix-master-Linux/lastCompletedBuild/jdk=JDK%201.8%20(latest)/testReport/org.apache.tools.ant.taskdefs.optional.unix/SymlinkTest/testRecreate/
-Jaikiran
On 10/12/17 3:13 PM, Stefan Bodewig wrote:
On 2017-12-10, Stefan Bodewig wrote:
testCreateDoubleHanging is related to
https://bz.apache.org/bugzilla/show_bug.cgi?id=38199 judging from the
history. Here the link points to a non-existent file and Files.exists
returns false in Java8.
fixed by
@@ -37,6 +37,7 @@ import java.io.IOException;
import java.io.InputStream;
import java.io.PrintStream;
import java.nio.file.Files;
+import java.nio.file.LinkOption;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.ArrayList;
@@ -440,7 +441,7 @@ public class Symlink extends DispatchTask {
private void doLink(String res, String lnk) throws BuildException {
final Path link = Paths.get(lnk);
final Path target = Paths.get(res);
-final boolean alreadyExists = Files.exists(link);
+final boolean alreadyExists = Files.exists(link,
LinkOption.NOFOLLOW_LINKS);
if (!alreadyExists) {
// if the path (at which the link is expected to be created)
isn't already present
// then we just go ahead and attempt to symlink
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
