[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/61/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #63: Replace JAI with ImageIO
GitHub user twogee opened a pull request: https://github.com/apache/ant/pull/63 Replace JAI with ImageIO Undeprecate Image task in Java 9+. No documentation yet; only the code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant image-with-imageio Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 commit 7930191ba5300eeccd6a021b9ae6f7e616482ffe Author: twogee Date: 2018-07-06T19:03:13Z Replace JAI with ImageIO --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: ant git commit: Unbreak tests
Hello all
Just for your info, please take into consideration for a rollback or not
descision (I am neither happy with the commit, nor happy with a rollback
and therefore am 0 on rollback or not):
I have written a small checker to remove all whitespace only diffs from
the diffs on the URL below.
Significant whitespace changes that may have been lost would be unlikely
(space difference before "/>" , ">" or ")" and around "=" is also ignored)
That would reduce the original "2f64e0b5" diff to (the extra lines
starting with \ before the diff are added by the checker i wrote)
Removing whitespace only changes from asf.txt
From: Gintas Grigelionis
Date: Sun, 1 Jul 2018 13:31:35 + (+0200)
Subject: Trailing whitespace
X-Git-Url:
https://git1-us-west.apache.org/repos/asf?p=ant.git;a=commitdiff_plain;h=2f64e0b5
Trailing whitespace
---
\
\@ -87,11 +87,11 @@
JDepend Analysis align="right">Designed for use with href="http://www.clarkware.com/software/JDepend.html;>JDepend and href="https://ant.apache.org;>Ant. width="100%"> Summary align="right">
\@ -87,11 +87,11 @@
JDepend Analysis align="right">Designed for use with href="http://www.clarkware.com/software/JDepend.html;>JDepend and href="http://jakarta.apache.org;>Ant. width="100%"> Summary align="right">
\
diff --git a/src/etc/jdepend.xsl b/src/etc/jdepend.xsl
index f813297..907ade2 100644
--- a/src/etc/jdepend.xsl
+++ b/src/etc/jdepend.xsl
@@ -87,11 +87,11 @@
-
+
JDepend Analysis
- Designed for use with href="http://www.clarkware.com/software/JDepend.html;>JDepend and href="http://jakarta.apache.org;>Ant.
-
-
+ Designed for use with href="http://www.clarkware.com/software/JDepend.html;>JDepend and href="https://ant.apache.org;>Ant.
+
+
Summary
\
\@ -57,8 +57,8 @@ dir="${test.dir}/src/org/apache/tools/ant"/> dir="${test.dir}/dest"/> file="${test.dir}/src/org/apache/tools/ant/DirscannerSetup.java">
Re: ant git commit: Unbreak tests
On 2018-07-06, Jaikiran Pai wrote: > On 05/07/18 2:42 PM, Stefan Bodewig wrote: >> On 2018-07-05, Jaikiran Pai wrote: >>> I personally believe that reviewing these meaningless changes is a >>> waste of time and energy. I'm in favour of rolling back the entire >>> commit set if that's what it takes. >> +1 >> although reverting the commits in both branches and merging back the >> 1.9.x branch is likely going to end in an ugly merge that will need >> review as well. Hopefullly a shorter one. > Yes, I agree.I plan to attempt this later tonight (around 8 hours from > now) if no one else gets to it before that. Just letting it know here, > so that we don't end up duplicating these efforts. Thank you. I'm unlikely to get there before you do, would have tackled it tomorrow. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: ant git commit: Unbreak tests
On 05/07/18 2:42 PM, Stefan Bodewig wrote: On 2018-07-05, Jaikiran Pai wrote: I personally believe that reviewing these meaningless changes is a waste of time and energy. I'm in favour of rolling back the entire commit set if that's what it takes. +1 although reverting the commits in both branches and merging back the 1.9.x branch is likely going to end in an ugly merge that will need review as well. Hopefullly a shorter one. Yes, I agree.I plan to attempt this later tonight (around 8 hours from now) if no one else gets to it before that. Just letting it know here, so that we don't end up duplicating these efforts. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
