[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/75/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/81/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/74/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/80/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/77/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user twogee commented on the issue: https://github.com/apache/ant/pull/63 Thanks for reviewing. I hope my last refactoring clarifies the point about the string field in the Text class (or the string attribute in the text element). --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/71/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/63 `addImageOperation` indeed looks strange (as does the manual when it talks about `ImageOperation`, By virtue of `add(ImageOperation)` you can add any type as nested element that implements `ImgeOperation` which is a good thing. Not sure what you mean with "text has the wrong attribute". --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/75/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/69/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/74/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/68/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user twogee commented on the issue: https://github.com/apache/ant/pull/63 I will do move `addRectangle` and `addText` to `Draw`, it makes no sense to have them in an abstract class. The manual needs correction regarding `ImageOperation`, both for image and imageio tasks: it should not be mentioned at all. Even if imageoperation could be used as a nested tag, it will only cause instantiation exception. Besides, text has a wrong attribute, it's "string", not "text"; so it makes sense to redraw both class diagrams ð --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/63 Looks good to me. I probably wouldn't have touched the image task's diagram at all, but that's your choice. No idea about `addRectangle`. If things work if you move the method over to `Draw` I suggest you do so for the imageio task and leave things as they are in image. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user twogee commented on the issue: https://github.com/apache/ant/pull/63 Looks like disk is full in CI server... --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/67/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/73/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user twogee commented on the issue: https://github.com/apache/ant/pull/63 Looking at the class diagram, I wonder why `addRectangle()` is in TransformOperation rather than only in Draw? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/66/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/72/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user twogee commented on the issue: https://github.com/apache/ant/pull/63 I decided to redraw the class diagram as GraphML (continuing Ivy tradition of using yEd), because it's quite informative. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/63 or live without any UML diagram :-) - no, I don't think we've got anything but the image. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user twogee commented on the issue: https://github.com/apache/ant/pull/63 I could almost reuse the class diagram in the documentation if it wasn't referring to PlanarImage... so I have to draw a new one unless the original UML is available somewhere (a long shot, I know...) --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/63/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/69/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/63 Looks as if only the manual was missing. :-) --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/62/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/68/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user twogee commented on the issue: https://github.com/apache/ant/pull/63 "imageio" is fine by me, then we skip a potential debacle about naming of java-jai.jar ð Whenever JAI is laid to rest, "image" can be reclaimed as an alias. FWIW Java 8 is an LTS release, but hopefully not the last one. So, it's refactoring, fixing build.xml, writing the documentation and putting a note about JAI in Image task manual -- did I miss something? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/63 My scenario is people using Java 8, where JAI still works - Java 8 is far less dead than Java 9 in my view :-) I'd prefer a new "imageio" (or whatever it is called) task that doesn't suggest it was a drop-in replacement. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user twogee commented on the issue: https://github.com/apache/ant/pull/63 JAI is dead. It depends on internal classes that are no longer there in Java 9. I propose dropping JAI API support completely, just like apt or javah. I don't like the like the idea of shipping dead code for the sake of BWC. If someone would like to use JAI on Java 8, there is an option of using an older ant-jai.jar; else, [jai-imageio-core](https://jai-imageio.github.io/jai-imageio-core/) implements the lacking functionality (TIFF support). Also, there are [TwelveMonkeys](https://haraldk.github.io/TwelveMonkeys/) for even more functionality. The task is not deprecated in documentation because it works on Java 8 as is; perhaps the situation with JAI should be explained once there's an agreement on how to proceed. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/63 I'm a bit torn as this PR breaks public APIs and may break build environments where somebody has managed to install JAI. for example because they've downloaded it long ago. Maybe it would be better to make this a new task so people can actively chose the implementation. Also note we have deprecated the Java classes but the image task's manual doesn't mention deprecation at all. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/63 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/61/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
