[jira] [Created] (ARIES-1880) Use builder instead of many parameters in subscribe
Christian Schneider created ARIES-1880: -- Summary: Use builder instead of many parameters in subscribe Key: ARIES-1880 URL: https://issues.apache.org/jira/browse/ARIES-1880 Project: Aries Issue Type: Improvement Components: Journaled Events Reporter: Christian Schneider Assignee: Christian Schneider -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARIES-1880) Use builder instead of many parameters in subscribe
[ https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated ARIES-1880: --- Description: Subscription subscribe(String topic, Position position, Seek seek, Consumer callback); 4 Parameters which can partly be null is not a good idea. [~alien11689] proposed on the list to use a DTO. > Use builder instead of many parameters in subscribe > --- > > Key: ARIES-1880 > URL: https://issues.apache.org/jira/browse/ARIES-1880 > Project: Aries > Issue Type: Improvement > Components: Journaled Events >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > > Subscription subscribe(String topic, Position position, Seek seek, > Consumer callback); > 4 Parameters which can partly be null is not a good idea. [~alien11689] > proposed on the list to use a DTO. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe
[ https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734159#comment-16734159 ] ASF subversion and git services commented on ARIES-1880: Commit 12c21af3f7bea344f594546d74227dd1862d0eca in aries-journaled-events's branch refs/heads/ARIES-1880 from Christian Schneider [ https://gitbox.apache.org/repos/asf?p=aries-journaled-events.git;h=12c21af ] ARIES-1880 - Use builder in subscribe > Use builder instead of many parameters in subscribe > --- > > Key: ARIES-1880 > URL: https://issues.apache.org/jira/browse/ARIES-1880 > Project: Aries > Issue Type: Improvement > Components: Journaled Events >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > > Subscription subscribe(String topic, Position position, Seek seek, > Consumer callback); > 4 Parameters which can partly be null is not a good idea. [~alien11689] > proposed on the list to use a DTO. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] cschneider opened a new pull request #10: ARIES-1880 - Use builder in subscribe
cschneider opened a new pull request #10: ARIES-1880 - Use builder in subscribe URL: https://github.com/apache/aries-journaled-events/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe
[ https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734161#comment-16734161 ] Christian Schneider commented on ARIES-1880: [~alien11689] .. is this what you thought of ? https://github.com/apache/aries-journaled-events/pull/10 > Use builder instead of many parameters in subscribe > --- > > Key: ARIES-1880 > URL: https://issues.apache.org/jira/browse/ARIES-1880 > Project: Aries > Issue Type: Improvement > Components: Journaled Events >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Subscription subscribe(String topic, Position position, Seek seek, > Consumer callback); > 4 Parameters which can partly be null is not a good idea. [~alien11689] > proposed on the list to use a DTO. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe
[ https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734339#comment-16734339 ] Dominik Przybysz commented on ARIES-1880: - Yes :) It will be even more readable if you replace the getters and setters with lombok :) > Use builder instead of many parameters in subscribe > --- > > Key: ARIES-1880 > URL: https://issues.apache.org/jira/browse/ARIES-1880 > Project: Aries > Issue Type: Improvement > Components: Journaled Events >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Subscription subscribe(String topic, Position position, Seek seek, > Consumer callback); > 4 Parameters which can partly be null is not a good idea. [~alien11689] > proposed on the list to use a DTO. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe
[
https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734420#comment-16734420
]
Timothee Maret commented on ARIES-1880:
---
FWIW, using a Builder looks like a good approach to me. The current PR seems to
include a slightly different approach than the builder pattern though. If we
use the actual pattern (all building method return a
{{SubscribeRequestBuilder}}, a {{build}} method return the actual
{{SubscribeRequest}}) then we could add some checks in the builder that would
allow to enforce, for instance, that the Seek parameter is set.
> Use builder instead of many parameters in subscribe
> ---
>
> Key: ARIES-1880
> URL: https://issues.apache.org/jira/browse/ARIES-1880
> Project: Aries
> Issue Type: Improvement
> Components: Journaled Events
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Subscription subscribe(String topic, Position position, Seek seek,
> Consumer callback);
> 4 Parameters which can partly be null is not a good idea. [~alien11689]
> proposed on the list to use a DTO.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (ARIES-1880) Use builder instead of many parameters in subscribe
[
https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734420#comment-16734420
]
Timothee Maret edited comment on ARIES-1880 at 1/4/19 6:08 PM:
---
FWIW, using a Builder looks like a good approach to me.
-The current PR seems to include a slightly different approach than the builder
pattern though. If we use the actual pattern (all building method return a
{{SubscribeRequestBuilder}}, a {{build}} method return the actual
{{SubscribeRequest}}) then we could add some checks in the builder that would
allow to enforce, for instance, that the Seek parameter is set.-
Ah, scratched the above after a second look, Seek has a default value set ..
lgtm ;-)
was (Author: marett):
FWIW, using a Builder looks like a good approach to me. The current PR seems to
include a slightly different approach than the builder pattern though. If we
use the actual pattern (all building method return a
{{SubscribeRequestBuilder}}, a {{build}} method return the actual
{{SubscribeRequest}}) then we could add some checks in the builder that would
allow to enforce, for instance, that the Seek parameter is set.
> Use builder instead of many parameters in subscribe
> ---
>
> Key: ARIES-1880
> URL: https://issues.apache.org/jira/browse/ARIES-1880
> Project: Aries
> Issue Type: Improvement
> Components: Journaled Events
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Subscription subscribe(String topic, Position position, Seek seek,
> Consumer callback);
> 4 Parameters which can partly be null is not a good idea. [~alien11689]
> proposed on the list to use a DTO.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Journaled events MongoDB implementation
Hi I would like to offer to contribute MongoDB based implementation to event journal sub project [1] A bit of myself: My name is Alexei Krainiouk and I’ve been developer at Adobe for over 10 years, based in San Francisco, Bay Area. Recently I joined the team that works on cloud development of Adobe Experience Manager. Currently working together with Timothee Maret and Christian Schneider on AEM content publishing. As Timothee described earlier in this forum we have Kafka based implementation of content publishing that he already offered to contribute. I am working on the MongoDB implementation and it would make sense to have it as an alternative back end for journaled event API as well. Please let me know if this would be useful/interesting. Regards Alexei [0] https://lists.apache.org/thread.html/47c4c103c026ad57887796d400c6ae6004fa8346346d8b4321ceceee@%3Cdev.aries.apache.org%3E [1] https://github.com/apache/aries-journaled-events
[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe
[ https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734799#comment-16734799 ] ASF subversion and git services commented on ARIES-1880: Commit bc2769ade6b1c5c111e397e3830f6b5d4ebd91c3 in aries-journaled-events's branch refs/heads/master from Christian Schneider [ https://gitbox.apache.org/repos/asf?p=aries-journaled-events.git;h=bc2769a ] Merge pull request #10 from apache/ARIES-1880 ARIES-1880 - Use builder in subscribe > Use builder instead of many parameters in subscribe > --- > > Key: ARIES-1880 > URL: https://issues.apache.org/jira/browse/ARIES-1880 > Project: Aries > Issue Type: Improvement > Components: Journaled Events >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Subscription subscribe(String topic, Position position, Seek seek, > Consumer callback); > 4 Parameters which can partly be null is not a good idea. [~alien11689] > proposed on the list to use a DTO. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] cschneider closed pull request #10: ARIES-1880 - Use builder in subscribe
cschneider closed pull request #10: ARIES-1880 - Use builder in subscribe URL: https://github.com/apache/aries-journaled-events/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (ARIES-1880) Use builder instead of many parameters in subscribe
[ https://issues.apache.org/jira/browse/ARIES-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734798#comment-16734798 ] ASF subversion and git services commented on ARIES-1880: Commit 12c21af3f7bea344f594546d74227dd1862d0eca in aries-journaled-events's branch refs/heads/master from Christian Schneider [ https://gitbox.apache.org/repos/asf?p=aries-journaled-events.git;h=12c21af ] ARIES-1880 - Use builder in subscribe > Use builder instead of many parameters in subscribe > --- > > Key: ARIES-1880 > URL: https://issues.apache.org/jira/browse/ARIES-1880 > Project: Aries > Issue Type: Improvement > Components: Journaled Events >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Subscription subscribe(String topic, Position position, Seek seek, > Consumer callback); > 4 Parameters which can partly be null is not a good idea. [~alien11689] > proposed on the list to use a DTO. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
