Re: [CI] Code coverage reports

[Antoine Pitrou]

Hi,

There's now a draft PR that generates and uploads Python / Cython code
coverage.  See example report here:
https://codecov.io/gh/apache/arrow/pull/2050/list/

Regards

Antoine.


On Sat, 12 May 2018 16:18:47 +0200
Antoine Pitrou  wrote:

> Le 12/05/2018 à 00:55, Wes McKinney a écrit :
> > 
> > Thanks for doing this! I am sure our code coverage has suffered as a
> > result of not having the reports. I wonder what it would take to get
> > C++ coverage that includes lines touched by Python unit test execution  
> 
> Nothing, because it already does :-)
> I'm now working on Python / Cython code coverage.
> 
> Regards
> 
> Antoine.
> 

Re: [CI] Code coverage reports

[Antoine Pitrou]

Le 12/05/2018 à 00:55, Wes McKinney a écrit :
> 
> Thanks for doing this! I am sure our code coverage has suffered as a
> result of not having the reports. I wonder what it would take to get
> C++ coverage that includes lines touched by Python unit test execution

Nothing, because it already does :-)
I'm now working on Python / Cython code coverage.

Regards

Antoine.

Re: [CI] Code coverage reports

[Antoine Pitrou]

Hi Wes,

Le 11/05/2018 à 05:32, Wes McKinney a écrit :
> 
> I also prefer codecov.io, but unfortunately Apache Infra does not
> support it I believe due to some app hook permissions issue (there are
> some similar problems preventing CircleCI from being made available to
> Apache projects). I have asked before, you are welcome to open an
> INFRA ticket to ask again.
Can you elaborate on "Apache Infra does not support it"?  What does it
mean for us exactly?

Right now a typical PR gets coverage measured and posted as a comment by
the codecov bot (*).  Do we expect some tighter integration with GitHub?

(*) example: https://github.com/apache/arrow/pull/2026

Regards

Antoine.

[CI] Code coverage reports

[Antoine Pitrou]

Hi,

Previous efforts to gather and publish C++ code coverage using the free
service provided by coveralls.io have stalled (see ARROW-27).

I went ahead and experimented with another free service, codecov.io.  I
got it to work with our C++ and Rust code bases.  An example report can
be seen here:
https://codecov.io/gh/apache/arrow/list/8804ab50118f46139986acc435d740cb536f08f4/

The proposed changes are in PR #2023.

The two platforms, codecov.io and coveralls.io, seem largely similar:
they provide free hosting for code coverage reports, support a range of
programming languages and code coverage formats, and display compute
coverage changes accross repository commits.  I find codecov.io slightly
more readable but that's just a personal opinion.

Do people or the Apache project have a strong preference for one of
those two services?

Regards

Antoine.