[jira] [Assigned] (ATLAS-2953) UI : Lineage show detail popup while clicking on node

2019-01-21 Thread Abhishek Kadam (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Kadam reassigned ATLAS-2953:
-

Assignee: Abhishek Kadam

> UI : Lineage show detail popup while clicking on node
> -
>
> Key: ATLAS-2953
> URL: https://issues.apache.org/jira/browse/ATLAS-2953
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Abhishek Kadam
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2953) UI : Lineage show detail popup while clicking on node

2019-01-21 Thread Abhishek Kadam (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Kadam updated ATLAS-2953:
--
Attachment: ATLAS-2953.patch

> UI : Lineage show detail popup while clicking on node
> -
>
> Key: ATLAS-2953
> URL: https://issues.apache.org/jira/browse/ATLAS-2953
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Abhishek Kadam
>Priority: Major
> Attachments: ATLAS-2953.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2953) UI : Lineage show detail popup while clicking on node

2019-01-21 Thread Abhishek Kadam (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Kadam updated ATLAS-2953:
--
Attachment: (was: ATLAS-2953.patch)

> UI : Lineage show detail popup while clicking on node
> -
>
> Key: ATLAS-2953
> URL: https://issues.apache.org/jira/browse/ATLAS-2953
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Abhishek Kadam
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2953) UI : Lineage show detail popup while clicking on node

2019-01-21 Thread Abhishek Kadam (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Kadam updated ATLAS-2953:
--
Attachment: ATLAS-2953.patch

> UI : Lineage show detail popup while clicking on node
> -
>
> Key: ATLAS-2953
> URL: https://issues.apache.org/jira/browse/ATLAS-2953
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Abhishek Kadam
>Priority: Major
> Attachments: ATLAS-2953.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 69707: API: Audit Scan for Classification Updates

2019-01-21 Thread Ashutosh Mestry 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69707/
---

(Updated Jan. 21, 2019, 7:59 p.m.)


Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and 
Sarath Subramanian.


Changes
---

Updates include: 
- Addressed review comments.
- Unit tests refactored for brevity.


Bugs: ATLAS-3029
https://issues.apache.org/jira/browse/ATLAS-3029


Repository: atlas


Description
---

**Approach**
- Scan HBase 'ATLAS_ENTITY_AUDIT_EVENTS' table with approprite paramters.
- New: Package the output into _AtlasEntityHeaders_.
- Provide _REST APIs_ to _EntityREST_.
- _AtlasClientV2_ updated to support the new endpoints.

**Rules for _setClassifications_**
- If incoming _AtlasEntityHeader_:
- Has no classifications: Delete entity's classification.
- Has classifications & entity does not have the classification: Add to 
entity's classifications.
- Has classifications & entity has the classification: Update entity's 
classification.
 

**CURL**

_Fetch_
curl -X GET  -u admin:passWord -H 'Content-Type: application/json'
  
'http://localhost:21000/api/atlas/v2/entity/bulk/headers?tagUpdateStartTime=154699200'
 \

_Udpate_
curl -X POST  -u admin:passWord -H 'Content-Type: application/json'
  'http://localhost:21000/api/atlas/v2/entity/bulk/setClassifications' 
  -d @fetched-classifications.json


**Not supported**
- Cassandra based Audits.
- For testing: In-memory audits.


Diffs (updated)
-

  0001-ATLAS-3020-Audit-APIs-for-classification-updates.patch PRE-CREATION 
  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7c8caee89 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeaders.java 
PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
 eb78f8f70 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java
 aab2d5b6c 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 6f4415fa8 
  
repository/src/main/java/org/apache/atlas/repository/audit/InMemoryEntityAuditRepository.java
 dca3b853e 
  
repository/src/main/java/org/apache/atlas/repository/audit/NoopEntityAuditRepository.java
 e3a607809 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 750fa1775 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 35aa3afed 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociator.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 066abc109 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociatorTest.java
 PRE-CREATION 
  
repository/src/test/resources/json/classification-association/col-entity-None.json
 PRE-CREATION 
  
repository/src/test/resources/json/classification-association/col-entity-PII-FIN_PII.json
 PRE-CREATION 
  
repository/src/test/resources/json/classification-association/col-entity-PII.json
 PRE-CREATION 
  
repository/src/test/resources/json/classification-association/col-entity-T1-prop-Tn.json
 PRE-CREATION 
  
repository/src/test/resources/json/classification-association/header-FIN_PII.json
 PRE-CREATION 
  
repository/src/test/resources/json/classification-association/header-None.json 
PRE-CREATION 
  
repository/src/test/resources/json/classification-association/header-PII-VENDOR_PII.json
 PRE-CREATION 
  repository/src/test/resources/json/classification-association/header-PII.json 
PRE-CREATION 
  
repository/src/test/resources/json/classification-association/header-Tx-prop-T1.json
 PRE-CREATION 
  repository/src/test/resources/json/classification-association/header-Tx.json 
PRE-CREATION 
  
repository/src/test/resources/json/classification-association/header-empty.json 
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 68c132c37 


Diff: https://reviews.apache.org/r/69707/diff/9/

Changes: https://reviews.apache.org/r/69707/diff/8-9/


Testing
---

**Unit tests**
New tests added.

**Functional tests**
Via CURL calls.

**Volume tests**
Loads of over 2000 entities.
Classification types: 50
Entities: 8102
File size: 3.3 MB.
Duration: 11 mins


File Attachments


entity-headers.json
  
https://reviews.apache.org/media/uploaded/files/2019/01/14/a23bead7-6990-4d5b-b3b8-f46f990f5d99__entity-headers.json


Thanks,

Ashutosh Mestry

Re: Review Request 69707: API: Audit Scan for Classification Updates

2019-01-21 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69707/#review212181
---


Fix it, then Ship it!





0001-ATLAS-3020-Audit-APIs-for-classification-updates.patch
Lines 1 (patched)


Patch file included by mistake? Please remove before committing the patch.


- Madhan Neethiraj


On Jan. 21, 2019, 7:59 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69707/
> ---
> 
> (Updated Jan. 21, 2019, 7:59 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3029
> https://issues.apache.org/jira/browse/ATLAS-3029
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> - Scan HBase 'ATLAS_ENTITY_AUDIT_EVENTS' table with approprite paramters.
> - New: Package the output into _AtlasEntityHeaders_.
> - Provide _REST APIs_ to _EntityREST_.
> - _AtlasClientV2_ updated to support the new endpoints.
> 
> **Rules for _setClassifications_**
> - If incoming _AtlasEntityHeader_:
> - Has no classifications: Delete entity's classification.
> - Has classifications & entity does not have the classification: Add to 
> entity's classifications.
> - Has classifications & entity has the classification: Update entity's 
> classification.
>  
> 
> **CURL**
> 
> _Fetch_
> curl -X GET  -u admin:passWord -H 'Content-Type: application/json'
>   
> 'http://localhost:21000/api/atlas/v2/entity/bulk/headers?tagUpdateStartTime=154699200'
>  \
> 
> _Udpate_
> curl -X POST  -u admin:passWord -H 'Content-Type: application/json'
>   'http://localhost:21000/api/atlas/v2/entity/bulk/setClassifications' 
>   -d @fetched-classifications.json
> 
> 
> **Not supported**
> - Cassandra based Audits.
> - For testing: In-memory audits.
> 
> 
> Diffs
> -
> 
>   0001-ATLAS-3020-Audit-APIs-for-classification-updates.patch PRE-CREATION 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 
> 7c8caee89 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeaders.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
>  eb78f8f70 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java
>  aab2d5b6c 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
>  6f4415fa8 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/InMemoryEntityAuditRepository.java
>  dca3b853e 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/NoopEntityAuditRepository.java
>  e3a607809 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  750fa1775 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  35aa3afed 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociator.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  066abc109 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociatorTest.java
>  PRE-CREATION 
>   
> repository/src/test/resources/json/classification-association/col-entity-None.json
>  PRE-CREATION 
>   
> repository/src/test/resources/json/classification-association/col-entity-PII-FIN_PII.json
>  PRE-CREATION 
>   
> repository/src/test/resources/json/classification-association/col-entity-PII.json
>  PRE-CREATION 
>   
> repository/src/test/resources/json/classification-association/col-entity-T1-prop-Tn.json
>  PRE-CREATION 
>   
> repository/src/test/resources/json/classification-association/header-FIN_PII.json
>  PRE-CREATION 
>   
> repository/src/test/resources/json/classification-association/header-None.json
>  PRE-CREATION 
>   
> repository/src/test/resources/json/classification-association/header-PII-VENDOR_PII.json
>  PRE-CREATION 
>   
> repository/src/test/resources/json/classification-association/header-PII.json 
> PRE-CREATION 
>   
> repository/src/test/resources/json/classification-association/header-Tx-prop-T1.json
>  PRE-CREATION 
>   
> repository/src/test/resources/json/classification-association/header-Tx.json 
> PRE-CREATION 
>   
> repository/src/test/resources/json/classification-association/header-empty.json
>  PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 68c132c37 
> 
> 
> Diff: https://reviews.apache.org/r/69707/diff/9/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional tests**
> Via CURL calls.
> 
> **Volume

[jira] [Created] (ATLAS-3034) Perf enhancement to avoid unnecessary lookup when creating new relationships

2019-01-21 Thread Sarath Subramanian (JIRA) 
Sarath Subramanian created ATLAS-3034:
-

 Summary: Perf enhancement to avoid unnecessary lookup when 
creating new relationships
 Key: ATLAS-3034
 URL: https://issues.apache.org/jira/browse/ATLAS-3034
 Project: Atlas
  Issue Type: Improvement
  Components:  atlas-core
Affects Versions: 1.2.0, 2.0.0
Reporter: Sarath Subramanian
Assignee: Sarath Subramanian
 Fix For: 1.2.0, 2.0.0


Perf enhancement to avoid unnecessary lookup when creating new relationships



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 69804: ATLAS-3034: Perf enhancement to avoid unnecessary lookup when creating new relationships

2019-01-21 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69804/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon 
Rodrigues.


Bugs: ATLAS-3034
https://issues.apache.org/jira/browse/ATLAS-3034


Repository: atlas


Description
---

Perf enhancement to avoid unnecessary lookup when creating new relationships in 
entityGraphMapper


Diffs
-

  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
45bf8dca4 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipStore.java
 44689516e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
 86cc98cda 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 98734cc1d 


Diff: https://reviews.apache.org/r/69804/diff/1/


Testing
---

Precommit run: 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/880/console

Before patch : Creating hive_table with 5000 columns took ~31 minutes
After  patch : Creating hive_table with 5000 columns took ~8.4 minutes


Thanks,

Sarath Subramanian

[jira] [Commented] (ATLAS-3034) Perf enhancement to avoid unnecessary lookup when creating new relationships

2019-01-21 Thread Sarath Subramanian (JIRA) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748271#comment-16748271
 ] 

Sarath Subramanian commented on ATLAS-3034:
---

Perf improvement - creating hive_table with 5000 columns

*Before patch:*
2019-01-21 19:27:17,223|NotificationHookConsumer 
thread-0|PERF|createOrUpdate()|1847974
2019-01-21 19:28:12,778|NotificationHookConsumer 
thread-0|PERF|ENTITY_CREATE_V2|1903529 (*~ 31 minutes*)

*After patch:*
2019-01-21 20:05:19,227|NotificationHookConsumer 
thread-0|PERF|createOrUpdate()|450430
2019-01-21 20:06:14,423|NotificationHookConsumer 
thread-0|PERF|ENTITY_CREATE_V2|505626 (*~ 8.4 minutes*)

> Perf enhancement to avoid unnecessary lookup when creating new relationships
> 
>
> Key: ATLAS-3034
> URL: https://issues.apache.org/jira/browse/ATLAS-3034
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 1.2.0, 2.0.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
> Fix For: 1.2.0, 2.0.0
>
>
> Perf enhancement to avoid unnecessary lookup when creating new relationships



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-3034) Perf enhancement to avoid unnecessary lookup when creating new relationships

2019-01-21 Thread Sarath Subramanian (JIRA) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748270#comment-16748270
 ] 

Sarath Subramanian commented on ATLAS-3034:
---

Code review: https://reviews.apache.org/r/69804/

> Perf enhancement to avoid unnecessary lookup when creating new relationships
> 
>
> Key: ATLAS-3034
> URL: https://issues.apache.org/jira/browse/ATLAS-3034
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 1.2.0, 2.0.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
> Fix For: 1.2.0, 2.0.0
>
>
> Perf enhancement to avoid unnecessary lookup when creating new relationships



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-3020) ClientV2: DeleteClassifications Invokes Incorrect REST Call

2019-01-21 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748378#comment-16748378
 ] 

ASF subversion and git services commented on ATLAS-3020:


Commit cb2421bc0eb4f6a9c2d9f6dadf3b9ba0080e3e82 in atlas's branch 
refs/heads/master from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=cb2421b ]

ATLAS-3020: Audit APIs for classification updates.


> ClientV2: DeleteClassifications Invokes Incorrect REST Call
> ---
>
> Key: ATLAS-3020
> URL: https://issues.apache.org/jira/browse/ATLAS-3020
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: 1.1.0, 0.8.4, trunk
>
> Attachments: ATLAS-3020-Atlas-Client-Delete-Classifications-API.patch
>
>
> *Background*
> Existing _AtlasClientV2.deleteClassifications_ invokes incorrect REST API. 
> *Solution*
> The method should invoke the correct REST API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-3029) API: Retrieve Classification Events from Audits

2019-01-21 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748421#comment-16748421
 ] 

ASF subversion and git services commented on ATLAS-3029:


Commit de7fe47a2b714a023c5aa3d4f3b5648306ae7af1 in atlas's branch 
refs/heads/master from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=de7fe47 ]

ATLAS-3029, ATLAS-3020: Audit APIs for classification updates. Part-2.


> API: Retrieve Classification Events from Audits
> ---
>
> Key: ATLAS-3029
> URL: https://issues.apache.org/jira/browse/ATLAS-3029
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core, atlas-intg
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 
> ATLAS-3020-Audit-APIs-for-classification-updates-master.patch
>
>
> *Use Cases*
> 1. In the case where user looses data within Atlas, they can get it ingested 
> by using tool like _import-hive_. With this approach, the user does not get 
> the classifications and the entities associated with them.
> 2. In case where classifications were inadvertently removed from entities.
> *Solution*
> In the scenarios above, currently there isn't a way to know the 
> classification operations performed.
> A REST API that would get this information from Atlas' Audit tables would 
> benefit the user.
> *Approach Guidance*
>  * REST endpoint: Use Atlas' Audit Repository to fetch the audit events. This 
> API should accept a timestamp range so that useful audit events can be 
> fetched.
>  * REST endpoint: Re-play the audit events to update Atlas.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-3029) API: Retrieve Classification Events from Audits

2019-01-21 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748420#comment-16748420
 ] 

ASF subversion and git services commented on ATLAS-3029:


Commit fa7d167537dfcdc48401e810519615723a4c664e in atlas's branch 
refs/heads/master from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=fa7d167 ]

ATLAS-3029: Audit APIs for classification updates.


> API: Retrieve Classification Events from Audits
> ---
>
> Key: ATLAS-3029
> URL: https://issues.apache.org/jira/browse/ATLAS-3029
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core, atlas-intg
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 
> ATLAS-3020-Audit-APIs-for-classification-updates-master.patch
>
>
> *Use Cases*
> 1. In the case where user looses data within Atlas, they can get it ingested 
> by using tool like _import-hive_. With this approach, the user does not get 
> the classifications and the entities associated with them.
> 2. In case where classifications were inadvertently removed from entities.
> *Solution*
> In the scenarios above, currently there isn't a way to know the 
> classification operations performed.
> A REST API that would get this information from Atlas' Audit tables would 
> benefit the user.
> *Approach Guidance*
>  * REST endpoint: Use Atlas' Audit Repository to fetch the audit events. This 
> API should accept a timestamp range so that useful audit events can be 
> fetched.
>  * REST endpoint: Re-play the audit events to update Atlas.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-3020) ClientV2: DeleteClassifications Invokes Incorrect REST Call

2019-01-21 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748422#comment-16748422
 ] 

ASF subversion and git services commented on ATLAS-3020:


Commit de7fe47a2b714a023c5aa3d4f3b5648306ae7af1 in atlas's branch 
refs/heads/master from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=de7fe47 ]

ATLAS-3029, ATLAS-3020: Audit APIs for classification updates. Part-2.


> ClientV2: DeleteClassifications Invokes Incorrect REST Call
> ---
>
> Key: ATLAS-3020
> URL: https://issues.apache.org/jira/browse/ATLAS-3020
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: 1.1.0, 0.8.4, trunk
>
> Attachments: ATLAS-3020-Atlas-Client-Delete-Classifications-API.patch
>
>
> *Background*
> Existing _AtlasClientV2.deleteClassifications_ invokes incorrect REST API. 
> *Solution*
> The method should invoke the correct REST API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 69804: ATLAS-3034: Perf enhancement to avoid unnecessary lookup when creating new relationships

2019-01-21 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69804/#review212188
---




repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Line 345 (original), 345 (patched)


Comments for this method (before this commit) detail the need for 
traversing all edges i.e. ATLAS-1104. Is that issue not relevant now (perhaps 
after moving to JanusGraph?)? Please review.


- Madhan Neethiraj


On Jan. 21, 2019, 11:30 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69804/
> ---
> 
> (Updated Jan. 21, 2019, 11:30 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon 
> Rodrigues.
> 
> 
> Bugs: ATLAS-3034
> https://issues.apache.org/jira/browse/ATLAS-3034
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Perf enhancement to avoid unnecessary lookup when creating new relationships 
> in entityGraphMapper
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 45bf8dca4 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipStore.java
>  44689516e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
>  86cc98cda 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  98734cc1d 
> 
> 
> Diff: https://reviews.apache.org/r/69804/diff/1/
> 
> 
> Testing
> ---
> 
> Precommit run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/880/console
> 
> Before patch : Creating hive_table with 5000 columns took ~31 minutes
> After  patch : Creating hive_table with 5000 columns took ~8.4 minutes
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>