Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70789/
---

(Updated June 7, 2019, 8 a.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
Sridhar K, Le Ma, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sarath 
Subramanian.


Changes
---

fixed IT failures


Bugs: ATLAS-3262
https://issues.apache.org/jira/browse/ATLAS-3262


Repository: atlas


Description
---

- skipped full-text index computation & population when free-text is enabled
- added FreeTextRequestHandlerPatch to create /freetext request handler in Solr
- fixed free-text search handling of typeName filter


Diffs (updated)
-

  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
 edab08cc0 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
 18e6976a4 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphSolrIndexClient.java
 a55fc3689 
  graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
0d5ae4f84 
  intg/src/main/java/org/apache/atlas/ApplicationProperties.java 6d0153f7d 
  intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 0636677ae 
  
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
 1cd507c3b 
  
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 
c4b5ffb12 
  
repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
 b1a84c742 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
50edb9faf 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
2e09beda0 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 56655a845 
  
repository/src/main/java/org/apache/atlas/repository/graph/IndexChangeListener.java
 9cde947aa 
  
repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java 
20a517ff1 
  
repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
 259f24674 
  
repository/src/main/java/org/apache/atlas/repository/patches/FreeTextRequestHandlerPatch.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 035b02ce4 
  
repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java
 1d296057b 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
38de885cf 


Diff: https://reviews.apache.org/r/70789/diff/3/

Changes: https://reviews.apache.org/r/70789/diff/2-3/


Testing
---

- verified that free-text handler is created by the patch for the first time 
this enhancement is applied in an existing env
- verified that the free-text search handles typeName filter correctly
- pre-commit tests run: 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1176/


Thanks,

Madhan Neethiraj

Re: Review Request 70805: ATLAS-3266 : Update version in branch-1.0 to 1.3.0-SNAPSHOT

[keval bhatt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70805/#review215744
---


Ship it!




Ship It!

- keval bhatt


On June 7, 2019, 6:48 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70805/
> ---
> 
> (Updated June 7, 2019, 6:48 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Since 1.2.0 realease is out from branch-1.0 . Updated pom.xml files to 
> replace version 1.2.0-SNAPSHOT to 1.3.0-SNAPSHOT.
> 
> 
> Diffs
> -
> 
>   addons/falcon-bridge-shim/pom.xml 8becfc613 
>   addons/falcon-bridge/pom.xml c4f7e763c 
>   addons/hbase-bridge-shim/pom.xml 3e42bd51d 
>   addons/hbase-bridge/pom.xml a8f2cc321 
>   addons/hdfs-model/pom.xml feee6404f 
>   addons/hive-bridge-shim/pom.xml ddf3a8b8f 
>   addons/hive-bridge/pom.xml 8a045dd09 
>   addons/kafka-bridge/pom.xml 36ae92050 
>   addons/sqoop-bridge-shim/pom.xml fb88d0341 
>   addons/sqoop-bridge/pom.xml f68a098ce 
>   addons/storm-bridge-shim/pom.xml 8f08a7cf3 
>   addons/storm-bridge/pom.xml 850523e71 
>   authorization/pom.xml cbc7af1dd 
>   client/client-v1/pom.xml ef9aca3af 
>   client/client-v2/pom.xml de3bd3cfe 
>   client/common/pom.xml 10528d0a3 
>   client/pom.xml 3f36eab39 
>   common/pom.xml bc10d61a2 
>   dashboardv2/pom.xml 9415ef65b 
>   distro/pom.xml 6ad66e603 
>   docs/pom.xml 256ca369c 
>   graphdb/api/pom.xml c80fdd9fe 
>   graphdb/common/pom.xml ce74c640c 
>   graphdb/graphdb-impls/pom.xml 92768dade 
>   graphdb/janus/pom.xml da72af44b 
>   graphdb/pom.xml f8af9bce2 
>   intg/pom.xml d5ce9f67c 
>   notification/pom.xml 23fdf973f 
>   plugin-classloader/pom.xml 630ee3b58 
>   pom.xml bbe8f329e 
>   repository/pom.xml ab3fb78eb 
>   server-api/pom.xml 6beea0898 
>   shaded/hbase-client-shaded/pom.xml df7d74847 
>   shaded/hbase-server-shaded/pom.xml afd6f2491 
>   test-tools/pom.xml 5cbda9d34 
>   webapp/pom.xml cbbe6d46a 
> 
> 
> Diff: https://reviews.apache.org/r/70805/diff/1/
> 
> 
> Testing
> ---
> 
> Newly build artifacts will have 1.3.0-SNAPSHOT has a version.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

[jira] [Commented] (ATLAS-3266) Update version in branch-1.0 to 1.3.0-SNAPSHOT

[Keval Bhatt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858407#comment-16858407
 ] 

Keval Bhatt commented on ATLAS-3266:


+1 for the patch

> Update version in branch-1.0 to 1.3.0-SNAPSHOT
> --
>
> Key: ATLAS-3266
> URL: https://issues.apache.org/jira/browse/ATLAS-3266
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: 
> 0001-ATLAS-3266-Update-version-in-branch-1.0-to-1.3.0-SNA.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (ATLAS-3206) Atlas REST API: Create new attribute in AtlasGlossaryTerm

[Mayank Jain (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mayank Jain reassigned ATLAS-3206:
--

Assignee: Mayank Jain

> Atlas REST API: Create new attribute in AtlasGlossaryTerm
> -
>
> Key: ATLAS-3206
> URL: https://issues.apache.org/jira/browse/ATLAS-3206
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: José Nilson dos Santos Júnior
>Assignee: Mayank Jain
>Priority: Major
> Fix For: 1.1.0
>
> Attachments: Create_with_custom_attr.png, POST_v2-glossary-term.txt, 
> PUT_v2-glossary-term-termGuid.txt, PUT_v2-types-typedefs.txt, 
> atlasglossaryterm-created.png, atlasglossaryterm-updated.png
>
>
> Hi experts,
>  
> I have been working with Atlas REST API.
> [http://atlas.apache.org/api/v2/index.html]
>  
> I created a new attribute in AtlasGlossaryTerm with the command: See 
> {color:#33}*PUT_v2-types-typedefs.txt*{color}
>  
> I can not update the values of this new attribute. I tried two ways:
>  
> [1] I tried to create a new term with the command: See 
> {color:#33}*POST_v2-glossary-term.txt.*{color}
>  
> The term is created, however the display is empty. See 
> *atlasglossaryterm-created.png*.
>  
> [2] I also tried updating the term created: See 
> {color:#33}*PUT_v2-glossary-term-termGuid.txt*. {color}
> {color:#33}See *atlasglossaryterm-updated.png*.{color}
>  
> How can I solve this?
>  
> Thank you.
> Best Regards.
>  
> José Nilson



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-3266) Update version in branch-1.0 to 1.3.0-SNAPSHOT

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858412#comment-16858412
 ] 

ASF subversion and git services commented on ATLAS-3266:


Commit 5d241a9f71cf06035e598c841a67b667d1df712f in atlas's branch 
refs/heads/branch-1.0 from Nixon Rodrigues
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=5d241a9 ]

ATLAS-3266 - Update version in branch-1.0 to 1.3.0-SNAPSHOT


> Update version in branch-1.0 to 1.3.0-SNAPSHOT
> --
>
> Key: ATLAS-3266
> URL: https://issues.apache.org/jira/browse/ATLAS-3266
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: 
> 0001-ATLAS-3266-Update-version-in-branch-1.0-to-1.3.0-SNA.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (ATLAS-3263) UI: Assign button (Create Term) should be blocked while an API call is in progress

[Binit Gutka (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Binit Gutka reassigned ATLAS-3263:
--

Assignee: Binit Gutka

> UI: Assign button (Create Term) should be blocked while an API call is in 
> progress
> --
>
> Key: ATLAS-3263
> URL: https://issues.apache.org/jira/browse/ATLAS-3263
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Binit Gutka
>Priority: Minor
> Attachments: disableassignbutton.jpg
>
>
> It is possible that if the user clicks the Assign button in the Create Term 
> window multiple times rapidly, the UI detects and acknowledges the same as 
> displayed in the screenshot below. 
> !disableassignbutton.jpg|width=200,height=200!
> The side-effect of this behaviour is that these clicks are recognized in the 
> Audit Log of the entity (to whom term is assigned) and we have multiple "Term 
> Created" entries even though it refers to only one term being created.
> To avoid such behaviour, it would be better to lock the Assign button while 
> the API call is in progress.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [atlas] arempter opened a new pull request #58: [ATLAS-3261] Set kafka user as current principal for Ranger Authorization

[GitBox]

arempter opened a new pull request #58: [ATLAS-3261] Set kafka user as current 
principal for Ranger Authorization
URL: https://github.com/apache/atlas/pull/58
 
 
   If lineage message sent to ATLAS_HOOK has non empty "user" value, 
NotificationHookConsumer.java will set Authentication context to this user, 
allowing check in Ranger policies by Atlas authorizer.
   
   Currently no user is set by NotificationHookConsumer, so Atlas authorizer is 
not invoked. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (ATLAS-3261) Ranger Authorizer for Atlas is not checked for kafka messages

[Adam Rempter (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Rempter updated ATLAS-3261:

Attachment: (was: 0001-set-message-user-as-principal.patch)

> Ranger Authorizer for Atlas is not checked for kafka messages
> -
>
> Key: ATLAS-3261
> URL: https://issues.apache.org/jira/browse/ATLAS-3261
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-intg
>Affects Versions: 1.1.0, 2.0.0
>Reporter: Adam Rempter
>Priority: Major
>  Labels: security
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Atlas can be configured to authorize user actions with Ranger 
> ([https://atlas.apache.org/1.1.0/Atlas-Authorization-Ranger-Authorizer.html]).
>  
> When I use user via REST it works:
> curl -X GET -u testuser:testuser 
> http://localhost:21000/api/atlas/v2/entity/guid/f52151a0-fa08-4eab-b885-ece847a106e0
> {"errorCode":"ATLAS-403-00-001","errorMessage":"testuser is not authorized to 
> perform read entity: guid=f52151a0-fa08-4eab-b885-ece847a106e0"}
>  
> When I send lineage to ATLAS_HOOK, I can create lineage successfully:
> 2019-06-04 14:01:38,974 
> 2019-06-04T12:01:23.867Z|testuser|NotificationHookConsumer|POST|api/atlas/v2/entity/|200|15119
> In above, I think user is taken from lineage message field user in json.
>  
> Of course above is valid if another policy in ranger  (kafka plugin) allows 
> puting messages to ATLAS_HOOK topic. 
>  
> But if I have one user (technical account) to produce to kafka and I want to 
> deny access in Atlas based on user from message, atlas ranger authorizer 
> doens't work.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-3263) UI: Assign button (Create Term) should be blocked while an API call is in progress

[Keval Bhatt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858529#comment-16858529
 ] 

Keval Bhatt commented on ATLAS-3263:


+1 for the patch


> UI: Assign button (Create Term) should be blocked while an API call is in 
> progress
> --
>
> Key: ATLAS-3263
> URL: https://issues.apache.org/jira/browse/ATLAS-3263
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Binit Gutka
>Priority: Minor
> Attachments: ATLAS-3263.patch, disableassignbutton.jpg
>
>
> It is possible that if the user clicks the Assign button in the Create Term 
> window multiple times rapidly, the UI detects and acknowledges the same as 
> displayed in the screenshot below. 
> !disableassignbutton.jpg|width=200,height=200!
> The side-effect of this behaviour is that these clicks are recognized in the 
> Audit Log of the entity (to whom term is assigned) and we have multiple "Term 
> Created" entries even though it refers to only one term being created.
> To avoid such behaviour, it would be better to lock the Assign button while 
> the API call is in progress.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-3265) Publish release artifacts for 1.2.0

[Nixon Rodrigues (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858536#comment-16858536
 ] 

Nixon Rodrigues commented on ATLAS-3265:


h3. Added to rc3 release artifacts to svn apache release directory and 
performed mvn deploy steps for publishing artifacts in apache mvn repository.
h3. Will publish website/documentation changes soon. 

> Publish release artifacts for 1.2.0
> ---
>
> Key: ATLAS-3265
> URL: https://issues.apache.org/jira/browse/ATLAS-3265
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ATLAS-3265) Publish release artifacts for 1.2.0

[Nixon Rodrigues (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues resolved ATLAS-3265.

Resolution: Delivered

> Publish release artifacts for 1.2.0
> ---
>
> Key: ATLAS-3265
> URL: https://issues.apache.org/jira/browse/ATLAS-3265
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-3265) Publish release artifacts for 1.2.0

[Nixon Rodrigues (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3265:
---
Fix Version/s: 1.2.0

> Publish release artifacts for 1.2.0
> ---
>
> Key: ATLAS-3265
> URL: https://issues.apache.org/jira/browse/ATLAS-3265
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 1.2.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ATLAS-3268) Catch ignored in initialize() method of InMemoryJAASConfiguration.java

[Diego Marino Monetti (JIRA)]

Diego Marino Monetti created ATLAS-3268:
---

 Summary: Catch ignored in initialize() method of 
InMemoryJAASConfiguration.java
 Key: ATLAS-3268
 URL: https://issues.apache.org/jira/browse/ATLAS-3268
 Project: Atlas
  Issue Type: Bug
  Components: atlas-intg
Affects Versions: 3.0.0
Reporter: Diego Marino Monetti


I really don't understand what happens. It seems that the catch on line 345 
does not work as it should because the catch is completely ignored. Then the 
job is done perfectly but isn't it that some other problem lurks? I tried to 
move the catch inside the if block, and other nonsense, but the strange 
behavior subsists.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

[Sridhar K]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70789/#review215745
---



Review is not yet complete.


intg/src/main/java/org/apache/atlas/ApplicationProperties.java
Lines 52 (patched)


It is confusing herewhy two properties?


- Sridhar K


On June 7, 2019, 8 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70789/
> ---
> 
> (Updated June 7, 2019, 8 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
> Sridhar K, Le Ma, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3262
> https://issues.apache.org/jira/browse/ATLAS-3262
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - skipped full-text index computation & population when free-text is enabled
> - added FreeTextRequestHandlerPatch to create /freetext request handler in 
> Solr
> - fixed free-text search handling of typeName filter
> 
> 
> Diffs
> -
> 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
>  edab08cc0 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
>  18e6976a4 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphSolrIndexClient.java
>  a55fc3689 
>   graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
> 0d5ae4f84 
>   intg/src/main/java/org/apache/atlas/ApplicationProperties.java 6d0153f7d 
>   intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 0636677ae 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  1cd507c3b 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  c4b5ffb12 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  b1a84c742 
>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
> 50edb9faf 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 2e09beda0 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  56655a845 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/IndexChangeListener.java
>  9cde947aa 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java
>  20a517ff1 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
>  259f24674 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/FreeTextRequestHandlerPatch.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
>  035b02ce4 
>   
> repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java
>  1d296057b 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 38de885cf 
> 
> 
> Diff: https://reviews.apache.org/r/70789/diff/3/
> 
> 
> Testing
> ---
> 
> - verified that free-text handler is created by the patch for the first time 
> this enhancement is applied in an existing env
> - verified that the free-text search handles typeName filter correctly
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1176/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

[Madhan Neethiraj]

> On June 7, 2019, 1:55 p.m., Sridhar K wrote:
> > intg/src/main/java/org/apache/atlas/ApplicationProperties.java
> > Lines 52 (patched)
> > 
> >
> > It is confusing herewhy two properties?

atlas.search.fulltext.enable was an exising property, which enables disabling 
of fulltext-search feature.

atlas.search.freetext.enable was introduced in this commit, to support 
disabling of freetext feature; primarily to address IT failures caused by used 
of embedded-solr.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70789/#review215745
---


On June 7, 2019, 8 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70789/
> ---
> 
> (Updated June 7, 2019, 8 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
> Sridhar K, Le Ma, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3262
> https://issues.apache.org/jira/browse/ATLAS-3262
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - skipped full-text index computation & population when free-text is enabled
> - added FreeTextRequestHandlerPatch to create /freetext request handler in 
> Solr
> - fixed free-text search handling of typeName filter
> 
> 
> Diffs
> -
> 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
>  edab08cc0 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
>  18e6976a4 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphSolrIndexClient.java
>  a55fc3689 
>   graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
> 0d5ae4f84 
>   intg/src/main/java/org/apache/atlas/ApplicationProperties.java 6d0153f7d 
>   intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 0636677ae 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  1cd507c3b 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  c4b5ffb12 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  b1a84c742 
>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
> 50edb9faf 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 2e09beda0 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  56655a845 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/IndexChangeListener.java
>  9cde947aa 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java
>  20a517ff1 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
>  259f24674 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/FreeTextRequestHandlerPatch.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
>  035b02ce4 
>   
> repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java
>  1d296057b 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 38de885cf 
> 
> 
> Diff: https://reviews.apache.org/r/70789/diff/3/
> 
> 
> Testing
> ---
> 
> - verified that free-text handler is created by the patch for the first time 
> this enhancement is applied in an existing env
> - verified that the free-text search handles typeName filter correctly
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1176/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[GitHub] [atlas] nixonrodrigues commented on a change in pull request #58: [ATLAS-3261] Set kafka user as current principal for Ranger Authorization

[GitBox]

nixonrodrigues commented on a change in pull request #58: [ATLAS-3261] Set 
kafka user as current principal for Ranger Authorization
URL: https://github.com/apache/atlas/pull/58#discussion_r291610536
 
 

 ##
 File path: 
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 ##
 @@ -477,6 +484,31 @@ public void doWork() {
 }
 }
 
+private void setMessagePrincipal(String messageUser) throws 
AtlasException {
+Configuration configuration = ApplicationProperties.get();
+boolean msgPrincipalEnabled = 
configuration.getBoolean("atlas.authentication.method.kafka.message.principal", 
false);
+
+if(msgPrincipalEnabled) {
+if (!StringUtils.isEmpty(messageUser)) {
+List grantedAuths = 
getAuthoritiesFromUGI(messageUser);
+UserDetails principal;
+
+if (grantedAuths.isEmpty()) {
+principal = new User(messageUser, "", new HashSet<>());
+} else {
+principal = new User(messageUser, "", grantedAuths);
+}
+
+Authentication finalAuthentication = new 
UsernamePasswordAuthenticationToken(principal, "");
+
SecurityContextHolder.getContext().setAuthentication(finalAuthentication);
 
 Review comment:
   This will be adding authentication in context for every message and this can 
cause performance issue. Can we maintain session some how ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

[Sridhar K]

> On June 7, 2019, 1:55 p.m., Sridhar K wrote:
> > intg/src/main/java/org/apache/atlas/ApplicationProperties.java
> > Lines 52 (patched)
> > 
> >
> > It is confusing herewhy two properties?
> 
> Madhan Neethiraj wrote:
> atlas.search.fulltext.enable was an exising property, which enables 
> disabling of fulltext-search feature.
> 
> atlas.search.freetext.enable was introduced in this commit, to support 
> disabling of freetext feature; primarily to address IT failures caused by 
> used of embedded-solr.

I don't think it is right to introduce a variable to fix INT test. Let me 
investigate this little bit more.


- Sridhar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70789/#review215745
---


On June 7, 2019, 8 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70789/
> ---
> 
> (Updated June 7, 2019, 8 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
> Sridhar K, Le Ma, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3262
> https://issues.apache.org/jira/browse/ATLAS-3262
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - skipped full-text index computation & population when free-text is enabled
> - added FreeTextRequestHandlerPatch to create /freetext request handler in 
> Solr
> - fixed free-text search handling of typeName filter
> 
> 
> Diffs
> -
> 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
>  edab08cc0 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
>  18e6976a4 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphSolrIndexClient.java
>  a55fc3689 
>   graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
> 0d5ae4f84 
>   intg/src/main/java/org/apache/atlas/ApplicationProperties.java 6d0153f7d 
>   intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 0636677ae 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  1cd507c3b 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  c4b5ffb12 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  b1a84c742 
>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
> 50edb9faf 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 2e09beda0 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  56655a845 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/IndexChangeListener.java
>  9cde947aa 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java
>  20a517ff1 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
>  259f24674 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/FreeTextRequestHandlerPatch.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
>  035b02ce4 
>   
> repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java
>  1d296057b 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 38de885cf 
> 
> 
> Diff: https://reviews.apache.org/r/70789/diff/3/
> 
> 
> Testing
> ---
> 
> - verified that free-text handler is created by the patch for the first time 
> this enhancement is applied in an existing env
> - verified that the free-text search handles typeName filter correctly
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1176/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Using Atlas Hook for entity creation

[anshu shukla]

Hi,

I am using atlas hook for creation of entities. But for creating entities
with remote vertex connection like creating Table with DB as a remote
entity is not working.

1- Is there any latest documentation for finding the exact message format
to be used for altas Hook.
2- Does Hooks support creating of complex entities.

Error:
On publishing this msg on Hook:
*{"version":{"version":"1.0.0"},"message":{"type":"ENTITY_CREATE","entities":[{"typeName":"hive_table","values":{"tableType":"MANAGED_TABLE","name":"table@cl8","createTime":"2016-12-28T09:34:53.000Z","temporary":false,"db":{"guid":"96393f8b-4b1c-4d10-b35f-b72eea0bb0a8","typeName":"hive_db"},"qualifiedName":"default.table1@cl8"},"id":{"id":"-­1467290565135246000"}}]}}*


*AtlasBaseException: Invalid instance creation/updation parameters passed :
db={guid=96393f8b-4b1c-4d10-b35f-b72eea0bb0a8, typeName=hive_db}* at
org.apache.atlas.repository.converters.AtlasStructFormatConverter.fromV1ToV2(AtlasStructFormatConverter.java:267)
at
org.apache.atlas.repository.converters.AtlasEntityFormatConverter.fromV1ToV2(AtlasEntityFormatConverter.java:76)
at
org.apache.atlas.repository.converters.AtlasInstanceConverter.fromV1toV2Entity(AtlasInstanceConverter.java:215)

-- 
Thanks & Regards,
Anshu Shukla

Re: Using Atlas Hook for entity creation

[Madhan Neethiraj]

Anshu,

 

In the message given in your email, ‘type’ should be set to ‘ENTITY_CREATE_V2’ 
(and not ‘ENTITY_CREATE’).

 

More details on hook notification message contents can be found at 
HookNotification.java.

 

Hope this helps.

 

Madhan

 

 

From: anshu shukla 
Reply-To: "u...@atlas.apache.org" 
Date: Friday, June 7, 2019 at 8:36 AM
To: "u...@atlas.apache.org" , "dev@atlas.apache.org" 

Cc: "sar...@apache.org" 
Subject: Using Atlas Hook for entity creation

 

Hi, 

 

I am using atlas hook for creation of entities. But for creating entities with 
remote vertex connection like creating Table with DB as a remote entity is not 
working. 

 

1- Is there any latest documentation for finding the exact message format to be 
used for altas Hook.

2- Does Hooks support creating of complex entities.

 

Error:

On publishing this msg on Hook:

{"version":{"version":"1.0.0"},"message":{"type":"ENTITY_CREATE","entities":[{"typeName":"hive_table","values":{"tableType":"MANAGED_TABLE","name":"table@cl8","createTime":"2016-12-28T09:34:53.000Z","temporary":false,"db":{"guid":"96393f8b-4b1c-4d10-b35f-b72eea0bb0a8","typeName":"hive_db"},"qualifiedName":"default.table1@cl8"},"id":{"id":"-­1467290565135246000"}}]}}

 

AtlasBaseException: Invalid instance creation/updation parameters passed : 
db={guid=96393f8b-4b1c-4d10-b35f-b72eea0bb0a8, typeName=hive_db}
at 
org.apache.atlas.repository.converters.AtlasStructFormatConverter.fromV1ToV2(AtlasStructFormatConverter.java:267)
at 
org.apache.atlas.repository.converters.AtlasEntityFormatConverter.fromV1ToV2(AtlasEntityFormatConverter.java:76)
at 
org.apache.atlas.repository.converters.AtlasInstanceConverter.fromV1toV2Entity(AtlasInstanceConverter.java:215)

 

-- 

Thanks & Regards,
Anshu Shukla

[jira] [Created] (ATLAS-3269) basic-search for entities with no-classifications and a search string returns empty result

[Madhan Neethiraj (JIRA)]

Madhan Neethiraj created ATLAS-3269:
---

 Summary: basic-search for entities with no-classifications and a 
search string returns empty result
 Key: ATLAS-3269
 URL: https://issues.apache.org/jira/browse/ATLAS-3269
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Madhan Neethiraj
Assignee: Madhan Neethiraj


ATLAS-2775 introduced basic-search enhancements to search for entities having 
no classification associated. However, such a search along with a free-text 
search string, returns empty result. For example, search with 
{{query=hive_table, classificationName=_NOT_CLASSIFIED}} returns empty results, 
though Atlas has a number of hive_table entities having no classification 
associated.

Please note however that the search for entities having any classification 
return correct results i.e {{query=hive_table, classificationName=_CLASSIFIED}} 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 70812: ATLAS-3269: fixed basic-search handing of search for entities with no-classication

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70812/
---

Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
Sridhar K, Le Ma, Mehul Parikh, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, 
and Sarath Subramanian.


Bugs: ATLAS-3269
https://issues.apache.org/jira/browse/ATLAS-3269


Repository: atlas


Description
---

added "is-null-or-empty" in-memory filter and updated search-processors to use 
this filter instead of "is-null" filter


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
 1cd507c3b 
  
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 
c4b5ffb12 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
38de885cf 


Diff: https://reviews.apache.org/r/70812/diff/1/


Testing
---

- verified that search with query=hive_table, classification=_NOT_CLASSIFIED 
returns all hive_table entities having no classifications
- pre-commit tests run: 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1189/


Thanks,

Madhan Neethiraj

Re: Review Request 70812: ATLAS-3269: fixed basic-search handing of search for entities with no-classication

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70812/#review215762
---


Ship it!




Ship It!

- Sarath Subramanian


On June 7, 2019, 11:13 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70812/
> ---
> 
> (Updated June 7, 2019, 11:13 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
> Sridhar K, Le Ma, Mehul Parikh, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3269
> https://issues.apache.org/jira/browse/ATLAS-3269
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> added "is-null-or-empty" in-memory filter and updated search-processors to 
> use this filter instead of "is-null" filter
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  1cd507c3b 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  c4b5ffb12 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 38de885cf 
> 
> 
> Diff: https://reviews.apache.org/r/70812/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that search with query=hive_table, classification=_NOT_CLASSIFIED 
> returns all hive_table entities having no classifications
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1189/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[jira] [Commented] (ATLAS-3206) Atlas REST API: Create new attribute in AtlasGlossaryTerm

[Sarath Subramanian (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858965#comment-16858965
 ] 

Sarath Subramanian commented on ATLAS-3206:
---

change Jira status to Patch Available and attach link to reviewboard.

> Atlas REST API: Create new attribute in AtlasGlossaryTerm
> -
>
> Key: ATLAS-3206
> URL: https://issues.apache.org/jira/browse/ATLAS-3206
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: José Nilson dos Santos Júnior
>Assignee: Mayank Jain
>Priority: Major
> Fix For: 1.1.0
>
> Attachments: Create_with_custom_attr.png, POST_v2-glossary-term.txt, 
> PUT_v2-glossary-term-termGuid.txt, PUT_v2-types-typedefs.txt, 
> atlasglossaryterm-created.png, atlasglossaryterm-updated.png
>
>
> Hi experts,
>  
> I have been working with Atlas REST API.
> [http://atlas.apache.org/api/v2/index.html]
>  
> I created a new attribute in AtlasGlossaryTerm with the command: See 
> {color:#33}*PUT_v2-types-typedefs.txt*{color}
>  
> I can not update the values of this new attribute. I tried two ways:
>  
> [1] I tried to create a new term with the command: See 
> {color:#33}*POST_v2-glossary-term.txt.*{color}
>  
> The term is created, however the display is empty. See 
> *atlasglossaryterm-created.png*.
>  
> [2] I also tried updating the term created: See 
> {color:#33}*PUT_v2-glossary-term-termGuid.txt*. {color}
> {color:#33}See *atlasglossaryterm-updated.png*.{color}
>  
> How can I solve this?
>  
> Thank you.
> Best Regards.
>  
> José Nilson



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-3269) basic-search for entities with no-classifications and a search string returns empty result

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858989#comment-16858989
 ] 

ASF subversion and git services commented on ATLAS-3269:


Commit 40081d4853ae9923e601f62c150c165f1cea902d in atlas's branch 
refs/heads/master from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=40081d4 ]

ATLAS-3269: fixed basic-search handing of search for entities with 
no-classication


> basic-search for entities with no-classifications and a search string returns 
> empty result
> --
>
> Key: ATLAS-3269
> URL: https://issues.apache.org/jira/browse/ATLAS-3269
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 1.2.0, 2.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3269.patch
>
>
> ATLAS-2775 introduced basic-search enhancements to search for entities having 
> no classification associated. However, such a search along with a free-text 
> search string, returns empty result. For example, search with 
> {{query=hive_table, classificationName=_NOT_CLASSIFIED}} returns empty 
> results, though Atlas has a number of hive_table entities having no 
> classification associated.
> Please note however that the search for entities having any classification 
> return correct results i.e {{query=hive_table, 
> classificationName=_CLASSIFIED}} 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-3269) basic-search for entities with no-classifications and a search string returns empty result

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858991#comment-16858991
 ] 

ASF subversion and git services commented on ATLAS-3269:


Commit 16be4d611652b058ef98b185baa4201625568f90 in atlas's branch 
refs/heads/branch-2.0 from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=16be4d6 ]

ATLAS-3269: fixed basic-search handing of search for entities with 
no-classication

(cherry picked from commit 40081d4853ae9923e601f62c150c165f1cea902d)


> basic-search for entities with no-classifications and a search string returns 
> empty result
> --
>
> Key: ATLAS-3269
> URL: https://issues.apache.org/jira/browse/ATLAS-3269
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 1.2.0, 2.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3269.patch
>
>
> ATLAS-2775 introduced basic-search enhancements to search for entities having 
> no classification associated. However, such a search along with a free-text 
> search string, returns empty result. For example, search with 
> {{query=hive_table, classificationName=_NOT_CLASSIFIED}} returns empty 
> results, though Atlas has a number of hive_table entities having no 
> classification associated.
> Please note however that the search for entities having any classification 
> return correct results i.e {{query=hive_table, 
> classificationName=_CLASSIFIED}} 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-3269) basic-search for entities with no-classifications and a search string returns empty result

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858992#comment-16858992
 ] 

ASF subversion and git services commented on ATLAS-3269:


Commit 52ba8b4f755113be98e87861ddfafc4579ecb931 in atlas's branch 
refs/heads/branch-1.0 from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=52ba8b4 ]

ATLAS-3269: fixed basic-search handing of search for entities with 
no-classication

(cherry picked from commit 40081d4853ae9923e601f62c150c165f1cea902d)


> basic-search for entities with no-classifications and a search string returns 
> empty result
> --
>
> Key: ATLAS-3269
> URL: https://issues.apache.org/jira/browse/ATLAS-3269
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 1.2.0, 2.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3269.patch
>
>
> ATLAS-2775 introduced basic-search enhancements to search for entities having 
> no classification associated. However, such a search along with a free-text 
> search string, returns empty result. For example, search with 
> {{query=hive_table, classificationName=_NOT_CLASSIFIED}} returns empty 
> results, though Atlas has a number of hive_table entities having no 
> classification associated.
> Please note however that the search for entities having any classification 
> return correct results i.e {{query=hive_table, 
> classificationName=_CLASSIFIED}} 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70789/
---

(Updated June 7, 2019, 10:28 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, 
Sridhar K, Le Ma, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sarath 
Subramanian.


Changes
---

updated to address review comments.


Bugs: ATLAS-3262
https://issues.apache.org/jira/browse/ATLAS-3262


Repository: atlas


Description
---

- skipped full-text index computation & population when free-text is enabled
- added FreeTextRequestHandlerPatch to create /freetext request handler in Solr
- fixed free-text search handling of typeName filter


Diffs (updated)
-

  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
 edab08cc0 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
 18e6976a4 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphSolrIndexClient.java
 a55fc3689 
  graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
0d5ae4f84 
  intg/src/main/java/org/apache/atlas/ApplicationProperties.java 6d0153f7d 
  intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 0636677ae 
  
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
 c929d9a62 
  
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 
e4a315fce 
  
repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
 b1a84c742 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
50edb9faf 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
2e09beda0 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 56655a845 
  
repository/src/main/java/org/apache/atlas/repository/graph/IndexChangeListener.java
 9cde947aa 
  
repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java 
20a517ff1 
  
repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
 259f24674 
  
repository/src/main/java/org/apache/atlas/repository/patches/FreeTextRequestHandlerPatch.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 035b02ce4 
  
repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java
 1d296057b 


Diff: https://reviews.apache.org/r/70789/diff/4/

Changes: https://reviews.apache.org/r/70789/diff/3-4/


Testing
---

- verified that free-text handler is created by the patch for the first time 
this enhancement is applied in an existing env
- verified that the free-text search handles typeName filter correctly
- pre-commit tests run: 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1176/


Thanks,

Madhan Neethiraj

[jira] [Commented] (ATLAS-3262) disable full-text index population when free-text is enabled

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859025#comment-16859025
 ] 

ASF subversion and git services commented on ATLAS-3262:


Commit b9481410bb667c0297ec9fe84c4693f7aec8c4be in atlas's branch 
refs/heads/master from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=b948141 ]

ATLAS-3262: disabled full-text index population when free-text is enabled i.e. 
for Solr index store


> disable full-text index population when free-text is enabled
> 
>
> Key: ATLAS-3262
> URL: https://issues.apache.org/jira/browse/ATLAS-3262
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
>
> Free-text search introduced/updated in ATLAS-3100 and ATLAS-3246 uses Solr 
> index fields of entity attributes to perform text searches. When free-text 
> search is enabled (i.e. when Solr is the index backend), full-text collection 
> is not used, hence should not be updated during entity create/update. This is 
> likely to result in sizable time in processing notifications, in addition to 
> reducing the load on Solr.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ATLAS-3270) Enhance Atlas to have a new rest end point to get suggestions given a prefix string.

[Sridhar (JIRA)]

Sridhar created ATLAS-3270:
--

 Summary: Enhance Atlas to have a new rest end point to get 
suggestions given a prefix string.
 Key: ATLAS-3270
 URL: https://issues.apache.org/jira/browse/ATLAS-3270
 Project: Atlas
  Issue Type: Improvement
Reporter: Sridhar
Assignee: Sridhar






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ATLAS-3271) Investigate and fix test failures in atlas-distro module

[Sarath Subramanian (JIRA)]

Sarath Subramanian created ATLAS-3271:
-

 Summary: Investigate and fix test failures in atlas-distro module
 Key: ATLAS-3271
 URL: https://issues.apache.org/jira/browse/ATLAS-3271
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 2.0.0
Reporter: Sarath Subramanian
Assignee: Sarath Subramanian


Fix failing test:

{code}
==
FAIL: test_main_embedded (TestMetadata.TestMetadata)
--
Traceback (most recent call last):
  File 
"/home/jenkins/jenkins-slave/workspace/Atlas-master-AllTests/distro/src/test/mock/mock.py",
 line 1199, in patched
return func(*args, **keywargs)
  File 
"/home/jenkins/jenkins-slave/workspace/Atlas-master-AllTests/distro/src/test/python/scripts/TestMetadata.py",
 line 121, in test_main_embedded
runProcess_mock.assert_has_calls(calls)
  File 
"/home/jenkins/jenkins-slave/workspace/Atlas-master-AllTests/distro/src/test/mock/mock.py",
 line 861, in assert_has_calls
'Actual: %r' % (calls, self.mock_calls)
AssertionError: Calls not found.
Expected: [call(['atlas_home/hbase/bin/hbase-daemon.sh', '--config', 
'atlas_home/hbase/conf', 'start', 'master'], 'atlas_home/logs', False, True), 
call(['atlas_home/solr/bin/solr', 'start', '-z', 'localhost:9838', '-p', 
'9838'], 'atlas_home/logs', False, True), call(['atlas_home/solr/bin/solr', 
'create', '-c', 'vertex_index', '-d', 'atlas_home/conf/solr', '-shards', '1', 
'-replicationFactor', '1'], 'atlas_home/logs', False, True), 
call(['atlas_home/solr/bin/solr', 'create', '-c', 'edge_index', '-d', 
'atlas_home/conf/solr', '-shards', '1', '-replicationFactor', '1'], 
'atlas_home/logs', False, True), call(['atlas_home/solr/bin/solr', 'create', 
'-c', 'fulltext_index', '-d', 'atlas_home/conf/solr', '-shards', '1', 
'-replicationFactor', '1'], 'atlas_home/logs', False, True)]
Actual: [call(['atlas_home/hbase/bin/hbase-daemon.sh', '--config', 
'atlas_home/hbase/conf', 'start', 'master'], 'atlas_home/logs', False, True),
 call(['atlas_home/solr/bin/solr', 'start', '-z', 'localhost:9838', '-p', 
'9838'], 'atlas_home/logs', False, True),
 call(['atlas_home/solr/bin/solr', 'create', '-c', 'vertex_index', '-d', 
'atlas_home/solr/server/solr/configsets/_default/conf', '-shards', '1', 
'-replicationFactor', '1'], 'atlas_home/logs', False, True),
 call(['atlas_home/solr/bin/solr', 'create', '-c', 'edge_index', '-d', 
'atlas_home/solr/server/solr/configsets/_default/conf', '-shards', '1', 
'-replicationFactor', '1'], 'atlas_home/logs', False, True),
 call(['atlas_home/solr/bin/solr', 'create', '-c', 'fulltext_index', '-d', 
'atlas_home/solr/server/solr/configsets/_default/conf', '-shards', '1', 
'-replicationFactor', '1'], 'atlas_home/logs', False, True)]
{code}

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-3271) Investigate and fix test failures in atlas-distro module

[Sarath Subramanian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-3271:
--
Attachment: ATLAS-3271.001.patch

> Investigate and fix test failures in atlas-distro module
> 
>
> Key: ATLAS-3271
> URL: https://issues.apache.org/jira/browse/ATLAS-3271
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.0.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
> Attachments: ATLAS-3271.001.patch
>
>
> Fix failing test:
> {code}
> ==
> FAIL: test_main_embedded (TestMetadata.TestMetadata)
> --
> Traceback (most recent call last):
>   File 
> "/home/jenkins/jenkins-slave/workspace/Atlas-master-AllTests/distro/src/test/mock/mock.py",
>  line 1199, in patched
> return func(*args, **keywargs)
>   File 
> "/home/jenkins/jenkins-slave/workspace/Atlas-master-AllTests/distro/src/test/python/scripts/TestMetadata.py",
>  line 121, in test_main_embedded
> runProcess_mock.assert_has_calls(calls)
>   File 
> "/home/jenkins/jenkins-slave/workspace/Atlas-master-AllTests/distro/src/test/mock/mock.py",
>  line 861, in assert_has_calls
> 'Actual: %r' % (calls, self.mock_calls)
> AssertionError: Calls not found.
> Expected: [call(['atlas_home/hbase/bin/hbase-daemon.sh', '--config', 
> 'atlas_home/hbase/conf', 'start', 'master'], 'atlas_home/logs', False, True), 
> call(['atlas_home/solr/bin/solr', 'start', '-z', 'localhost:9838', '-p', 
> '9838'], 'atlas_home/logs', False, True), call(['atlas_home/solr/bin/solr', 
> 'create', '-c', 'vertex_index', '-d', 'atlas_home/conf/solr', '-shards', '1', 
> '-replicationFactor', '1'], 'atlas_home/logs', False, True), 
> call(['atlas_home/solr/bin/solr', 'create', '-c', 'edge_index', '-d', 
> 'atlas_home/conf/solr', '-shards', '1', '-replicationFactor', '1'], 
> 'atlas_home/logs', False, True), call(['atlas_home/solr/bin/solr', 'create', 
> '-c', 'fulltext_index', '-d', 'atlas_home/conf/solr', '-shards', '1', 
> '-replicationFactor', '1'], 'atlas_home/logs', False, True)]
> Actual: [call(['atlas_home/hbase/bin/hbase-daemon.sh', '--config', 
> 'atlas_home/hbase/conf', 'start', 'master'], 'atlas_home/logs', False, True),
>  call(['atlas_home/solr/bin/solr', 'start', '-z', 'localhost:9838', '-p', 
> '9838'], 'atlas_home/logs', False, True),
>  call(['atlas_home/solr/bin/solr', 'create', '-c', 'vertex_index', '-d', 
> 'atlas_home/solr/server/solr/configsets/_default/conf', '-shards', '1', 
> '-replicationFactor', '1'], 'atlas_home/logs', False, True),
>  call(['atlas_home/solr/bin/solr', 'create', '-c', 'edge_index', '-d', 
> 'atlas_home/solr/server/solr/configsets/_default/conf', '-shards', '1', 
> '-replicationFactor', '1'], 'atlas_home/logs', False, True),
>  call(['atlas_home/solr/bin/solr', 'create', '-c', 'fulltext_index', '-d', 
> 'atlas_home/solr/server/solr/configsets/_default/conf', '-shards', '1', 
> '-replicationFactor', '1'], 'atlas_home/logs', False, True)]
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-3271) Investigate and fix test failures in atlas-distro module

[Madhan Neethiraj (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859062#comment-16859062
 ] 

Madhan Neethiraj commented on ATLAS-3271:
-

+1 for the patch. Thanks Sarath!

> Investigate and fix test failures in atlas-distro module
> 
>
> Key: ATLAS-3271
> URL: https://issues.apache.org/jira/browse/ATLAS-3271
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.0.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
> Attachments: ATLAS-3271.001.patch
>
>
> Fix failing test:
> {code}
> ==
> FAIL: test_main_embedded (TestMetadata.TestMetadata)
> --
> Traceback (most recent call last):
>   File 
> "/home/jenkins/jenkins-slave/workspace/Atlas-master-AllTests/distro/src/test/mock/mock.py",
>  line 1199, in patched
> return func(*args, **keywargs)
>   File 
> "/home/jenkins/jenkins-slave/workspace/Atlas-master-AllTests/distro/src/test/python/scripts/TestMetadata.py",
>  line 121, in test_main_embedded
> runProcess_mock.assert_has_calls(calls)
>   File 
> "/home/jenkins/jenkins-slave/workspace/Atlas-master-AllTests/distro/src/test/mock/mock.py",
>  line 861, in assert_has_calls
> 'Actual: %r' % (calls, self.mock_calls)
> AssertionError: Calls not found.
> Expected: [call(['atlas_home/hbase/bin/hbase-daemon.sh', '--config', 
> 'atlas_home/hbase/conf', 'start', 'master'], 'atlas_home/logs', False, True), 
> call(['atlas_home/solr/bin/solr', 'start', '-z', 'localhost:9838', '-p', 
> '9838'], 'atlas_home/logs', False, True), call(['atlas_home/solr/bin/solr', 
> 'create', '-c', 'vertex_index', '-d', 'atlas_home/conf/solr', '-shards', '1', 
> '-replicationFactor', '1'], 'atlas_home/logs', False, True), 
> call(['atlas_home/solr/bin/solr', 'create', '-c', 'edge_index', '-d', 
> 'atlas_home/conf/solr', '-shards', '1', '-replicationFactor', '1'], 
> 'atlas_home/logs', False, True), call(['atlas_home/solr/bin/solr', 'create', 
> '-c', 'fulltext_index', '-d', 'atlas_home/conf/solr', '-shards', '1', 
> '-replicationFactor', '1'], 'atlas_home/logs', False, True)]
> Actual: [call(['atlas_home/hbase/bin/hbase-daemon.sh', '--config', 
> 'atlas_home/hbase/conf', 'start', 'master'], 'atlas_home/logs', False, True),
>  call(['atlas_home/solr/bin/solr', 'start', '-z', 'localhost:9838', '-p', 
> '9838'], 'atlas_home/logs', False, True),
>  call(['atlas_home/solr/bin/solr', 'create', '-c', 'vertex_index', '-d', 
> 'atlas_home/solr/server/solr/configsets/_default/conf', '-shards', '1', 
> '-replicationFactor', '1'], 'atlas_home/logs', False, True),
>  call(['atlas_home/solr/bin/solr', 'create', '-c', 'edge_index', '-d', 
> 'atlas_home/solr/server/solr/configsets/_default/conf', '-shards', '1', 
> '-replicationFactor', '1'], 'atlas_home/logs', False, True),
>  call(['atlas_home/solr/bin/solr', 'create', '-c', 'fulltext_index', '-d', 
> 'atlas_home/solr/server/solr/configsets/_default/conf', '-shards', '1', 
> '-replicationFactor', '1'], 'atlas_home/logs', False, True)]
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)